Re: [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node

2020-09-09 Thread Laurent Vivier
Le 10/09/2020 à 04:38, Pan Nengyuan a écrit : > 'str' is not used in match_interval_mapping_node(), remove it. > > Signed-off-by: Pan Nengyuan > --- > tests/test-vmstate.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c > index f8de709a0b..

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-09-09 Thread Collin Walling
On 9/10/20 2:38 AM, Cornelia Huck wrote: > On Wed, 9 Sep 2020 14:13:55 -0400 > Collin Walling wrote: > >> Has this been merged yet? There is one patch that I neglected to include >> in this series (I didn't realize it until now) that properly sets the >> SCCB size in QEMU based on the length prov

Re: [PATCH v2 2/2] arm64: kvm: Introduce MTE VCPU feature

2020-09-09 Thread Andrew Jones
On Wed, Sep 09, 2020 at 04:53:02PM +0100, Peter Maydell wrote: > On Wed, 9 Sep 2020 at 16:48, Andrew Jones wrote: > > We either need a KVM cap or a new CPU feature probing interface to avoid > > making userspace try features one at a time. It's too bad that VCPU_INIT > > doesn't clear all offendin

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-09-09 Thread Cornelia Huck
On Wed, 9 Sep 2020 14:13:55 -0400 Collin Walling wrote: > Has this been merged yet? There is one patch that I neglected to include > in this series (I didn't realize it until now) that properly sets the > SCCB size in QEMU based on the length provided by the kernel (right now, > these patches all

Re: [PATCH v2 0/2] MTE support for KVM guest

2020-09-09 Thread Andrew Jones
On Wed, Sep 09, 2020 at 05:04:15PM +0100, Steven Price wrote: > On 09/09/2020 16:25, Andrew Jones wrote: > > On Fri, Sep 04, 2020 at 05:00:16PM +0100, Steven Price wrote: > > > 2. Automatically promotes (normal host) memory given to the guest to be > > > tag enabled (sets PG_mte_tagged), if

[PATCH v5 5/7] misc: Add versal-usb2-regs module

2020-09-09 Thread Sai Pavan Boddu
This module emulates control registers of versal usb2 controller, this is added just to make guest happy. In general this module would control the phy-reset signal from usb controller, data coherency of the transactions, signals the host system errors received from controller. Signed-off-by: Sai P

[PATCH v5 4/7] usb: hcd-xhci-sysbus: Attach xhci to sysbus device

2020-09-09 Thread Sai Pavan Boddu
Use XHCI as sysbus device, add memory region property to get the address space instance for dma read/write. Signed-off-by: Sai Pavan Boddu --- hw/usb/Kconfig | 5 +++ hw/usb/hcd-xhci-sysbus.c | 99 hw/usb/hcd-xhci-sysbus.h | 32

[PATCH v5 3/7] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-09-09 Thread Sai Pavan Boddu
This patch sets the base to use xhci as sysbus model, for which pci specific hooks are moved to hcd-xhci-pci.c. As a part of this requirment msi/msix interrupts handling is moved under XHCIPCIState. Made required changes for qemu-xhci-nec. Signed-off-by: Sai Pavan Boddu fixup Signed-off-by: Sai

[PATCH v5 1/7] usb/hcd-xhci: Make dma read/writes hooks pci free

2020-09-09 Thread Sai Pavan Boddu
This patch starts making the hcd-xhci.c pci free, as part of this restructuring dma read/writes are handled without passing pci object. Signed-off-by: Sai Pavan Boddu --- hw/usb/hcd-xhci.c | 24 +++- hw/usb/hcd-xhci.h | 1 + 2 files changed, 12 insertions(+), 13 deletions(-)

[PATCH v5 6/7] usb: Add DWC3 model

2020-09-09 Thread Sai Pavan Boddu
From: Vikram Garhwal This patch adds skeleton model of dwc3 usb controller attached to xhci-sysbus device. It defines global register space of DWC3 controller, global registers control the AXI/AHB interfaces properties, external FIFO support and event count support. All of which are unimplemented

[PATCH v5 2/7] usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c

2020-09-09 Thread Sai Pavan Boddu
Move pci specific devices to new file. This set the environment to move all pci specific hooks in hcd-xhci.c to hcd-xhci-pci.c. Signed-off-by: Sai Pavan Boddu --- hw/usb/Kconfig| 6 + hw/usb/hcd-xhci-pci.c | 66 +++ hw/usb/hcd-xhci.c

[PATCH v5 7/7] Versal: Connect DWC3 controller with virt-versal

2020-09-09 Thread Sai Pavan Boddu
From: Vikram Garhwal Connect dwc3 controller and usb2-reg module to virt-versal. Configure it as dual port host controller. Signed-off-by: Vikram Garhwal Signed-off-by: Sai Pavan Boddu --- hw/arm/xlnx-versal-virt.c| 59 hw/arm/xlnx-versal.c

[PATCH v5 0/7] Make hcd-xhci independent of pci hooks

2020-09-09 Thread Sai Pavan Boddu
This patch series attempts to make 'hcd-xhci' an independent model so it can be used by both pci and system-bus interface. Changes for V2: Make XHCIState non-qom Use container_of functions for retriving pci device instance Initialize the AddressSpace pointer in PATCH 1/3 itself Changes

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-09 Thread Laurent Vivier
Could you try with the patch attached to bug 1823790? https://bugs.launchpad.net/qemu/+bug/1823790/+attachment/5405549/+files/SO_PEERGROUPS.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895053

[Bug 1895080] Re: pgb_reserved_va: Assertion `addr == test' failed

2020-09-09 Thread Laurent Vivier
** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895080 Title: pgb_reserved_va: Assertion `addr == test' failed Status in QEMU: New Bug description: This problem occur

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-09 Thread Laurent Vivier
** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895053 Title: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service. Status in QEMU: New Bug description:

[PATCH] vhost-blk: set features before setting inflight feature

2020-09-09 Thread Jin Yu
Virtqueue has split and packed, so before setting inflight, you need to inform the back-end virtqueue format. Signed-off-by: Jin Yu --- hw/block/vhost-user-blk.c | 6 ++ hw/virtio/vhost.c | 18 ++ include/hw/virtio/vhost.h | 1 + 3 files changed, 25 insertions(+) d

Re: [PATCH v2] configure: Do not intent to build WHPX on 32-bit host

2020-09-09 Thread Stefan Weil
Am 10.09.20 um 07:45 schrieb Philippe Mathieu-Daudé: > Hyper-V is available on 64-bit versions of Windows, > do not try to build its support on 32-bit versions. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Since v1: Handle MinGW automatic detection (Thomas, Stefan) > --- > configure | 5 +++

[PATCH v2] configure: Do not intent to build WHPX on 32-bit host

2020-09-09 Thread Philippe Mathieu-Daudé
Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions. Signed-off-by: Philippe Mathieu-Daudé --- Since v1: Handle MinGW automatic detection (Thomas, Stefan) --- configure | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/conf

Re: [PATCH v2 0/2] MTE support for KVM guest

2020-09-09 Thread Andrew Jones
On Wed, Sep 09, 2020 at 06:45:33PM -0700, Richard Henderson wrote: > On 9/9/20 8:25 AM, Andrew Jones wrote: > >> * Provide a KVM-specific method to extract the tags from guest memory. > >>This might also have benefits in terms of providing an easy way to > >>read bulk tag data from guest m

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-09 Thread Philippe Mathieu-Daudé
On 9/9/20 8:15 PM, Eduardo Habkost wrote: > Hi, > > Thanks for the patch, and sorry for taking so long to review > this. I'm finally getting to the patches that were postponed to > 5.2. Sorry I missed that patch too. Why restrict this to CPUClass, and not provide this feature to all ObjectClass

Re: [PATCH 7/8] tests/acceptance/boot_linux: Accept SSH pubkey

2020-09-09 Thread Philippe Mathieu-Daudé
On 9/9/20 8:40 PM, Max Reitz wrote: > Let download_cloudinit() take an optional pubkey, which subclasses of > BootLinux can pass through setUp(). > > Signed-off-by: Max Reitz Reviewed-by: Philippe Mathieu-Daudé > --- > tests/acceptance/boot_linux.py | 13 +++-- > 1 file changed, 7 ins

Re: [PATCH 1/4] docs: lift block-core.json rST header into parents

2020-09-09 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.09.2020 um 17:28 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 09.09.2020 um 14:10 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: [...] >> >> > There are orders that I can't get this way. >> >> >> >> You're right, ordering by first

Re: [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node

2020-09-09 Thread Thomas Huth
On 10/09/2020 04.38, Pan Nengyuan wrote: > 'str' is not used in match_interval_mapping_node(), remove it. > > Signed-off-by: Pan Nengyuan > --- > tests/test-vmstate.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c > index f8de709a0b..1c763

Re: [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node

2020-09-09 Thread Li Qiang
Pan Nengyuan 于2020年9月10日周四 上午10:39写道: > > 'str' is not used in match_interval_mapping_node(), remove it. > > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > tests/test-vmstate.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c >

[Bug 1895080] [NEW] pgb_reserved_va: Assertion `addr == test' failed

2020-09-09 Thread Hansni Bu
Public bug reported: This problem occurs on CentOS-7.5 (64-bit) with qemu-5.1.0, qemu head (commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a) for riscv32-linux- user. Firstly, compile fails: Compiling C object libqemu-riscv32-linux-user.fa.p/linux-user_strace.c.o ../qemu.git/linux-user/strace.c:12

[PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node

2020-09-09 Thread Pan Nengyuan
'str' is not used in match_interval_mapping_node(), remove it. Signed-off-by: Pan Nengyuan --- tests/test-vmstate.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index f8de709a0b..1c763015d0 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vm

Re: [PATCH] pci: advertise a page aligned ATS

2020-09-09 Thread Jason Wang
On 2020/9/9 下午11:43, Peter Xu wrote: On Wed, Sep 09, 2020 at 04:17:31PM +0800, Jason Wang wrote: After Linux kernel commit 61363c1474b1 ("iommu/vt-d: Enable ATS only if the device uses page aligned address."), ATS will be only enabled if device advertises a page aligned request. Unfortunately

Re: [PATCH v2 0/2] MTE support for KVM guest

2020-09-09 Thread Richard Henderson
On 9/9/20 8:25 AM, Andrew Jones wrote: >> * Provide a KVM-specific method to extract the tags from guest memory. >>This might also have benefits in terms of providing an easy way to >>read bulk tag data from guest memory (since the LDGM instruction >>isn't available at EL0). > > Maybe

Re: [PATCH 0/2] hw/net/opencores_eth: Trivial patches

2020-09-09 Thread Jason Wang
On 2020/9/10 上午2:00, Philippe Mathieu-Daudé wrote: On 9/2/20 2:26 PM, Philippe Mathieu-Daudé wrote: On 6/8/20 11:15 AM, Philippe Mathieu-Daudé wrote: Remove unnecessary mask, use #define instead of magic. Philippe Mathieu-Daudé (2): hw/net/opencores_eth: Use definitions instead of magic v

Re: [PATCH V2 for-5.2] hw/null-machine: Add the kvm_type() hook for MIPS

2020-09-09 Thread Huacai Chen
Hi, Thomas, On Wed, Sep 9, 2020 at 3:20 PM Thomas Huth wrote: > > On 09/09/2020 04.57, chen huacai wrote: > > Hi, all, > > > > On Wed, Sep 9, 2020 at 1:25 AM Thomas Huth wrote: > >> > >> On 24/08/2020 10.11, Huacai Chen wrote: > >>> MIPS has two types of KVM: TE & VZ, and TE is the default type.

Re: [PATCH v2 0/2] MTE support for KVM guest

2020-09-09 Thread Richard Henderson
On 9/4/20 9:00 AM, Steven Price wrote: > 3. Doesn't provide any new methods for the VMM to access the tags on > memory. ... > (3) may be problematic and I'd welcome input from those familiar with > VMMs. User space cannot access tags unless the memory is mapped with the > PROT_MTE flag. Howeve

Re: [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-09-09 Thread Haibo Xu
On Wed, 9 Sep 2020 at 17:34, Andrew Jones wrote: > > On Wed, Sep 09, 2020 at 03:51:14PM +0800, Haibo Xu wrote: > > > > + > > > > +if (spe) { > > > > +assert(ARM_CPU(cpu)->has_spe == ON_OFF_AUTO_ON); > > > > +if (kvm_irqchip_in_kernel()) { > > > > +

[REPORT] Nightly Performance Tests - Wednesday, September 9, 2020

2020-09-09 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-09 22:30:01 End Time (UTC) : 2020-09-09 23:03:07 Execution Time : 0:33:05.538923 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%. -

Re: [PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1

2020-09-09 Thread Paolo Bonzini
Il mer 9 set 2020, 22:11 罗勇刚(Yonggang Luo) ha scritto: > > > On Thu, Sep 10, 2020 at 4:08 AM Paolo Bonzini wrote: > >> >> >> Il mer 9 set 2020, 20:43 Yonggang Luo ha scritto: >> >>> So we can removal usage of unstable-keyval >>> >> >> Isn't it stable only on 0.56.0? >> >> Paolo >> > On Windows,

Re: [PULL v2] Block layer patches

2020-09-09 Thread Eric Blake
On 9/9/20 4:55 PM, Peter Maydell wrote: This fails 'make check' on NetBSD and OpenBSD: ./check: line 47: realpath: command not found ./check: line 60: /common.env: No such file or directory check: failed to source common.env (make sure the qemu-iotests are run from tests/qemu-iotests in the bu

[PATCH] oss-fuzz: move linker arg to fix coverage-build

2020-09-09 Thread Alexander Bulekov
The order of the add_project_link_arguments calls impacts which arguments are placed between --start-group and --end-group. OSS-Fuzz coverage builds seem to just add these to CFLAGS: -fprofile-instr-generate -fcoverage-mapping pthread -Wl,--no-as-needed --Wl,-ldl -Wl,-lm Wno-unused-command-line-arg

Re: [PULL v2] Block layer patches

2020-09-09 Thread Peter Maydell
On Tue, 8 Sep 2020 at 12:53, Kevin Wolf wrote: > > The following changes since commit 7c37270b3fbe3d034ba80e488761461676e21eb4: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20200904-pull-request' > into staging (2020-09-06 16:23:55 +0100) > > are available in the Git repository at:

Re: Meson can't recover from deletion of generated QAPI file(s)

2020-09-09 Thread Claudio Fontana
On 9/9/20 5:10 PM, Paolo Bonzini wrote: > On 09/09/20 17:05, Claudio Fontana wrote: >> Hmm, I still encounter problems: > > And another: > > diff --git a/tests/meson.build b/tests/meson.build > index 998e4c48f9..95789f43b3 100644 > --- a/tests/meson.build > +++ b/tests/meson.build > @@ -56,7 +56,

[Bug 1895053] [NEW] Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-09 Thread Petunia
Public bug reported: Hi, I'm using nspawn and asked the question @systemd-devel. They redirected me to you, guessing that nspawn calls a syscall or ioctl qemu isnt aware of and can't implement properly? They were like: "Sorry, that's not my department." ^^ Maybe you can reproduce the issue or h

RE: [EXTERNAL] Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host

2020-09-09 Thread Sunil Muthuswamy
Signed-off-by: Sunil Muthuswamy > Am 09.09.20 um 20:40 schrieb Thomas Huth: > > > On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote: > >> Hyper-V is available on 64-bit versions of Windows, > >> do not try to build its support on 32-bit versions. > >> > >> Signed-off-by: Philippe Mathieu-Daudé

Re: [RFC] QEMU as Xcode project on macOS

2020-09-09 Thread Liviu Ionescu
> On 9 Sep 2020, at 22:16, Peter Maydell wrote: > > ... You still need a Python 3.5 or better for the other scripts > QEMU has as part of its build process, so you will still > need a python other than the Apple /usr/bin/python to build > even if you have a standalone meson with its own python

Re: [PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1

2020-09-09 Thread Yonggang Luo
On Thu, Sep 10, 2020 at 4:08 AM Paolo Bonzini wrote: > > > Il mer 9 set 2020, 20:43 Yonggang Luo ha scritto: > >> So we can removal usage of unstable-keyval >> > > Isn't it stable only on 0.56.0? > > Paolo > On Windows, there is following warning: WARNING: Module unstable-keyval is now stable,

Re: [PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1

2020-09-09 Thread Paolo Bonzini
Il mer 9 set 2020, 20:43 Yonggang Luo ha scritto: > So we can removal usage of unstable-keyval > Isn't it stable only on 0.56.0? Paolo > Signed-off-by: Yonggang Luo > --- > meson.build | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/meson.build b/meson.buil

Re: [PATCH v5 06/11] riscv: Initial commit of OpenTitan machine

2020-09-09 Thread Palmer Dabbelt
On Wed, 09 Sep 2020 12:00:07 PDT (-0700), Peter Maydell wrote: On Wed, 9 Sep 2020 at 19:00, Alistair Francis wrote: On Tue, Sep 8, 2020 at 7:52 AM Peter Maydell wrote: > ...shouldn't the riscv64-softmmu config have CONFIG_OPENTITAN too? > The usual principle is that the 64-bit executable can

Re: [RFC] QEMU as Xcode project on macOS

2020-09-09 Thread Christian Schoenebeck
On Mittwoch, 9. September 2020 21:03:32 CEST Liviu Ionescu wrote: > > On 9 Sep 2020, at 21:56, Christian Schoenebeck > > wrote: > > > > ... However you would > > still be opted out from (4.) all those Xcode IDE features that make > > development such efficient. > > Could you elaborate? > > I th

Re: [PATCH v2] qcow2: Skip copy-on-write when allocating a zero cluster

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
27.08.2020 17:53, Alberto Garcia wrote: Since commit c8bb23cbdbe32f5c326365e0a82e1b0e68cdcd8a when a write request results in a new allocation QEMU first tries to see if the rest of the cluster outside the written area contains only zeroes. In that case, instead of doing a normal copy-on-write o

Re: [RFC] QEMU as Xcode project on macOS

2020-09-09 Thread Peter Maydell
On Wed, 9 Sep 2020 at 19:56, Christian Schoenebeck wrote: > Interesting! That would defuse the homebrew problematic. You still need a Python 3.5 or better for the other scripts QEMU has as part of its build process, so you will still need a python other than the Apple /usr/bin/python to build eve

Re: [PATCH v5 06/11] riscv: Initial commit of OpenTitan machine

2020-09-09 Thread Peter Maydell
On Wed, 9 Sep 2020 at 19:00, Alistair Francis wrote: > > On Tue, Sep 8, 2020 at 7:52 AM Peter Maydell wrote: > > ...shouldn't the riscv64-softmmu config have CONFIG_OPENTITAN too? > > The usual principle is that the 64-bit executable can run the > > 32-bit boards too. > > I didn't know that was t

[PATCH 09/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
Don't use error propagation in qcow2_get_specific_info(). For this refactor qcow2_get_bitmap_info_list, its current interface rather weird. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h| 4 ++-- block/qcow2-bitmap.c | 27 +-- block/qcow2.c

[PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
1. Drop extra error propagation 2. Set errp always on failure. Generic bdrv_open_driver supports driver functions which can return negative value and forget to set errp. That's a strange thing.. Let's improve qcow2_do_open to not behave this way. This allows to simplify code in qcow2_co_invalidate

Re: [RFC] QEMU as Xcode project on macOS

2020-09-09 Thread Liviu Ionescu
> On 9 Sep 2020, at 21:56, Christian Schoenebeck wrote: > > ... However you would > still be opted out from (4.) all those Xcode IDE features that make > development such efficient. Could you elaborate? I thought that a standalone meson can be used with any environment, it just reduces th

[PATCH 08/14] blockjob: return status from block_job_set_speed()

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
Better to return status together with setting errp. It allows to avoid error propagation in the caller. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/blockjob.h | 2 +- blockjob.c | 18 -- 2 files changed, 9 insertions(+), 11 deletions(-) diff --gi

[PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
It's better to return status together with setting errp. It makes possible to avoid error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h| 2 +- block/qcow2-bitmap.c | 13 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/block/qcow2

[PATCH 12/14] block/qcow2: read_cache_sizes: return status value

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
It's better to return status together with setting errp. It allows to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index c2cd9434cc..3

[PATCH 06/14] block/mirror: drop extra error propagation in commit_active_start()

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
Let's check return value of mirror_start_job to check for failure instead of local_err. Rename ret to job, as ret is usually integer variable. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/mirror.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/block/mi

[PATCH 03/14] block: check return value of bdrv_open_child and drop error propagation

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
This patch is generated by cocci script: @@ symbol bdrv_open_child, errp, local_err; expression file; @@ file = bdrv_open_child(..., -&local_err +errp ); - if (local_err) + if (!file) { ... - error_propagate(err

[PATCH 04/14] blockdev: fix drive_backup_prepare() missed error

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
We leak local_err and don't report failure to the caller. It's definitely wrong, let's fix. Signed-off-by: Vladimir Sementsov-Ogievskiy --- blockdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 36bef6b188..74259527c1 100644 --- a/blockdev.

[PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
It's simple to avoid error propagation in blk_log_writes_open(), we just need to refactor blk_log_writes_find_cur_log_sector() a bit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/blklogwrites.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a

[PATCH 01/14] block: return status from bdrv_append and friends

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
The recommended use of qemu error api assumes returning status together with setting errp and avoid void functions with errp parameter. Let's improve bdrv_append and some friends to reduce error-propagation overhead in further patches. Choose int return status, because bdrv_replace_node() has call

[PATCH 05/14] block: drop extra error propagation for bdrv_set_backing_hd

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
bdrv_set_backing_hd now returns status, let's use it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 9b624b2535..c5e3a1927e 100644 --- a/block.c +++ b/block.c @@ -3011,11 +3011,9 @@ int bdr

[PATCH 14/14] block/qed: bdrv_qed_do_open: deal with errp

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
Set errp always on failure. Generic bdrv_open_driver supports driver functions which can return negative value and forget to set errp. That's a strange thing.. Let's improve bdrv_qed_do_open to not behave this way. This allows to simplify code in bdrv_qed_co_invalidate_cache(). Signed-off-by: Vlad

[PATCH 02/14] block: use return status of bdrv_append()

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
Now bdrv_append returns status and we can drop all the local_err things around it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 5 + block/backup-top.c | 20 block/commit.c | 5 + block/mirror.c |

[PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
It's recommended for bool functions with errp to return true on success and false on failure. Non-standard interfaces don't help to understand the code. The change is also needed to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h| 3 ++- block/qco

[PATCH 00/14] block: deal with errp: part I

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
Hi all! I've start to apply scripts/coccinelle/errp-guard.cocci to block subsystem, but it turned out that in most cases error propagation can be simply avoided. So, here are some improvements to block layer error reporting to avoid error propagation. It's not complete, so its called part I, I do

Re: [RFC] QEMU as Xcode project on macOS

2020-09-09 Thread Christian Schoenebeck
On Mittwoch, 9. September 2020 20:13:55 CEST Daniel P. Berrangé wrote: > > On Mittwoch, 9. September 2020 15:40:05 CEST Daniel P. Berrangé wrote: > > > Ideally any xcode setup would just invoke whatever our standard > > > build tools are IMHO, so it has zero possibility of introducing > > > new bui

Re: [PATCH v6 08/25] tests: disable /char/stdio/* tests in test-char.c on win32

2020-09-09 Thread Yonggang Luo
On Thu, Sep 10, 2020 at 2:48 AM Thomas Huth wrote: > On 09/09/2020 20.42, Yonggang Luo wrote: > > These tests are blocking test-char to be finished. > > Disable them by using variable is_win32, so we doesn't > > need macro to open it. and easy recover those function > > latter. > > > > Signed-off

Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host

2020-09-09 Thread Stefan Weil
Am 09.09.20 um 20:40 schrieb Thomas Huth: > On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote: >> Hyper-V is available on 64-bit versions of Windows, >> do not try to build its support on 32-bit versions. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> configure | 3 +++ >> 1 file changed,

[PATCH v6 24/25] ci: Enable msys2 ci in cirrus

2020-09-09 Thread Yonggang Luo
Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be updated. There is no need of --cross-prefix, open mingw64.exe instead of msys2.exe then we don't need the --cross-prefix, besides

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-09 Thread Ani Sinha
On Sep 10, 2020, 00:00 +0530, Ani Sinha , wrote: > On Sep 9, 2020, 23:20 +0530, Julia Suvorova , wrote: > > On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha wrote: > > > > > > Cold plugged bridges are not hot unpluggable, even when their hotplug > > > property (acpi-pci-hotplug-with-bridge-support) is tur

[PATCH 8/8] tests/acceptance: Add virtiofs_submounts.py

2020-09-09 Thread Max Reitz
This test invokes several shell scripts to create a random directory tree full of submounts, and then check in the VM whether every submount has its own ID and the structure looks as expected. (Note that the test scripts must be non-executable, so Avocado will not try to execute them as if they we

[PATCH 6/8] virtiofsd: Announce sub-mount points

2020-09-09 Thread Max Reitz
Whenever we encounter a directory with an st_dev that differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so the guest can create a submount for it. Make this behavior optional, so submounts are only announced to the guest with the announce_submounts option. Some users may prefer

Re: [PATCH v6 08/25] tests: disable /char/stdio/* tests in test-char.c on win32

2020-09-09 Thread Thomas Huth
On 09/09/2020 20.42, Yonggang Luo wrote: > These tests are blocking test-char to be finished. > Disable them by using variable is_win32, so we doesn't > need macro to open it. and easy recover those function > latter. > > Signed-off-by: Yonggang Luo > --- > tests/test-char.c | 26 +++

[PATCH 4/8] virtiofsd: Add fuse_reply_attr_with_flags()

2020-09-09 Thread Max Reitz
The plain fuse_reply_attr() function does not allow setting fuse_attr.flags, so add this new function that does. Make fuse_reply_attr() a wrapper around it. Signed-off-by: Max Reitz --- tools/virtiofsd/fuse_lowlevel.h | 15 +++ tools/virtiofsd/fuse_lowlevel.c | 14 -- 2

[PATCH 7/8] tests/acceptance/boot_linux: Accept SSH pubkey

2020-09-09 Thread Max Reitz
Let download_cloudinit() take an optional pubkey, which subclasses of BootLinux can pass through setUp(). Signed-off-by: Max Reitz --- tests/acceptance/boot_linux.py | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/boot_linux.py b/tests/acceptanc

[PATCH 3/8] virtiofsd: Add attr_flags to fuse_entry_param

2020-09-09 Thread Max Reitz
fuse_entry_param is converted to fuse_attr on the line (by fill_entry()), so it should have a member that mirrors fuse_attr.flags. fill_entry() should then copy this fuse_entry_param.attr_flags to fuse_attr.flags. Signed-off-by: Max Reitz --- tools/virtiofsd/fuse_lowlevel.h | 5 + tools/vi

[PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1

2020-09-09 Thread Yonggang Luo
So we can removal usage of unstable-keyval Signed-off-by: Yonggang Luo --- meson.build | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index 0b1741557d..af34a85bec 100644 --- a/meson.build +++ b/meson.build @@ -1,14 +1,11 @@ -project('qemu',

[PATCH v6 08/25] tests: disable /char/stdio/* tests in test-char.c on win32

2020-09-09 Thread Yonggang Luo
These tests are blocking test-char to be finished. Disable them by using variable is_win32, so we doesn't need macro to open it. and easy recover those function latter. Signed-off-by: Yonggang Luo --- tests/test-char.c | 26 -- 1 file changed, 16 insertions(+), 10 deletio

[PATCH 5/8] virtiofsd: Store every lo_inode's parent_dev

2020-09-09 Thread Max Reitz
We want to detect mount points in the shared tree. We report them to the guest by setting the FUSE_ATTR_SUBMOUNT flag in fuse_attr.flags, but because the FUSE client will create a submount for every directory that has this flag set, we must do this only for the actual mount points. We can detect

[PATCH 2/8] virtiofsd: Announce FUSE_ATTR_FLAGS

2020-09-09 Thread Max Reitz
The fuse_attr.flags field is currently just initialized to 0, which is valid. Thus, there is no reason not to always announce FUSE_ATTR_FLAGS (when the kernel supports it). Signed-off-by: Max Reitz --- tools/virtiofsd/fuse_common.h | 8 tools/virtiofsd/fuse_lowlevel.c | 7 +++ 2

[PATCH 1/8] linux/fuse.h: Pull in from Linux

2020-09-09 Thread Max Reitz
Update the linux/fuse.h standard header from the kernel development tree that implements FUSE submounts. This adds the fuse_attr.flags field, the FUSE_ATTR_FLAGS INIT flag, and the FUSE_ATTR_SUBMOUNT flag for fuse_attr.flags. Signed-off-by: Max Reitz --- include/standard-headers/linux/fuse.h |

[PATCH 0/8] virtiofsd: Announce submounts to the guest

2020-09-09 Thread Max Reitz
RFC: https://www.redhat.com/archives/virtio-fs/2020-May/msg00024.html Branch: https://github.com/XanClic/qemu.git virtiofs-submounts-v2 Branch: https://git.xanclic.moe/XanClic/qemu.git virtiofs-submounts-v2 (Note that there is an accompanying Linux (kernel) series “fuse: Mirror virtio-fs submoun

Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host

2020-09-09 Thread Thomas Huth
On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote: > Hyper-V is available on 64-bit versions of Windows, > do not try to build its support on 32-bit versions. > > Signed-off-by: Philippe Mathieu-Daudé > --- > configure | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure b/conf

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-09 Thread Ani Sinha
On Sep 9, 2020, 23:20 +0530, Julia Suvorova , wrote: > On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha wrote: > > > > Cold plugged bridges are not hot unpluggable, even when their hotplug > > property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see > > the function acpi_pcihp_pc_no_hotpl

Re: [PATCH v2 14/21] cirrus: Building freebsd in a single short

2020-09-09 Thread Yonggang Luo
On Thu, Sep 10, 2020 at 2:16 AM Daniel P. Berrangé wrote: > On Wed, Sep 09, 2020 at 01:32:04PM -0400, Ed Maste wrote: > > On Wed, 9 Sep 2020 at 05:47, Yonggang Luo wrote: > > > > > > freebsd 1 hour limit not hit anymore > > > > > > Signed-off-by: Yonggang Luo > > > > Reviewed-by: Ed Maste > >

[PATCH] configure: Do not intent to build WHPX on 32-bit host

2020-09-09 Thread Philippe Mathieu-Daudé
Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions. Signed-off-by: Philippe Mathieu-Daudé --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 4231d56bcc0..4bd08f5469b 100755 --- a/configure +++ b/con

Re: [PATCH v2 14/21] cirrus: Building freebsd in a single short

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 01:32:04PM -0400, Ed Maste wrote: > On Wed, 9 Sep 2020 at 05:47, Yonggang Luo wrote: > > > > freebsd 1 hour limit not hit anymore > > > > Signed-off-by: Yonggang Luo > > Reviewed-by: Ed Maste > > > When its running properly, the consumed time are little, but when tests

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-09 Thread Eduardo Habkost
Hi, Thanks for the patch, and sorry for taking so long to review this. I'm finally getting to the patches that were postponed to 5.2. Comments and questions below: On Thu, Jun 11, 2020 at 10:47:55AM +0800, Robert Hoo wrote: > Complement versioned CPU model framework with the ability of marking

Re: [RFC] QEMU as Xcode project on macOS

2020-09-09 Thread Daniel P . Berrangé
> On Mittwoch, 9. September 2020 15:40:05 CEST Daniel P. Berrangé wrote: > > Ideally any xcode setup would just invoke whatever our standard > > build tools are IMHO, so it has zero possibility of introducing > > new build problems. > > Then you would not win anything on Mac. The problematic on ma

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-09-09 Thread Collin Walling
On 9/9/20 5:43 AM, Cornelia Huck wrote: > On Wed, 9 Sep 2020 10:46:23 +0200 > Cornelia Huck wrote: > >> On Wed, 9 Sep 2020 09:54:40 +0200 >> Christian Borntraeger wrote: >> >>> On 16.07.20 14:02, Cornelia Huck wrote: On Wed, 15 Jul 2020 12:26:20 -0400 Collin Walling wrote:

Re: [PATCH v2 05/21] tests: disable /char/stdio/* tests in test-char.c on win32

2020-09-09 Thread Yonggang Luo
On Wed, Sep 9, 2020 at 8:52 PM Daniel P. Berrangé wrote: > On Wed, Sep 09, 2020 at 05:46:01PM +0800, Yonggang Luo wrote: > > These tests are blocking test-char to be finished. > > Merge three #ifndef _WIN32 > > > > Signed-off-by: Yonggang Luo > > --- > > tests/test-char.c | 8 > > 1 fi

Re: [PATCH 0/2] hw/net/opencores_eth: Trivial patches

2020-09-09 Thread Philippe Mathieu-Daudé
On 9/2/20 2:26 PM, Philippe Mathieu-Daudé wrote: > On 6/8/20 11:15 AM, Philippe Mathieu-Daudé wrote: >> Remove unnecessary mask, use #define instead of magic. >> >> Philippe Mathieu-Daudé (2): >> hw/net/opencores_eth: Use definitions instead of magic values >> hw/net/opencores_eth: Remove unnec

Re: [PATCH v5 06/11] riscv: Initial commit of OpenTitan machine

2020-09-09 Thread Alistair Francis
On Tue, Sep 8, 2020 at 7:52 AM Peter Maydell wrote: > > On Thu, 28 May 2020 at 23:31, Alistair Francis > wrote: > > > > This adds a barebone OpenTitan machine to QEMU. > > > > Signed-off-by: Alistair Francis > > Reviewed-by: Bin Meng > > --- > > default-configs/riscv32-softmmu.mak | 1 + > >

Re: [PULL v2 13/15] hw/rx: Add RX GDB simulator

2020-09-09 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 9/7/20 3:13 PM, Peter Maydell wrote: > On Mon, 22 Jun 2020 at 20:20, Philippe Mathieu-Daudé wrote: >> >> From: Yoshinori Sato >> >> Add the RX machine internally simulated in GDB. > > Hi; Coverity points out a memory leak (CID 1432307) in this function: > >> +static void rx_gd

Re: [PATCH 13/43] tcg: Consolidate 3 bits into enum TCGTempKind

2020-09-09 Thread Philippe Mathieu-Daudé
On 9/9/20 2:16 AM, Richard Henderson wrote: > The temp_fixed, temp_global, temp_local bits are all related. > Combine them into a single enumeration. > > Reviewed-by: Alex Bennée Already reviewed: https://www.mail-archive.com/qemu-devel@nongnu.org/msg701705.html > Signed-off-by: Richard Henders

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-09 Thread Julia Suvorova
On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha wrote: > > Cold plugged bridges are not hot unpluggable, even when their hotplug > property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see > the function acpi_pcihp_pc_no_hotplug() (thanks Julia). However, with > the current implementaton,

Re: [PATCH 10/43] tcg: Remove TCG_TARGET_HAS_cmp_vec

2020-09-09 Thread Philippe Mathieu-Daudé
On 9/9/20 2:16 AM, Richard Henderson wrote: > The cmp_vec opcode is mandatory; this symbol is unused. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.h | 1 - > tcg/i386/tcg-target.h| 1 - > tcg/ppc/tcg-target.h | 1 - > 3 files changed, 3 deletions(-) Reviewed-by: P

[PATCH v2 0/1] hw/arm: versal-virt: Correct the tx/rx GEM clocks

2020-09-09 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This corrects the Ethernet tx/rx clocks in the generated DTB. Avoids a Linux kernel warning. Cheers, Edgar ChangeLog: v1 -> v2: * Fix commit message typo, I -> It Edgar E. Iglesias (1): hw/arm: versal-virt: Correct the tx/rx GEM clocks hw/arm/xlnx-versal-virt.c |

[PATCH v2 1/1] hw/arm: versal-virt: Correct the tx/rx GEM clocks

2020-09-09 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Correct the GEMs tx/rx clocks to use the 125Mhz fixed-clock. This matches the setup with the fixed-link 100Mbit PHY. It also avoids the following warnings from the Linux kernel driver: eth0: unable to generate target frequency: 12500 Hz Reviewed-by: Philippe Mathie

Re: [PATCH 06/43] tcg: Remove TCGOpDef.used

2020-09-09 Thread Philippe Mathieu-Daudé
On 9/9/20 2:16 AM, Richard Henderson wrote: > The last user of this field disappeared in f69d277ece4. > > Signed-off-by: Richard Henderson > --- > include/tcg/tcg.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h > index e8629b58c8..8804a8c4a2 10

  1   2   3   4   >