Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-06 Thread Cornelia Huck
On Thu, 6 Aug 2020 21:13:56 +0200 Paolo Bonzini wrote: > This the more or less final version of the Meson conversion. Due to > the sheer size of the series you have been CCed only on the cover > letter. > > The series reaches the point where Makefile.target and unnest-vars > can be removed, an

Re: [PATCH v13 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-08-06 Thread Vladimir Sementsov-Ogievskiy
06.08.2020 22:35, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary to_json() ... that returns a json-dumpable object with desired fields and their values. Extend it in subclass when

Re: [PATCH for-5.2 15/19] ftgmac100: Improve software reset

2020-08-06 Thread Cédric Le Goater
On 8/7/20 2:03 AM, Joel Stanley wrote: > On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: >> >> The software reset of the MAC needs a finer granularity. Not all >> registers are reseted and some setting in MACCR are kept. > > 'settings' > > This makes the software reset incorrect, but the po

Re: [RFC] checkpatch: detect missing changes to trace-events

2020-08-06 Thread Markus Armbruster
Claudio Fontana writes: > Signed-off-by: Claudio Fontana > --- > scripts/checkpatch.pl | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) > > We could do something similar to MAINTAINERS for trace-events, > ie warning about files added, moved, deleted if we don't see >

Re: [RFC PATCH 2/8] migration/dirtyrate: Add block_dirty_info to store dirtypage info

2020-08-06 Thread Zheng Chuan
On 2020/8/7 0:59, Dr. David Alan Gilbert wrote: > * Zheng Chuan (zhengch...@huawei.com) wrote: >> >> >> On 2020/8/5 0:28, Dr. David Alan Gilbert wrote: >>> * Chuan Zheng (zhengch...@huawei.com) wrote: From: Zheng Chuan Add block_dirty_info to store dirtypage info for each rambloc

Re: [PATCH for-5.2 12/19] ftgmac100: Change interrupt status when a DMA error occurs

2020-08-06 Thread Cédric Le Goater
On 8/7/20 1:51 AM, Joel Stanley wrote: > On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: >> >> The model uses today the "No transmit buffer unavailable" interrupt >> status which it is not appropriate. According to the Aspeed specs, no >> interrupts are raised in that case. An "AHB error" sta

Re: [RFC PATCH 0/8] *** A Method for evaluating dirty page rate ***

2020-08-06 Thread Zheng Chuan
On 2020/8/7 0:58, Dr. David Alan Gilbert wrote: > * Zheng Chuan (zhengch...@huawei.com) wrote: >> >> >> On 2020/8/5 0:19, Dr. David Alan Gilbert wrote: >>> * Chuan Zheng (zhengch...@huawei.com) wrote: From: Zheng Chuan >>> >>> Hi, >>> Sometimes it is neccessary to evaluate dirty page

Re: [PATCH for-5.2 10/19] ftgmac100: Fix interrupt status "Packet transmitted on ethernet"

2020-08-06 Thread Cédric Le Goater
On 8/7/20 1:47 AM, Joel Stanley wrote: > On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: >> >> The second field of the TX descriptor has a set of flags to choose >> when the transmit interrupt is raised : after the packet has been sent >> on the ethernet or after it has been moved into the TX

Re: [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence

2020-08-06 Thread Cédric Le Goater
On 8/7/20 1:42 AM, Joel Stanley wrote: > On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: >> >> BIT(0) of the ASPEED_SDHCI_INFO register is set by SW and polled until >> the bit is cleared by HW. Add definitions for the default value of >> this register and fix the reset sequence by clearing t

Re: [PATCH for-5.2 02/19] m25p80: Add support for mx25l25635f

2020-08-06 Thread Cédric Le Goater
On 8/7/20 12:55 AM, Joel Stanley wrote: > On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: >> >> The mx25l25635f is an extenstion of the mx25l25635e. It includes QPI >> support, 4-Byte Address Command Set and faster transfers. See this >> document for more details : >> >> https://www.macronix.

[Bug 1890775] Re: Aten USB to Serial bridge does not work with qemu under Windows 10

2020-08-06 Thread Laci
I forgot that the environment is Windows 10 64 bit. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890775 Title: Aten USB to Serial bridge does not work with qemu under Windows 10 Status in QEMU:

[Bug 1890775] [NEW] Aten USB to Serial bridge does not work with qemu under Windows 10

2020-08-06 Thread Laci
Public bug reported: I would like to use MSDOS 6.22 with qemu (unfortunatelly lot of our test programs has been written in dos). I tried to connect two laptop by RS232 port, one of the machine have a built-in serial port and run with native MSDOS 6.22 with 4.0 norton commander. Another machine

[PATCH for-5.2] hw/null-machine: Add the kvm_type() hook for MIPS

2020-08-06 Thread Huacai Chen
MIPS has two types of KVM: TE & VZ, and TE is the default type. Now, libvirt uses a null-machine to detect the kvm capability. In the MIPS case, it will return "KVM not supported" on a VZ platform by default. So, add the kvm_type() hook to the null-machine. This seems not a very good solution, but

[PATCH V7 for-5.2] hw/mips: Add Loongson-3 machine support (with KVM)

2020-08-06 Thread Huacai Chen
Add Loongson-3 based machine support, it use liointc as the interrupt controler and use GPEX as the pci controller. Currently it can only work with KVM, but we will add TCG support in future. As the machine model is not based on any exiting physical hardware, the name of the machine is "loongson3-

Re: Any reason VIRTQUEUE_MAX_SIZE is 1024? Can we increase this limit?

2020-08-06 Thread Jason Wang
On 2020/8/6 下午8:37, Stefan Hajnoczi wrote: On Wed, Aug 05, 2020 at 08:13:29AM -0400, Michael S. Tsirkin wrote: On Wed, Aug 05, 2020 at 01:11:07PM +0100, Stefan Hajnoczi wrote: On Thu, Jul 30, 2020 at 07:46:09AM +, Yajun Wu wrote: I'm doing iperf test on VIRTIO net through vhost-user(HW V

Re: [PATCH for-5.2 16/19] aspeed/sdmc: Perform memory training

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:38, Philippe Mathieu-Daudé wrote: > > @@ -206,6 +206,19 @@ static void aspeed_sdmc_reset(DeviceState *dev) > > > > /* Set ram size bit and defaults values */ > > s->regs[R_CONF] = asc->compute_conf(s, 0); > > + > > +/* > > + * PHY status: > > + * -

Re: [PATCH for-5.2 19/19] aspeed/smc: Open AHB window of the second chip of the AST2600 FMC controller

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > This change works around the HW default values to be able to test the > tacoma board with -kernel command line option. > > Signed-off-by: Cédric Le Goater Good fix. This was required for Tacoma when we had both flash chips enabled in the d

Re: [PATCH for-5.2 18/19] aspeed/sdmc: Simplify calculation of RAM bits

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > Changes in commit 533eb415df2e ("arm/aspeed: actually check RAM size") > introduced a 'valid_ram_sizes' array which can be used to compute the > associated bit field value encoding the RAM size. The field is simply > the index of the array.

Re: [RFC v3 26/71] target/riscv: rvv-1.0: update vext_max_elems() for load/store insns

2020-08-06 Thread Richard Henderson
On 8/6/20 3:46 AM, frank.ch...@sifive.com wrote: > +static inline uint32_t vext_max_elems(uint32_t desc, uint32_t esz, bool > is_ldst) > { > -return simd_maxsz(desc) << vext_lmul(desc); > +/* > + * As simd_desc support at most 256 bytes, the max vlen is 256 bits. > + * so vlen in

Re: [PATCH for-5.2 15/19] ftgmac100: Improve software reset

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > The software reset of the MAC needs a finer granularity. Not all > registers are reseted and some setting in MACCR are kept. 'settings' This makes the software reset incorrect, but the power on reset values correct. Was that your goal? If

Re: [PATCH for-5.2 14/19] ftgmac100: Fix integer overflow in ftgmac100_do_tx()

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > When inserting the VLAN tag in packets, memmove() can generate an > integer overflow for packets whose length is less than 12 bytes. > > Check length against the size of the ethernet header (14 bytes) to > avoid the crash and return FTGMAC10

Re: [PATCH for-5.2 13/19] ftgmac100: Check for invalid len and address before doing a DMA transfer

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > According to the Aspeed specs, no interrupts are raised in that case > but a "Tx-packets lost" status seems like a good modeling choice for > all implementations. It is covered by the Linux kernel. > > Cc: Frederic Konrad > Signed-off-by: C

Re: [PATCH for-5.2 12/19] ftgmac100: Change interrupt status when a DMA error occurs

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > The model uses today the "No transmit buffer unavailable" interrupt > status which it is not appropriate. According to the Aspeed specs, no > interrupts are raised in that case. An "AHB error" status seems like a > better modeling choice for

Re: [PATCH for-5.2 11/19] ftgmac100: Fix interrupt status "Packet moved to RX FIFO"

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > As we don't model the RX or TX FIFO, raise the "Packet moved to RX > FIFO" interrupt status bit as soon as we are handling a RX packet. > > Cc: Frederic Konrad > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley > --- > hw/net/

Re: [PATCH for-5.2 10/19] ftgmac100: Fix interrupt status "Packet transmitted on ethernet"

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > The second field of the TX descriptor has a set of flags to choose > when the transmit interrupt is raised : after the packet has been sent > on the ethernet or after it has been moved into the TX FIFO. But we > don't model that today. Does

Re: [PATCH for-5.2 09/19] ftgmac100: Fix registers that can be read

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > Receive Ring Base Address Register (RXR_BADR) and the Normal Priority > Transmit Receive Ring Base Address Register (NPTXR_BADR) can als be > read. > > Cc: Frederic Konrad > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley > --

Re: [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > BIT(0) of the ASPEED_SDHCI_INFO register is set by SW and polled until > the bit is cleared by HW. Add definitions for the default value of > this register and fix the reset sequence by clearing the RESET bit. This is mentioned in the datas

Re: [RFC v3 19/71] target/riscv: rvv-1.0: configure instructions

2020-08-06 Thread Richard Henderson
On 8/6/20 3:46 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Signed-off-by: Frank Chang > --- > target/riscv/insn_trans/trans_rvv.inc.c | 12 > target/riscv/vector_helper.c| 14 +- > 2 files changed, 21 insertions(+), 5 deletions(-) Reviewed-by:

Re: [PATCH for-5.2 07/19] aspeed/smc: Fix max_slaves of the legacy SMC device

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > The legacy controller only has one slave. > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley > --- > hw/ssi/aspeed_smc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/as

Re: [PATCH for-5.2 06/19] aspeed/smc: Fix MemoryRegionOps definition

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:23, Cédric Le Goater wrote: > > Unaligned access support is a leftover from the initial commit. There > is no such need on this device register mapping. Remove it. > > Cc: Michael S. Tsirkin > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley > --- > hw/ssi/a

Re: [PATCH for-5.2 05/19] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > From: erik-smit > > The BMC Firmware can be downloaded from : > > https://www.supermicro.com/en/products/motherboard/X11SSL-F > > Signed-off-by: erik-smit > Reviewed-by: Cédric Le Goater > [ clg: Modified commit log ] > Message-Id: <202

Re: [RFC v3 16/71] target/riscv: add fp16 nan-box check generator function

2020-08-06 Thread Richard Henderson
On 8/6/20 3:46 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > If a 16-bit input is not properly nanboxed, then the input is replaced > with the default qnan. > > Signed-off-by: Frank Chang > --- > target/riscv/translate.c | 10 ++ > 1 file changed, 10 insertions(+) The code

Re: [RFC v3 18/71] target/riscv: rvv-1.0: apply nanbox helper in opfvf_trans

2020-08-06 Thread Richard Henderson
On 8/6/20 3:46 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Signed-off-by: Frank Chang > --- > target/riscv/insn_trans/trans_rvv.inc.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) With patches 16 and 17 merged into here, Reviewed-by: Richard Henderson r~

Re: [PATCH for-5.2 03/19] m25p80: Add support for n25q512ax3

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > Datasheet available here : > > https://www.micron.com/-/media/client/global/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_512mb_1ce_3v_65nm.pdf > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley > --- > h

Re: [RFC v3 17/71] target/riscv: rvv:1.0: add translation-time nan-box helper function

2020-08-06 Thread Richard Henderson
On 8/6/20 3:46 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Add do_nanbox() helper function to utilize gen_check_nanbox_X() to > generate the NaN-boxed floating-point values based on SEW setting. > > Signed-off-by: Frank Chang > --- > target/riscv/insn_trans/trans_rvv.inc.c | 27 +

Re: [PATCH for-5.2 04/19] aspeed/scu: Fix valid access size on AST2400

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > The read access size of the SCU registers can be 1/2/4 bytes and write > is 4 bytes. Set the min access size to 1 byte to cover both read and > write operations on the AST2400 but keep the min access size of the > other SoCs to 4 bytes as th

Re: [PATCH for-5.2 02/19] m25p80: Add support for mx25l25635f

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > > The mx25l25635f is an extenstion of the mx25l25635e. It includes QPI > support, 4-Byte Address Command Set and faster transfers. See this > document for more details : > > https://www.macronix.com/Lists/ApplicationNote/Attachments/1892/AN020

Re: [RFC v3 15/71] target/riscv: introduce more imm value modes in translator functions

2020-08-06 Thread Richard Henderson
On 8/6/20 3:46 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Immediate value in translator function is extended not only > zero-extended and sign-extended but with more modes to be applicable > with multiple formats of vector instructions. > > * IMM_ZX: Zero-extended > * IMM_

Re: [qemu]: How to use qemu to run 64MB bmc image?

2020-08-06 Thread Joel Stanley
On Thu, 6 Aug 2020 at 15:12, Philippe Mathieu-Daudé wrote: > > On 8/6/20 3:54 PM, Cédric Le Goater wrote: > > Hello, > > > > On 8/6/20 3:58 AM, www wrote: > >> Hi Joel Stanley, Andrew Jeffery, Cédric Le Goater, > >> > >> How to modify it so that QEMU can run 64MB BMC image? > > > > You can increas

Re: [PULL 0/6] Improve gitlab-CI and fix a compiler warning

2020-08-06 Thread Alistair Francis
On Wed, Aug 5, 2020 at 5:58 AM Thomas Huth wrote: > > Hi Peter, > > the following changes since commit fd3cd581f9dcd11286daacaa5272e721c65aece8: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200804' into staging (2020-08-04 > 18:20:32 +0100) > > are available in

Re: [PATCH 001/143] tests: move socket_scm_helper back to tests/

2020-08-06 Thread Philippe Mathieu-Daudé
On 8/6/20 9:13 PM, Paolo Bonzini wrote: > This file is unrelated to qemu-iotests and was moved incorrectly > to tests/qtest/Makefile.include. > > Signed-off-by: Paolo Bonzini > --- > tests/Makefile.include | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/Makefile.include b/tests

Re: [PATCH 095/143] meson: convert hw/sd

2020-08-06 Thread Philippe Mathieu-Daudé
On 8/6/20 9:15 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs| 1 - > hw/meson.build | 1 + > hw/sd/Makefile.objs | 12 > hw/sd/meson.build | 12 > 4 files ch

Re: [PATCH 108/143] meson: convert hw/intc

2020-08-06 Thread Philippe Mathieu-Daudé
On 8/6/20 11:20 PM, Paolo Bonzini wrote: > > > Il gio 6 ago 2020, 23:02 Peter Maydell > ha scritto: > > On Thu, 6 Aug 2020 at 21:10, Paolo Bonzini > wrote: > > > > From: Marc-André Lureau

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-06 Thread Philippe Mathieu-Daudé
On 8/6/20 10:51 PM, Peter Maydell wrote: > On Thu, 6 Aug 2020 at 21:31, Philippe Mathieu-Daudé wrote: >> >> On 8/6/20 8:01 PM, Jiaxun Yang wrote: >>> 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: We only implement the Index[Store/Load]Tag from the 'cache' opcode. Instead of ignoring the

Re: [PATCH 108/143] meson: convert hw/intc

2020-08-06 Thread Paolo Bonzini
Il gio 6 ago 2020, 23:02 Peter Maydell ha scritto: > On Thu, 6 Aug 2020 at 21:10, Paolo Bonzini wrote: > > > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Signed-off-by: Paolo Bonzini > > Compared to: > > > -common-obj-$(CONFIG_HEATHROW_PIC) += heathrow_pic.o > > > +s

[Bug 1594394] Re: Using setreuid / setegid crashes x86_64 user-mode target

2020-08-06 Thread Steve Dodd
Sorry, heat is definitely getting to me - just realized this is an upstream bug, not an Ubuntu one! Ubuntu package version is 1:2.11+dfsg- 1ubuntu7.26. At some point I will look at building qemu from source, but won't be an immediate thing. Apologies for noise .. though if anyone knows off-hand tha

[PATCH 2/2] block/qcow: remove runtime opts

2020-08-06 Thread John Snow
Introduced by d85f4222b468, These were seemingly never used at all. Signed-off-by: John Snow --- block/qcow.c | 9 - 1 file changed, 9 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index e514a86fe5e..f8919a44d19 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -105,15 +105,6 @@ s

[PATCH 1/2] block/rbd: remove runtime_opts

2020-08-06 Thread John Snow
This saw its last use in 4bfb274165ba. Signed-off-by: John Snow --- block/rbd.c | 42 -- 1 file changed, 42 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 688074c64b7..171c67e3a01 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -341,48 +341,6 @@

[PATCH 0/2] block: remove stale runtime_opts

2020-08-06 Thread John Snow
John Snow (2): block/rbd: remove runtime_opts block/qcow: remove runtime opts block/qcow.c | 9 - block/rbd.c | 42 -- 2 files changed, 51 deletions(-) -- 2.26.2

[Bug 1594394] Re: Using setreuid / setegid crashes x86_64 user-mode target

2020-08-06 Thread Steve Dodd
(Need a "cd .." after the tar, doh.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1594394 Title: Using setreuid / setegid crashes x86_64 user-mode target Status in QEMU: New Bug description:

[Bug 1594394] Re: Using setreuid / setegid crashes x86_64 user-mode target

2020-08-06 Thread Steve Dodd
Sorry, lost your reply in amongst the chaos of my life! OK, quick test case (type at command line, don't run as script!), host arch is x86-64, you need qemu-user-static installed.. wget https://cloud-images.ubuntu.com/bionic/current/bionic-server-cloudimg-armhf-root.tar.xz sudo -s mkdir armcont c

[Bug 1594394] Re: Using setreuid / setegid crashes x86_64 user-mode target

2020-08-06 Thread Steve Dodd
Actually, this is possibly not the same bug. I will add to the list to investigate further.. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1594394 Title: Using setreuid / setegid crashes x86_64 use

Re: [PATCH 0/4] Refactor get_fpstatus_ptr() ready for AArch32 fp16

2020-08-06 Thread Richard Henderson
On 8/6/20 3:44 AM, Peter Maydell wrote: > Peter Maydell (4): > target/arm: Replace A64 get_fpstatus_ptr() with generic fpstatus_ptr() > target/arm: Make A32/T32 use new fpstatus_ptr() API > target/arm: Implement FPST_STD_F16 fpstatus > target/arm: Use correct FPST for VCMLA, VCADD on fp16

Re: [PATCH 108/143] meson: convert hw/intc

2020-08-06 Thread Peter Maydell
On Thu, 6 Aug 2020 at 21:10, Paolo Bonzini wrote: > > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini Compared to: > -common-obj-$(CONFIG_HEATHROW_PIC) += heathrow_pic.o > +softmmu_ss.add(when: 'CONFIG_HEATHROW_PIC', if_true: files('heathrow_pic.c'

Small error in blog post

2020-08-06 Thread Louis Cloete
Hi! I read your blog post http://blog.vmsplice.net/2020/08/why-qemu-should-move-from-c-to-rust.html I thought it was a well thought out exposition of the topic of "what shall we do to security vulnerabilities due to C bugs. Is Rust the answer". However, one small inaccuracy caught my eye. Rust d

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-06 Thread Peter Maydell
On Thu, 6 Aug 2020 at 21:31, Philippe Mathieu-Daudé wrote: > > On 8/6/20 8:01 PM, Jiaxun Yang wrote: > > 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: > >> We only implement the Index[Store/Load]Tag from the 'cache' opcode. > >> Instead of ignoring the other cache operations, report them as > >> u

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

2020-08-06 Thread Robert Foley
The comment around documenting the cpu_mutex fields and critical sections got us thinking and revisiting our locking assumptions in cpu_handle_interrupt. Initially we were thinking that removing the BQL from cpu_handle_interrupt meant that we needed to replace it with the cpu mutex to protect the

[PATCH v13 06/11] qcow2_format.py: pass cluster size to substructures

2020-08-06 Thread Andrey Shinkevich
The cluster size of an image is the QcowHeader class member and may be obtained by dependent extension structures such as Qcow2BitmapExt for further bitmap table details print. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2_format.py | 17

Re: [PATCH-for-5.2] target/mips: Report unimplemented cache() operations

2020-08-06 Thread Philippe Mathieu-Daudé
On 8/6/20 8:01 PM, Jiaxun Yang wrote: > 在 2020/8/6 下午8:26, Philippe Mathieu-Daudé 写道: >> We only implement the Index[Store/Load]Tag from the 'cache' opcode. >> Instead of ignoring the other cache operations, report them as >> unimplemented. > > Hmm, I don't think we have anything to do with Invali

[PATCH v13 04/11] qcow2_format.py: dump bitmap flags in human readable way.

2020-08-06 Thread Andrey Shinkevich
Introduce the class BitmapFlags that parses a bitmap flags mask. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2_format.py | 16 1 file changed, 16 insertions(+) diff --git a/te

Re: [Virtio-fs] virtio-fs performance

2020-08-06 Thread Vivek Goyal
On Tue, Aug 04, 2020 at 03:51:50PM +0800, Derek Su wrote: > Vivek Goyal 於 2020年7月28日 週二 下午11:27寫道: > > > > On Tue, Jul 28, 2020 at 02:49:36PM +0100, Stefan Hajnoczi wrote: > > > > I'm trying and testing the virtio-fs feature in QEMU v5.0.0. > > > > My host and guest OS are both ubuntu 18.04 with k

[PATCH v13 08/11] qcow2.py: Introduce '-j' key to dump in JSON format

2020-08-06 Thread Andrey Shinkevich
Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that follows. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-i

Re: [PATCH v1 04/21] target/avr: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-06 Thread Robert Foley
On Thu, 6 Aug 2020 at 14:37, Michael Rolnik wrote: > > Hi Robert. > > I am sorry but how can I apply it? following this what I get > > error: patch failed: accel/tcg/cpu-exec.c:558 > error: accel/tcg/cpu-exec.c: patch does not apply > error: patch failed: target/arm/helper.c:9808 > error: target/a

[PATCH v13 11/11] iotests: dump QCOW2 header in JSON in #303

2020-08-06 Thread Andrey Shinkevich
Extend the test case #303 by dumping QCOW2 image metadata in JSON format. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/303 | 3 ++ tests/qemu-iotests/303.out | 76 ++ 2 files changed, 79 insert

[PATCH v13 05/11] qcow2_format.py: Dump bitmap directory information

2020-08-06 Thread Andrey Shinkevich
Read and dump entries from the bitmap directory of QCOW2 image. Header extension: magic 0x23852875 (Bitmaps) ... Bitmap name bitmap-1 bitmap_table_offset 0xf bitmap_table_size 1 flags 0x2 (['auto']) type 1

[PATCH v13 03/11] qcow2_format.py: change Qcow2BitmapExt initialization method

2020-08-06 Thread Andrey Shinkevich
There are two ways to initialize a class derived from Qcow2Struct: 1. Pass a block of binary data to the constructor. 2. Pass the file descriptor to allow reading the file from constructor. Let's change the Qcow2BitmapExt initialization method from 1 to 2 to support a scattered reading in the initi

[PATCH v13 10/11] qcow2_format.py: support dumping metadata in JSON format

2020-08-06 Thread Andrey Shinkevich
Implementation of dumping QCOW2 image metadata. The sample output: { "Header_extensions": [ { "name": "Feature table", "magic": 1745090647, "length": 192, "data_str": "" }, { "name": "Bitmaps", "magi

[PATCH v13 01/11] iotests: add test for QCOW2 header dump

2020-08-06 Thread Andrey Shinkevich
The simple script creates a QCOW2 image and fills it with some data. Two bitmaps are created as well. Then the script reads the image header with extensions from the disk by running the script qcow2.py and dumps the information to the output. Other entities, such as snapshots, may be added to the t

[PATCH v13 07/11] qcow2_format.py: Dump bitmap table serialized entries

2020-08-06 Thread Andrey Shinkevich
Add bitmap table information to the QCOW2 metadata dump. Bitmap name bitmap-1 ... Bitmap table typesize offset 0 serialized 6553610092544 1 all-zeroes 00 2 all-zeroes 00 Signe

[PATCH v13 00/11] iotests: Dump QCOW2 dirty bitmaps metadata

2020-08-06 Thread Andrey Shinkevich
Add dirty bitmap information to QCOW2 metadata dump in the qcow2_format.py. v13: 01: Bitmaps are added without launching VM (suggested by Eric). The code amendments suggested by Vladimir. 07: Bitmap table entry size zeroed up for all types but serialized. 09: The extra dict variables r

[PATCH v13 02/11] qcow2_format.py: make printable data an extension class member

2020-08-06 Thread Andrey Shinkevich
Let us differ binary data type from string one for the extension data variable and keep the string as the QcowHeaderExtension class member. Signed-off-by: Andrey Shinkevich Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2_format.py | 14 ---

Acceptance Test BootLinuxAarch64.test_virt_tcg execution times

2020-08-06 Thread Cleber Rosa
TL;DR: This is a followup from an IRC chat about the tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_tcg test taking many orders of magnitute longer than other acceptance (and even similar boot) tests. I could not find an easy way for this specific test (aarch64+tcg) to have a significan

[PATCH 139/143] meson: convert sample plugins

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure| 4 tests/Makefile.include | 9 - tests/meson.build| 3 +++ tests/plugin/Makefile| 46 -- tests/plugin/meson.build | 7 +++ 5 files changed, 10 insertions(+),

[PATCH 133/143] remove Makefile.target

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile| 53 - Makefile.target | 12 configure | 2 -- 3 files changed, 4 insertions(+), 63 deletions(-) delete mode 100644 Makefile.target diff -

[PATCH 142/143] meson: convert po/

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 5 +--- configure | 2 +- meson.build| 3 +++ po/LINGUAS | 7 ++ po/Makefile| 52 - po/POTFILES| 1 + po/meson.build

[PATCH 131/143] meson: convert systemtap files

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 85 ++- meson.build | 26 + rules.mak | 3 -- trace/meson.build | 14 - 4 files changed, 35 i

[PATCH 134/143] meson: sphinx-build

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 142 +++-- configure | 1 - docs/index.html.in | 4 +- docs/meson.build | 68 + meson.build| 2 + rules.mak

[PATCH 140/143] meson: move SDL and SDL-image detection to meson

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- chardev/meson.build | 2 +- configure | 142 +++- meson.build | 24 ++--- meson_options.txt | 2 + ui/meson.build | 4 +- 5 files changed, 30 insertions(+), 144 deletions(-) creat

[PATCH 143/143] meson: update build-system documentation

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/build-system.txt | 373 ++-- 1 file changed, 185 insertions(+), 188 deletions(-) diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt index fea67b2..fb62cb2 100644 --- a/docs/devel/build-system.

[PATCH v13 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-08-06 Thread Andrey Shinkevich
As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary with desired fields and their values. Extend it in subclass when necessary to print the final dictionary in the JSON output which follows. Suggested-by: Vladimir

[PATCH 141/143] meson: convert VNC and dependent libraries to meson

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 122 ++ meson.build | 42 ++- meson_options.txt | 4 ++ ui/meson.build| 10 ++--- 4 files changed, 44 insertions(+), 134 deletions(-) diff --git a/configure b/co

[PATCH 121/143] meson: convert hw/acpi

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/acpi/Makefile.objs | 26 -- hw/acpi/meson.build | 25 + hw/meson.build| 1 + 4 files changed, 26 insertions(+),

[PATCH 138/143] meson: replace create-config with meson configure_file

2020-08-06 Thread Paolo Bonzini
Move the create-config logic to meson.build; create a configuration_data object and let meson handle the quoting and output. Signed-off-by: Paolo Bonzini --- Makefile | 2 +- block.c| 4 +- configure | 9 ++- meson.build

[PATCH 120/143] meson: convert hw/adc

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/adc/Makefile.objs | 1 - hw/adc/meson.build | 1 + hw/meson.build | 1 + 4 files changed, 2 insertions(+), 2 deletions(-) delete mode 100644 hw/adc/Makefile.objs c

[PATCH 132/143] rules.mak: remove version.o

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 5 - Makefile.objs | 4 rules.mak | 4 +--- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/Makefile b/Makefile index 1f89680..603869d 100644 --- a/Makefile +++

[PATCH 119/143] meson: convert hw/audio

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/audio/Makefile.objs | 18 -- hw/audio/meson.build | 14 ++ hw/meson.build | 1 + 4 files changed, 15 insertions(+), 19 deletions(-)

[PATCH 136/143] meson: convert check-block

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 18 ++ tests/meson.build | 4 tests/qemu-iotests/meson.build | 8 3 files changed, 14 insertions(+), 16 deletions(-) create mode 100644 tests/qemu-iotests/meson.build diff --git a/test

[PATCH 115/143] meson: convert hw/display

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 1 + hw/Makefile.objs | 1 - hw/display/Makefile.objs | 65 - hw/display/meson.build | 94 +++

[PATCH 130/143] meson: link emulators without Makefile.target

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- .gitlab-ci.yml| 4 +- Makefile | 34 +-- Makefile.objs | 32 --- Makefile.target | 153 +---

[PATCH 137/143] rules.mak: drop unneeded macros

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- .gitignore | 1 - Makefile| 7 +- configure | 32 +- docs/devel/build-system.txt | 5 +- rules.mak | 231 +--- scripts/create_config |

[PATCH 135/143] meson: build texi doc

2020-08-06 Thread Paolo Bonzini
Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 108 +++-- docs/interop/qemu-ga-ref.texi | 2 +- docs/interop/qemu-qmp-ref.texi | 2 +- meson.build| 85 +++

[PATCH 128/143] meson: cpu-emu

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 12 configure | 8 meson.build | 37 + scripts/feature_to_c.sh | 24

[PATCH 127/143] meson: bsd-user

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target| 3 --- bsd-user/Makefile.objs | 2 -- bsd-user/meson.build | 10 ++ meson.build| 4 4 files changed, 14 insertions(+), 5 deletions(-) delete mode 10

[PATCH 113/143] meson: convert hw/gpio

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/gpio/Makefile.objs | 12 hw/gpio/meson.build | 12 hw/meson.build| 1 + 4 files changed, 13 insertions(+), 13 deletions(-) delete mod

[PATCH 129/143] meson: plugins

2020-08-06 Thread Paolo Bonzini
For now link arguments end up in Makefile.target, they will move to the right place soon. Signed-off-by: Paolo Bonzini --- Makefile | 8 +--- Makefile.target | 12 ++-- meson.build | 5 + plugins/Makefile.objs | 21 - plugins/mes

[PATCH 118/143] meson: convert hw/block

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/block/Makefile.objs | 18 -- hw/block/dataplane/Makefile.objs | 2 -- hw/block/dataplane/meson.build | 2 ++ hw/block/meson.build

[PATCH 108/143] meson: convert hw/intc

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/intc/Makefile.objs | 54 -- hw/intc/meson.build | 55 +++ hw/meson.build

[PATCH 126/143] meson: linux-user

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 3 --- configure | 27 --- linux-user/Makefile.objs| 25 - linux-user/alpha/Mak

[PATCH 124/143] meson: target

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 3 +- libdecnumber/Makefile.objs | 5 --- libdecnumber/meson.build| 7 meson.build | 11 + scripts/decodetree.py |

[PATCH 125/143] meson: accel

2020-08-06 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.objs | 2 +- Makefile.target | 1 - accel/Makefile.objs | 6 -- accel/kvm/Makefile.objs | 2 -- accel/kvm/meson.build | 5 + accel/meson.build

  1   2   3   4   5   6   >