[qemu]: How to use qemu to run 64MB bmc image?

2020-08-05 Thread www
Hi Joel Stanley, Andrew Jeffery, Cédric Le Goater, How to modify it so that QEMU can run 64MB BMC image? In addition, how to learn the source code of QEMU? Are there any guidelines and reference documents? thanks, Byron

Re: [PATCH v2 7/7] target/riscv: check before allocating TCG temps

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:32 AM Richard Henderson < richard.hender...@linaro.org> wrote: > From: LIU Zhiwei > > Signed-off-by: LIU Zhiwei > Message-Id: <20200626205917.4545-5-zhiwei_...@c-sky.com> > Signed-off-by: Richard Henderson > --- > target/riscv/insn_trans/trans_rvd.inc.c | 8 >

Re: [PATCH v2 6/7] target/riscv: Clean up fmv.w.x

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > From: LIU Zhiwei > > Use tcg_gen_extu_tl_i64 to avoid the ifdef. > > Signed-off-by: LIU Zhiwei > Message-Id: <20200626205917.4545-7-zhiwei_...@c-sky.com> > Signed-off-by: Richard Henderson > --- > target

Re: [PATCH v2 5/7] target/riscv: Check nanboxed inputs in trans_rvf.inc.c

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > If a 32-bit input is not properly nanboxed, then the input is replaced > with the default qnan. The only inline expansion is for the sign-changing > set of instructions: FSGNJ.S, FSGNJX.S, FSGNJN.S. > > Sig

Re: [PATCH v2 4/7] target/riscv: Check nanboxed inputs to fp helpers

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:29 AM Richard Henderson < richard.hender...@linaro.org> wrote: > If a 32-bit input is not properly nanboxed, then the input is > replaced with the default qnan. > > Signed-off-by: Richard Henderson > --- > target/riscv/internals.h | 11 +++ > target/riscv/fpu_helpe

Re: [PATCH v2 3/7] target/riscv: Generate nanboxed results from trans_rvf.inc.c

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > Make sure that all results from inline single-precision scalar > operations are properly nan-boxed to 64-bits. > > Signed-off-by: Richard Henderson > --- > target/riscv/insn_trans/trans_rvf.inc.c | 4

Re: [PATCH v2 2/7] target/riscv: Generalize gen_nanbox_fpr to gen_nanbox_s

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > Do not depend on the RVD extension, take input and output via > TCGv_i64 instead of fpu regno. Move the function to translate.c > so that it can be used in multiple trans_*.inc.c files. > > Signed-off-by: R

Re: [for-5.2 v4 10/10] s390: Recognize host-trust-limitation option

2020-08-05 Thread David Gibson
On Mon, Jul 27, 2020 at 05:50:40PM +0200, Cornelia Huck wrote: > On Fri, 24 Jul 2020 12:57:44 +1000 > David Gibson wrote: > > > At least some s390 cpu models support "Protected Virtualization" (PV), > > a mechanism to protect guests from eavesdropping by a compromised > > hypervisor. > > > > Thi

Re: [PATCH v2 1/7] target/riscv: Generate nanboxed results from fp helpers

2020-08-05 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 2:06 PM LIU Zhiwei wrote: > > > On 2020/7/24 11:55, Richard Henderson wrote: > > On 7/23/20 7:35 PM, LIU Zhiwei wrote: > >> > >> On 2020/7/24 8:28, Richard Henderson wrote: > >>> Make sure that all results from single-precision scalar helpers > >>> are properly nan-boxed t

Re: [PATCH v5 0/2] add new options to set smbios type 4 fields

2020-08-05 Thread Michael S. Tsirkin
On Thu, Aug 06, 2020 at 11:56:32AM +0800, Ying Fang wrote: > From: fangying > > Hi, this patchset was previously posted by my teamate Heyi Guo several > months ago, however we missed the merge window. It is reposted here to > make it an end. Thanks. Thanks, I will tag it for after the release.

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: >> On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: >> > >> > The struct had a single field (IDEDevice dev), and is only used >> > in the QOM type declarations and property lists. We can simply >> > use

Re: [PATCH] spapr: Clarify error and documentation for broken KVM XICS

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 05:47:16PM +0200, Greg Kurz wrote: > When starting an L2 KVM guest with `ic-mode=dual,kernel-irqchip=on`, > QEMU fails with: > > KVM is too old to support ic-mode=dual,kernel-irqchip=on > > This error message was introduced to detect older KVM versions that > didn't allow

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 08:04:11PM +0100, Peter Maydell wrote: > On Wed, 5 Aug 2020 at 18:01, Thiago Jung Bauermann > wrote: > > Any news on this? Is there something I should be doing? I saw -rc3 today > > but not these patches. > > Sorry, you've missed the bus for 5.1 at this point. I'd assumed

Re: Adding VHOST_USER_PROTOCOL_F_CONFIG_MEM_SLOTS to 5.1 release notes

2020-08-05 Thread Michael S. Tsirkin
A bit verbose. I shortened it to A new feature, VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS, has been added to the vhost-user protocol. VMs with vhost-user device backends which support this feature will not be subject to the current max RAM slots limit of 8 and will be able to hot-add memory as man

Re: cleanups with long-term benefits

2020-08-05 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Aug 05, 2020 at 06:23:23PM +0200, Kevin Wolf wrote: >> We're basically weighing "git blame" against syntax highlighting >> defaults. I don't think the latter has an obviously higher weight. > > I think "syntax highlight defaults" is far from being an accurate > d

Re: [PATCH for-5.2 2/5] spapr/xive: Simplify kvmppc_xive_disconnect()

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:29PM +0200, Greg Kurz wrote: > Since this function begins with: > > /* The KVM XIVE device is not in use */ > if (!xive || xive->fd == -1) { > return; > } > > we obviously don't need to check xive->fd again. > > Signed-off-by: Greg Kurz Applied

Re: [PATCH for-5.2 1/5] spapr/xive: Fix xive->fd if kvm_create_device() fails

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:22PM +0200, Greg Kurz wrote: > If the creation of the KVM XIVE device fails for some reasons, the > negative errno ends up in xive->fd, but the rest of the code assumes > that xive->fd either contains an open fd, ie. positive value, or -1. > > This doesn't cause any m

Re: [PATCH for-5.2 4/5] spapr/xive: Convert KVM device fd checks to assert()

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:44PM +0200, Greg Kurz wrote: > All callers guard these functions with kvmppc_xive_in_kernel() or one > of its variants. Make it clear that these functions are only to be > called when the KVM XIVE device is active. > > Note that the check on xive is dropped in kvmppc_

Re: [PATCH for-5.2 5/5] spapr: Simplify error handling in spapr_phb_realize()

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:51PM +0200, Greg Kurz wrote: > The spapr_phb_realize() function has a local_err variable which > is used to: > > 1) check failures of spapr_irq_findone() and spapr_irq_claim() > > 2) prepend extra information to the error message > > Recent work from Markus Armbrust

Re: [PATCH for-5.2 3/5] ppc/xive: Introduce dedicated kvm_irqchip_in_kernel() wrappers

2020-08-05 Thread David Gibson
On Wed, Aug 05, 2020 at 07:35:37PM +0200, Greg Kurz wrote: > Calls to the KVM XIVE device are guarded by kvm_irqchip_in_kernel(). This > ensures that QEMU won't try to use the device if KVM is disabled or if > an in-kernel irqchip isn't required. > > When using ic-mode=dual with the pseries machin

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-05 Thread Markus Armbruster
John Snow writes: > On 8/5/20 3:36 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 8/4/20 4:03 AM, Markus Armbruster wrote: The pain of tweaking the parser is likely dwarved several times over by the pain of the flag day. >>> >>> You mention this often; I wonder if I misund

[PATCH v5 1/2] hw/smbios: add options for type 4 max-speed and current-speed

2020-08-05 Thread Ying Fang
Common VM users sometimes care about CPU speed, so we add two new options to allow VM vendors to present CPU speed to their users. Normally these information can be fetched from host smbios. Strictly speaking, the "max speed" and "current speed" in type 4 are not really for the max speed and curre

[PATCH v5 2/2] tests/bios-tables-test: add smbios cpu speed test

2020-08-05 Thread Ying Fang
Add smbios type 4 CPU speed check for we added new options to set smbios type 4 "max speed" and "current speed". The default value should be 2000 when no option is specified, just as the old version did. We add the test case to one machine of each architecture, though it doesn't really run on aarc

[PATCH v5 0/2] add new options to set smbios type 4 fields

2020-08-05 Thread Ying Fang
From: fangying Hi, this patchset was previously posted by my teamate Heyi Guo several months ago, however we missed the merge window. It is reposted here to make it an end. Thanks. Patch description: Common VM users sometimes care about CPU speed, so we add two new options to allow VM vendors

Re: Adding VHOST_USER_PROTOCOL_F_CONFIG_MEM_SLOTS to 5.1 release notes

2020-08-05 Thread Raphael Norwitz
ping On Wed, Jul 29, 2020 at 9:17 PM Raphael Norwitz wrote: > > How about something like: > "A new feature, VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS, has been > added to the vhost-user protocol which, when negotiated, changes the > way QEMU transmit memory regions to backend devices. Instead of

Re: [PATCH 0/2] Instruction set detection for clang.

2020-08-05 Thread Shu-Chun Weng
Ping: https://patchew.org/QEMU/cover.1595463707.git@google.com/ On Wed, Jul 22, 2020 at 5:27 PM Shu-Chun Weng wrote: > Currently when configuring QEMU with clang, AVX2, AVX512F, ATOMIC64, and > ATOMIC128 are all disabled because the detection code is GCC-only. With > these > two patches, I a

Re: [PATCH v2] linux-user: Add most IFTUN ioctls

2020-08-05 Thread Shu-Chun Weng
Ping: https://patchew.org/QEMU/20200723231020.769893-1-...@google.com/ On Thu, Jul 23, 2020 at 4:10 PM Shu-Chun Weng wrote: > The three options handling `struct sock_fprog` (TUNATTACHFILTER, > TUNDETACHFILTER, and TUNGETFILTER) are not implemented. Linux kernel > keeps a user space pointer in th

Re: [PATCH 0/6] fcntl, sockopt, and ioctl options

2020-08-05 Thread Shu-Chun Weng
Ping! Patchew: https://patchew.org/QEMU/cover.1595461447.git@google.com/ On Wed, Jul 22, 2020 at 5:19 PM Shu-Chun Weng wrote: > Hi Laurent, > > This is a series of 6 patches in 4 groups, putting into a single thread for > easier tracking. > > [PATCH 1/6] linux-user: Support F_ADD_SEALS and F

Re: vhost-user protocol feature negotiation

2020-08-05 Thread Michael S. Tsirkin
On Wed, Aug 05, 2020 at 03:13:06PM +, Alyssa Ross wrote: > Quoting from the definition of VHOST_USER_SET_PROTOCOL_FEATURES in > vhost-user.rst: > > > Only legal if feature bit ``VHOST_USER_F_PROTOCOL_FEATURES`` is present in > > ``VHOST_USER_GET_FEATURES``. > > > > .. Note:: > >Slave

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Eduardo Habkost
On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: > On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: > > > > The struct had a single field (IDEDevice dev), and is only used > > in the QOM type declarations and property lists. We can simply > > use the IDEDevice struct directly ins

[PATCH] block/vhdx: Support vhdx image only with 512 bytes logical sector size

2020-08-05 Thread Swapnil Ingle
block/vhdx uses qemu block layer where sector size is always 512 byte. This may have issues with 4K logical sector sized vhdx image. For e.g qemu-img convert on such images fails with following assert: $qemu-img convert -f vhdx -O raw 4KTest1.vhdx test.raw qemu-img: util/iov.c:388: qiov_slice: A

Re: [PATCH] target/arm: Delete unused ARM_FEATURE_CRC

2020-08-05 Thread Richard Henderson
On 8/5/20 2:08 PM, Peter Maydell wrote: > In commit 962fcbf2efe57231a9f5df we converted the uses of the > ARM_FEATURE_CRC bit to use the aa32_crc32 isar_feature test > instead. However we forgot to remove the now-unused definition > of the feature name in the enum. Delete it now. > > Signed-off-by

[PATCH] target/arm: Delete unused ARM_FEATURE_CRC

2020-08-05 Thread Peter Maydell
In commit 962fcbf2efe57231a9f5df we converted the uses of the ARM_FEATURE_CRC bit to use the aa32_crc32 isar_feature test instead. However we forgot to remove the now-unused definition of the feature name in the enum. Delete it now. Signed-off-by: Peter Maydell --- target/arm/cpu.h | 1 - 1 file

[ANNOUNCE] QEMU 5.1.0-rc3 is now available

2020-08-05 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 5.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-5.1.0-rc3.tar.xz http://down

Re: [PATCH v3 7/8] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-05 Thread Helge Deller
Hello Alexander, * Alexander Bulekov : > On 200804 2320, Helge Deller wrote: > > * Alexander Bulekov : > > > I applied this series and it fixes most of the problems I saw before. > > > I still see a few crashes - I made issues for them on launchpad: > > > https://bugs.launchpad.net/qemu/+bug/18903

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: > > The struct had a single field (IDEDevice dev), and is only used > in the QOM type declarations and property lists. We can simply > use the IDEDevice struct directly instead. > > Signed-off-by: Eduardo Habkost > @@ -327,7 +323,6 @@ static vo

[Bug 1890370] Re: Segfault in artist vram_bit_write

2020-08-05 Thread Helge Deller
** Changed in: qemu Assignee: (unassigned) => Helge Deller (hdeller) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890370 Title: Segfault in artist vram_bit_write Status in QEMU: Invalid

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

2020-08-05 Thread Thiago Jung Bauermann
Peter Maydell writes: > On Wed, 5 Aug 2020 at 18:01, Thiago Jung Bauermann > wrote: >> Any news on this? Is there something I should be doing? I saw -rc3 today >> but not these patches. > > Sorry, you've missed the bus for 5.1 at this point. I'd assumed > that the relevant bits of the patchset

Re: [PATCH v1 02/21] target/alpha: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
On Wed, 5 Aug 2020 at 15:18, Richard Henderson wrote: > > On 8/5/20 11:12 AM, Robert Foley wrote: > > @@ -299,8 +299,12 @@ void alpha_cpu_do_interrupt(CPUState *cs) > > { > > AlphaCPU *cpu = ALPHA_CPU(cs); > > CPUAlphaState *env = &cpu->env; > > -int i = cs->exception_index; > > - >

[PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Eduardo Habkost
The struct had a single field (IDEDevice dev), and is only used in the QOM type declarations and property lists. We can simply use the IDEDevice struct directly instead. Signed-off-by: Eduardo Habkost --- hw/ide/qdev.c | 25 + 1 file changed, 9 insertions(+), 16 deletion

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

2020-08-05 Thread Richard Henderson
On 8/5/20 11:12 AM, Robert Foley wrote: > This change removes the implied BQL from the cpu_handle_interrupt, > and cpu_handle_exception paths. This BQL acquire is being pushed > down into the per arch implementation. > > Signed-off-by: Robert Foley > --- > accel/tcg/cpu-exec.c | 19 +++--

Re: [PATCH v1 02/21] target/alpha: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Richard Henderson
On 8/5/20 11:12 AM, Robert Foley wrote: > @@ -299,8 +299,12 @@ void alpha_cpu_do_interrupt(CPUState *cs) > { > AlphaCPU *cpu = ALPHA_CPU(cs); > CPUAlphaState *env = &cpu->env; > -int i = cs->exception_index; > - > +int i; > +bool bql = !qemu_mutex_iothread_locked(); > +if

Re: v8.1M cpu emulation and target-arm feature-identification strategy

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 18:00, Richard Henderson wrote: > Older ones like XSCALE are obvious Looking at the XScale manual we could actually implement ARM_FEATURE_XSCALE as (cpu->midr & 0x == 0x6905) [Vendor=intel, arch=ARMv5TE], and ARM_FEATURE_IWMMXT as (cpu->midr & 0xe000 == 0x690

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 18:01, Thiago Jung Bauermann wrote: > Any news on this? Is there something I should be doing? I saw -rc3 today > but not these patches. Sorry, you've missed the bus for 5.1 at this point. I'd assumed that the relevant bits of the patchset would go into a PPC pullreq if it wa

Re: v8.1M cpu emulation and target-arm feature-identification strategy

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 18:00, Richard Henderson wrote: > I've always assumed we'd never get rid of all of them. > > Older ones like XSCALE are obvious, but I don't think there's a clear > indicator > for V{5,6,7,8} either. MIDR.Architecture lets you distinguish v4/v4T/v5/v5T/v5TE/v5TEJ/v6, and th

[RFC PATCH] travis.yml: Drop the default softmmu builds

2020-08-05 Thread Thomas Huth
The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore. Signed-off-by: Thomas Huth --- Well, ok, we do not test all the softmmu targets

[PATCH 2/2] travis.yml: Drop the Python 3.5 and 3.6 builds

2020-08-05 Thread Thomas Huth
Python 3.5 is already the default in Ubuntu Xenial (which we use for most jobs on Travis), and Python 3.6 is the default on Ubuntu Bionic (which we use for the s390x jobs on Travis for example already), so explicitely defining tests for Python 3.5 and 3.6 seems redundant. Signed-off-by: Thomas Hut

[PATCH v1 21/21] target/xtensa: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 16/21] target/rx: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 08/21] target/lm32: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 14/21] target/ppc: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 20/21] target/unicore32: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 18/21] target/sh4: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 19/21] target/sparc: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 07/21] target/i386: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 13/21] target/openrisc: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 05/21] target/cris: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 15/21] target/riscv: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 09/21] target/m68k: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 11/21] target/mips: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 12/21] target/nios2: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 06/21] target/hppa: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 10/21] target/microblaze: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 03/21] target/arm: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

2020-08-05 Thread Robert Foley
This change removes the implied BQL from the cpu_handle_interrupt, and cpu_handle_exception paths. This BQL acquire is being pushed down into the per arch implementation. Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(

[PATCH v1 00/21] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path

2020-08-05 Thread Robert Foley
The purpose of this change is to set the groundwork so that an arch could move towards removing the BQL from the cpu_handle_interrupt/exception paths. The BQL is a bottleneck in scaling to more cores. And this cpu_handle_interrupt/exception path is one of the key BQL users as measured by the QEMU

[PATCH v1 02/21] target/alpha: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

[PATCH v1 04/21] target/avr: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec

RE: [PATCH v2 4/4] net/colo: Match is-enabled probe to tracepoint

2020-08-05 Thread Zhang, Chen
> -Original Message- > From: Stefan Hajnoczi > Sent: Wednesday, August 5, 2020 6:53 PM > To: Zhang, Chen > Cc: Roman Bolshakov ; Li Zhijian > ; Jason Wang ; qemu- > de...@nongnu.org; Cameron Esfahani ; Philippe > Mathieu-Daudé ; Daniel Berrange > > Subject: Re: [PATCH v2 4/4] net/colo

Re: [PATCH for-5.2 0/5] spapr: Cleanups for XIVE and PHB

2020-08-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/159664891296.638781.18417631893299150932.st...@bahia.lan/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SC

[PATCH for-5.2 5/5] spapr: Simplify error handling in spapr_phb_realize()

2020-08-05 Thread Greg Kurz
The spapr_phb_realize() function has a local_err variable which is used to: 1) check failures of spapr_irq_findone() and spapr_irq_claim() 2) prepend extra information to the error message Recent work from Markus Armbruster highlighted we get better code when testing the return value of a functi

[PATCH for-5.2 4/5] spapr/xive: Convert KVM device fd checks to assert()

2020-08-05 Thread Greg Kurz
All callers guard these functions with kvmppc_xive_in_kernel() or one of its variants. Make it clear that these functions are only to be called when the KVM XIVE device is active. Note that the check on xive is dropped in kvmppc_xive_disconnect(). It really cannot be NULL since it comes from set_a

[PATCH for-5.2 3/5] ppc/xive: Introduce dedicated kvm_irqchip_in_kernel() wrappers

2020-08-05 Thread Greg Kurz
Calls to the KVM XIVE device are guarded by kvm_irqchip_in_kernel(). This ensures that QEMU won't try to use the device if KVM is disabled or if an in-kernel irqchip isn't required. When using ic-mode=dual with the pseries machine, we have two possible interrupt controllers: XIVE and XICS. The kvm

[PATCH for-5.2 2/5] spapr/xive: Simplify kvmppc_xive_disconnect()

2020-08-05 Thread Greg Kurz
Since this function begins with: /* The KVM XIVE device is not in use */ if (!xive || xive->fd == -1) { return; } we obviously don't need to check xive->fd again. Signed-off-by: Greg Kurz --- hw/intc/spapr_xive_kvm.c |6 ++ 1 file changed, 2 insertions(+), 4 deletio

[PATCH for-5.2 1/5] spapr/xive: Fix xive->fd if kvm_create_device() fails

2020-08-05 Thread Greg Kurz
If the creation of the KVM XIVE device fails for some reasons, the negative errno ends up in xive->fd, but the rest of the code assumes that xive->fd either contains an open fd, ie. positive value, or -1. This doesn't cause any misbehavior except kvmppc_xive_disconnect() that will try to close(xiv

[PATCH for-5.2 0/5] spapr: Cleanups for XIVE and PHB

2020-08-05 Thread Greg Kurz
Recent cleanup patch "spapr: Simplify error handling in spapr_phb_realize" had to be dropped from ppc-for-5.2 because it would cause QEMU to crash at init time on some POWER9 setups (eg. Boston systems), as reported by Daniel. The crash was happening because the kvmppc_xive_source_reset_one() func

Re: [PATCH v12 11/11] iotests: dump QCOW2 header in JSON in #303

2020-08-05 Thread Vladimir Sementsov-Ogievskiy
30.07.2020 17:15, Andrey Shinkevich wrote: Extend the test case #303 by dumping QCOW2 image metadata in JSON format. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v12 10/11] qcow2_format.py: support dumping metadata in JSON format

2020-08-05 Thread Vladimir Sementsov-Ogievskiy
30.07.2020 17:15, Andrey Shinkevich wrote: Implementation of dumping QCOW2 image metadata. The sample output: { "Header_extensions": [ { "name": "Feature table", "magic": 1745090647, "length": 192, "data_str": "" },

Re: [RFC v3 0/8] QEMU cpus.c refactoring part2

2020-08-05 Thread Claudio Fontana
On 8/3/20 1:48 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> Motivation and higher level steps: >> >> https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html >> >> The biggest open item for me is, does it makes sense to: >> >> >> 1) make icount TCG-only (building the icount

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

2020-08-05 Thread Thiago Jung Bauermann
Thiago Jung Bauermann writes: > Philippe Mathieu-Daudé writes: > >> Le jeu. 30 juil. 2020 03:00, David Gibson a >> écrit : >> >>> On Tue, Jul 28, 2020 at 09:56:36PM -0300, Thiago Jung Bauermann wrote: >>> > >>> > Thiago Jung Bauermann writes: >>> > >>> > > The ARM code has a start-powered-of

Re: v8.1M cpu emulation and target-arm feature-identification strategy

2020-08-05 Thread Richard Henderson
On 8/5/20 9:52 AM, Peter Maydell wrote: > On Wed, 5 Aug 2020 at 17:45, Alex Bennée wrote: >> I wouldn't test other feature bits but what stopping us adding: >> >> struct ARMISARegisters { >> uint32_t id_isar0; >> ... >> uint64_t id_aa64dfr1; >> /* >> *

Re: [PATCH v12 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-08-05 Thread Vladimir Sementsov-Ogievskiy
30.07.2020 17:15, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary with desired fields and their values. Extend it in subclass when necessary to print the final dictionary in the JSON o

Re: v8.1M cpu emulation and target-arm feature-identification strategy

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 17:45, Alex Bennée wrote: > I wouldn't test other feature bits but what stopping us adding: > > struct ARMISARegisters { > uint32_t id_isar0; > ... > uint64_t id_aa64dfr1; > /* > * The following are synthetic flags for features not

[Bug 1879587] Re: Register number in ESR is incorrect for certain banked registers when switching from AA32 to AA64

2020-08-05 Thread Peter Maydell
** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879587 Title: Register number in ESR is incorrect for certain banked registers when

Re: [RFC v2 50/76] target/riscv: rvv-0.9: single-width saturating add and subtract instructions

2020-08-05 Thread Richard Henderson
On 8/3/20 7:40 PM, Frank Chang wrote: > This isn't what spike does. > > The manual could really stand to be more specific here... > > Isn't Spike's vsaddu.vi immediate value also > signed-extended?  > /riscv/insns/vsaddu_vi.h:/ > /vd = vs2 + (insn.v_simm5() & (UINT64_M

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-08-05 Thread Igor Mammedov
On Wed, 5 Aug 2020 08:01:24 +0200 Philippe Mathieu-Daudé wrote: > On 8/5/20 7:56 AM, Philippe Mathieu-Daudé wrote: > > On 3/19/20 11:02 AM, Paolo Bonzini wrote: > >> On 19/03/20 10:42, Philippe Mathieu-Daudé wrote: > >>> On 3/19/20 10:36 AM, Paolo Bonzini wrote: > On 18/03/20 23:15, Ph

Re: cleanups with long-term benefits

2020-08-05 Thread Eduardo Habkost
On Wed, Aug 05, 2020 at 06:23:23PM +0200, Kevin Wolf wrote: > Am 05.08.2020 um 12:08 hat Daniel P. Berrangé geschrieben: > > On Wed, Aug 05, 2020 at 11:11:55AM +0200, Cornelia Huck wrote: > > > On Wed, 5 Aug 2020 10:05:40 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Wed, Aug 05, 2020

Re: v8.1M cpu emulation and target-arm feature-identification strategy

2020-08-05 Thread Alex Bennée
Richard Henderson writes: > On 8/5/20 4:08 AM, Peter Maydell wrote: >> Mostly recently we've been aiming for QEMU emulation code in >> target/arm to use ID register fields to determine whether a >> feature is present or not (the isar_feature_* functions) rather >> than the old style of defining

Re: [PATCH v2 3/3] aio-posix: keep aio_notify_me disabled during polling

2020-08-05 Thread Paolo Bonzini
On 05/08/20 12:00, Stefan Hajnoczi wrote: > + > +/* > + * aio_notify can avoid the expensive event_notifier_set if > + * everything (file descriptors, bottom halves, timers) will > + * be re-evaluated before the next blocking poll(). This is > + * already tr

Re: [PATCH v2 for-5.1?] target/arm: Fix Rt/Rt2 in ESR_ELx for copro traps from AArch32 to 64

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 16:26, Richard Henderson wrote: > > On 8/4/20 12:39 PM, Peter Maydell wrote: > > When a coprocessor instruction in an AArch32 guest traps to AArch32 > > Hyp mode, the syndrome register (HSR) includes Rt and Rt2 fields > > which are simply copies of the Rt and Rt2 fields from

Re: [PATCH] spapr: Clarify error and documentation for broken KVM XICS

2020-08-05 Thread Cédric Le Goater
On 8/5/20 5:47 PM, Greg Kurz wrote: > When starting an L2 KVM guest with `ic-mode=dual,kernel-irqchip=on`, > QEMU fails with: > > KVM is too old to support ic-mode=dual,kernel-irqchip=on > > This error message was introduced to detect older KVM versions that > didn't allow destruction and re-crea

Re: [PATCH v2 2/3] async: always set ctx->notified in aio_notify()

2020-08-05 Thread Paolo Bonzini
On 05/08/20 12:00, Stefan Hajnoczi wrote: > aio_notify() does not set ctx->notified when called with > ctx->aio_notify_me disabled. Therefore aio_notify_me needs to be enabled > during polling. > > This is suboptimal since expensive event_notifier_set(&ctx->notifier) > and event_notifier_test_and_

Re: cleanups with long-term benefits

2020-08-05 Thread Kevin Wolf
Am 05.08.2020 um 12:08 hat Daniel P. Berrangé geschrieben: > On Wed, Aug 05, 2020 at 11:11:55AM +0200, Cornelia Huck wrote: > > On Wed, 5 Aug 2020 10:05:40 +0100 > > Daniel P. Berrangé wrote: > > > > > On Wed, Aug 05, 2020 at 10:49:35AM +0200, Paolo Bonzini wrote: > > > > On 05/08/20 10:39, Dr.

Re: v8.1M cpu emulation and target-arm feature-identification strategy

2020-08-05 Thread Richard Henderson
On 8/5/20 4:08 AM, Peter Maydell wrote: > Mostly recently we've been aiming for QEMU emulation code in > target/arm to use ID register fields to determine whether a > feature is present or not (the isar_feature_* functions) rather > than the old style of defining ARM_FEATURE_* flags. This seems to

Re: [PATCH v12 08/11] qcow2.py: Introduce '-j' key to dump in JSON format

2020-08-05 Thread Vladimir Sementsov-Ogievskiy
30.07.2020 17:15, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that follows. Signed-off-by: Andrey Shinkevich Reviewed-by: V

Re: [PATCH-for-5.1 v3 1/2] exec: Restrict icount to softmmu

2020-08-05 Thread Richard Henderson
On 8/5/20 3:01 AM, Philippe Mathieu-Daudé wrote: > 'icount' feature is only meaningful when using softmmu. > Move it out of the globally used exec.c, and define it as > 'false' in user-mode emulation. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/cpus.h | 4 > exec.c

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-05 Thread John Snow
On 8/5/20 3:36 AM, Markus Armbruster wrote: John Snow writes: On 8/4/20 4:03 AM, Markus Armbruster wrote: The pain of tweaking the parser is likely dwarved several times over by the pain of the flag day. You mention this often; I wonder if I misunderstand the critique, because the pain of a

[Bug 1890290] Re: PowerPC L2(nested virt) kvm guest fails to boot with ic-mode=dual, kernel-irqchip=on - `KVM is too old to support ic-mode=dual, kernel-irqchip=on`

2020-08-05 Thread Greg Kurz
Posted a patch to the list. http://patchwork.ozlabs.org/project/qemu- devel/patch/159664243614.622889.18307368735989783528.st...@bahia.lan/ Satheesh, Can you please review and test ? ** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Greg

Re: [PATCH v12 07/11] qcow2_format.py: Dump bitmap table serialized entries

2020-08-05 Thread Vladimir Sementsov-Ogievskiy
30.07.2020 17:15, Andrey Shinkevich wrote: Add bitmap table information to the QCOW2 metadata dump. Bitmap name bitmap-1 ... Bitmap table typesize offset 0 serialized 6553610092544 1 all-zeroes 655360 For s

  1   2   3   >