Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-03 Thread Stefan Weil
Am 04.08.20 um 08:43 schrieb Thomas Huth: > On 03/08/2020 22.25, Stefan Weil wrote: >> We can add a CI pipeline on Microsoft infrastructure by using a GitHub >> action. > Sorry for being ignorant, but how does that solve the legal questions > just because it is running on GitHub instead of a diffe

Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-03 Thread Thomas Huth
On 03/08/2020 22.25, Stefan Weil wrote: > Am 03.08.20 um 13:28 schrieb Stefan Weil: > >> Am 03.08.20 um 12:51 schrieb Philippe Mathieu-Daudé: >> >>> Hi Sunil, >>> >>> On 8/1/20 1:31 AM, Sunil Muthuswamy wrote: The ask generally sounds reasonable. But, can you help me understand the full

[PULL 1/2] colo-compare: Remove superfluous NULL-pointer checks for s->iothread

2020-08-03 Thread Jason Wang
From: Lukas Straub s->iothread is checked for NULL on object creation in colo_compare_complete, so it's guaranteed not to be NULL. This resolves a false alert from Coverity (CID 1429969). Signed-off-by: Lukas Straub Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Reviewed-by: Zhang

[PULL 2/2] hw/net/net_tx_pkt: fix assertion failure in net_tx_pkt_add_raw_fragment()

2020-08-03 Thread Jason Wang
From: Mauro Matteo Cascella An assertion failure issue was found in the code that processes network packets while adding data fragments into the packet context. It could be abused by a malicious guest to abort the QEMU process on the host. This patch replaces the affected assert() with a conditio

[PULL 0/2] Net patches

2020-08-03 Thread Jason Wang
The following changes since commit 5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200803' into staging (2020-08-03 20:34:26 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tag

Re: [PATCH 4/7] spice: Make spice a module configuration

2020-08-03 Thread Gerd Hoffmann
On Thu, Jul 23, 2020 at 07:46:12PM +0200, Christophe de Dinechin wrote: > This commit changes the spice configuration 'm' by default, and moves > the spice components to obj-m variables. It is sufficient to build > without modules enable, but does not link correctly yet, since no > shims have been

Re: [PATCH 3/7] minikconf: Pass variables for modules

2020-08-03 Thread Gerd Hoffmann
On Thu, Jul 23, 2020 at 07:46:11PM +0200, Christophe de Dinechin wrote: > Signed-off-by: Christophe de Dinechin > --- > scripts/minikconf.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/minikconf.py b/scripts/minikconf.py > index bcd91015d3..d60add97f6 100

Re: [PATCH] colo-compare: Remove superfluous NULL-pointer checks for s->iothread

2020-08-03 Thread Jason Wang
On 2020/7/31 下午1:06, Lukas Straub wrote: s->iothread is checked for NULL on object creation in colo_compare_complete, so it's guaranteed not to be NULL. This resolves a false alert from Coverity (CID 1429969). Signed-off-by: Lukas Straub --- net/colo-compare.c | 8 ++-- 1 file changed,

Re: [PATCH v2] hw/net/net_tx_pkt: fix assertion failure in net_tx_pkt_add_raw_fragment()

2020-08-03 Thread Jason Wang
On 2020/8/2 上午12:42, Mauro Matteo Cascella wrote: An assertion failure issue was found in the code that processes network packets while adding data fragments into the packet context. It could be abused by a malicious guest to abort the QEMU process on the host. This patch replaces the affected

Re: qapi-schema esotera

2020-08-03 Thread Markus Armbruster
John Snow writes: > On 8/3/20 1:25 PM, Eric Blake wrote: >> On 8/3/20 11:49 AM, John Snow wrote: >>> UNION is split into two primary forms: >>> >>> 1. Simple (No discriminator nor base) >>> 2. Flat (Discriminator and base) >>> >>> In expr.py, I notice that we modify the perceived type of the >>>

[PATCH 2/3] async: always set ctx->notified in aio_notify()

2020-08-03 Thread Stefan Hajnoczi
aio_notify() does not set ctx->notified when called with ctx->aio_notify_me disabled. In order to poll ctx->notified it is therefore necessary to enable ctx->aio_notify_me. This is suboptimal since expensive event_notifier_set(&ctx->notifier) and event_notifier_test_and_clear(&ctx->notifier) calls

[PATCH 3/3] aio-posix: keep aio_notify_me disabled during polling

2020-08-03 Thread Stefan Hajnoczi
Polling only monitors the ctx->notified field and does not need the ctx->notifier EventNotifier to be signalled. Keep ctx->aio_notify_me disabled while polling to avoid unnecessary EventNotifier syscalls. This optimization improves virtio-blk 4KB random read performance by 18%. The following resul

[PATCH 1/3] async: rename event_notifier_dummy_cb/poll()

2020-08-03 Thread Stefan Hajnoczi
The event_notifier_*() prefix can be confused with the EventNotifier APIs that are also called event_notifier_*(). Rename the functions to aio_context_notifier_*() to make it clear that they relate to the AioContext::notifier field. Signed-off-by: Stefan Hajnoczi --- util/async.c | 8

[PATCH 0/3] aio-posix: keep aio_notify_me disabled during polling

2020-08-03 Thread Stefan Hajnoczi
This patch series eliminates ctx->notifier EventNotifier activity when aio_poll() is in polling mode. There is no need to use the EventNotifier since a polling handler can detect that aio_notify() has been called by monitoring a field in memory instead. Optimizing out the EventNotifier calls impro

Re: [PATCH] target/arm/translate.c: Delete/amend incorrect comments

2020-08-03 Thread Richard Henderson
On 8/3/20 6:28 AM, Peter Maydell wrote: > In arm_tr_init_disas_context() we have a FIXME comment that suggests > "cpu_M0 can probably be the same as cpu_V0". This isn't in fact > possible: cpu_V0 is used as a temporary inside gen_iwmmxt_shift(), > and that function is called in various places wher

Re: [RFC v2 50/76] target/riscv: rvv-0.9: single-width saturating add and subtract instructions

2020-08-03 Thread Frank Chang
On Fri, Jul 31, 2020 at 5:24 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > > From: Frank Chang > > > > Sign-extend vsaddu.vi immediate value. > > > > Signed-off-by: Frank Chang > > --- > > target/riscv/insn_trans/trans_rvv.inc.

[PATCH v2] target/arm: Fix decode of LDRA[AB] instructions

2020-08-03 Thread Peter Collingbourne
These instructions use zero as the discriminator, not SP. Signed-off-by: Peter Collingbourne --- v2: - fixed commit message target/arm/translate-a64.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 8c076495

[PATCH] target/arm: Rename function disas_ldst_pac to disas_ld_pac

2020-08-03 Thread Peter Collingbourne
The name disas_ldst_pac is misleading as it implies the existence of authenticating store instructions, so rename it to avoid that implication. Signed-off-by: Peter Collingbourne --- target/arm/translate-a64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/t

Re: [PATCH] target/arm: Fix decode of {LD,ST}RA[AB] instructions

2020-08-03 Thread Peter Collingbourne
On Mon, Aug 3, 2020 at 3:27 PM Peter Collingbourne wrote: > > These instructions use zero as the discriminator, not SP. Oh, there is no such thing as STRAA/STRAB. I must have been confused by the name of the function, disas_ldst_pac. I will send a v2 with a fixed commit message, and another patch

RE: [PATCH v2 0/5] virtio mmio specification enhancement

2020-08-03 Thread Pincus, Josh
Hi Alex, Thank you for the reply. Please see my inline response below. -Original Message- From: Alex Bennée Sent: Friday, July 31, 2020 8:45 AM To: Pincus, Josh Cc: linux-ker...@vger.kernel.org; zha...@linux.alibaba.com; virtio-...@lists.oasis-open.org; qemu-devel@nongnu.org Subject:

[PATCH] target/arm: Fix decode of {LD,ST}RA[AB] instructions

2020-08-03 Thread Peter Collingbourne
These instructions use zero as the discriminator, not SP. Signed-off-by: Peter Collingbourne --- target/arm/translate-a64.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 8c0764957c..c996ca1393 100644 --- a/

[Bug 1890208] [NEW] Mouse pointer disappears when it is over console window

2020-08-03 Thread Adriano Marto Reis
Public bug reported: The host mouse pointer disappears when it is over a console window. I am emulating quite simple hardware: just text console and no mouse. I don't expect the mouse to have any effect on the emulated computers, but I need to know where the mouse pointer is. That is important b

QEMU | Pipeline #173898302 has failed for master | 5c1c3e4f

2020-08-03 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 5c1c3e4f ( https://gitlab.com/qemu-project/qemu/-/commit/5c1c3e4f02e458cf280c677c817ae4fd1ed9bf10 ) Commit Message: Merge remote-tr

Re: [PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX

2020-08-03 Thread John Snow
On 8/3/20 2:58 AM, Thomas Huth wrote: test-image-locking.c uses the qemu_lock_fd_test() function which is only available on Posix-like systems. Signed-off-by: Thomas Huth Reviewed-by: John Snow --- tests/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/Makefi

Re: [PATCH-for-5.2] stubs/cmos: Use correct include

2020-08-03 Thread John Snow
On 7/24/20 4:43 AM, Philippe Mathieu-Daudé wrote: cmos_get_fd_drive_type() is declared in "hw/block/fdc.h". This currently works because "hw/i386/pc.h" happens to include it. Simplify including the correct header. Fixes: 2055dbc1c9 ("acpi: move aml builder code for floppy device") Signed-off-by:

Re: [PULL 0/8] target-arm queue

2020-08-03 Thread Peter Maydell
;remotes/ericb/tags/pull-bitmaps-2020-08-03' > into staging (2020-08-03 15:13:49 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20200803 > > for you to fetch changes up to 13557fd3928

Re: [PATCH] schemas: Add vim modeline

2020-08-03 Thread Nir Soffer
On Mon, Aug 3, 2020 at 3:23 PM Daniel P. Berrangé wrote: > > On Mon, Aug 03, 2020 at 02:16:19PM +0200, Paolo Bonzini wrote: > > On 03/08/20 13:36, Daniel P. Berrangé wrote: > > >>> Given that QEMU needs to pass > > >>> uint64 values, JSON was simply the wrong choice of format for QMP. > > > > > >

[PATCH for-5.1] docs/devel: Document decodetree no-overlap groups

2020-08-03 Thread Richard Henderson
When support for this feature went in, the update to the documentation was forgotten. Fixes: 067e8b0f45d6 Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- docs/devel/decodetree.rst | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread John Snow
On 8/3/20 3:54 PM, Nir Soffer wrote: On Mon, Aug 3, 2020 at 9:19 PM John Snow wrote: On 8/3/20 2:16 PM, Paolo Bonzini wrote: On 03/08/20 20:10, John Snow wrote: Heresy: Docstrings could become part of the data format so they can be parsed, analyzed and validated. Parsers largely treat comme

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Helge Deller
On 03.08.20 21:10, Alexander Bulekov wrote: > On 200803 1432, Alexander Bulekov wrote: >> On 200803 1336, Alexander Bulekov wrote: >>> Hi, >>> I applied this patch, but I can still trigger a segfault and heap >>> overread through artist_reg_write -> fill_window. I dont know if these >>> problems ar

Re: [PATCH v6 00/13] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-08-03 Thread Havard Skinnemoen
Hi Philippe, On Mon, Aug 3, 2020 at 12:08 PM Philippe Mathieu-Daudé wrote: > > Hi Havard, > > On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > > I also pushed this and the previous two patchsets to my qemu fork on github. > > The branches are named npcm7xx-v[1-6]. > > > > https://github.com/hskin

Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-03 Thread Stefan Weil
Am 03.08.20 um 13:28 schrieb Stefan Weil: > Am 03.08.20 um 12:51 schrieb Philippe Mathieu-Daudé: > >> Hi Sunil, >> >> On 8/1/20 1:31 AM, Sunil Muthuswamy wrote: >>> The ask generally sounds reasonable. But, can you help me understand the >>> full >>> scope of the ask. Few questions: >>> 1. Stefan

[PATCH for-5.1] Add GitHub action for Windows build

2020-08-03 Thread Stefan Weil
The GitHub action is restricted to https://github.com/qemu/qemu. Signed-off-by: Stefan Weil --- This patch adds a GitHub action for continuous integration builds of QEMU for Windows. The CI builds run on GitHub and include the WHPX code. The action rules avoid unnecessary waste of resources by

[PATCH v2] Emulate dip switch language layout settings on SUN keyboard

2020-08-03 Thread Henrik Carlqvist
This is my second attempt to contribute a patch which makes the -k switch useful for sparc emulation as its value is used to emulate the dip switch in a SUN keyboard for language layout setting. Unfortunately my glib version is too old to compile later versions of qemu so even though this patch is

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Nir Soffer
On Mon, Aug 3, 2020 at 9:19 PM John Snow wrote: > > On 8/3/20 2:16 PM, Paolo Bonzini wrote: > > On 03/08/20 20:10, John Snow wrote: > >> Heresy: > >> > >> Docstrings could become part of the data format so they can be parsed, > >> analyzed and validated. Parsers largely treat comments like non-sem

[PULL 7/8] hw/arm/nrf51_soc: Set system_clock_scale

2020-08-03 Thread Peter Maydell
The nrf51 SoC model wasn't setting the system_clock_scale global.which meant that if guest code used the systick timer in "use the processor clock" mode it would hang because time never advances. Set the global to match the documented CPU clock speed for this SoC. This SoC in fact doesn't have a

[PULL 6/8] target/arm: Avoid maybe-uninitialized warning with gcc 4.9

2020-08-03 Thread Peter Maydell
From: Kaige Li GCC version 4.9.4 isn't clever enough to figure out that all execution paths in disas_ldst() that use 'fn' will have initialized it first, and so it warns: /home/LiKaige/qemu/target/arm/translate-a64.c: In function ‘disas_ldst’: /home/LiKaige/qemu/target/arm/translate-a64.c:3392:5

[PULL 5/8] target/arm: Fix AddPAC error indication

2020-08-03 Thread Peter Maydell
From: Richard Henderson The definition of top_bit used in this function is one higher than that used in the Arm ARM psuedo-code, which put the error indication at top_bit - 1 at the wrong place, which meant that it wasn't visible to Auth. Fixing the definition of top_bit requires more changes, b

[PULL 8/8] hw/timer/imx_epit: Avoid assertion when CR.SWR is written

2020-08-03 Thread Peter Maydell
The imx_epit device has a software-controllable reset triggered by setting the SWR bit in the CR register. An error in commit cc2722ec83ad9 means that we will end up assert()ing if the guest does this, because the code in imx_epit_write() starts ptimer transactions, and then imx_epit_reset() also s

[PULL 3/8] hw/intc/armv7m_nvic: Provide default "reset the system" behaviour for SYSRESETREQ

2020-08-03 Thread Peter Maydell
The NVIC provides an outbound qemu_irq "SYSRESETREQ" which it signals when the guest sets the SYSRESETREQ bit in the AIRCR register. This matches the hardware design (where the CPU has a signal of this name and it is up to the SoC to connect that up to an actual reset mechanism), but in QEMU it mo

[PULL 2/8] include/hw/irq.h: New function qemu_irq_is_connected()

2020-08-03 Thread Peter Maydell
Mostly devices don't need to care whether one of their output qemu_irq lines is connected, because functions like qemu_set_irq() silently do nothing if there is nothing on the other end. However sometimes a device might want to implement default behaviour for the case where the machine hasn't wire

[PULL 4/8] msf2-soc, stellaris: Don't wire up SYSRESETREQ

2020-08-03 Thread Peter Maydell
The MSF2 SoC model and the Stellaris board code both wire SYSRESETREQ up to a function that just invokes qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET); This is now the default action that the NVIC does if the line is not connected, so we can delete the handling code. Signed-off-by: Pet

[PULL 0/8] target-arm queue

2020-08-03 Thread Peter Maydell
0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200803 for you to fetch changes up to 13557fd392890cbd985bceba7f717e01efd674b8: hw/timer/imx_epit: Avoid assertion when CR.SWR is written (2020-08-03 17:5

[PULL 1/8] hw/arm/netduino2, netduinoplus2: Set system_clock_scale

2020-08-03 Thread Peter Maydell
The netduino2 and netduinoplus2 boards forgot to set the system_clock_scale global, which meant that if guest code used the systick timer in "use the processor clock" mode it would hang because time never advances. Set the global to match the documented CPU clock speed of these boards. Judging by

Re: [Bug 1889943] Improper TCP/IP packet splitting on e1000e/vmxnet3

2020-08-03 Thread Patrick J. Magauran
Hello Yan, I tryed the patches mentioned(the first one was already implemented in the git master, the second wasn't). It did fix the IPv6 fragmentation issue. So therefore, the focus needs to be on implementing proper layer 4 segmentation. --Patrick On Mon, 2020-08-03 at 09:37 +0300, Yan Vugenfi

Re: Ping: [PATCH] Emulate dip switch language layout settings on SUN keyboard

2020-08-03 Thread Artyom Tarasenko
On Mon, Aug 3, 2020 at 8:36 PM Henrik Carlqvist wrote: > > Thanks for finding my typos! :-) > On Mon, 3 Aug 2020 20:16:43 +0200 > Artyom Tarasenko wrote: > > > > > On Fri, 10 Jul 2020 20:19:11 +0200 > > > > Henrik Carlqvist wrote: > > > >> hardcoded to allways use an US keyboard layout. > > >

[PATCH] Get rid of the libqemustub.a remainders

2020-08-03 Thread Thomas Huth
libqemustub.a has been removed in commit ebedb37c8d ("Makefile: Remove libqemustub.a"). Some remainders have been missed. Remove them now. Signed-off-by: Thomas Huth --- Makefile| 2 +- scripts/coverity-scan/run-coverity-scan | 3 --- tests/test-util-sockets.c

[PATCH 2/3] tools/virtiofsd: xattr name mappings: Map client xattr names

2020-08-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Map xattr names originating at the client; from get/set/remove xattr. Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 101 ++- 1 file changed, 99 insertions(+), 2 deletions(-) diff --git a/tools/virtiofsd/

[PATCH 3/3] tools/virtiofsd: xattr name mappings: Map host xattr names

2020-08-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Map xattr names coming from the host, i.e. listxattr. Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 88 1 file changed, 88 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiof

[PATCH 0/3] virtiofsd xattr name mappings

2020-08-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This is a first cut of a xattr name mapping option for virtiofsd. It allows the user of virtiofsd to define a fairly flexible mapping from the view of the xattr names the host fs has and the ones that the guest sees. The hope is this allows things like:

[PATCH 1/3] tools/virtiofsd: xattr name mappings: Add option

2020-08-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add an option to define mappings of xattr names so that the client and host filesystems see different views. This can be used to have different SELinux mappings as seen by the guest, to run the virtiofsd with less privileges (e.g. in a case where it can't set truste

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Alexander Bulekov
On 200803 1432, Alexander Bulekov wrote: > On 200803 1336, Alexander Bulekov wrote: > > Hi, > > I applied this patch, but I can still trigger a segfault and heap > > overread through artist_reg_write -> fill_window. I dont know if these > > problems are related to what this patch fixes. If not, let

Re: [PATCH v6 00/13] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-08-03 Thread Philippe Mathieu-Daudé
Hi Havard, On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > I also pushed this and the previous two patchsets to my qemu fork on github. > The branches are named npcm7xx-v[1-6]. > > https://github.com/hskinnemoen/qemu > > This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to

[PATCH] target/riscv/vector_helper: Fix build on 32-bit big endian targets

2020-08-03 Thread Thomas Huth
The code currently fails to compile on 32-bit big endian targets: target/riscv/vector_helper.c: In function 'vext_clear': target/riscv/vector_helper.c:154:16: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] memset((void *)((uintptr_t)tail & ~(7ULL)),

Re: [RFC v2 59/76] target/riscv: rvv-0.9: floating-point slide instructions

2020-08-03 Thread Richard Henderson
On 8/3/20 3:35 AM, Frank Chang wrote: > i.e. > /DEF_HELPER_6(vslide1up_vx_w, void, ptr, ptr, *tl*, ptr, env, i32)/ vs. > /DEF_HELPER_6(vfslide1up_vf_h, void, ptr, ptr, *i64*, ptr, env, i32)/ > > As /opfvf_trans()/ and /opivx_trans()/ are shared among other instructions, > I wouldn't like to make p

Re: Ping: [PATCH] Emulate dip switch language layout settings on SUN keyboard

2020-08-03 Thread Henrik Carlqvist
Thanks for finding my typos! On Mon, 3 Aug 2020 20:16:43 +0200 Artyom Tarasenko wrote: > > > On Fri, 10 Jul 2020 20:19:11 +0200 > > > Henrik Carlqvist wrote: > > >> hardcoded to allways use an US keyboard layout. > Can you please move this description to the commit message? (Fixing > typo in "

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Alexander Bulekov
On 200803 1336, Alexander Bulekov wrote: > Hi, > I applied this patch, but I can still trigger a segfault and heap > overread through artist_reg_write -> fill_window. I dont know if these > problems are related to what this patch fixes. If not, let me know and > I can create a separate launchpad re

Re: [PULL 0/1] xen queue 2020-08-03

2020-08-03 Thread Peter Maydell
On Mon, 3 Aug 2020 at 17:53, Anthony PERARD wrote: > > xen patches > > bug fix > > > Philippe Mathieu-Daudé (1): > accel/xen: Fix xen_enabled() behavior on target

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread John Snow
On 8/3/20 2:16 PM, Paolo Bonzini wrote: On 03/08/20 20:10, John Snow wrote: Heresy: Docstrings could become part of the data format so they can be parsed, analyzed and validated. Parsers largely treat comments like non-semantic information and discard it. Round-trip parsers that preserve commen

Re: Ping: [PATCH] Emulate dip switch language layout settings on SUN keyboard

2020-08-03 Thread Artyom Tarasenko
On Mon, Aug 3, 2020 at 7:52 PM Paolo Bonzini wrote: > > On 03/08/20 19:26, Henrik Carlqvist wrote: > > Would you please consider my patch which implements the honor of the -k > > switch > > for sparc as a sun keyboard language dip switch setting instead of a hard > > coded en-us keyboard layout?

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Paolo Bonzini
On 03/08/20 20:10, John Snow wrote: > Heresy: > > Docstrings could become part of the data format so they can be parsed, > analyzed and validated. Parsers largely treat comments like non-semantic > information and discard it. Round-trip parsers that preserve comments in > any language are extremel

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread John Snow
On 8/3/20 8:01 AM, Paolo Bonzini wrote: That said, after a bit more research I'm skeptical about the possibility of using an off-the-shelf parser because most of them either don't support comments, or are based on YAJL which simply discards comments. Heresy: Docstrings could become part of the

Re: [PULL 00/63] riscv-to-apply queue

2020-08-03 Thread Thomas Huth
On 03/08/2020 20.00, Philippe Mathieu-Daudé wrote: > On 8/3/20 7:53 PM, Thomas Huth wrote: >> On 30/06/2020 10.44, LIU Zhiwei wrote: >>> >>> >>> On 2020/6/30 16:11, Thomas Huth wrote: On 30/06/2020 08.56, LIU Zhiwei wrote: > > > On 2020/6/29 6:51, Alistair Francis wrote: >> On

[Bug 1879587] Re: Register number in ESR is incorrect for certain banked registers when switching from AA32 to AA64

2020-08-03 Thread Julien Freche
Of course. I just tested the patch (used the branch from https://github.com/patchew-project/qemu) and it didn't seem to help. Could that be linked to the fact that the translation is only in the SMC exception path? It should probably target the MSR exception path also (and probably others too). It'

[Bug 1879587] Re: Register number in ESR is incorrect for certain banked registers when switching from AA32 to AA64

2020-08-03 Thread Julien Freche
Maybe it's covered by EXCP_HYP_TRAP already... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879587 Title: Register number in ESR is incorrect for certain banked registers when switching from AA

Re: [PULL 00/63] riscv-to-apply queue

2020-08-03 Thread Philippe Mathieu-Daudé
On 8/3/20 7:53 PM, Thomas Huth wrote: > On 30/06/2020 10.44, LIU Zhiwei wrote: >> >> >> On 2020/6/30 16:11, Thomas Huth wrote: >>> On 30/06/2020 08.56, LIU Zhiwei wrote: On 2020/6/29 6:51, Alistair Francis wrote: > On Sun, Jun 28, 2020 at 7:30 AM Peter Maydell > wrote: >

Re: [PULL 00/63] riscv-to-apply queue

2020-08-03 Thread Thomas Huth
On 30/06/2020 10.44, LIU Zhiwei wrote: > > > On 2020/6/30 16:11, Thomas Huth wrote: >> On 30/06/2020 08.56, LIU Zhiwei wrote: >>> >>> >>> On 2020/6/29 6:51, Alistair Francis wrote: On Sun, Jun 28, 2020 at 7:30 AM Peter Maydell wrote: > On Fri, 26 Jun 2020 at 22:53, Alistair Francis

Re: Ping: [PATCH] Emulate dip switch language layout settings on SUN keyboard

2020-08-03 Thread Paolo Bonzini
On 03/08/20 19:26, Henrik Carlqvist wrote: > Would you please consider my patch which implements the honor of the -k switch > for sparc as a sun keyboard language dip switch setting instead of a hard > coded en-us keyboard layout? > > The initial patch mail was sent to the mailing list and the lis

Re: qapi-schema esotera

2020-08-03 Thread John Snow
On 8/3/20 1:25 PM, Eric Blake wrote: On 8/3/20 11:49 AM, John Snow wrote: UNION is split into two primary forms: 1. Simple (No discriminator nor base) 2. Flat (Discriminator and base) In expr.py, I notice that we modify the perceived type of the 'type' expression based on the two union forms.

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Alexander Bulekov
Hi, I applied this patch, but I can still trigger a segfault and heap overread through artist_reg_write -> fill_window. I dont know if these problems are related to what this patch fixes. If not, let me know and I can create a separate launchpad report for these. -Alex (1) Segfault: cat << EOF |

Ping: [PATCH] Emulate dip switch language layout settings on SUN keyboard

2020-08-03 Thread Henrik Carlqvist
Would you please consider my patch which implements the honor of the -k switch for sparc as a sun keyboard language dip switch setting instead of a hard coded en-us keyboard layout? The initial patch mail was sent to the mailing list and the listed maintainers of escc.c and is also available at ht

Re: qapi-schema esotera

2020-08-03 Thread Eric Blake
On 8/3/20 11:49 AM, John Snow wrote: UNION is split into two primary forms: 1. Simple (No discriminator nor base) 2. Flat (Discriminator and base) In expr.py, I notice that we modify the perceived type of the 'type' expression based on the two union forms. 1a. Simple unions allow Array[T] 1b

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Paolo Bonzini
On 03/08/20 18:03, Markus Armbruster wrote: >> In general it seems like a good idea to use a standard file format and >> not "a standard file format except for two characters". :) We also >> wouldn't be having discussions on editors. > > No argument. But towards which standard file format should

Re: [PATCH-for-5.0 1/2] hw/acpi/piix4: Add 'system-hotplug-support' property

2020-08-03 Thread Philippe Mathieu-Daudé
Hi Igor, Paolo. On 3/23/20 12:04 PM, Marcelo Tosatti wrote: > On Mon, Mar 23, 2020 at 09:05:06AM +0100, Paolo Bonzini wrote: >> On 22/03/20 17:27, Philippe Mathieu-Daudé wrote: > That 'ugly' is typically used within QEMU to deal with such things probably due to its low complexity. >>

Re: [PATCH] [PATCH v2] gdbstub: add support to Xfer:auxv:read: packet

2020-08-03 Thread Lirong Yuan
On Mon, Aug 3, 2020 at 4:27 AM Alex Bennée wrote: > > > Lirong Yuan writes: > > > This allows gdb to access the target’s auxiliary vector, > > which can be helpful for telling system libraries important details > > about the hardware, operating system, and process. > > > > Signed-off-by: Lirong Y

[Bug 1879587] Re: Register number in ESR is incorrect for certain banked registers when switching from AA32 to AA64

2020-08-03 Thread Peter Maydell
Thanks for the bug report; I think this patch should fix it: https://patchew.org/QEMU/20200803165409.15099-1-peter.mayd...@linaro.org/ Any chance you could test it? ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- de

Re: [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines

2020-08-03 Thread Philippe Mathieu-Daudé
On 7/30/20 1:34 PM, Igor Mammedov wrote: > On Fri, 24 Jul 2020 18:52:59 +0200 > Philippe Mathieu-Daudé wrote: > >> No MIPS machine uses the ACPI cpu-hotplug feature >> (QEMU implementation is X86 specific). > > if I recall correctly we were building it to satisfy symbol dependencies > due to hw/

[PATCH] target/arm: Fix Rt/Rt2 in ESR_ELx for copro traps from AArch32 to 64

2020-08-03 Thread Peter Maydell
When a coprocessor instruction in an AArch32 guest traps to AArch32 Hyp mode, the syndrome register (HSR) includes Rt and Rt2 fields which are simply copies of the Rt and Rt2 fields from the trapped instruction. However, if the instruction is trapped from AArch32 to an AArch64 higher exception le

[PULL 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-08-03 Thread Anthony PERARD
From: Philippe Mathieu-Daudé CONFIG_XEN is generated by configure and stored in "config-target.h", which is (obviously) only include for target-specific objects. This is a problem for target-agnostic objects as CONFIG_XEN is never defined and xen_enabled() is always inlined as 'false'. Fix by fo

[PULL 0/1] xen queue 2020-08-03

2020-08-03 Thread Anthony PERARD
erard/qemu-dm.git tags/pull-xen-20200803 for you to fetch changes up to b3fcc98f391e9a60a369d825333b852871cf67b0: accel/xen: Fix xen_enabled() behavior on target-agnostic objects (2020-08-03 17:39:38 +0100) xen patche

qapi-schema esotera

2020-08-03 Thread John Snow
UNION is split into two primary forms: 1. Simple (No discriminator nor base) 2. Flat (Discriminator and base) In expr.py, I notice that we modify the perceived type of the 'type' expression based on the two union forms. 1a. Simple unions allow Array[T] 1b. Flat unions disallow Array[T] From

[PATCH v1 1/1] docs/system/arm: Document the Xilinx Versal Virt board

2020-08-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Document the Xilinx Versal Virt board. Signed-off-by: Edgar E. Iglesias --- docs/system/arm/xlnx-versal-virt.rst | 176 +++ docs/system/target-arm.rst | 1 + MAINTAINERS | 3 +- 3 files changed, 179 insert

[PATCH v1 0/1] docs/system/arm: Document the Xilinx Versal Virt board

2020-08-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, This adds some basic documentation for the Xilinx Versal Virt board, including a few command-line examples on how to run ARM Trusterd Firmware, U-boot, Xen and Linux. If this looks OK I'll send similar basic documentation for the ZynqMP and Zynq. Best regards, Edg

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-08-03 Thread Peter Maydell
On Mon, 3 Aug 2020 at 17:35, Anthony PERARD wrote: > > On Tue, Jul 28, 2020 at 12:09:25PM +0200, Philippe Mathieu-Daudé wrote: > > CONFIG_XEN is generated by configure and stored in "config-target.h", > > which is (obviously) only include for target-specific objects. > > This is a problem for targ

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Kevin Wolf
Am 03.08.2020 um 18:03 hat Markus Armbruster geschrieben: > Paolo Bonzini writes: > > This means the two parts might be considered separately: > > > > - replacing single-quote with double-quote strings > > > > - replacing # comments with // > > If all we want is decent editor support out of the b

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-08-03 Thread Anthony PERARD
On Tue, Jul 28, 2020 at 12:09:25PM +0200, Philippe Mathieu-Daudé wrote: > CONFIG_XEN is generated by configure and stored in "config-target.h", > which is (obviously) only include for target-specific objects. > This is a problem for target-agnostic objects as CONFIG_XEN is never > defined and xen_e

Re: [PATCH v2 0/5] virtio mmio specification enhancement

2020-08-03 Thread Alex Bennée
Alex Bennée writes: > Pincus, Josh writes: > >> Hi, >> >> >> >> We were looking into a similar enhancement for the Virt I/O MMIO transport >> and came across this project. >> >> This enhancement would be perfect for us. > > So there is certainly an interest in optimising MMIO based virtio a

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-03 Thread Eugenio Pérez
On Fri, 2020-07-03 at 15:24 +0800, Jason Wang wrote: > On 2020/7/2 下午11:45, Peter Xu wrote: > > On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote: > > > So I think we agree that a new notifier is needed? > > Good to me, or a new flag should be easier (IOMMU_NOTIFIER_DEV_IOTLB)? > > That s

Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

2020-08-03 Thread Markus Armbruster
Paolo Bonzini writes: > On 03/08/20 13:28, Markus Armbruster wrote: We could remove them from the QAPI schema language. Flag day, and git-blame becomes pretty much useless for a couple of years. >>> Is that a nack or a "whatever"? >> It's "is this really worth the trouble?" I guess th

Re: [PULL 0/2] bitmaps patches for -rc3, 2020-08-03

2020-08-03 Thread Peter Maydell
On Mon, 3 Aug 2020 at 15:13, Eric Blake wrote: > > The following changes since commit 6c5dfc9ccb643a0d50fdec9f10806b14960571d1: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-08-03' > into staging (2020-08-03 12:21:57 +0100) > > are available in the Git repository at: > >

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Richard Henderson
On 8/1/20 6:13 AM, Helge Deller wrote: > From: Sven Schnelle > > Signed-off-by: Sven Schnelle > Signed-off-by: Helge Deller > --- > hw/display/artist.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) Looks ok, if not ideal. Reviewed-by: Richard Henderson

Re: [PATCH] schemas: Add vim modeline

2020-08-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Aug 03, 2020 at 02:16:19PM +0200, Paolo Bonzini wrote: >> On 03/08/20 13:36, Daniel P. Berrangé wrote: >> >>> Given that QEMU needs to pass >> >>> uint64 values, JSON was simply the wrong choice of format for QMP. >> > >> > I wasn't refering to RFC7159. The pr

Re: [Bug 1890160] [NEW] Abort in vmxnet3_validate_queues

2020-08-03 Thread Philippe Mathieu-Daudé
Cc'ing Dmitry as he doesn't have lauchpad account :/ On 8/3/20 4:37 PM, Alexander Bulekov wrote: > Public bug reported: > > Hello, > Reproducer: > > cat << EOF | ./i386-softmmu/qemu-system-i386 \ > -device vmxnet3 -m 64 -nodefaults -qtest stdio -nographic > outl 0xcf8 0x80001014 > outl 0xcfc 0xe

Re: [PATCH for-5.1] hw/arm/nrf51_soc: Set system_clock_scale

2020-08-03 Thread Philippe Mathieu-Daudé
On 7/27/20 9:34 PM, Peter Maydell wrote: > The nrf51 SoC model wasn't setting the system_clock_scale > global.which meant that if guest code used the systick timer in "use > the processor clock" mode it would hang because time never advances. > > Set the global to match the documented CPU clock sp

Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-08-03 Thread Andrew Jones
On Wed, Jul 29, 2020 at 04:40:54PM +0200, Andrew Jones wrote: > > > +static inline void kvm_arm_steal_time_finalize(ARMCPU *cpu, Error > > > **errp) {} > > > > Does this stub need to report an error to the caller via errp, > > or is it a "never called but needs to exist to avoid linker errors" ?

Re: [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time

2020-08-03 Thread Andrew Jones
On Sat, Aug 01, 2020 at 02:00:34PM +0200, Andrew Jones wrote: > > > if (kvm_enabled()) { > > > +hwaddr pvtime_base = vms->memmap[VIRT_PVTIME].base; > > > +hwaddr pvtime_size = vms->memmap[VIRT_PVTIME].size; > > > + > > > +if (steal_time) { > > > +MemoryRegio

Re: [PATCH for-5.1] hw/timer/imx_epit: Avoid assertion when CR.SWR is written

2020-08-03 Thread Philippe Mathieu-Daudé
On 7/27/20 5:45 PM, Peter Maydell wrote: > The imx_epit device has a software-controllable reset triggered by > setting the SWR bit in the CR register. An error in commit cc2722ec83ad9 > means that we will end up assert()ing if the guest does this, because > the code in imx_epit_write() starts ptim

[Bug 1890160] [NEW] Abort in vmxnet3_validate_queues

2020-08-03 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device vmxnet3 -m 64 -nodefaults -qtest stdio -nographic outl 0xcf8 0x80001014 outl 0xcfc 0xe0001000 outl 0xcf8 0x80001018 outl 0xcf8 0x80001004 outw 0xcfc 0x7 write 0x0 0x1 0xe1 write 0x1 0x1 0xfe write 0x2 0

[Bug 1890159] [NEW] Assertion failure in net_tx_pkt_add_raw_fragment through vmxnet3

2020-08-03 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device vmxnet3 -m 64 -nodefaults -qtest stdio -nographic outl 0xcf8 0x80001010 outl 0xcfc 0xe000 outl 0xcf8 0x80001014 outl 0xcfc 0xe0001000 outl 0xcf8 0x80001018 outl 0xcf8 0x80001001 outl 0xcfc 0x3fff3ff

[Bug 1890157] [NEW] Assertion failure in net_tx_pkt_reset through vmxnet3

2020-08-03 Thread Alexander Bulekov
Public bug reported: Hello, Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device vmxnet3 -m 64 -nodefaults -qtest stdio -nographic outl 0xcf8 0x80001014 outl 0xcfc 0xe0001000 outl 0xcf8 0x80001018 outl 0xcf8 0x80001004 outw 0xcfc 0x7 outl 0xcf8 0x80001083 write 0x0 0x1 0xe1 write 0x

  1   2   3   >