Re: [PATCH] schemas: Add vim modeline

On 7/30/20 9:24 AM, Daniel P. Berrangé wrote: On Thu, Jul 30, 2020 at 01:51:10PM +0200, Markus Armbruster wrote: Daniel P. Berrangé writes: modify them so that we can load the files straight into the python intepretor as code, and not parse them as data. I feel

[Bug 1888971] Re: SMI trigger causes hang with multiple cores

I tried without specifying -bios parameter still hang is seen. But this time it had low memory corruption. And built seabios with more debug logs but seabios doesn't does SMM init even when its selected in make menuconfig. I guess fundamentally th issue is writing 0xXX in IO port 0xB2 should trig

Re: [PATCH for-5.2] spapr: Avoid some integer conversions in spapr_phb_realize()

On Thu, Jul 30, 2020 at 06:55:18PM +0200, Greg Kurz wrote: > On Wed, 29 Jul 2020 12:54:41 +1000 > David Gibson wrote: > > > On Tue, Jul 28, 2020 at 11:14:13AM +0200, Greg Kurz wrote: > > > Without this patch, the irq number gets converted uselessly from int > > > to int32_t, back and forth. > > >

[PATCH] colo-compare: Remove superfluous NULL-pointer checks for s->iothread

s->iothread is checked for NULL on object creation in colo_compare_complete, so it's guaranteed not to be NULL. This resolves a false alert from Coverity (CID 1429969). Signed-off-by: Lukas Straub --- net/colo-compare.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/

Re: [PATCH v2 1/2] virtio-mem: Change PRIx32 to PRIXPTR to fix compile error.

On 07/30/2020 09:15 PM, Philippe Mathieu-Daudé wrote: On 7/30/20 1:57 PM, Kaige Li wrote: When I compile qemu with such as: git clone https://git.qemu.org/git/qemu.git cd qemu git submodule init git submodule update --recursive ./configure make ^ this timeless description is pointless (thin

Re: [PATCH 1/2] hw/net/net_tx_pkt: add function to check pkt->max_raw_frags

On 2020/7/31 上午1:05, Mauro Matteo Cascella wrote: On Thu, Jul 30, 2020 at 7:28 AM Jason Wang wrote: On 2020/7/29 上午12:26, Mauro Matteo Cascella wrote: On Tue, Jul 28, 2020 at 6:06 AM Jason Wang wrote: On 2020/7/28 上午1:08, Mauro Matteo Cascella wrote: This patch introduces a new function i

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

Hi,Thanks a lot! Can confirm the authenticity of both patches. I also do not mind whether my full name or nickname is used, whatever is easier.Best regards,Vitaly On Thu, Jul 30, 2020 at 22:35, Michael S. Tsirkin wrote: On Thu, Jul 30, 2020 at 06:11:17PM +0200, Philippe Mathieu

[RFC PATCH v2 1/2] hw/riscv: sifive_u: Add file-backed OTP.

Add a file-backed implementation for OTP of sifive_u machine. The machine property for file-backed is disabled in default. Do file open, mmap and close for every OTP read/write in case keep the update-to-date snapshot of OTP. Signed-off-by: Green Wan --- hw/riscv/sifive_u.c | 26

[RFC PATCH v2 2/2] hw/riscv: sifive_u: Add write-once protection.

Add array to store the 'written' status for all bit of OTP to block the write operation to the same bit. Ignore the control register offset from 0x0 to 0x38 of OTP memory mapping. Signed-off-by: Green Wan --- hw/riscv/sifive_u_otp.c | 20 include/hw/riscv/sifive_u_ot

[RFC PATCH v2 0/2] Add write-once and file-backed features to OTP

First patch is to add file-backed implementation to allow users to assign an OTP image file to machine. Users can assign the property, "otp-file", to machine to enable it. File-backed feature is set to "NULL" string in default. Any filename other than "NULL" is used as OTP image file. For example,

Re: [PATCH v2 2/2] target/arm: Fix compile error.

On 07/31/2020 04:45 AM, Peter Maydell wrote: On Thu, 30 Jul 2020 at 12:58, Kaige Li wrote: When I compile qemu with such as: git clone https://git.qemu.org/git/qemu.git cd qemu git submodule init git submodule update --recursive ./configure make There is error log: /home/LiKaige/qemu/target

Re: [PATCH-for-5.1? v2 1/2] qemu/osdep: Make QEMU_VMALLOC_ALIGN unsigned long

On Thu, Jul 30, 2020 at 04:12:44PM +0200, Philippe Mathieu-Daudé wrote: > QEMU_VMALLOC_ALIGN is sometimes expanded to signed type, > other times to unsigned. Unify using unsigned. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson > --- > include/qemu/osdep.h | 4 ++-- > 1 fi

Re: [PATCH-for-5.1? v2 2/2] util/pagesize: Make qemu_real_host_page_size of type size_t

On Thu, Jul 30, 2020 at 04:12:45PM +0200, Philippe Mathieu-Daudé wrote: > We use different types to hold 'qemu_real_host_page_size'. > Unify picking 'size_t' which seems the best candidate. > > Doing so fix a format string issue in hw/virtio/virtio-mem.c > reported when building with GCC 4.9.4: >

Re: [PATCH] trace/simple: Allow enabling simple traces from command line

Well, this is a bit embarrassing.  The patch below simply re-introduced the bug which the Fixes: line was trying to fix in the first place. I.e, : - with my patch (just committed as 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4) applied, a QEMU built with simple tracing will always produce a trace

Re: [PATCH] introduce VFIO-over-socket protocol specificaion

Comments embedded. Thanks for looking at it. JJ > On Jul 29, 2020, at 4:51 PM, Alex Williamson > wrote: > > On Thu, 16 Jul 2020 08:31:43 -0700 > Thanos Makatos wrote: > >> This patch introduces the VFIO-over-socket protocol specification,

Re: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

On 7/29/20 10:40, Stefan Hajnoczi wrote: > On Wed, Jul 29, 2020 at 09:59:01AM +0200, Roman Mohr wrote: >> On Tue, Jul 28, 2020 at 3:13 PM Vivek Goyal wrote: >> >>> On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote: On Tue, Jul 28, 2020 at 3:07 AM misono.tomoh...@fujitsu.com < mi

[PATCH] WHPX: vmware cpuid leaf for tsc and apic frequency

Newer versions of WHPX provide the capability to query the tsc and apic frequency. Expose these through the vmware cpuid leaf. This patch doesnt support setting the tsc frequency; that will come as a separate fix. Signed-off-by: Sunil Muthuswamy --- target/i386/whp-dispatch.h | 3 +- target/i38

Re: [PATCH 3/3] cpu-timers, icount: new modules

On 30/07/20 18:33, Claudio Fontana wrote: > One problem I noticed is that qemu_clock_get_ns is util/qemu-timer.c, > which is tools _and_ softmmu, while I tried to extract the > softmmu-only timer code in softmmu/cpu-timers.c, Not all of it, only the VIRTUAL clock which is if (use_icount)

RE: [EXTERNAL] Re: qemu repo lockdown message for a WHPX PR

> > I was not referring to github pull requests, but rather to a maintainer > pull request. This is also sent to the mailing list. There is no > QEMU-specific documentation since maintainers are generally experienced > enough to have observed how these are sent, but the Linux documentation > mor

QEMU | Pipeline #172716064 has failed for master | 14486297

Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 14486297 ( https://gitlab.com/qemu-project/qemu/-/commit/1448629751871c4924c234c2faaa968fc26890e1 ) Commit Message: Merge remote-tr

Re: [PATCH V1 00/32] Live Update

On 30/07/20 21:09, Steven Sistare wrote: >> please spell it out. Also, how does the functionality compare to >> xen-save-devices-state and xen-load-devices-state? > > qmp_xen_save_devices_state serializes device state to a file which is loaded > on the target for a live migration. It performs so

Re: [RFC v2 53/76] target/riscv: use softfloat lib float16 comparison functions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Signed-off-by: Frank Chang > --- > target/riscv/vector_helper.c | 19 --- > 1 file changed, 19 deletions(-) Reviewed-by: Richard Henderson r~

Re: [RFC v2 51/76] target/riscv: rvv-0.9: integer comparison instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Sign-extend vmselu.vi and vmsgtu.vi immediate values. > > Signed-off-by: Frank Chang > --- > target/riscv/insn_trans/trans_rvv.inc.c | 4 +- > target/riscv/vector_helper.c| 86 + > 2

Re: [RFC v2 50/76] target/riscv: rvv-0.9: single-width saturating add and subtract instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Sign-extend vsaddu.vi immediate value. > > Signed-off-by: Frank Chang > --- > target/riscv/insn_trans/trans_rvv.inc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/insn_trans/tran

Re: [RFC v2 49/76] target/riscv: rvv-0.9: quad-widening integer multiply-add instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Add the following instructions: > > * vqmaccu.vv > * vqmaccu.vx > * vqmacc.vv > * vqmacc.vx > * vqmaccsu.vv > * vqmaccsu.vx > * vqmaccus.vx > > Signed-off-by: Frank Chang > --- > target/riscv/helper.h

Re: [PATCH v2 0/5] virtio mmio specification enhancement

Hi, We were looking into a similar enhancement for the Virt I/O MMIO transport and came across this project. This enhancement would be perfect for us. Has there been any progress since Feb, 2020? It looks like the effort might have stalled? Thanks, JP

Re: [RFC v2 48/76] target/riscv: rvv-0.9: widening integer multiply-add instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Signed-off-by: Frank Chang > --- > target/riscv/insn32.decode | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [RFC v2 47/76] target/riscv: rvv-0.9: narrowing integer right shift instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Signed-off-by: Frank Chang > --- > target/riscv/helper.h | 24 ++-- > target/riscv/insn32.decode | 12 +- > target/riscv/insn_trans/trans_rvv.inc.c | 30 -

Re: [PATCH] schemas: Add vim modeline

On 7/30/20 11:11 AM, Eric Blake wrote: JSON5 would also let us get rid of some quotes, if that is considered a desirable goal of the representation (although I'm not sure that quote avoidance should be driving our decision, so much as automated conversion). There's no JSON5 parser built in to

Re: [PATCH] schemas: Add vim modeline

On 7/30/20 11:11 AM, Eric Blake wrote: Agreed on that front. Thirded: Reviewed-by: John Snow

Re: [PATCH v2 2/2] target/arm: Fix compile error.

On Thu, 30 Jul 2020 at 14:17, Philippe Mathieu-Daudé wrote: > Again, what compiler / version are you using? My guess is you are > using an old GCC, and I wonder if it is still supported. configure complains if you use a gcc so old we don't support it (our current minimum is GCC 4.8; Kaige is usin

Re: [RFC v2 44/76] target/riscv: rvv-0.9: single-width averaging add and subtract instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Add the following instructions: > > * vaaddu.vv > * vaaddu.vx > * vasubu.vv > * vasubu.vx > > Remove the following instructions: > > * vadd.vi > > Signed-off-by: Frank Chang > --- > target/riscv/helper.h

Re: [RFC v2 45/76] target/riscv: rvv-0.9: single-width bit shift instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > Truncate vsll.vi, vsrl.vi, vsra.vi's immediate values to lg2(SEW) bits. > > Signed-off-by: Frank Chang > --- > target/riscv/insn_trans/trans_rvv.inc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Review

Re: [PATCH v2 2/2] target/arm: Fix compile error.

On Thu, 30 Jul 2020 at 12:58, Kaige Li wrote: > > When I compile qemu with such as: > > git clone https://git.qemu.org/git/qemu.git > cd qemu > git submodule init > git submodule update --recursive > ./configure > make > > There is error log: > > /home/LiKaige/qemu/target/arm/translate-a64.c: In f

Re: [RFC v2 43/76] target/riscv: rvv-0.9: integer extension instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > +static gen_helper_gvec_3_ptr * const fns[6][4] = { > +{ > +NULL, gen_helper_vzext_vf2_h, > +gen_helper_vzext_vf2_w, gen_helper_vzext_vf2_d > +}, > +{ > +NULL, NULL, > +ge

Re: [PATCH 2/2] arm/acpi: fix an out of spec _UID for PCI root

On Thu, 30 Jul 2020 at 16:58, Michael S. Tsirkin wrote: > > On ARM/virt machine type QEMU currently reports an incorrect _UID in > ACPI. > > The particular node in question is the primary PciRoot (PCI0 in ACPI), > which gets assigned PCI0 in ACPI UID and 0 in the > DevicePath. This is due to the _

Re: [PULL for-5.1 0/2] Tracing patches

On Thu, 30 Jul 2020 at 19:14, Stefan Hajnoczi wrote: > > The following changes since commit 5772f2b1fc5d00e7e04e01fa28e9081d6550440a: > > Update version for v5.1.0-rc2 release (2020-07-28 21:51:03 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/

Re: Differing PAC behavior between Qemu and Arm FVP

On Thu, 30 Jul 2020 at 21:06, Derrick McKee wrote: > > Hi Peter, > > I just got a SIGILL trying to execute a stg instruction with the QEMU version > later in this thread, but the same instruction works correctly on the FVP. > Are you sure that all the MTE functionality is present in the master

Re: [RFC v2 42/76] target/riscv: rvv-0.9: whole register move instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > +((a->rd & ((LEN) - 1)) == 0) && \ QEMU_IS_ALIGNED(a->rd, LEN) > +tcg_gen_gvec_mov(8, vreg_ofs(s, a->rd + i), \ > + vreg_ofs(s, a->rs2 + i), \ > +

Re: [RFC v2 40/76] target/riscv: rvv-0.9: floating-point move instruction

On 7/30/20 12:57 PM, Richard Henderson wrote: > On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: >> +(s->sew < MO_32)) { >> +/* SEW < FLEN */ >> +TCGv_i64 t1 = tcg_temp_new_i64(); >> +TCGv_i32 sew = tcg_const_i32(1 << (s->sew + 3)); >

Re: [RFC v2 41/76] target/riscv: rvv-0.9: floating-point scalar move instructions

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > NaN-boxed the scalar floating-point register based on RVV 0.9's rules. > > Signed-off-by: Frank Chang > --- > target/riscv/insn32.decode | 4 +-- > target/riscv/insn_trans/trans_rvv.inc.c | 45 +

Re: [RFC v2 40/76] target/riscv: rvv-0.9: floating-point move instruction

On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > NaN-boxed the scalar floating-point register based on RVV 0.9's rules. > > Signed-off-by: Frank Chang > --- > target/riscv/insn_trans/trans_rvv.inc.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(

[PATCH v2 2/5] virtiofsd: create lock/pid file in per user cache dir

Right now we create lock/pid file in /usr/local/var/... and unprivliged user does not have access to create files there. Hence, in unprivileged mode, create this file in per user cache dir as specified by environment variable XDG_RUNTIME_DIR. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_

[PATCH v2 5/5] virtiofsd: Skip setup_capabilities() in sandbox=NONE mode

setup_capabilites() tries to give some of the required capabilities to act as a full fledged file server in priviliged mode. In unpriviliged mode we can't get those capabilities and setup_capabilities() will fail. So don't setup capabilities when sandbox=NONE. Signed-off-by: Vivek Goyal --- too

[PATCH v2 4/5] virtiofsd: Open lo->source while setting up root in sandbox=NONE mode

In sandbox=NONE mode, lo->source points to the directory which is being exported. We have not done any chroot()/pivot_root(). So open lo->source. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_ll.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/virtiofs

[PATCH v2 1/5] virtiofsd: Add notion of unprivileged mode

At startup if we are running as non-root user, then internally set unpriviliged mode set. Also add a notion of sandbox NONE and set that internally in unprivileged mode. setting up namespaces and chroot() fails in unpriviliged mode. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_ll.c

[PATCH v2 3/5] virtiofsd: open /proc/self/fd/ in sandbox=NONE mode

We need /proc/self/fd descriptor even in sandbox=NONE mode. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_ll.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index cd91c4a831..76ef

[PATCH v2 0/5] virtiofsd: Add a unprivileged passthrough mode

Hi, This is V2 of patches. Only change since last version is handling of lock/pid file creation as per the comments from Daniel Berrange. I can't think of any more changes needed. As a unpriviliged user inside VM I can do simple operations like create/remove/read/write files. For more testing, I

Re: [PATCH] gdbstub: add support to Xfer:auxv:read: packet

On Tue, Jul 21, 2020 at 1:29 PM Lirong Yuan wrote: > > On Tue, Jul 21, 2020 at 12:50 PM Alex Bennée wrote: > > > > > > Lirong Yuan writes: > > > > > On Tue, Mar 31, 2020 at 12:20 AM Alex Bennée > > > wrote: > > >> > > >> > > >> Lirong Yuan writes: > > >> > > >> > On Mon, Mar 30, 2020 at 12:47

[PATCH] [PATCH v2] gdbstub: add support to Xfer:auxv:read: packet

This allows gdb to access the target’s auxiliary vector, which can be helpful for telling system libraries important details about the hardware, operating system, and process. Signed-off-by: Lirong Yuan --- Changelog since v1: - Added a multiarch gdbstub test to verify this is working properly.

Re: [PATCH 2/2] arm/acpi: fix an out of spec _UID for PCI root

On 07/30/20 17:58, Michael S. Tsirkin wrote: > On ARM/virt machine type QEMU currently reports an incorrect _UID in > ACPI. > > The particular node in question is the primary PciRoot (PCI0 in ACPI), > which gets assigned PCI0 in ACPI UID and 0 in the > DevicePath. This is due to the _UID assigned

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

On Thu, Jul 30, 2020 at 06:11:17PM +0200, Philippe Mathieu-Daudé wrote: > On 7/30/20 5:58 PM, Michael S. Tsirkin wrote: > > macOS uses ACPI UIDs to build the DevicePath for NVRAM boot options, > > while OVMF firmware gets them via an internal channel through QEMU. > > Due to a bug in QEMU ACPI cur

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

On 07/30/20 17:58, Michael S. Tsirkin wrote: > macOS uses ACPI UIDs to build the DevicePath for NVRAM boot options, > while OVMF firmware gets them via an internal channel through QEMU. > Due to a bug in QEMU ACPI currently UEFI firmware and ACPI have > different values, and this makes the underlyi

Re: [PATCH V1 00/32] Live Update

On 7/30/2020 1:49 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Improve and extend the qemu functions that save and restore VM state so a >> guest may be suspended and resumed with minimal pause time. qemu may be >> updated to a new version in between. >

Re: [PATCH V1 00/32] Live Update

On 7/30/2020 1:15 PM, Paolo Bonzini wrote: > On 30/07/20 17:14, Steve Sistare wrote: >> The first set of patches adds the cprsave and cprload commands to save and >> restore VM state, and allow the host kernel to be updated and rebooted in >> between. The VM must create guest RAM in a persistent s

Re: [PATCH v12 01/11] iotests: add test for QCOW2 header dump

On 7/30/20 9:15 AM, Andrey Shinkevich wrote: The simple script creates a QCOW2 image and fills it with some data. Two bitmaps are created as well. Then the script reads the image header with extensions from the disk by running the script qcow2.py and dumps the information to the output. Other ent

Re: [PATCH V1 00/32] Live Update

On 7/30/2020 12:52 PM, Daniel P. Berrangé wrote: > On Thu, Jul 30, 2020 at 08:14:04AM -0700, Steve Sistare wrote: >> Improve and extend the qemu functions that save and restore VM state so a >> guest may be suspended and resumed with minimal pause time. qemu may be >> updated to a new version in b

Re: [PATCH V1 14/32] savevm: VMS_RESTART and cprsave restart

On 7/30/2020 12:22 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> Add the VMS_RESTART variant of vmstate, for use when upgrading qemu in place >> on the same host without a reboot.  Invoke it using: >>    cprsave restart >> >> VMS_RESTART supports guest ram mapped by private

[PULL for-5.1 2/2] tracetool: carefully define SDT_USE_VARIADIC

The dtrace backend defines SDT_USE_VARIADIC as a workaround for a conflict with a LTTng UST header file, which requires SDT_USE_VARIADIC to be defined. LTTng UST breaks if included after generated dtrace headers because SDT_USE_VARIADIC will already be defined: #ifdef LTTNG_UST_HAVE_SDT_INTEGR

[PULL for-5.1 0/2] Tracing patches

The following changes since commit 5772f2b1fc5d00e7e04e01fa28e9081d6550440a: Update version for v5.1.0-rc2 release (2020-07-28 21:51:03 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 000822441e3491

[PULL for-5.1 1/2] trace/simple: Allow enabling simple traces from command line

From: Josh DuBois The simple trace backend is enabled / disabled with a call to st_set_trace_file_enabled(). When initializing tracing from the command-line, this must be enabled on startup. (Prior to db25d56c014aa1a9, command-line initialization of simple trace worked because every call to st_s

Re: [PATCH V1 12/32] vl: pause option

On 7/30/2020 1:03 PM, Alex Bennée wrote: > > Steve Sistare writes: > >> Provide the -pause command-line parameter and the QEMU_PAUSE environment >> variable to briefly pause QEMU in main and allow a developer to attach gdb. >> Useful when the developer does not invoke QEMU directly, such as when

Re: [PATCH V1 12/32] vl: pause option

On 7/30/2020 12:20 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> Provide the -pause command-line parameter and the QEMU_PAUSE environment >> variable to briefly pause QEMU in main and allow a developer to attach gdb. >> Useful when the developer does not invoke QEMU directly,

[Bug 1888601] Re: QEMU v5.1.0-rc0/rc1 hang with nested virtualization

Hi Jason, See Comment#10 for trace -- 5.1.0-rc2 includes that fix... https://github.com/qemu/qemu/commit/a48aaf882b100b30111b5c7c75e1d9e83fe76cfd ... so hang is still happening. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:

Re: [PATCH V1 07/32] savevm: QMP command for cprinfo

On 7/30/2020 12:17 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> Provide the cprinfo QMP command.  This returns a string with a space- >> separated list of modes supported by cprsave, and can be used by clients >> as a feature test to check if the running QEMU instance suppor

Re: [PATCH V1 05/32] savevm: QMP command for cprload

On 7/30/2020 12:14 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> Provide the cprload QMP command.  The VM is created from the file produced >> by the cprsave command.  Guest RAM is restored in-place from the shared >> memory backend file, and guest block devices are used as i

Re: [PATCH V1 03/32] savevm: QMP command for cprsave

On 7/30/2020 12:12 PM, Eric Blake wrote: > On 7/30/20 10:14 AM, Steve Sistare wrote: >> To enable live reboot, provide the cprsave QMP command and the VMS_REBOOT >> vmstate-saving operation, which saves the state of the virtual machine in a >> simple file. >> >> Syntax: >>    {'command':'cprsave',

Re: [PATCH V1 00/32] Live Update

* Steve Sistare (steven.sist...@oracle.com) wrote: > Improve and extend the qemu functions that save and restore VM state so a > guest may be suspended and resumed with minimal pause time. qemu may be > updated to a new version in between. Nice. > The first set of patches adds the cprsave and cp

Re: device compatibility interface for live migration with assigned devices

On Thu, 30 Jul 2020 11:41:04 +0800 Yan Zhao wrote: > On Wed, Jul 29, 2020 at 01:12:55PM -0600, Alex Williamson wrote: > > On Wed, 29 Jul 2020 12:28:46 +0100 > > Sean Mooney wrote: > > > > > On Wed, 2020-07-29 at 16:05 +0800, Yan Zhao wrote: > > > > On Mon, Jul 27, 2020 at 04:23:21PM -0600,

Re: [PATCH V1 00/32] Live Update

On 30/07/20 17:14, Steve Sistare wrote: > The first set of patches adds the cprsave and cprload commands to save and > restore VM state, and allow the host kernel to be updated and rebooted in > between. The VM must create guest RAM in a persistent shared memory file, > such as /dev/dax0.0 or pers

Re: [PATCH 1/2] hw/net/net_tx_pkt: add function to check pkt->max_raw_frags

On Thu, Jul 30, 2020 at 7:28 AM Jason Wang wrote: > > > On 2020/7/29 上午12:26, Mauro Matteo Cascella wrote: > > On Tue, Jul 28, 2020 at 6:06 AM Jason Wang wrote: > >> > >> On 2020/7/28 上午1:08, Mauro Matteo Cascella wrote: > >>> This patch introduces a new function in hw/net/net_tx_pkt.{c,h} to che

Re: [PATCH V1 12/32] vl: pause option

Steve Sistare writes: > Provide the -pause command-line parameter and the QEMU_PAUSE environment > variable to briefly pause QEMU in main and allow a developer to attach gdb. > Useful when the developer does not invoke QEMU directly, such as when using > libvirt. How does this differ from -S?

[PATCH-for-5.2 1/2] hw/mips/mipssim: Use MMIO serial device on fake ISA I/O

The 'mipssim' is not a real hardware, it is a simulator. There is an ISA MMIO space mapped at 0x1fd0, however this is not a real ISA bus (no ISA IRQ). So can not use the TYPE_ISA_SERIAL device... Instead we have been using a plain MMIO device, but named it IO. TYPE_SERIAL_IO is a superset of

[PATCH-for-5.2 0/2] hw/char: Remove TYPE_SERIAL_IO

Remove the TYPE_SERIAL_IO which is simply a superset of TYPE_SERIAL_MM, as suggested by Paolo and Peter here: https://www.mail-archive.com/qemu-devel@nongnu.org/msg721806.html Philippe Mathieu-Daudé (2): hw/mips/mipssim: Use MMIO serial device on fake ISA I/O hw/char/serial: Remove TYPE_SERIAL

[PATCH-for-5.2 2/2] hw/char/serial: Remove TYPE_SERIAL_IO (superset of TYPE_SERIAL_MM)

TYPE_SERIAL_IO is a superset of TYPE_SERIAL_MM, and it is not used anymore. Remove it. Suggested-by: Paolo Bonzini Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- include/hw/char/serial.h | 9 - hw/char/serial.c | 41 --

Re: [PATCH for-5.2] spapr: Avoid some integer conversions in spapr_phb_realize()

On Wed, 29 Jul 2020 12:54:41 +1000 David Gibson wrote: > On Tue, Jul 28, 2020 at 11:14:13AM +0200, Greg Kurz wrote: > > Without this patch, the irq number gets converted uselessly from int > > to int32_t, back and forth. > > > > This doesn't fix an actual issue, it's just to make the code neater

Re: [PATCH V1 00/32] Live Update

On Thu, Jul 30, 2020 at 08:14:04AM -0700, Steve Sistare wrote: > Improve and extend the qemu functions that save and restore VM state so a > guest may be suspended and resumed with minimal pause time. qemu may be > updated to a new version in between. > > The first set of patches adds the cprsave

Re: [PATCH] osdep.h: Add doc comment for qemu_get_thread_id()

On Thu, Jul 30, 2020 at 11:24:51AM -0500, Eric Blake wrote: > On 7/30/20 10:59 AM, Daniel P. Berrangé wrote: > > > > Well, I suspect that management-layer code currently has > > > gone for "assume we're always running on Linux" and was > > > written by people who knew they were getting a Linux tid

Re: [PATCH 3/3] cpu-timers, icount: new modules

On 7/29/20 12:01 PM, Paolo Bonzini wrote: > On 29/07/20 10:48, Claudio Fontana wrote: >>> If you want you can add to your accelerator ops series one for >>> qemu_get_clock_ns(QEMU_CLOCK_VIRTUAL), cpu_get_ticks() and >>> qemu_start_warp_timer(), that would certainly work for me; >> >> The problem I

Re: [PATCH] osdep.h: Add doc comment for qemu_get_thread_id()

On 7/30/20 10:59 AM, Daniel P. Berrangé wrote: Well, I suspect that management-layer code currently has gone for "assume we're always running on Linux" and was written by people who knew they were getting a Linux tid... Yes, on the libvirt side, the functionality that relies on thread_is is on

Re: [PATCH V1 14/32] savevm: VMS_RESTART and cprsave restart

On 7/30/20 10:14 AM, Steve Sistare wrote: Add the VMS_RESTART variant of vmstate, for use when upgrading qemu in place on the same host without a reboot. Invoke it using: cprsave restart VMS_RESTART supports guest ram mapped by private anonymous memory, versus VMS_REBOOT which requires that

Re: [PATCH V1 12/32] vl: pause option

On 7/30/20 10:14 AM, Steve Sistare wrote: Provide the -pause command-line parameter and the QEMU_PAUSE environment variable to briefly pause QEMU in main and allow a developer to attach gdb. Useful when the developer does not invoke QEMU directly, such as when using libvirt. How would you set t

Re: [Bug 1889621] Re: ARM Highbank Crashes Realted to GIC

On 200730 1550, Peter Maydell wrote: > I haven't looked at reproducer #1, but is it a fuzzer-specific variant > of LP:1602247 (trying to read the "for this CPU" registers from > something other than a CPU doesn't work) ? That was my initial suspicion as well, but it looks like the SEGV happens her

Re: [PATCH V1 07/32] savevm: QMP command for cprinfo

On 7/30/20 10:14 AM, Steve Sistare wrote: Provide the cprinfo QMP command. This returns a string with a space- separated list of modes supported by cprsave, and can be used by clients as a feature test to check if the running QEMU instance supports cprsave. When you've already got array suppor

Re: [PATCH for-5.1] tracetool: carefully define SDT_USE_VARIADIC

On 7/29/20 5:39 PM, Stefan Hajnoczi wrote: > The dtrace backend defines SDT_USE_VARIADIC as a workaround for a > conflict with a LTTng UST header file, which requires SDT_USE_VARIADIC > to be defined. > > LTTng UST breaks if included after generated dtrace > headers because SDT_USE_VARIADIC will

Re: [PATCH V1 05/32] savevm: QMP command for cprload

On 7/30/20 10:14 AM, Steve Sistare wrote: Provide the cprload QMP command. The VM is created from the file produced by the cprsave command. Guest RAM is restored in-place from the shared memory backend file, and guest block devices are used as is. The contents of such devices must not be modif

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

On 7/30/20 5:58 PM, Michael S. Tsirkin wrote: > macOS uses ACPI UIDs to build the DevicePath for NVRAM boot options, > while OVMF firmware gets them via an internal channel through QEMU. > Due to a bug in QEMU ACPI currently UEFI firmware and ACPI have > different values, and this makes the underly

Re: [PATCH V1 03/32] savevm: QMP command for cprsave

On 7/30/20 10:14 AM, Steve Sistare wrote: To enable live reboot, provide the cprsave QMP command and the VMS_REBOOT vmstate-saving operation, which saves the state of the virtual machine in a simple file. Syntax: {'command':'cprsave', 'data':{'file':'str', 'mode':'str'}} The mode argument

Re: [PATCH 2/2] arm/acpi: fix an out of spec _UID for PCI root

On 7/30/20 5:58 PM, Michael S. Tsirkin wrote: > On ARM/virt machine type QEMU currently reports an incorrect _UID in > ACPI. > > The particular node in question is the primary PciRoot (PCI0 in ACPI), > which gets assigned PCI0 in ACPI UID and 0 in the > DevicePath. This is due to the _UID assigned

Re: [PATCH 0/1] RFC: pcie: parital fix for missing unplug events

On Wed, Jul 22, 2020 at 07:17:21PM +0300, Maxim Levitsky wrote: > As described in bugzilla #1854264 it is possible to plug > a pcie device and then unplug it before the guest notices > (has time to process the attention button press) > > To partially fix this issue, detect and refuse the hotunplug

Re: [PATCH 1/1] pci/pcie: refuse another hotplug/unplug event if attention button is pending

On Wed, Jul 22, 2020 at 07:17:22PM +0300, Maxim Levitsky wrote: > Curently it is possible to hotplug a device and then immediatly > hotunplug it before the OS notices, and that will result > in missed unplug event since we can only send one attention button event. > > Moreover the device will stuc

[Bug 1889621] Re: ARM Highbank Crashes Realted to GIC

I haven't looked at reproducer #1, but is it a fuzzer-specific variant of LP:1602247 (trying to read the "for this CPU" registers from something other than a CPU doesn't work) ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

[PATCH] [v4] linux-user: add option to intercept execve() syscalls

This patch is based on the original work by Petros Angelatos [1], which I have updated to the current git master. The following commit message is largely based on Petros' original message. In order for one to use QEMU user mode emulation under a chroot, it is required to use binfmt_misc. This can

Re: [Bug 1889621] Re: ARM Highbank Crashes Realted to GIC

On 200730 1531, Philippe Mathieu-Daudé wrote: > Why put all these bugs in the same ticket? Thought they might have a similar root cause, though that is evidently wrong.. > For reproducer #2: > > writeq 0xfff11f00 0x613a650f0fda6555 does: > > gic_dist_write dist write at 0x0f00 size 4: 0x0fd

Re: [PATCH] osdep.h: Add doc comment for qemu_get_thread_id()

On Thu, Jul 30, 2020 at 04:52:49PM +0100, Peter Maydell wrote: > On Thu, 30 Jul 2020 at 16:11, Markus Armbruster wrote: > > > > Peter Maydell writes: > > > > > On Tue, 28 Jul 2020 at 16:17, Eric Blake wrote: > > >> > > >> On 7/16/20 10:41 AM, Peter Maydell wrote: > > >> > Add a documentation com

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

On Thu, 23 Jul 2020 at 03:57, Thiago Jung Bauermann wrote: > > The ARM code has a start-powered-off property in ARMCPU, which is a > subclass of CPUState. This property causes arm_cpu_reset() to set > CPUState::halted to 1, signalling that the CPU should start in a halted > state. Other architectu

Re: [PATCH] osdep.h: Add doc comment for qemu_get_thread_id()

On Thu, 30 Jul 2020 at 16:11, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Tue, 28 Jul 2020 at 16:17, Eric Blake wrote: > >> > >> On 7/16/20 10:41 AM, Peter Maydell wrote: > >> > Add a documentation comment for qemu_get_thread_id(): since this > >> > is rather host-OS-specific it'

[PATCH V1 27/32] vhost: reset vhost devices upon cprsave

From: Mark Kanda A vhost device is implicitly preserved across re-exec because its fd is not closed, and the value of the fd is specified on the command line for the new qemu to find. However, new qemu issues an VHOST_RESET_OWNER ioctl, which fails because the device already has an owner. To fi

[PATCH 2/2] arm/acpi: fix an out of spec _UID for PCI root

On ARM/virt machine type QEMU currently reports an incorrect _UID in ACPI. The particular node in question is the primary PciRoot (PCI0 in ACPI), which gets assigned PCI0 in ACPI UID and 0 in the DevicePath. This is due to the _UID assigned to it by build_dsdt in hw/arm/virt-acpi-build.c Which doe

[PATCH V1 30/32] vfio-pci: save and restore

Enable vfio-pci devices to be saved and restored across an exec restart of qemu. At vfio creation time, save the value of vfio container, group, and device descriptors in the environment. In cprsave, save the msi message area as part of vfio-pci vmstate, and clear the close-on-exec flag for the v

  1   2   3   >