Re: [PATCH v6 04/13] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 6:59 PM, Havard Skinnemoen wrote: > +Markus Armbruster > > On Fri, Jul 17, 2020 at 5:20 AM Cédric Le Goater wrote: >> >> On 7/17/20 8:02 AM, Havard Skinnemoen wrote: >>> The Nuvoton NPCM7xx SoC family are used to implement Baseboard >>> Management Controllers in servers. While the fami

Re: [PATCH v6 00/13] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-07-17 Thread Havard Skinnemoen
On Fri, Jul 17, 2020 at 1:32 PM Cédric Le Goater wrote: > > On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > > I also pushed this and the previous two patchsets to my qemu fork on github. > > The branches are named npcm7xx-v[1-6]. > > > > https://github.com/hskinnemoen/qemu > > > > This patch seri

[PATCH v2] goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH

2020-07-17 Thread Jessica Clarke
The specification says: 0x00 TIME_LOW R: Get current time, then return low-order 32-bits. 0x04 TIME_HIGH R: Return high 32-bits from previous TIME_LOW read. ... To read the value, the kernel must perform an IO_READ(TIME_LOW), which returns an unsigned 32-bit value, before an

Re: [PATCH] goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH

2020-07-17 Thread Richard Henderson
On 7/17/20 5:20 PM, Jessica Clarke wrote: > The specification says: > >0x00 TIME_LOW R: Get current time, then return low-order 32-bits. >0x04 TIME_HIGH R: Return high 32-bits from previous TIME_LOW read. > >... > >To read the value, the kernel must perform an IO_READ(TIME_L

[PATCH] goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH

2020-07-17 Thread Jessica Clarke
The specification says: 0x00 TIME_LOW R: Get current time, then return low-order 32-bits. 0x04 TIME_HIGH R: Return high 32-bits from previous TIME_LOW read. ... To read the value, the kernel must perform an IO_READ(TIME_LOW), which returns an unsigned 32-bit value, before an

Re: tests/vm infrastructure fails to notice that QEMU dying is a failure

2020-07-17 Thread John Snow
On 7/17/20 9:25 AM, Philippe Mathieu-Daudé wrote: On 7/17/20 3:22 PM, Philippe Mathieu-Daudé wrote: Cc'ing John & Cleber. On 7/17/20 3:08 PM, Peter Maydell wrote: If you run vm-build-openbsd, our makefile/scripting infrastructure seems to fail to notice that death of the QEMU process that's ru

Re: [PATCH-for-5.2] hw/vfio: Move some target-independent devices to common-objs

2020-07-17 Thread Alex Williamson
On Wed, 15 Jul 2020 15:13:22 +0200 Philippe Mathieu-Daudé wrote: > These devices do not depend on the target CPU configuration > (32 or 64-bit, big / little endian). Move them to common-obj > to compile them once for all the targets. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/vfio/Ma

[Bug 1880287] Re: gcc crashes in hppa emulation

2020-07-17 Thread Helge Deller
Test still crashes the VM and chroot with up-to-date debian chroot, including updated gcc-9.3.0-14. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880287 Title: gcc crashes in hppa emulation Statu

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Havard Skinnemoen
On Fri, Jul 17, 2020 at 1:52 PM Philippe Mathieu-Daudé wrote: > > On 7/17/20 9:18 PM, Havard Skinnemoen wrote: > > On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé > > wrote: > >> > >> On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: > >>> On 7/17/20 10:03 AM, Thomas Huth wrote: > O

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 9:18 PM, Havard Skinnemoen wrote: > On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé > wrote: >> >> On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: >>> On 7/17/20 10:03 AM, Thomas Huth wrote: On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: > +Thomas > On 7

[PATCH v1 2/3] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-17 Thread Robert Foley
The primary purpose of this change is to clean up machine.py's console_socket property to return a single type, a ConsoleSocket. ConsoleSocket now derives from a socket, which means that in the default case (of not draining), machine.py will see the same behavior as it did prior to ConsoleSocket.

[PATCH v1 3/3] tests/vm: add shutdown timeout in basevm.py

2020-07-17 Thread Robert Foley
We are adding the shutdown timeout to solve an issue we now see where the aarch64 VMs timeout on shutdown under TCG. There is a new 3 second timeout in machine.py, which we override in basevm.py when shutting down. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 15 ++- 1 file

[PATCH v1 1/3] python/qemu: Cleanup changes to ConsoleSocket

2020-07-17 Thread Robert Foley
The changes to console_socket.py and machine.py are to cleanup for pylint and flake8. Reviewed-by: Alex Bennée Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 57 ++- python/qemu/machine.py| 7 +++-- python/qemu/pylintrc | 2 +-

[PATCH v1 0/3] python/qemu: follow-up changes for ConsoleSocket

2020-07-17 Thread Robert Foley
For v1, we added a few minor changes, and also added one new patch in tests/vm to add a shutdown timeout. This fixes an issue we saw in testing the aarch64 VMs with TCG. This patch series introduces a few follow-up changes after the introduction of ConsoleSocket. The first patch introduces cl

Re: [PATCH v6 00/13] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-07-17 Thread Cédric Le Goater
On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > I also pushed this and the previous two patchsets to my qemu fork on github. > The branches are named npcm7xx-v[1-6]. > > https://github.com/hskinnemoen/qemu > > This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to > boot > a

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Cédric Le Goater
On 7/17/20 9:18 PM, Havard Skinnemoen wrote: > On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé > wrote: >> >> On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: >>> On 7/17/20 10:03 AM, Thomas Huth wrote: On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: > +Thomas > On 7

Re: [PATCH v1 1/5] shippable: add one more qemu to registry url

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 12:51 PM, Alex Bennée wrote: > The registry url is //qemu/ > > Perhaps we should rationalise that some day but for now. > > Signed-off-by: Alex Bennée > --- > .shippable.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.shippable.yml b/.shippable.yml > in

[Bug 1878641] Re: Abort() in mch_update_pciexbar

2020-07-17 Thread Philippe Mathieu-Daudé
Proposed fix: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg05612.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878641 Title: Abort() in mch_update_pciexbar Status in QEMU: New

Re: [RFC PATCH-for-5.1] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 8:38 PM, Richard Henderson wrote: > On 7/17/20 11:17 AM, Philippe Mathieu-Daudé wrote: >> case MCH_HOST_BRIDGE_PCIEXBAR_LENGTH_RVD: >> -default: >> -abort(); >> +qemu_log_mask(LOG_GUEST_ERROR, "Q35: Reserved PCIEXBAR LENGTH\n"); >> +return; >> } > >

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Havard Skinnemoen
On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé wrote: > > On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: > > On 7/17/20 10:03 AM, Thomas Huth wrote: > >> On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: > >>> +Thomas > >> > >>> On 7/16/20 10:56 PM, Havard Skinnemoen wrote: > On

Re: [RFC PATCH-for-5.1] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

2020-07-17 Thread Richard Henderson
On 7/17/20 11:17 AM, Philippe Mathieu-Daudé wrote: > case MCH_HOST_BRIDGE_PCIEXBAR_LENGTH_RVD: > -default: > -abort(); > +qemu_log_mask(LOG_GUEST_ERROR, "Q35: Reserved PCIEXBAR LENGTH\n"); > +return; > } Did you really want to remove the default case? I guess

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Alex Williamson
On Fri, 17 Jul 2020 19:03:44 +0100 "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Wed, 15 Jul 2020 16:20:41 +0800 > > Yan Zhao wrote: > > > > > On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > > > > On Tue, 14 Jul 2020 18:19:

Re: [PATCH] target/i386: floatx80: avoid compound literals in static initializers

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 6:46 PM, Laszlo Ersek wrote: > On 07/17/20 11:26, Laszlo Ersek wrote: >> On 07/16/20 17:09, Philippe Mathieu-Daudé wrote: >>> On 7/16/20 4:42 PM, Laszlo Ersek wrote: Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an object that has static storage duration s

[PULL for-5.1 3/3] tcg/cpu-exec: precise single-stepping after an interrupt

2020-07-17 Thread Richard Henderson
When single-stepping with a debugger attached to QEMU, and when an interrupt is raised, the debugger misses the first instruction after the interrupt. Tested-by: Luc Michel Reviewed-by: Luc Michel Buglink: https://bugs.launchpad.net/qemu/+bug/757702 Message-Id: <20200717163029.2737546-1-richard.

[RFC PATCH-for-5.1] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

2020-07-17 Thread Philippe Mathieu-Daudé
libFuzzer triggered the following assertion: cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ -nographic -monitor none -serial none \ -qtest stdio -d guest_errors -trace pci\* outl 0xcf8 0xf260 outl 0xcfc 0x8400056e EOF pci_cfg_write mch 00:0 @0x60 <- 0x8400056e Aborted (core

[PULL for-5.1 0/3] tcg patch queue

2020-07-17 Thread Richard Henderson
s/pull-tcg-20200717 for you to fetch changes up to ba3c35d9c4026361fd380b269dc6def9510b7166: tcg/cpu-exec: precise single-stepping after an interrupt (2020-07-17 11:09:34 -0700) Fix vector min/max fallback expansion Fix singl

[PULL for-5.1 1/3] tcg: Save/restore vecop_list around minmax fallback

2020-07-17 Thread Richard Henderson
Forgetting this asserts when tcg_gen_cmp_vec is called from within tcg_gen_cmpsel_vec. Fixes: 72b4c792c7a Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index f784517d84..ed6fb55fe1 100644 --- a/tcg/

[PULL for-5.1 2/3] tcg/cpu-exec: precise single-stepping after an exception

2020-07-17 Thread Richard Henderson
From: Luc Michel When single-stepping with a debugger attached to QEMU, and when an exception is raised, the debugger misses the first instruction after the exception: $ qemu-system-aarch64 -M virt -display none -cpu cortex-a53 -s -S $ aarch64-linux-gnu-gdb GNU gdb (GDB) 9.2 [...] (gdb) tar rem

Re: [PATCH v1 4/5] util: add qemu_get_host_physmem utility function

2020-07-17 Thread Richard Henderson
On 7/17/20 3:51 AM, Alex Bennée wrote: > +size_t qemu_get_host_physmem(void) > +{ > +#ifdef _SC_PHYS_PAGES > +long pages = sysconf(_SC_PHYS_PAGES); > +if (pages > 0) { > +return pages * qemu_real_host_page_size; > +} > +#endif > +return 0; > +} Is it worth examining our own

Re: [PATCH] tcg/cpu-exec: precise single-stepping after an interrupt

2020-07-17 Thread Luc Michel
On 7/17/20 6:30 PM, Richard Henderson wrote: When single-stepping with a debugger attached to QEMU, and when an interrupt is raised, the debugger misses the first instruction after the interrupt. Buglink: https://bugs.launchpad.net/qemu/+bug/757702 Signed-off-by: Richard Henderson Reviewed-by

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Wed, 15 Jul 2020 16:20:41 +0800 > Yan Zhao wrote: > > > On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > > > On Tue, 14 Jul 2020 18:19:46 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Alex Williamson (a

Re: [PATCH v1 4/5] util: add qemu_get_host_physmem utility function

2020-07-17 Thread Richard Henderson
On 7/17/20 7:24 AM, Christian Ehrhardt wrote: > > +size_t qemu_get_host_physmem(void) > > +{ > > +#ifdef _SC_PHYS_PAGES > > +    long pages = sysconf(_SC_PHYS_PAGES); > > +    if (pages > 0) { > > +        return pages * qemu_real_host_page_size; > > The Linux man page

Re: [PATCH v2] virtiofsd: Remove "norace" from cmdline help and docs

2020-07-17 Thread Dr. David Alan Gilbert
* Sergio Lopez (s...@redhat.com) wrote: > Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed > the implementation of the "norace" option, so remove it from the > cmdline help and the documentation too. > > Signed-off-by: Sergio Lopez > Reviewed-by: Philippe Mathieu-Daudé > Revi

[Bug 1878255] Re: Assertion failure in bdrv_aio_cancel, through ide

2020-07-17 Thread Philippe Mathieu-Daudé
Proposed fix: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg05595.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878255 Title: Assertion failure in bdrv_aio_cancel, through ide Sta

[Bug 1878043] Re: memcpy param-overlap in Slirp ip_stripoptions through e1000e

2020-07-17 Thread Dr. David Alan Gilbert
Committed in upstream libslirp: commit d620bac888923524f8b8407dbf35f6d2b3b7ddb2 (origin/lp1878043, lp1878043) Author: Dr. David Alan Gilbert Date: Fri Jul 17 18:17:41 2020 +0100 ip_stripoptions use memmove -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [PATCH v1 3/5] semihosting: don't send the trailing '\0'

2020-07-17 Thread Richard Henderson
On 7/17/20 3:51 AM, Alex Bennée wrote: > From: KONRAD Frederic > > Don't send the trailing 0 from the string. > > Signed-off-by: KONRAD Frederic > Signed-off-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé > Message-Id: <1592215252-26742-2-git-send-email-frederic.kon...@adacore.com> > -

Re: [PATCH v1 2/5] semihosting: defer connect_chardevs a little more to use serialx

2020-07-17 Thread Richard Henderson
On 7/17/20 3:51 AM, Alex Bennée wrote: > From: KONRAD Frederic > > With that we can just use -semihosting-config chardev=serial0. > > Signed-off-by: KONRAD Frederic > Message-Id: <1592215252-26742-1-git-send-email-frederic.kon...@adacore.com> > [AJB: tweak commit message] > Signed-off-by: Alex

[Bug 1878043] Re: memcpy param-overlap in Slirp ip_stripoptions through e1000e

2020-07-17 Thread Dr. David Alan Gilbert
Created patch and merge request in upstream libslirp: https://gitlab.freedesktop.org/dgilbert/libslirp/-/commit/d620bac888923524f8b8407dbf35f6d2b3b7ddb2 ** Changed in: qemu Assignee: (unassigned) => Dr. David Alan Gilbert (dgilbert-h) ** Changed in: qemu Status: New => In Progress -

[PATCH for-5.2] spapr: Simplify error handling in spapr_phb_realize()

2020-07-17 Thread Greg Kurz
The spapr_phb_realize() function has a local_err variable which is used to: 1) check failures of spapr_irq_findone() and spapr_irq_claim() 2) prepend extra information to the error message Recent work from Markus Armbruster highlighted we get better code when testing the return value of a functi

Re: [RFC PATCH-for-5.1] hw/ide: Do not block for AIO while resetting a drive

2020-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200717171938.1249-1-f4...@amsat.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

[RFC PATCH-for-5.1] hw/ide: Do not block for AIO while resetting a drive

2020-07-17 Thread Philippe Mathieu-Daudé
libFuzzer triggered the following assertion: cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ -nographic -monitor none -serial none \ -qtest stdio -trace ide\* outl 0xcf8 0x8000fa24 outl 0xcfc 0xe106c000 outl 0xcf8 0x8000fa04 outw 0xcfc 0x7 outl 0xcf8 0x8000fb20 write 0x0 0x3 0x

Re: sysbus_create_simple Vs qdev_create

2020-07-17 Thread Peter Maydell
On Fri, 17 Jul 2020 at 17:32, Daniel P. Berrangé wrote: > Personally I've not seen a problem with the term "parent" in > this scenario. The class inheritance metaphor maps reasonably > clearly to a parent/child metaphor. It's not bad in itself; it's just that it means almost all of our objects ar

Re: Inter-VM device emulation (call on Mon 20th July 2020)

2020-07-17 Thread Stefan Hajnoczi
On Fri, Jul 17, 2020 at 11:58:40AM +0300, Nikos Dragazis wrote: > On 15/7/20 7:44 μ.μ., Alex Bennée wrote: > > > Stefan Hajnoczi writes: > > > > > On Wed, Jul 15, 2020 at 01:28:07PM +0200, Jan Kiszka wrote: > > > > On 15.07.20 13:23, Stefan Hajnoczi wrote: > > > > > Let's have a call to figure o

Re: [PATCH] fuzz: Fix leak when assembling datadir path string

2020-07-17 Thread Alexander Bulekov
On 200717 1847, Thomas Huth wrote: > On 17/07/2020 18.35, Alexander Bulekov wrote: > > We freed the string containing the final datadir path, but did not free > > the path to the executable's directory that we get from > > g_path_get_dirname(). Fix that. > > > > Reported-by: Thomas Huth > > Signe

Re: [PATCH v6 04/13] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-17 Thread Havard Skinnemoen
+Markus Armbruster On Fri, Jul 17, 2020 at 5:20 AM Cédric Le Goater wrote: > > On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > > The Nuvoton NPCM7xx SoC family are used to implement Baseboard > > Management Controllers in servers. While the family includes four SoCs, > > this patch implements limi

Re: [PATCH] fuzz: Fix leak when assembling datadir path string

2020-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200717163523.1591-1-alx...@bu.edu/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /bin

[PATCH] fuzz: Fix leak when assembling datadir path string

2020-07-17 Thread Alexander Bulekov
We freed the string containing the final datadir path, but did not free the path to the executable's directory that we get from g_path_get_dirname(). Fix that. Reported-by: Thomas Huth Signed-off-by: Alexander Bulekov --- I ran it with Thomas' fixed build-oss-fuzz job: https://gitlab.com/a1xndr

[GIT PULL] IPMI updates

2020-07-17 Thread Corey Minyard
The following changes since commit 95d1fbabae0cd44156ac4b96d512d143ca7dfd5e: Merge remote-tracking branch 'remotes/kraxel/tags/fixes-20200716-pull-request' into staging (2020-07-16 18:50:51 +0100) are available in the Git repository at: https://github.com/cminyard/qemu.git tags/for-qemu-ip

Re: [PATCH] fuzz: Fix leak when assembling datadir path string

2020-07-17 Thread Thomas Huth
On 17/07/2020 18.35, Alexander Bulekov wrote: > We freed the string containing the final datadir path, but did not free > the path to the executable's directory that we get from > g_path_get_dirname(). Fix that. > > Reported-by: Thomas Huth > Signed-off-by: Alexander Bulekov > --- > > I ran it

Re: [PATCH] target/i386: floatx80: avoid compound literals in static initializers

2020-07-17 Thread Laszlo Ersek
On 07/17/20 11:26, Laszlo Ersek wrote: > On 07/16/20 17:09, Philippe Mathieu-Daudé wrote: >> On 7/16/20 4:42 PM, Laszlo Ersek wrote: >>> Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an >>> object that has static storage duration shall be constant expressions or >>> string lit

Re: sysbus_create_simple Vs qdev_create

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 12:23:12PM -0400, Eduardo Habkost wrote: > On Fri, Jul 17, 2020 at 07:10:57AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > I'd also note that the use of "parent" in the code is also > > > ambiguous. It can mean: > > > > > > * QOM parent type, i.e.

[PATCH] tcg/cpu-exec: precise single-stepping after an interrupt

2020-07-17 Thread Richard Henderson
When single-stepping with a debugger attached to QEMU, and when an interrupt is raised, the debugger misses the first instruction after the interrupt. Buglink: https://bugs.launchpad.net/qemu/+bug/757702 Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 8 +++- 1 file changed, 7 in

Re: [PATCH v3 3/9] vfio: add quirk device write method

2020-07-17 Thread Alex Williamson
On Fri, 17 Jul 2020 16:57:40 +0100 Peter Maydell wrote: > On Fri, 17 Jul 2020 at 16:54, Alex Williamson > wrote: > > > > On Thu, 16 Jul 2020 18:46:33 +0100 > > Peter Maydell wrote: > > > > > Alex (Williamson) -- as the vfio maintainer, do you have a view > > > on whether we should be logging

Re: sysbus_create_simple Vs qdev_create

2020-07-17 Thread Eduardo Habkost
On Fri, Jul 17, 2020 at 07:10:57AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > I'd also note that the use of "parent" in the code is also > > ambiguous. It can mean: > > > > * QOM parent type, i.e. TypeInfo.parent. Related fields: > > * parent_class members of class struct

Re: [virtio-comment] [RFC] ivshmem v2: Shared memory device specification

2020-07-17 Thread Jan Kiszka
On 15.07.20 15:27, Stefan Hajnoczi wrote: On Mon, May 25, 2020 at 09:58:28AM +0200, Jan Kiszka wrote: IVSHMEM Device Specification ** NOTE: THIS IS WORK-IN-PROGRESS, NOT YET A STABLE INTERFACE SPECIFICATION! ** Hi Jan, Thanks for posting this! I have a posted comm

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Alex Williamson
On Thu, 16 Jul 2020 16:32:30 +0800 Yan Zhao wrote: > On Thu, Jul 16, 2020 at 12:16:26PM +0800, Jason Wang wrote: > > > > On 2020/7/14 上午7:29, Yan Zhao wrote: > > > hi folks, > > > we are defining a device migration compatibility interface that helps > > > upper > > > layer stack like openstac

Re: [PATCH v3 3/9] vfio: add quirk device write method

2020-07-17 Thread Peter Maydell
On Fri, 17 Jul 2020 at 16:54, Alex Williamson wrote: > > On Thu, 16 Jul 2020 18:46:33 +0100 > Peter Maydell wrote: > > > Alex (Williamson) -- as the vfio maintainer, do you have a view > > on whether we should be logging write accesses to port 0x3c3 > > here as guest-errors or unimplemented-QEMU-

Re: [PATCH v3 3/9] vfio: add quirk device write method

2020-07-17 Thread Alex Williamson
On Thu, 16 Jul 2020 18:46:33 +0100 Peter Maydell wrote: > On Tue, 30 Jun 2020 at 13:30, P J P wrote: > > > > From: Prasad J Pandit > > > > Add vfio quirk device mmio write method to avoid NULL pointer > > dereference issue. > > > > Reported-by: Lei Sun > > Reviewed-by: Li Qiang > > Signed-off

Re: [PATCH] e1000e: using bottom half to send packets

2020-07-17 Thread Peter Maydell
On Fri, 17 Jul 2020 at 04:11, Jason Wang wrote: > I think several things were missed in this patch (take virtio-net as a > reference), do we need the following things: > > - Cancel the bh when VM is stopped. Similarly, what should we do with the bh when the device is reset ? > - A throttle to pr

Re: [PATCH] e1000e: using bottom half to send packets

2020-07-17 Thread Li Qiang
Jason Wang 于2020年7月17日周五 下午1:39写道: > > > On 2020/7/17 下午12:46, Li Qiang wrote: > > Jason Wang 于2020年7月17日周五 上午11:10写道: > >> > >> On 2020/7/17 上午12:14, Li Qiang wrote: > >>> Alexander Bulekov reported a UAF bug related e1000e packets send. > >>> > >>> -->https://bugs.launchpad.net/qemu/+bug/188636

Re: Implement standard file operation with QEMU

2020-07-17 Thread Peter Maydell
On Fri, 17 Jul 2020 at 16:28, casmac wrote: >What I want to realize is to be able to call standard file operations > (open, read, write etc) in the application program, and execute such programs > in QEMU. But I am building under system mode. >TI provide copilation toolchain and a librar

Re: [RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-17 Thread Richard Henderson
On 7/17/20 4:01 AM, Luc Michel wrote: > I wrote a small test case for the interrupt side that can be run on the > virt board: ... > This is with your fix. Without it, the second stepi stops on 0x284. Awesome, thanks. > Do you want me to send it? If yes, how should I give credit to you? > Should I

Re: [PATCH] gitlab-ci.yml: Add oss-fuzz build tests

2020-07-17 Thread Thomas Huth
On 17/07/2020 15.20, Alexander Bulekov wrote: > On 200717 0951, Thomas Huth wrote: >> On 17/07/2020 07.40, Thomas Huth wrote: [...] >> I think I've got it basically working like this: >> >> build-oss-fuzz: >> <<: *native_build_job_definition >> variables: >> IMAGE: fedora >> script: >>

Re: [PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean"

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 5:25 PM, Peter Maydell wrote: > The config-devices.mak files are generated by "make", and so they > should be deleted by "make clean". > > (This is different from config-host.mak and config-all-disas.mak, > which are created by "configure" and so only deleted by > "make distclen".) typ

Re: Implement standard file operation with QEMU

2020-07-17 Thread casmac
Hello Phil,    What I want to realize is to be able to call standard file operations (open, read, write etc) in the application program, and execute such programs in QEMU. But I am building under system mode.    TI provide copilation toolchain and a library that provide partial functionality fro

[Bug 1878642] Re: Assertion failure in pci_bus_get_irq_level

2020-07-17 Thread Philippe Mathieu-Daudé
Proposed fix: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg05564.html ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878642 Title: A

[Bug 1887309] Re: Floating-point exception in ide_set_sector

2020-07-17 Thread Philippe Mathieu-Daudé
Proposed fix: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg05528.html ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1887309 Title: F

[PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean"

2020-07-17 Thread Peter Maydell
The config-devices.mak files are generated by "make", and so they should be deleted by "make clean". (This is different from config-host.mak and config-all-disas.mak, which are created by "configure" and so only deleted by "make distclen".) If we don't delete these files on "make clean", then the

Re: [PATCH v2 05/20] block/block-copy: implement block_copy_async

2020-07-17 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 17:00, Max Reitz wrote: On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: We'll need async block-copy invocation to use in backup directly. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-copy.h | 13 + block/block-copy.c | 40

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Alex Williamson
On Wed, 15 Jul 2020 15:37:19 +0800 Alex Xu wrote: > Alex Williamson 于2020年7月15日周三 上午5:00写道: > > > On Tue, 14 Jul 2020 18:19:46 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > > On Tue, 14 Jul 2020 11:21:29 +0100 > > > > Daniel

Re: [PATCH v2 03/20] qapi: backup: add x-use-copy-range parameter

2020-07-17 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 16:15, Max Reitz wrote: On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: Add parameter to enable/disable copy_range. Keep current default for now (enabled). Why x-, though? I can’t think of a reason why we would have to remove this. I add some x- arguments in these series:

[RFC PATCH-for-5.1] hw/isa/lpc_ich9: Ignore reserved/invalid SCI IRQ

2020-07-17 Thread Philippe Mathieu-Daudé
libFuzzer triggered the following assertion: cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ -nographic -monitor none -serial none \ -qtest stdio -d guest_errors -trace pci\* outl 0xcf8 0x8400f841 outl 0xcfc 0xebed205d outl 0x5d02 0xedf82049 EOF pci_cfg_write ICH9-LPC 31:0 @0x41

[PULL 0/1] bitmaps patches for 2020-07-17 [-rc1]

2020-07-17 Thread Eric Blake
The following changes since commit 151f76c689b1ff4c2c59e6d8469a0d4fe5346f55: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2020-07-16 21:46:18 +0100) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-bitmaps-2020-0

[PULL 1/1] migration/block-dirty-bitmap: fix add_bitmaps_to_list

2020-07-17 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We shouldn't fail when finding an unnamed bitmap in a unnamed node or node with auto-generated node name, as bitmap migration ignores such bitmaps in the first place. Fixes: 82640edb88faa Fixes: 4ff5cc121b089 Signed-off-by: Vladimir Sementsov-Ogievskiy Message

Re: [PATCH 2/7] pc-bios: s390x: Cleanup jump to ipl code

2020-07-17 Thread Thomas Huth
On 15/07/2020 11.40, Janosch Frank wrote: > jump_to_IPL_code takes a 64 bit address, masks it with the short psw > address mask and later branches to it using a full 64 bit register. > > * As the masking is not necessary, let's remove it > * Without the mask we can save the ipl address to a static

Re: [PATCH 1/7] pc-bios: s390x: Fix bootmap.c zipl component entry data handling

2020-07-17 Thread Thomas Huth
On 15/07/2020 11.40, Janosch Frank wrote: > The two main types of zipl component entries are execute and > load/data. The last member of the component entry struct therefore > denotes either a PSW or an address. Let's make this a bit more clear > by introducing a union and cleaning up the code that

Re: [PATCH v1 5/5] accel/tcg: better handle memory constrained systems

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 03:55:15PM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Fri, Jul 17, 2020 at 11:51:39AM +0100, Alex Bennée wrote: > >> It turns out there are some 64 bit systems that have relatively low > >> amounts of physical memory available to them (typically CI

Re: [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak

2020-07-17 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 15:01, Kevin Wolf wrote: Am 14.07.2020 um 18:22 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! We've faced crash bug, which is reproducing on master branch as well. The case is described in 01, where fix is suggested. New iotest in 02 crashes without that fix. v3: resend for

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Alex Williamson
On Wed, 15 Jul 2020 16:20:41 +0800 Yan Zhao wrote: > On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > > On Tue, 14 Jul 2020 18:19:46 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > > On Tue, 14 Jul 2020 11:21:

Re: [PATCH v1 5/5] accel/tcg: better handle memory constrained systems

2020-07-17 Thread Alex Bennée
Daniel P. Berrangé writes: > On Fri, Jul 17, 2020 at 11:51:39AM +0100, Alex Bennée wrote: >> It turns out there are some 64 bit systems that have relatively low >> amounts of physical memory available to them (typically CI system). >> Even with swapping available a 1GB translation buffer that f

[PATCH] file-posix: Handle `EINVAL` fallocate return value

2020-07-17 Thread Antoine Damhet
From: Antoine Damhet The `detect-zeroes=unmap` option may issue unaligned `FALLOC_FL_PUNCH_HOLE` requests, raw block devices can (and will) return `EINVAL`, qemu should then write the zeroes to the blockdev instead of issuing an `IO_ERROR`. Signed-off-by: Antoine Damhet --- block/file-posix.c

[PATCH RESEND] file-posix: Handle `EINVAL` fallocate return value

2020-07-17 Thread antoine . damhet
From: Antoine Damhet The `detect-zeroes=unmap` option may issue unaligned `FALLOC_FL_PUNCH_HOLE` requests, raw block devices can (and will) return `EINVAL`, qemu should then write the zeroes to the blockdev instead of issuing an `IO_ERROR`. Signed-off-by: Antoine Damhet --- I am resending this

Re: [PATCH] linux-user: Add strace support for printing arguments for ioctls used for terminals and serial lines

2020-07-17 Thread Laurent Vivier
Le 14/07/2020 à 22:04, Filip Bozuta a écrit : > Functions "print_ioctl()" and "print_syscall_ret_ioctl()" are used > to print arguments of "ioctl()" with "-strace". These functions > use "thunk_print()", which is defined in "thunk.c", to print the > contents of ioctl's third arguments that are not

[PATCH v2 1/4] linux-user: Add support for a group of btrfs inode ioctls

2020-07-17 Thread Filip Bozuta
This patch implements functionality of following ioctls: BTRFS_IOC_INO_LOOKUP - Reading tree root id and path Read tree root id and path for a given file or directory. The name and tree root id are returned in an ioctl's third argument that represents a pointer to a following type:

[PATCH v2 3/4] linux-user: Add support for btrfs ioctls used to manage quota

2020-07-17 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_QUOTA_CTL - Enabling/Disabling quota support Enable or disable quota support for a btrfs filesystem. Quota support is enabled or disabled using the ioctls third argument which represents a pointer to a following type:

[PATCH v2 2/4] linux-user: Add support for two btrfs ioctls used for subvolume

2020-07-17 Thread Filip Bozuta
This patch implements functionality for following ioctl: BTRFS_IOC_DEFAULT_SUBVOL - Setting a default subvolume Set a default subvolume for a btrfs filesystem. The third ioctl's argument is a '__u64' (unsigned long long) which represents the id of a subvolume that is to be set as

[PATCH v2 4/4] linux-user: Add support for btrfs ioctls used to scrub a filesystem

2020-07-17 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_SCRUB - Starting a btrfs filesystem scrub Start a btrfs filesystem scrub. The third ioctls argument is a pointer to a following type: struct btrfs_ioctl_scrub_args { __u64 devid;/*

[PATCH v2 0/4] Add support for a group of btrfs ioctls - 2

2020-07-17 Thread Filip Bozuta
This series covers support for following btrfs ioctls *BTRFS_IOC_DEFAULT_SUBVOL*BTRFS_IOC_QUOTA_RESCAN *BTRFS_IOC_GET_SUBVOL_ROOTREF*BTRFS_IOC_QUOTA_RESCAN_WAIT *BTRFS_IOC_QUOTA_CTL *BTRFS_IOC_SCRUB *BTRFS_IOC_QGROUP_CREATE *BTRFS_IOC_SCRUB_CANCEL

Re: [PATCH v1 5/5] accel/tcg: better handle memory constrained systems

2020-07-17 Thread Daniel P . Berrangé
On Fri, Jul 17, 2020 at 11:51:39AM +0100, Alex Bennée wrote: > It turns out there are some 64 bit systems that have relatively low > amounts of physical memory available to them (typically CI system). > Even with swapping available a 1GB translation buffer that fills up > can put the machine under

Re: TB Cache size grows out of control with qemu 5.0

2020-07-17 Thread Alex Bennée
Christian Ehrhardt writes: > On Thu, Jul 16, 2020 at 6:27 PM Alex Bennée wrote: > >> >> Christian Ehrhardt writes: >> >> > On Wed, Jul 15, 2020 at 5:58 PM BALATON Zoltan >> wrote: >> > >> >> See commit 47a2def4533a2807e48954abd50b32ecb1aaf29a and the next two >> >> following it. >> >> >> > >

Re: [PATCH v1 4/5] util: add qemu_get_host_physmem utility function

2020-07-17 Thread Christian Ehrhardt
On Fri, Jul 17, 2020 at 3:32 PM BALATON Zoltan wrote: > On Fri, 17 Jul 2020, Alex Bennée wrote: > > This will be used in a future patch. For POSIX systems _SC_PHYS_PAGES > > isn't standardised but at least appears in the man pages for > > Open/FreeBSD. The result is advisory so any users of it sh

Re: [PATCH v1 5/5] accel/tcg: better handle memory constrained systems

2020-07-17 Thread Christian Ehrhardt
On Fri, Jul 17, 2020 at 12:51 PM Alex Bennée wrote: > It turns out there are some 64 bit systems that have relatively low > amounts of physical memory available to them (typically CI system). > Even with swapping available a 1GB translation buffer that fills up > can put the machine under increas

[PATCH 0/4] Add support for a group of btrfs ioctls - 2

2020-07-17 Thread Filip Bozuta
This series covers support for following btrfs ioctls *BTRFS_IOC_DEFAULT_SUBVOL*BTRFS_IOC_QUOTA_RESCAN *BTRFS_IOC_GET_SUBVOL_ROOTREF*BTRFS_IOC_QUOTA_RESCAN_WAIT *BTRFS_IOC_QUOTA_CTL *BTRFS_IOC_SCRUB *BTRFS_IOC_QGROUP_CREATE *BTRFS_IOC_SCRUB_CANCEL

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-07-17 Thread Peter Xu
On Thu, Jul 16, 2020 at 10:54:31AM +0800, Jason Wang wrote: > > On 2020/7/16 上午9:00, Peter Xu wrote: > > On Mon, Jul 13, 2020 at 12:04:16PM +0800, Jason Wang wrote: > > > On 2020/7/10 下午9:30, Peter Xu wrote: > > > > On Fri, Jul 10, 2020 at 02:34:11PM +0800, Jason Wang wrote: > > > > > On 2020/7/9

Re: [PATCH] accel/tcg: reduce default code gen buffer on small hosts

2020-07-17 Thread Christian Ehrhardt
On Fri, Jul 17, 2020 at 4:07 PM Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > Since v5.0.0 and 600e17b2 "accel/tcg: increase default code gen buffer > size for 64 bit" in particular qemu with TCG regularly gets OOM Killed > on small hosts. > > The former 47a2def4 "accel/tcg: remo

[PATCH] accel/tcg: reduce default code gen buffer on small hosts

2020-07-17 Thread Christian Ehrhardt
Since v5.0.0 and 600e17b2 "accel/tcg: increase default code gen buffer size for 64 bit" in particular qemu with TCG regularly gets OOM Killed on small hosts. The former 47a2def4 "accel/tcg: remove link between guest ram and TCG cache size" removed the link to guest size which is right, but at leas

[PATCH 3/4] linux-user: Add support for btrfs ioctls used to manage quota

2020-07-17 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_QUOTA_CTL - Enabling/Disabling quota support Enable or disable quota support for a btrfs filesystem. Quota support is enabled or disabled using the ioctls third argument which represents a pointer to a following type:

[PATCH 4/4] linux-user: Add support for btrfs ioctls used to scrub a filesystem

2020-07-17 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_SCRUB - Starting a btrfs filesystem scrub Start a btrfs filesystem scrub. The third ioctls argument is a pointer to a following type: struct btrfs_ioctl_scrub_args { __u64 devid;/*

[PATCH 1/4] linux-user: Add support for a group of btrfs inode ioctls

2020-07-17 Thread Filip Bozuta
This patch implements functionality of following ioctls: BTRFS_IOC_INO_LOOKUP - Reading tree root id and path Read tree root id and path for a given file or directory. The name and tree root id are returned in an ioctl's third argument that represents a pointer to a following type:

[PATCH 2/4] linux-user: Add support for two btrfs ioctls used for subvolume

2020-07-17 Thread Filip Bozuta
This patch implements functionality for following ioctl: BTRFS_IOC_DEFAULT_SUBVOL - Setting a default subvolume Set a default subvolume for a btrfs filesystem. The third ioctl's argument is a '__u64' (unsigned long long) which represents the id of a subvolume that is to be set as

  1   2   3   >