Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-15 Thread Cornelia Huck
On Tue, 14 Jul 2020 18:40:11 +0530 (IST) P J P wrote: > * QEMU would abort(3), if a user attempts to start QEMU with insecure > options >like say -virtfs OR -fda fat:floopy OR -netdev user OR -device tulip ? > > * One way could be to abort(3) at options parsing stage, if 'security' f

Re: [PATCH v2] .mailmap: Update Paul Burton email address

2020-07-15 Thread Philippe Mathieu-Daudé
Hi Paul, Do you mind Acking this patch? QEMU's get_maintainer.pl still selects pbur...@wavecomp.com for various of your contributions and wavesemi.com (where wavecomp.com seems redirected) keeps sending "The recipient email address is incorrect or does not exist in this domain." In case you don't

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-15 Thread Michael S. Tsirkin
On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > Some recent error handling cleanups unveiled issues with our support of > PCI bridges: > > 1) QEMU aborts when using non-standard PCI bridge types, >unveiled by commit 7ef1553dac "spapr_pci: Drop some dead error handling" > > $ qemu

Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-15 Thread Li Qiang
Markus Armbruster 于2020年7月16日周四 下午1:59写道: > > Li Qiang writes: > > > Properly free each test response to avoid memory leak and separate > > qtest_qmp() calls with spare lines, in a consistent manner. > > > > Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add > > qmp/object-add-failure-modes" > > The pat

Re: [RFC for Linux v4 1/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES and inflate_cont_vq

2020-07-15 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 10:41:51AM +0800, Hui Zhu wrote: > diff --git a/include/uapi/linux/virtio_balloon.h > b/include/uapi/linux/virtio_balloon.h > index dc3e656..4d0151a 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -37,6 +37,7 @@ > #define

Re: [PATCH 02/13] qcow2: introduce icount field for snapshots

2020-07-15 Thread Pavel Dovgalyuk
On 06.07.2020 23:17, Eric Blake wrote: On 6/26/20 5:19 AM, Pavel Dovgalyuk wrote: From: Pavel Dovgalyuk This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by:

Re: [RFC for qemu v4 2/2] virtio_balloon: Add dcvq to deflate continuous pages

2020-07-15 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 10:41:55AM +0800, Hui Zhu wrote: > This commit adds a vq dcvq to deflate continuous pages. > When VIRTIO_BALLOON_F_CONT_PAGES is set, try to get continuous pages > from icvq and use madvise MADV_WILLNEED with the pages. > > Signed-off-by: Hui Zhu This is arguably somethin

Re: [RFC for Linux v4 0/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES to report continuous pages

2020-07-15 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 10:41:50AM +0800, Hui Zhu wrote: > The first, second and third version are in [1], [2] and [3]. > Code of current version for Linux and qemu is available in [4] and [5]. > Update of this version: > 1. Report continuous pages will increase the speed. So added deflate >co

Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc"

2020-07-15 Thread Thomas Huth
On 16/07/2020 04.59, sundeep subbaraya wrote: > On Wed, Jul 15, 2020 at 8:12 PM Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> On 7/15/20 4:04 PM, Markus Armbruster wrote: Watch this: $ qemu-system-aarch64 -M ast2600-evb -S -display none -qmp stdio

Re: [PATCH v2] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-15 Thread Cédric Le Goater
On 7/15/20 7:34 PM, erik-smit wrote: > Signed-off-by: erik-smit Reviewed-by: Cédric Le Goater > --- > Changed in v2: > - matched aspeed_machine_supermicrox11_bmc_class_init function name to >machine name > > hw/arm/aspeed.c | 35 +++ > 1 file changed, 35 i

[Bug 1884719] Re: Function not implemented when using libaio

2020-07-15 Thread Martin Grigorov
Thank you for working on this, Laurent! Just let me know and I will test your changes! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1884719 Title: Function not implemented when using libaio Statu

Re: [PATCH 05/13] qapi: introduce replay.json for record/replay-related stuff

2020-07-15 Thread Pavel Dovgalyuk
On 15.07.2020 14:20, Alex Bennée wrote: Pavel Dovgalyuk writes: From: Pavel Dovgalyuk This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster --- 0 files changed diff

Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-15 Thread Markus Armbruster
Li Qiang writes: > Properly free each test response to avoid memory leak and separate > qtest_qmp() calls with spare lines, in a consistent manner. > > Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add > qmp/object-add-failure-modes" The patch also fixes leaks introduced in 442b09b83d and 9fc719b869,

[PATCH] configure: Fix for running with --enable-werror on macOS

2020-07-15 Thread Thomas Huth
The configure script currently refuses to succeed when run on macOS with --enable-werror: ERROR: configure test passed without -Werror but failed with -Werror. The information in config.log indicates: config-temp/qemu-conf.c:3:55: error: control reaches end of non-void function [-Werror,-Wret

[PATCH v5 7/7] Makefile: Ship the generic platform bios ELF images for RISC-V

2020-07-15 Thread Bin Meng
From: Bin Meng At present only the generic platform fw_dynamic bios BIN images are included in the 'make install' target for 'virt' and 'sifive_u' machines. This updates the install blob list to include ELF images which are needed by the 'spike' machine. Signed-off-by: Bin Meng --- Changes in

[PATCH v5 6/7] gitlab-ci/opensbi: Update GitLab CI to build generic platform

2020-07-15 Thread Bin Meng
From: Bin Meng This updates the GitLab CI opensbi job to build opensbi bios images for the generic platform. Signed-off-by: Bin Meng Reviewed-by: Anup Patel Reviewed-by: Alistair Francis --- (no changes since v3) Changes in v3: - Generate fw_dynamic images in the artifacts Changes in v2:

[PATCH v5 5/7] hw/riscv: spike: Change the default bios to use generic platform image

2020-07-15 Thread Bin Meng
From: Bin Meng To keep sync with other RISC-V machines, change the default bios to use generic platform fw_dynamic.elf image. While we are here, add some comments to mention that using ELF files for the Spike machine was intentional. Signed-off-by: Bin Meng Reviewed-by: Anup Patel Reviewed-by

[PATCH v5 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-07-15 Thread Bin Meng
From: Bin Meng Update virt and sifive_u machines to use the opensbi fw_dynamic bios image built for the generic FDT platform. Remove the out-of-date no longer used bios images. Signed-off-by: Bin Meng Reviewed-by: Anup Patel Reviewed-by: Alistair Francis --- Changes in v5: - Include the ge

[PATCH v5 2/7] roms/opensbi: Upgrade from v0.7 to v0.8

2020-07-15 Thread Bin Meng
From: Bin Meng Upgrade OpenSBI from v0.7 to v0.8. The v0.8 release includes the following commits: 1bb00ab lib: No need to provide default PMP region using platform callbacks a9eac67 include: sbi_platform: Combine reboot and shutdown into one callback 6585fab lib: utils: Add SiFive test device

[PATCH v5 3/7] roms/Makefile: Build the generic platform for RISC-V OpenSBI firmware

2020-07-15 Thread Bin Meng
From: Bin Meng The RISC-V generic platform is a flattened device tree (FDT) based platform where all platform specific functionality is provided based on FDT passed by previous booting stage. The support was added in the upstream OpenSBI v0.8 release recently. Update our Makefile to build the ge

[PATCH v5 1/7] configure: Create symbolic links for pc-bios/*.elf files

2020-07-15 Thread Bin Meng
From: Bin Meng Now we need to ship the OpenSBI fw_dynamic.elf image for the RISC-V Spike machine, it requires us to create symbolic links for pc-bios/*.elf files. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- (no changes since v2) Changes in v2: - new patch: configure: Create sy

[PATCH v5 0/7] riscv: Switch to use generic platform fw_dynamic type opensbi bios images

2020-07-15 Thread Bin Meng
From: Bin Meng The RISC-V generic platform is a flattened device tree (FDT) based platform where all platform specific functionality is provided based on FDT passed by previous booting stage. The support was added in the upstream OpenSBI v0.8 release recently. This series updates QEMU to switch

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-15 Thread Markus Armbruster
David Gibson writes: > On Mon, 13 Jul 2020 18:13:42 +0200 > Markus Armbruster wrote: > >> David Gibson writes: >> >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> >> >> >> The surprising part is that n turns out to be l

Re: [PATCH v3] spapr: Add a new level of NUMA for GPUs

2020-07-15 Thread David Gibson
On Mon, May 25, 2020 at 12:49:27PM -0500, Reza Arbab wrote: > On Mon, May 25, 2020 at 03:05:50PM +1000, David Gibson wrote: > > On Fri, May 22, 2020 at 02:53:33PM -0500, Reza Arbab wrote: > > > --- a/hw/ppc/spapr_pci_nvlink2.c > > > +++ b/hw/ppc/spapr_pci_nvlink2.c > > > @@ -362,7 +362,7 @@ void sp

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-15 Thread David Gibson
On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > Some recent error handling cleanups unveiled issues with our support of > PCI bridges: > > 1) QEMU aborts when using non-standard PCI bridge types, >unveiled by commit 7ef1553dac "spapr_pci: Drop some dead error handling" > > $ qemu

[Bug 1887745] [NEW] call-method block-size failed with error ffffffdf

2020-07-15 Thread InfoLibre
Public bug reported: I start Debian 10 PowerPC version in QEMU with this command : /usr/bin/qemu-system-ppc -monitor stdio -M mac99 -k fr -machine accel=tcg -m 512 -cdrom /home/david/Bureau/debian-10.0.0-powerpc- NETINST-1.iso -hda /home/david/Documents/Informatique et téléphone/Documentation inf

Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-07-15 Thread Bin Meng
Hi Alistair, On Mon, Jul 13, 2020 at 9:53 AM Bin Meng wrote: > > On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis wrote: > > > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote: > > > > > > From: Bin Meng > > > > > > Update virt and sifive_u machines to use the opensbi fw_dynamic bios > > > ima

Re: device compatibility interface for live migration with assigned devices

2020-07-15 Thread Jason Wang
On 2020/7/14 上午7:29, Yan Zhao wrote: hi folks, we are defining a device migration compatibility interface that helps upper layer stack like openstack/ovirt/libvirt to check if two devices are live migration compatible. The "devices" here could be MDEVs, physical devices, or hybrid of the two. e

[PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

2020-07-15 Thread andrew
From: Andrew Melnychenko There is an issue, that netdev can't be removed if it was added using hmp. The bug appears after 08712fcb851034228b61f75bd922863a984a4f60 commit. It happens because of unclear QemuOpts that was created during hmp_netdev_add(), now it uses qmp analog function - qmp_marshal

[PATCH v3 2/2] hw/net: Added basic IPv6 software fragmentation

2020-07-15 Thread andrew
From: Andrew The basic IPv6 fragmentation - adding 'frag' extension to the packet, overall shares some logic with IPv4. It works, but there are still issues with a combination of extensions - in the future, it would require refactoring work to implement workflow with IPv6 and extension. "Jumbo op

[PATCH v3 1/2] hw/net: Added plen fix for IPv6

2020-07-15 Thread andrew
From: Andrew Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065 With network backend with 'virtual header' - there was an issue in 'plen' field. Overall, during TSO, 'plen' would be changed, but with 'vheader' this field should be set to the size of the payload itself instead of '0'. S

Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc"

2020-07-15 Thread sundeep subbaraya
On Wed, Jul 15, 2020 at 8:12 PM Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > On 7/15/20 4:04 PM, Markus Armbruster wrote: > >> Watch this: > >> > >> $ qemu-system-aarch64 -M ast2600-evb -S -display none -qmp stdio > >> {"QMP": {"version": {"qemu": {"micro": 50, "minor

Re: [PULL 0/7] Net patches

2020-07-15 Thread Jason Wang
On 2020/7/16 上午2:06, Peter Maydell wrote: On Wed, 15 Jul 2020 at 14:53, Jason Wang wrote: The following changes since commit 673205379fb499d2b72f2985b47ec7114282f5fe: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/python-next-20200714' into staging (2020-07-15 13:04:27 +0100)

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-07-15 Thread Jason Wang
On 2020/7/16 上午9:00, Peter Xu wrote: On Mon, Jul 13, 2020 at 12:04:16PM +0800, Jason Wang wrote: On 2020/7/10 下午9:30, Peter Xu wrote: On Fri, Jul 10, 2020 at 02:34:11PM +0800, Jason Wang wrote: On 2020/7/9 下午10:10, Peter Xu wrote: On Thu, Jul 09, 2020 at 01:58:33PM +0800, Jason Wang wrote:

Re: Test failure with Smartfusion2 emac block (msf2-emac)

2020-07-15 Thread sundeep subbaraya
Hi Thomas, I will check and get back to you in a week. Hope that's okay. Thanks, Sundeep On Tue, Jul 14, 2020 at 8:12 PM Philippe Mathieu-Daudé wrote: > > Ping? > > On 7/7/20 7:32 AM, Thomas Huth wrote: > > On 07/07/2020 07.18, Thomas Huth wrote: > >> > >> Hi Subbaraya, > >> > >> today, I noti

[RFC for qemu v4 0/2] virtio-balloon: Add option cont-pages to set VIRTIO_BALLOON_F_CONT_PAGES

2020-07-15 Thread Hui Zhu
Code of current version for Linux and qemu is available in [1] and [2]. Update of this version: 1. Report continuous pages will increase the speed. So added deflate continuous pages. 2. According to the comments from David in [3], added 2 new vqs icvq and dcvq to get continuous pages with fo

[RFC for qemu v4 2/2] virtio_balloon: Add dcvq to deflate continuous pages

2020-07-15 Thread Hui Zhu
This commit adds a vq dcvq to deflate continuous pages. When VIRTIO_BALLOON_F_CONT_PAGES is set, try to get continuous pages from icvq and use madvise MADV_WILLNEED with the pages. Signed-off-by: Hui Zhu --- hw/virtio/virtio-balloon.c | 14 +- include/hw/virtio/virtio-balloon

[RFC for Linux v4 1/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES and inflate_cont_vq

2020-07-15 Thread Hui Zhu
This commit adds a new flag VIRTIO_BALLOON_F_CONT_PAGES to virtio_balloon. Add it adds a vq inflate_cont_vq to inflate continuous pages. When VIRTIO_BALLOON_F_CONT_PAGES is set, try to allocate continuous pages and report them use inflate_cont_vq. Signed-off-by: Hui Zhu --- drivers/virtio/virtio

[RFC for Linux v4 2/2] virtio_balloon: Add deflate_cont_vq to deflate continuous pages

2020-07-15 Thread Hui Zhu
This commit adds a vq deflate_cont_vq to deflate continuous pages. When VIRTIO_BALLOON_F_CONT_PAGES is set, call leak_balloon_cont to leak the balloon. leak_balloon_cont will call balloon_page_list_dequeue_cont get continuous pages from balloon and report them use deflate_cont_vq. Signed-off-by: H

[RFC for qemu v4 1/2] virtio_balloon: Add cont-pages and icvq

2020-07-15 Thread Hui Zhu
This commit adds cont-pages option to virtio_balloon. virtio_balloon will open flags VIRTIO_BALLOON_F_CONT_PAGES with this option. And it add a vq icvq to inflate continuous pages. When VIRTIO_BALLOON_F_CONT_PAGES is set, try to get continuous pages from icvq and use madvise MADV_DONTNEED release

[RFC for Linux v4 0/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES to report continuous pages

2020-07-15 Thread Hui Zhu
The first, second and third version are in [1], [2] and [3]. Code of current version for Linux and qemu is available in [4] and [5]. Update of this version: 1. Report continuous pages will increase the speed. So added deflate continuous pages. 2. According to the comments from David in [6], add

Re: [PATCH v3 4/4] spapr: Forbid nested KVM-HV in pre-power9 compat mode

2020-07-15 Thread David Gibson
On Wed, Jul 15, 2020 at 01:14:42PM +0200, Greg Kurz wrote: > On Mon, 13 Jul 2020 14:53:30 +1000 > David Gibson wrote: > > > On Fri, Jul 03, 2020 at 04:19:24PM +0200, Greg Kurz wrote: > > > On Mon, 15 Jun 2020 11:20:31 +0200 > > > Greg Kurz wrote: > > > > > > > On Sat, 13 Jun 2020 17:18:04 +1000

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-07-15 Thread Peter Xu
On Mon, Jul 13, 2020 at 12:04:16PM +0800, Jason Wang wrote: > > On 2020/7/10 下午9:30, Peter Xu wrote: > > On Fri, Jul 10, 2020 at 02:34:11PM +0800, Jason Wang wrote: > > > On 2020/7/9 下午10:10, Peter Xu wrote: > > > > On Thu, Jul 09, 2020 at 01:58:33PM +0800, Jason Wang wrote: > > > > > > > - If we

Implement standard file operation with QEMU

2020-07-15 Thread casmac
Hi all,   I am trying to implment standard file operation (stdio) with QEMU for DSP architecture. The manufacture (TI) provides a runtime library that support posix standard IO, but it left the device level implmentation as hook function calls, like in the library source , it contains  add_devi

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-15 Thread David Gibson
On Mon, 13 Jul 2020 18:13:42 +0200 Markus Armbruster wrote: > David Gibson writes: > > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > >> > >> The surprising part is that n turns out to be large enough for n^2 to > >> matter *that*

Re: [PATCH v5 03/11] hw/timer: Add NPCM7xx Timer device model

2020-07-15 Thread Havard Skinnemoen
On Wed, Jul 15, 2020 at 12:25 AM Philippe Mathieu-Daudé wrote: > > On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > > The NPCM730 and NPCM750 SoCs have three timer modules each holding five > > timers and some shared registers (e.g. interrupt status). > > > > Each timer runs at 25 MHz divided by a pr

[ANNOUNCE] QEMU 5.1.0-rc0 is now available

2020-07-15 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 5.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-5.1.0-rc0.tar.xz http://downl

Re: [PATCH v7 25/47] block: Def. impl.s for get_allocated_file_size

2020-07-15 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: If every BlockDriver were to implement bdrv_get_allocated_file_size(), there are basically three ways it would be handled: (1) For protocol drivers: Figure out the actual allocated file size in some protocol-specific way (2) For protocol drivers: If that

Re: [PATCH v7 23/47] block/snapshot: Fix fallback

2020-07-15 Thread Andrey Shinkevich
On 16.07.2020 00:22, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: If the top node's driver does not provide snapshot functionality and we want to fall back to a node down the chain, we need to snapshot all non-COW children.  For simplicity's sake, just do not fall back if there

Re: build: haiky system build fix

2020-07-15 Thread Christophe de Dinechin
nit: typo in the mail subject (haiky instead of haiku) > On 25 Jun 2020, at 20:36, David CARLIER wrote: > > From 25adbdcdc17ef51a41759f16576901338ed8a469 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Thu, 25 Jun 2020 19:32:42 + > Subject: [PATCH] build: haiku system build fix > >

Re: [PATCH v7 24/47] block: Use CAFs for debug breakpoints

2020-07-15 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: When looking for a blkdebug node (which implements debug breakpoints), use bdrv_primary_bs() to iterate through the graph, because that is where a blkdebug node would be. Signed-off-by: Max Reitz --- block.c | 16 +++- 1 file changed, 3 inser

Re: [PATCH v7 23/47] block/snapshot: Fix fallback

2020-07-15 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: If the top node's driver does not provide snapshot functionality and we want to fall back to a node down the chain, we need to snapshot all non-COW children. For simplicity's sake, just do not fall back if there I guess it comes to COW children like BDRV_C

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-15 Thread Havard Skinnemoen
On Wed, Jul 15, 2020 at 12:42 AM Cédric Le Goater wrote: > > On 7/14/20 4:56 AM, Havard Skinnemoen wrote: > > On Mon, Jul 13, 2020 at 7:57 AM Cédric Le Goater wrote: > >> > >> On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > >>> This allows these NPCM7xx-based boards to boot from a flash image, e.g.

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-15 Thread Havard Skinnemoen
On Wed, Jul 15, 2020 at 3:57 AM Philippe Mathieu-Daudé wrote: > > On 7/15/20 11:00 AM, Markus Armbruster wrote: > > Now my point. Why first make up user configuration, then use that to > > create a BlockBackend, when you could just go ahead and create the > > BlockBackend? > > CLI issue mostly. >

[PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-15 Thread Robert Foley
The primary purpose of this change is to clean up machine.py's console_socket property to return a single type, a ConsoleSocket. ConsoleSocket now derives from a socket, which means that in the default case (of not draining), machine.py will see the same behavior as it did prior to ConsoleSocket.

[PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-15 Thread Robert Foley
The changes to console_socket.py and machine.py are to cleanup for pylint and flake8. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 58 +-- python/qemu/machine.py| 7 +++-- python/qemu/pylintrc | 2 +- 3 files changed, 34 inser

[PATCH 0/2] python/qemu: follow-up changes for ConsoleSocket

2020-07-15 Thread Robert Foley
This patch series introduces a few follow-up changes after the introduction of ConsoleSocket. The first patch introduces cleanup changes for pylint and flake8. The second patch allows machine.py to use a single type for the console_socket, a ConsoleSocket. Since machine.py will use ConsoleSocket

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2020-07-15 Thread Marc-André Lureau
Hi On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell wrote: > > On Tue, 16 Jun 2020 at 10:19, Peter Maydell wrote: > > > > On Tue, 16 Jun 2020 at 00:00, Joe Slater wrote: > > > > > > Always look for ../share/qemu then ../pc-bios when looking for datadir. > > > > Could you provide some more context

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2020-07-15 Thread Peter Maydell
On Tue, 16 Jun 2020 at 10:19, Peter Maydell wrote: > > On Tue, 16 Jun 2020 at 00:00, Joe Slater wrote: > > > > Always look for ../share/qemu then ../pc-bios when looking for datadir. > > Could you provide some more context, please? Why is this > change useful; presumably we broke some setup in 5.

[Bug 1884719] Re: Function not implemented when using libaio

2020-07-15 Thread Laurent Vivier
Martin, after a first look, I can see that asynchronicity introduces more complexity in QEMU than usual ... I'm going to try to write the patches. I will ask you some help to test them. I've already implemented io_setup and io_destroy, but io_submit introduces more complexity because we can only

Re: [PATCH-for-5.1] net/colo: Remove unused trace event

2020-07-15 Thread Roman Bolshakov
On Wed, Jul 15, 2020 at 04:13:02PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 15, 2020 at 04:31:30PM +0200, Philippe Mathieu-Daudé wrote: > > Unused trace event cause build failure when using the dtrace backend: > > > > "probe colo_compare_miscompare doesn't exist" > > > > Fixes: f4b618360e

[PULL v1 2/2] tests: tpm: Skip over pcrUpdateCounter byte in result comparison

2020-07-15 Thread Stefan Berger
The TPM 2 code in libtpms was fixed to handle the PCR 'TCB group' according to the PCClient profile. The change of the PCRs belonging to the 'TCB group' now affects the pcrUpdateCounter in the TPM2_PCRRead() responses where its value is now different (typically lower by '1') than what it was before

[PULL v1 0/2] Merge tpm 2020/07/15 v1

2020-07-15 Thread Stefan Berger
Hello! This series fixes a couple of minor issues with the PPC64 TPM SPAPR interface and a test case. Stefan The following changes since commit 8746309137ba470d1b2e8f5ce86ac228625db940: Update version for v5.1.0-rc0 release (2020-07-15 19:08:07 +0100) are available in the Git repository a

[PULL v1 1/2] tpm: tpm_spapr: Exit on TPM backend failures

2020-07-15 Thread Stefan Berger
Exit on TPM backend failures in the same way as the TPM CRB and TIS device models do. With this change we now get an error report when the backend did not start up properly: error: internal error: qemu unexpectedly closed the monitor: 2020-07-07T12:49:28.333928Z qemu-system-ppc64: tpm-emulator: \

Re: [PATCH-for-5.1] net/colo: Remove unused trace event

2020-07-15 Thread Roman Bolshakov
On Wed, Jul 15, 2020 at 04:31:30PM +0200, Philippe Mathieu-Daudé wrote: > Unused trace event cause build failure when using the dtrace backend: > > "probe colo_compare_miscompare doesn't exist" > > Fixes: f4b618360e ("colo-compare: add TCP, UDP, ICMP packet comparison") > Reported-by: Roman Bol

Re: unable to boot windows with 256 cpus

2020-07-15 Thread Peter Xu
On Wed, Jul 15, 2020 at 07:45:13PM +0200, Igor Mammedov wrote: > While testing ACPI cpu hotplug changes I stumbled on BSOD in case > QEMU is configured with 256 CPUs, Windows Server 2012R2x64 fails to boot > with bugcheck 5C > > > qemu-system-x86_64 -m 4G -smp 2,sockets=64,cores=4,maxcpus=256 -M

Re: [PATCH] slirp: update to v4.3.1

2020-07-15 Thread Peter Maydell
On Wed, 15 Jul 2020 at 19:12, Marc-André Lureau wrote: > On Mon, Jul 13, 2020 at 12:33 PM Marc-André Lureau > wrote: >> >> Switch from stable-4.2 branch back to master (which is actually >> maintained, I think we tend to forget about stable...). > > > ping > > Peter, should I send a pull request

Re: [PATCH] slirp: update to v4.3.1

2020-07-15 Thread Marc-André Lureau
Hi On Mon, Jul 13, 2020 at 12:33 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Switch from stable-4.2 branch back to master (which is actually > maintained, I think we tend to forget about stable...). > ping Peter, should I send a pull request directly? (I feel like it should b

Re: [PULL 0/7] Net patches

2020-07-15 Thread Peter Maydell
On Wed, 15 Jul 2020 at 14:53, Jason Wang wrote: > > The following changes since commit 673205379fb499d2b72f2985b47ec7114282f5fe: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/python-next-20200714' into staging (2020-07-15 > 13:04:27 +0100) > > are available in the git reposito

Re: [PULL v3 0/9] final misc fixes for 5.1-rc0

2020-07-15 Thread Peter Maydell
On Wed, 15 Jul 2020 at 12:15, Alex Bennée wrote: > > Sorry about that, dropped configure patch, added Travis ppc64abi32 > patch. > > --- > > The following changes since commit c920fdba39480989cb5f1af3cc63acccef021b54: > > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-07-13-tag'

[RFC PATCH-for-5.2 5/5] hw/virtio: Simplify virtio_mem_set_requested_size()

2020-07-15 Thread Philippe Mathieu-Daudé
Simplify by directly using visit_type_size() return value. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/virtio-mem.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c index ddf09ed1bf..e407abc2d8 100644 --- a/hw/virtio/

[PATCH-for-5.2 3/5] qom: Use g_autofree in ObjectPropertyGet functions

2020-07-15 Thread Philippe Mathieu-Daudé
By using g_autofree we make it easier to have ObjectPropertyGet methods return a value (see next commit). Signed-off-by: Philippe Mathieu-Daudé --- backends/tpm/tpm_util.c | 3 +-- hw/block/xen-block.c | 3 +-- hw/core/qdev-properties-system.c | 13 + hw/mem/nv

[RFC PATCH-for-5.2 2/5] qom: Split ObjectPropertyAccessor as ObjectProperty[Get/Set]

2020-07-15 Thread Philippe Mathieu-Daudé
To make refactors easier, split the common ObjectPropertyAccessor type definition into ObjectPropertyGet() and ObjectPropertySet(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/qdev-core.h | 4 ++-- include/qom/object.h | 48 -- hw/ppc/spapr_cap

[RFC PATCH-for-5.2 4/5] qom: Let ObjectPropertyGet functions return a boolean value

2020-07-15 Thread Philippe Mathieu-Daudé
Commits 1c94a35164..7b3cb8037c simplified the error propagation. Similarly to commit 73ac1aac39 ("qdev: Make functions taking Error ** return bool, not void") let the ObjectPropertyGet functions return a boolean value, not void. See commit e3fe3988d7 ("error: Document Error API usage rules") for

[RFC PATCH-for-5.2 0/5] qom: Let ObjectPropertyGet functions return a boolean value

2020-07-15 Thread Philippe Mathieu-Daudé
RFC series to follow Markus direction to simplify error propagation. Not sure it is worth it yet. It starts to be interesting when using the QEMU_WARN_UNUSED_RESULT attribute in the visitors, such: -- >8 -- @@ -525,6 +533,7 @@ bool visit_type_uint8(Visitor *v, const char *name, uint8_t *obj, *

[PATCH-for-5.2 1/5] hw/core/qdev-properties: Simplify get_reserved_region()

2020-07-15 Thread Philippe Mathieu-Daudé
Use the safer g_strdup_printf() over snprintf() + abort(). Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev-properties.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 098298c78e..d5f5aa150b 100644 --

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-15 Thread David Hildenbrand
On 15.07.20 19:38, David Hildenbrand wrote: > On 15.07.20 18:14, Heiko Carstens wrote: >> On Wed, Jul 15, 2020 at 01:42:02PM +0200, David Hildenbrand wrote: So, are you saying that even at IPL time there might already be memory devices attached to the system? And the kernel should _not_ t

unable to boot windows with 256 cpus

2020-07-15 Thread Igor Mammedov
While testing ACPI cpu hotplug changes I stumbled on BSOD in case QEMU is configured with 256 CPUs, Windows Server 2012R2x64 fails to boot with bugcheck 5C qemu-system-x86_64 -m 4G -smp 2,sockets=64,cores=4,maxcpus=256 -M q35,kernel-irqchip=split -enable-kvm -device intel-iommu,intremap=on,eim=

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-15 Thread David Hildenbrand
On 15.07.20 18:14, Heiko Carstens wrote: > On Wed, Jul 15, 2020 at 01:42:02PM +0200, David Hildenbrand wrote: >>> So, are you saying that even at IPL time there might already be memory >>> devices attached to the system? And the kernel should _not_ treat them >>> as normal memory? >> >> Sorry if th

Re: [PATCH] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-15 Thread Erik Smit
Hey Cédric, On Wed, 15 Jul 2020 at 15:07, Cédric Le Goater wrote: > > Signed-off-by: erik-smit > > -- > > checkpatch was complaining about the length of > > aspeed_machine_supermicrox11_bmc_class_init(ObjectClass *oc, void *data) > > in which way ? line too long ? Yes. > If so, you can insert

[PATCH v2] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-15 Thread erik-smit
Signed-off-by: erik-smit --- Changed in v2: - matched aspeed_machine_supermicrox11_bmc_class_init function name to machine name hw/arm/aspeed.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 379f9672a5..ef04247

Re: [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME

2020-07-15 Thread Niek Linnenbank
On Wed, Jul 15, 2020, 16:04 Markus Armbruster wrote: > nd_table[] contains NIC configuration for boards to pick up. Device > code has no business looking there. Several devices do it anyway. > Two of them already have a suitable FIXME comment: "allwinner-a10" and > "msf2-soc". Copy it to the o

Re: Inter-VM device emulation (call on Mon 20th July 2020)

2020-07-15 Thread Alex Bennée
Stefan Hajnoczi writes: > On Wed, Jul 15, 2020 at 01:28:07PM +0200, Jan Kiszka wrote: >> On 15.07.20 13:23, Stefan Hajnoczi wrote: >> > Let's have a call to figure out: >> > >> > 1. What is unique about these approaches and how do they overlap? >> > 2. Can we focus development and code review

Re: [PATCH v2] crypto: use a stronger private key for tests

2020-07-15 Thread Daniel P . Berrangé
On Wed, Jul 15, 2020 at 06:08:53PM +0200, Philippe Mathieu-Daudé wrote: > On 7/15/20 5:47 PM, Daniel P. Berrangé wrote: > > The unit tests using the x509 crypto functionality have started > > failing in Fedora 33 rawhide with a message like > > > > The certificate uses an insecure algorithm

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-07-15 Thread Collin Walling
On 7/15/20 12:04 PM, Cornelia Huck wrote: > On Wed, 15 Jul 2020 11:36:35 -0400 > Collin Walling wrote: > >> Polite ping. Patches have been sitting on the list for a few weeks now, >> and it doesn't look like any further changes are requested (hopefully I >> didn't miss something). > > The only t

[Bug 1882851] Re: QEMU video freezes with "Guest disabled display" (virtio driver)

2020-07-15 Thread Diego Viola
Will the patch make it for 5.8? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1882851 Title: QEMU video freezes with "Guest disabled display" (virtio driver) Status in QEMU: New Bug description

RE: Inter-VM device emulation (call on Mon 20th July 2020)

2020-07-15 Thread Thanos Makatos
> -Original Message- > From: kvm-ow...@vger.kernel.org On > Behalf Of Stefan Hajnoczi > Sent: 15 July 2020 12:24 > To: Nikos Dragazis ; Jan Kiszka > > Cc: Michael S. Tsirkin ; Thanos Makatos > ; John G. Johnson > ; Andra-Irina Paraschiv > ; Alexander Graf ; qemu- > de...@nongnu.org; k.

Re: [PULL 0/3] MIPS patches for 5.1

2020-07-15 Thread Peter Maydell
On Tue, 14 Jul 2020 at 21:22, Philippe Mathieu-Daudé wrote: > > The following changes since commit 1a53dfee92284d3016a579ef31d53367e84d9dd8: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2020-07-13' into > staging (2020-07-14 13:52:10 +0100) > > are available in the Git reposito

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-15 Thread Heiko Carstens
On Wed, Jul 15, 2020 at 01:42:02PM +0200, David Hildenbrand wrote: > > So, are you saying that even at IPL time there might already be memory > > devices attached to the system? And the kernel should _not_ treat them > > as normal memory? > > Sorry if that was unclear. Yes, we can have such device

Re: [PATCH v2] crypto: use a stronger private key for tests

2020-07-15 Thread Philippe Mathieu-Daudé
On 7/15/20 5:47 PM, Daniel P. Berrangé wrote: > The unit tests using the x509 crypto functionality have started > failing in Fedora 33 rawhide with a message like > > The certificate uses an insecure algorithm > > This is result of Fedora changes to support strong crypto [1]. RSA > with 102

Re: [PATCH v4 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2020 11:35:06 -0400 Collin Walling wrote: > On 6/26/20 6:01 AM, Cornelia Huck wrote: > > On Wed, 24 Jun 2020 16:23:10 -0400 > > Collin Walling wrote: > > > >> As more features and facilities are added to the Read SCP Info (RSCPI) > >> response, more space is required to store t

Re: TB Cache size grows out of control with qemu 5.0

2020-07-15 Thread BALATON Zoltan
See commit 47a2def4533a2807e48954abd50b32ecb1aaf29a and the next two following it.

Re: [PATCH 1/1] analyze-migration.py: fix read_migration_debug_json() return type

2020-07-15 Thread Philippe Mathieu-Daudé
Cc'ing Eduardo/Cleber. On 7/15/20 5:21 PM, Alexey Kirillov wrote: > Since we use result of read_migration_debug_json() as JSON formatted string, > we must provide proper type. Before Python 3.6 json.loads() method > support only str typed input. > > Signed-off-by: Alexey Kirillov > --- > script

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2020 11:36:35 -0400 Collin Walling wrote: > Polite ping. Patches have been sitting on the list for a few weeks now, > and it doesn't look like any further changes are requested (hopefully I > didn't miss something). The only thing I had was (I think) the logging of the length you

[PATCH v2] crypto: use a stronger private key for tests

2020-07-15 Thread Daniel P . Berrangé
The unit tests using the x509 crypto functionality have started failing in Fedora 33 rawhide with a message like The certificate uses an insecure algorithm This is result of Fedora changes to support strong crypto [1]. RSA with 1024 bit key is viewed as legacy and thus insecure. Generate a

[PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-15 Thread Li Qiang
Properly free each test response to avoid memory leak and separate qtest_qmp() calls with spare lines, in a consistent manner. Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add qmp/object-add-failure-modes" Reviewed-by: Eric Auger Signed-off-by: Li Qiang --- Change sincve v1: add detailed commit mess

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-07-15 Thread dann frazier
I ran the new PPA build (1:2.11+dfsg-1ubuntu7.29~ppa01) on both a ThunderX2 system and a Hi1620 system overnight, and both survived (6574 & 12919 iterations, respectively). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

Re: Inter-VM device emulation (call on Mon 20th July 2020)

2020-07-15 Thread Stefan Hajnoczi
On Wed, Jul 15, 2020 at 01:28:07PM +0200, Jan Kiszka wrote: > On 15.07.20 13:23, Stefan Hajnoczi wrote: > > Let's have a call to figure out: > > > > 1. What is unique about these approaches and how do they overlap? > > 2. Can we focus development and code review efforts to get something > >mer

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-07-15 Thread Collin Walling
Polite ping. Patches have been sitting on the list for a few weeks now, and it doesn't look like any further changes are requested (hopefully I didn't miss something). Thanks for everyone's time and patience. Stay safe out there. - Collin

Re: [PATCH v4 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-07-15 Thread Collin Walling
On 6/26/20 6:01 AM, Cornelia Huck wrote: > On Wed, 24 Jun 2020 16:23:10 -0400 > Collin Walling wrote: > >> As more features and facilities are added to the Read SCP Info (RSCPI) >> response, more space is required to store them. The space used to store >> these new features intrudes on the space

  1   2   3   >