On Thu, Jun 25, 2020 at 07:47:41AM +0200, Thomas Huth wrote:
> On 25/06/2020 01.06, Michael S. Tsirkin wrote:
> > The following changes since commit d4b78317b7cf8c0c635b70086503813f79ff21ec:
> >
> >Merge remote-tracking branch
> > 'remotes/pmaydell/tags/pull-target-arm-20200623' into staging
lichun writes:
> Signed-off-by: lichun
> ---
> chardev/char-socket.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
> index afebeec5c3..569d54c144 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -1
Paolo Bonzini writes:
> On 24/06/20 16:17, Igor Mammedov wrote:
>>> -cpu = object_new(MACHINE(x86ms)->cpu_type);
>>> -
>>> -object_property_set_uint(cpu, apic_id, "apic-id", &local_err);
>>> -qdev_realize(DEVICE(cpu), NULL, &local_err);
>>> -
>>> -object_unref(cpu);
>>> -error
Greg Kurz writes:
> On Wed, 24 Jun 2020 10:37:15 +0200
> Markus Armbruster wrote:
>
>> Receiving the error in a local variable only to free it is less clear
>> (and also less efficient) than passing NULL. Clean up.
>>
>> Cc: Daniel P. Berrange
>> Cc: Jerome Forissier
>> CC: Greg Kurz
>> Sig
Cédric Le Goater writes:
> On 6/22/20 10:31 AM, Philippe Mathieu-Daudé wrote:
>> On 6/22/20 8:27 AM, Cédric Le Goater wrote:
>>> On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote:
Add a description field to distinguish between multiple devices.
Pardon my lack of imagination: how does this h
On 6/24/20 6:43 PM, Markus Armbruster wrote:
> Don't handle object_property_get_link() failure that can't happen
> unless the programmer screwed up, pass &error_abort.
>
> Signed-off-by: Markus Armbruster
> ---
> hw/arm/bcm2835_peripherals.c | 7 +--
> hw/arm/bcm2836.c | 7 +---
On 6/24/20 6:43 PM, Markus Armbruster wrote:
> Commit 2f262e06f0 lifted qdev_get_type() from qdev to object without
> renaming it accordingly. Do that now.
>
> Signed-off-by: Markus Armbruster
> ---
> qom/object.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qom
On 6/24/20 8:55 PM, P J P wrote:
> From: Prasad J Pandit
>
> Add tz-ppc-dummy mmio read/write methods to avoid assert failure
> during initialisation.
>
> Signed-off-by: Prasad J Pandit
> ---
> hw/misc/tz-ppc.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/hw/misc/
On 24/06/2020 22.23, Collin Walling wrote:
Rework the SCLP boundary check to account for different SCLP commands
(eventually) allowing different boundary sizes.
Move the length check code into a separate function, and introduce a
new function to determine the length of the read SCP data (i.e. th
On 6/24/20 8:55 PM, P J P wrote:
> From: Prasad J Pandit
>
> Add ppc-parity mmio write method to avoid NULL pointer dereference
> issue.
>
> Reported-by: Lei Sun
> Signed-off-by: Prasad J Pandit
> ---
> hw/ppc/prep_systemio.c | 8
> 1 file changed, 8 insertions(+)
>
> Update v2: use
On 6/24/20 9:00 PM, Laurent Vivier wrote:
> qemu_set_nonblock() checks that the file descriptor can be used and, if
> not, crashes QEMU. An assert() is used for that. The use of assert() is
> used to detect programming error and the coredump will allow to debug
> the problem.
>
> But in the case o
On Wed, Jun 24, 2020 at 09:06:48AM +0200, Cornelia Huck wrote:
> On Mon, 22 Jun 2020 16:27:28 +0200
> Christian Borntraeger wrote:
>
> > On 19.06.20 04:05, David Gibson wrote:
> > > A number of hardware platforms are implementing mechanisms whereby the
> > > hypervisor does not have unfettered ac
On Wed, Jun 24, 2020 at 03:55:59AM -0400, Michael S. Tsirkin wrote:
> On Fri, Jun 19, 2020 at 01:16:38PM +0100, Daniel P. Berrangé wrote:
> > On Fri, Jun 19, 2020 at 07:47:20AM -0400, Michael S. Tsirkin wrote:
> > > On Fri, Jun 19, 2020 at 07:46:14AM -0400, Michael S. Tsirkin wrote:
> > > > On Fri
Kirti Wankhede writes:
> On 6/23/2020 12:51 PM, Markus Armbruster wrote:
>> QAPI review only.
>>
>> The only changes since I reviewed v23 is the rename of VfioStats member
>> @bytes to @transferred, and the move of MigrationInfo member @vfio next
>> to @ram and @disk. Good. I'm copying my other
On Thu, Jun 25, 2020 at 03:47:23PM +1000, David Gibson wrote:
> On Wed, Jun 24, 2020 at 09:06:48AM +0200, Cornelia Huck wrote:
> > On Mon, 22 Jun 2020 16:27:28 +0200
> > Christian Borntraeger wrote:
> >
> > > On 19.06.20 04:05, David Gibson wrote:
> > > > A number of hardware platforms are implem
On Fri, Jun 19, 2020 at 12:04:25PM +0200, David Hildenbrand wrote:
> >> However, once we have multiple options to protect a guest (memory
> >> encryption, unmapping guest pages ,...) the name will no longer really
> >> suffice to configure QEMU, no?
> >
> > That's why it takes a parameter. It poi
On Mon, Jun 22, 2020 at 10:09:30AM +0100, Daniel P. Berrangé wrote:
> On Sat, Jun 20, 2020 at 06:24:27PM +1000, David Gibson wrote:
> > On Fri, Jun 19, 2020 at 04:05:56PM +0100, Daniel P. Berrangé wrote:
> > > On Sat, Jun 20, 2020 at 12:45:41AM +1000, David Gibson wrote:
> > > > On Fri, Jun 19, 202
On 25/06/2020 01.06, Michael S. Tsirkin wrote:
The following changes since commit d4b78317b7cf8c0c635b70086503813f79ff21ec:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20200623' into staging (2020-06-23
18:57:05 +0100)
are available in the Git repository at:
git
On Mon, Jun 22, 2020 at 04:27:28PM +0200, Christian Borntraeger wrote:
> On 19.06.20 04:05, David Gibson wrote:
> > A number of hardware platforms are implementing mechanisms whereby the
> > hypervisor does not have unfettered access to guest memory, in order
> > to mitigate the security impact of
On Fri, Jun 19, 2020 at 07:46:10AM -0400, Michael S. Tsirkin wrote:
> On Fri, Jun 19, 2020 at 11:12:45AM +0100, Daniel P. Berrangé wrote:
> > On Fri, Jun 19, 2020 at 12:06:02PM +1000, David Gibson wrote:
> > > The default behaviour for virtio devices is not to use the platforms
> > > normal
> > >
On Mon, Jun 22, 2020 at 02:02:54PM +0200, Cornelia Huck wrote:
> On Fri, 19 Jun 2020 12:10:13 +0200
> David Hildenbrand wrote:
>
> > On 19.06.20 12:05, Cornelia Huck wrote:
> > > On Fri, 19 Jun 2020 11:56:49 +0200
> > > David Hildenbrand wrote:
> > >
> > > For now this series covers just
On 24/06/2020 18.26, Philippe Mathieu-Daudé wrote:
Hi Thomas,
On 6/24/20 12:21 PM, Philippe Mathieu-Daudé wrote:
On 6/24/20 7:04 AM, Thomas Huth wrote:
On 23/06/2020 19.35, Philippe Mathieu-Daudé wrote:
On 6/23/20 7:07 PM, Thomas Huth wrote:
On 23/06/2020 17.39, Philippe Mathieu-Daudé wrote:
Signed-off-by: Jon Doron
---
hw/i386/acpi-build.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 91af0d2d0d..1f938a53b2 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1091,7 +1091,6 @@ static Aml
After doing further tests and looking at the latest HyperV ACPI DSDT.
Do minor fix to our VMBus ACPI entry.
v4:
* Removed the patch which adds _ADR definition to the VMBus
* Correct the change which moves the VMBus under the SB
v3:
Removed accidental change for the dct submodule head
v2:
Renamed
It seems like Windows does not really require 2 IRQs to have a
functioning VMBus.
Signed-off-by: Jon Doron
Reviewed-by: Igor Mammedov
---
hw/hyperv/vmbus.c| 3 +--
hw/i386/acpi-build.c | 4 +---
include/hw/hyperv/vmbus-bridge.h | 3 +--
3 files changed, 3 insertions(
Cindy Lu writes:
> On Tue, Jun 23, 2020 at 5:43 PM Jason Wang wrote:
>>
>>
>> On 2020/6/23 下午5:16, Cindy Lu wrote:
>> > On Tue, Jun 23, 2020 at 3:07 PM Markus Armbruster
>> > wrote:
>> >> Cindy Lu writes:
>> >>
>> >>> vDPA device is a device that uses a datapath which complies with the
>> >>>
On 25/06/2020, Jon Doron wrote:
On 23/06/2020, Igor Mammedov wrote:
On Thu, 18 Jun 2020 06:00:27 +0300
Jon Doron wrote:
Signed-off-by: Jon Doron
---
hw/i386/acpi-build.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.
John Snow writes:
> On 6/22/20 5:42 AM, Markus Armbruster wrote:
>> There are three ways to configure backends:
>>
>> * -nic, -serial, -drive, ... (onboard devices)
>>
>> * Set the property with -device, or, if you feel masochistic, with
>> -set device (pluggable devices)
>>
>> * Set the pro
On Wed, Jun 24, 2020 at 10:37:19AM +0200, Markus Armbruster wrote:
> spapr_machine_init() leaks an Error object when
> kvmppc_check_papr_resize_hpt() fails and spapr->resize_hpt is
> SPAPR_RESIZE_HPT_DISABLED, i.e. when the host doesn't support hash
> page table resizing, and the user didn't ask fo
On Sat, Jun 20, 2020 at 4:15 AM Vivek Goyal wrote:
>
> On Fri, Jun 19, 2020 at 01:46:20PM +0900, Chirantan Ekbote wrote:
> > On Fri, Jun 19, 2020 at 4:27 AM Vivek Goyal wrote:
> > >
> > > On Thu, Jun 18, 2020 at 08:16:55PM +0100, Dr. David Alan Gilbert wrote:
> > > > * Vivek Goyal (vgo...@redhat.
On Wed, Jun 24, 2020 at 1:57 PM Dr. David Alan Gilbert
wrote:
>
> * Jason Andryuk (jandr...@gmail.com) wrote:
> > Hi,
> >
> > At some point, QEMU changed to add a json VM description (vmdesc)
> > after the migration data. The vmdesc is not needed to restore the
> > migration data, but qemu_loadvm
On 23/06/2020, Igor Mammedov wrote:
On Thu, 18 Jun 2020 06:00:27 +0300
Jon Doron wrote:
Signed-off-by: Jon Doron
---
hw/i386/acpi-build.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 6d9df38e31..38be9e5a58
On 23/06/2020, Igor Mammedov wrote:
On Thu, 18 Jun 2020 06:00:26 +0300
Jon Doron wrote:
It seems like latest HyperV sets _ADR to 0 in the ACPI for the VMBS
that's a hardly a good reason to add this.
To me looks like a pointless addition,
_ADR mostly is used when device resides on a bus with
On Thu, Jun 25, 2020 at 12:25:20AM +0530, P J P wrote:
> From: Prasad J Pandit
>
> Add spapr msi mmio read method to avoid NULL pointer dereference
> issue.
>
> Reported-by: Lei Sun
> Signed-off-by: Prasad J Pandit
Acked-by: David Gibson
> ---
> hw/ppc/spapr_pci.c | 13 +++--
> 1 f
On Thu, Jun 25, 2020 at 12:25:18AM +0530, P J P wrote:
> From: Prasad J Pandit
>
> Add ppc-parity mmio write method to avoid NULL pointer dereference
> issue.
>
> Reported-by: Lei Sun
> Signed-off-by: Prasad J Pandit
Acked-by: David Gibson
> ---
> hw/ppc/prep_systemio.c | 8
> 1 f
I'm not exactly sure what commit improved the situation (either
https://git.qemu.org/?p=qemu.git;a=commit;h=e37aa8b0e410 or
https://git.qemu.org/?p=qemu.git;a=commit;h=fbafbb6db7742) but I have
noticed that sporadic failures are gone after the series was applied:
https://lists.gnu.org/archive/html
The issue should be fixed in QEMU v5.0+
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1818937
Title:
Crash with HV_ERROR on macOS host
Status in QEMU:
Fix Released
Bug description:
On macOS h
On Wed, Jun 24, 2020 at 06:43:02PM +0200, Markus Armbruster wrote:
> macio_newworld_realize() effectively ignores ns->gpio realization
> errors, leaking the Error object. Fortunately, macio_gpio_realize()
> can't actually fail. Tidy up.
>
> Cc: Mark Cave-Ayland
> Cc: David Gibson
> Signed-off-
From: Thomas Huth
"make check-qtest" currently fails if configure has been run with
"--disable-tpm" - the TPM-related tests can only work if the TPM is
enabled in the build. So let's use the CONFIG_TPM switch to disable
the test if TPM is not available.
Signed-off-by: Thomas Huth
Message-Id: <2
From: Ani Sinha
Currently, the option use_acpi_pci_hotplug is being used to control device
hotplug capability using ACPI for slots of cold plugged bridges. Hence, we
are renaming this option to better reflect what it actually does.
Signed-off-by: Ani Sinha
Message-Id: <1592310699-58916-1-git-se
From: Raphael Norwitz
Prior to this change, the vhost_user_fill_msg_region function filled out
all elements of the VhostUserMemoryRegion struct except the mmap_offset.
This function is often called on uninitialized structs, which are then
copied into VHOST_USER_SET_MEM_TABLE and VHOST_USER_ADD/R
From: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann
Message-Id: <20200619091905.21676-13-kra...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
tests/data/acpi/pc/DSDT | Bin 5014 -> 4934 bytes
tests/data/acpi/pc/DSDT.acpihmat | Bin 6338 -> 6258 bytes
From: Eric Auger
ACPI boot now is supported. Let's remove the comment
saying it is not.
Signed-off-by: Eric Auger
Reviewed-by: Stefan Berger
Reviewed-by: Igor Mammedov
Message-Id: <20200622140620.17229-4-eric.au...@redhat.com>
Tested-by: Ard Biesheuvel
Reviewed-by: Michael S. Tsirkin
Signed
From: Eric Auger
In case it is dynamically instantiated, add the TPM 2.0 device object
under the DSDT table in the ACPI namespace. Its HID is MSFT0101
while its current resource settings (CRS) property is initialized
with the guest physical address and MMIO size of the device.
Signed-off-by: Eri
From: Gerd Hoffmann
The _STA methods for COM+LPT used to reference them,
but that isn't the case any more.
piix4 DSDT changes:
Scope (_SB.PCI0)
{
Device (ISA)
{
Name (_ADR, 0x0001) // _ADR: Address
OperationRegion (P40C, PCI_Config, 0x6
On systems where the IASL tool exists, we can convert
extected ACPI tables to ASL format, which is useful
for debugging and documentation purposes.
This script does this for all ACPI tables under tests/data/acpi/.
Signed-off-by: Michael S. Tsirkin
---
tests/data/acpi/disassemle-aml.sh | 52 +
From: Gerd Hoffmann
DSDT change: isa device order changes in case MI1 (ipmi) is present.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
Message-Id: <20200619091905.21676-7-kra...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S
From: Gerd Hoffmann
Seems to be unused.
ich9 DSDT changes:
Scope (_SB.PCI0)
{
Device (ISA)
{
Name (_ADR, 0x001F) // _ADR: Address
OperationRegion (PIRQ, PCI_Config, 0x60, 0x0C)
-OperationRegion (LPCD, PCI_Config, 0x80, 0x02)
From: Eric Auger
Remove any reference to Acpi20TPM2 and adopt an implementation
similar to build_ghes_v2().
Signed-off-by: Eric Auger
Suggested-by: Igor Mammedov
Reviewed-by: Stefan Berger
Tested-by: Stefan Berger
Reviewed-by: Igor Mammedov
Message-Id: <20200622140620.17229-2-eric.au...@re
From: Gerd Hoffmann
The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits)
is not used any more, remove it from DSDT.
piix4 DSDT changes:
Scope (_SB.PCI0)
{
-Device (PX13)
-{
-Name (_ADR, 0x00010003) // _ADR: Address
-OperationRegion (P
From: Gerd Hoffmann
x86 machines can have a single ISA bus only.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20200619091905.21676-9-kra...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/
From: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: John Snow
Message-Id: <20200619091905.21676-6-kra...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
include/hw/block/fdc.h | 1 +
include/hw/i386/pc.h | 1 -
From: Gerd Hoffmann
acpi aml generator needs this, but it is in floppy code now
so we can make the function static.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: John Snow
Message-Id: <20200619091905.21676-5-kra...@redhat.com>
Reviewed-
From: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann
Message-Id: <20200619091905.21676-2-kra...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-tables-test-allowed-diff.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/tes
From: Gerd Hoffmann
Add helper function to add fw_cfg device,
also move code to hw/i386/fw_cfg.c.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
Message-Id: <20200619091905.21676-8-kra...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by:
From: Gerd Hoffmann
DSDT change: isa device order changes in case MI1 (ipmi) is present.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
Message-Id: <20200619091905.21676-4-kra...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/block/fdc.c
The following changes since commit d4b78317b7cf8c0c635b70086503813f79ff21ec:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200623'
into staging (2020-06-23 18:57:05 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags
From: Gerd Hoffmann
Makes it easier to create good commit messages from the logs.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20200619091905.21676-3-kra...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-ta
Similar patch was sent a while ago but got lost.
While at it, add a status wiki page.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 01e6b3fefe..f54a50cdb2 100644
--- a/MAINTAINERS
+++ b/M
HVF doesn't have a CPU kick and without it it's not possible to perform
an action on CPU thread until a VMEXIT happens. The kick is also needed
for timely interrupt delivery.
Existing implementation of CPU kick sends SIG_IPI (aka SIGUSR1) to vCPU
thread, but it's different from what hv_vcpu_interr
It's worth to have a custom accel-specific reset in x86_cpu_reset() only
if something related to CPUState has to be reset and that can't be done
in post-init or post-reset.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
include/sysemu/hvf.h | 1 -
target/i386/cpu.c | 3 ---
targ
hvf_reset_vcpu() duplicates actions performed by x86_cpu_reset(). The
difference is that hvf_reset_vcpu() stores initial values directly to
VMCS while x86_cpu_reset() stores it in CPUX86State and then
cpu_synchronize_all_post_init() or cpu_synchronize_all_post_reset()
flushes CPUX86State into VMCS.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
cpus.c| 12
include/sysemu/hw_accel.h | 10 ++
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/cpus.c b/cpus.c
index 7317ae06b9..26709677d3 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1017,
Make them more concise and consitent with the rest of the code in the
file and drop non-relevant TODO.
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
target/i386/hvf/hvf.c | 36
1 file changed, 16 insertions(+), 20 deletions(-)
diff --git a/target/
hvf lacks an implementation of cpu_synchronize_pre_loadvm().
Cc: Cameron Esfahani
Signed-off-by: Roman Bolshakov
---
include/sysemu/hvf.h | 1 +
include/sysemu/hw_accel.h | 3 +++
target/i386/hvf/hvf.c | 11 +++
3 files changed, 15 insertions(+)
diff --git a/include/sysemu/h
The series is a prerequisite to implement gdbstub support for HVF and mostly
concerns improvements of cpu_synchronize_* functions wrt to HVF and addresses
old TODO's in the related code.
Unfortunately live snapshots don't seem to work yet but they don't work with
tcg (on macOS) either.
Roman Bols
cpu_synchronize_state() is currently no-op for hvf but BIOS will hang in
vAPIC option ROM when cpu_synchronize_state() is wired to
hvf_cpu_synchronize_state().
cpu_synchronize_state() state is called from vapic_write() during option
ROM initialization. It sets dirty flag on the cpu. macvm_set_rip(
On 6/24/20 4:48 PM, Eric Blake wrote:
grep -e is also a non-portable construct; it might be possible to change
that line to call egrep instead, or to rewrite the regex to not need
extended regex.
As a short-term workaround, you can always do:
/path/to/bash ./configure
to run it under a shel
On 6/24/20 11:43 AM, Markus Armbruster wrote:
virtio_crypto_pci_realize() continues after realization of its
"virtio-crypto-device" fails. Only an object_property_set_link()
follows; looks harmless to me. Tidy up anyway: return after failure,
just like virtio_rng_pci_realize() does.
Cc: "Gongl
On 6/24/20 11:43 AM, Markus Armbruster wrote:
macio_newworld_realize() effectively ignores ns->gpio realization
errors, leaking the Error object. Fortunately, macio_gpio_realize()
can't actually fail. Tidy up.
Cc: Mark Cave-Ayland
Cc: David Gibson
Signed-off-by: Markus Armbruster
---
hw/m
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
hw/core/qdev-properties.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization
On 6/24/20 11:43 AM, Markus Armbruster wrote:
qdev_print_props() receives and throws away Error objects just to
check for object_property_get_str() and object_property_print()
failure. Unnecessary, both return suitable values, so use those
instead.
Signed-off-by: Markus Armbruster
---
qdev-m
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
qemu-img.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake
Another case where you already wrote the followup patch for something I
spotted earlier in the series ;)
On 6/24/20 4:31 PM, Michele Denber wrote:
While trying to run configure in Solaris 11.4, I quickly run into:
root@hemlock:~/qemu-5.0.0# ./configure
./configure[62]: local: not found [No such file or directory]
grep: illegal option -- e
Usage: grep [-c|-l|-q] -bhinsvw pattern file . . .
./conf
On 6/24/20 11:43 AM, Markus Armbruster wrote:
When foo(..., &err) is followed by error_propagate(errp, err), we can
often just as well do foo(..., errp). The previous commit did that
for simple cases with Coccinelle. Do it for one more manually.
Signed-off-by: Markus Armbruster
---
hw/block
On 6/24/20 11:43 AM, Markus Armbruster wrote:
The previous commit enables conversion of
qdev_prop_set_drive_err(..., &err);
if (err) {
...
}
to
if (!qdev_prop_set_drive_err(..., errp)) {
...
}
Eliminate error_propagate() that are now unnecessary. Delete @er
On 6/24/20 11:43 AM, Markus Armbruster wrote:
See recent commit "error: Document Error API usage rules" for
rationale.
Signed-off-by: Markus Armbruster
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org |
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Just for consistency. Also fix the example in object_set_props()'s
documentation.
Signed-off-by: Markus Armbruster
---
include/qom/object.h | 28 +++-
qom/object.c | 14 +++---
2 files changed, 18 inserti
On 6/24/20 11:43 AM, Markus Armbruster wrote:
The previous commit enables conversion of
foo(..., &err);
if (err) {
...
}
to
if (!foo(..., errp)) {
...
}
for QOM functions that now return true / false on success / error.
Coccinelle script:
Signed-of
On 6/24/20 11:43 AM, Markus Armbruster wrote:
When foo(..., &err) is followed by error_propagate(errp, err), we can
often just as well do foo(..., errp). The previous commit did that
for simple cases with Coccinelle. Do it for a few more manually.
Signed-off-by: Markus Armbruster
---
Review
On 6/24/20 11:43 AM, Markus Armbruster wrote:
See recent commit "error: Document Error API usage rules" for
rationale.
Signed-off-by: Markus Armbruster
---
@@ -524,25 +527,29 @@ void object_initialize(void *data, size_t size, const
char *typename)
object_initialize_with_type(data, siz
While trying to run configure in Solaris 11.4, I quickly run into:
root@hemlock:~/qemu-5.0.0# ./configure
./configure[62]: local: not found [No such file or directory]
./configure[62]: local: not found [No such file or directory]
./configure[62]: local: not found [No such file or directory]
./con
On 6/24/20 11:43 AM, Markus Armbruster wrote:
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name
On 6/24/20 11:43 AM, Markus Armbruster wrote:
When using the Error object to check for error, we need to receive it
into a local variable, then propagate() it to @errp.
Using the return value permits allows receiving it straight to @errp.
Signed-off-by: Markus Armbruster
---
qom/object.c | 1
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Don't handle object_property_get_link() failure that can't happen
unless the programmer screwed up, pass &error_abort.
Signed-off-by: Markus Armbruster
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Your pipeline has failed.
Project: QEMU ( https://gitlab.com/qemu-project/qemu )
Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master )
Commit: d4b78317 (
https://gitlab.com/qemu-project/qemu/-/commit/d4b78317b7cf8c0c635b70086503813f79ff21ec
)
Commit Message: Merge remote-tr
> Am 24.06.2020 um 22:36 schrieb Michael S. Tsirkin :
>
> On Wed, Jun 24, 2020 at 06:01:02PM +0200, David Hildenbrand wrote:
>>> On 24.06.20 17:37, Michael S. Tsirkin wrote:
>>> On Wed, Jun 24, 2020 at 05:28:59PM +0200, David Hildenbrand wrote:
> So at the high level the idea was simple, w
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Pass &error_abort instead of NULL where the returned value is
dereferenced or asserted to be non-null.
Signed-off-by: Markus Armbruster
---
@@ -63,8 +64,8 @@ hwaddr platform_bus_get_mmio_addr(PlatformBusDevice *pbus,
SysBusDevice *sbdev,
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Commit 2f262e06f0 lifted qdev_get_type() from qdev to object without
renaming it accordingly. Do that now.
Signed-off-by: Markus Armbruster
---
qom/object.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
--
On 6/24/20 11:43 AM, Markus Armbruster wrote:
The commit before previous enables another round of the transformation
from recent commit "error: Avoid unnecessary error_propagate() after
error_setg()".
Signed-off-by: Markus Armbruster
---
hw/acpi/core.c | 15 ++-
1 file changed, 6
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
include/qom/object.h | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization:
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
block/parallels.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qe
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
qapi/qapi-visit-core.c | 40 +++-
1 file changed, 19 insertions(+), 21 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Convert
visit_type_FOO(v, ..., &ptr, &err);
...
if (err) {
...
}
to
visit_type_FOO(v, ..., &ptr, errp);
...
if (!ptr) {
...
}
for functions that set @ptr to non-null / null on success / error
On 6/24/20 11:43 AM, Markus Armbruster wrote:
Use visitor functions' return values to check for failure. Eliminate
error_propagate() that are now unnecessary. Delete @err that are now
unused.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt | 60 ++--
On 6/24/20 11:43 AM, Markus Armbruster wrote:
When foo(..., &err) is followed by error_propagate(errp, err), we can
often just as well do foo(..., errp). The previous commit did that
for simple cases with Coccinelle. Do it for a few more manually.
Signed-off-by: Markus Armbruster
---
Review
On 6/24/20 11:43 AM, Markus Armbruster wrote:
The previous commit enables conversion of
visit_foo(..., &err);
if (err) {
...
}
to
if (!visit_foo(..., errp)) {
...
}
for visitor functions that now return true / false on success / error.
Coccinelle scrip
On 6/24/20 11:43 AM, Markus Armbruster wrote:
See recent commit "error: Document Error API usage rules" for
rationale.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt | 51 +--
include/qapi/clone-visitor.h | 8 +-
include/qapi/visitor-impl.h | 26 +++---
i
On Wed, Jun 24, 2020 at 06:01:02PM +0200, David Hildenbrand wrote:
> On 24.06.20 17:37, Michael S. Tsirkin wrote:
> > On Wed, Jun 24, 2020 at 05:28:59PM +0200, David Hildenbrand wrote:
> >>> So at the high level the idea was simple, we just clear the dirty bit
> >>> when page is hinted, unless we s
Patchew URL:
https://patchew.org/QEMU/20200624194809.26600-1-eric.au...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
1 - 100 of 510 matches
Mail list logo
