Re: [RFC v2 6/9] virtio-bus: introduce queue_enabled method

2020-05-08 Thread Cindy Lu
On Sat, May 9, 2020 at 11:02 AM Jason Wang wrote: > > > On 2020/5/9 上午12:32, Cindy Lu wrote: > > From: Jason Wang > > > > This patch introduces queue_enabled() method which allows the > > transport to implement its own way to report whether or not a queue is > > enabled. > > > > Signed-off-by: Ja

Re: [RFC v2 8/9] vhost_net: set vq ready during start if necessary

2020-05-08 Thread Cindy Lu
On Sat, May 9, 2020 at 11:04 AM Jason Wang wrote: > > > On 2020/5/9 上午12:32, Cindy Lu wrote: > > From: Jason Wang > > > > Signed-off-by: Jason Wang > > --- > > hw/net/vhost_net.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > > ind

Re: [RFC v2 2/9] net: use the function qemu_get_peer

2020-05-08 Thread Cindy Lu
On Sat, May 9, 2020 at 10:20 AM Jason Wang wrote: > > > On 2020/5/9 上午12:32, Cindy Lu wrote: > > user the qemu_get_peer to replace the old process > > > The title should be "vhost_net: use the function qemu_get_peer". > > Thanks > Sure, I will fix this > > > > > Signed-off-by: Cindy Lu > > --- >

[Bug 1868221] Re: /usr/share/applications/qemu.desktop should have an "Exec=" key.

2020-05-08 Thread Lockywolf
I am sorry I haven't dealt with this bug for quite a while. KDE 5 is not properly working on my distro, and I wanted to test it when it stabilises. If qemu dislikes long-standing bugs, this bug can be closed, and I'll open a new one when I have time to test it on the new KDE. -- You received thi

Re: [PATCH v2] e1000e: Added ICR clearing by corresponding IMS bit.

2020-05-08 Thread Jason Wang
On 2020/5/9 上午2:13, Andrew Melnichenko wrote: Yo, I've used OpenSDM_8257x-18.pdf specification. This document was recommended by Intel guys(Also, they referenced to that note). I've made a fast fix and it works. Before that I had a fix for Linux e1000e driver. Overall, the issue was in pendin

[Bug 1868221] Re: /usr/share/applications/qemu.desktop should have an "Exec=" key.

2020-05-08 Thread Frédéric Brière
Thank you Lockywolf for this bug report. Have you filed one against KDE as you previously mentioned? If so, could you provide us with a link? Thanks in advance! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

Re: [PATCH v16 QEMU 09/16] vfio: Add save state functions to SaveVMHandlers

2020-05-08 Thread Yan Zhao
On Wed, Mar 25, 2020 at 05:09:07AM +0800, Kirti Wankhede wrote: > Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy > functions. These functions handles pre-copy and stop-and-copy phase. > > In _SAVING|_RUNNING device state or pre-copy phase: > - read pending_bytes. If p

Re: [PATCH V3 00/14] KVM: MIPS: Add Loongson-3 support (Host Side)

2020-05-08 Thread Huacai Chen
Hi, Aleksandar, On Fri, May 8, 2020 at 7:43 PM Aleksandar Markovic wrote: > > нед, 3. мај 2020. у 12:06 Huacai Chen је написао/ла: > > > > We are preparing to add KVM support for Loongson-3. VZ extension is > > fully supported in Loongson-3A R4+, and we will not care about old CPUs > > (at least

[Bug 1877706] [NEW] [Feature request] qemu does not support for Octeon MIPS64 on X86

2020-05-08 Thread Lu Haocong
Public bug reported: Description of problem: I use mips64-octeon-linux-gnu-gcc cross toolchain on X86,and generate binary file. > mips64-octeon-linux-gnu-gcc hello.c -static > file a.out > a.out: ELF 32-bit MSB executable, MIPS, N32 MIPS64 rel2 version 1 (SYSV), > statically linked, for GNU/Lin

Re: [PATCH V2] hax: Dynamic allocate vcpu state structure

2020-05-08 Thread Colin Xu
Bowen is no longer working on the project so continue the revising. Sorry for the delayed reply. On 2020-05-09 11:59, Colin Xu wrote: From: WangBowen Dynamic allocating vcpu state structure according to smp value to be more precise and safe. Previously it will alloccate array of fixed size HA

[PATCH V2] hax: Dynamic allocate vcpu state structure

2020-05-08 Thread Colin Xu
From: WangBowen Dynamic allocating vcpu state structure according to smp value to be more precise and safe. Previously it will alloccate array of fixed size HAX_MAX_VCPU. This is achieved by using g_new0 to dynamic allocate the array. The allocated size is obtained from smp.max_cpus in MachineSt

Re: [RFC v2 0/9] vDPA support in qemu

2020-05-08 Thread Jason Wang
On 2020/5/9 上午12:32, Cindy Lu wrote: vDPA device is a device that uses a datapath which complies with the virtio specifications with vendor specific control path. vDPA devices can be both physically located on the hardware or emulated by software. This RFC introduce the vDPA support in qemu ch

Re: [RFC v2 5/9] vhost-vdpa: implement vhost-vdpa backend

2020-05-08 Thread Jason Wang
On 2020/5/9 上午11:00, Jason Wang wrote: +    .vhost_get_config  = vhost_vdpa_get_config, +    .vhost_set_config = vhost_vdpa_set_config, Btw, I don't see the actual user of those two helpers? Thanks

Re: [RFC v2 9/9] vhost: introduce vhost_set_vring_ready method

2020-05-08 Thread Jason Wang
On 2020/5/9 上午12:32, Cindy Lu wrote: From: Jason Wang Vhost-vdpa introduces VHOST_VDPA_SET_VRING_ENABLE which complies the semantic of queue_enable defined in virtio spec. This method can be used for preventing device from executing request for a specific virtqueue. This patch introduces the

Re: [RFC v2 8/9] vhost_net: set vq ready during start if necessary

2020-05-08 Thread Jason Wang
On 2020/5/9 上午12:32, Cindy Lu wrote: From: Jason Wang Signed-off-by: Jason Wang --- hw/net/vhost_net.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 1af39abaf3..eff9ec9177 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -

Re: [RFC v2 7/9] virito-pci: implement queue_enabled method

2020-05-08 Thread Jason Wang
On 2020/5/9 上午12:32, Cindy Lu wrote: From: Jason Wang With version 1, we can detect whether a queue is enabled via queue_enabled. Signed-off-by: Jason Wang This patch should come before any vhost-vdpa patch. Thanks --- hw/virtio/virtio-pci.c | 13 + 1 file changed, 13

Re: [RFC v2 6/9] virtio-bus: introduce queue_enabled method

2020-05-08 Thread Jason Wang
On 2020/5/9 上午12:32, Cindy Lu wrote: From: Jason Wang This patch introduces queue_enabled() method which allows the transport to implement its own way to report whether or not a queue is enabled. Signed-off-by: Jason Wang This patch should come before any of the vhost-vpda patch. Thanks

Re: [RFC v2 5/9] vhost-vdpa: implement vhost-vdpa backend

2020-05-08 Thread Jason Wang
On 2020/5/9 上午12:32, Cindy Lu wrote: From: Tiwei Bie Currently we have 2 types of vhost backends in QEMU: vhost kernel and vhost-user. The above patch provides a generic device for vDPA purpose, this vDPA device exposes to user space a non-vendor-specific configuration interface for setting u

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

2020-05-08 Thread chen huacai
Hi, Aleksandar, On Sat, May 9, 2020 at 12:55 AM Aleksandar Markovic wrote: > > нед, 3. мај 2020. у 12:21 Huacai Chen је написао/ла: > > > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > > R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while > > Loongso

Re: Parameter 'driver' expects pluggable device type

2020-05-08 Thread Priyamvad Acharya
Hi, I have set user_creatable to true in class_init function of pl061 source code. Now when I run qemu via command line with *-device *option it gives below output > qemu-system-arm: Device pl061 can not be dynamically instantiated > I request community members to reply asap!!! On

Re: [RFC v2 4/9] vhost-vdpa: introduce vhost-vdpa net client

2020-05-08 Thread Jason Wang
On 2020/5/9 上午12:32, Cindy Lu wrote: From: Tiwei Bie If you think you've done a huge refactor on the code, you can change the author but need to keep the sob of Tiwei. This patch set introduces a new net client type: vhost-vdpa. vhost-vdpa net client will set up a vDPA device which is

Re: [RFC v2 3/9] virtio_net: introduce vhost_set_state

2020-05-08 Thread Jason Wang
On 2020/5/9 上午12:32, Cindy Lu wrote: Introduce a function to set the state to the vhost driver. vDPA need to sync the driver's state to NIC Let's split this patch into two. 1) introduce vhost_set_state 2) make virtio-net use of vhost_set_state Signed-off-by: Cindy Lu --- hw/net/vhost

Re: [RFC v2 2/9] net: use the function qemu_get_peer

2020-05-08 Thread Jason Wang
On 2020/5/9 上午12:32, Cindy Lu wrote: user the qemu_get_peer to replace the old process The title should be "vhost_net: use the function qemu_get_peer". Thanks Signed-off-by: Cindy Lu --- hw/net/vhost_net.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --

[Bug 1877688] Re: 9p virtfs device reports error when opening certain files

2020-05-08 Thread A A
Here's a C program to trigger this behavior. I don't think it matters what the contents of "file" or its size is. ** Description changed: Reading certain files on a 9p mounted FS produces this error message: qemu-system-x86_64: VirtFS reply type 117 needs 12 bytes, buffer has 12, less th

Re: [PATCH v5 00/19] target/arm: sve load/store improvements

2020-05-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200508154359.7494-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200508154359.7494-1-richard.hender...@linaro.org Subject: [PATCH v5 00/19] target/arm: sve l

[Bug 1877688] Re: 9p virtfs device reports error when opening certain files

2020-05-08 Thread A A
** Description changed: Reading certain files on a 9p mounted FS produces this error message: qemu-system-x86_64: VirtFS reply type 117 needs 12 bytes, buffer has 12, less than minimum After this error message is generated, further accesses to the 9p FS hangs whatever tries to acce

[Bug 1877688] [NEW] 9p virtfs device reports error when opening certain files

2020-05-08 Thread A A
Public bug reported: Reading certain files on a 9p mounted FS produces this error message: qemu-system-x86_64: VirtFS reply type 117 needs 12 bytes, buffer has 12, less than minimum After this error message is generated, further accesses to the 9p FS hangs whatever tries to access it. The Arch L

Qemu Support for Virtio Video V4L2 driver

2020-05-08 Thread Saket Sinha
Hi , This is to inquire about Qemu support for Virtio Video V4L2 driver posted in [1]. I am currently not aware of any upstream effort for Qemu reference implementation and would like to discuss how to proceed with the same. [1]: https://patchwork.linuxtv.org/patch/61717/ Regards, Saket Sinha

[PATCH v1 7/8] s390/kvm: header sync for diag318

2020-05-08 Thread Collin Walling
Signed-off-by: Collin Walling --- linux-headers/asm-s390/kvm.h | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 0138ccb0d8..b661feafdc 100644 --- a/linux-headers/asm-s390/kvm.h +++ b/linux-headers/asm-s390/kvm.h @@ -74,6 +7

[PATCH v1 3/8] s390/sclp: rework sclp boundary and length checks

2020-05-08 Thread Collin Walling
Let's factor out the SCLP boundary and length checks into separate functions. Signed-off-by: Collin Walling --- hw/s390x/sclp.c | 41 +++-- 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index d08a291e40..470d5

[PATCH v1 2/8] s390/sclp: check sccb len before filling in data

2020-05-08 Thread Collin Walling
The SCCB must be checked for a sufficient length before it is filled with any data. If the length is insufficient, then the SCLP command is suppressed and the proper response code is set in the SCCB header. Signed-off-by: Collin Walling --- hw/s390x/sclp.c | 22 ++ smp.max_cp

[PATCH v1 8/8] s390: diagnose 318 info reset and migration support

2020-05-08 Thread Collin Walling
The DIAGNOSE 318 (diag318) instruction allows the guest to store diagnostic data that is collected by the firmware in the case of hardware/firmware service events. The instruction is invoked in the Linux kernel and intercepted in KVM. QEMU needs to collect this data for migration so that it is cons

[PATCH v1 5/8] s390/sclp: use cpu offset to locate cpu entries

2020-05-08 Thread Collin Walling
The start of the CPU entry region in the Read SCP Info response data is denoted by the offset_cpu field. As such, QEMU needs to begin creating entries at this address. This is in preparation for when Read SCP Info inevitably introduces new bytes that push the start of its CPUEntry field further aw

[PATCH v1 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-05-08 Thread Collin Walling
As more features and facilities are added to the Read SCP Info (RSCPI) response, more space is required to store them. The space used to store these new features intrudes on the space originally used to store CPU entries. This means as more features and facilities are added to the RSCPI response, l

[PATCH v1 1/8] s390/sclp: remove SCLPDevice param from prepare_cpu_entries

2020-05-08 Thread Collin Walling
It was never used in this function, so let's remove it. Signed-off-by: Collin Walling --- hw/s390x/sclp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index ede056b3ef..156ffe3223 100644 --- a/hw/s390x/sclp.c +++ b/hw/s390x/sclp.c @@

[PATCH v1 4/8] s390/sclp: read sccb from mem based on sccb length

2020-05-08 Thread Collin Walling
The header of the SCCB contains the actual length of the SCCB. Instead of using a static 4K size, let's allow for a variable size determined by the value set in the header. The proper checks are already in place to ensure the SCCB length is sufficent to store a full response, and that the length do

[PATCH v1 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-05-08 Thread Collin Walling
This patch series introduces two features for an s390 KVM quest: - Extended-Length SCCB (els) for the Read SCP/CPU Info SCLP commands - DIAGNOSE 0x318 (diag318) enabling / migration handling The diag318 feature depends on els and KVM support. The els feature is handled entirely w

[PATCH v24 QEMU 1/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-05-08 Thread Alexander Duyck
From: Alexander Duyck In an upcoming patch a feature named Free Page Reporting is about to be added. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report' with 'h

[PATCH v24 QEMU 3/3] virtio-balloon: Provide an interface for free page reporting

2020-05-08 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back into th

[PATCH v24 QEMU 2/3] virtio-balloon: Implement support for page poison reporting feature

2020-05-08 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison reporting if we want to actually get data on if the guest will be poisoning pages. Add a value for reporting the poison value being used if page poisoning is enabled in the guest. With this we can determine if we

[PATCH v24 QEMU 0/3] virtio-balloon: add support for page poison reporting and free page reporting

2020-05-08 Thread Alexander Duyck
This series provides an asynchronous means of reporting free guest pages to QEMU through virtio-balloon so that the memory associated with those pages can be dropped and reused by other processes and/or guests on the host. Using this it is possible to avoid unnecessary I/O to disk and greatly impro

[PULL v2 1/1] hw/tpm: fix usage of bool in tpm-tis.c

2020-05-08 Thread Stefan Berger
From: Jafar Abdi Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h. FALSE and TRUE (with capital letters) are the constants defined by glib for being used with the "gboolean" type of glib. But some parts of the code also use TRUE and FALSE for variables that are dec

[PULL v2 0/1] Merge tpm 2020/05/08 v2

2020-05-08 Thread Stefan Berger
This PR submits a fix that changes improperly used 'FALSE' to 'false'. The following changes since commit c88f1ffc19e38008a1c33ae039482a860aa7418c: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2020-05-08 14:29:18 +0100) are available in the Git repository at:

Re: [PATCH v3 06/17] block/io: support int64_t bytes in bdrv_aligned_pwritev()

2020-05-08 Thread Eric Blake
On 4/30/20 6:10 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be

Re: [PULL v1 1/1] hw/tpm: fix usage of bool in tpm-tis.c

2020-05-08 Thread Stefan Berger
On 5/8/20 4:04 PM, Stefan Berger wrote: Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h. FALSE and TRUE (with capital letters) are the constants defined by glib for being used with the "gboolean" type of glib. But some parts of the code also use TRUE and FALSE for

Re: [PATCH 4/4] exec: Rename qemu_ram_writeback() as qemu_ram_msync()

2020-05-08 Thread Richard Henderson
On 5/7/20 11:24 PM, Philippe Mathieu-Daudé wrote: > Rename qemu_ram_writeback() as qemu_ram_msync() to better > match what it does. > > Suggested-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé > --- > include/exec/ram_addr.h | 4 ++-- > exec.c | 2 +- > memory.c

Re: [PATCH 3/4] hw/block: Let the NVMe emulated device be target-agnostic

2020-05-08 Thread Richard Henderson
On 5/7/20 11:24 PM, Philippe Mathieu-Daudé wrote: > Now than the non-target specific memory_region_msync() function > is available, use it to make this device target-agnostic. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/block/nvme.c| 6 ++ > hw/block/Makefile.objs | 2 +- >

[Bug 1868116] Re: QEMU monitor no longer works

2020-05-08 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1868116 Title: QEMU monitor no longer works Status in QEMU: New Status in qemu packa

Re: [PATCH 1/4] memory: Rename memory_region_do_writeback -> memory_region_writeback

2020-05-08 Thread Richard Henderson
On 5/7/20 11:24 PM, Philippe Mathieu-Daudé wrote: > We usually use '_do_' for internal functions. Rename > memory_region_do_writeback() as memory_region_writeback(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/exec/memory.h | 4 ++-- > memory.c | 2 +- > target/arm/hel

[PULL v1 1/1] hw/tpm: fix usage of bool in tpm-tis.c

2020-05-08 Thread Stefan Berger
Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h. FALSE and TRUE (with capital letters) are the constants defined by glib for being used with the "gboolean" type of glib. But some parts of the code also use TRUE and FALSE for variables that are declared as "bool" (th

[PULL v1 0/1] Merge tpm 2020/05/08 v1

2020-05-08 Thread Stefan Berger
This PR submits a fix that changes improperly used 'FALSE' to 'false'. The following changes since commit c88f1ffc19e38008a1c33ae039482a860aa7418c: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2020-05-08 14:29:18 +0100) are available in the Git repository at:

Re: [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c

2020-05-08 Thread Stefan Berger
On 5/7/20 7:52 AM, Daniel P. Berrangé wrote: ping, again, for either qemu-trivial or TPM maintainers to take this patch. The other three in this series are merged, but this TPM patch is still pending. I'll send a PR with it tonight.

RE: [PATCH v3 06/11] net: cadence_gem: Move tx/rx packet buffert to CadenceGEMState

2020-05-08 Thread Sai Pavan Boddu
Hi Edgar, > -Original Message- > From: Edgar E. Iglesias > Sent: Friday, May 8, 2020 5:00 PM > To: Sai Pavan Boddu > Cc: Alistair Francis ; Peter Maydell > ; Jason Wang ; Markus > Armbruster ; Philippe Mathieu-Daudé > ; Tong Ho ; Ramon Fried > ; qemu-...@nongnu.org; qemu- > de...@nongnu.

RE: [PATCH v3 07/11] net: cadence_gem: Add support for jumbo frames

2020-05-08 Thread Sai Pavan Boddu
Hi Edgar, > -Original Message- > From: Edgar E. Iglesias > Sent: Friday, May 8, 2020 5:14 PM > To: Sai Pavan Boddu > Cc: Alistair Francis ; Peter Maydell > ; Jason Wang ; Markus > Armbruster ; Philippe Mathieu-Daudé > ; Tong Ho ; Ramon Fried > ; qemu-...@nongnu.org; qemu- > de...@nongnu.

Re: [PATCH v4 07/19] tcg: Use tcg_constant_{i32,i64,vec} with tcg gvec expanders

2020-05-08 Thread Richard Henderson
On 5/8/20 11:26 AM, Richard Henderson wrote: > @@ -1647,16 +1632,14 @@ static void gen_addv_mask(TCGv_i64 d, TCGv_i64 a, > TCGv_i64 b, TCGv_i64 m) > > void tcg_gen_vec_add8_i64(TCGv_i64 d, TCGv_i64 a, TCGv_i64 b) > { > -TCGv_i64 m = tcg_const_i64(dup_const(MO_8, 0x80)); > +TCGv_i64 m =

Re: [PATCH v2 3/3] arm/acpi: Add the TPM2.0 device under the DSDT

2020-05-08 Thread Stefan Berger
On 5/8/20 11:25 AM, Ard Biesheuvel wrote: On Fri, 8 May 2020 at 17:24, Shannon Zhao wrote: Hi, On 2020/5/5 22:44, Eric Auger wrote: +static void acpi_dsdt_add_tpm(Aml *scope, VirtMachineState *vms) +{ +hwaddr pbus_base = vms->memmap[VIRT_PLATFORM_BUS].base; +PlatformBusDevice *pbus =

Re: [PATCH v4 01/19] tcg: Consolidate 3 bits into enum TCGTempKind

2020-05-08 Thread Philippe Mathieu-Daudé
On 5/8/20 8:25 PM, Richard Henderson wrote: The temp_fixed, temp_global, temp_local bits are all related. Combine them into a single enumeration. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 20 +--- tcg/optimize.c| 8 +-- tcg/tcg.c |

Re: [PATCH v3 01/19] tcg: Consolidate 3 bits into enum TCGTempKind

2020-05-08 Thread Philippe Mathieu-Daudé
On 5/8/20 5:17 PM, Richard Henderson wrote: The temp_fixed, temp_global, temp_local bits are all related. Combine them into a single enumeration. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 20 +--- tcg/optimize.c| 8 +-- tcg/tcg.c | 122 +

Re: [PATCH 2/2] hw/display/edid: Add missing 'qdev-properties.h' header

2020-05-08 Thread Philippe Mathieu-Daudé
On Mon, May 4, 2020 at 8:38 PM Richard Henderson wrote: > > On 5/4/20 1:20 AM, Philippe Mathieu-Daudé wrote: > > To use the DEFINE_EDID_PROPERTIES() macro we need the > > definitions from "hw/qdev-properties.h". > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > include/hw/display/edid.h

Re: [PATCH v3 3/3] target/arm: Use clear_vec_high more effectively

2020-05-08 Thread Philippe Mathieu-Daudé
On Tue, May 5, 2020 at 4:22 PM Richard Henderson wrote: > > On 5/4/20 11:09 PM, Philippe Mathieu-Daudé wrote: > >> @@ -7111,7 +7121,7 @@ static void disas_simd_zip_trn > >> } > >> tcg_resl = tcg_const_i64(0); > >> -tcg_resh = tcg_const_i64(0); > >> +tcg_resh = is_q ? tcg_cons

[PATCH v4 18/19] tcg/i386: Use tcg_constant_vec with tcg vec expanders

2020-05-08 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 5e73e5d02b..cce28c81d7 100644 --- a/tcg/i386/tcg-ta

[PATCH v4 19/19] tcg: Remove tcg_gen_dup{8,16,32,64}i_vec

2020-05-08 Thread Richard Henderson
These interfaces have been replaced by tcg_gen_dupi_vec and tcg_constant_vec. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h | 4 tcg/tcg-op-vec.c | 20 2 files changed, 24 deletions(-) diff --git a/include/tcg/tcg-op.h b/inclu

[PATCH v4 16/19] tcg: Increase tcg_out_dupi_vec immediate to int64_t

2020-05-08 Thread Richard Henderson
While we don't store more than tcg_target_long in TCGTemp, we shouldn't be limited to that for code generation. We will be able to use this for INDEX_op_dup2_vec with 2 constants. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 2 +- tcg/i386/tcg-t

[PATCH v4 17/19] tcg: Add tcg_reg_alloc_dup2

2020-05-08 Thread Richard Henderson
There are several ways we can expand a vector dup of a 64-bit element on a 32-bit host. Signed-off-by: Richard Henderson --- tcg/tcg.c | 88 +++ 1 file changed, 88 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index 18ebcc98f6..e8fe2d580b 1

[PATCH v4 13/19] tcg/tci: Add special tci_movi_{i32,i64} opcodes

2020-05-08 Thread Richard Henderson
The normal movi opcodes are going away. We need something for TCI to use internally. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h| 8 tcg/tci.c| 4 ++-- tcg/tci/tcg-target.inc.c | 4 ++-- 3 files changed, 12 insertions(+), 4 d

[PATCH v4 15/19] tcg: Use tcg_out_dupi_vec from temp_load

2020-05-08 Thread Richard Henderson
Having dupi pass though movi is confusing and arguably wrong. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 7 tcg/i386/tcg-target.inc.c| 63 tcg/ppc/tcg-target.inc.c | 6 tcg/tcg.c

[PATCH v4 12/19] tcg/optimize: Use tcg_constant_internal with constant folding

2020-05-08 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/optimize.c | 106 ++--- 1 file changed, 48 insertions(+), 58 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index d36d7e1d7f..dd5187be31 100644 --- a/tcg/optimize.c +++ b/tcg

[PATCH v4 10/19] tcg/optimize: Improve find_better_copy

2020-05-08 Thread Richard Henderson
Prefer TEMP_CONST over anything else. Signed-off-by: Richard Henderson --- tcg/optimize.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c0fc5e3da6..b86bf3d707 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.

[PATCH v4 11/19] tcg/optimize: Adjust TempOptInfo allocation

2020-05-08 Thread Richard Henderson
Do not allocate a large block for indexing. Instead, allocate for each temporary as they are seen. In general, this will use less memory, if we consider that most TBs do not touch every target register. This also allows us to allocate TempOptInfo for new temps created during optimization. Revie

[PATCH v4 09/19] tcg: Rename struct tcg_temp_info to TempOptInfo

2020-05-08 Thread Richard Henderson
Fix this name vs our coding style. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/optimize.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 8f3bd

[PATCH v4 05/19] tcg: Use tcg_constant_{i32, i64} with tcg int expanders

2020-05-08 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h | 13 +-- tcg/tcg-op.c | 216 --- 2 files changed, 100 insertions(+), 129 deletions(-) diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h index 5abf17fecc..b

[PATCH v4 08/19] tcg: Use tcg_constant_{i32,i64} with tcg plugins

2020-05-08 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- accel/tcg/plugin-gen.c | 49 +++--- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 51580d51a0..e5dc9d0ca9 100644 --- a/accel/tc

[PATCH v4 06/19] tcg: Use tcg_constant_{i32, vec} with tcg vec expanders

2020-05-08 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 63 ++-- 1 file changed, 34 insertions(+), 29 deletions(-) diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index 43101defe4..0e3e80a612 100644 --- a/tcg/tcg-op-vec.c +++

[PATCH v4 07/19] tcg: Use tcg_constant_{i32, i64, vec} with tcg gvec expanders

2020-05-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg-op-gvec.c | 125 +++--- 1 file changed, 50 insertions(+), 75 deletions(-) diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c index 3707c0effb..8ecaf4d67e 100644 --- a/tcg/tcg-op-gvec.c +++ b/tcg/tcg-op-gvec.c @@

[PATCH v4 03/19] tcg: Introduce TYPE_CONST temporaries

2020-05-08 Thread Richard Henderson
These will hold a single constant for the duration of the TB. They are hashed, so that each value has one temp across the TB. Not used yet, this is all infrastructure. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 27 +++- tcg/optimize.c| 13 +++- tcg/tcg-op-vec.c | 17 ++

[PATCH v4 01/19] tcg: Consolidate 3 bits into enum TCGTempKind

2020-05-08 Thread Richard Henderson
The temp_fixed, temp_global, temp_local bits are all related. Combine them into a single enumeration. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 20 +--- tcg/optimize.c| 8 +-- tcg/tcg.c | 122

[PATCH v4 14/19] tcg: Remove movi and dupi opcodes

2020-05-08 Thread Richard Henderson
These are now completely covered by mov from a TYPE_CONST temporary. Reviewed-by: Alex Bennée Reviewed-by: Aleksandar Markovic Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h| 3 --- tcg/aarch64/tcg-target.inc.c | 3 --- tcg/arm/tcg-target.inc.c | 1 - tcg/i386/tcg-ta

[PATCH v4 04/19] tcg: Use tcg_constant_i32 with icount expander

2020-05-08 Thread Richard Henderson
We must do this before we adjust how tcg_out_movi_i32, lest the under-the-hood poking that we do be broken. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/inc

[PATCH v4 00/19] tcg: Better handling of constants

2020-05-08 Thread Richard Henderson
V4 adds the r-b against v2 that I forgot to go back and add. Re patch 17, Alex asked if I could ifdef tcg_reg_alloc_dup2 instead of assert within it. Answer: No, not without adding still more ifdefs to compensate. In the end I prefer the assert. V3 fixes the target/sparc regression during regis

[PATCH v4 02/19] tcg: Add temp_readonly

2020-05-08 Thread Richard Henderson
In most, but not all, places that we check for TEMP_FIXED, we are really testing that we do not modify the temporary. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 5 + tcg/tcg.c | 21 ++--- 2

[PATCH] spapr: Add a new level of NUMA for GPUs

2020-05-08 Thread Reza Arbab
NUMA nodes corresponding to GPU memory currently have the same affinity/distance as normal memory nodes. Add a third NUMA associativity reference point enabling us to give GPU nodes more distance. Before, `numactl -H` output in a guest with 4 GPUs (nodes 2-5): node distances: node 0 1 2 3

Re: [PATCH v3 05/17] block/io: support int64_t bytes in bdrv_co_do_pwrite_zeroes()

2020-05-08 Thread Eric Blake
On 4/30/20 6:10 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be

Re: [PATCH v23 QEMU 0/5] virtio-balloon: add support for page poison reporting and free page reporting

2020-05-08 Thread David Hildenbrand
> Am 08.05.2020 um 19:31 schrieb Alexander Duyck : > > I just wanted to follow up since it has been a little over a week > since I submitted this and I haven't heard anything back. It looks > like the linux-headers patches can be dropped since the headers appear > to have been synced. I was wo

[PATCH v3 5/9] blockdev: Split off basic bitmap operations for qemu-img

2020-05-08 Thread Eric Blake
Upcoming patches want to add some basic bitmap manipulation abilities to qemu-img. But blockdev.o is too heavyweight to link into qemu-img (among other things, it would drag in block jobs and transaction support - qemu-img does offline manipulation, where atomicity is less important because there

[PATCH v3 9/9] iotests: Add test 291 to for qemu-img bitmap coverage

2020-05-08 Thread Eric Blake
Add a new test covering the 'qemu-img bitmap' subcommand, as well as 'qemu-img convert --bitmaps', both added in recent patches. Signed-off-by: Eric Blake --- tests/qemu-iotests/291 | 112 + tests/qemu-iotests/291.out | 78 ++ test

[PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-08 Thread Eric Blake
It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data. Report this value as an additional field, present when measuring an existing image and the output format supports bitmaps. Update iotest 178 and 190 to

[PATCH v3 3/9] block: Make it easier to learn which BDS support bitmaps

2020-05-08 Thread Eric Blake
Upcoming patches will enhance bitmap support in qemu-img, but in doing so, it turns out to be nice to suppress output when bitmaps make no sense (such as on a qcow2 v2 image). Add a hook to make this easier to query. In the future, when we improve the ability to look up bitmaps through a filter,

[PATCH v3 6/9] qemu-img: Add bitmap sub-command

2020-05-08 Thread Eric Blake
Include actions for --add, --remove, --clear, --enable, --disable, and --merge (note that --clear is a bit of fluff, because the same can be accomplished by removing a bitmap and then adding a new one in its place, but it matches what QMP commands exist). Listing is omitted, because it does not re

[PATCH v3 8/9] qemu-img: Add convert --bitmaps option

2020-05-08 Thread Eric Blake
Make it easier to copy all the persistent bitmaps of (the top layer of) a source image along with its guest-visible contents, by adding a boolean flag for use with qemu-img convert. This is basically shorthand, as the same effect could be accomplished with a series of 'qemu-img bitmap --add' and '

[PATCH v3 2/9] qemu-img: Fix stale comments on doc location

2020-05-08 Thread Eric Blake
Missed in commit e13c59fa. Signed-off-by: Eric Blake --- qemu-img.c | 2 +- qemu-img-cmds.hx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 6a4327aaba56..b6e8af9202a5 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -108,7 +108,7 @@ static v

[PATCH v3 0/9] qemu-img: Add convert --bitmaps

2020-05-08 Thread Eric Blake
v2 was here, to see the original cover letter: https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg03464.html Since then: - patch 2 was previously posted in isolation but fits well in this series - patch 3 is new - patch 4 and 5 were split from v2:2/6 [Max] - new filename chosen in patch 5 is

[PATCH v3 1/9] docs: Sort sections on qemu-img subcommand parameters

2020-05-08 Thread Eric Blake
We already list the subcommand summaries alphabetically, we should do the same for the documentation related to subcommand-specific parameters. Signed-off-by: Eric Blake Reviewed-by: Max Reitz --- docs/tools/qemu-img.rst | 48 - 1 file changed, 24 inserti

[PATCH v3 4/9] blockdev: Promote several bitmap functions to non-static

2020-05-08 Thread Eric Blake
The next patch will split blockdev.c, which will require accessing some previously-static functions from more than one .c file. But part of promoting a function to public is picking a naming scheme that does not reek of exposing too many internals (two of the three functions were named starting wi

Re: [PATCH v2] e1000e: Added ICR clearing by corresponding IMS bit.

2020-05-08 Thread Andrew Melnichenko
Yo, I've used OpenSDM_8257x-18.pdf specification. This document was recommended by Intel guys(Also, they referenced to that note). I've made a fast fix and it works. Before that I had a fix for Linux e1000e driver. Overall, the issue was in pending interrupts that can't be cleared by reading ICR in

Re: [PATCH] cpus: Fix botched configure_icount() error API violation fix

2020-05-08 Thread Markus Armbruster
Markus Armbruster writes: > Fixes: abc9bf69a66a11499a801ff545b8fe7adbb3a04c > Fixes: Coverity CID 1428754 > Signed-off-by: Markus Armbruster > --- > cpus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cpus.c b/cpus.c > index 5670c96bcf..b9275c672d 100644 > --- a/cpus

[PATCH v2 4/5] virtio-iommu-pci: Add array of Interval properties

2020-05-08 Thread Eric Auger
The machine may need to pass reserved regions to the virtio-iommu-pci device (such as the MSI window on x86). So let's add an array of Interval properties. Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker --- v12 -> v12: - added Jean's R-b --- hw/virtio/virtio-iommu-pci.c | 3 +++

[PATCH v2 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs

2020-05-08 Thread Eric Auger
At the moment the virtio-iommu translates MSI transactions. This behavior is inherited from ARM SMMU. The virt machine code knows where the guest MSI doorbells are so we can easily declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that setting the guest will not map MSIs through the IOMMU

[PATCH v2 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-08 Thread Eric Auger
This patch implements the PROBE request. At the moment, only THE RESV_MEM property is handled. The first goal is to report iommu wide reserved regions such as the MSI regions set by the machine code. On x86 this will be the IOAPIC MSI region, [0xFEE0 - 0xFEEF], on ARM this may be the ITS do

[PATCH v2 3/5] virtio-iommu: Handle reserved regions in the translation process

2020-05-08 Thread Eric Auger
When translating an address we need to check if it belongs to a reserved virtual address range. If it does, there are 2 cases: - it belongs to a RESERVED region: the guest should neither use this address in a MAP not instruct the end-point to DMA on them. We report an error - It belongs to an

[PATCH v2 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-05-08 Thread Eric Auger
By default the virtio-iommu translates MSI transactions. This behavior is inherited from ARM SMMU. However the virt machine code knows where the MSI doorbells are, so we can easily declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that setting the guest iommu subsystem will not need to map

  1   2   3   4   >