[PATCH] iotests/055: Use cache.no-flush for vmdk target

055 uses the backup block job to create a compressed backup of an $IMGFMT image with both qcow2 and vmdk targets. However, cluster allocation in vmdk is very slow because it flushes the image file after each L2 update. There is no reason why we need this level of safety in this test, so let's disa

Re: [PATCH qemu] spapr: Add PVR setting capability

On 05/05/2020 15:50, David Gibson wrote: > On Tue, May 05, 2020 at 10:56:17AM +1000, Alexey Kardashevskiy wrote: >> >> >> On 04/05/2020 21:30, Greg Kurz wrote: >>> On Fri, 17 Apr 2020 14:11:05 +1000 >>> Alexey Kardashevskiy wrote: >>> At the moment the VCPU init sequence includes setting P

Re: [PATCH v18 QEMU 02/18] vfio: Add function to unmap VFIO region

Hi Kirti, On 5/5/20 12:44 AM, Kirti Wankhede wrote: This function will be used for migration region. Migration region is mmaped when migration starts and will be unmapped when migration is complete. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Cornelia Huck --- hw/vfio/c

Re: [PATCH v3 3/3] target/arm: Use clear_vec_high more effectively

On 5/4/20 9:23 PM, Richard Henderson wrote: Do not explicitly store zero to the NEON high part when we can pass !is_q to clear_vec_high. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- Patch easier to review with 'git-diff --function-context'. target/arm/translate-a64.c | 5

Re: [PATCH] aspeed: Support AST2600A1 silicon revision

On 5/4/20 11:37 AM, Joel Stanley wrote: > There are minimal differences from Qemu's point of view between the A0 > and A1 silicon revisions. > > As the A1 exercises different code paths in u-boot it is desirable to > emulate that instead. > > Signed-off-by: Joel Stanley Reviewed-by: Cédric Le G

Re: [PATCH qemu] spapr: Add PVR setting capability

On Tue, May 05, 2020 at 10:56:17AM +1000, Alexey Kardashevskiy wrote: > > > On 04/05/2020 21:30, Greg Kurz wrote: > > On Fri, 17 Apr 2020 14:11:05 +1000 > > Alexey Kardashevskiy wrote: > > > >> At the moment the VCPU init sequence includes setting PVR which in case of > >> KVM-HV only checks if

Re: [PATCH v5 06/18] nvme: refactor nvme_addr_read

On May 5 07:48, Klaus Jensen wrote: > From: Klaus Jensen > > Pull the controller memory buffer check to its own function. The check > will be used on its own in later patches. > > Signed-off-by: Klaus Jensen > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Maxim Levitsky > Reviewed-by: K

[PATCH v5 16/18] nvme: factor out pmr setup

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 95 ++--- 1 file changed, 51 insertions(+), 44 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index bd255a5c711a..b0b3d3ffb75f 100644 --- a

[PATCH v5 17/18] nvme: do cmb/pmr init as part of pci init

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index b0b3d3ffb75f..6454f3810e5b 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c

[PATCH v5 14/18] nvme: factor out pci setup

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c i

[PATCH v5 12/18] nvme: add namespace helpers

From: Klaus Jensen Introduce some small helpers to make the next patches easier on the eye. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 3 +-- hw/block/nvme.h | 17 + 2 files chan

[PATCH v5 11/18] nvme: factor out block backend setup

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 72e838a476af.

[PATCH v5 13/18] nvme: factor out namespace setup

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/hw/block/nvme.c b/

[PATCH v5 18/18] nvme: factor out controller identify setup

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 49 ++--- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/hw/block/nvme.c

[PATCH v5 15/18] nvme: factor out cmb setup

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/hw/block/nvme.c b/hw/b

[PATCH v5 09/18] nvme: factor out property/constraint checks

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 48 ++-- 1 file changed, 30 insertions(+), 18 deletions(-) diff --git a/hw/block/nvme.c b

[PATCH v5 10/18] nvme: factor out device state setup

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 13fb

[PATCH v5 02/18] nvme: rename trace events to pci_nvme

From: Klaus Jensen Change the prefix of all nvme device related trace events to 'pci_nvme' to not clash with trace events from the nvme block driver. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c

[PATCH v5 00/18] nvme: refactoring and cleanups

From: Klaus Jensen Changes since v5 No functional changes, just updated Reviewed-by tags. Also, I screwed up the CC list when sending v4. Philippe and Keith, please add a Reviewed-by to * "nvme: factor out pmr setup" and * "do cmb/pmr init as part of pci init" since the fi

[PATCH v5 05/18] nvme: use constants in identify

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Maxim Levitsky Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Keith Busch --- hw/block/nvme.c | 8 include/block/nvme.h | 8 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/hw/block/nvme.c b/

[PATCH v5 07/18] nvme: add max_ioqpairs device parameter

From: Klaus Jensen The num_queues device paramater has a slightly confusing meaning because it accounts for the admin queue pair which is not really optional. Secondly, it is really a maximum value of queues allowed. Add a new max_ioqpairs parameter that only accounts for I/O queue pairs, but ke

[PATCH v5 06/18] nvme: refactor nvme_addr_read

From: Klaus Jensen Pull the controller memory buffer check to its own function. The check will be used on its own in later patches. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 16

[PATCH v5 04/18] nvme: move device parameters to separate struct

From: Klaus Jensen Move device configuration parameters to separate struct to make it explicit what is configurable and what is set internally. Signed-off-by: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 49 ++

[PATCH v5 01/18] nvme: fix pci doorbell size calculation

From: Klaus Jensen The size of the BAR is 0x1000 (main registers) + 8 bytes for each queue. Currently, the size of the BAR is calculated like so: n->reg_size = pow2ceil(0x1004 + 2 * (n->num_queues + 1) * 4); Since the 'num_queues' parameter already accounts for the admin queue, this should

[PATCH v5 08/18] nvme: remove redundant cmbloc/cmbsz members

From: Klaus Jensen Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Maxim Levitsky Reviewed-by: Keith Busch --- hw/block/nvme.c | 7 ++- hw/block/nvme.h | 2 -- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c in

[PATCH v5 03/18] nvme: remove superfluous breaks

From: Klaus Jensen These break statements was left over when commit 3036a626e9ef ("nvme: add Get/Set Feature Timestamp support") was merged. Signed-off-by: Klaus Jensen Reviewed-by: Maxim Levitsky Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Keith Busch --- hw/block/nvme.c | 4 1 f

Re: [PATCH 4/4] hw/i386: Make vmmouse helpers static

On 5/4/20 7:29 PM, Richard Henderson wrote: On 5/4/20 1:33 AM, Philippe Mathieu-Daudé wrote: +++ b/hw/i386/vmport.c @@ -23,10 +23,10 @@ */ #include "qemu/osdep.h" #include "hw/isa/isa.h" -#include "hw/i386/pc.h" #include "sysemu/hw_accel.h" #include "qemu/log.h" #include "vmport.h"

Re: [PATCH v4 00/18] nvme: factor out cmb/pmr setup

Hi Klaus, On 5/5/20 6:31 AM, Klaus Jensen wrote: On Apr 29 07:40, Klaus Jensen wrote: On Apr 22 13:01, Klaus Jensen wrote: From: Klaus Jensen Changes since v3 * Remove the addition of a new PROPERTIES macro in "nvme: move device parameters to separate struct" (Philippe)

Re: [PATCH 1/1] target-ppc: fix rlwimi, rlwinm, rlwnm for Clang-9

On Fri, May 01, 2020 at 03:09:13PM -0400, Daniele Buono wrote: > Starting with Clang v9, -Wtype-limits is implemented and triggers a > few "result of comparison is always true" errors when compiling PPC32 > targets. > > The comparisons seem to be necessary only on PPC64, since the > else branch in

Re: [PATCH 0/2] checkpatch: fix handling of acpi expected files

Patchew URL: https://patchew.org/QEMU/20200504115848.34410-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200504115848.34410-1-...@redhat.com Subject: [PATCH 0/2] checkpatch: fix handling of acpi expected files T

Re: [PATCH v16 QEMU 04/16] vfio: Add save and load functions for VFIO PCI devices

On Tue, 5 May 2020 04:48:37 +0530 Kirti Wankhede wrote: > On 3/26/2020 1:26 AM, Alex Williamson wrote: > > On Wed, 25 Mar 2020 02:39:02 +0530 > > Kirti Wankhede wrote: > > > >> These functions save and restore PCI device specific data - config > >> space of PCI device. > >> Tested save and re

Re: [PATCH v16 QEMU 08/16] vfio: Register SaveVMHandlers for VFIO device

On Tue, 5 May 2020 04:49:10 +0530 Kirti Wankhede wrote: > On 3/26/2020 2:32 AM, Alex Williamson wrote: > > On Wed, 25 Mar 2020 02:39:06 +0530 > > Kirti Wankhede wrote: > > > >> Define flags to be used as delimeter in migration file stream. > >> Added .save_setup and .save_cleanup functions. M

Re: [PATCH v16 QEMU 09/16] vfio: Add save state functions to SaveVMHandlers

On Tue, 5 May 2020 04:48:14 +0530 Kirti Wankhede wrote: > On 3/26/2020 3:33 AM, Alex Williamson wrote: > > On Wed, 25 Mar 2020 02:39:07 +0530 > > Kirti Wankhede wrote: > > > >> Added .save_live_pending, .save_live_iterate and > >> .save_live_complete_precopy > >> functions. These functions h

Re: [PATCH v4 00/18] nvme: factor out cmb/pmr setup

On Apr 29 07:40, Klaus Jensen wrote: > On Apr 22 13:01, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Changes since v3 > > > > * Remove the addition of a new PROPERTIES macro in "nvme: move device > > parameters to separate struct" (Philippe) > > > > * Add NVME_PMR_BIR co

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

Hi, Ike. I think this tricky bug was fixed by Paolo last month. Please try patch https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5710a3e09f9b85801e5ce70797a4a511e5fc9e2c. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs

[Bug 1875762] Re: Poor disk performance on sparse VMDKs

Thanks Stefan. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1875762 Title: Poor disk performance on sparse VMDKs Status in QEMU: New Bug description: Found in QEMU 4.1, and reproduced on mas

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

Take several CPUs offline and re-test. Even only 32 threads left, I still can reproduce this issue easily. ubuntu@kreiken:~$ lscpu | grep list;for i in `seq 1 10`;do echo ;rm -f out.img;timeout 30 qemu-img convert -f qcow2 -O qcow2 ./bionic-server-cloudimg-arm64.img out.img -p; done On-line CPU(

Re: [PATCH qemu] spapr: Add PVR setting capability

On 04/05/2020 21:30, Greg Kurz wrote: > On Fri, 17 Apr 2020 14:11:05 +1000 > Alexey Kardashevskiy wrote: > >> At the moment the VCPU init sequence includes setting PVR which in case of >> KVM-HV only checks if it matches the hardware PVR mask as PVR cannot be >> virtualized by the hardware. In

Re: [PATCH v1 4/4] .travis.yml: reduce the load on [ppc64] GCC check-tcg

On Mon, May 04, 2020 at 08:48:46PM +0100, Alex Bennée wrote: > > Richard Henderson writes: > > > On 5/3/20 7:10 PM, David Gibson wrote: > > - TEST_CMD="make check check-tcg V=1" > > -- CONFIG="--disable-containers > > --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-l

Re: [PATCH 5/6] block/nvme: Align block pages queue to host page size

On Mon, May 04, 2020 at 11:46:40AM +0200, Philippe Mathieu-Daudé wrote: > In nvme_create_queue_pair() we create a page list using > qemu_blockalign(), then map it with qemu_vfio_dma_map(): > > q->prp_list_pages = qemu_blockalign0(bs, s->page_size * NVME_QUEUE_SIZE); > r = qemu_vfio_dma_map(s->

Re: [PATCH qemu] spapr: Add PVR setting capability

On 04/05/2020 21:38, Cédric Le Goater wrote: > > > On 5/4/20 1:30 PM, Greg Kurz wrote: >> On Fri, 17 Apr 2020 14:11:05 +1000 >> Alexey Kardashevskiy wrote: >> >>> At the moment the VCPU init sequence includes setting PVR which in case of >>> KVM-HV only checks if it matches the hardware PVR m

[PATCH v2 4/4] softfloat: fix floatx80 pseudo-denormal round to integer

The softfloat function floatx80_round_to_int incorrectly handles the case of a pseudo-denormal where only the high bit of the significand is set, ignoring that bit (treating the number as an exact zero) rather than treating the number as an alternative representation of +/- 2^-16382 (which may roun

[PATCH v2 3/4] softfloat: fix floatx80 pseudo-denormal comparisons

The softfloat floatx80 comparisons fail to allow for pseudo-denormals, which should compare equal to corresponding values with biased exponent 1 rather than 0. Add an adjustment for that case when comparing numbers with the same sign. Note that this fix only changes floatx80_compare_internal, not

[PATCH v2 1/4] softfloat: silence sNaN for conversions to/from floatx80

Conversions between IEEE floating-point formats should convert signaling NaNs to quiet NaNs. Most of those in QEMU's softfloat code do so, but those for floatx80 fail to. Fix those conversions to silence signaling NaNs as well. Signed-off-by: Joseph Myers --- fpu/softfloat.c

Re: [PATCH v16 QEMU 10/16] vfio: Add load state functions to SaveVMHandlers

On 4/2/2020 12:28 AM, Dr. David Alan Gilbert wrote: * Kirti Wankhede (kwankh...@nvidia.com) wrote: Sequence during _RESUMING device state: While data for this device is available, repeat below steps: a. read data_offset from where user application should write data. b. write data of data_siz

Re: [PATCH v16 QEMU 04/16] vfio: Add save and load functions for VFIO PCI devices

On 4/7/2020 9:40 AM, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: On 2020/3/25 5:09, Kirti Wankhede wrote: These functions save and restore PCI device specific data - config space of PCI device. Tested save and restore with MSI and MSIX type. Signed-off-by: Kirti Wan

[PATCH v2 2/4] softfloat: fix floatx80 pseudo-denormal addition / subtraction

The softfloat function addFloatx80Sigs, used for addition of values with the same sign and subtraction of values with opposite sign, fails to handle the case where the two values both have biased exponent zero and there is a carry resulting from adding the significands, which can occur if one or bo

Re: [PATCH v16 QEMU 07/16] vfio: Add migration state change notifier

On 4/1/2020 4:57 PM, Dr. David Alan Gilbert wrote: * Kirti Wankhede (kwankh...@nvidia.com) wrote: Added migration state change notifier to get notification on migration state change. These states are translated to VFIO device state and conveyed to vendor driver. Signed-off-by: Kirti Wankhede

Re: [PATCH v16 QEMU 13/16] vfio: Add function to start and stop dirty pages tracking

On 4/2/2020 12:33 AM, Dr. David Alan Gilbert wrote: * Kirti Wankhede (kwankh...@nvidia.com) wrote: Call VFIO_IOMMU_DIRTY_PAGES ioctl to start and stop dirty pages tracking for VFIO devices. Signed-off-by: Kirti Wankhede --- hw/vfio/migration.c | 36 1

[PATCH v18 QEMU 13/18] vfio: Add function to start and stop dirty pages tracking

Call VFIO_IOMMU_DIRTY_PAGES ioctl to start and stop dirty pages tracking for VFIO devices. Signed-off-by: Kirti Wankhede --- hw/vfio/migration.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index 3d11d212b1ce.

[PATCH v2 0/4] softfloat: fix floatx80 emulation bugs

Attempting to run the GCC and glibc testsuites for i686 under QEMU shows up a range of bugs in the x87 floating-point emulation. This series fixes some bugs (found both through those testsuites and through subsequent code inspection) that appear to be in the softfloat code itself rather than in th

Re: [PATCH v16 QEMU 05/16] vfio: Add migration region initialization and finalize function

On 3/26/2020 11:22 PM, Dr. David Alan Gilbert wrote: * Kirti Wankhede (kwankh...@nvidia.com) wrote: - Migration functions are implemented for VFIO_DEVICE_TYPE_PCI device in this patch series. - VFIO device supports migration or not is decided based of migration region query. If migratio

Re: [PATCH v16 QEMU 04/16] vfio: Add save and load functions for VFIO PCI devices

On 3/26/2020 11:16 PM, Dr. David Alan Gilbert wrote: * Kirti Wankhede (kwankh...@nvidia.com) wrote: These functions save and restore PCI device specific data - config space of PCI device. Tested save and restore with MSI and MSIX type. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia ---

Re: [PATCH v16 QEMU 08/16] vfio: Register SaveVMHandlers for VFIO device

On 4/1/2020 11:06 PM, Dr. David Alan Gilbert wrote: * Kirti Wankhede (kwankh...@nvidia.com) wrote: Define flags to be used as delimeter in migration file stream. Added .save_setup and .save_cleanup functions. Mapped & unmapped migration region from these functions at source during saving or p

[PATCH v18 QEMU 16/18] vfio: Add ioctl to get dirty pages bitmap during dma unmap.

With vIOMMU, IO virtual address range can get unmapped while in pre-copy phase of migration. In that case, unmap ioctl should return pages pinned in that range and QEMU should find its correcponding guest physical addresses and report those dirty. Note: This patch is not yet tested. I'm trying to

Re: [PATCH v16 QEMU 13/16] vfio: Add function to start and stop dirty pages tracking

On 3/27/2020 12:40 AM, Alex Williamson wrote: On Wed, 25 Mar 2020 02:39:11 +0530 Kirti Wankhede wrote: Call VFIO_IOMMU_DIRTY_PAGES ioctl to start and stop dirty pages tracking for VFIO devices. Signed-off-by: Kirti Wankhede --- hw/vfio/migration.c | 36 ++

[PATCH v18 QEMU 10/18] vfio: Add load state functions to SaveVMHandlers

Sequence during _RESUMING device state: While data for this device is available, repeat below steps: a. read data_offset from where user application should write data. b. write data of data_size to migration region from data_offset. c. write data_size which indicates vendor driver that data is wri

[PATCH v18 QEMU 07/18] vfio: Add migration state change notifier

Added migration state change notifier to get notification on migration state change. These states are translated to VFIO device state and conveyed to vendor driver. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/migration.c | 30 ++ hw/vfio/

[PATCH v18 QEMU 15/18] vfio: Get migration capability flags for container

Added helper functions to get IOMMU info capability chain. Added function to get migration capability flags from that capability chain for IOMMU container. Similar change was proposed earlier: https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg03759.html Signed-off-by: Kirti Wankhede Cc: S

[PATCH v18 QEMU 11/18] iommu: add callback to get address limit IOMMU supports

Add optional method to get address limit IOMMU supports Signed-off-by: Kirti Wankhede --- hw/i386/intel_iommu.c | 9 + include/exec/memory.h | 18 ++ memory.c | 11 +++ 3 files changed, 38 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/i

[PATCH v18 QEMU 17/18] vfio: Make vfio-pci device migration capable

If device is not failover primary device call vfio_migration_probe() and vfio_migration_finalize() functions for vfio-pci device to enable migration for vfio PCI device which support migration. Removed vfio_pci_vmstate structure. Removed migration blocker from VFIO PCI device specific structure and

[PATCH v18 QEMU 09/18] vfio: Add save state functions to SaveVMHandlers

Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy functions. These functions handles pre-copy and stop-and-copy phase. In _SAVING|_RUNNING device state or pre-copy phase: - read pending_bytes. If pending_bytes > 0, go through below steps. - read data_offset - indicates k

Re: [PATCH v16 QEMU 08/16] vfio: Register SaveVMHandlers for VFIO device

On 3/26/2020 2:32 AM, Alex Williamson wrote: On Wed, 25 Mar 2020 02:39:06 +0530 Kirti Wankhede wrote: Define flags to be used as delimeter in migration file stream. Added .save_setup and .save_cleanup functions. Mapped & unmapped migration region from these functions at source during saving

Re: [PATCH v16 QEMU 04/16] vfio: Add save and load functions for VFIO PCI devices

On 3/26/2020 1:26 AM, Alex Williamson wrote: On Wed, 25 Mar 2020 02:39:02 +0530 Kirti Wankhede wrote: These functions save and restore PCI device specific data - config space of PCI device. Tested save and restore with MSI and MSIX type. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia

[PATCH v18 QEMU 18/18] qapi: Add VFIO devices migration stats in Migration stats

Added amount of bytes transferred to the target VM by all VFIO devices Signed-off-by: Kirti Wankhede --- hw/vfio/common.c| 20 hw/vfio/migration.c | 10 +- include/qemu/vfio-helpers.h | 3 +++ migration/migration.c | 12 monito

[PATCH v18 QEMU 08/18] vfio: Register SaveVMHandlers for VFIO device

Define flags to be used as delimeter in migration file stream. Added .save_setup and .save_cleanup functions. Mapped & unmapped migration region from these functions at source during saving or pre-copy phase. Set VFIO device state depending on VM's state. During live migration, VM is running when .

[PATCH v18 QEMU 06/18] vfio: Add VM state change handler to know state of VM

VM state change handler gets called on change in VM's state. This is used to set VFIO device state to _RUNNING. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/migration.c | 87 +++ hw/vfio/trace-events | 2 + include/hw

[PATCH v18 QEMU 02/18] vfio: Add function to unmap VFIO region

This function will be used for migration region. Migration region is mmaped when migration starts and will be unmapped when migration is complete. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Cornelia Huck --- hw/vfio/common.c | 20 hw/vfio/

[PATCH v18 QEMU 14/18] vfio: Add vfio_listener_log_sync to mark dirty pages

vfio_listener_log_sync gets list of dirty pages from container using VFIO_IOMMU_GET_DIRTY_BITMAP ioctl and mark those pages dirty when all devices are stopped and saving state. Return early for the RAM block section of mapped MMIO region. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- h

[PATCH v18 QEMU 05/18] vfio: Add migration region initialization and finalize function

- Migration functions are implemented for VFIO_DEVICE_TYPE_PCI device in this patch series. - VFIO device supports migration or not is decided based of migration region query. If migration region query is successful and migration region initialization is successful then migration is supported

[PATCH v18 QEMU 01/18] vfio: KABI for migration interface - Kernel header placeholder

Kernel header patches are being reviewed along with kernel side changes. This patch is only for place holder. Link to Kernel patch set: https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg03225.html This patch include all changes in vfio.h from above patch set Signed-off-by: Kirti Wankhede

[PATCH v18 QEMU 04/18] vfio: Add save and load functions for VFIO PCI devices

These functions save and restore PCI device specific data - config space of PCI device. Tested save and restore with MSI and MSIX type. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/pci.c | 163 ++ include/hw/vfio/vfio-com

[PATCH v18 QEMU 12/18] memory: Set DIRTY_MEMORY_MIGRATION when IOMMU is enabled

Signed-off-by: Kirti Wankhede --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory.c b/memory.c index 52f1a4cd37f0..5b868fe5eab3 100644 --- a/memory.c +++ b/memory.c @@ -1788,7 +1788,7 @@ bool memory_region_is_ram_device(MemoryRegion *mr) uint8_t memory_region_

Re: [PATCH v16 QEMU 09/16] vfio: Add save state functions to SaveVMHandlers

On 3/26/2020 3:33 AM, Alex Williamson wrote: On Wed, 25 Mar 2020 02:39:07 +0530 Kirti Wankhede wrote: Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy functions. These functions handles pre-copy and stop-and-copy phase. In _SAVING|_RUNNING device state or pre-co

[PATCH v18 QEMU 03/18] vfio: Add vfio_get_object callback to VFIODeviceOps

Hook vfio_get_object callback for PCI devices. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Suggested-by: Cornelia Huck Reviewed-by: Cornelia Huck --- hw/vfio/pci.c | 8 include/hw/vfio/vfio-common.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/vfio/

[PATCH v18 QEMU 00/18] Add migration support for VFIO devices

Hi, This Patch set adds migration support for VFIO devices in QEMU. This Patch set include patches as below: Patch 1: - Define KABI for VFIO device for migration support for device state and newly added ioctl definations to get dirty pages bitmap. This is a placeholder patch. Patch 2-4: - Fe

Re: [PATCH] ppc: Use hard-float in ppc fp_hlper as early as possible. This would increase the performance better than enable hard-float it in soft-float.c; Just using fadd fsub fmul fdiv as a simple b

пон, 4. мај 2020. у 21:31 је написао/ла: > > From: Yonggang Luo > > Just post as an idea to improve PPC fp performance. > With this idea, we have no need to adjust the helper orders. > > Signed-off-by: Yonggang Luo > --- > target/ppc/fpu_helper.c | 44 + >

Re: [PATCH] ppc: Use hard-float in ppc fp_hlper as early as possible...

On 5/4/20 12:29 PM, luoyongg...@gmail.com wrote: > Re: [PATCH] ppc: Use hard-float in ppc fp_hlper as early as possible. This > would increase the performance better than enable hard-float it in > soft-float.c; Just using fadd fsub fmul fdiv as a simple bench demo. With > this patch, performanc

[PULL 4/4] block/nbd-client: drop max_block restriction from discard

From: Vladimir Sementsov-Ogievskiy The NBD spec was updated (see nbd.git commit 9f30fedb) so that max_block doesn't relate to NBD_CMD_TRIM. So, drop the restriction. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200401150112.9557-3-vsement...@virtuozzo.com> Reviewed-by: Eric Blake

[PULL 0/4] NBD patches through 2020-05-04

Happy Star Wars Day! May the Fourth be with you as you apply this... The following changes since commit 5375af3cd7b8adcc10c18d8083b7be63976c9645: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-05-04 15:51:09 +0100) are available in the Git repository at: ht

[PULL 1/4] tools: Fix use of fcntl(F_SETFD) during socket activation

Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in 32-bit mode. However, we cannot use our wrapper qemu_set_cloexec(), because that wrapper intentionally abort()s on fa

[PULL 3/4] block/nbd-client: drop max_block restriction from block_status

From: Vladimir Sementsov-Ogievskiy The NBD spec was updated (see nbd.git commit 9f30fedb) so that max_block doesn't relate to NBD_CMD_BLOCK_STATUS. So, drop the restriction. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id: <20200401150112.9557-2-vsement...@virtuo

[PULL 2/4] iotests/041: Fix NBD socket path

From: Max Reitz We should put all UNIX socket files into the sock_dir, not test_dir. Reported-by: Elena Ufimtseva Signed-off-by: Max Reitz Message-Id: <20200424134626.78945-1-mre...@redhat.com> Reviewed-by: Eric Blake Fixes: a1da1878607a Reviewed-by: Stefan Hajnoczi Signed-off-by: Eric Blake

Publishing Python Packages

Hi! It keeps coming up in review or in bugs that it would be nice to ship certain python scripts or modules outside of QEMU for easy consumption as dev tooling, light debugging SDKs, or other various tasks. We keep avoiding the question as a diversion. Let's investigate this seriously, but let's

Re: [PATCH v5 for-5.0? 0/7] Tighten qemu-img rules on missing backing format

On 4/3/20 12:58 PM, Eric Blake wrote: v4 was here: https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg03775.html In v5: - fix 'qemu-img convert -B' to actually warn [Kashyap] - squash in followups - a couple more iotest improvements If we decide this is not 5.0 material, then patches 4 and

Re: [PATCH] ppc: Use hard-float in ppc fp_hlper as early as possible. This would increase the performance better than enable hard-float it in soft-float.c; Just using fadd fsub fmul fdiv as a simple b

Bench result; orignal: -> FLOPS 3.00 GCC version: 4.3.3 Ops count: 1073217024 Time spent: 27.768 sec MFLOPS: 38.65 FLOPS 3.00 GCC version: 4.3.3 Ops count: 1073217024 Time spent: 28.359 sec MFLOPS: 37.84 soft-hard-float: GCC version: 4.3.3 Ops count: 1073217024 Time spent: 14.874 sec MFLOPS: 72.

Re: [PATCH v2 2/6] block/nbd-client: drop max_block restriction from discard

On 4/21/20 4:56 PM, Eric Blake wrote: On 4/1/20 10:01 AM, Vladimir Sementsov-Ogievskiy wrote: NBD spec is updated, so that max_block doesn't relate to NBD_CMD_TRIM. So, drop the restriction. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   block/nbd.c | 2 +-   1 file changed, 1 insertion(+),

Re: [PATCH v1 2/4] .travis.yml: drop MacOSX

Daniel P. Berrangé writes: > On Fri, May 01, 2020 at 12:15:03PM +0100, Alex Bennée wrote: >> This keeps breaking on Travis so lets just fall back to the Cirrus CI >> builds which seem to be better maintained. Fix up the comments while >> we are doing this as we never had a windows build. > > FY

Re: [PATCH v1 4/4] .travis.yml: reduce the load on [ppc64] GCC check-tcg

Richard Henderson writes: > On 5/3/20 7:10 PM, David Gibson wrote: > - TEST_CMD="make check check-tcg V=1" > -- CONFIG="--disable-containers > --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user" > +- CONFIG="--disable-containers > --target-l

Re: [PATCH 2/3] io/task: Move 'qom/object.h' header to source

On 5/4/20 7:42 PM, Richard Henderson wrote: On 5/4/20 1:46 AM, Philippe Mathieu-Daudé wrote: We need "qom/object.h" to call object_ref()/object_unref(). This description doesn't seem to match +++ b/include/io/task.h @@ -21,8 +21,6 @@ #ifndef QIO_TASK_H #define QIO_TASK_H -#include "qo

Re: [PULL 00/29] virtio,acpi,pci,pc: backlog from pre-5.0

On Mon, 4 May 2020 at 15:29, Michael S. Tsirkin wrote: > > The following changes since commit 9af638cc1f665712522608c5d6b8c03d8fa67666: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200504' into staging (2020-05-04 > 13:37:17 +0100)

[PATCH] ppc: Use hard-float in ppc fp_hlper as early as possible. This would increase the performance better than enable hard-float it in soft-float.c; Just using fadd fsub fmul fdiv as a simple bench

From: Yonggang Luo Just post as an idea to improve PPC fp performance. With this idea, we have no need to adjust the helper orders. Signed-off-by: Yonggang Luo --- target/ppc/fpu_helper.c | 44 + 1 file changed, 44 insertions(+) diff --git a/target/ppc/

[PATCH v3 1/3] target/arm: Use tcg_gen_gvec_5_ptr for sve FMLA/FCMLA

Now that we can pass 7 parameters, do not encode register operands within simd_data. Reviewed-by: Alex Bennée Reviewed-by: Taylor Simpson Signed-off-by: Richard Henderson --- v2: Remove gen_helper_sve_fmla typedef (phil). --- target/arm/helper-sve.h| 45 +++ target/arm/sve_helper.

[PATCH v3 2/3] target/arm: Use tcg_gen_gvec_mov for clear_vec_high

The 8-byte store for the end a !is_q operation can be merged with the other stores. Use a no-op vector move to trigger the expand_clr portion of tcg_gen_gvec_mov. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 10 ++ 1 file changed, 2 inserti

[PATCH v3 0/3] target/arm: misc cleanups

Richard Henderson (3): target/arm: Use tcg_gen_gvec_5_ptr for sve FMLA/FCMLA target/arm: Use tcg_gen_gvec_mov for clear_vec_high target/arm: Use clear_vec_high more effectively target/arm/helper-sve.h| 45 +++ target/arm/sve_helper.c| 157 ++-

[PATCH v3 3/3] target/arm: Use clear_vec_high more effectively

Do not explicitly store zero to the NEON high part when we can pass !is_q to clear_vec_high. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 59 +++--- 1 file changed, 36 insertions(+), 23 deletions(-) diff --git a/targ

[PATCH] [ppc] Use hard-float as early as possible for PPC. And this would increase the performance better than enable it in soft-float.c; Just using fadd fsub fmul fdiv as a demo. With this patch. Per

From: Yonggang Luo Just post as an idea to improve PPC fp performance. Through this path, we have no need to revise the helper orders. Signed-off-by: Yonggang Luo --- target/ppc/fpu_helper.c | 44 + 1 file changed, 44 insertions(+) diff --git a/target/p

Re: An first try to improve PPC float simulation, not even compiled. Just ask question.

On Mon, 4 May 2020, Richard Henderson wrote: On 5/4/20 11:30 AM, BALATON Zoltan wrote: On Mon, 4 May 2020, Richard Henderson wrote: On 5/3/20 5:41 PM, 罗勇刚(Yonggang Luo) wrote: On Mon, May 4, 2020 at 7:40 AM BALATON Zoltan mailto:bala...@eik.bme.hu>> wrote:     Hello,     On Mon, 4 May 2020,

Re: An first try to improve PPC float simulation, not even compiled. Just ask question.

On 5/4/20 11:30 AM, BALATON Zoltan wrote: > On Mon, 4 May 2020, Richard Henderson wrote: >> On 5/3/20 5:41 PM, 罗勇刚(Yonggang Luo) wrote: >>> On Mon, May 4, 2020 at 7:40 AM BALATON Zoltan >> > wrote: >>> >>>     Hello, >>> >>>     On Mon, 4 May 2020, 罗勇刚(Yonggang Luo) wrote

Re: [PATCH 2/2] hw/display/edid: Add missing 'qdev-properties.h' header

On 5/4/20 1:20 AM, Philippe Mathieu-Daudé wrote: > To use the DEFINE_EDID_PROPERTIES() macro we need the > definitions from "hw/qdev-properties.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/display/edid.h | 1 + > 1 file changed, 1 insertion(+) Does this not currently build?

  1   2   3   4   5   6   >