06.04.2020 20:14, Kevin Wolf wrote:
Waiting in blk_wait_while_drained() while blk->in_flight is increased
for the current request is wrong because it will cause the drain
operation to deadlock.
This patch makes sure that blk_wait_while_drained() is called with
blk->in_flight increased exactly on
On 4/6/20 7:47 PM, Philippe Mathieu-Daudé wrote:
> Patch created mechanically by running:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h \
> --include-headers --keep-comments --in-place \
> --sp-file \
> scripts/coccinelle/use-error_abort-in-instance_init.cocci
>
> S
On 4/7/20 12:55 AM, Cameron Esfahani wrote:
> NRF51_GPIO_REG_CNF_END doesn't actually refer to the start of the last
> valid CNF register: it's referring to the last byte of the last valid
> CNF register.
>
> This hasn't been a problem up to now, as current implementation in
> memory.c turns an un
On 4/6/20 7:46 PM, Philippe Mathieu-Daudé wrote:
> In the previous commit we noticed we don't need two different
> Error*, drop the one less used.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Cédric Le Goater
It seems that the 'return' are badly aligned ?
Thanks,
C.
> ---
> hw/
On 4/6/20 7:47 PM, Philippe Mathieu-Daudé wrote:
> Patch created mechanically by running:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h --include-headers \
> --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \
> --keep-comments --smpl-spacing --in-place --d
On 4/6/20 7:46 PM, Philippe Mathieu-Daudé wrote:
> Coccinelle reported:
>
> $ spatch ... --timeout 60 --sp-file \
> scripts/coccinelle/simplify-init-realize-error_propagate.cocci
> HANDLING: ./hw/arm/aspeed_soc.c
> >>> possible moves from aspeed_soc_init() to aspeed_soc_realize() in
> .
On 4/6/20 7:46 PM, Philippe Mathieu-Daudé wrote:
> Coccinelle reported:
>
> $ spatch ... --timeout 60 --sp-file \
> scripts/coccinelle/simplify-init-realize-error_propagate.cocci
> HANDLING: ./hw/arm/aspeed_ast2600.c
> >>> possible moves from aspeed_soc_ast2600_init() to
> aspeed_soc_as
06.04.2020 20:14, Kevin Wolf wrote:
External callers of blk_co_*() don't currently increase the
BlockBackend.in_flight counter, but calls from blk_aio_*() do, so there
is an inconsistency whether the counter has been increased or not.
This patch moves the actual operations to static functions th
On Mon, 6 Apr 2020 17:37:18 -0400
Eric Farman wrote:
> On 4/6/20 12:22 PM, Cornelia Huck wrote:
> > On Thu, 6 Feb 2020 22:45:09 +0100
> > Eric Farman wrote:
> >
> >> From: Farhan Ali
> >>
> >> The CRW irq will be used by vfio-ccw to notify the userspace
> >> about any CRWs the userspace nee
On Mon, 6 Apr 2020 14:21:17 -0400
Eric Farman wrote:
> On 4/1/20 4:52 AM, Cornelia Huck wrote:
> > On Wed, 25 Mar 2020 03:24:28 +0100
> > Halil Pasic wrote:
> >
> >> On Tue, 24 Mar 2020 18:04:30 +0100
> >> Cornelia Huck wrote:
> >>
> >>> On Thu, 6 Feb 2020 22:45:03 +0100
> >>> Eric Farman
I wouldn't mind either.
Andrey
From: Alberto Garcia
Sent: Monday, April 6, 2020 7:08 PM
To: qemu-devel@nongnu.org
Cc: qemu-bl...@nongnu.org ; Andrey Shinkevich
; Max Reitz ; Kevin Wolf
; Vladimir Sementsov-Ogievskiy ;
Pavel Butsykin
Subject: Re: [PATCH v2] q
Add the VMBus infrastructure -- bus, devices, root bridge, vmbus state
machine, vmbus channel interactions, etc.
VMBus is a collection of technologies. At its lowest layer, it's a message
passing and signaling mechanism, allowing efficient passing of messages to and
from guest VMs. A layer highe
Guest OS uses ACPI to discover VMBus presence. Add a corresponding
entry to DSDT in case VMBus has been enabled.
Experimentally Windows guests were found to require this entry to
include two IRQ resources. They seem to never be used but they still
have to be there.
Make IRQ numbers user-configur
As vmbus-bridge is derived from sysbus device, it has to be whitelisted
to be allowed to be created with -device.
Signed-off-by: Roman Kagan
Signed-off-by: Maciej S. Szmigiero
Signed-off-by: Jon Doron
---
hw/i386/pc_piix.c | 2 ++
hw/i386/pc_q35.c | 2 ++
2 files changed, 4 insertions(+)
dif
SynIc can be enabled regardless of the SControl mechanisim which can
register a GSI for a given SintRoute.
This behaviour can achived by setting enabling SIMP and then the guest
will poll on the message slot.
Once there is another message pending the host will set the message slot
with the pendin
This can be allow to include controller-specific data while
saving/loading in-flight scsi requests of the vmbus scsi controller.
Signed-off-by: Roman Kagan
Signed-off-by: Maciej S. Szmigiero
Signed-off-by: Jon Doron
---
hw/hyperv/vmbus.c | 99 +++
in
Add a header with data structures and constants used in Hyper-V VMBus
hypervisor <-> guest interactions.
Based on the respective stuff from Linux kernel.
Signed-off-by: Roman Kagan
Signed-off-by: Maciej S. Szmigiero
Signed-off-by: Jon Doron
---
include/hw/hyperv/vmbus-proto.h | 222 ++
Signed-off-by: Jon Doron
---
hw/hyperv/hyperv.c | 8
include/hw/hyperv/hyperv.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c
index 8ca3706f5b..ddf4f32c60 100644
--- a/hw/hyperv/hyperv.c
+++ b/hw/hyperv/hyperv.c
@@ -37,6 +37,13 @@ t
This is a rebase of the old patchset from Roman for HyperV VMBus
implementation.
How to use:
-device vmbus-bridge
Later on new paravirtualized devices can be implemented on top of it
(Network/SCSI/etc.)
VMBus is a collection of technologies. At its lowest layer, it's a message
passing and signa
06.04.2020 20:14, Kevin Wolf wrote:
Move all variants of the flush/pdiscard functions to a single place and
put the blk_co_*() version first because it is called by all other
variants (and will become static in the next patch).
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sementsov-Ogievski
Anthony PERARD writes:
> On Mon, Apr 06, 2020 at 06:50:41PM +0200, Philippe Mathieu-Daudé wrote:
>> On 4/6/20 6:42 PM, Anthony PERARD wrote:
>> > Since 7f5d9b206d1e ("object-add: don't create return value if
>> > failed"), qmp_object_add() don't write any value in 'ret_data', thus
>> > has random
Damien Hedde writes:
> Add the documentation about the clock inputs and outputs in devices.
>
> This is based on the original work of Frederic Konrad.
>
> Signed-off-by: Damien Hedde
> Reviewed-by: Alistair Francis
> Reviewed-by: Edgar E. Iglesias
> ---
> v9:
> + fix a few typos (Alistair)
>
On 4/6/20 9:04 PM, Max Filippov wrote:
> On Mon, Apr 6, 2020 at 8:09 PM Richard Henderson
> wrote:
>>
>> Rather than dynamically allocate, and risk failing to free
>> when we longjmp out of the translator, allocate the maximum
>> buffer size from any of the supported cpus, which is 8:
>
> There's
From: Alexey Kardashevskiy
This is a single regression fix for for 5.0:
Greg Kurz (1):
slof: Only close stdout for virtio-serial devices
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: David Gibson
---
pc-bios/README | 2 +-
pc-bios/slof.bin | Bin 965008 -> 965112 bytes
roms/SL
From: Cédric Le Goater
Commit e2392d4395dd ("ppc/pnv: Create BMC devices at machine init")
introduced default BMC devices which can be a problem when the same
devices are defined on the command line with :
-device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10
QEMU fails with :
q
From: Nicholas Piggin
Add some messages which explain problems and guest misbehaviour that
may be difficult to diagnose in rare cases of machine checks.
Signed-off-by: Nicholas Piggin
Message-Id: <20200325142906.221248-4-npig...@gmail.com>
Reviewed-by: Greg Kurz
Signed-off-by: David Gibson
--
From: Nicholas Piggin
Try to be tolerant of FWNMI delivery errors if the machine check had been
recovered by the host.
Signed-off-by: Nicholas Piggin
Message-Id: <20200325142906.221248-5-npig...@gmail.com>
Reviewed-by: Greg Kurz
[dwg: Updated comment at Greg's suggestion]
Signed-off-by: David
From: Peter Maydell
In dcr_write_pcie() we take the iothread lock around a call to
pcie_host_mmcfg_udpate(). This is an incorrect attempt to deal with
the bug fixed in commit 235352ee6e73d7716, where we were not taking
the iothread lock before calling device dcr read/write functions.
(It's not s
From: Nicholas Piggin
Some of the conditions are not as clearly documented as they could be.
Also the non-FWNMI case does not need a large comment.
Reviewed-by: Greg Kurz
Signed-off-by: Nicholas Piggin
Message-Id: <20200325142906.221248-3-npig...@gmail.com>
Signed-off-by: David Gibson
---
hw
From: Nicholas Piggin
The KVM FWNMI capability should be enabled with the "ibm,nmi-register"
rtas call. Although MCEs from KVM will be delivered as architected
interrupts to the guest before "ibm,nmi-register" is called, KVM has
different behaviour depending on whether the guest has enabled FWNMI
From: Alexey Kardashevskiy
Coverity detected an issue (CID 1421903) with potential call of clz64(0)
which returns 64 which make it do "<<" with a negative number.
This checks the mask and avoids undefined behaviour.
In practice pgsizes and memory_region_iommu_get_min_page_size() always
have som
The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200406'
into staging (2020-04-06 12:36:45 +0100)
are available in the Git repository at:
git://github.com/dgibson/qemu.git tags/p
From: Peter Maydell
If qemu_find_file() doesn't find the BIOS it returns NULL; we were
passing that unchecked through to load_elf(), which assumes a non-NULL
pointer and may misbehave. In practice it fails with a weird message:
$ qemu-system-ppc -M ppce500 -display none -kernel nonesuch
Bad
For various technical reasons we can't currently allow unplug a PCI to PCI
bridge on the pseries machine. spapr_pci_unplug_request() correctly
generates an error message if that's attempted.
But.. if the given errp is not error_abort or error_fatal, it doesn't
actually stop trying to unplug the b
On 2020/3/25 5:09, Kirti Wankhede wrote:
> These functions save and restore PCI device specific data - config
> space of PCI device.
> Tested save and restore with MSI and MSIX type.
>
> Signed-off-by: Kirti Wankhede
> Reviewed-by: Neo Jia
> ---
> hw/vfio/pci.c | 163
> +
On Mon, Apr 6, 2020 at 9:04 PM Max Filippov wrote:
> diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c
> index 376a61f3397c..278415ae0e06 100644
> --- a/target/xtensa/helper.c
> +++ b/target/xtensa/helper.c
> @@ -96,6 +96,7 @@ static void init_libisa(XtensaConfig *config)
>
> confi
On Mon, Apr 6, 2020 at 8:09 PM Richard Henderson
wrote:
>
> Rather than dynamically allocate, and risk failing to free
> when we longjmp out of the translator, allocate the maximum
> buffer size from any of the supported cpus, which is 8:
There's macro MAX_INSN_LENGTH that defines maximal support
On Fri, Apr 03, 2020 at 08:53:12PM +0800, Peter Maydell wrote:
> On Fri, 3 Apr 2020 at 09:13, Yan Zhao wrote:
> >
> > patch 1 modifies handler of ram device memory regions to drop guest writes
> > to read-only ram device memory regions
> >
> > patch 2 modifies handler of non-mmap'd read-only vfio
The padding that was added in 95cda4c44ee was added to a union,
and so it had no effect. This fixes misalignment errors detected
by clang sanitizers for ppc64 and ppc64le.
In addition, only ppc64 allocates space for VSX registers, so do
not save them for ppc32. The kernel only has references to
Rather than dynamically allocate, and risk failing to free
when we longjmp out of the translator, allocate the maximum
buffer size from any of the supported cpus, which is 8:
core-dc232b/xtensa-modules.inc.c: 3 /* insn_size */, 0,
core-dc233c/xtensa-modules.inc.c: 3 /* insn_size */, 0,
core-de21
Since I posted this bug report, I have done a little more research and
this specific part of this command is actually quite obsolete. It use
to be documented (MMC v1.2 Draft), but later versions have actually
removed this part of the command, even stating "obsolete" in some of the
documentation.
BTW, it does make the guest unusable ... can't even enter a password (if
I could get that far, having issues even running setup).
Thanks!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1871267
Title:
Public bug reported:
Hi,
I am finding this issue with v4.2.0, or the latest master - on a Windows
host, with macOS guest. It happens using gtk (SPICE?) or VNC. When I get
to a place to enter a keystroke, I quite reliably get multiple of the
same key (i.e. press A, get ).
Thinking there may b
Public bug reported:
Description of problem:
Currently, when a iOS device is redirected to a macOS VM, it falls into a
reset-not-found loop.
Version-Release number of selected component (if applicable):
latest
How reproducible:
100%
Steps to Reproduce:
Connect an iOS device to Ubuntu 18.04.2 LT
On 4/7/20 1:54 AM, Philippe Mathieu-Daudé wrote:
Using the BC1ANY4F instruction with a 24Kf core (MIPS32R2
& ASE_MIPS16) we get:
$ echo -ne '\x03\x20\xf8\x09' > cop1x.bin
$ qemu-system-mipsel -bios cop1x.bin
unknown branch 0x13000
Aborted (core dumped)
(gdb) bt
#0 0x7
Using the BC1ANY4F instruction with a 24Kf core (MIPS32R2
& ASE_MIPS16) we get:
$ echo -ne '\x03\x20\xf8\x09' > cop1x.bin
$ qemu-system-mipsel -bios cop1x.bin
unknown branch 0x13000
Aborted (core dumped)
(gdb) bt
#0 0x7fe2d38b1e35 in raise () at /lib64/libc.so.6
#1 0x7
Public bug reported:
Hi,
I'm running the latest (master) of QEMU, though the version doesn't seem
to matter - I also checked back to v4.2.0, exactly the same issue. And
this isn't about the VM (guest), if I even just try to run,
> "c:\Program Files\qemu\qemu-system-x86_64.exe" -accel hax
Basica
Hi Brian,
You try to execute a CP1 instruction in a delay slot,
which triggers a Reserved Instruction exception.
Per the ISA the processor operation is UNPREDICTABLE in such case.
What is the behavior on real hardware?
An assertion() seems appropriate.
Your compiler might be buggy, or you are no
NRF51_GPIO_REG_CNF_END doesn't actually refer to the start of the last
valid CNF register: it's referring to the last byte of the last valid
CNF register.
This hasn't been a problem up to now, as current implementation in
memory.c turns an unaligned 4-byte read from 0x77f to a single byte read
and
I had a look at this failing test case after running applying Cedric's patch
(https://github.com/legoater/qemu/commit/d57ac950c4be47a2bafd6c6a96dec2922c2ecd65).
It looks like this is just a bug in the test case. The test case is attempting
to verify that the CNF registers are programmed correct
On 2/17/20 10:56 AM, Max Reitz wrote:
Hi,
AFAIU, external data files with data_file_raw=on are supposed to return
the same data as the qcow2 file when read. But we still use the qcow2
metadata structures (which are by default initialized to “everything
unallocated”), even though we never ensure
On 4/6/20 5:41 PM, Philippe Mathieu-Daudé wrote:
> Some GitHub users try to open pull requests against the GitHub
> mirror. Unfortunate these get ignored until eventually someone
> notices and closes the request.
>
> Enable the 'Repo Lockdown' [*] 3rd party bot which can autorespond
> to pull r
Some GitHub users try to open pull requests against the GitHub
mirror. Unfortunate these get ignored until eventually someone
notices and closes the request.
Enable the 'Repo Lockdown' [*] 3rd party bot which can autorespond
to pull requests with a friendly comment, close the request, and
then loc
On 4/6/20 12:22 PM, Cornelia Huck wrote:
> On Thu, 6 Feb 2020 22:45:09 +0100
> Eric Farman wrote:
>
>> From: Farhan Ali
>>
>> The CRW irq will be used by vfio-ccw to notify the userspace
>> about any CRWs the userspace needs to handle. Let's add support
>> for it.
>>
>> Signed-off-by: Farhan
On 4/3/20 9:11 PM, Alex Bennée wrote:
From: Richard Henderson
Without -Werror, the probe may succeed, but then compilation fails
later when -Werror is added for other reasons. Shows up on windows,
where the compiler complains about -fPIC.
Signed-off-by: Richard Henderson
Signed-off-by: Alex
I found the exact same bug. Tested on several hosts and qemu releases.
The newest one I tested was on FreeBSD 12.1 host and qemu-4.1.1_1 built
from ports.
Instructions:
4000d0: 0320f809jalrt9
4000d4: 454545450x45454545 # bc1any4t $fcc1,0x800101f8
I was
In some corner cases (that never happen during normal operation but a
malicious guest could program wrong values) pixman functions were
called with parameters that result in a crash. Fix this and add more
checks to disallow such cases.
Reported-by: Ziming Zhang
Signed-off-by: BALATON Zoltan
---
Patchew URL: https://patchew.org/QEMU/20200406174743.16956-1-f4...@amsat.org/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/
Patchew URL: https://patchew.org/QEMU/20200406174743.16956-1-f4...@amsat.org/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export A
On 4/2/20 8:48 AM, Kevin Wolf wrote:
> Am 01.04.2020 um 10:15 hat Stefan Reiter geschrieben:
>> Contains three seperate but related patches cleaning up and fixing some
>> issues regarding aio_context_acquire/aio_context_release for jobs. Mostly
>> affects blockjobs running for devices that have
On 4/6/20 12:47 PM, Philippe Mathieu-Daudé wrote:
In some places in we put an error into a local Error*, but forget
to check for failure and pass it back to the caller.
Add a Coccinelle patch to catch automatically add the missing code.
s/catch/catch and/
Inspired-by: Peter Maydell
Signed-o
On 4/6/20 2:13 PM, Paolo Bonzini wrote:
Deprecate atomic_mb_read and atomic_mb_set; it is not really possible to
use them correctly because they do not interoperate with sequentially-consistent
RMW operations.
Signed-off-by: Paolo Bonzini
---
docs/devel/atomics.rst | 290 -
On 4/6/20 2:13 PM, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
docs/devel/atomics.rst | 447 +
docs/devel/atomics.txt | 403 -
docs/devel/index.rst | 1 +
3 files changed, 448 insertions(+), 403 deleti
On 4/3/20 10:22 AM, Daniel P. Berrangé wrote:
> QEMU, like libvirt, has a github.com project which contains automated
> read-only mirrors of QEMU repositories.
>
> https://github.com/qemu/
>
> An unfortunate side effect of this is that some users will try to open
> pull requests against thes
On Sat, Apr 04, 2020 at 12:00:12PM +, Liu, Yi L wrote:
> Hi Peter,
>
> > From: Peter Xu
> > Sent: Saturday, April 4, 2020 12:11 AM
> > To: Liu, Yi L
> > Subject: Re: [PATCH v2 16/22] intel_iommu: replay pasid binds after context
> > cache
> > invalidation
> >
> > On Fri, Apr 03, 2020 at 03
Hi, if you can quote the relevant spec, would you like to include that
in a commit message and send a patch?
Also, does this result in a bug anywhere visible that we can test
against?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
h
On 4/6/20 7:47 PM, Philippe Mathieu-Daudé wrote:
Running the coccinelle script produced:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
--keep-comments --smpl-spacing --dir .
HANDLING:
When using C11 atomics, non-seqcst reads and writes do not participate
in the total order of seqcst operations. In util/async.c and util/aio-posix.c,
in particular, the pattern that we use
write ctx->notify_me write bh->scheduled
read bh->scheduled
Signed-off-by: Paolo Bonzini
---
docs/devel/rcu.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/rcu.txt b/docs/devel/rcu.txt
index d83fed2f79..0ce15ba198 100644
--- a/docs/devel/rcu.txt
+++ b/docs/devel/rcu.txt
@@ -132,7 +132,7 @@ The core RCU API is small:
Deprecate atomic_mb_read and atomic_mb_set; it is not really possible to
use them correctly because they do not interoperate with sequentially-consistent
RMW operations.
Signed-off-by: Paolo Bonzini
---
docs/devel/atomics.rst | 290 -
1 file changed, 114 i
Patch 4 fixes qemu-img and qemu-io hangs on weakly-ordered architectures.
Patch 1-3 are related docs fixes and improvements.
This is RFC because it relies on the iothread being locked during aio_poll
on the main AioContext. If I add assertions for this however I see a
failure for test 267, so I a
Signed-off-by: Paolo Bonzini
---
docs/devel/atomics.rst | 447 +
docs/devel/atomics.txt | 403 -
docs/devel/index.rst | 1 +
3 files changed, 448 insertions(+), 403 deletions(-)
create mode 100644 docs/devel/atomics.
On Mon, Apr 6, 2020 at 3:21 PM Alex Bennée wrote:
>
>
> Willian Rampazzo writes:
>
> > On Mon, Apr 6, 2020 at 12:39 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> On 4/6/20 5:31 PM, Alex Bennée wrote:
> >> >
> >> > Philippe Mathieu-Daudé writes:
> >> >
> >> >> Signed-off-by: Philippe Mathieu-Da
Richard Henderson writes:
> When %gs cannot be used, we use register offset addressing.
> This path is almost never used, so it was clearly not tested.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
> ---
> tcg/i386/tcg-target.inc.c | 2 +-
> 1 file c
On 4/1/20 4:52 AM, Cornelia Huck wrote:
> On Wed, 25 Mar 2020 03:24:28 +0100
> Halil Pasic wrote:
>
>> On Tue, 24 Mar 2020 18:04:30 +0100
>> Cornelia Huck wrote:
>>
>>> On Thu, 6 Feb 2020 22:45:03 +0100
>>> Eric Farman wrote:
>>>
From: Farhan Ali
EIO is returned by vfio-c
On Mon, Apr 6, 2020 at 12:39 PM Philippe Mathieu-Daudé
wrote:
>
> On 4/6/20 5:31 PM, Alex Bennée wrote:
> >
> > Philippe Mathieu-Daudé writes:
> >
> >> Signed-off-by: Philippe Mathieu-Daudé
> >> ---
> >> .travis.yml | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --g
Willian Rampazzo writes:
> On Mon, Apr 6, 2020 at 12:39 PM Philippe Mathieu-Daudé
> wrote:
>>
>> On 4/6/20 5:31 PM, Alex Bennée wrote:
>> >
>> > Philippe Mathieu-Daudé writes:
>> >
>> >> Signed-off-by: Philippe Mathieu-Daudé
>> >> ---
>> >> .travis.yml | 2 +-
>> >> 1 file changed, 1 inse
In some places in we put an error into a local Error*, but
forget to use it. Add a Coccinelle patch to find such cases
and report them.
Inspired-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
---
.../find-missing-error_propagate.cocci| 53 +++
MAINTAINERS
Running the coccinelle script produced:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
--keep-comments --smpl-spacing --dir .
HANDLING: ./hw/mips/boston.c
[[manual check required: error_prop
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci \
--keep-comments --smpl-spacing --in-place --dir hw
Unfortunately the cocci script doesn't proper
On 4/6/20 12:46 PM, Philippe Mathieu-Daudé wrote:
Coccinelle reported:
$ spatch ... --timeout 60 --sp-file \
scripts/coccinelle/simplify-init-realize-error_propagate.cocci
HANDLING: ./hw/arm/allwinner-a10.c
>>> possible moves from aw_a10_init() to aw_a10_realize() in
./hw/arm/allw
On 4/6/20 7:47 PM, Philippe Mathieu-Daudé wrote:
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci
\
sigh I forgot to update this, the scrip has
The instance_init() calls are not suppose to fail. Add a
Coccinelle script to use &error_abort instead of ignoring
errors by using a NULL Error*.
Signed-off-by: Philippe Mathieu-Daudé
---
.../use-error_abort-in-instance_init.cocci| 52 +++
MAINTAINERS
Running the coccinelle script:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci \
--keep-comments --smpl-spacing --dir hw
inserted a block after object_property_set_uint("apic-id") which
Willian Rampazzo writes:
> On Mon, Apr 6, 2020 at 12:41 PM Alex Bennée wrote:
>>
>>
>> Philippe Mathieu-Daudé writes:
>>
>> > Signed-off-by: Philippe Mathieu-Daudé
>> > ---
>> > tests/Makefile.include | 7 +++
>> > 1 file changed, 7 insertions(+)
>> >
>> > diff --git a/tests/Makefile.in
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci \
--keep-comments --smpl-spacing --dir hw
Then review showed this file has a 'xilinx_axidma_realiz
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h \
--include-headers --keep-comments --in-place \
--sp-file \
scripts/coccinelle/use-error_abort-in-instance_init.cocci
Signed-off-by: Philippe Mathieu-Daudé
---
backends/cryptodev-vhost
On 4/6/20 7:47 PM, Philippe Mathieu-Daudé wrote:
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h \
--include-headers --keep-comments --in-place \
--sp-file \
scripts/coccinelle/use-error_abort-in-instance_init.cocci
Signed-off-b
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \
--keep-comments --smpl-spacing --in-place --dir hw
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/o
Running the coccinelle script produced:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
--keep-comments --smpl-spacing --dir .
HANDLING: ./qga/commands-win32.c
[[manual check required: error_
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \
--keep-comments --smpl-spacing --in-place --dir hw
Signed-off-by: Philippe Mathieu-Daudé
---
hw/microbl
Running the coccinelle script produced:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
--keep-comments --smpl-spacing --dir .
HANDLING: ./migration/colo.c
[[manual check required: error_prop
On Mon, Apr 6, 2020 at 12:41 PM Alex Bennée wrote:
>
>
> Philippe Mathieu-Daudé writes:
>
> > Signed-off-by: Philippe Mathieu-Daudé
> > ---
> > tests/Makefile.include | 7 +++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/tests/Makefile.include b/tests/Makefile.include
> > index
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \
--keep-comments --smpl-spacing --in-place --dir hw
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/arm
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci \
--keep-comments --smpl-spacing --dir hw
Reviewed-by: David Gibson
Acked-by: David Gibson
Revie
Hi
On Mon, Apr 6, 2020 at 7:48 PM Philippe Mathieu-Daudé wrote:
>
> Fixes the following coccinelle warnings:
>
> $ spatch --sp-file --verbose-parsing ... \
> scripts/coccinelle/remove_local_err.cocci
> ...
> SUSPICIOUS: a \ character appears outside of a #define at
> ./target/ppc/tr
06.04.2020 16:32, Eric Blake wrote:
On 4/6/20 3:50 AM, Vladimir Sementsov-Ogievskiy wrote:
03.04.2020 21:19, Eric Blake wrote:
Although we already covered the need for padding bytes with our
changes in commit 3ae3fcfa, commit 66fcbca5 just added one byte and
relied on the rest of the text for i
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \
--keep-comments --smpl-spacing --in-place --dir hw
Signed-off-by: Philippe Mathieu-Daudé
---
hw/riscv/s
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci \
--keep-comments --smpl-spacing --dir hw
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/milkym
Patch created mechanically by running:
$ spatch \
--macro-file scripts/cocci-macro-file.h --include-headers \
--sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \
--keep-comments --smpl-spacing --in-place --dir hw
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/msf
1 - 100 of 301 matches
Mail list logo
