[Qemu-devel PATCH v2 1/2] hw/net: Add Smartfusion2 emac block

2020-04-04 Thread sundeep . lkml
From: Subbaraya Sundeep Modelled Ethernet MAC of Smartfusion2 SoC. Micrel KSZ8051 PHY is present on Emcraft's SOM kit hence same PHY is emulated. Signed-off-by: Subbaraya Sundeep --- MAINTAINERS| 2 + hw/net/Makefile.objs | 1 + hw/net/msf2-emac.c | 556 ++

[Qemu-devel PATCH v2 2/2] msf2: Add EMAC block to SmartFusion2 SoC

2020-04-04 Thread sundeep . lkml
From: Subbaraya Sundeep With SmartFusion2 Ethernet MAC model in place this patch adds the same to SoC. Signed-off-by: Subbaraya Sundeep --- hw/arm/msf2-soc.c | 21 - include/hw/arm/msf2-soc.h | 3 +++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/h

[Qemu-devel PATCH v2 0/2] Add SmartFusion2 EMAC block

2020-04-04 Thread sundeep . lkml
From: Subbaraya Sundeep This patch set emulates Ethernet MAC block present in Microsemi SmartFusion2 SoC. v2: No changes. Fixed Signed-off mail id in patch 2/2 Testing: 1. Download u-boot.bin, uImage and msf2-devkit.dtb from https://github.com/Subbaraya-Sundeep/qemu-test-binaries.git 2.

[Qemu-devel PATCH 2/2] msf2: Add EMAC block to SmartFusion2 SoC

2020-04-04 Thread sundeep . lkml
From: Subbaraya Sundeep With SmartFusion2 Ethernet MAC model in place this patch adds the same to SoC. Signed-off-by: Subbaraya Sundeep --- hw/arm/msf2-soc.c | 21 - include/hw/arm/msf2-soc.h | 3 +++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/h

[Qemu-devel PATCH 1/2] hw/net: Add Smartfusion2 emac block

2020-04-04 Thread sundeep . lkml
From: Subbaraya Sundeep Modelled Ethernet MAC of Smartfusion2 SoC. Micrel KSZ8051 PHY is present on Emcraft's SOM kit hence same PHY is emulated. Signed-off-by: Subbaraya Sundeep --- MAINTAINERS| 2 + hw/net/Makefile.objs | 1 + hw/net/msf2-emac.c | 556 ++

[Qemu-devel PATCH 0/2] Add SmartFusion2 EMAC block

2020-04-04 Thread sundeep . lkml
From: Subbaraya Sundeep This patch set emulates Ethernet MAC block present in Microsemi SmartFusion2 SoC. Testing: 1. Download u-boot.bin, uImage and msf2-devkit.dtb from https://github.com/Subbaraya-Sundeep/qemu-test-binaries.git 2. Copy uImage and msf2-devkit.dtb to suitable Qemu tftp dire

[Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib"

2020-04-04 Thread Chad Kennedy
I am still running into this issue when compiling QEMU on Windows using MSYS2. I can manually apply the fix per the Capstone commit above and compile just fine. For moving forward, how should this be handled in the codebase to get the MSYS2 build cleanly working? I imagine wholesale pulling the la

Re: [PATCH] ppc/pnv: Create BMC devices only when defaults are enabled

2020-04-04 Thread Nathan Chancellor
Hi Cédric, On Sat, Apr 04, 2020 at 05:36:55PM +0200, Cédric Le Goater wrote: > Commit e2392d4395dd ("ppc/pnv: Create BMC devices at machine init") > introduced default BMC devices which can be a problem when the same > devices are defined on the command line with : > > -device ipmi-bmc-sim,id=b

Re: [PATCH v2] ppc/pnv: Create BMC devices at machine init

2020-04-04 Thread Cédric Le Goater
Hello Nathan, Some comments on the command line. > $ timeout 3m unbuffer qemu-system-ppc64 -device ipmi-bmc-sim,id=bmc0 \ > -device isa-ipmi-bt,bmc=bmc0,irq=10 \ > -L images/ppc64le/ \ >

[PATCH] ppc/pnv: Create BMC devices only when defaults are enabled

2020-04-04 Thread Cédric Le Goater
Commit e2392d4395dd ("ppc/pnv: Create BMC devices at machine init") introduced default BMC devices which can be a problem when the same devices are defined on the command line with : -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10 QEMU fails with : qemu-system-ppc64: error c

[PATCH] qom/object: Fix object_child_foreach_recursive() return value

2020-04-04 Thread Cédric Le Goater
When recursing, the return value of do_object_child_foreach() is not taken into account. Cc: Peter Crosthwaite Fixes: d714b8de7747 ("qom: Add recursive version of object_child_for_each") Signed-off-by: Cédric Le Goater --- qom/object.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH v1 0/5] dma/xlnx-zdma: Bug fixes

2020-04-04 Thread Edgar E. Iglesias
On Fri, Apr 03, 2020 at 07:53:24PM +0100, Peter Maydell wrote: > On Thu, 2 Apr 2020 at 14:46, Edgar E. Iglesias > wrote: > > > > From: "Edgar E. Iglesias" > > > > Hi, > > > > This series fixes a couple of bugs we've ran into with some > > proprietary test code and drivers using the Xilinx zDMA.

[PATCH v1 2/2] dma/xlnx-zdma: Fix descriptor loading (REG) wrt endianness

2020-04-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Fix descriptor loading from registers wrt host endianness. Reported-by: Peter Maydell Signed-off-by: Edgar E. Iglesias --- hw/dma/xlnx-zdma.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c i

[PATCH v1 0/2] dma/xlnx-zdma: Fix descriptor loading wrt host endianness

2020-04-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, This fixes the endinannes related bugs with descriptor loading that Peter pointed out. Cheers, Edgar Edgar E. Iglesias (2): dma/xlnx-zdma: Fix descriptor loading (MEM) wrt endianness dma/xlnx-zdma: Fix descriptor loading (REG) wrt endianness hw/dma/xlnx-zdma

[PULL 1/3] scripts/coccinelle: add error-use-after-free.cocci

2020-04-04 Thread Markus Armbruster
From: Vladimir Sementsov-Ogievskiy Add script to find and fix trivial use-after-free of Error objects. How to use: spatch --sp-file scripts/coccinelle/error-use-after-free.cocci \ --macro-file scripts/cocci-macro-file.h --in-place \ --no-show-diff ( FILES... | --use-gitgrep . ) Signed-off-by:

[PATCH v1 1/2] dma/xlnx-zdma: Fix descriptor loading (MEM) wrt endianness

2020-04-04 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Fix descriptor loading from memory wrt host endianness. Reported-by: Peter Maydell Signed-off-by: Edgar E. Iglesias --- hw/dma/xlnx-zdma.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c index 1c

[PULL 0/3] Error reporting patches for 2020-04-04

2020-04-04 Thread Markus Armbruster
The following changes since commit 146aa0f104bb3bf88e43c4082a0bfc4bbda4fbd8: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-04-03 15:30:11 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2020-04-04

[PULL 2/3] dump/win_dump: fix use after free of err

2020-04-04 Thread Markus Armbruster
From: Vladimir Sementsov-Ogievskiy It's possible that we'll try to set err twice (or more). It's bad, it will crash. Instead, use warn_report(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200324153630.11882-4-vsement...@virtuozzo.com> Reviewed-by: Markus Armbruster Reviewed-by

[PULL 3/3] qga/commands-posix: fix use after free of local_err

2020-04-04 Thread Markus Armbruster
From: Vladimir Sementsov-Ogievskiy local_err is used several times in guest_suspend(). Setting non-NULL local_err will crash, so let's zero it after freeing. Also fix possible leak of local_err in final if(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200324153630.11882-7-vsemen

Re: [PATCH for-5.0 0/6] Several error use-after-free

2020-04-04 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Hi all! > > I accidentally found use-after-free of local_err in mirror, and decided > to search for similar cases with help of small coccinelle script > (patch 01). Happily, there no many cases. > > Better to fix zero Error* pointer after each freeing everyw

RE: [PATCH v2 16/22] intel_iommu: replay pasid binds after context cache invalidation

2020-04-04 Thread Liu, Yi L
Hi Peter, > From: Peter Xu > Sent: Saturday, April 4, 2020 12:11 AM > To: Liu, Yi L > Subject: Re: [PATCH v2 16/22] intel_iommu: replay pasid binds after context > cache > invalidation > > On Fri, Apr 03, 2020 at 03:21:10PM +, Liu, Yi L wrote: > > > From: Peter Xu > > > Sent: Friday, Apri

RE: [PATCH v2 13/22] intel_iommu: add PASID cache management infrastructure

2020-04-04 Thread Liu, Yi L
Hi Peter, > From: Peter Xu > Sent: Saturday, April 4, 2020 12:20 AM > To: Liu, Yi L > > On Fri, Apr 03, 2020 at 03:05:57PM +, Liu, Yi L wrote: > > > From: Peter Xu > > > Sent: Thursday, April 2, 2020 9:45 PM > > > To: Liu, Yi L > > > Subject: Re: [PATCH v2 13/22] intel_iommu: add PASID ca

Re: Questionable aspects of QEMU Error's design

2020-04-04 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > >> QEMU's Error was patterned after GLib's GError. Differences include: > [...] >> * Return value conventions >> >> Common: non-void functions return a distinct error value on failure >> when such a value can be defined. Patterns: >>

Re: QEMU participation to Google Season of Docs

2020-04-04 Thread Ruben
Its ingoogle... We don't do google. On April 3, 2020 9:37:09 PM EDT, John Snow wrote: > > >On 4/1/20 12:37 PM, Philippe Mathieu-Daudé wrote: >> Hi, >> >> Google recently announced their 'Season of Docs' project: >> https://developers.google.com/season-of-docs >> >> QEMU project seems to fit a

Re: [PATCH v2] ppc/pnv: Create BMC devices at machine init

2020-04-04 Thread Nathan Chancellor
Hi Cédric, On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU model

Re: [PATCH v4 for-5.0] configure: warn if not using a separate build directory

2020-04-04 Thread Peter Maydell
On Fri, 3 Apr 2020 at 23:35, Aleksandar Markovic wrote: > But, Eric, while, to some extent I understand your motivation and the idea, > there are still features working in in-tree builds only (some coccinele > scenarios, and some gcov-related scenarios - and perhaps others that nobody > seems t

Re: [PATCH for-5.0] dump: Fix writing of ELF section

2020-04-04 Thread Peter Maydell
On Fri, 3 Apr 2020 at 21:55, Philippe Mathieu-Daudé wrote: > > On 3/24/20 6:36 PM, Peter Maydell wrote: > > In write_elf_section() we set the 'shdr' pointer to point to local > > structures shdr32 or shdr64, which we fill in to be written out to > > the ELF dump. Unfortunately the address we pass

Re: [PATCH v2 0/7] hyperv: VMBus implementation

2020-04-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200404082900.33711-1-ari...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

[PATCH v2 7/7] vmbus: add infrastructure to save/load vmbus requests

2020-04-04 Thread Jon Doron
This can be allow to include controller-specific data while saving/loading in-flight scsi requests of the vmbus scsi controller. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/hyperv/vmbus.c | 99 +++ in

[PATCH v2 6/7] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-04 Thread Jon Doron
Guest OS uses ACPI to discover VMBus presence. Add a corresponding entry to DSDT in case VMBus has been enabled. Experimentally Windows guests were found to require this entry to include two IRQ resources. They seem to never be used but they still have to be there. Make IRQ numbers user-configur

[PATCH v2 2/7] hyperv: SControl is optional to enable SynIc

2020-04-04 Thread Jon Doron
SynIc can be enabled regardless of the SControl mechanisim which can register a GSI for a given SintRoute. This behaviour can achived by setting enabling SIMP and then the guest will poll on the message slot. Once there is another message pending the host will set the message slot with the pendin

[PATCH v2 5/7] i386:pc: whitelist dynamic vmbus-bridge

2020-04-04 Thread Jon Doron
As vmbus-bridge is derived from sysbus device, it has to be whitelisted to be allowed to be created with -device. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c | 2 ++ 2 files changed, 4 insertions(+) dif

[PATCH v2 3/7] vmbus: add vmbus protocol definitions

2020-04-04 Thread Jon Doron
Add a header with data structures and constants used in Hyper-V VMBus hypervisor <-> guest interactions. Based on the respective stuff from Linux kernel. Signed-off-by: Roman Kagan Signed-off-by: Maciej S. Szmigiero Signed-off-by: Jon Doron --- include/hw/hyperv/vmbus-proto.h | 222 ++

[PATCH v2 0/7] hyperv: VMBus implementation

2020-04-04 Thread Jon Doron
This is a rebase of the old patchset from Roman for HyperV VMBus implementation. How to use: -device vmbus-bridge Later on new paravirtualized devices can be implemented on top of it (Network/SCSI/etc.) VMBus is a collection of technologies. At its lowest layer, it's a message passing and signa

[PATCH v2 1/7] hyperv: expose API to determine if synic is enabled

2020-04-04 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/hyperv.c | 8 include/hw/hyperv/hyperv.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c index 8ca3706f5b..ddf4f32c60 100644 --- a/hw/hyperv/hyperv.c +++ b/hw/hyperv/hyperv.c @@ -37,6 +37,13 @@ t

[PATCH v2 4/7] vmbus: vmbus implementation

2020-04-04 Thread Jon Doron
Add the VMBus infrastructure -- bus, devices, root bridge, vmbus state machine, vmbus channel interactions, etc. VMBus is a collection of technologies. At its lowest layer, it's a message passing and signaling mechanism, allowing efficient passing of messages to and from guest VMs. A layer highe

Re: [PATCH v2] ppc/pnv: Create BMC devices at machine init

2020-04-04 Thread Cédric Le Goater
On 4/4/20 9:17 AM, Nathan Chancellor wrote: > Hi Cédric, > > On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: >> The BMC of the OpenPOWER systems monitors the machine state using >> sensors, controls the power and controls the access to the PNOR flash >> device containing the firm

Re: Questionable aspects of QEMU Error's design

2020-04-04 Thread Markus Armbruster
Markus Armbruster writes: > QEMU's Error was patterned after GLib's GError. Differences include: [...] > * Return value conventions > > Common: non-void functions return a distinct error value on failure > when such a value can be defined. Patterns: > > - Functions returning non-null poin