Re: [PATCH-for-5.0 00/12] hw: Add missing error-propagation code

2020-04-03 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Markus, Peter. > > On 3/31/20 3:23 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> This series is inspired of Peter fix: >>> "hw/arm/xlnx-zynqmp.c: fix some error-handling code" >>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg69

[PATCH v5 0/2] Replaced locks with lock guard macros

2020-04-03 Thread dnbrdsky
From: Daniel Brodsky This patch set adds: - a fix for lock guard macros so they can be used multiple times in the same function - replacement of locks with lock guards where appropriate v4 -> v5: - added G_GNUC_UNUSED to lock guard macro to supress unused var warning v3 -> v4: - removed unneede

[PATCH v5 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-04-03 Thread dnbrdsky
From: Daniel Brodsky - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets - replaced result with QEMU_LOCK_GUARD if all unlocks at function end - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end Signed-off-by: Daniel Brodsky --- block/iscsi.c | 7 ++ block/nf

[PATCH v5 1/2] lockable: fix __COUNTER__ macro to be referenced properly

2020-04-03 Thread dnbrdsky
From: Daniel Brodsky - __COUNTER__ doesn't work with ## concat - replaced ## with glue() macro so __COUNTER__ is evaluated Fixes: 3284c3ddc4 Signed-off-by: Daniel Brodsky --- include/qemu/lockable.h | 7 --- include/qemu/rcu.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-)

Re: [PATCH for-5.0] qcow2: Check request size in qcow2_co_pwritev_compressed_part()

2020-04-03 Thread Andrey Shinkevich
From: Alberto Garcia Sent: Friday, April 3, 2020 7:57 PM To: qemu-devel@nongnu.org Cc: Alberto Garcia; qemu-bl...@nongnu.org; Andrey Shinkevich; Max Reitz; Kevin Wolf; Vladimir Sementsov-Ogievskiy; Pavel Butsykin Subject: [PATCH for-5.0] qcow2: Check req

Re: [PATCH for-5.0] qcow2: Check request size in qcow2_co_pwritev_compressed_part()

2020-04-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200403165752.18009-1-be...@igalia.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-03 Thread John Snow
On 4/3/20 4:57 AM, Max Reitz wrote: > On 02.04.20 20:27, John Snow wrote: > > [...] > >> Are we squared up for this series? I am actually not sure. > > As far as I’m concerned, yes. I just had this question on how to use mypy. Oh, whoops, Kevin's comment. I do want to address that one. So

Re: [PATCH 2/5] ppc/pnv: Add support for NMI interface

2020-04-03 Thread Nicholas Piggin
Cédric Le Goater's on April 4, 2020 1:47 am: > On 4/3/20 3:12 PM, Nicholas Piggin wrote: >> Nicholas Piggin's on April 3, 2020 5:57 pm: >>> Cédric Le Goater's on March 26, 2020 2:38 am: [ Please use c...@kaod.org ! ] On 3/25/20 3:41 PM, Nicholas Piggin wrote: > This implements th

Re: QEMU participation to Google Season of Docs

2020-04-03 Thread John Snow
On 4/1/20 12:37 PM, Philippe Mathieu-Daudé wrote: > Hi, > > Google recently announced their 'Season of Docs' project: > https://developers.google.com/season-of-docs > > QEMU project seems to fit all the requirements. > > Who is interested in [co-]mentoring? > > Relevant links: > https://deve

Re: [PATCH v3 08/12] linux-user: factor out reading of /proc/self/maps

2020-04-03 Thread Richard Henderson
On 4/3/20 12:11 PM, Alex Bennée wrote: > +e->is_read = fields[1][0] == 'r' ? true : false; > +e->is_write = fields[1][1] == 'w' ? true : false; > +e->is_exec = fields[1][2] == 'x' ? true : false; > +e->is_priv = fields[1][3] == 'p'

Re: plugin interface function qemu_plugin_mem_size_shift

2020-04-03 Thread Richard Henderson
On 4/3/20 11:55 AM, Alex Bennée wrote: > + * The size_shift is the scale of access, e.g. << 3 is a 64 bit wide > + * access. Maybe better as "e.g. 1 << 3 is an 8-byte access."? r~

Re: [PATCH for-5.0?] docs: Improve our gdbstub documentation

2020-04-03 Thread Richard Henderson
On 4/3/20 2:40 AM, Peter Maydell wrote: > The documentation of our -s and -gdb options is quite old; in > particular it still claims that it will cause QEMU to stop and wait > for the gdb connection, when this has not been true for some time: > you also need to pass -S if you want to make QEMU not

Re: [PATCH-for-5.0 v2] target/rx/translate: Add missing fall through comment

2020-04-03 Thread Richard Henderson
On 4/3/20 11:44 AM, Philippe Mathieu-Daudé wrote: > Coverity reported a missing fall through comment, add it. > > Fixes: e5918d7d7f0 ("target/rx: TCG translation") > Reported-by: Coverity (CID 142 MISSING_BREAK) > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > ---

Re: [PATCH-for-5.0] target/rx/translate: Add missing fall through comment

2020-04-03 Thread Richard Henderson
On 4/3/20 11:42 AM, Philippe Mathieu-Daudé wrote: > Coverity reported a missing fall through comments, add it. > > Fixes: e5918d7d7f0 ("target/rx: TCG translation") > Reported-by: Coverity (CID 142 MISSING_BREAK) > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > ---

[Bug 1805913] Re: readdir() returns NULL (errno=EOVERFLOW) for 32-bit user-static qemu on 64-bit host

2020-04-03 Thread Eicke Herbertz
After reading through the discussion on the mailing list, as it's all about ext4, I got curious... I'm testing with qemu-user-static and regulary build arm images in a tmpfs. This show similar behaviour and readdir() fails. However, running in the same root copied onto a btrfs, it seems fine. Ma

Re: [PATCH v1 0/5] hyperv: VMBus implementation

2020-04-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200403142308.82990-1-ari...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v1 0/5] hyperv: VMBus implementation Message-id: 20200403142308.82990-1-ari...@gmail.com Type: series

Re: [PATCH v4 for-5.0] configure: warn if not using a separate build directory

2020-04-03 Thread Aleksandar Markovic
16:44 Pet, 03.04.2020. Eric Blake је написао/ла: > > On 4/3/20 9:02 AM, Eric Blake wrote: > > On 4/3/20 8:53 AM, Daniel P. Berrangé wrote: > >> Running configure directly from the source directory is a build > >> configuration that will go away in future. It is also not currently > >> covered by a

Re: [PATCH] nvdimm-utils: clean up headers and add license comment

2020-04-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200403140018.13531-1-imamm...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Maciej S. Szmigiero
It seems to me that Roman might not be getting our e-mails since his new e-mail address seems to be "rvka...@yandex-team.ru". @Roman, are you with us? Thanks, Maciej On 03.04.2020 19:18, Maciej S. Szmigiero wrote: > Hi Jon, > > The patches are available here: > https://github.com/maciejsszmigie

Re: [PATCH for-5.0] dump: Fix writing of ELF section

2020-04-03 Thread Philippe Mathieu-Daudé
On 3/24/20 6:36 PM, Peter Maydell wrote: In write_elf_section() we set the 'shdr' pointer to point to local structures shdr32 or shdr64, which we fill in to be written out to the ELF dump. Unfortunately the address we pass to fd_write_vmcore() has a spurious '&' operator, so instead of writing o

Re: [PATCH v3 04/12] linux-user: more debug for init_guest_space

2020-04-03 Thread Philippe Mathieu-Daudé
On 4/3/20 9:11 PM, Alex Bennée wrote: Searching for memory space can cause problems so lets extend the CPU_LOG_PAGE output so you can watch init_guest_space fail to allocate memory. A more involved fix is actually required to make this function play nicely with the large guard pages the sanitiser

Re: [PATCH v16 QEMU 14/16] vfio: Add vfio_listener_log_sync to mark dirty pages

2020-04-03 Thread Kirti Wankhede
On 4/1/2020 11:20 AM, Yan Zhao wrote: On Wed, Mar 25, 2020 at 05:09:12AM +0800, Kirti Wankhede wrote: vfio_listener_log_sync gets list of dirty pages from container using VFIO_IOMMU_GET_DIRTY_BITMAP ioctl and mark those pages dirty when all devices are stopped and saving state. Return early f

[PATCH v3 12/12] configure: Add -Werror to PIE probe

2020-04-03 Thread Alex Bennée
From: Richard Henderson Without -Werror, the probe may succeed, but then compilation fails later when -Werror is added for other reasons. Shows up on windows, where the compiler complains about -fPIC. Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20200401214756.6559

[PATCH v3 09/12] linux-user: clean-up padding on /proc/self/maps

2020-04-03 Thread Alex Bennée
Don't use magic spaces, calculate the justification for the file field like the kernel does with seq_pad. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - change for unsigned long update --- linux-user/syscall.c | 32 +++- 1 file changed, 19 inse

[PATCH v3 10/12] target/arm: don't expose "ieee_half" via gdbstub

2020-04-03 Thread Alex Bennée
While support for parsing ieee_half in the XML description was added to gdb in 2019 (a6d0f249) there is no easy way for the gdbstub to know if the gdb end will understand it. Disable it for now and allow older gdbs to successfully connect to the default -cpu max SVE enabled QEMUs. Signed-off-by: A

[PATCH v3 06/12] gdbstub: fix compiler complaining

2020-04-03 Thread Alex Bennée
From: Denis Plotnikov ./gdbstub.c: In function ‘handle_query_thread_extra’: /usr/include/glib-2.0/glib/glib-autocleanups.h:28:10: error: ‘cpu_name’ may be used uninitialized in this function [-Werror=maybe-uninitialized] g_free (*pp); ^ ./gdbstub.c:2

[PATCH v3 08/12] linux-user: factor out reading of /proc/self/maps

2020-04-03 Thread Alex Bennée
Unfortunately reading /proc/self/maps is still considered the gold standard for a process finding out about it's own memory layout. As we will want this data in other contexts soon factor out the code to read and parse the data. Rather than just blindly copying the existing sscanf based code we use

[PATCH v3 05/12] target/xtensa: add FIXME for translation memory leak

2020-04-03 Thread Alex Bennée
Dynamically allocating a new structure within the DisasContext can potentially leak as we can longjmp out of the translation loop (see test_phys_mem). The proper fix would be to use static allocation within the DisasContext but as the Xtensa translator imports it's code from elsewhere I leave that

[PATCH v3 11/12] hw/core: properly terminate loading .hex on EOF record

2020-04-03 Thread Alex Bennée
The https://makecode.microbit.org/#editor generates slightly weird .hex files which work fine on a real microbit but causes QEMU to choke. The reason is extraneous data after the EOF record which causes the loader to attempt to write a bigger file than it should to the "rom". According to the HEX f

[PATCH v3 04/12] linux-user: more debug for init_guest_space

2020-04-03 Thread Alex Bennée
Searching for memory space can cause problems so lets extend the CPU_LOG_PAGE output so you can watch init_guest_space fail to allocate memory. A more involved fix is actually required to make this function play nicely with the large guard pages the sanitiser likes to use. Signed-off-by: Alex Benn

[PATCH v3 07/12] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

2020-04-03 Thread Alex Bennée
From: Richard Henderson All other calls to normalize*Subnormal detect zero input before the call -- this is the only outlier. This case can happen with +0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of the correct sign. Reported-by: Coverity (CID 1421991) Signed-off-by: Richard Hend

[PATCH v3 01/12] elf-ops: bail out if we have no function symbols

2020-04-03 Thread Alex Bennée
It's perfectly possible to have no function symbols in your elf file and if we do the undefined behaviour sanitizer rightly complains about us passing NULL to qsort. Check nsyms before we go ahead. While we are at it lets drop the unchecked return value and cleanup the fail leg by use of g_autoptr

[PATCH v3 03/12] tests/tcg: remove extraneous pasting macros

2020-04-03 Thread Alex Bennée
We are not using them and they just get in the way. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- tests/tcg/x86_64/system/boot.S | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/tcg/x86_64/system/boot.S b/tests/tc

[PATCH v3 02/12] linux-user: protect fcntl64 with an #ifdef

2020-04-03 Thread Alex Bennée
Checking TARGET_ABI_BITS is sketchy - we should check for the presence of the define to be sure. Also clean up the white space while we are there. Signed-off-by: Alex Bennée Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/syscall.c | 8 1 file changed, 4 inse

[PATCH v3 for 5.0-rc2 00/12] a selection of random fixes

2020-04-03 Thread Alex Bennée
Hi, Here is version 3 of my random fixes series. I've dropped the more involved re-factoring of init_guest_space as it's going to take more thought and is best left to 5.1. I've left in the earlier clean-ups which fix the spacing and of the /proc/self/maps but I can drop them if they seem too ra

Re: qemu plugin exposure of register addresses

2020-04-03 Thread Alex Bennée
Robert Henry writes: > There is now a qemu plugin interface function > qemu_plugin_register_vcpu_mem_cb which registers a plugin-side > callback. This callback is later invoked at the start of each emulated > instruction, and it receives information about memory addresses and > read/write indic

Re: plugin interface function qemu_plugin_mem_size_shift

2020-04-03 Thread Alex Bennée
Robert Henry writes: > I don't understand what > unsigned int qemu_plugin_mem_size_shift(qemu_plugin_meminfo_t info); > does. The documentation in qemu-plugin.h is silent on this matter. > It appears to expose more of the guts of qemu that I don't yet know. It's the size as a power of 2,

Re: [PATCH v1 0/5] dma/xlnx-zdma: Bug fixes

2020-04-03 Thread Peter Maydell
On Thu, 2 Apr 2020 at 14:46, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Hi, > > This series fixes a couple of bugs we've ran into with some > proprietary test code and drivers using the Xilinx zDMA. Thanks; as these are bugfixes I've applied them to target-arm.next for 5.0. I'd a

[PATCH-for-5.0 v2] target/rx/translate: Add missing fall through comment

2020-04-03 Thread Philippe Mathieu-Daudé
Coverity reported a missing fall through comment, add it. Fixes: e5918d7d7f0 ("target/rx: TCG translation") Reported-by: Coverity (CID 142 MISSING_BREAK) Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- v2: Fixed typo 'comments -> comment' --- target/rx/translate.c

[PATCH-for-5.0] target/rx/translate: Add missing fall through comment

2020-04-03 Thread Philippe Mathieu-Daudé
Coverity reported a missing fall through comments, add it. Fixes: e5918d7d7f0 ("target/rx: TCG translation") Reported-by: Coverity (CID 142 MISSING_BREAK) Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/rx/translate.c | 1 + 1 file changed, 1 insertion(+) d

Re: [PATCH v1 5/5] dma/xlnx-zdma: Reorg to fix CUR_DSCR

2020-04-03 Thread Peter Maydell
On Thu, 2 Apr 2020 at 14:46, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Reorganize the descriptor handling so that CUR_DSCR always > points to the next descriptor to be processed. > > Signed-off-by: Edgar E. Iglesias > --- This is just moved-code in this patch so I think it's a

Re: [PATCH for-5.0] dump: Fix writing of ELF section

2020-04-03 Thread Peter Maydell
On Tue, 24 Mar 2020 at 17:49, Marc-André Lureau wrote: > > Hi > > On Tue, Mar 24, 2020 at 6:36 PM Peter Maydell > wrote: > > > > In write_elf_section() we set the 'shdr' pointer to point to local > > structures shdr32 or shdr64, which we fill in to be written out to > > the ELF dump. Unfortunat

Re: [PATCH] target/arm: don't expose "ieee_half" via gdbstub

2020-04-03 Thread Peter Maydell
On Thu, 2 Apr 2020 at 15:39, Alex Bennée wrote: > > While support for parsing ieee_half in the XML description was added > to gdb in 2019 (a6d0f249) there is no easy way for the gdbstub to know > if the gdb end will understand it. Disable it for now and allow older > gdbs to successfully connect t

[PATCH for-5.0? v2] qcow2: Explicit mention of padding bytes

2020-04-03 Thread Eric Blake
Although we already covered the need for padding bytes with our changes in commit 3ae3fcfa, commit 66fcbca5 just added one byte and relied on the rest of the text for implicitly covering 7 padding bytes. For consistency with other parts of the header (such as the header extension format listing pa

[PATCH v5 3/7] qcow: Tolerate backing_fmt=, but warn on backing_fmt=raw

2020-04-03 Thread Eric Blake
qcow has no space in the metadata to store a backing format, and there are existing qcow images backed both by raw or by other formats (usually qcow) images, reliant on probing to tell the difference. While we don't recommend the creation of new qcow images (as qcow2 is hands-down better), we can a

[PATCH v5 6/7] block: Add support to warn on backing file change without format

2020-04-03 Thread Eric Blake
For now, this is a mechanical addition; all callers pass false. But the next patch will use it to improve 'qemu-img rebase -u' when selecting a backing file with no format. Signed-off-by: Eric Blake Reviewed-by: Peter Krempa Reviewed-by: Ján Tomko --- include/block/block.h | 4 ++-- block.c

[PATCH v5 7/7] qemu-img: Deprecate use of -b without -F

2020-04-03 Thread Eric Blake
Creating an image that requires format probing of the backing image is inherently unsafe (we've had several CVEs over the years based on probes leaking information to the guest on a subsequent boot, although these days tools like libvirt are aware of the issue enough to prevent the worst effects).

[PATCH v5 4/7] qcow2: Deprecate use of qemu-img amend to change backing file

2020-04-03 Thread Eric Blake
The use of 'qemu-img amend' to change qcow2 backing files is not tested very well. In particular, our implementation has a bug where if a new backing file is provided without a format, then the prior format is blindly reused, even if this results in data corruption, but this is not caught by iotes

[PATCH v5 2/7] vmdk: Add trivial backing_fmt support

2020-04-03 Thread Eric Blake
vmdk already requires that if backing_file is present, that it be another vmdk image (see vmdk_co_do_create). Meanwhile, we want to move towards always being explicit about the backing format for other drivers where it matters. So for convenience, make qemu-img create -F vmdk work, while rejectin

[PATCH v5 1/7] sheepdog: Add trivial backing_fmt support

2020-04-03 Thread Eric Blake
Sheepdog already requires that if backing_file is present, that it be another sheepdog image (see sd_co_create). Meanwhile, we want to move towards always being explicit about the backing format for other drivers where it matters. So for convenience, make qemu-img create -F sheepdog work, while r

[PATCH v5 for-5.0? 0/7] Tighten qemu-img rules on missing backing format

2020-04-03 Thread Eric Blake
v4 was here: https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg03775.html In v5: - fix 'qemu-img convert -B' to actually warn [Kashyap] - squash in followups - a couple more iotest improvements If we decide this is not 5.0 material, then patches 4 and 7 need a tweak to s/5.0/5.1/ as the sta

Re: [PATCH-for-5.0?] configure: Do not leave sphinx in-tree artifacts

2020-04-03 Thread Philippe Mathieu-Daudé
On 4/3/20 7:49 PM, Eric Blake wrote: On 4/3/20 12:37 PM, Eric Blake wrote: On 4/3/20 11:57 AM, Peter Maydell wrote: On Fri, 3 Apr 2020 at 17:54, Philippe Mathieu-Daudé wrote: When ./configure checks the sphinx version is new enough, it leaves the docs/sphinx/__pycache__/ directory. Avoid thi

Re: [PATCH-for-5.0 00/12] hw: Add missing error-propagation code

2020-04-03 Thread Philippe Mathieu-Daudé
Hi Markus, Peter. On 3/31/20 3:23 PM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: This series is inspired of Peter fix: "hw/arm/xlnx-zynqmp.c: fix some error-handling code" https://www.mail-archive.com/qemu-devel@nongnu.org/msg691636.html Add a cocci script to fix the other place

Re: [PATCH-for-5.0?] configure: Do not leave sphinx in-tree artifacts

2020-04-03 Thread Eric Blake
On 4/3/20 12:37 PM, Eric Blake wrote: On 4/3/20 11:57 AM, Peter Maydell wrote: On Fri, 3 Apr 2020 at 17:54, Philippe Mathieu-Daudé wrote: When ./configure checks the sphinx version is new enough, it leaves the docs/sphinx/__pycache__/ directory. Avoid this by using the '-B' option (don't writ

Re: [PATCH for-5.0] qcow2: Check request size in qcow2_co_pwritev_compressed_part()

2020-04-03 Thread Eric Blake
On 4/3/20 11:57 AM, Alberto Garcia wrote: When issuing a compressed write request the number of bytes must be a multiple of the cluster size. With the current code such requests are allowed and we hit an assertion: $ qemu-img create -f qcow2 img.qcow2 1M $ qemu-io -c 'write -c 0 32k' im

Re: [PATCH-for-5.0?] configure: Do not leave sphinx in-tree artifacts

2020-04-03 Thread Eric Blake
On 4/3/20 11:57 AM, Peter Maydell wrote: On Fri, 3 Apr 2020 at 17:54, Philippe Mathieu-Daudé wrote: When ./configure checks the sphinx version is new enough, it leaves the docs/sphinx/__pycache__/ directory. Avoid this by using the '-B' option (don't write .py[co] files on import) via the PYTH

Re: [PATCH-for-5.0?] configure: Do not leave sphinx in-tree artifacts

2020-04-03 Thread Philippe Mathieu-Daudé
On 4/3/20 6:57 PM, Peter Maydell wrote: On Fri, 3 Apr 2020 at 17:54, Philippe Mathieu-Daudé wrote: When ./configure checks the sphinx version is new enough, it leaves the docs/sphinx/__pycache__/ directory. Avoid this by using the '-B' option (don't write .py[co] files on import) via the PYTHO

[NOTFORMERGE PATCH 8/8] Kludge for Avocado issue #3661

2020-04-03 Thread Philippe Mathieu-Daudé
Use a feature from unreleased Avocado v78.0. See https://github.com/avocado-framework/avocado/issues/3661 Signed-off-by: Philippe Mathieu-Daudé --- tests/requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/requirements.txt b/tests/requirements.txt index f9c

[PATCH-for-5.0 5/8] .travis.yml: Cache acceptance-test assets

2020-04-03 Thread Philippe Mathieu-Daudé
Keep all acceptance-test assets in the same cache bucket. As of v5.0.0-rc1, the cache is 2610.11MB: https://travis-ci.org/github/philmd/qemu/jobs/670558103 Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index

[PATCH-for-5.1 6/8] tests/Makefile: Add fetch-acceptance-assets rule

2020-04-03 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/Makefile.include | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index 51de676298..90f457593c 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -906,6 +906,13 @@ get-vm-ima

[PATCH-for-5.1 7/8] .travis.yml: Run fetch-acceptance-assets before check-acceptance

2020-04-03 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 2fd63eceaa..c6b32da447 100644 --- a/.travis.yml +++ b/.travis.yml @@ -317,7 +317,7 @@ jobs: dist: bionic env: - CONFIG="

[PATCH-for-5.0 3/8] tests/acceptance/ppc_prep_40p: Use mirror for ftp.software.ibm.com

2020-04-03 Thread Philippe Mathieu-Daudé
To avoid regular failures on Travis-CI with ftp.software.ibm.com, use a mirror. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/ppc_prep_40p.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py ind

[PATCH-for-5.0 1/8] Acceptance test: Fix to EXEC migration

2020-04-03 Thread Philippe Mathieu-Daudé
From: Oksana Vohchana The exec migration test isn't run a whole test scenario. This patch fixes it Fixes: 2e768cb682bf Signed-off-by: Oksana Vohchana Reviewed-by: Philippe Mathieu-Daudé Tested-by: Wainer dos Santos Moschetta Message-Id: <20200325113138.20337-1-ovosh...@redhat.com> Signed-off-

[PATCH-for-5.0 2/8] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-04-03 Thread Philippe Mathieu-Daudé
Use NetBSD content delivery network to get faster downloads. Suggested-by: Kamil Rytarowski Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20200211134504.9156-1-phi...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/ppc_prep_40p.py | 4 ++-- 1 file changed, 2 inse

[PATCH-for-5.0 4/8] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

2020-04-03 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé This test was written/tested around beginning of 2019, but was extracted from a bigger series and posted end of June 2019 [*]. Unfortunately I did not notice commit 162abf1a8 was merged by then, which implements the AHB and APB plug and play devices. HelenOS 0.6 is e

[PATCH-for-5.0 0/8] Acceptance tests queue

2020-04-03 Thread Philippe Mathieu-Daudé
I'm planning to send the first 5 patches as This series contains acceptance test fixes, and Travis-CI improvements. I plan to send a pull request with the first 6 patches for v5.0-rc2. The last 3 patches helped debugging painfully the Travis failures, but can not be used because Avocado 78.0 is not

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Maciej S. Szmigiero
Hi Jon, The patches are available here: https://github.com/maciejsszmigiero/qemu.git in "vmbus-patches" branch. Please note that these patches don't have Roman's "Signed-off-by:" tags, so I haven't applied mine, either. If you are able to establish a proper SoB chain then please also add: "Signe

[PATCH for-5.0] qcow2: Check request size in qcow2_co_pwritev_compressed_part()

2020-04-03 Thread Alberto Garcia
When issuing a compressed write request the number of bytes must be a multiple of the cluster size. With the current code such requests are allowed and we hit an assertion: $ qemu-img create -f qcow2 img.qcow2 1M $ qemu-io -c 'write -c 0 32k' img.qcow2 qemu-io: block/qcow2.c:4257: qcow2

Re: [PATCH-for-5.0?] configure: Do not leave sphinx in-tree artifacts

2020-04-03 Thread Peter Maydell
On Fri, 3 Apr 2020 at 17:54, Philippe Mathieu-Daudé wrote: > > When ./configure checks the sphinx version is new enough, it leaves > the docs/sphinx/__pycache__/ directory. Avoid this by using the '-B' > option (don't write .py[co] files on import) via the > PYTHONDONTWRITEBYTECODE environment var

[PATCH-for-5.0?] configure: Do not leave sphinx in-tree artifacts

2020-04-03 Thread Philippe Mathieu-Daudé
When ./configure checks the sphinx version is new enough, it leaves the docs/sphinx/__pycache__/ directory. Avoid this by using the '-B' option (don't write .py[co] files on import) via the PYTHONDONTWRITEBYTECODE environment variable. Reported-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v2] nvdimm-utils: clean up headers and add license comment

2020-04-03 Thread Philippe Mathieu-Daudé
Hi Igor, On 4/3/20 4:41 PM, Igor Mammedov wrote: Fixes: 3f350f6bb36233be50fc2bc18dc78b6a948a5dbe Reported-by: Peter Maydell Signed-off-by: Igor Mammedov --- v2: - add license blob to header as well - trim comment a litle bit to remove unrelated NFIT/PMEM sentences --- include/qemu/nvdi

Re: [PULL 03/13] target/rx: TCG translation

2020-04-03 Thread Richard Henderson
On 4/3/20 9:41 AM, Peter Maydell wrote: > On Tue, 17 Mar 2020 at 16:52, Philippe Mathieu-Daudé wrote: >> >> From: Yoshinori Sato >> >> This part only supported RXv1 instructions. >> >> Instruction manual: >> >> https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxs

Re: [PULL 03/13] target/rx: TCG translation

2020-04-03 Thread Peter Maydell
On Tue, 17 Mar 2020 at 16:52, Philippe Mathieu-Daudé wrote: > > From: Yoshinori Sato > > This part only supported RXv1 instructions. > > Instruction manual: > > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Hi; Coverity points out a possible missing

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Maciej S. Szmigiero
Hi Jon, On 03.04.2020 16:23, Jon Doron wrote: > Guest OS uses ACPI to discover vmbus presence. Add a corresponding > entry to DSDT in case vmbus has been enabled. > > Experimentally Windows guests were found to require this entry to > include two IRQ resources, so this patch adds two semi-arbitr

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Maciej S. Szmigiero
Thanks Jon, I will push out to what I have in a moment. Maciej On 03.04.2020 17:30, Jon Doron wrote: > Thank you Maciej it seems like your version is really ahead I'll do > the required work and merge it so i can submit a v2 with the latest > patchset from Roman > > On Fri, Apr 3, 2020 at 6:06

Re: bdrv_drained_begin deadlock with io-threads

2020-04-03 Thread Dietmar Maurer
> On April 3, 2020 10:47 AM Kevin Wolf wrote: > > > Am 03.04.2020 um 10:26 hat Dietmar Maurer geschrieben: > > > With the following patch, it seems to survive for now. I'll give it some > > > more testing tomorrow (also qemu-iotests to check that I didn't > > > accidentally break something el

Re: [PATCH v2 13/22] intel_iommu: add PASID cache management infrastructure

2020-04-03 Thread Peter Xu
On Fri, Apr 03, 2020 at 03:05:57PM +, Liu, Yi L wrote: > > From: Peter Xu > > Sent: Thursday, April 2, 2020 9:45 PM > > To: Liu, Yi L > > Subject: Re: [PATCH v2 13/22] intel_iommu: add PASID cache management > > infrastructure > > > > On Thu, Apr 02, 2020 at 06:46:11AM +, Liu, Yi L wrote

Re: [PATCH v2 16/22] intel_iommu: replay pasid binds after context cache invalidation

2020-04-03 Thread Peter Xu
On Fri, Apr 03, 2020 at 03:21:10PM +, Liu, Yi L wrote: > > From: Peter Xu > > Sent: Friday, April 3, 2020 10:46 PM > > To: Liu, Yi L > > Subject: Re: [PATCH v2 16/22] intel_iommu: replay pasid binds after context > > cache > > invalidation > > > > On Sun, Mar 29, 2020 at 09:24:55PM -0700, L

Re: qemu-system-aarch64 windows binary run Arm64 defconfig kernel not working

2020-04-03 Thread yoma sophian
hi Peter: > unfortunately, 32-bit Windows qemu binary still fail on booting > upstream arm64 defconfig kernel. Is there any debug info of qemu could I provide? Appreciate ur kind help,

Re: [PATCH v3 0/3] hw/riscv: Add a serial property to sifive_u

2020-04-03 Thread Palmer Dabbelt
On Mon, 23 Mar 2020 19:08:19 PDT (-0700), bmeng...@gmail.com wrote: Hi Palmer, On Sat, Mar 7, 2020 at 5:45 AM Alistair Francis wrote: At present the board serial number is hard-coded to 1, and passed to OTP model during initialization. Firmware (FSBL, U-Boot) uses the serial number to generat

Re: [PATCH 2/5] ppc/pnv: Add support for NMI interface

2020-04-03 Thread Cédric Le Goater
On 4/3/20 3:12 PM, Nicholas Piggin wrote: > Nicholas Piggin's on April 3, 2020 5:57 pm: >> Cédric Le Goater's on March 26, 2020 2:38 am: >>> [ Please use c...@kaod.org ! ] >>> >>> On 3/25/20 3:41 PM, Nicholas Piggin wrote: This implements the NMI interface for the PNV machine, similarly to >>>

Re: [PATCH v2 0/5] fix migration with bitmaps and mirror

2020-04-03 Thread Vladimir Sementsov-Ogievskiy
03.04.2020 18:05, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: 03.04.2020 14:29, Vladimir Sementsov-Ogievskiy wrote: 03.04.2020 14:23, Peter Krempa wrote: On Fri, Apr 03, 2020 at 14:02:47 +0300, Vladimir Sementsov-Ogievskiy wrote: 19.12.2019 1

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Jon Doron
Thank you Maciej it seems like your version is really ahead I'll do the required work and merge it so i can submit a v2 with the latest patchset from Roman On Fri, Apr 3, 2020 at 6:06 PM Jon Doron wrote: > > Thank you Maciej, I based it on top of what Denis (d...@openvz.org) gave me > which was

RE: [PATCH v2 22/22] intel_iommu: modify x-scalable-mode to be string option

2020-04-03 Thread Liu, Yi L
> From: Peter Xu < pet...@redhat.com> > Sent: Friday, April 3, 2020 10:49 PM > To: Liu, Yi L > Subject: Re: [PATCH v2 22/22] intel_iommu: modify x-scalable-mode to be string > option > > On Sun, Mar 29, 2020 at 09:25:01PM -0700, Liu Yi L wrote: > > Intel VT-d 3.0 introduces scalable mode, and it

Re: [PATCH v2] s390x/pv: Retry ioctls on -EINTR

2020-04-03 Thread Cornelia Huck
On Fri, 27 Mar 2020 08:46:16 -0400 Christian Borntraeger wrote: > PV_ENABLE (and maybe others) might return -EINTR when a signal is > pending. See the Linux kernel patch "s390/gmap: return proper error code > on ksm unsharing" for details. Let us retry the ioctl in that case. > > Fixes: 4d226dea

RE: [PATCH v2 16/22] intel_iommu: replay pasid binds after context cache invalidation

2020-04-03 Thread Liu, Yi L
> From: Peter Xu > Sent: Friday, April 3, 2020 10:46 PM > To: Liu, Yi L > Subject: Re: [PATCH v2 16/22] intel_iommu: replay pasid binds after context > cache > invalidation > > On Sun, Mar 29, 2020 at 09:24:55PM -0700, Liu Yi L wrote: > > This patch replays guest pasid bindings after context ca

RE: [PATCH v2 19/22] intel_iommu: process PASID-based iotlb invalidation

2020-04-03 Thread Liu, Yi L
> From: Peter Xu > Sent: Friday, April 3, 2020 10:47 PM > To: Liu, Yi L > Subject: Re: [PATCH v2 19/22] intel_iommu: process PASID-based iotlb > invalidation > > On Sun, Mar 29, 2020 at 09:24:58PM -0700, Liu Yi L wrote: > > This patch adds the basic PASID-based iotlb (piotlb) invalidation > > s

Re: [PULL for-5.0 0/1] Block patches

2020-04-03 Thread Peter Maydell
On Fri, 3 Apr 2020 at 12:52, Stefan Hajnoczi wrote: > > The following changes since commit 5142ca078d1cbc0f77b0f385d28cdb3e504e62bd: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2020-04-02 20:18:25 +0100) > > are available in the Git repository at: > >

Re: [PATCH v4 4/4] target/ppc: Add support for Radix partition-scoped translation

2020-04-03 Thread Greg Kurz
On Fri, 3 Apr 2020 16:00:56 +0200 Cédric Le Goater wrote: > The Radix tree translation model currently supports process-scoped > translation for the PowerNV machine (Hypervisor mode) and for the > pSeries machine (Guest mode). Guests running under an emulated > Hypervisor (PowerNV machine) requi

RE: [PATCH v2 13/22] intel_iommu: add PASID cache management infrastructure

2020-04-03 Thread Liu, Yi L
> From: Peter Xu > Sent: Thursday, April 2, 2020 9:45 PM > To: Liu, Yi L > Subject: Re: [PATCH v2 13/22] intel_iommu: add PASID cache management > infrastructure > > On Thu, Apr 02, 2020 at 06:46:11AM +, Liu, Yi L wrote: > > [...] > > > > > +/** > > > > + * This function replay the guest p

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Jon Doron
Thank you Maciej, I based it on top of what Denis (d...@openvz.org) gave me which was this: https://ftp.openvz.org/virtuozzo/releases/openvz-7.0.12-288/source/SRPMS/q/qemu-kvm-vz-2.12.0-33.vz7.14.4.src.rpm Do you think you have a more recent version I dont mind diffing and resubmitting a new versi

Re: [PATCH v2 0/5] fix migration with bitmaps and mirror

2020-04-03 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 03.04.2020 14:29, Vladimir Sementsov-Ogievskiy wrote: > > 03.04.2020 14:23, Peter Krempa wrote: > > > On Fri, Apr 03, 2020 at 14:02:47 +0300, Vladimir Sementsov-Ogievskiy > > > wrote: > > > > 19.12.2019 13:36, Peter Krempa wrote: >

Re: [PATCH v4 for-5.0] configure: warn if not using a separate build directory

2020-04-03 Thread BALATON Zoltan
On Fri, 3 Apr 2020, Eric Blake wrote: On 4/3/20 8:53 AM, Daniel P. Berrangé wrote: Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attem

Re: [PATCH v4 1/4] target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation

2020-04-03 Thread Greg Kurz
On Fri, 3 Apr 2020 16:00:53 +0200 Cédric Le Goater wrote: > This is moving code under a new ppc_radix64_xlate() routine shared by > the MMU Radix page fault handler and the 'get_phys_page_debug' PPC > callback. The difference being that 'get_phys_page_debug' does not > generate exceptions. > >

Re: [PATCH for-5.0 2/2] block: Fix blk->in_flight during blk_wait_while_drained()

2020-04-03 Thread Kevin Wolf
Am 03.04.2020 um 14:42 hat Max Reitz geschrieben: > On 03.04.20 12:44, Kevin Wolf wrote: > > Calling blk_wait_while_drained() while blk->in_flight is increased for > > the current request is wrong because it will cause the drain operation > > to deadlock. > > > > Many callers of blk_wait_while_dra

Re: [PATCH v2 22/22] intel_iommu: modify x-scalable-mode to be string option

2020-04-03 Thread Peter Xu
On Sun, Mar 29, 2020 at 09:25:01PM -0700, Liu Yi L wrote: > Intel VT-d 3.0 introduces scalable mode, and it has a bunch of capabilities > related to scalable mode translation, thus there are multiple combinations. > While this vIOMMU implementation wants simplify it for user by providing > typical

Re: [PATCH v2 19/22] intel_iommu: process PASID-based iotlb invalidation

2020-04-03 Thread Peter Xu
On Sun, Mar 29, 2020 at 09:24:58PM -0700, Liu Yi L wrote: > This patch adds the basic PASID-based iotlb (piotlb) invalidation > support. piotlb is used during walking Intel VT-d 1st level page > table. This patch only adds the basic processing. Detailed handling > will be added in next patch. > >

Re: [PATCH v2 16/22] intel_iommu: replay pasid binds after context cache invalidation

2020-04-03 Thread Peter Xu
On Sun, Mar 29, 2020 at 09:24:55PM -0700, Liu Yi L wrote: > This patch replays guest pasid bindings after context cache > invalidation. This is a behavior to ensure safety. Actually, > programmer should issue pasid cache invalidation with proper > granularity after issuing a context cache invalidat

Re: [PATCH v4 for-5.0] configure: warn if not using a separate build directory

2020-04-03 Thread Eric Blake
On 4/3/20 9:02 AM, Eric Blake wrote: On 4/3/20 8:53 AM, Daniel P. Berrangé wrote: Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attemp

[PATCH v2] nvdimm-utils: clean up headers and add license comment

2020-04-03 Thread Igor Mammedov
Fixes: 3f350f6bb36233be50fc2bc18dc78b6a948a5dbe Reported-by: Peter Maydell Signed-off-by: Igor Mammedov --- v2: - add license blob to header as well - trim comment a litle bit to remove unrelated NFIT/PMEM sentences --- include/qemu/nvdimm-utils.h | 23 +-- util/nvdimm-ut

  1   2   3   >