[Bug 1846451] Re: K800 keyboard no longer works when attached to a VM

2020-02-23 Thread Gerd Hoffmann
Try this: Not fully sure this works for hotplugged devices though. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1846451 Title: K800 keyboard no longer works when attached to a VM Status

Re: The issues about architecture of the COLO checkpoint

2020-02-23 Thread Daniel Cho
Hi Zhang, Thanks for your help. However, did you occur the error which the function qemu_hexdump in colo-compare.c will crash the qemu process while doing operation with network? We are working on VM fault tolerance study and COLO function evalutation first. Currently we did not have a confirmed

Re: [PATCH 2/2] util: add util function buffer_zero_avx512()

2020-02-23 Thread Robert Hoo
Thanks Richard:-) Sorry for late reply. On Thu, 2020-02-13 at 10:20 -0800, Richard Henderson wrote: > On 2/12/20 11:52 PM, Robert Hoo wrote: > > And initialize buffer_is_zero() with it, when Intel AVX512F is > > available on host. > > > > This function utilizes Intel AVX512 fundamental instruction

RE: The issues about architecture of the COLO checkpoint

2020-02-23 Thread Zhanghailiang
Hi Daniel, I have fixed this problem, and send V2, please refer to that series. Thanks, From: Daniel Cho [mailto:daniel...@qnap.com] Sent: Thursday, February 20, 2020 11:52 AM To: Zhang, Chen Cc: Dr. David Alan Gilbert ; Zhanghailiang ; qemu-devel@nongnu.org; Jason Wang Subject: Re: The issu

[PATCH V2 7/8] COLO: Migrate dirty pages during the gap of checkpointing

2020-02-23 Thread zhanghailiang
We can migrate some dirty pages during the gap of checkpointing, by this way, we can reduce the amount of ram migrated during checkpointing. Signed-off-by: zhanghailiang --- migration/colo.c | 73 -- migration/migration.h | 1 + migration/trace-eve

[PATCH V2 8/8] migration/colo: Only flush ram cache while do checkpoint

2020-02-23 Thread zhanghailiang
After add migrating ram backgroud, we will call ram_load for this process, but we should not flush ram cache during this process. Move the flush action to the right place. Signed-off-by: zhanghailiang --- migration/colo.c | 1 + migration/ram.c | 5 + migration/ram.h | 1 + 3 files changed

[PATCH V2 4/8] COLO: Optimize memory back-up process

2020-02-23 Thread zhanghailiang
This patch will reduce the downtime of VM for the initial process, Privously, we copied all these memory in preparing stage of COLO while we need to stop VM, which is a time-consuming process. Here we optimize it by a trick, back-up every page while in migration process while COLO is enabled, thoug

[PATCH V2 3/8] savevm: Don't call colo_init_ram_cache twice

2020-02-23 Thread zhanghailiang
This helper has been called twice which is wrong. Left the one where called while get COLO enable message from source side. Signed-off-by: zhanghailiang --- migration/migration.c | 5 - 1 file changed, 5 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 06d1ff9d5

[PATCH V2 2/8] migration/colo: wrap incoming checkpoint process into new helper

2020-02-23 Thread zhanghailiang
Split checkpoint incoming process into a helper. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 260 --- 1 file changed, 133 insertions(+), 127 deletions(-) diff --git a/migration/colo.c b/migration/colo.c ind

[PATCH V2 0/8] Optimize VM's downtime while do checkpoint in COLO

2020-02-23 Thread zhanghailiang
This series try to tries to reduce VM's pause time while do checkpoint in COLO state. Here, we use two methods to reduce the downtime during COLO stage: The first one is to reduce the time of backup PVM's memory into cache, Instread of doing this once time backup all PVM's memory when VM is stop

[PATCH V2 1/8] migration: fix COLO broken caused by a previous commit

2020-02-23 Thread zhanghailiang
This commit "migration: Create migration_is_running()" broke COLO. Becuase there is a process broken by this commit. colo_process_checkpoint ->colo_do_checkpoint_transaction ->migrate_set_block_enabled ->qmp_migrate_set_capabilities It can be fixed by make COLO process as an exception, M

[PATCH V2 6/8] migration: recognize COLO as part of activating process

2020-02-23 Thread zhanghailiang
We will migrate parts of dirty pages backgroud lively during the gap time of two checkpoints, without this modification, it will not work because ram_save_iterate() will check it before send RAM_SAVE_FLAG_EOS at the end of it. Signed-off-by: zhanghailiang --- migration/migration.c | 1 + 1 file

[PATCH V2 5/8] ram/colo: only record bitmap of dirty pages in COLO stage

2020-02-23 Thread zhanghailiang
It is only need to record bitmap of dirty pages while goes into COLO stage. Signed-off-by: zhanghailiang --- migration/ram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index ebf9e6ba51..1b3f423351 100644 --- a/migration/ram.c ++

[PATCH RESEND 3/3] util/pty: fix a null pointer reference in qemu_openpty_raw

2020-02-23 Thread Longpeng(Mike)
From: Longpeng q_ptsname may failed ane return null, so use the returned pointer as the param of strcpy will cause null pointer deference. Use the return string of openpty instead of call ptsname. Signed-off-by: Longpeng --- util/qemu-openpty.c | 10 ++ 1 file changed, 2 insertions(+),

[PATCH RESEND 2/3] vhost: fix a null pointer reference of vhost_log

2020-02-23 Thread Longpeng(Mike)
From: Longpeng vhost_log_alloc() may fails and returned pointer of log is null. However there're two places derefernce the return pointer without check. Signed-off-by: Longpeng --- hw/virtio/vhost.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/vir

[PATCH RESEND 1/3] vfio/pci: fix a null pointer reference in vfio_rom_read

2020-02-23 Thread Longpeng(Mike)
From: Longpeng vfio_pci_load_rom() maybe failed and then the vdev->rom is NULL in some situation (though I've not encountered yet), maybe we should avoid the VM abort. Signed-off-by: Longpeng --- hw/vfio/pci.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw

[PATCH RESEND 0/3] fix some warnings by static code scan tool

2020-02-23 Thread Longpeng(Mike)
From: Longpeng Hi guys, Our tool find some potential issues in QEMU source code, maybe they're misreported, hope you could have a look at them. Longpeng (Mike) (3): vfio/pci: fix a null pointer reference in vfio_rom_read vhost: fix a null pointer reference of vhost_log util/pty: fix a null

[PATCH] target/i386/hax-posix: fix two 'format-truncation' compile warnings

2020-02-23 Thread pannengyuan
From: Pan Nengyuan Fix compile warnings: /mnt/sdb/qemu-new/qemu_test/qemu/target/i386/hax-posix.c:124:56: error: ‘%02d’ directive output may be truncated writing between 2 and 11 bytes into a region of size 3 [-Werror=format-truncation=] snprintf(name, sizeof HAX_VM_DEVFS, "/dev/hax_vm/vm%

Re: [PATCH v2] net: tulip: check frame size and r/w data length

2020-02-23 Thread Jason Wang
On 2020/2/17 下午7:38, P J P wrote: From: Prasad J Pandit Tulip network driver while copying tx/rx buffers does not check frame size against r/w data length. This may lead to OOB buffer access. Add check to avoid it. Reported-by: Li Qiang Reported-by: Ziming Zhang Signed-off-by: Prasad J Pan

[PATCH] hw/arm: Use TYPE_PL011 to create serial port

2020-02-23 Thread Gavin Shan
This uses TYPE_PL011 when creating the serial port, to make the code a bit more atomatic. Signed-off-by: Gavin Shan --- hw/arm/sbsa-ref.c| 3 ++- hw/arm/virt.c| 3 ++- hw/arm/xlnx-versal.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/

RE: [PATCH 3/3] COLO: Optimize memory back-up process

2020-02-23 Thread Zhanghailiang
Hi Dave, > -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Friday, February 21, 2020 2:25 AM > To: Zhanghailiang > Cc: qemu-devel@nongnu.org; quint...@redhat.com; chen.zh...@intel.com; > daniel...@qnap.com > Subject: Re: [PATCH 3/3] COLO: Optimize me

RE: [PATCH 2/3] COLO: Migrate dirty pages during the gap of checkpointing

2020-02-23 Thread Zhanghailiang
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Thursday, February 20, 2020 2:51 AM > To: Zhanghailiang > Cc: qemu-devel@nongnu.org; quint...@redhat.com; chen.zh...@intel.com; > daniel...@qnap.com > Subject: Re: [PATCH 2/3] COLO: Migrate dirty pages

[PATCH v2 0/2] delete virtio queues in vhost-user-blk-unrealize

2020-02-23 Thread pannengyuan
From: Pan Nengyuan This series patch fix memleaks when detaching vhost-user-blk device. 1. use old virtio_del_queue to fix memleaks, it's easier for stable branches to merge. As the discussion in https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02903.html 2. convert virtio_del_qu

[PATCH v2 2/2] vhost-use-blk: convert to new virtio_delete_queue

2020-02-23 Thread pannengyuan
From: Pan Nengyuan use the new virtio_delete_queue function to cleanup. Signed-off-by: Pan Nengyuan --- V2->V1: - rename vqs to vhost_vqs to avoid confusing with virtqs (suggented by Stefan Hajnoczi) --- hw/block/vhost-user-blk.c | 19 +++ include/hw/virtio/vhost-user

[PATCH v2 1/2] vhost-user-blk: delete virtioqueues in unrealize to fix memleaks

2020-02-23 Thread pannengyuan
From: Pan Nengyuan virtio queues forgot to delete in unrealize, and aslo error path in realize, this patch fix these memleaks, the leak stack is as follow: Direct leak of 114688 byte(s) in 16 object(s) allocated from: #0 0x7f24024fdbf0 in calloc (/lib64/libasan.so.3+0xcabf0) #1 0x7f24016

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-23 Thread Gavin Shan
On 2/21/20 8:46 PM, Philippe Mathieu-Daudé wrote: On 2/21/20 10:37 AM, Philippe Mathieu-Daudé wrote: Cc'ing Igor & Drew. On 2/21/20 7:28 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200221044908.266883-1-gs...@redhat.com/  > === TEST SCRIPT BEGIN === #!/bin/bash ma

[PATCH v2] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-23 Thread Gavin Shan
The depth of TxFIFO can be 1 or 16 depending on LCR[4]. The TxFIFO is disabled when its depth is 1. It's nice to have TxFIFO enabled if possible because more characters can be piled and transmitted at once, which would have less overhead. Besides, we can be blocked because of qemu_chr_fe_write_all(

Re: [PATCH] virtiofsd/helper: Add shared/no_shared options to help message

2020-02-23 Thread Xiao Yang
Hi David, Do you have any comment on this patch? :-) Cc qemu-devel@nongnu.org Best Regards, Xiao Yang On 2020/2/10 18:44, Xiao Yang wrote: > From: Xiao Yang > > Also add a hint that user should start 'ireg' daemon before using shared > cache. > > Signed-off-by: Xiao Yang > --- > tools/virtio

Re: [PATCH v4] Implement the Screamer sound chip for the mac99 machine type

2020-02-23 Thread Programmingkid
> On Feb 23, 2020, at 12:00 PM, qemu-ppc-requ...@nongnu.org wrote: > > Message: 2 > Date: Sun, 23 Feb 2020 12:43:37 +0300 > From: Andrew Randrianasulu > To: hsp.c...@gmail.com, qemu-devel@nongnu.org, "qemu-...@nongnu.org" > > Subject: Re: [PATCH v4] Implement the Screamer sound chip for

[RESEND PATCH v2] migration/throttle: Add throttle-trig-thres migration parameter

2020-02-23 Thread Keqian Zhu
Currently, if the bytes_dirty_period is more than the 50% of bytes_xfer_period, we start or increase throttling. If we make this percentage higher, then we can tolerate higher dirty rate during migration, which means less impact on guest. The side effect of higher percentage is longer migration ti

[PATCH] migration/throttle: Add throttle-trig-thres migration parameter

2020-02-23 Thread Keqian Zhu
Currently, if the bytes_dirty_period is more than the 50% of bytes_xfer_period, we start or increase throttling. If we make this percentage higher, then we can tolerate higher dirty rate during migration, which means less impact on guest. The side effect of higher percentage is longer migration ti

Re: [PATCH v4] Implement the Screamer sound chip for the mac99 machine type

2020-02-23 Thread Programmingkid
> On Feb 23, 2020, at 9:17 AM, Howard Spoelstra wrote: > > > > On Fri, Feb 21, 2020 at 1:09 PM Howard Spoelstra wrote: > > > The current screamer-enabled builds for OSX and Windows are on > www.emaculation.com ;-) > As you see from testing, there are reasons why the patches from Mark's >

Re: [PATCH] migration/throttle: Add throttle-trig-thres migration parameter

2020-02-23 Thread zhukeqian
Hi, Eric On 2020/2/21 22:14, Eric Blake wrote: > On 2/20/20 8:57 PM, Keqian Zhu wrote: >> Currently, if the bytes_dirty_period is more than the 50% of >> bytes_xfer_period, we start or increase throttling. >> >> If we make this percentage higher, then we can tolerate higher >> dirty rate during mi

RE: RFC: Split EPT huge pages in advance of dirty logging

2020-02-23 Thread Zhoujian (jay)
> -Original Message- > From: Peter Feiner [mailto:pfei...@google.com] > Sent: Saturday, February 22, 2020 8:19 AM > To: Junaid Shahid > Cc: Ben Gardon ; Zhoujian (jay) > ; Peter Xu ; > k...@vger.kernel.org; qemu-devel@nongnu.org; pbonz...@redhat.com; > dgilb...@redhat.com; quint...@redha

Re: [PATCH] hw/char/pl011: Output characters using best-effort mode

2020-02-23 Thread Gavin Shan
Hi Marc, On 2/21/20 8:09 PM, Marc Zyngier wrote: On 2020-02-21 04:24, Gavin Shan wrote: On 2/20/20 9:10 PM, Peter Maydell wrote: On Thu, 20 Feb 2020 at 09:10, Marc Zyngier wrote: On 2020-02-20 06:01, Gavin Shan wrote: This fixes the issue by using newly added API qemu_chr_fe_try_write_all()

Re: [PATCH] hw/char/pl011: Output characters using best-effort mode

2020-02-23 Thread Gavin Shan
On 2/22/20 5:15 AM, Paolo Bonzini wrote: On 21/02/20 14:14, Peter Maydell wrote: The initial case reported by Gavin in this thread is "-serial tcp:127.0.0.1:50900" with the other end being a program which listens on TCP port 50900 and then sleeps without accepting any incoming connections, which

[RFC PATCH v2 2/2] hw/arm/integratorcp: Map a CFI parallel flash

2020-02-23 Thread Philippe Mathieu-Daudé
The Linux kernel displays errors why trying to detect the flash: Linux version 4.16.0 (linus@genomnajs) (gcc version 7.2.1 20171011 (Linaro GCC 7.2-2017.11)) #142 PREEMPT Wed May 9 13:24:55 CEST 2018 CPU: ARM926EJ-S [41069265] revision 5 (ARMv5TEJ), cr=00093177 CPU: VIVT data cache, VIVT in

[PATCH v2 1/2] hw/arm/integratorcp: Map the audio codec controller

2020-02-23 Thread Philippe Mathieu-Daudé
The Linux kernel displays errors why trying to detect the PL041 audio interface: Linux version 4.16.0 (linus@genomnajs) (gcc version 7.2.1 20171011 (Linaro GCC 7.2-2017.11)) #142 PREEMPT Wed May 9 13:24:55 CEST 2018 CPU: ARM926EJ-S [41069265] revision 5 (ARMv5TEJ), cr=00093177 CPU: VIVT dat

[PATCH v2 0/2] hw/arm/integratorcp: Map Audio controller and parallel flash

2020-02-23 Thread Philippe Mathieu-Daudé
While looking whether Thomas's test patch [*] requires a respin or not, I noticed we could complete the integrator model. Thomas patch still applies properly ;) Since v1: - Added uncommitted Kconfig - Use hobbyist git-identity [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675828.html

[PATCH 0/2] hw/arm/integratorcp: Map Audio controller and parallel flash

2020-02-23 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé While looking whether Thomas's test patch [*] requires a respin or not, I noticed we could complete the integrator model. Thomas patch still applies properly ;) [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675828.html Philippe Mathieu-Daudé (2): hw/ar

Re: [PATCH] hw/char/pl011: Output characters using best-effort mode

2020-02-23 Thread Gavin Shan
On 2/21/20 11:44 PM, Peter Maydell wrote: On Fri, 21 Feb 2020 at 11:44, Paolo Bonzini wrote: On 21/02/20 11:21, Peter Maydell wrote: Before you do that, I would suggest investigating: * is this a problem we've already had on x86 and that there is a standard solution for Disconnected so

[PATCH 1/2] hw/arm/integratorcp: Map the audio codec controller

2020-02-23 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The Linux kernel displays errors why trying to detect the PL041 audio interface: Linux version 4.16.0 (linus@genomnajs) (gcc version 7.2.1 20171011 (Linaro GCC 7.2-2017.11)) #142 PREEMPT Wed May 9 13:24:55 CEST 2018 CPU: ARM926EJ-S [41069265] revision 5 (ARMv5TE

[RFC PATCH 2/2] hw/arm/integratorcp: Map a CFI parallel flash

2020-02-23 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The Linux kernel displays errors why trying to detect the flash: Linux version 4.16.0 (linus@genomnajs) (gcc version 7.2.1 20171011 (Linaro GCC 7.2-2017.11)) #142 PREEMPT Wed May 9 13:24:55 CEST 2018 CPU: ARM926EJ-S [41069265] revision 5 (ARMv5TEJ), cr=00093177

[PATCH 0/2] hw/arm/gumstix: Trivial cleanups

2020-02-23 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Two house keeping patches while looking at the Gumstix boards, to make the code slightly more readable/documented. Philippe Mathieu-Daudé (2): hw/arm/gumstix: Simplify since the machines are little-endian only hw/arm/gumstix: Use the IEC binary prefix definitions

[PATCH 2/2] hw/arm/gumstix: Use the IEC binary prefix definitions

2020-02-23 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé IEC binary prefixes ease code review: the unit is explicit. Add a comment describing the Connex uses a Numonyx RC28F128J3F75 flash, and the Verdex uses a Micron RC28F256P30TFA. Correct the Verdex machine description (we model the 'Pro' board). Signed-off-by: Philip

[PATCH 1/2] hw/arm/gumstix: Simplify since the machines are little-endian only

2020-02-23 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé As the Connex and Verdex machines only boot in little-endian, we can simplify the code. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/gumstix.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/hw/arm/gumstix.c b/hw/arm/gum

Re: [RFC v3 3/3] ACPI/unit-test: Add a new test for pxb-pcie for arm

2020-02-23 Thread Michael S. Tsirkin
On Sat, Feb 22, 2020 at 09:40:07AM +, miaoyubo wrote: > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Friday, February 21, 2020 7:19 PM > > To: miaoyubo > > Cc: peter.mayd...@linaro.org; shannon.zha...@gmail.com; Xiexiangyou > > ; imamm...@redh

[PATCH 2/2] net/colo-compare.c: Expose "expired_scan_cycle" to user

2020-02-23 Thread Zhang Chen
From: Zhang Chen The "expired_scan_cycle" determines colo-compare scan expired net packet cycle. Signed-off-by: Zhang Chen --- net/colo-compare.c | 48 +++--- qemu-options.hx| 3 ++- 2 files changed, 47 insertions(+), 4 deletions(-) diff --git a/ne

[PATCH 0/2] net/colo-compare.c: Expose more COLO internal

2020-02-23 Thread Zhang Chen
From: Zhang Chen Make a way to config COLO parameter detailed according to user cases and environment. Zhang Chen (2): net/colo-compare.c: Expose "compare_timeout" to user net/colo-compare.c: Expose "expired_scan_cycle" to user net/colo-compare.c | 95 ++

[PATCH 1/2] net/colo-compare.c: Expose "compare_timeout" to user

2020-02-23 Thread Zhang Chen
From: Zhang Chen The "compare_timeout" determines the max time to hold the primary net packet. This patch expose the "compare_timeout", make user can adjest this value according to the specific application scenario. QMP command demo: { "execute": "qom-get", "arguments": { "path": "/

Re: [PATCH 1/1] target/riscv: Fix VS mode interrupts forwarding.

2020-02-23 Thread Jose Martins
No problem. But I'm failing to see what you mean. My reasoning was: the specification mandates that only VS mode interrupt bits are writable in hideleg, all the others must be hardwired to zero. This means the hypervisor can't really delegate S mode interrupts as you are saying. So, if this is impl

Re: [PATCH 1/1] target/riscv: Fix VS mode interrupts forwarding.

2020-02-23 Thread Jose Martins
Hello rajnesh, I had already submitted almost this exact patch a few weeks ago. Jose On Sun, 23 Feb 2020 at 13:51, wrote: > > From: Rajnesh Kanwal > > Currently riscv_cpu_local_irq_pending is used to find out pending > interrupt and VS mode interrupts are being shifted to represent > S mode in

RE: The issues about architecture of the COLO checkpoint

2020-02-23 Thread Zhang, Chen
From: Daniel Cho Sent: Thursday, February 20, 2020 11:49 AM To: Zhang, Chen Cc: Dr. David Alan Gilbert ; Zhanghailiang ; qemu-devel@nongnu.org; Jason Wang Subject: Re: The issues about architecture of the COLO checkpoint Hi Zhang, Thanks, I will configure on code for testing first. However

Re: [PATCH] hw/ide: Remove status register read side effect

2020-02-23 Thread BALATON Zoltan
On Sun, 23 Feb 2020, jasper.low...@bt.com wrote: ide_exec_cmd 0.461 pid=147030 bus=0x55b77f922d10 state=0x55b77f922d98 cmd=0xef The command is run here if I'm not mistaken Does this set the irq right away on QEMU where on real hadware this may take some time? Not sure if that's a problem but

Re: [PATCH 1/1] target/riscv: Fix VS mode interrupts forwarding.

2020-02-23 Thread Rajnesh Kanwal
Hello Jose, Sorry I didn't see that as it hadn't became a part of the port. I don't know how they proceed with same patches. Just to add, there is a minor problem with your patch. The cause value should only be decremented by one for VS mode interrupts. In case if hypervisor has delegated S mode

Re: [PATCH v4] Implement the Screamer sound chip for the mac99 machine type

2020-02-23 Thread Howard Spoelstra
On Fri, Feb 21, 2020 at 1:09 PM Howard Spoelstra wrote: > > > The current screamer-enabled builds for OSX and Windows are on > www.emaculation.com ;-) > As you see from testing, there are reasons why the patches from Mark's > screamer branch are not in master yet, and these have not all been > ad

[PATCH 1/1] target/riscv: Fix VS mode interrupts forwarding.

2020-02-23 Thread rajnesh . kanwal49
From: Rajnesh Kanwal Currently riscv_cpu_local_irq_pending is used to find out pending interrupt and VS mode interrupts are being shifted to represent S mode interrupts in this function. So when the cause returned by this function is passed to riscv_cpu_do_interrupt to actually forward the interr

[PATCH RESEND v31 21/22] BootLinuxConsoleTest: Test the RX-Virt machine

2020-02-23 Thread Yoshinori Sato
From: Philippe Mathieu-Daudé Add two tests for the rx-virt machine, based on the recommended test setup from Yoshinori Sato: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03586.html - U-Boot prompt - Linux kernel with Sash shell These are very quick tests: $ avocado run -t arch:rx

[PATCH RESEND v31 15/22] hw/timer: RX62N internal timer modules

2020-02-23 Thread Yoshinori Sato
renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philip

[PATCH RESEND v31 04/22] target/rx: TCG translation

2020-02-23 Thread Yoshinori Sato
This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-2-ys...@users

[PATCH RESEND v31 16/22] hw/char: RX62N serial communication interface (SCI)

2020-02-23 Thread Yoshinori Sato
This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-8-ys...@users.sourcef

[PATCH RESEND v31 07/22] target/rx: RX disassembler

2020-02-23 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-5-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/disas/dis-asm.h |5 + target/rx/disas.c | 1480 +

[PATCH RESEND v31 17/22] hw/rx: RX Target hardware definition

2020-02-23 Thread Yoshinori Sato
rx62n - RX62N cpu. rx-virt - RX QEMU virtual target. Signed-off-by: Yoshinori Sato Message-Id: <20190616142836.10614-17-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-9-ys...@users.sourceforge.jp> Signed-off-b

[PATCH RESEND v31 14/22] hw/intc: RX62N interrupt controller (ICUa)

2020-02-23 Thread Yoshinori Sato
This implementation supported only ICUa. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-6-ys...@users.sourcefo

[PATCH RESEND v31 09/22] target/rx: Replace operand with prt_ldmi in disassembler

2020-02-23 Thread Yoshinori Sato
From: Richard Henderson This has consistency with prt_ri(). It loads all data before beginning output. It uses exactly one call to prt() to emit the full instruction. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49

[PATCH RESEND v31 06/22] target/rx: CPU definition

2020-02-23 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Message-Id: <20190616142836.10614-4-ys...@users.sourceforge.jp> Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-4-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson [PMD: Use newer QOM style, split cpu-qom.h, restrict access to extable a

[PATCH RESEND v31 20/22] Add rx-softmmu

2020-02-23 Thread Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-17-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson pick ed65c02993 target/rx: Add RX to SysEmuTarget pick 01372568ae tests: Add rx to machine-none-t

[PATCH RESEND v31 05/22] target/rx: TCG helper

2020-02-23 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Message-Id: <20190616142836.10614-3-ys...@users.sourceforge.jp> Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-3-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson [PMD: Removed tlb_fill, extracted from

[PATCH RESEND v31 19/22] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core

2020-02-23 Thread Yoshinori Sato
From: Philippe Mathieu-Daudé While the VIRT machine can use different microcontrollers, the RX62N microcontroller is tied to the RX62N CPU core. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato --- hw/rx/rx-virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/rx/

[PATCH RESEND v31 12/22] target/rx: Collect all bytes during disassembly

2020-02-23 Thread Yoshinori Sato
From: Richard Henderson Collected, to be used in the next patch. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-23-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson

[PATCH RESEND v31 18/22] hw/rx: Honor -accel qtest

2020-02-23 Thread Yoshinori Sato
From: Richard Henderson Issue an error if no kernel, no bios, and not qtest'ing. Fixes make check-qtest-rx: test/qom-test. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-16-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signe

[PATCH RESEND v31 22/22] qemu-doc.texi: Add RX section.

2020-02-23 Thread Yoshinori Sato
Describe emulated target specification. And two examples. Signed-off-by: Yoshinori Sato --- qemu-doc.texi | 44 1 file changed, 44 insertions(+) diff --git a/qemu-doc.texi b/qemu-doc.texi index 33b9597b1d..d80a9c64f7 100644 --- a/qemu-doc.texi +++ b/

[PATCH RESEND v31 13/22] target/rx: Dump bytes for each insn during disassembly

2020-02-23 Thread Yoshinori Sato
From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <201906070

[PATCH v31 23/23] fix warning.

2020-02-23 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- hw/rx/rx-virt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c index 6cf7936201..4ee6647728 100644 --- a/hw/rx/rx-virt.c +++ b/hw/rx/rx-virt.c @@ -90,8 +90,10 @@ static void rxvirt_init(MachineState *ma

[PATCH RESEND v31 08/22] target/rx: Disassemble rx_index_addr into a string

2020-02-23 Thread Yoshinori Sato
From: Richard Henderson We were eliding all zero indexes. It is only ld==0 that does not have an index in the instruction. This also allows us to avoid breaking the final print into multiple pieces. Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-1

[PATCH RESEND v31 03/22] hw/registerfields.h: Add 8bit and 16bit register macros

2020-02-23 Thread Yoshinori Sato
From: Philippe Mathieu-Daudé Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-11-ys...@users.sourceforge.jp> Tested-by: Philippe Math

[PATCH RESEND v31 00/22] Add RX archtecture support

2020-02-23 Thread Yoshinori Sato
. Squashed v19 changes. Changes for v19. Follow tcg changes. Cleanup cpu.c. simplify rx_cpu_class_by_name and rx_load_image move to rx-virt. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20200223 Testing binaries bellow. u-boot Download - https://osdn.net

[PATCH RESEND v31 11/22] target/rx: Emit all disassembly in one prt()

2020-02-23 Thread Yoshinori Sato
From: Richard Henderson Many of the multi-part prints have been eliminated by previous patches. Eliminate the rest of them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-22-ys...@users.sourceforge.jp> Tested-by

[PATCH RESEND v31 10/22] target/rx: Use prt_ldmi for XCHG_mr disassembly

2020-02-23 Thread Yoshinori Sato
From: Richard Henderson Note that the ld == 3 case handled by prt_ldmi is decoded as XCHG_rr and cannot appear here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-21-ys...@users.sourceforge.jp> Tested-by: Philip

[PATCH RESEND v31 02/22] qemu/bitops.h: Add extract8 and extract16

2020-02-23 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-10-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/qemu/bitops.h | 38 +

[PATCH RESEND v31 01/22] MAINTAINERS: Add RX

2020-02-23 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-18-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINER

Re: [PATCH v4] Implement the Screamer sound chip for the mac99 machine type

2020-02-23 Thread Andrew Randrianasulu
Just thought I must share my uneducated guess on issue reported at https://www.emaculation.com/forum/viewtopic.php?f=34&t=9820 > Please note that running with 1024Mb of memory will make sound stop working > in Mac OS 9.x. So run with less memory. > As will running without virtual memory. My gues

Re: [PATCH v3 2/3] hw: Make MachineClass::is_default a boolean type

2020-02-23 Thread Paolo Bonzini
On 07/02/20 15:25, Michael S. Tsirkin wrote: @@ -841,7 +841,7 @@ static void sun4v_class_init(ObjectClass *oc, void *data) mc->desc = "Sun4v platform"; mc->init = sun4v_init; mc->block_default_type = IF_IDE; -mc->max_cpus = 1; /* XXX for now */

Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-02-23 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and > does corresponding changes in code (look for details in > include/qapi/error.h) > > Usage example: > spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ > --macro-file scr

Re: [PATCH v31 00/22] Add RX archtecture support

2020-02-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v31 00/22] Add RX archtecture support Message-id: 20200223065102.61652-1-ys...@users.source

Re: [PATCH v16 00/10] VIRTIO-IOMMU device

2020-02-23 Thread Michael S. Tsirkin
On Fri, Feb 21, 2020 at 02:27:30PM +, Peter Maydell wrote: > On Fri, 14 Feb 2020 at 13:28, Eric Auger wrote: > > > > This series implements the QEMU virtio-iommu device. > > > > This matches the v0.12 spec (voted) and the corresponding > > virtio-iommu driver upstreamed in 5.3. All kernel depe

Re: [PATCH v31 00/22] Add RX archtecture support

2020-02-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v31 00/22] Add RX archtecture support Message-id: 20200223065102.61652-1-ys...@users.source

Re: [PATCH v31 00/22] Add RX archtecture support

2020-02-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v31 00/22] Add RX archtecture support Message-id: 20200223065102.61652-1-ys...@users.source