Re: [PATCH] mailmap: Add more entries to sanitize 'git log' output

2020-01-17 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Most of these developers have the Signed-off-by tag properly > written, but not the author/commiter name. Fix this. > Also we incorrectly wrote Arei Gonglei name, update and reorder. > > git-log does not use this file by default until you specify the > --use-mailm

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-17 Thread Markus Armbruster
John Snow writes: > On 1/17/20 2:07 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 1/16/20 3:25 PM, Markus Armbruster wrote: Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" modules" switched QAPISchema.visit() from for entity in self._

Re: [PATCH v7 01/11] add device_legacy_reset function to prepare for reset api change

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: Provide a temporary device_legacy_reset function doing what device_reset does to prepare for the transition with Resettable API. All occurrence of device_reset in the code tree are also replaced by device_legacy_reset. The new resettable API has different

Re: [PATCH v7 08/11] hw/core: deprecate old reset functions and introduce new ones

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: Deprecate device_legacy_reset(), qdev_reset_all() and qbus_reset_all() to be replaced by new functions device_cold_reset() and bus_cold_reset() which uses resettable API. Also introduce resettable_cold_reset_fn() which may be used as a replacement for qdev

Re: [PATCH v7 07/11] hw/core/qdev: update hotplug reset regarding resettable

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: This commit make use of the resettable API to reset the device being hotplugged when it is realized. Also it ensures it is put in a reset state coherent with the parent it is plugged into. Note that there is a difference in the reset. Instead of resetting

Re: [PATCH v7 05/11] hw/core/resettable: add support for changing parent

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: Add a function resettable_change_parent() to do the required plumbing when changing the parent a of Resettable object. We need to make sure that the reset state of the object remains coherent with the reset state of the new parent. We make the 2 following

Re: [PATCH v7 03/11] hw/core: create Resettable QOM interface

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: This commit defines an interface allowing multi-phase reset. This aims to solve a problem of the actual single-phase reset (built in DeviceClass and BusClass): reset behavior is dependent on the order in which reset handlers are called. In particular doing

Re: [PATCH v7 03/11] hw/core: create Resettable QOM interface

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/15/20 1:36 PM, Damien Hedde wrote: This commit defines an interface allowing multi-phase reset. This aims to solve a problem of the actual single-phase reset (built in DeviceClass and BusClass): reset behavior is dependent on the order in which reset handlers are called. In particular doing

Re: [PATCH] audio/dsound: fix invalid parameters error

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 7:26 PM, KJ Liew wrote: QEMU Windows has broken dsound backend since the rewrite of audio API in version 4.2.0. Both playback and capture buffers failed to lock with invalid parameters error. Fixes: 7fa9754ac88 (dsoundaudio: port to the new audio backend api) Cc'ing Zoltán who wrote

Re: [PATCH v1] vnc: fix VNC artifacts

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 10:43 PM, Cameron Esfahani via wrote: I’m new to this process, what are the next steps? Assuming your patch is in a branch named vncfix_v1: 1/ Start new branch based on the commit previous to your patch: - git checkout -b vncfix_v2 vncfix_v1~ 2/ Revert the offending patch, expla

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 8:23 PM, Richard Henderson wrote: On 1/17/20 8:50 AM, Philippe Mathieu-Daudé wrote: On Fri, Jan 17, 2020 at 2:53 AM Richard Henderson wrote: The PA-RISC 1.1 specification says that LDCW must be aligned mod 16 or the operation is undefined. However, real hardware only generates an

Re: [PATCH v3 0/7] gpio: Add GPIO Aggregator/Repeater

2020-01-17 Thread Eugeniu Rosca
Hi Geert, On Wed, Nov 27, 2019 at 09:42:46AM +0100, Geert Uytterhoeven wrote: > - Create aggregators: > > $ echo e6052000.gpio 19,20 \ > > /sys/bus/platform/drivers/gpio-aggregator/new_device > > gpio-aggregator gpio-aggregator.0: gpio 0 => gpio-953 (gpio-aggregator.0) > gp

[Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2020-01-17 Thread Richard Henderson
Another proposed patch: https://patchew.org/QEMU/20200117230245.5040-1-richard.hender...@linaro.org/ ** Changed in: qemu (Ubuntu) Assignee: (unassigned) => Richard Henderson (rth) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH] linux-user: Reserve space for brk

2020-01-17 Thread Warner Losh
On Fri, Jan 17, 2020 at 4:03 PM Richard Henderson < richard.hender...@linaro.org> wrote: > With bad luck, we can wind up with no space at all for brk, > which will generally cause the guest malloc to fail. > ... > The choice of 16MB is somewhat arbitrary. It's enough for libc > to get going, but

[PATCH] linux-user: Reserve space for brk

2020-01-17 Thread Richard Henderson
With bad luck, we can wind up with no space at all for brk, which will generally cause the guest malloc to fail. This bad luck is easier to come by with ET_DYN (PIE) binaries, where either the stack or the interpreter (ld.so) gets placed immediately after the main executable. But there's nothing

Re: [PATCH 036/104] virtiofsd: passthrough_ll: add fd_map to hide file descriptors

2020-01-17 Thread Masayoshi Mizuma
On Thu, Dec 12, 2019 at 04:37:56PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > Do not expose file descriptor numbers to clients. This prevents the > abuse of internal file descriptors (like stdin/stdout). > > Signed-off-by: Stefan Hajnoczi > dgilbert: > Added lseek

[Bug 1860053] Re: Possible lack of precision when calling clock_gettime via vDSO on user mode ppc64le

2020-01-17 Thread Fabiano Rosas
Since there is no vdso, the Go code goes into the syscall fallback: MOVDruntime·vdsoClockgettimeSym(SB), R12// Check for VDSO availability CMP R12, R0 BEQ fallback (...) fallback: ADD $32, R1, R4 SYSCALL $SYS_clock_gettime MOVD32(R1), R3 MOVD

Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl

2020-01-17 Thread Alexandre Belloni
Hi, Quick answers to your very good questions below: On 17/01/2020 21:50:34+0100, Aleksandar Markovic wrote: > Alexandre (and Arnd too, or any other person knowledgeable in the area), > > I just need to clarify a couple of details with you, please. > > Firstly, here is what man page rtc(4) says

Re: [PATCH 034/104] virtiofsd: passthrough_ll: add ino_map to hide lo_inode pointers

2020-01-17 Thread Masayoshi Mizuma
On Thu, Dec 12, 2019 at 04:37:54PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > Do not expose lo_inode pointers to clients. > > Signed-off-by: Stefan Hajnoczi > --- > tools/virtiofsd/passthrough_ll.c | 144 --- > 1 file changed, 114 inserti

Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl

2020-01-17 Thread Arnd Bergmann
On Fri, Jan 17, 2020 at 9:50 PM Aleksandar Markovic wrote: > Alexandre (and Arnd too, or any other person knowledgeable in the area), > > I just need to clarify a couple of details with you, please. > > Firstly, here is what man page rtc(4) says: > > "The /dev/rtc (or /dev/rtc0, /dev/rtc1, etc.)

Re: [PATCH 033/104] virtiofsd: passthrough_ll: add lo_map for ino/fh indirection

2020-01-17 Thread Masayoshi Mizuma
On Thu, Dec 12, 2019 at 04:37:53PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > A layer of indirection is needed because passthrough_ll cannot expose > pointers or file descriptor numbers to untrusted clients. Malicious > clients could send invalid pointers or file desc

Re: [PATCH v1] vnc: fix VNC artifacts

2020-01-17 Thread Cameron Esfahani via
I’m new to this process, what are the next steps? Cameron Esfahani di...@apple.com > On Jan 16, 2020, at 11:47 PM, Gerd Hoffmann wrote: > > On Thu, Jan 16, 2020 at 07:50:58PM -0800, Cameron Esfahani wrote: >> Remove VNC optimization to reencode framebuffer update as raw if it's >> smaller than

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread John David Anglin
This is not related to the patch but there is one other corner issue with the load and clear instructions. When the target register is GR0, the instruction may be implemented as a normal load and clear which clears memory, or it may be aliased to the equivalent-sized load instruction, in which

help

2020-01-17 Thread Fairouz Fakhfakh
Hello, I would like to use qemu to install a virtual machine (VM) in Ubuntu. I need a minimal VM which contains only jdk (openjdk). Can someone help me, please. Thank you in advance.

Re: [PATCH 039/104] virtiofsd: Plumb fuse_bufvec through to do_write_buf

2020-01-17 Thread Masayoshi Mizuma
On Thu, Dec 12, 2019 at 04:37:59PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Let fuse_session_process_buf_int take a fuse_bufvec * instead of a > fuse_buf; and then through to do_write_buf - where in the best > case it can pass that straight through to op.wr

Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl

2020-01-17 Thread Aleksandar Markovic
On Thu, Jan 16, 2020 at 1:00 PM Arnd Bergmann wrote: > > On Thu, Jan 16, 2020 at 12:27 PM Aleksandar Markovic > wrote: > > On Thursday, January 16, 2020, Aleksandar Markovic > > wrote: > >> On Wednesday, January 15, 2020, Laurent Vivier wrote: > >>> Le 15/01/2020 à 20:17, Filip Bozuta a écrit

RE: [PATCH v2] uas: fix super speed bMaxPacketSize0

2020-01-17 Thread fys
I am okay with this patch. Thank you. Ben > -Original Message- > From: Gerd Hoffmann > Sent: Friday, January 17, 2020 12:37 AM > To: qemu-devel@nongnu.org > Cc: f...@fysnet.net; Gerd Hoffmann > Subject: [PATCH v2] uas: fix super speed bMaxPacketSize0 > > For usb2 bMaxPacketSize0 is "n

[Bug 1859920] Re: daemoniz not working on MacOS

2020-01-17 Thread JS
I mixed up some thing in #2 above. Please ignore it and use following: --- I tried with following and it work: qemu-system-x86_64 -no-user-config -nodefaults -name u64d01 -M q35,accel=hvf,usb=off,vmport=off -cpu host -smp 4 -m 8192 -overcommit mem-lock=off -overcommit cpu-pm=off -rtc base=utc,cl

[Bug 1859920] Re: daemoniz not working on MacOS

2020-01-17 Thread JS
I tried with following and it work: qemu-system-x86_64 -no-user-config -nodefaults -name u64d01 -M q35,accel=hvf,usb=off,vmport=off -cpu host -smp 4 -m 8192 -overcommit mem-lock=off -overcommit cpu-pm=off -rtc base=utc,clock=host -device virtio-blk-pci,drive=ssd1 -drive id=ssd1,file=/Users/js/code

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Helge Deller
On 17.01.20 20:23, Richard Henderson wrote: > On 1/17/20 8:50 AM, Philippe Mathieu-Daudé wrote: >> On Fri, Jan 17, 2020 at 2:53 AM Richard Henderson >> wrote: >>> >>> The PA-RISC 1.1 specification says that LDCW must be aligned mod 16 >>> or the operation is undefined. However, real hardware only

Re: [PATCH] qemu-img: Add --target-is-zero to convert

2020-01-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200117103434.1363985-1-david.edmond...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200117103434.1363985-1-david.edmond...@oracle.com Type: series Subject: [PATCH] qemu-img: A

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-17 Thread John Snow
On 1/17/20 2:07 AM, Markus Armbruster wrote: > John Snow writes: > >> On 1/16/20 3:25 PM, Markus Armbruster wrote: >>> Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" >>> modules" switched QAPISchema.visit() from >>> >>> for entity in self._entity_list: >>> >>> effec

Re: [PATCH 2/4] linux-user: Use `qemu_log' for strace

2020-01-17 Thread Josh Kunz
On Tue, Jan 14, 2020 at 2:56 AM Alex Bennée wrote: > Could we cut out the middle-man and just qemu_add_log(LOG_STRACE) here > and drop the enable_strace variable. This code has been re-factored based on Laurent's comments. In v2 `enable_strace` is still needed to avoid QEMU_LOG/-d overwriting the

Re: [PATCH 2/4] linux-user: Use `qemu_log' for strace

2020-01-17 Thread Josh Kunz
On Tue, Jan 14, 2020 at 1:09 AM Laurent Vivier wrote: > This is really a special case as the flags are all given at the same > time, could you use directly qemu_set_log() in main()? Fixed in v2. > > +/* Remove (subtract) the given log flags from the current log mask. */ > > +static inline void q

Re: [PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-17 Thread Josh Kunz
On Tue, Jan 14, 2020 at 2:43 AM Alex Bennée wrote: > > As Laurent said I think LOG_UNIMP is perfectly fine for stuff we haven't > done. I don't think any of the cases warrant LOG_GUEST_ERROR. I've replaced `LOG_USER` with `LOG_UNIMP`. Didn't catch that mask at first, LOG_UNIMP is indeed a better

[PATCH v2 4/4] bsd-user: Replace gemu_log with qemu_log

2020-01-17 Thread Josh Kunz
gemu_log is an old logging mechanism used to implement strace logging in the bsd-user tree. It logs directly to stderr and cannot easily be redirected. This change instead causes strace to log via the qemu_log subsystem which has fine-grained logging control, and a centralized mechanism for log red

[PATCH v2 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-17 Thread Josh Kunz
Since most calls to `gemu_log` are actually logging unimplemented features, this change replaces most non-strace calls to `gemu_log` with calls to `qemu_log_mask(LOG_UNIMP, ...)`. This allows the user to easily log to a file, and to mask out these log messages if they desire. Note: This change is

[PATCH v2 2/4] linux-user: Use `qemu_log' for strace

2020-01-17 Thread Josh Kunz
This change switches linux-user strace logging to use the newer `qemu_log` logging subsystem rather than the older `gemu_log` (notice the "g") logger. `qemu_log` has several advantages, namely that it allows logging to a file, and provides a more unified interface for configuration of logging (via

[PATCH v2 0/4] migration: Replace gemu_log with qemu_log

2020-01-17 Thread Josh Kunz
Summary of v2 changes: * Removed backwards-compatibility code for non-strace log statements. * Removed new qemu_log interface for adding or removing fields from the log mask. * Removed LOG_USER and converted all uses (except one) to LOG_UNIMP. * One gemu_log statement was converted to

[PATCH v2 3/4] linux-user: remove gemu_log from the linux-user tree

2020-01-17 Thread Josh Kunz
Now that all uses have been migrated to `qemu_log' it is no longer needed. Signed-off-by: Josh Kunz --- linux-user/main.c | 9 - linux-user/qemu.h | 1 - 2 files changed, 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 8f1d07cdd6..22578b1633 100644 --- a/linux-u

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Richard Henderson
On 1/17/20 8:50 AM, Philippe Mathieu-Daudé wrote: > On Fri, Jan 17, 2020 at 2:53 AM Richard Henderson > wrote: >> >> The PA-RISC 1.1 specification says that LDCW must be aligned mod 16 >> or the operation is undefined. However, real hardware only generates >> an unaligned access trap for unaligne

Re: [PATCH 026/104] virtiofsd: Fast path for virtio read

2020-01-17 Thread Masayoshi Mizuma
On Thu, Dec 12, 2019 at 04:37:46PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Readv the data straight into the guests buffer. > > Signed-off-by: Dr. David Alan Gilbert > With fix by: > Signed-off-by: Eryu Guan > --- > tools/virtiofsd/fuse_lowlevel.c | 5

Re: [PATCH RFC 12/12] migration/rdma: only register the virt-ram block for MultiRDMA

2020-01-17 Thread Dr. David Alan Gilbert
* Zhimin Feng (fengzhim...@huawei.com) wrote: > From: fengzhimin > > The virt-ram block is sent by MultiRDMA, so we only register it for > MultiRDMA channels and main channel don't register the virt-ram block. > > Signed-off-by: fengzhimin You can't specialise on the name of the RAMBlock like

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Philippe Mathieu-Daudé
On Fri, Jan 17, 2020 at 2:53 AM Richard Henderson wrote: > > The PA-RISC 1.1 specification says that LDCW must be aligned mod 16 > or the operation is undefined. However, real hardware only generates > an unaligned access trap for unaligned mod 4. This Linux kernel commit seems relevant: https:

Re: [PATCH 6/6] hw/arm/exynos4210: Connect serial port DMA busy signals with pl330

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 18:29, Guenter Roeck wrote: > > On Fri, Jan 17, 2020 at 01:48:06PM +, Peter Maydell wrote: > > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > > > > > The Exynos4210 serial driver uses an interrupt line to signal if receive > > > data is available. Connect that i

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-17 Thread Dr. David Alan Gilbert
* Miklos Szeredi (mszer...@redhat.com) wrote: > On Thu, Jan 16, 2020 at 5:45 PM Dr. David Alan Gilbert > wrote: > > > > * Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > > > From: Miklos Szeredi > > > > > > > > Signed-off-by: Miklos Szeredi > > > > > > I'm not familiar with qemu conv

Re: [PATCH 4/6] hw/char/exynos4210_uart: Implement receive FIFO

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 18:21, Guenter Roeck wrote: > Doesn't that mean that the .post_load function is missing even today, > and that it should call exynos4210_uart_update_parameters() ? Yes, it should, so that's an existing bug. (I think you'll only notice an ill effect from that if you have wir

Re: [PATCH v3 2/5] migration: Create MigrationState active field

2020-01-17 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Right now, there is no easy way to dectect if we have already >> cancelled/finished/failed a migration. This field is setup to true >> when we start a migration, and it is set to false as soon as we stop >> it. >>

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Richard Henderson
On 1/17/20 7:01 AM, Helge Deller wrote: > Maybe adding something like (if TARGET_32BIT...) now would make sense, so we > don't get it > wrong when 64bit gets added? I'll add a "TODO: HPPA64" comment. r~

Re: [PATCH 2/6] hw/arm/exynos4210: Fix DMA initialization

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 18:07, Guenter Roeck wrote: > > Hi Peter, > > On Fri, Jan 17, 2020 at 01:30:19PM +, Peter Maydell wrote: > > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > > > > > First parameter to exynos4210_get_irq() is not the SPI port number, > > > but the interrupt group

Re: [PATCH 6/6] hw/arm/exynos4210: Connect serial port DMA busy signals with pl330

2020-01-17 Thread Guenter Roeck
On Fri, Jan 17, 2020 at 01:48:06PM +, Peter Maydell wrote: > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > > > The Exynos4210 serial driver uses an interrupt line to signal if receive > > data is available. Connect that interrupt with the DMA controller's > > 'peripheral busy' gpio pi

[Bug 1860053] Re: Possible lack of precision when calling clock_gettime via vDSO on user mode ppc64le

2020-01-17 Thread Richard Henderson
QEMU does not implement any vDSO, so this cannot be the explanation. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860053 Title: Possible lack of precision when calling clock_gettime via vDSO on u

Re: [PATCH 4/6] hw/char/exynos4210_uart: Implement receive FIFO

2020-01-17 Thread Guenter Roeck
Hi Peter, On Fri, Jan 17, 2020 at 01:42:54PM +, Peter Maydell wrote: > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > The subject just says "implement receive FIFO", but the > existing code clearly has an "Exynos4210UartFIFO rx" > which it does some storing and retrieving data from

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 6:30 PM, Richard Henderson wrote: On 1/17/20 6:13 AM, Philippe Mathieu-Daudé wrote: -    MemOp mop = MO_TEUL | MO_ALIGN_16 | a->size; +    MemOp mop = MO_TE | MO_ALIGN | a->size; Hmmm you changed MO_TEUL -> MO_TE, so from MO_32 to MO_8. Per your description, shouldn't this be MO_T

Re: qemu-x86_64, buster /sbin/ldconfig and setup_arg_pages (a mind dump)

2020-01-17 Thread Richard Henderson
On 1/17/20 7:33 AM, Alex Bennée wrote: > So what do we take away from this? > > * we need testcases to exercise the memory layout of dynamic binaries > * "special" dynamic binaries can break our careful memory layout > * I feel as though I've trodden on a nest of vipers > > Does any of this tr

Re: [PATCH 2/6] hw/arm/exynos4210: Fix DMA initialization

2020-01-17 Thread Guenter Roeck
Hi Peter, On Fri, Jan 17, 2020 at 01:30:19PM +, Peter Maydell wrote: > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > > > First parameter to exynos4210_get_irq() is not the SPI port number, > > but the interrupt group number. Interrupt groups are 20 for mdma > > and 21 for pdma. Inter

Re: [PULL 00/15] target-arm queue

2020-01-17 Thread Peter Maydell
rth/tags/pull-tcg-20200115' into > staging (2020-01-17 12:13:17 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20200117-1 > > for you to fetch changes up to 1a1fbc6cbb34c26d43d8360c66c1d21681a

[PATCH v2 7/7] tests/bios-tables-test: Update arm/virt memhp test

2020-01-17 Thread Shameer Kolothum
Since we now have both pc-dimm and nvdimm support, update test_acpi_virt_tcg_memhp() to include those. Signed-off-by: Shameer Kolothum --- tests/data/acpi/virt/NFIT.memhp | 0 tests/data/acpi/virt/SSDT.memhp | 0 tests/qtest/bios-tables-test.c | 9 +++-- 3 files changed, 7 insertions(+), 2

[PATCH v2 3/7] nvdimm: Use configurable ACPI IO base and size

2020-01-17 Thread Shameer Kolothum
From: Kwangwoo Lee This patch makes IO base and size configurable to create NPIO AML for ACPI NFIT. Since a different architecture like AArch64 does not use port-mapped IO, a configurable IO base is required to create correct mapping of ACPI IO address and size. Signed-off-by: Kwangwoo Lee Sign

[PATCH v2 5/7] hw/arm/virt: Add nvdimm hotplug support

2020-01-17 Thread Shameer Kolothum
This adds support for nvdimm hotplug events through GED and enables nvdimm for the arm/virt. Now Guests with ACPI can have both cold and hot plug of nvdimms. Hot removal functionality is not yet supported. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- docs/specs/acpi_hw_reduce

[PATCH v2 4/7] hw/arm/virt: Add nvdimm hot-plug infrastructure

2020-01-17 Thread Shameer Kolothum
From: Kwangwoo Lee Prepare pre-plug and plug handlers for NVDIMM support. Please note nvdimm_support is not yet enabled. Signed-off-by: Kwangwoo Lee Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum --- hw/arm/Kconfig | 1 + hw/arm/virt-acpi-build.c | 6 ++ hw/arm/vir

[PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-01-17 Thread Shameer Kolothum
If ACPI blob length modifications happens after the initial virt_acpi_build() call, and the changed blob length is within the PAGE size boundary, then the revised size is not seen by the firmware on Guest reboot. The is because in the virt_acpi_build_update() -> acpi_ram_update() -> qemu_ram_resize

[PATCH v2 6/7] tests: Update ACPI tables list for upcoming arm/virt test changes

2020-01-17 Thread Shameer Kolothum
This is in preparation to update test_acpi_virt_tcg_memhp() with pc-dimm and nvdimm. Update the bios-tables-test-allowed-diff.h with the affected ACPI tables so that "make check" doesn't fail. Signed-off-by: Shameer Kolothum --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ 1 file changed

[PATCH v2 0/7] ARM virt: Add NVDIMM support

2020-01-17 Thread Shameer Kolothum
This series adds NVDIMM support to arm/virt platform. The series reuses some of the patches posted by Eric in his earlier attempt here[1]. Patch #1 is a fix to the Guest reboot issue on NVDIMM hot add case described here[2] and patch #2 is another fix to the nvdimm aml issue discussed here[3]. I

[PATCH v2 2/7] hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length

2020-01-17 Thread Shameer Kolothum
As per ACPI spec 6.3, Table 19-419 Object Conversion Rules, if the Buffer Field <= to the size of an Integer (in bits), it will be treated as an integer. Moreover, the integer size depends on DSDT tables revision number. If revision number is < 2, integer size is 32 bits, otherwise it is 64 bits. C

Re: [PATCH 1/6] dma/pl330: Convert to support tracing

2020-01-17 Thread Guenter Roeck
On Fri, Jan 17, 2020 at 05:05:07PM +, Peter Maydell wrote: > On Fri, 17 Jan 2020 at 16:46, Guenter Roeck wrote: > > > > On Fri, Jan 17, 2020 at 01:23:46PM +, Peter Maydell wrote: > > > Won't this now do all the work of constructing the hexdump strings, > > > even if tracing is disabled ? >

Re: [for-5.0 PATCH 00/11] Support for reverse debugging with GDB

2020-01-17 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> >> > GDB remote protocol supports reverse debugging of the targets. >> > It includes 'reverse step' and 'reverse continue' operations. >> > The first one finds the previous step of the e

Re: [PATCH v2 66/86] ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup

2020-01-17 Thread BALATON Zoltan
On Fri, 17 Jan 2020, Igor Mammedov wrote: On Fri, 17 Jan 2020 16:38:02 +0100 Philippe Mathieu-Daudé wrote: On 1/17/20 11:46 AM, Igor Mammedov wrote: On Wed, 15 Jan 2020 22:33:46 +0100 (CET) BALATON Zoltan wrote: [...] v2 basically works the same as original code, except of that instead of

qemu-x86_64, buster /sbin/ldconfig and setup_arg_pages (a mind dump)

2020-01-17 Thread Alex Bennée
Hi Richard, While I was attempting to test the new vsyscall patches for x86 I discovered I couldn't debootstrap an x86_64 buster image on my ARM box. After digging further into it I discovered it was because executing /sbin/ldconfig crashes and aborts the bootstrap. This is helpfully reproducib

Proposal for handling .hx files with Sphinx

2020-01-17 Thread Peter Maydell
Currently our manual creation includes some .texi files which are autogenerated from .hx files by running scripts/hxtool. .hx files are a simple format, where where a line is either a directive or literal text to be output: HXCOMM -- comment lines, ignored STEXI/ETEXI -- mark start/end of chunks

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Richard Henderson
On 1/17/20 6:13 AM, Philippe Mathieu-Daudé wrote: >>> -    MemOp mop = MO_TEUL | MO_ALIGN_16 | a->size; >>> +    MemOp mop = MO_TE | MO_ALIGN | a->size; > > > Hmmm you changed MO_TEUL -> MO_TE, so from MO_32 to MO_8. > > Per your description, shouldn't this be MO_TEUL | MO_ALIGN_4? The "UL" par

Re: [PULL 0/4] qtests and gitlab-CI

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 11:08, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit fee0ec1fd11a6fb960517e18201ed8a686a0d7e8: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2020-01-14 14:11:34 +) > > are available in the Git re

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu - status update

2020-01-17 Thread Dr. David Alan Gilbert
* John G Johnson (john.g.john...@oracle.com) wrote: > DMA > > This is one place where I might diverge from VFIO. It uses an > ioctl to tell the kernel driver what areas of guest memory the device > can address. The driver then pins that memory so it can be programmed > into a HW IOMMU.

Re: [PATCH 1/6] dma/pl330: Convert to support tracing

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 16:46, Guenter Roeck wrote: > > On Fri, Jan 17, 2020 at 01:23:46PM +, Peter Maydell wrote: > > Won't this now do all the work of constructing the hexdump strings, > > even if tracing is disabled ? > > > That is correct. Can I check > if (trace_event_get_state(TRA

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Helge Deller
On 17.01.20 17:13, Philippe Mathieu-Daudé wrote: > On 1/17/20 4:49 PM, Helge Deller wrote: >> On 17.01.20 02:53, Richard Henderson wrote: >>> The PA-RISC 1.1 specification says that LDCW must be aligned mod 16 >>> or the operation is undefined.  However, real hardware only generates >>> an unaligne

[PATCH v3 2/2] hw/timer/m48t59: Convert debug printf()s to trace events

2020-01-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/m48t59-internal.h | 5 - hw/rtc/m48t59.c | 11 +-- hw/rtc/trace-events | 6 ++ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/rtc/m48t59-internal.h b/hw/rtc/m48t59-internal.h index 4d4f2a6fed..cd

[PATCH v3 1/2] MAINTAINERS: Add missing m48t59 files to the PReP section

2020-01-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4b425d030d..c162145bd0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1084,6 +1084,8 @@ F: hw/pci-host/prep.[hc] F: hw/isa/i82378.c F: hw/isa/pc87312.c F:

[PATCH v3 0/2] hw/timer/m48t59: Convert to trace events

2020-01-17 Thread Philippe Mathieu-Daudé
Another trivial cleanup series. v2: Rebased on 4.2 Philippe Mathieu-Daudé (2): MAINTAINERS: Add missing m48t59 files to the PReP section hw/timer/m48t59: Convert debug printf()s to trace events hw/rtc/m48t59-internal.h | 5 - hw/rtc/m48t59.c | 11 +-- MAINTAINERS

Re: [RFC PATCH] pcie: Defer hot unplug until migration is complete

2020-01-17 Thread Dr. David Alan Gilbert
* Julia Suvorova (jus...@redhat.com) wrote: > On Mon, Jan 13, 2020 at 3:04 PM Yury Kotov wrote: > > > > Devices hot-plug during migration is not allowed and disabled in > > corresponding QMP-commands (device_add, device_del). > > But guest still can unplug device by powering it off > > (Example: e

Re: [PATCH v2 0/6] Fix more GCC9 -O3 warnings

2020-01-17 Thread Philippe Mathieu-Daudé
Cc'ing qemu-trivial as this series is fully reviewed. On 12/18/19 8:25 PM, Philippe Mathieu-Daudé wrote: Fix some trivial warnings when building with -O3. v2: - addressed Thomas and Aleksandar comments - dropped 'hw/scsi/megasas: Silent GCC9 duplicated-cond warning' - dropped 'qemu-io-cmds: Sil

Re: [PATCH] mailmap: Add more entries to sanitize 'git log' output

2020-01-17 Thread Philippe Mathieu-Daudé
ping? On Wed, Dec 18, 2019 at 7:57 PM Philippe Mathieu-Daudé wrote: > > Most of these developers have the Signed-off-by tag properly > written, but not the author/commiter name. Fix this. > Also we incorrectly wrote Arei Gonglei name, update and reorder. > > git-log does not use this file by defa

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 5:40 PM, Igor Mammedov wrote: On Fri, 17 Jan 2020 17:19:26 +0100 Philippe Mathieu-Daudé wrote: On 1/17/20 5:03 PM, Igor Mammedov wrote: On Thu, 16 Jan 2020 16:43:07 +0100 Philippe Mathieu-Daudé wrote: On 1/15/20 10:01 PM, no-re...@patchew.org wrote: Patchew URL: https://pat

Re: [PULL 0/4] qtests and gitlab-CI

2020-01-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200117110758.1995-1-th...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200117110758.1995-1-th...@redhat.com Type: series Subject: [PULL 0/4] qtests and gitlab-CI === TEST SCRI

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-17 Thread Christian Schoenebeck
On Freitag, 17. Januar 2020 16:15:37 CET Greg Kurz wrote: > > > Hmm... this patch does a sanity check on 'count', not on 'msize'... > > > > Yes ... :) > > > > > I mean no matter what msize is, clipping count to msize - 11 gives a > > > chance to stop processing the entries before overflowing the

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-17 Thread Igor Mammedov
On Fri, 17 Jan 2020 17:19:26 +0100 Philippe Mathieu-Daudé wrote: > On 1/17/20 5:03 PM, Igor Mammedov wrote: > > On Thu, 16 Jan 2020 16:43:07 +0100 > > Philippe Mathieu-Daudé wrote: > > > >> On 1/15/20 10:01 PM, no-re...@patchew.org wrote: > >>> Patchew URL: > >>> https://patchew.org/QEMU/1

Re: [PATCH 1/6] dma/pl330: Convert to support tracing

2020-01-17 Thread Guenter Roeck
On Fri, Jan 17, 2020 at 01:23:46PM +, Peter Maydell wrote: > On Fri, 10 Jan 2020 at 20:39, Guenter Roeck wrote: > > > > Replace debug logging code with tracing. > > > > Signed-off-by: Guenter Roeck > > --- > > hw/dma/pl330.c | 88 +++-- > > hw/dma

Re: [PATCH v3 3/5] migration: Don't wait in semaphore for thread we know has finished

2020-01-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > If p->quit is true for any channel, we know that it has finished for > any reason. So don't wait for it, just continue. > > Signed-off-by: Juan Quintela > > --- > > I could be convinced that the right thing to do in that case is to > just do a bre

Re: [PATCH v2 66/86] ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup

2020-01-17 Thread Igor Mammedov
On Fri, 17 Jan 2020 16:38:02 +0100 Philippe Mathieu-Daudé wrote: > On 1/17/20 11:46 AM, Igor Mammedov wrote: > > On Wed, 15 Jan 2020 22:33:46 +0100 (CET) > > BALATON Zoltan wrote: > > > [...] > > v2 basically works the same as original code, except of that > > instead of fixing up ram_size, i

Re: [PATCH v3 05/11] tests/virtio-9p: added readdir test

2020-01-17 Thread Christian Schoenebeck
On Freitag, 17. Januar 2020 16:51:29 CET Greg Kurz wrote: > On Tue, 14 Jan 2020 00:08:51 +0100 > > Christian Schoenebeck wrote: > > The first readdir test simply checks the amount of directory > > entries returned by 9pfs server, according to the created amount > > of virtual files on 9pfs synth

Re: [PATCH v3 2/5] migration: Create MigrationState active field

2020-01-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Right now, there is no easy way to dectect if we have already > cancelled/finished/failed a migration. This field is setup to true > when we start a migration, and it is set to false as soon as we stop > it. > > It fixes a real bug, in ram_save_itera

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 5:03 PM, Igor Mammedov wrote: On Thu, 16 Jan 2020 16:43:07 +0100 Philippe Mathieu-Daudé wrote: On 1/15/20 10:01 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imamm...@redhat.com/ Hi, This series failed the docker-quick@

Re: [PATCH] qemu-img: Add --target-is-zero to convert

2020-01-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200117104156.1364069-1-david.edmond...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200117104156.1364069-1-david.edmond...@oracle.com Type: series Subject: [PATCH] qemu-img: A

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 4:49 PM, Helge Deller wrote: On 17.01.20 02:53, Richard Henderson wrote: The PA-RISC 1.1 specification says that LDCW must be aligned mod 16 or the operation is undefined. However, real hardware only generates an unaligned access trap for unaligned mod 4. Match real hardware, but di

Re: [PATCH v3 1/3] qcow2: introduce Qcow2Metadata structure

2020-01-17 Thread Vladimir Sementsov-Ogievskiy
14.01.2020 11:22, Andrey Shinkevich wrote: > The preliminary patch to provide an extendable structure for dumping > QCOW2 metadata allocations in image. The command line optional key is > introduced in the patch that follows. > > Suggested-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Andrey

Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

2020-01-17 Thread Igor Mammedov
On Thu, 16 Jan 2020 16:43:07 +0100 Philippe Mathieu-Daudé wrote: > On 1/15/20 10:01 PM, no-re...@patchew.org wrote: > > Patchew URL: > > https://patchew.org/QEMU/1579100861-73692-1-git-send-email-imamm...@redhat.com/ > > > > > > > > Hi, > > > > This series failed the docker-quick@centos7 bui

Re: qemu-4.0.1: vhost_region_add_section:Section rounded to 0 prior to previous a0000

2020-01-17 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: > Am 16.01.20 um 21:26 schrieb Dr. David Alan Gilbert: > > * Peter Lieven (p...@kamp.de) wrote: > >> Am 16.01.20 um 13:47 schrieb Peter Lieven: > >>> Am 13.01.20 um 17:25 schrieb Peter Lieven: > Am 09.01.20 um 19:44 schrieb Dr. David Alan Gilbert: > > *

Re: [PATCH v3 05/11] tests/virtio-9p: added readdir test

2020-01-17 Thread Greg Kurz
On Tue, 14 Jan 2020 00:08:51 +0100 Christian Schoenebeck wrote: > The first readdir test simply checks the amount of directory > entries returned by 9pfs server, according to the created amount > of virtual files on 9pfs synth driver side. Then the subsequent > readdir test also checks whether al

Re: [PATCH] target/hppa: Allow, but diagnose, LDCW aligned only mod 4

2020-01-17 Thread Helge Deller
On 17.01.20 02:53, Richard Henderson wrote: > The PA-RISC 1.1 specification says that LDCW must be aligned mod 16 > or the operation is undefined. However, real hardware only generates > an unaligned access trap for unaligned mod 4. > > Match real hardware, but diagnose with GUEST_ERROR a violatio

Re: [PATCH v3 03/11] 9pfs: validate count sent by client with T_readdir

2020-01-17 Thread Greg Kurz
On Thu, 16 Jan 2020 17:51:10 +0100 Christian Schoenebeck wrote: > On Donnerstag, 16. Januar 2020 14:33:42 CET Greg Kurz wrote: > > On Mon, 13 Jan 2020 23:22:08 +0100 > > > > Christian Schoenebeck wrote: > > > A good 9p client sends T_readdir with "count" parameter that's > > > sufficiently smal

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread Greg Kurz
On Fri, 17 Jan 2020 13:10:35 +0100 Laurent Vivier wrote: > On 17/01/2020 12:49, Greg Kurz wrote: > > On Wed, 15 Jan 2020 19:26:18 +0100 > > Laurent Vivier wrote: > > > >> On 15/01/2020 19:10, Laurent Vivier wrote: > >>> Hi, > >>> > >>> On 15/01/2020 18:48, Greg Kurz wrote: > Migration can

  1   2   3   >