[PATCH v2] Fix some comment spelling errors.

2019-12-07 Thread Cameron Esfahani via
Signed-off-by: Cameron Esfahani Reviewed-by: Stefan Weil --- target/i386/machine.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/machine.c b/target/i386/machine.c index 2699eed94e..ee342ddd50 100644 --- a/target/i386/machine.c +++ b/target/i386/machine.c

[PATCH v2] Adding support for MAC filtering in the FEC IP implementation.

2019-12-07 Thread bilalwasim676
From: Bilal Wasim This addition ensures that the IP does NOT boot up in promiscuous mode by default, and so the software only receives the desired packets(Unicast, Broadcast, Unicast / Multicast hashed) by default. The software running on-top of QEMU can also modify these settings and disable rec

Re: [PATCH] Adding support for MAC filtering in the FEC IP implementation.

2019-12-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191207203450.6304-1-bilalwasim...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] Adding support for MAC filtering in the FEC IP implementation. Type: series Message-id: 201912

[PATCH] Adding support for MAC filtering in the FEC IP implementation.

2019-12-07 Thread bilalwasim676
From: Bilal Wasim This addition ensures that the IP does NOT boot up in promiscuous mode by default, and so the software only receives the desired packets(Unicast, Broadcast, Unicast / Multicast hashed) by default. The software running on-top of QEMU can also modify these settings and disable rec

Re: [RESEND PATCH v21 1/6] hw/arm/virt: Introduce a RAS machine option

2019-12-07 Thread gengdongjiu
> > I think we could make the user-facing description of > the option a little clearer: something like > "Set on/off to enable/disable reporting host memory errors > to a KVM guest using ACPI and guest external abort exceptions" > > ? Peter, sorry for the late response. sure, we have already up

Re: [PATCH v2 3/5] MAINTAINERS: Adjust maintainership for Malta board

2019-12-07 Thread Aleksandar Markovic
On Thursday, November 14, 2019, Philippe Mathieu-Daudé wrote: > +Paul Burton > > On 11/13/19 2:47 PM, Aleksandar Markovic wrote: > >> From: Aleksandar Markovic >> >> Change the maintainership for Malta board to improve its quality. >> >> Acked-by: Aurelien Jarno >> Signed-off-by: Aleksandar Mar

Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

2019-12-07 Thread Aleksandar Markovic
On Thursday, November 14, 2019, Philippe Mathieu-Daudé wrote: > On 11/14/19 2:08 PM, chen huacai wrote: > >> Hi, all, >> >> On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic >> wrote: >> >>> >>> Hi, Philippe, >>> >>> From: Philippe Mathieu-Daudé Hi Aleksandar, On 11/13/19

[Bug 1855535] [NEW] Connection reset by peer when using port fwd

2019-12-07 Thread Leonardo
Public bug reported: $ qemu-system-ppc64 -cpu POWER8,compat=power7 -machine pseries -m 8G -smp cores=8 -serial mon:stdio -nographic \ -drive file=/qemu/aix72.img,if=none,id=drive-virtio-disk0 \ -device virtio-scsi-pci,id=scsi -device scsi-hd,drive=drive-virtio-disk0 \ -cdrom /qemu/aix72.iso \ -pr

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-12-07 Thread Michael Weiser
FWIW, my VMs run with SATA and Virtio SCSI with discard=unmap and detect-zeroes=unmap (among the plethora of options from libvirtd) for maximum space savings. No problems since the fix patches went in and had no bearing on the bug occurence before that. /usr/bin/qemu-system-x86_64 -name guest=win1

Re: [PATCH] exec: Remove the duplicated check in parse_cpu_option()

2019-12-07 Thread Gavin Shan
On 12/7/19 3:58 AM, Greg Kurz wrote: On Fri, 6 Dec 2019 17:33:37 +1100 Gavin Shan wrote: The @cpu_option shouldn't be NULL, otherwise assertion from g_strsplit() should be raised as below message indicates. So it's meaningless to validate @model_pices[0] in parse_cpu_option() as it shouldn't

Re: [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1

2019-12-07 Thread Aleksandar Markovic
On Wednesday, August 28, 2019, Aleksandar Markovic wrote: > > From: Laurent Vivier > > Sent: Wednesday, August 28, 2019 10:51 AM > > To: Josh Kunz; Aleksandar Markovic; milos.stojano...@rt-rk.com > > Cc: marlies.r...@gmail.com; qemu-devel@nongnu.org; riku.voi...@iki.fi; > > qemu-triv...@nongnu.o

Re: [PATCH] exec: Remove the duplicated check in parse_cpu_option()

2019-12-07 Thread Greg Kurz
On Sat, 7 Dec 2019 23:56:55 +1100 Gavin Shan wrote: > On 12/7/19 3:58 AM, Greg Kurz wrote: > > On Fri, 6 Dec 2019 17:33:37 +1100 > > Gavin Shan wrote: > > > >> The @cpu_option shouldn't be NULL, otherwise assertion from g_strsplit() > >> should be raised as below message indicates. So it's mea

Re: [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK()

2019-12-07 Thread Gavin Shan
On 12/7/19 8:48 PM, Philippe Mathieu-Daudé wrote: There is no declaration of the 'NMI' type. INTERFACE_CHECK() returns an abstract type (see commit aa1b35b975d8). The abstract type corresponding to the TYPE_NMI interface is 'NMIState'. Fixes: 9cb805fd267 Signed-off-by: Philippe Mathieu-Daudé --

Re: [PATCH] hw/core: Fix data type in do_nmi()

2019-12-07 Thread Gavin Shan
On 12/7/19 3:50 AM, Greg Kurz wrote: On Fri, 6 Dec 2019 17:36:42 +1100 Gavin Shan wrote: object_dynamic_cast() should return machine (or GPIO) state instad of NMI state in do_nmi(). So it's wrong to convert it to NMI state unconditionally. object_dynamic_cast() returns either its first arg

[PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK()

2019-12-07 Thread Philippe Mathieu-Daudé
There is no declaration of the 'NMI' type. INTERFACE_CHECK() returns an abstract type (see commit aa1b35b975d8). The abstract type corresponding to the TYPE_NMI interface is 'NMIState'. Fixes: 9cb805fd267 Signed-off-by: Philippe Mathieu-Daudé --- include/hw/nmi.h | 2 +- 1 file changed, 1 insert

Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2019-12-07 Thread gengdongjiu
On 2019/11/22 23:47, Beata Michalska wrote: > Hi, > > On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote: >> >> From: Dongjiu Geng >> >> Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, >> translates the host VA delivered by host to guest PA, then fills this PA >> to gues