[RFC 4/8] Got GPU init working. Stops at probing display

2019-11-27 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/ati.c | 9 +- hw/display/r300.c | 571 +- hw/display/r300.h | 77 ++- 3 files changed, 544 insertions(+), 113 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index db3b254316..1d36233163 100644

[RFC 7/8] R300 fixes

2019-11-27 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 9 + hw/display/r300.h | 6 ++ 2 files changed, 15 insertions(+) diff --git a/hw/display/r300.c b/hw/display/r300.c index 653474c3aa..074dbf5b2d 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -878,6 +878,15 @@ static void r300_

[RFC 6/8] Fix MC STATUS resgister

2019-11-27 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 15 --- hw/display/r300.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/display/r300.c b/hw/display/r300.c index 94e90b7a95..653474c3aa 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -278,6 +278,10 @

[RFC 3/8] R300 fixes

2019-11-27 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 9 + hw/display/r300.h | 6 ++ 2 files changed, 15 insertions(+) diff --git a/hw/display/r300.c b/hw/display/r300.c index 653474c3aa..074dbf5b2d 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -878,6 +878,15 @@ static void r300_

[RFC 8/8] Got GPU init working. Stops at probing display

2019-11-27 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/ati.c | 9 +- hw/display/r300.c | 571 +- hw/display/r300.h | 77 ++- 3 files changed, 544 insertions(+), 113 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index db3b254316..1d36233163 100644

[RFC 2/8] Fix MC STATUS resgister

2019-11-27 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 15 --- hw/display/r300.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/display/r300.c b/hw/display/r300.c index 94e90b7a95..653474c3aa 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -278,6 +278,10 @

Re: [PATCH v4 6/6] s390x: kvm: Make kvm_sclp_service_call void

2019-11-27 Thread Thomas Huth
On 27/11/2019 18.50, Janosch Frank wrote: It defaults to returning 0 anyway and that return value is not necessary, as 0 is also the default rc that the caller would return. While doing that we can simplify the logic a bit and return early if we inject a PGM exception. Also we always set a 0 cc,

[PATCH] Add a parameter 'offset' for HostMemoryBackendFile

2019-11-27 Thread Jason Zeng
In cloud environment, when using DRAM-emulated-PMEM DAX device (by kernel parameter 'memmap=nn!ss') to mmap guest memory, multiple VMs may need to share the same DAX device. This is because we can't dynamically create multiple namespaces in one DRAM-emulated-PMEM region. It is also hard to figure o

Re: [PATCH v4 3/6] s390x: Move initial reset

2019-11-27 Thread Janosch Frank
On 11/28/19 8:00 AM, Thomas Huth wrote: > On 27/11/2019 18.50, Janosch Frank wrote: >> Let's move the intial reset into the reset handler and cleanup >> afterwards. >> >> Signed-off-by: Janosch Frank >> Reviewed-by: David Hildenbrand >> --- >> target/s390x/cpu-qom.h | 2 +- >> target/s390x/cp

RE: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()

2019-11-27 Thread Gonglei (Arei)
CCing qemu-triv...@nongnu.org Reviewed-by: Gonglei Regards, -Gonglei > -Original Message- > From: Vladimir Sementsov-Ogievskiy [mailto:vsement...@virtuozzo.com] > Sent: Thursday, November 28, 2019 3:46 AM > To: qemu-devel@nongnu.org > Cc: Gonglei (Arei) ; marcandre.lur...@gmail.com; >

Re: [PATCH v4 4/6] s390x: Move clear reset

2019-11-27 Thread Thomas Huth
On 27/11/2019 18.50, Janosch Frank wrote: Let's also move the clear reset function into the reset handler. Signed-off-by: Janosch Frank --- target/s390x/cpu-qom.h | 1 + target/s390x/cpu.c | 58 +- 2 files changed, 18 insertions(+), 41 deletions(

Re: [PATCH v4 3/6] s390x: Move initial reset

2019-11-27 Thread Thomas Huth
On 27/11/2019 18.50, Janosch Frank wrote: Let's move the intial reset into the reset handler and cleanup afterwards. Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand --- target/s390x/cpu-qom.h | 2 +- target/s390x/cpu.c | 44 -- targe

Re: [RFC 00/10] R300 QEMU device V2

2019-11-27 Thread Aaron Zakhrov
I tested my code with the vgabios-ati.bin rom file and it seems to get passed the earlier issue I had. I have cleaned up my code and have sent a new patch series. The new one is pretty big but it contains only the necessary header files and it should be a little easier to review On Wed, Nov 27, 20

[RFC 0/1] ATI R300 emulated grpahics card V2

2019-11-27 Thread aaron . zakhrov
From: Aaron Dominick This is the cleaned up patchset to my previous RFC patch set. I could not reliably clean up my previous commits so I deleted my fork and started from scratch. The patch looks like a lot of changes but most of it is just register definitions copied from the kernel radeon DRM

Re: [PATCH v4 2/6] s390x: Move reset normal to shared reset handler

2019-11-27 Thread Thomas Huth
On 27/11/2019 18.50, Janosch Frank wrote: Let's start moving the cpu reset functions into a single function with a switch/case, so we can use fallthroughs and share more code between resets. Nit: I'd add a "later" in above sentence, since you don't use fallthroughs yet. This patch introduce

Re: [PATCH v2 5/5] hvf: save away type as well as vector so we can reinject them

2019-11-27 Thread Cameron Esfahani via
I added some asserts to our internal version of QEMU. It's a few months off of master and, specifically, doesn't have fd13f23b8c95311eff74426921557eee592b0ed3. With the previous version of hvf_inject_interrupts(), before our fix, the code looked like the following: > if (env->interrupt_inj

[PATCH 3/4] target/arm: Prepare generic timer for per-platform CNTFRQ

2019-11-27 Thread Andrew Jeffery
The ASPEED AST2600 clocks the generic timer at the rate of HPLL. On recent firmwares this is at 1125MHz, which is considerably quicker than the assumed 62.5MHz of the current generic timer implementation. The delta between the value as read from CNTFRQ and the true rate of the underlying QEMUTimer

[PATCH 0/4] Expose GT CNTFRQ as a CPU property to support AST2600

2019-11-27 Thread Andrew Jeffery
Hello, This is a belated follow-up from a few of my earlier attempts to fix up the ARM generic timer for correct behaviour on the ASPEED AST2600 SoC. The AST2600 clocks the generic timer at the rate of HPLL, which is configured to 1125MHz. This is significantly quicker than the currently hard-code

[PATCH 2/4] target/arm: Abstract the generic timer frequency

2019-11-27 Thread Andrew Jeffery
Prepare for SoCs such as the ASPEED AST2600 whose firmware configures CNTFRQ to values significantly larger than the static 62.5MHz value currently derived from GTIMER_SCALE. As the OS potentially derives its timer periods from the CNTFRQ value the lack of support for running QEMUTimers at the appr

[PATCH 4/4] ast2600: Configure CNTFRQ at 1125MHz

2019-11-27 Thread Andrew Jeffery
This matches the configuration set by u-boot on the AST2600. Signed-off-by: Andrew Jeffery --- hw/arm/aspeed_ast2600.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c index 931887ac681f..5aecc3b3caec 100644 --- a/hw/arm/aspeed_ast2600.c ++

[PATCH 1/4] target/arm: Remove redundant scaling of nexttick

2019-11-27 Thread Andrew Jeffery
The corner-case codepath was adjusting nexttick such that overflow wouldn't occur when timer_mod() scaled the value back up. Remove a use of GTIMER_SCALE and avoid unnecessary operations by calling timer_mod_ns() directly. Signed-off-by: Andrew Jeffery --- target/arm/helper.c | 5 +++-- 1 file c

Re: [PATCH v18 3/8] numa: Extend CLI to provide memory side cache information

2019-11-27 Thread Tao Xu
On 11/28/2019 10:46 AM, Tao Xu wrote: On 11/27/2019 5:56 PM, Markus Armbruster wrote: Tao Xu writes: From: Liu Jingqi Add -numa hmat-cache option to provide Memory Side Cache Information. These memory attributes help to build Memory Side Cache Information Structure(s) in ACPI Heterogeneous

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Jason Wang
On 2019/11/28 上午11:32, Alexei Starovoitov wrote: On Tue, Nov 26, 2019 at 12:35:14PM -0800, Jakub Kicinski wrote: I'd appreciate if others could chime in. The performance improvements are quite appealing. In general offloading from higher layers into lower layers is necessary long term. But

Re: [PATCH v6 00/20] ppc/pnv: add XIVE support for KVM guests

2019-11-27 Thread David Gibson
On Mon, Nov 25, 2019 at 07:58:00AM +0100, Cédric Le Goater wrote: > Hello, > > The QEMU PowerNV machine emulates a baremetal OpenPOWER system and > acts as an hypervisor (L0). Supporting emulation of KVM to run guests > (L1) requires a few more extensions, among which guest support for the > XIVE

Re: [PATCH v6 16/20] ppc/xive: Introduce a xive_tctx_ipb_update() helper

2019-11-27 Thread David Gibson
On Wed, Nov 27, 2019 at 09:50:50AM +0100, Greg Kurz wrote: 65;5802;1c> On Mon, 25 Nov 2019 07:58:16 +0100 > Cédric Le Goater wrote: > > > We will use it to resend missed interrupts when a vCPU context is > > pushed on a HW thread. > > > > Signed-off-by: Cédric Le Goater > > --- > > include/hw/

Re: [PATCH v6 13/20] ppc/pnv: Clarify how the TIMA is accessed on a multichip system

2019-11-27 Thread David Gibson
On Wed, Nov 27, 2019 at 07:57:31AM +0100, Cédric Le Goater wrote: > On 27/11/2019 06:23, David Gibson wrote: > > On Mon, Nov 25, 2019 at 07:58:13AM +0100, Cédric Le Goater wrote: > >> The TIMA region gives access to the thread interrupt context registers > >> of a CPU. It is mapped at the same addr

Re: [PATCH v6 15/20] ppc/xive: Remove the get_tctx() XiveRouter handler

2019-11-27 Thread David Gibson
On Mon, Nov 25, 2019 at 07:58:15AM +0100, Cédric Le Goater wrote: > It is now unused. > > Reviewed-by: Greg Kurz > Signed-off-by: Cédric Le Goater 14..15 applied to ppc-for-5.0. > --- > include/hw/ppc/xive.h | 2 -- > hw/intc/pnv_xive.c| 13 - > hw/intc/spapr_xive.c | 8 ---

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Jason Wang
On 2019/11/28 上午3:49, Jakub Kicinski wrote: On Wed, 27 Nov 2019 10:59:37 +0800, Jason Wang wrote: On 2019/11/27 上午4:35, Jakub Kicinski wrote: On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: Note: This RFC has been sent to netdev as well as qemu-devel lists This series introduces X

Re: [PATCH v3 6/7] docs: gpio: Add GPIO Aggregator/Repeater documentation

2019-11-27 Thread Ulrich Hecht
> On November 27, 2019 at 9:42 AM Geert Uytterhoeven > wrote: > > > Document the GPIO Aggregator/Repeater, and the three typical use-cases. > > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > --- > .../admin-guide/gpio/gpio-aggregator.rst | 111 ++ > Documen

Re: [PATCH v3 3/7] gpiolib: Add support for GPIO line table lookup

2019-11-27 Thread Ulrich Hecht
> On November 27, 2019 at 9:42 AM Geert Uytterhoeven > wrote: > > > Currently GPIOs can only be referred to by GPIO controller and offset in > GPIO lookup tables. > > Add support for looking them up by line name. > > Signed-off-by: Geert Uytterhoeven > --- > If this is rejected, the GPIO A

Re: [PATCH v3 5/7] gpio: Add GPIO Aggregator/Repeater driver

2019-11-27 Thread Ulrich Hecht
Thank you for this series! > On November 27, 2019 at 9:42 AM Geert Uytterhoeven > wrote: > > > GPIO controllers are exported to userspace using /dev/gpiochip* > character devices. Access control to these devices is provided by > standard UNIX file system permissions, on an all-or-nothing basi

Re: [PATCH v3 4/7] dt-bindings: gpio: Add gpio-repeater bindings

2019-11-27 Thread Ulrich Hecht
> On November 27, 2019 at 9:42 AM Geert Uytterhoeven > wrote: > > > Add Device Tree bindings for a GPIO repeater, with optional translation > of physical signal properties. This is useful for describing explicitly > the presence of e.g. an inverter on a GPIO line, and was inspired by the > n

Re: [PATCH v3 1/7] gpiolib: Add GPIOCHIP_NAME definition

2019-11-27 Thread Ulrich Hecht
> On November 27, 2019 at 9:42 AM Geert Uytterhoeven > wrote: > > > The string literal "gpiochip" is used in several places. > Add a definition for it, and use it everywhere, to make sure everything > stays in sync. > > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > --- > drive

Re: [PATCH v3 2/7] gpiolib: Add support for gpiochipN-based table lookup

2019-11-27 Thread Ulrich Hecht
> On November 27, 2019 at 9:42 AM Geert Uytterhoeven > wrote: > > > Currently GPIO controllers can only be referred to by label in GPIO > lookup tables. > > Add support for looking them up by "gpiochipN" name, with "N" either the > corresponding GPIO device's ID number, or the GPIO controlle

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Alexei Starovoitov
On Tue, Nov 26, 2019 at 12:35:14PM -0800, Jakub Kicinski wrote: > > I'd appreciate if others could chime in. The performance improvements are quite appealing. In general offloading from higher layers into lower layers is necessary long term. But the approach taken by patches 15 and 17 is a dead

RE: [PATCH V2 0/4] Introduce Advanced Watch Dog module

2019-11-27 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Wednesday, November 27, 2019 11:49 PM > To: Zhang, Chen > Cc: Jason Wang ; Paolo Bonzini > ; Philippe Mathieu-Daudé ; > qemu-dev ; Zhang Chen > Subject: Re: [PATCH V2 0/4] Introduce Advanced Watch Dog module > > "Zhang, Chen" wr

Re: [RFC net-next 15/18] virtio_net: implement XDP prog offload functionality

2019-11-27 Thread Prashant Bhole
On 11/28/19 5:42 AM, Michael S. Tsirkin wrote: On Tue, Nov 26, 2019 at 07:07:41PM +0900, Prashant Bhole wrote: From: Jason Wang This patch implements bpf_prog_offload_ops callbacks and adds handling for XDP_SETUP_PROG_HW. Handling of XDP_SETUP_PROG_HW involves setting up struct virtio_net_c

Re: [PATCH v18 3/8] numa: Extend CLI to provide memory side cache information

2019-11-27 Thread Tao Xu
On 11/27/2019 5:56 PM, Markus Armbruster wrote: Tao Xu writes: From: Liu Jingqi Add -numa hmat-cache option to provide Memory Side Cache Information. These memory attributes help to build Memory Side Cache Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Please

[NOTFORMERGE PATCH 10/10] hw/avr: Remove the 'sample' board

2019-11-27 Thread Philippe Mathieu-Daudé
We introduce real world boards with proper schematics, let's remove this. Signed-off-by: Philippe Mathieu-Daudé --- Patch meant to squash on 'target/avr: Add example board configuration' --- hw/avr/sample.c | 282 --- hw/avr/Makefile.objs | 1 - 2 f

[RFC PATCH 09/10] tests/acceptance: Use the ATmega2560 board

2019-11-27 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/machine_avr6.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/machine_avr6.py b/tests/acceptance/machine_avr6.py index 2ef4a9ac2c..abe8d45b65 100644 --- a/tests/acceptance/machine_avr6.py +++ b/t

[PATCH 08/10] tests/acceptance: Keep multilines comment consistent with other tests

2019-11-27 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/machine_avr6.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/machine_avr6.py b/tests/acceptance/machine_avr6.py index ba1f47dd70..2ef4a9ac2c 100644 --- a/tests/acceptance/machine_avr6.py +++ b

[RFC PATCH 06/10] hw/avr: Add ATmega microcontrollers

2019-11-27 Thread Philippe Mathieu-Daudé
Add famous ATmega MCUs: - middle range: ATmega168 and ATmega328 - high range: ATmega1280 and ATmega2560 Signed-off-by: Philippe Mathieu-Daudé --- hw/avr/atmega.h | 58 +++ hw/avr/atmega.c | 379 +++ hw/avr/Makefile.objs | 1 + 3 files cha

Re: [RFC PATCH 06/10] hw/avr: Add ATmega microcontrollers

2019-11-27 Thread Philippe Mathieu-Daudé
On Thu, Nov 28, 2019 at 2:50 AM Philippe Mathieu-Daudé wrote: > > Add famous ATmega MCUs: > > - middle range: ATmega168 and ATmega328 > - high range: ATmega1280 and ATmega2560 > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/avr/atmega.h | 58 +++ > hw/avr/atmega.c | 379 +

[RFC PATCH 07/10] hw/avr: Add few Arduino boards

2019-11-27 Thread Philippe Mathieu-Daudé
Add famous Arduino boards: - Arduino Duemilanove - Arduino Mega Signed-off-by: Philippe Mathieu-Daudé --- hw/avr/arduino.c | 173 +++ hw/avr/Makefile.objs | 1 + 2 files changed, 174 insertions(+) create mode 100644 hw/avr/arduino.c diff --git a/h

[NOTFORMERGE PATCH 04/10] target/avr: Fix IRQ count

2019-11-27 Thread Philippe Mathieu-Daudé
Fix a SEGV when using IRQ#57 by expanding to 64 IRQs. 64 is a magic number. Signed-off-by: Philippe Mathieu-Daudé --- target/avr/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 52ec21dd16..8198f9d49c 100644 --- a/target/avr/cpu.

[PATCH 02/10] target/avr: Remove unused include

2019-11-27 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/avr/helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/avr/helper.c b/target/avr/helper.c index f1939bd5a7..75946209b8 100644 --- a/target/avr/helper.c +++ b/target/avr/helper.c @@ -21,7 +21,6 @@ #include "qemu/osdep.h" #include

[PATCH 03/10] target/avr: Add missing definitions

2019-11-27 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/avr/cpu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/avr/cpu.h b/target/avr/cpu.h index a3e615a1eb..c1448a865f 100644 --- a/target/avr/cpu.h +++ b/target/avr/cpu.h @@ -26,6 +26,8 @@ #define TCG_GUEST_DEFAULT_MO 0 +#define AVR

[RFC PATCH 05/10] hw/char/avr: Reduce USART I/O size

2019-11-27 Thread Philippe Mathieu-Daudé
Per the datasheet the USART uses 6 consecutive 8-bit registers. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/avr_usart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/avr_usart.c b/hw/char/avr_usart.c index d039689c56..ba17bdd470 100644 --- a/hw/char/avr_usart.

[RFC PATCH 00/10] hw/avr: Introduce the Arduino board

2019-11-27 Thread Philippe Mathieu-Daudé
Hi Michael, I complained I'd rather have QEMU model real hardware, with documentation (schematics). Since your series is almost ready to get merged, I prefered to spend some time now to write down what I wanted. This is mostly a rewrite of your board, but matching the Arduino boards. Some bug sli

[NOTFORMERGE PATCH 01/10] hw/avr: Kludge to fix build failure

2019-11-27 Thread Philippe Mathieu-Daudé
Incomplete rename between Michael v36/v37 Signed-off-by: Philippe Mathieu-Daudé --- include/hw/char/avr_usart.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/char/avr_usart.h b/include/hw/char/avr_usart.h index 8e9ee88bbd..87f3f54cf8 100644 --- a/include/hw/char/avr_usart.h ++

RE: Network connection with COLO VM

2019-11-27 Thread Zhang, Chen
> -Original Message- > From: Dr. David Alan Gilbert > Sent: Wednesday, November 27, 2019 6:51 PM > To: Daniel Cho ; Zhang, Chen > ; lukasstra...@web.de > Cc: qemu-devel@nongnu.org > Subject: Re: Network connection with COLO VM > > * Daniel Cho (daniel...@qnap.com) wrote: > > Hello ever

Re: [PATCH 4/4] qom/object: Use common get/set uint helpers

2019-11-27 Thread Alexey Kardashevskiy
On 26/11/2019 20:39, Felipe Franciosi wrote: > > >> On Nov 26, 2019, at 8:39 AM, Marc-André Lureau >> wrote: >> >> Hi > > Heya, thanks for the review. > >> >> On Mon, Nov 25, 2019 at 7:37 PM Felipe Franciosi wrote: >>> >>> Several objects implemented their own uint property getters and se

Re: [PATCH v36 17/17] target/avr: Update MAINTAINERS file

2019-11-27 Thread Eduardo Habkost
On Tue, Nov 26, 2019 at 12:49:40AM +0100, Aleksandar Markovic wrote: > On Sunday, November 24, 2019, Michael Rolnik wrote: > > > Include AVR maintaners in MAINTAINERS file > > > > Signed-off-by: Michael Rolnik > > --- > > MAINTAINERS | 9 + > > 1 file changed, 9 insertions(+) > > > > di

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Jakub Kicinski
On Wed, 27 Nov 2019 15:32:17 -0500, Michael S. Tsirkin wrote: > On Tue, Nov 26, 2019 at 12:35:14PM -0800, Jakub Kicinski wrote: > > On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: > > > Note: This RFC has been sent to netdev as well as qemu-devel lists > > > > > > This series introduce

Re: [PATCH 1/2] analyze-migration.py: fix find() type error

2019-11-27 Thread Eduardo Habkost
On Wed, Nov 27, 2019 at 02:10:37PM +0400, Marc-André Lureau wrote: > Traceback (most recent call last): > File "../scripts/analyze-migration.py", line 611, in > dump.read(desc_only = True) > File "../scripts/analyze-migration.py", line 513, in read > self.load_vmsd_json(file) > File

[Bug 1853826] Re: ELF loader fails to load shared object on ThunderX2 running RHEL7

2019-11-27 Thread Caroline Concatto
Hi Alex, So, it works in some machines and others not. Mainly in machines with RHEL OS that we found the problem. What is the OS you are using? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1853826

Re: [PATCH v6] 9pfs: well form error hint helpers

2019-11-27 Thread Greg Kurz
On Wed, 27 Nov 2019 22:15:49 +0300 Vladimir Sementsov-Ogievskiy wrote: > Make error_append_security_model_hint and > error_append_socket_sockfd_hint hint append helpers well formed: > rename errp to errp_in, as it is IN-parameter here (which is unusual > for errp). > > Signed-off-by: Vladimir Se

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 10:31 PM, Aleksandar Markovic wrote: On Wed, Nov 27, 2019 at 10:17 PM Philippe Mathieu-Daudé wrote: Hi Aleksandar, On 11/27/19 7:47 PM, Aleksandar Markovic wrote: On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé wrote: The r4k machine was introduced in 2005 (6af0bf9c7)

Re: [PATCH v6] ppc: well form kvmppc_hint_smt_possible error hint helper

2019-11-27 Thread Greg Kurz
On Wed, 27 Nov 2019 22:14:34 +0300 Vladimir Sementsov-Ogievskiy wrote: > Make kvmppc_hint_smt_possible hint append helper well formed: > rename errp to errp_in, as it is IN-parameter here (which is unusual > for errp), rename function to be kvmppc_error_append_*_hint. > > Signed-off-by: Vladimir

Re: [PATCH v37 02/17] target/avr: Add instruction helpers

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 6:52 PM, Michael Rolnik wrote: Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of perip

Re: [PATCH v37 01/17] target/avr: Add outward facing interfaces and core CPU logic

2019-11-27 Thread Philippe Mathieu-Daudé
Hi Michael, On 11/27/19 6:52 PM, Michael Rolnik wrote: This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris Signed-off-by: Michael Rolnik Signed-off-by: Sarah Harris Signed-o

[PATCH 1/2] exec: flush CPU TB cache in breakpoint_invalidate

2019-11-27 Thread Max Filippov
When a breakpoint is inserted at location for which there's currently no virtual to physical translation no action is taken on CPU TB cache. If a TB for that virtual address already exists but is not visible ATM the breakpoint won't be hit next time an instruction at that address will be executed.

[PATCH 2/2] exec: drop tb_invalidate_phys_addr

2019-11-27 Thread Max Filippov
The only remaining user of tb_invalidate_phys_addr is target/xtensa instruction breakpoint code and it is better to use tb_flush there. Drop tb_invalidate_phys_addr implementations and declarations. Use tb_flush in xtensa IBREAK helpers. Signed-off-by: Max Filippov --- exec.c

[PATCH 0/2] flush CPU TB cache in breakpoint_invalidate

2019-11-27 Thread Max Filippov
Hello, this series changes breakpoint_invalidate to unconditionally do tb_flush and then changes remaining users of tb_invalidate_phys_addr to do the same and removes tb_invalidate_phys_addr. Changes RFC->v1: - do tb_flush in breakpoint_invalidate unconditionally - add tb_invalidate_phys_addr cle

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Aleksandar Markovic
On Wed, Nov 27, 2019 at 10:17 PM Philippe Mathieu-Daudé wrote: > > Hi Aleksandar, > > On 11/27/19 7:47 PM, Aleksandar Markovic wrote: > > On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé > > wrote: > >> > >> The r4k machine was introduced in 2005 (6af0bf9c7) and its last > >> logical chang

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Aleksandar Markovic
On Wed, Nov 27, 2019 at 10:17 PM Philippe Mathieu-Daudé wrote: > > Hi Aleksandar, > > On 11/27/19 7:47 PM, Aleksandar Markovic wrote: > > On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé > > wrote: > >> > >> The r4k machine was introduced in 2005 (6af0bf9c7) and its last > >> logical chang

Re: [PATCH 1/4] block/quorum.c: stable children names

2019-11-27 Thread Lukas Straub
On Tue, 26 Nov 2019 15:21:37 +0100 Alberto Garcia wrote: > On Thu 21 Nov 2019 07:34:45 PM CET, Lukas Straub wrote: > >> > diff --git a/block/quorum.c b/block/quorum.c > >> > index df68adcfaa..6100d4108a 100644 > >> > --- a/block/quorum.c > >> > +++ b/block/quorum.c > >> > @@ -1054,6 +1054,12 @@ s

Re: [PATCH] travis.yml: Run tcg tests with tci

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 7:38 PM, Alex Bennée wrote: Thomas Huth writes: So far we only have compile coverage for tci. But since commit 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation for INDEX_op_ld16u_i64") has been included, we can also run the x86 TCG tests with tci, so let's enable

Re: [PATCH 0/4] colo: Introduce resource agent and high-level test

2019-11-27 Thread Lukas Straub
On Fri, 22 Nov 2019 09:46:46 + "Dr. David Alan Gilbert" wrote: > * Lukas Straub (lukasstra...@web.de) wrote: > > Hello Everyone, > > These patches introduce a resource agent for use with the Pacemaker CRM and > > a > > high-level test utilizing it for testing qemu COLO. > > > > The resource

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 11/27/19 7:47 PM, Aleksandar Markovic wrote: On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé wrote: The r4k machine was introduced in 2005 (6af0bf9c7) and its last logical change was in 2005 (9542611a6). After we can count 164 maintenance commits (QEMU API changes) w

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 8:40 PM, Aleksandar Markovic wrote: On Mon, Nov 25, 2019 at 4:40 PM Daniel P. Berrangé wrote: On Mon, Nov 25, 2019 at 03:45:35PM +0100, Aleksandar Markovic wrote: On Monday, November 25, 2019, Philippe Mathieu-Daudé wrote: The r4k machine was introduced in 2005 (6af0bf9c7) and

Re: [PATCH v37 00/17] QEMU AVR 8 bit cores

2019-11-27 Thread Aleksandar Markovic
On Wed, Nov 27, 2019 at 6:53 PM Michael Rolnik wrote: > > This series of patches adds 8bit AVR cores to QEMU. > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested > yet. > However I was able to execute simple code with functions. e.g fibonacci > calculation. > This ser

Re: [RFC net-next 15/18] virtio_net: implement XDP prog offload functionality

2019-11-27 Thread Michael S. Tsirkin
On Tue, Nov 26, 2019 at 07:07:41PM +0900, Prashant Bhole wrote: > From: Jason Wang > > This patch implements bpf_prog_offload_ops callbacks and adds handling > for XDP_SETUP_PROG_HW. Handling of XDP_SETUP_PROG_HW involves setting > up struct virtio_net_ctrl_ebpf_prog and appending program instruc

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Michael S. Tsirkin
On Tue, Nov 26, 2019 at 12:35:14PM -0800, Jakub Kicinski wrote: > On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: > > Note: This RFC has been sent to netdev as well as qemu-devel lists > > > > This series introduces XDP offloading from virtio_net. It is based on > > the following work by

Re: [PATCH for-5.0 v2 0/3] benchmark util

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
27.11.2019 22:58, Aleksandar Markovic wrote: > On Tue, Nov 26, 2019 at 4:49 PM Vladimir Sementsov-Ogievskiy > wrote: >> >> Hi all! >> >> Here is simple benchmarking utility, to generate performance >> comparison tables, like the following: >> >> -- - - --

Re: [PATCH v6] nbd: well form nbd_iter_channel_error errp handler

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
27.11.2019 22:49, Eric Blake wrote: > [adding Markus] > > On 11/27/19 1:08 PM, Vladimir Sementsov-Ogievskiy wrote: >> Make nbd_iter_channel_error errp handler well formed: >> rename local_err to errp_in, as it is IN-parameter here (which is >> unusual for Error**). >> >> Signed-off-by: Vladimir Se

Re: [PATCH v36 11/17] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-27 Thread Aleksandar Markovic
On Wed, Nov 27, 2019 at 7:43 PM Aleksandar Markovic wrote: > > > > +/* Offsets of registers. */ > > > +#define USART_DR 0x06 > > > +#define USART_CSRA 0x00 > > > +#define USART_CSRB 0x01 > > > +#define USART_CSRC 0x02 > > > +#define USART_BRRH 0x05 > > > +#define USART_BRRL 0x04 > > > + > > >

Re: [PATCH for-5.0 v2 0/3] benchmark util

2019-11-27 Thread Aleksandar Markovic
On Tue, Nov 26, 2019 at 4:49 PM Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > Here is simple benchmarking utility, to generate performance > comparison tables, like the following: > > -- - - - > backup-1 backup-2 mirror >

[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
No reason for local_err here, use errp directly instead. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v6: keep return code checking [Cornelia] hw/vfio/ap.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index da6a20669d..8fbaa724c2 1

Re: [PATCH v6] nbd: well form nbd_iter_channel_error errp handler

2019-11-27 Thread Eric Blake
[adding Markus] On 11/27/19 1:08 PM, Vladimir Sementsov-Ogievskiy wrote: Make nbd_iter_channel_error errp handler well formed: rename local_err to errp_in, as it is IN-parameter here (which is unusual for Error**). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- v6: f

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-27 Thread Jakub Kicinski
On Wed, 27 Nov 2019 10:59:37 +0800, Jason Wang wrote: > On 2019/11/27 上午4:35, Jakub Kicinski wrote: > > On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: > >> Note: This RFC has been sent to netdev as well as qemu-devel lists > >> > >> This series introduces XDP offloading from virtio_net

[PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
No reason for local_err here, use errp directly instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- v6: add r-b by Philippe and Marc-André backends/cryptodev.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletio

[PATCH v6] include/qom/object.h: rename Error ** parameter to more common errp

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daudé --- v6: add r-b by Philippe include/qom/object.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 128d00c77f..716f6f655d 100644 --- a/include

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 4:40 PM Daniel P. Berrangé wrote: > > On Mon, Nov 25, 2019 at 03:45:35PM +0100, Aleksandar Markovic wrote: > > On Monday, November 25, 2019, Philippe Mathieu-Daudé > > wrote: > > > > > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > > > logical change was

[PATCH v6] hw/usb: rename Error ** parameter to more common errp

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/usb/dev-network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c index 5de6213cc4..b81a8abe83 100644 --- a/hw/usb/dev-network.c +++ b/hw/usb/dev-network.c @@ -1342,7 +1342,7 @@ stat

[PATCH v6] hw/tpm: rename Error ** parameter to more common errp

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger --- v6: add Stefan's r-b hw/tpm/tpm_emulator.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c index 22f9113432..10d587ed40 100644 --- a/hw/tpm/tpm_e

[PATCH v6] hw/sd: drop extra whitespace in sdhci_sysbus_realize() header

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- v6: improve patch subject (was [RFC v5 016/126] hw/sd: rename Error ** parameter to more common errp) add Eric's r-b hw/sd/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd

[PATCH v6] hw/s390x: rename Error ** parameter to more common errp

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Cornelia Huck --- v6: add Cornelia's r-b hw/s390x/event-facility.c | 2 +- hw/s390x/s390-stattrib.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c index 6620

[PATCH v6] monitor/qmp-cmds: rename Error ** parameter to more common errp

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- monitor/qmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c index 0880341a2d..c6faa3eaf0 100644 --- a/monitor/qmp-cmds.c +++ b/monitor/qmp-cmds.c @@ -109,7 +109,7 @@ void qmp_system_

[PATCH v6] qga: rename Error ** parameter to more common errp

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- qga/commands-posix.c | 2 +- qga/commands-win32.c | 2 +- qga/commands.c | 12 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 1c1a165dae..3bd7b54c08 100644 --- a/

Re: [PATCH v36 11/17] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-27 Thread Aleksandar Markovic
On Wed, Nov 27, 2019 at 7:48 PM Michael Rolnik wrote: > > too late :) > There will be opportunities in future versions. Whaaat, did you really think you would get away with only 37 versions? ;-)

[PATCH v6] hw/i386/amd_iommu: rename Error ** parameter to more common errp

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/i386/amd_iommu.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index d55dbf07fc..b1175e52c7 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -1533,7 +1533

[PATCH v6] block/snapshot: rename Error ** parameter to more common errp

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- v6: merge corresponding header change here, so, v6 is merge of [RFC v5 011/126] block/snapshot: rename Error ** parameter to more common errp and [RFC v5 019/126] include/block/snapshot.h: rename Error ** parameter to

[PATCH v6] hw/core/qdev: cleanup Error ** variables

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Rename Error ** parameter in check_only_migratable to common errp. In device_set_realized: - Move "if (local_err != NULL)" closer to error setters. - Drop 'Error **local_errp': it doesn't save any LoCs, but it's very unusual. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric B

Re: [RFC] exec: flush CPU TB cache when breakpoint address translation fails

2019-11-27 Thread Max Filippov
On Wed, Nov 27, 2019 at 11:06 AM Alex Bennée wrote: > Max Filippov writes: > > > When a breakpoint is inserted at location for which there's currently no > > virtual to physical translation no action is taken on CPU TB cache. If a > > TB for that virtual address already exists but is not visible

[PATCH v6] 9pfs: well form error hint helpers

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Make error_append_security_model_hint and error_append_socket_sockfd_hint hint append helpers well formed: rename errp to errp_in, as it is IN-parameter here (which is unusual for errp). Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Greg Kurz --- v6: add Greg's a-b hw/9pfs/9p-local.c

[PATCH v6] ppc: well form kvmppc_hint_smt_possible error hint helper

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Make kvmppc_hint_smt_possible hint append helper well formed: rename errp to errp_in, as it is IN-parameter here (which is unusual for errp), rename function to be kvmppc_error_append_*_hint. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Marc-André Lureau --- v6: keep kvmppc_ functio

[PATCH v6] nbd: well form nbd_iter_channel_error errp handler

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Make nbd_iter_channel_error errp handler well formed: rename local_err to errp_in, as it is IN-parameter here (which is unusual for Error**). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- v6: fix commit message add Eric's r-b block/nbd.c | 10 +- 1 file c

Re: [Virtio-fs] [PATCH 4/4] virtiofsd: Implement blocking posix locks

2019-11-27 Thread Vivek Goyal
On Tue, Nov 26, 2019 at 01:02:29PM +, Dr. David Alan Gilbert wrote: [..] > > > > @@ -1950,21 +1948,54 @@ static void lo_setlk(fuse_req_t req, fuse_ino_t > > > > ino, > > > > > > > > if (!plock) { > > > > saverr = ret; > > > > + pthread_mutex_unlock(&ino

Re: [RFC] exec: flush CPU TB cache when breakpoint address translation fails

2019-11-27 Thread Alex Bennée
Max Filippov writes: > When a breakpoint is inserted at location for which there's currently no > virtual to physical translation no action is taken on CPU TB cache. If a > TB for that virtual address already exists but is not visible ATM the > breakpoint won't be hit next time an instruction a

  1   2   3   >