Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-16 Thread Alex Williamson
On Sun, 17 Nov 2019 01:20:19 -0200 Marcelo Tosatti wrote: > On Sat, Nov 16, 2019 at 01:58:55PM -0700, Alex Williamson wrote: > > On Thu, 10 Oct 2019 09:30:08 -0300 > > Marcelo Tosatti wrote: > > > > > commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt > > > reinjection when

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-16 Thread Marcelo Tosatti
On Sat, Nov 16, 2019 at 01:58:55PM -0700, Alex Williamson wrote: > On Thu, 10 Oct 2019 09:30:08 -0300 > Marcelo Tosatti wrote: > > > commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt > > reinjection when there is no period change by the guest. > > > > In that case, old_period

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-16 Thread Alex Williamson
On Thu, 10 Oct 2019 09:30:08 -0300 Marcelo Tosatti wrote: > commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt > reinjection when there is no period change by the guest. > > In that case, old_period is 0, which ends up zeroing irq_coalesced > (counter of reinjected interrupts)

Re: [PATCH] buildfix: update texinfo menu

2019-11-16 Thread Laszlo Ersek
On 10/23/19 12:19, Gerd Hoffmann wrote: > Build error message: > qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' > despite being its Up target > > Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter") > Signed-off-by: Gerd Hoffmann > --- > qemu

Re: [Qemu-devel] [PULL 22/26] libvhost-user: Support tracking inflight I/O in shared memory

2019-11-16 Thread Marc-André Lureau
On Wed, Mar 13, 2019 at 6:59 AM Michael S. Tsirkin wrote: > > From: Xie Yongji > > This patch adds support for VHOST_USER_GET_INFLIGHT_FD and > VHOST_USER_SET_INFLIGHT_FD message to set/get shared buffer > to/from qemu. Then backend can track inflight I/O in this buffer. > > Signed-off-by: Xie Yo

[PATCH 4/4] block/io: fix bdrv_is_allocated_above

2019-11-16 Thread Vladimir Sementsov-Ogievskiy
bdrv_is_allocated_above wrongly handles short backing files: it reports after-EOF space as UNALLOCATED which is wrong, as on read the data is generated on the level of short backing file (if all overlays has unallocated area at that place). Reusing bdrv_common_block_status_above fixes the issue an

[PATCH 2/4] block/io: bdrv_common_block_status_above: support include_base

2019-11-16 Thread Vladimir Sementsov-Ogievskiy
In order to reuse bdrv_common_block_status_above in bdrv_is_allocated_above, let's support include_base parameter. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/block/io.c b/block/io.c index 4d7f

[PATCH 3/4] block/io: bdrv_common_block_status_above: support bs == base

2019-11-16 Thread Vladimir Sementsov-Ogievskiy
We are going to reuse bdrv_common_block_status_above in bdrv_is_allocated_above. bdrv_is_allocated_above may be called with include_base == false and still bs == base (for ex. from img_rebase()). So, support this corner case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 6 +-

[PATCH 1/4] block/io: fix bdrv_co_block_status_above

2019-11-16 Thread Vladimir Sementsov-Ogievskiy
bdrv_co_block_status_above has several problems with handling short backing files: 1. With want_zeros=true, it may return ret with BDRV_BLOCK_ZERO but without BDRV_BLOCK_ALLOCATED flag, when actually short backing file which produces these after-EOF zeros is inside requested backing sequesnce. 2.

[PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-16 Thread Vladimir Sementsov-Ogievskiy
Hi all! I wanted to understand, what is the real difference between bdrv_block_status_above and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above should work through bdrv_block_status_above.. And I found the problem: bdrv_is_allocated_above considers space after EOF as UNALLOCATED for interm

DROP Re: bdrv_is_allocated_above bug or feature

2019-11-16 Thread Vladimir Sementsov-Ogievskiy
Please don't answer, I'll resend it as a cover letter for proposed series to fix these things. 16.11.2019 17:18, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > I wanted to understand, what is the real difference between > bdrv_block_status_above > and bdrv_is_allocated_above, IMHO bdrv_is_al

[PATCH] riscv: sifive_u: Add a "serial" property for board serial number

2019-11-16 Thread Bin Meng
At present the board serial number is hard-coded to 1, and passed to OTP model during initialization. Firmware (FSBL, U-Boot) uses the serial number to generate a unique MAC address for the on-chip ethernet controller. When multiple QEMU 'sifive_u' instances are created and connected to the same su

bdrv_is_allocated_above bug or feature

2019-11-16 Thread Vladimir Sementsov-Ogievskiy
Hi all! I wanted to understand, what is the real difference between bdrv_block_status_above and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above should work through bdrv_block_status_above.. And I found the difference: bdrv_is_allocated_above considers space after EOF as UNALLOCATED for int

Re: [PATCH v1 2/5] qemu_log_lock/unlock now preserves the qemu_logfile handle.

2019-11-16 Thread Richard Henderson
On 11/12/19 4:01 PM, Robert Foley wrote: > qemu_log_lock() now returns a handle and qemu_log_unlock() receives a > handle to unlock. This allows for changing the handle during logging > and ensures the lock() and unlock() are for the same file. > > Signed-off-by: Robert Foley > --- > v1 > -

Re: [PATCH v1 1/5] Add a mutex to guarantee single writer to qemu_logfile handle.

2019-11-16 Thread Richard Henderson
On 11/12/19 4:01 PM, Robert Foley wrote: > Also added qemu_logfile_init() for initializing the logfile mutex. > > Signed-off-by: Robert Foley > --- > v1 > - changed qemu_logfile_init() to use __constructor__. > --- > util/log.c | 14 ++ > 1 file changed, 14 insertions(+) > > dif

[PATCH] vhost-user-fs: remove "vhostfd" property

2019-11-16 Thread Marc-André Lureau
The property doesn't make much sense for a vhost-user device. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user-fs.c | 1 - include/hw/virtio/vhost-user-fs.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c index f0df7f474

[PATCH v2] target/arm: Merge arm_cpu_vq_map_next_smaller into sole caller

2019-11-16 Thread Richard Henderson
Coverity reports, in sve_zcr_get_valid_len, "Subtract operation overflows on operands arm_cpu_vq_map_next_smaller(cpu, start_vq + 1U) and 1U" First, the aarch32 stub version of arm_cpu_vq_map_next_smaller, returning 0, does exactly what Coverity reports. Remove it. Second, the aarch64 version o

Re: [PATCH v2 2/2] iotests: add 269 to check maximum of bitmaps in qcow2

2019-11-16 Thread Vladimir Sementsov-Ogievskiy
25.10.2019 16:12, Max Reitz wrote: > On 14.10.19 13:51, Vladimir Sementsov-Ogievskiy wrote: >> Check that it's impossible to create more persistent bitmaps than qcow2 >> supports. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/qemu-iotests/269 | 47

Re: [RFC 21/24] backup: move to block-copy

2019-11-16 Thread Vladimir Sementsov-Ogievskiy
15.11.2019 20:58, Eric Blake wrote: > On 11/15/19 8:14 AM, Vladimir Sementsov-Ogievskiy wrote: >> This brings async request handling and block-status driven chunk sizes >> to backup out of the box, which improves backup performance. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- > >> ++

ui/gtk: fix gettext message's charset. #85

2019-11-16 Thread 颜闽辉
Detail see: https://github.com/qemu/qemu/pull/85 0001-ui-gtk-fix-gettext-message-s-charset.patch Description: Binary data