Not all ARM machines sections Cc the qemu-...@nongnu.org list,
fix this.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 47eae9fc46..65fbc6d7b4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -805,6 +805
Add the Siemens SX1 (OMAP310) machines with the other ARM machines.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 65fbc6d7b4..87afc1126a 100644
--- a/MAINTAINERS
+++ b/MAINT
The hw/sd/ssi-sd.c file is orphean, add it to the SD section.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3ca814850e..47eae9fc46 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1445,6 +1445,7 @@ S: Odd F
Few fixes after looking at Vladimir's commit-per-subsystem.py script:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg651545.html
Philippe Mathieu-Daudé (3):
MAINTAINERS: Add hw/sd/ssi-sd.c in the SD section
MAINTAINERS: Cc the qemu-...@nongnu.org for the ARM machines
MAINTAINERS: Move
On 10/11/19 6:05 PM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hint
On 10/11/19 6:05 PM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hint
On 10/11/19 6:05 PM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hint
On 10/11/19 6:05 PM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hint
On 10/11/19 6:05 PM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hint
Hi Vladimir,
On 10/11/19 6:04 PM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the err
On 10/11/19 6:04 PM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hint
On 10/11/19 6:04 PM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hint
On 10/11/19 6:04 PM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hint
On 10/11/19 6:04 PM, Vladimir Sementsov-Ogievskiy wrote:
No reason for local_err here, use errp directly instead.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
backends/cryptodev.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/backends/cryptodev.c b/backen
On 10/11/19 6:04 PM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/qom/object.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index 128d00c77f..716f6f655d 100644
--- a/include/q
On 10/11/19 6:03 PM, Vladimir Sementsov-Ogievskiy wrote:
Variable int err in inner scope shadows Error *err in outer scope.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
net/net.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git
Hello, everyone
May I know you have comments on this patch set? Thank you!
BRs
Qi Zhang
> -Original Message-
> From: Zhang, Qi1
> Sent: Tuesday, October 8, 2019 10:35 AM
> To: qemu-devel@nongnu.org
> Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
> r...@twiddle.net
From: Tianyu Lan
Hyper-V direct tlb flush targets KVM on Hyper-V guest.
Enable direct TLB flush for its guests meaning that TLB
flush hypercalls are handled by Level 0 hypervisor (Hyper-V)
bypassing KVM in Level 1. Due to the different ABI for hypercall
parameters between Hyper-V and KVM, KVM cap
On Mon, Mar 05, 2018 at 12:48:36AM +0800, Luwei Kang wrote:
> From: Chao Peng
>
> Add Intel Processor Trace related definition. It also add
> corresponding part to kvm_get/set_msr and vmstate.
>
> Signed-off-by: Chao Peng
> Signed-off-by: Luwei Kang
[...]
> diff --git a/target/i386/kvm.c b/tar
On 10/11/2019 10:08 PM, Igor Mammedov wrote:
On Thu, 10 Oct 2019 14:53:56 +0800
Tao Xu wrote:
On 10/3/2019 10:41 PM, Igor Mammedov wrote:
On Fri, 20 Sep 2019 15:43:47 +0800
Tao Xu wrote:
From: Liu Jingqi
This structure describes the memory access latency and bandwidth
information from
Add new version of Snowridge CPU model that removes MPX feature.
MPX support is being phased out by Intel. GCC has dropped it, Linux kernel
and KVM are also going to do that in the future.
Signed-off-by: Xiaoyao Li
---
Changes in v3:
- Remove the .alias field (ehabkost)
Changes in v2:
Patchew URL:
https://patchew.org/QEMU/20191011160552.22907-1-vsement...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [RFC v5 000/126] error: auto propagated local_err
Type: series
Message-id: 20191011160552.22907-1-vs
On 10/11/2019 9:56 PM, Igor Mammedov wrote:
On Wed, 9 Oct 2019 14:39:46 +0800
Tao Xu wrote:
On 10/2/2019 11:16 PM, Igor Mammedov wrote:
On Fri, 20 Sep 2019 15:43:44 +0800
Tao Xu wrote:
[...]
+struct HMAT_LB_Info {
+/* Indicates it's memory or the specified level memory side cache.
On Thu, Aug 29, 2019 at 01:22:55PM +0800, Luwei Kang wrote:
> This patch add a new feature words for IA32_PERF_CAPABILITIES (RO)
> register that serve to expose PEBS output Intel PT feature.
> The registers relate with PEBS need to be set/get when PEBS output
> Intel PT is supported in guest.
>
>
In current logic, if compress_threads_save_setup() returns -1 the whole
migration would fail, while we could handle it gracefully by disable
compress.
Signed-off-by: Wei Yang
---
migration/migration.c | 9 +
migration/migration.h | 1 +
migration/ram.c | 15 ---
3 fil
Two patches related to compress:
1. simplify the check since compress QEMUFile is not writable
2. handle compress setup failure gracefully
Wei Yang (2):
migration/compress: compress QEMUFile is not writable
migration/compress: disable compress if failed to setup
migration/migration.c | 9 +
We open a file with empty_ops for compress QEMUFile, which means this is
not writable.
Signed-off-by: Wei Yang
---
migration/qemu-file.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 26fb25ddc1..f3d99a96e
How do you know that the access won't straddle a page boundary? Is there a
guarantee somewhere that size=0 means that the access is naturally aligned?
Jonathan
On Fri, Oct 11, 2019 at 7:14 PM Dayeol Lee wrote:
> riscv_cpu_tlb_fill() uses the `size` parameter to check PMP violation
> using pmp_
Patchew URL:
https://patchew.org/QEMU/20191011160552.22907-1-vsement...@virtuozzo.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEG
On Sat, Oct 12, 2019 at 09:31:25AM +0800, Xiaoyao Li wrote:
> On 10/12/2019 9:21 AM, Eduardo Habkost wrote:
> > On Sat, Oct 12, 2019 at 09:15:56AM +0800, Xiaoyao Li wrote:
> > > On 10/12/2019 2:21 AM, Eduardo Habkost wrote:
> > > > On Fri, Oct 11, 2019 at 10:53:49PM +0800, Xiaoyao Li wrote:
> > > >
On 10/12/2019 9:21 AM, Eduardo Habkost wrote:
On Sat, Oct 12, 2019 at 09:15:56AM +0800, Xiaoyao Li wrote:
On 10/12/2019 2:21 AM, Eduardo Habkost wrote:
On Fri, Oct 11, 2019 at 10:53:49PM +0800, Xiaoyao Li wrote:
Add new version of Snowridge CPU model that removes MPX feature.
MPX support is b
On Sat, Oct 12, 2019 at 09:15:56AM +0800, Xiaoyao Li wrote:
> On 10/12/2019 2:21 AM, Eduardo Habkost wrote:
> > On Fri, Oct 11, 2019 at 10:53:49PM +0800, Xiaoyao Li wrote:
> > > Add new version of Snowridge CPU model that removes MPX feature.
> > >
> > > MPX support is being phased out by Intel. G
On 10/12/2019 2:21 AM, Eduardo Habkost wrote:
On Fri, Oct 11, 2019 at 10:53:49PM +0800, Xiaoyao Li wrote:
Add new version of Snowridge CPU model that removes MPX feature.
MPX support is being phased out by Intel. GCC has dropped it, Linux kernel
and kvm are also going to do that in the future.
Patchew URL: https://patchew.org/QEMU/20191011175536.GB25464@xps13.dannf/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Bug 1805256] Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2
possible issues
Type: series
Message-id: 201
Patchew URL: https://patchew.org/QEMU/20191011175536.GB25464@xps13.dannf/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#! /bin/
On 7/24/19 5:06 PM, John Snow wrote:
> Has anyone on this list experimented with these tools?
>
> I was hoping to use them to document things like the python/machine.py
> and python/qmp.py modules to help demonstrate some of our internal
> tooling API (for test writers, GSoC/Outreachy interns,
On 10/11/19 8:18 AM, Max Reitz wrote:
> For long test image paths, the order of the "Formatting" line and the
> "(qemu)" prompt after a drive_backup HMP command may be reversed. In
> fact, the interaction between the prompt and the line may lead to the
> "Formatting" to being greppable at all a
On Fri, Oct 11, 2019 at 08:13:33AM +0200, Greg Kurz wrote:
> On Fri, 11 Oct 2019 16:07:58 +1100
> David Gibson wrote:
>
> > On Thu, Oct 10, 2019 at 10:33:04PM +0200, Greg Kurz wrote:
> > > On Thu, 10 Oct 2019 08:29:58 +0200
> > > Greg Kurz wrote:
> > >
> > > > On Thu, 10 Oct 2019 13:02:09 +1100
On 10/4/19 11:39 AM, Max Reitz wrote:
> On 18.09.19 01:45, John Snow wrote:
>> This series uses python logging to enable output conditionally on
>> iotests.log(). We unify an initialization call (which also enables
>> debugging output for those tests with -d) and then make the switch
>> inside o
On 10/11/19 5:48 PM, Eric Blake wrote:
> On 10/11/19 4:25 PM, John Snow wrote:
>> From: Vladimir Sementsov-Ogievskiy
>>
>> hbitmap_reset has an unobvious property: it rounds requested region up.
>> It may provoke bugs, like in recently fixed write-blocking mode of
>> mirror: user calls reset on
Hi, Alistair,
Thank you for reminding me.
I already had the local patch, so I re-submitted the patch.
Please let me know if that's fair enough (or you have any other comments)
Thanks,
Dayeol
On Fri, Oct 11, 2019 at 3:24 PM Alistair Francis
wrote:
> On Sun, Oct 6, 2019 at 1:32 AM Chris William
riscv_cpu_tlb_fill() uses the `size` parameter to check PMP violation
using pmp_hart_has_privs().
However, if the size is unknown (=0), the ending address will be
`addr - 1` as it is `addr + size - 1` in `pmp_hart_has_privs()`.
This always causes a false PMP violation on the starting address of the
On Sun, Oct 6, 2019 at 1:32 AM Chris Williams wrote:
>
> Hello. I hope you don't mind me resubmitting this patch. Please let me know if
Not at all!
Thanks for the patch.
In future if people don't respond you can just keep pinging your patch.
> I've formatted it incorrectly or if it needs more
On Mon, Oct 7, 2019 at 10:18 AM Philippe Mathieu-Daudé wrote:
>
> The miniuart code is already present in the multi-device
> hw/char/bcm2835_aux.c. Simply extracting it does not generate
> patch easy to review. Instead, add it again, rename the function
> names accordingly, use the "hw/registerfie
On Tue, Oct 8, 2019 at 2:43 AM Philippe Mathieu-Daudé wrote:
>
> Hi Alistair,
>
> On 9/27/19 11:42 PM, Alistair Francis wrote:
> > On Thu, Sep 26, 2019 at 10:44 AM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> Base addresses and sizes taken from the "BCM2835 ARM Peripherals"
> >> datasheet from F
On 10/11/19 3:55 PM, Kevin Wolf wrote:
Instead of parsing help options as normal object properties and
returning an error, provide the same help functionality as the system
emulator in qemu-io, too.
Signed-off-by: Kevin Wolf
---
qemu-io.c | 9 -
1 file changed, 8 insertions(+), 1 del
I know we've talked about enforcing a VPATH build, but haven't yet
flipped the switch. This week, I've played with using a VPATH build (cd
qemu; mkdir -p build; cd ./build; ../configure ...; make ...), but find
my old habits of expecting an in-tree build to just work (cd qemu; make
...) hard t
On 10/11/19 4:25 PM, John Snow wrote:
From: Vladimir Sementsov-Ogievskiy
hbitmap_reset has an unobvious property: it rounds requested region up.
It may provoke bugs, like in recently fixed write-blocking mode of
mirror: user calls reset on unaligned region, not keeping in mind that
there are po
From: Vladimir Sementsov-Ogievskiy
- Correct check for write access to file child, and in correct place
(only if we want to write).
- Support reopen rw -> rw (which will be used in following commit),
for example, !bdrv_dirty_bitmap_readonly() is not a corruption if
bitmap is marked IN_USE i
On 10/11/19 3:55 PM, Kevin Wolf wrote:
Instead of parsing help options as normal object properties and
returning an error, provide the same help functionality as the system
emulator in qemu-img, too.
Signed-off-by: Kevin Wolf
---
qemu-img.c | 34 +-
1 file cha
On 10/11/19 3:55 PM, Kevin Wolf wrote:
Printing help for --object is something that we don't only want in the
s/don't/not/
system emulator, but also in tools that support --object. Move it into a
separate function in qom/object_interfaces.c to make the code accessible
for tools.
Signed-off-b
From: Vladimir Sementsov-Ogievskiy
qcow2_reopen_bitmaps_ro wants to store bitmaps and then mark them all
readonly. But the latter don't work, as
qcow2_store_persistent_dirty_bitmaps removes bitmaps after storing.
It's OK for inactivation but bad idea for reopen-ro. And this leads to
the following
On 10/11/19 3:55 PM, Kevin Wolf wrote:
Instead of parsing help options as normal object properties and
returning an error, provide the same help functionality as the system
emulator in qemu-nbd, too.
Signed-off-by: Kevin Wolf
---
qemu-nbd.c | 9 -
1 file changed, 8 insertions(+), 1 d
This parameter has been deprecated since 2.12.0 and is eligible for
removal. Remove this parameter as it is actually completely ignored;
let's not give false hope.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20191002232411.29968-1-js...
From: Vladimir Sementsov-Ogievskiy
Reopening bitmaps to RW was broken prior to previous commit. Check that
it works now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-4-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
tests/qemu-iotests/165 | 57
I already try to make sure all bitmaps patches have been reviewed by both
Red Hat and Virtuozzo anyway, so this formalizes the arrangement.
Fam meanwhile is no longer as active, so I am removing him as a co-maintainer
simply to reflect the current practice.
Signed-off-by: John Snow
Reviewed-by:
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-8-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
tests/qemu-iotests/260 | 89 ++
tests/qemu-iotests/260.out | 52 ++
From: Vladimir Sementsov-Ogievskiy
The only reason I can imagine for this strange code at the very-end of
bdrv_reopen_commit is the fact that bs->read_only updated after
calling drv->bdrv_reopen_commit in bdrv_reopen_commit. And in the same
time, prior to previous commit, qcow2_reopen_bitmaps_rw
From: Vladimir Sementsov-Ogievskiy
bdrv_dirty_bitmap_next is always used in same pattern. So, split it
into _next and _first, instead of combining two functions into one and
add FOR_EACH_DIRTY_BITMAP macro.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916
From: Vladimir Sementsov-Ogievskiy
Firstly, no reason to optimize failure path. Then, function name is
ambiguous: it checks for readonly and similar things, but someone may
think that it will ignore normal bitmaps which was just unchanged, and
this is in bad relation with the fact that we should
From: Vladimir Sementsov-Ogievskiy
We'll need reverse-foreach in the following commit, QTAILQ support it,
so move to QTAILQ.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-id: 20190927122355.7344-2-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/bloc
From: Vladimir Sementsov-Ogievskiy
The function is unused, drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190927122355.7344-6-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 2 --
block/qcow2-bitmap.c | 15 +
From: Vladimir Sementsov-Ogievskiy
mutex field is just a pointer to bs->dirty_bitmap_mutex, so no needs
to store it in BdrvDirtyBitmap when we have bs pointer in it (since
previous patch).
Drop mutex field. Constantly use bdrv_dirty_bitmaps_lock/unlock in
block/dirty-bitmap.c to make it more obv
From: Vladimir Sementsov-Ogievskiy
It's needed to fix reopening qcow2 with bitmaps to RW. Currently it
can't work, as qcow2 needs write access to file child, to mark bitmaps
in-image with IN_USE flag. But usually children goes after parents in
reopen queue and file child is still RO on qcow2 reop
From: Vladimir Sementsov-Ogievskiy
Drop meta bitmaps, as they are unused.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916141911.5255-2-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/block/dirty-bitmap.h | 5
block/dirty-bitmap.c
From: Vladimir Sementsov-Ogievskiy
qmp_block_dirty_bitmap_add and do_block_dirty_bitmap_remove do acquire
aio context since 0a6c86d024c52b. But this is not enough: we also must
lock qcow2 mutex when access in-image metadata. Especially it concerns
freeing qcow2 clusters.
To achieve this, move qc
From: Vladimir Sementsov-Ogievskiy
It's more comfortable to not deal with local_err.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190920082543.23444-3-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 5 ++---
include/bl
From: Vladimir Sementsov-Ogievskiy
Add bs field to BdrvDirtyBitmap structure. Drop BlockDriverState
parameter from bitmap APIs where possible.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916141911.5255-3-vsement...@virtuozzo.com
Signed-off-by: John Snow
From: Vladimir Sementsov-Ogievskiy
hbitmap_reset has an unobvious property: it rounds requested region up.
It may provoke bugs, like in recently fixed write-blocking mode of
mirror: user calls reset on unaligned region, not keeping in mind that
there are possible unrelated dirty bytes, covered by
The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2019-10-08 16:08:35 +0100)
are available in the Git repository at:
https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request
From: Vladimir Sementsov-Ogievskiy
block/dirty-bitmap.c seems to be more appropriate for it and
bdrv_remove_persistent_dirty_bitmap already in it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190920082543.23444-2-vsement...@virtuozzo.com
Signed-off-by: John
On Friday, October 11, 2019, Alex Bennée wrote:
>
> Aleksandar Markovic writes:
>
> > On Friday, October 11, 2019, Philippe Mathieu-Daudé
> > wrote:
> >
> >> Hi Michael,
> >>
> >> On 9/2/19 4:01 PM, Michael Rolnik wrote:
> >>
> >>> This series of patches adds 8bit AVR cores to QEMU.
> >>> All i
Instead of parsing help options as normal object properties and
returning an error, provide the same help functionality as the system
emulator in qemu-nbd, too.
Signed-off-by: Kevin Wolf
---
qemu-nbd.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/qemu-nbd.c b/qemu-
Instead of parsing help options as normal object properties and
returning an error, provide the same help functionality as the system
emulator in qemu-io, too.
Signed-off-by: Kevin Wolf
---
qemu-io.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/qemu-io.c b/qemu-io.
Instead of parsing help options as normal object properties and
returning an error, provide the same help functionality as the system
emulator in qemu-img, too.
Signed-off-by: Kevin Wolf
---
qemu-img.c | 34 +-
1 file changed, 21 insertions(+), 13 deletions(-)
di
This series fixes that the tools don't consider help options for
--object and just treat them as regular object properties. For example:
$ ./qemu-io --object secret,help
qemu-io: Parameter 'id' is missing
With these patches, we get the expected behaviour like in the system
emulator.
Kevi
Printing help for --object is something that we don't only want in the
system emulator, but also in tools that support --object. Move it into a
separate function in qom/object_interfaces.c to make the code accessible
for tools.
Signed-off-by: Kevin Wolf
---
include/qom/object_interfaces.h | 12 +
On 10/11/19 6:02 AM, Vladimir Sementsov-Ogievskiy wrote:
> 10.10.2019 21:46, John Snow wrote:
>>
>>
>> On 10/10/19 11:39 AM, Eric Blake wrote:
>>> On 6/7/19 1:53 PM, Vladimir Sementsov-Ogievskiy wrote:
07.06.2019 21:48, Vladimir Sementsov-Ogievskiy wrote:
> qcow2_can_store_new_dirty_bit
On 10/11/19 5:12 AM, Peter Krempa wrote:
> On Thu, Oct 10, 2019 at 14:08:12 -0400, John Snow wrote:
>> On 10/10/19 7:54 AM, Peter Krempa wrote:
>>> On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote:
On 10/10/19 1:26 PM, Peter Krempa wrote:
>
> [...]
>
>>> To be honest,
Am 11.10.2019 um 22:05 hat Cleber Rosa geschrieben:
> On Fri, Oct 11, 2019 at 02:27:25PM +0300, Nir Soffer wrote:
> > On Fri, Oct 11, 2019, 12:36 Kevin Wolf wrote:
> >
> > > Am 09.10.2019 um 21:47 hat Cleber Rosa geschrieben:
> > > > Due to not being able to find a reason to have shebangs on file
On Fri, Oct 11, 2019 at 02:27:25PM +0300, Nir Soffer wrote:
> On Fri, Oct 11, 2019, 12:36 Kevin Wolf wrote:
>
> > Am 09.10.2019 um 21:47 hat Cleber Rosa geschrieben:
> > > Due to not being able to find a reason to have shebangs on files that
> > > are not executable.
> > >
> > > While at it, add
On 10/11/19 11:05 AM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hin
From: Wei Yang
MultiFDPacket_t's magic and version field never changes during
migration, so move these two fields in setup stage.
Signed-off-by: Wei Yang
Message-Id: <20191011085050.17622-4-richardw.y...@linux.intel.com>
Reviewed-by: Juan Quintela
Signed-off-by: Dr. David Alan Gilbert
---
mi
From: Wei Yang
Currently, we set PostcopyState blindly to RUNNING, even we found the
previous state is not LISTENING. This will lead to a corner case.
First let's look at the code flow:
qemu_loadvm_state_main()
ret = loadvm_process_command()
loadvm_postcopy_handle_run()
From: Wei Yang
There are two places to call function postcopy_ram_incoming_cleanup()
postcopy_ram_listen_thread on migration success
loadvm_postcopy_handle_listen one setup failure
On success, the vm will never accept another migration. On failure,
PostcopyState is transited from LISTEN
From: Wei Yang
If mis->have_listen_thread is true, this means current PostcopyState
must be LISTENING or RUNNING. While the check at the beginning of the
function makes sure the state transaction happens when its previous
PostcopyState is ADVISE or DISCARD.
This means we would never touch this c
Patchew URL:
https://patchew.org/QEMU/20191011134744.2477-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v5 00/22] target/arm: Implement ARMv8.5-MemTag, system mode
Type: series
Message-id: 20191
On 10/11/19 11:05 AM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hin
On 10/11/19 11:05 AM, Vladimir Sementsov-Ogievskiy wrote:
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &fatal_err
(the program will exit prior to the error_append_hin
From: Wei Yang
Signed-off-by: Wei Yang
Message-Id: <20191005220517.24029-3-richardw.y...@linux.intel.com>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Dr. David Alan Gilbert
---
migration/postcopy-ram.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/migratio
Hi Gautam,
On 10/11/19 8:47 PM, Gautam Bhat wrote:
Hi,
I want to add some I2C based temperature sensors to the -M Q35 machine.
I want to update the ACPI tables to add this device information. How can
I go about doing this?
QEMU provides a MAINTAINERS file with persons to contact sorted by
From: Eric Auger
Introduce support for GTree migration. A custom save/restore
is implemented. Each item is made of a key and a data.
If the key is a pointer to an object, 2 VMSDs are passed into
the GTree VMStateField.
When putting the items, the tree is traversed in sorted order by
g_tree_fore
From: "Dr. David Alan Gilbert"
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Daniel P. Berrangé
Message-Id: <20191007143642.301445-6-dgilb...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
exec.c | 116 ++---
include/exec/ram_addr.h | 1
From: Wei Yang
multifd_send_fill_packet() prepares meta data for following pages to
transfer. It would be more proper to fill pages->allocated instead of
static max value, especially we want to support flexible packet size.
Signed-off-by: Wei Yang
Message-Id: <20191011085050.17622-3-richardw.y.
From: Wei Yang
Function postcopy_ram_incoming_setup and postcopy_ram_incoming_cleanup
is a pair. Rename to make it clear for audience.
Signed-off-by: Wei Yang
Reviewed-by: Dr. David Alan Gilbert
Message-Id: <20191010011316.31363-2-richardw.y...@linux.intel.com>
Reviewed-by: Peter Xu
Signed-of
From: "Dr. David Alan Gilbert"
Use the automatic read unlocker in migration/ram.c
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Daniel P. Berrangé
Message-Id: <20191007143642.301445-4-dgilb...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/ram.c | 259 ++
From: Wei Yang
Signed-off-by: Wei Yang
Message-Id: <20191011085050.17622-2-richardw.y...@linux.intel.com>
Reviewed-by: Juan Quintela
Signed-off-by: Dr. David Alan Gilbert
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
From: Wei Yang
When we found an available channel in multifd_send_pages(), its
pages->used is cleared and then attached to multifd_send_state.
It is not necessary to do this twice.
Signed-off-by: Wei Yang
Message-Id: <20191011085050.17622-5-richardw.y...@linux.intel.com>
Reviewed-by: Juan Quin
From: Wei Yang
This provides helpful information on which entry failed.
Signed-off-by: Wei Yang
Message-Id: <20191005220517.24029-5-richardw.y...@linux.intel.com>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Dr. David Alan Gilbert
---
migration/savevm.c | 2 ++
1 file changed, 2 insert
From: "Dr. David Alan Gilbert"
Use the automatic rcu_read unlocker to fix a missing unlock.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Daniel P. Berrangé
Message-Id: <20191007143642.301445-3-dgilb...@redhat.com>
Signed-off-by: Dr. David Alan Gilbert
---
migration/ram.c | 27 +
1 - 100 of 510 matches
Mail list logo
