[Bug 1623998] Re: pulseaudio Invalid argument error

2019-10-04 Thread John Arbuckle
I tried using "-device usb-audio"and the guest was able to detect the USB audio card, but for some reason no audio would play. I did not see any messages in the terminal about pulseaudio. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

[PATCH] target/i386: log guest name and memory error type AO, AR for MCEs

2019-10-04 Thread Mario Smarduch
In a large VPC environment we want to log memory error occurrences and log them with guest name and type - there are few use cases - if VM crashes on AR mce inform the user about the reason and resolve the case - if VM hangs notify the user to reboot and resume processing - if VM continues to r

Re: [PATCH v3] migration: Support gtree migration

2019-10-04 Thread Juan Quintela
Eric Auger wrote: > Introduce support for GTree migration. A custom save/restore > is implemented. Each item is made of a key and a data. > > If the key is a pointer to an object, 2 VMSDs are passed into > the GTree VMStateField. > > When putting the items, the tree is traversed in sorted order by

Re: ptimer use of bottom-half handlers

2019-10-04 Thread Richard Henderson
On 10/4/19 10:40 AM, Peter Maydell wrote: > So we should probably cause that to happen in the new scheme > (conceptually, something like "the trigger callback is > implicitly considered to be called from within a tx begin/ > commit block, so (a) it doesn't need to do begin/commit itself > and (b) i

Re: Re: target/ppc: bug in optimised vsl/vsr implementation?

2019-10-04 Thread Aleksandar Markovic
> > In comment #9 in the bug > (https://bugs.launchpad.net/qemu/+bug/1841990/comments/9), I note that the > issue was produced in running the test suite for the Power Vector Library > project (https://github.com/open-power-sdk/pveclib), which makes productive > use of dcbenq. > > Maybe that cou

Re: [PATCH v2] target/arm/arch_dump: Add SVE notes

2019-10-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191004120313.5347-1-drjo...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20191004120313.5347-1-drjo...@redhat.com Subject: [PATCH v2] target/arm/arch_dump: Add SVE n

Re: [PATCH v2 00/11] RFC crypto/luks: encryption key managment using amend interface

2019-10-04 Thread Max Reitz
On 13.09.19 00:30, Maxim Levitsky wrote: > This patch series is continuation of my work to add encryption > key managment to luks/qcow2 with luks. > > This is second version of this patch set. > The changes are mostly addressing the review feedback, > plus I tested (and fixed sadly) the somewhat u

Re: [PATCH v2 11/11] iotests : add tests for encryption key management

2019-10-04 Thread Max Reitz
On 13.09.19 00:30, Maxim Levitsky wrote: > Note that currently I add tests 300-302, which are > placeholders to ease the rebase. In final version > of these patches I will update these. > > Signed-off-by: Maxim Levitsky > --- > tests/qemu-iotests/300 | 202 + > te

[Bug 1846816] [NEW] Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel""

2019-10-04 Thread Leonardo
Public bug reported: # ls -ltr total 8750584 -rw-rw-r-- 1 linux linux 4274997248 Oct 4 18:33 AIX.vol1.iso -rw-rw-r-- 1 linux linux 4293888000 Oct 4 18:45 AIX.vol2.iso -rw-rw-r-- 1 linux linux 391485440 Oct 4 18:50 AIX.vol3.iso -rw-r--r-- 1 root root 204608 Oct 4 19:00 AIX61.img # q

Re: [PATCH 6/7] tests/fw_cfg: Declare one QFWCFG for all tests

2019-10-04 Thread Laszlo Ersek
On 10/04/19 00:54, Philippe Mathieu-Daudé wrote: > It is pointless to create/remove a QFWCFG object for each test. > Move it to the test context and create/remove it only once. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/fw_cfg-test.c | 74 +---

Re: [PATCH v2 09/11] block/qcow2: implement blockdev-amend

2019-10-04 Thread Max Reitz
On 13.09.19 00:30, Maxim Levitsky wrote: > Currently only for changing crypto parameters Yep, that elegantly avoids most of the problems we’d have otherwise. :-) > Signed-off-by: Maxim Levitsky > --- > block/qcow2.c| 71 > qapi/block-core.jso

Re: [PATCH 5/7] tests/libqos/fw_cfg: Pass QTestState as argument

2019-10-04 Thread Laszlo Ersek
On 10/04/19 00:54, Philippe Mathieu-Daudé wrote: > Since a QFWCFG object is not tied to a particular test, we can > call *_fw_cfg_init() once before creating QTests and use the same > for all the tests, then release the object with g_free() once all > the tests are run. > > Refactor the qfw_cfg* A

Re: [PATCH v2 07/11] block: add x-blockdev-amend qmp command

2019-10-04 Thread Max Reitz
On 13.09.19 00:30, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > block/Makefile.objs | 2 +- > block/amend.c | 116 ++ > include/block/block_int.h | 23 ++-- > qapi/block-core.json | 26 + > qapi/job.json

Re: [Virtio-fs] [PATCH] virtiofsd: Add pread64() to seccomp list for posix_fallocate()

2019-10-04 Thread Dr. David Alan Gilbert
* Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > I test virtiofs with NFS 4.0 as backend and notice that fallocate > causes system hang (kernel: 5.4-rc1, qemu: virtio-fs-dev branch): > $ mount -t virtiofs myfs /mnt > $ dd if=/dev/urandom bs=1000 seek=1 count=1 of=/mnt/file > $ falloca

Re: [PATCH 4/7] tests/fw_cfg: Let the tests use a context

2019-10-04 Thread Laszlo Ersek
On 10/04/19 00:54, Philippe Mathieu-Daudé wrote: > Introduce the local QTestCtx structure, and register the tests > with qtest_add_data_func(ctx). > For now the context only contains the machine name (which is > fixed to the 'pc' machine, since this test only runs on the > x86 architecture). > > S

Re: [PATCH v2] target/ppc: Fix for optimized vsl/vsr instructions

2019-10-04 Thread Paul Clarke
On 10/4/19 8:43 AM, Stefan Brankovic wrote: > In previous implementation, invocation of TCG shift function could request > shift of TCG variable by 64 bits when variable 'sh' is 0, which is not > supported in TCG (values can be shifted by 0 to 63 bits). This patch fixes > this by using two separate

Re: [PATCH v2] target/ppc: Fix for optimized vsl/vsr instructions

2019-10-04 Thread Aleksandar Markovic
> Reported-by: Paul Clark Stefan, Paul's full name is Paul A. Clarke. Thanks for the fix! Aleksandar

Re: [PATCH v2 05/11] block/crypto: implement the encryption key management

2019-10-04 Thread Max Reitz
On 13.09.19 00:30, Maxim Levitsky wrote: > This implements the encryption key management > using the generic code in qcrypto layer > (currently only for qemu-img amend) > > This code adds another 'write_func' because the initialization > write_func works directly on the underlying file, > because

Re: [PATCH 3/7] tests/libqos/fw_cfg: Document pc_fw_cfg_init to drop pc_fw_cfg_uninit

2019-10-04 Thread Laszlo Ersek
On 10/04/19 00:54, Philippe Mathieu-Daudé wrote: > Document pc_fw_cfg_init() return value must be released > with g_free(). Directly calling g_free() we don't really > need pc_fw_cfg_uninit(): remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/fw_cfg-test.c | 22 +++-

Re: [PATCH 2/7] tests/libqos/fw_cfg: Document mm_fw_cfg_init to drop mm_fw_cfg_uninit

2019-10-04 Thread Laszlo Ersek
On 10/04/19 00:54, Philippe Mathieu-Daudé wrote: > Document mm_fw_cfg_init() return value must be released > with g_free(). mm_fw_cfg_uninit() was never used, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/libqos/fw_cfg.c | 5 - > tests/libqos/fw_cfg.h | 10 +- >

Re: [PATCH 1/7] tests/libqos/fw_cfg: Document io_fw_cfg_init to drop io_fw_cfg_uninit

2019-10-04 Thread Laszlo Ersek
On 10/04/19 00:54, Philippe Mathieu-Daudé wrote: > Document io_fw_cfg_init() return value must be released > with g_free(). Directly calling g_free() we don't really > need io_fw_cfg_uninit(): remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/libqos/fw_cfg.c | 5 - > tests/

Re: [PATCH v9 3/3] iotests: test nbd reconnect

2019-10-04 Thread Eric Blake
On 9/24/19 3:31 AM, Vladimir Sementsov-Ogievskiy wrote: +def qemu_nbd_popen(*args): +'''Run qemu-nbd in daemon mode and return the parent's exit code''' +return subprocess.Popen(qemu_nbd_args + ['--persistent'] + list(args)) + Should you also use a pid file here, and wait for the exist

Re: [PATCH v2 02/11] qcrypto-luks: extend the create options for upcoming encryption key management

2019-10-04 Thread Max Reitz
On 13.09.19 00:30, Maxim Levitsky wrote: > Now you can specify which slot to put the encryption key to > Plus add 'active' option which will let user erase the key secret > instead of adding it. > Check that active=true it when creating. > > Signed-off-by: Maxim Levitsky > --- > block/crypto.c

Re: ptimer use of bottom-half handlers

2019-10-04 Thread Peter Maydell
On Fri, 27 Sep 2019 at 11:01, Peter Maydell wrote: > The ptimer API is basically a down-counter (with a lot of bells > and whistles), with functions to do things like "read current count" > and "write current count". When the counter hits zero it typically > reloads, and the ptimer code notifies a

[PATCH v4 1/3] tests/migration: mem leak fix

2019-10-04 Thread Mao Zhongyi
‘data’ has the possibility of memory leaks, so use the glib macros g_autofree recommended by CODING_STYLE.rst to automatically release the memory that returned from g_malloc(). Signed-off-by: Mao Zhongyi Reviewed-by: Alex Bennée --- tests/migration/stress.c | 21 ++--- 1 file ch

[PATCH v4 3/3] tests/migration:fix unreachable path in stress test

2019-10-04 Thread Mao Zhongyi
If stressone() or stress() exits it's because of a failure because the test runs forever otherwise, so change stressone and stress type to void to make the exit_failure() as the exit function of main(). Signed-off-by: Mao Zhongyi --- tests/migration/stress.c | 13 + 1 file changed, 5

[PATCH v4 2/3] tests/migration: fix a typo in comment

2019-10-04 Thread Mao Zhongyi
Signed-off-by: Mao Zhongyi Reviewed-by: Alex Bennée Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- tests/migration/stress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/migration/stress.c b/tests/migration/stress.c index d8a6f64af0..f9626d50ee

[PATCH v4 0/3] some fix in tests/migration

2019-10-04 Thread Mao Zhongyi
This patchset mainly fixes memory leak, typo and return value of stress function in stress test. v4-v3: p1: - remove redundant g_malloc return value judgment. [Laurent Vivier] p3: - always use exit_failure() as the exit function of main().

Re: [PATCH v9 2/3] block/nbd: nbd reconnect

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
23 Sep 2019 22:23 Eric Blake wrote: On 9/17/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote: > Implement reconnect. To achieve this: > > 1. add new modes: >connecting-wait: means, that reconnecting is in progress, and there > were small number of reconnect attempts, so all requests are

Re: [PATCH v6 00/10] Introduce the microvm machine type

2019-10-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191004093752.16564-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20191004093752.16564-1-...@redhat.com Subject: [PATCH v6 00/10] Introduce the microvm machine t

Re: [PATCH v6 00/10] Introduce the microvm machine type

2019-10-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191004093752.16564-1-...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

[PULL 29/29] target/i386/kvm: Silence warning from Valgrind about uninitialized bytes

2019-10-04 Thread Paolo Bonzini
From: Thomas Huth When I run QEMU with KVM under Valgrind, I currently get this warning: Syscall param ioctl(generic) points to uninitialised byte(s) at 0x95BA45B: ioctl (in /usr/lib64/libc-2.28.so) by 0x429DC3: kvm_ioctl (kvm-all.c:2365) by 0x51B249: kvm_arch_get_supported_msr_feat

[PATCH] migration: Support QLIST migration

2019-10-04 Thread Eric Auger
94869d5c52 ("migration: migrate QTAILQ") introduced support for QTAILQ migration. Let's do the same for QLIST. Signed-off-by: Eric Auger --- include/migration/vmstate.h | 21 ++ include/qemu/queue.h| 30 migration/vmstate-types.c | 60 tests/test-vmstat

[PULL 27/29] target/i386: add VMX features

2019-10-04 Thread Paolo Bonzini
Add code to convert the VMX feature words back into MSR values, allowing the user to enable/disable VMX features as they wish. The same infrastructure enables support for limiting VMX features in named CPU models. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 225

[PULL 26/29] vmxcap: correct the name of the variables

2019-10-04 Thread Paolo Bonzini
The low bits are 1 if the control must be one, the high bits are 1 if the control can be one. Correct the variable names as they are very confusing. Signed-off-by: Paolo Bonzini --- scripts/kvm/vmxcap | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/kvm

[PULL 24/29] target/i386: expand feature words to 64 bits

2019-10-04 Thread Paolo Bonzini
VMX requires 64-bit feature words for the IA32_VMX_EPT_VPID_CAP and IA32_VMX_BASIC MSRs. (The VMX control MSRs are 64-bit wide but actually have only 32 bits of information). Signed-off-by: Paolo Bonzini --- include/sysemu/kvm.h | 2 +- target/i386/cpu.c| 71 +++

[PULL 22/29] target/i386: handle filtered_features in a new function mark_unavailable_features

2019-10-04 Thread Paolo Bonzini
The next patch will add a different reason for filtering features, unrelated to host feature support. Extract a new function that takes care of disabling the features and optionally reporting them. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 87 ++---

[PULL 28/29] target/i386: work around KVM_GET_MSRS bug for secondary execution controls

2019-10-04 Thread Paolo Bonzini
Some secondary controls are automatically enabled/disabled based on the CPUID values that are set for the guest. However, they are still available at a global level and therefore should be present when KVM_GET_MSRS is sent to /dev/kvm. Unfortunately KVM forgot to include those, so fix that. Sign

[PULL 23/29] target/i386: introduce generic feature dependency mechanism

2019-10-04 Thread Paolo Bonzini
Sometimes a CPU feature does not make sense unless another is present. In the case of VMX features, KVM does not even allow setting the VMX controls to some invalid combinations. Therefore, this patch adds a generic mechanism that looks for bits that the user explicitly cleared, and uses them to

[PULL 25/29] target/i386: add VMX definitions

2019-10-04 Thread Paolo Bonzini
These will be used to compile the list of VMX features for named CPU models, and/or by the code that sets up the VMX MSRs. Signed-off-by: Paolo Bonzini --- target/i386/cpu.h | 130 ++ 1 file changed, 130 insertions(+) diff --git a/target/i386/

[PULL v3 00/29] Misc patches for 2019-10-02

2019-10-04 Thread Paolo Bonzini
The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 13:13:38 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

Re: [PULL 12/30] Makefile: Remove generated files when doing 'distclean'

2019-10-04 Thread Paolo Bonzini
On 04/10/19 14:20, Peter Maydell wrote: > On Wed, 2 Oct 2019 at 18:07, Paolo Bonzini wrote: >> >> From: Thomas Huth >> >> When running "make distclean" we currently leave a lot of generated >> files in the build directory. Fix that. >> >> Signed-off-by: Thomas Huth >> Reviewed-by: John Snow >>

Re: libvirt? qemu change that mmaps ELF files breaks libvirt svirt handling for os.kernel

2019-10-04 Thread Paolo Bonzini
On 04/10/19 14:47, Christian Borntraeger wrote: >> Please file a bz entry against the selinux-policy component for >> whatever distro you're using, and/or Fedora rawhide, and CC me >> on it too. > > Done. This was on Fedora 30. > https://bugzilla.redhat.com/show_bug.cgi?id=1758525 > > Now sure a

Re: [PATCH 4/4] Revert "mirror: Only mirror granularity-aligned chunks"

2019-10-04 Thread Max Reitz
On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: > This reverts commit 9adc1cb49af8d4e54f57980b1eed5c0a4b2dafa6. > "mirror: Only mirror granularity-aligned chunks" > > Since previous commit unaligned chunks are supported by > do_sync_target_write. > > Signed-off-by: Vladimir Sementsov-O

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Max Reitz
On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: > Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up > region in the dirty bitmap, which means that we may not copy some bytes > and assume them copied, which actually leads to producing corrupted > target. > > So 9adc1cb4

[PATCH 4/5] hw/arm/boot: Expose the pmem nodes in the DT

2019-10-04 Thread Shameer Kolothum
From: Eric Auger In case of NV-DIMM slots, let's add /pmem DT nodes. Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum --- hw/arm/boot.c | 45 + 1 file changed, 45 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index c264864c11..b

[PATCH 2/5] nvdimm: Use configurable ACPI IO base and size

2019-10-04 Thread Shameer Kolothum
From: Kwangwoo Lee This patch makes IO base and size configurable to create NPIO AML for ACPI NFIT. Since a different architecture like AArch64 does not use port-mapped IO, a configurable IO base is required to create correct mapping of ACPI IO address and size. Signed-off-by: Kwangwoo Lee Sign

[PATCH 5/5] hw/arm/virt: Add nvdimm hotplug support

2019-10-04 Thread Shameer Kolothum
This adds support for nvdimm hotplug events through GED and enables nvdimm for the arm/virt. Now Guests with DT boot can have nvdimm cold plug and with ACPI both cold/hot plug. Hot removal functionality is not yet supported. Signed-off-by: Shameer Kolothum --- docs/specs/acpi_hw_reduced_hotplug

[PATCH 3/5] hw/arm/virt: Add nvdimm hot-plug infrastructure

2019-10-04 Thread Shameer Kolothum
From: Kwangwoo Lee Pre-plug and plug handlers are prepared for NVDIMM support. Please note nvdimm_support is not yet enabled. Signed-off-by: Eric Auger Signed-off-by: Kwangwoo Lee Signed-off-by: Shameer Kolothum --- hw/arm/Kconfig | 1 + hw/arm/virt-acpi-build.c | 6 ++ hw/ar

[PATCH 0/5] ARM virt: Add NVDIMM support

2019-10-04 Thread Shameer Kolothum
This series adds NVDIMM support to arm/virt platform. This has a dependency on [0] and make use of the GED device for NVDIMM hotplug events. The series reuses some of the patches posted by Eric in his earlier attempt here[1]. Patch 1/5 is a fix to the Guest reboot issue on NVDIMM hot add case desc

[PATCH 1/5] block: Mark commit and mirror as filter drivers

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
From: Max Reitz The commit and mirror block nodes are filters, so they should be marked as such. Signed-off-by: Max Reitz Signed-off-by: Vladimir Sementsov-Ogievskiy [squash comment fix from another Max's patch and adjust commit msg] --- include/block/block_int.h | 8 +--- block/commit

[PATCH 0/5] fix migration with bitmaps and mirror

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
Hi all! It's a continuation for "bitmap migration bug with -drive while block mirror runs" <315cff78-dcdb-a3ce-2742-da3cc9f0c...@redhat.com> https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg07241.html The problem is that bitmaps migrated to node with same node-name or blk-parent name. And

[PATCH 1/5] hw/arm: Align ACPI blob len to PAGE size

2019-10-04 Thread Shameer Kolothum
If ACPI blob length modifications happens after the initial virt_acpi_build() call, and the changed blob length is within the PAGE size boundary, then the revised size is not seen by the firmware on Guest reboot. The is because in the virt_acpi_build_update() -> acpi_ram_update() -> qemu_ram_resize

[PATCH 4/5] migration/block-dirty-bitmap: fix bitmaps migration during mirror job

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
Important thing for bitmap migration is to select destination block node to obtain the migrated bitmap. Prepatch, on source we use bdrv_get_device_or_node_name() to identify the node, and on target we do bdrv_lookup_bs. bdrv_get_device_or_node_name() returns blk name only for direct children of bl

[PATCH 3/5] block/dirty-bitmap: add bdrv_has_named_bitmaps helper

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
To be used for bitmap migration in further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 1 + block/dirty-bitmap.c | 13 + 2 files changed, 14 insertions(+) diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h ind

[PATCH 5/5] iotests: 194: test also migration of dirty bitmap

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
Test that dirty bitmap migration works when we deal with mirror. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/194 | 14 ++ tests/qemu-iotests/194.out | 6 ++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/194 b/tests/

[PATCH 2/5] migretion/block-dirty-bitmap: refactor init_dirty_bitmap_migration

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
Split out handling one bs, it is needed for the following commit, which will handle BlockBackends in separate. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/block-dirty-bitmap.c | 93 +++--- 1 file changed, 51 insertions(+), 42 deletions(-) diff --git a/m

Re: [PATCH v5 0/5] iotests: use python logging

2019-10-04 Thread Max Reitz
On 18.09.19 01:45, John Snow wrote: > This series uses python logging to enable output conditionally on > iotests.log(). We unify an initialization call (which also enables > debugging output for those tests with -d) and then make the switch > inside of iotests. > > It will help alleviate the need

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2019 18:27, Max Reitz wrote: > On 04.10.19 17:04, Vladimir Sementsov-Ogievskiy wrote: >> 04.10.2019 17:48, Max Reitz wrote: >>> On 04.10.19 15:22, Vladimir Sementsov-Ogievskiy wrote: 04.10.2019 15:59, Max Reitz wrote: > On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: >> 02

Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-04 Thread Richard Henderson
On 10/4/19 5:34 AM, David Hildenbrand wrote: > Or, as alternative, something like "cpu_shall_exit()" which only > wraps the single check. I would prefer this to the full cpu_loop_exit_restore. It's harder to imagine what else might need doing for some other user of the interface. r~

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Max Reitz
On 04.10.19 17:04, Vladimir Sementsov-Ogievskiy wrote: > 04.10.2019 17:48, Max Reitz wrote: >> On 04.10.19 15:22, Vladimir Sementsov-Ogievskiy wrote: >>> 04.10.2019 15:59, Max Reitz wrote: On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 18:52, Max Reitz wrote: >> On

[PATCH v2] target/riscv: Expose "priv" register for GDB

2019-10-04 Thread Jonathan Behrens
This patch enables a debugger to read and write the current privilege level via a special "priv" register. When compiled with CONFIG_USER_ONLY the register is still visible but is hardwired to zero. Signed-off-by: Jonathan Behrens --- gdb-xml/riscv-32bit-cpu.xml | 1 + gdb-xml/riscv-64bit-cpu.x

Re: [Qemu-devel] [PATCH v9 07/17] blockdev: adds bdrv_parse_aio to use io_uring

2019-10-04 Thread Stefan Hajnoczi
On Wed, Aug 07, 2019 at 02:49:51PM +0200, Julia Suvorova via Qemu-devel wrote: > On Wed, Aug 7, 2019 at 2:06 PM Aarushi Mehta wrote: > > > > > > > > On Wed, 7 Aug, 2019, 17:15 Julia Suvorova, wrote: > >> > >> On Fri, Aug 2, 2019 at 1:41 AM Aarushi Mehta > >> wrote: > >> > +int bdrv_parse_aio(co

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2019 17:48, Max Reitz wrote: > On 04.10.19 15:22, Vladimir Sementsov-Ogievskiy wrote: >> 04.10.2019 15:59, Max Reitz wrote: >>> On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: 02.10.2019 18:52, Max Reitz wrote: > On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: >> 02

[PATCH] netmap: support git-submodule build otption

2019-10-04 Thread Giuseppe Lettieri
From: Giuseppe Lettieri With this patch, netmap support can be enabled with the following options to the configure script: --enable-netmap[=system] Use the host system netmap installation. Fail if not found. --enable-netmap=git clone the official netmap repository

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Max Reitz
On 04.10.19 15:22, Vladimir Sementsov-Ogievskiy wrote: > 04.10.2019 15:59, Max Reitz wrote: >> On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: >>> 02.10.2019 18:52, Max Reitz wrote: On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 18:03, Vladimir Sementsov-Ogievsk

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-04 Thread Max Reitz
On 04.10.19 16:05, Peter Maydell wrote: > On Fri, 4 Oct 2019 at 14:50, Max Reitz wrote: >> On 04.10.19 15:16, Peter Maydell wrote: >>> 'make check' does have the restriction >>> that we don't want the tests to take too long to run, but in >>> general the block layer should be running some reasonab

Re: [PATCH v15 0/5] backup-top filter driver for backup

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2019 17:21, Max Reitz wrote: > On 01.10.19 15:14, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> These series introduce backup-top driver. It's a filter-node, which >> do copy-before-write operation. Mirror uses filter-node for handling >> guest writes, let's move to filter-node (from w

Re: [Qemu-devel] [PATCH v2 2/3] tests/migration: fix a typo in comment

2019-10-04 Thread Philippe Mathieu-Daudé
On 9/11/19 5:31 AM, Mao Zhongyi wrote: Cc: arm...@redhat.com Cc: laur...@vivier.eu Cc: tony.ngu...@bt.com Signed-off-by: Mao Zhongyi Reviewed-by: Alex Bennée --- tests/migration/stress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/migration/stress.c b/tests/mig

Re: [PATCH v15 0/5] backup-top filter driver for backup

2019-10-04 Thread Max Reitz
On 01.10.19 15:14, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > These series introduce backup-top driver. It's a filter-node, which > do copy-before-write operation. Mirror uses filter-node for handling > guest writes, let's move to filter-node (from write-notifiers) for > backup too. > > Pr

Re: [PATCH v15 5/5] block/backup: use backup-top instead of write notifiers

2019-10-04 Thread Max Reitz
On 01.10.19 15:14, Vladimir Sementsov-Ogievskiy wrote: > Drop write notifiers and use filter node instead. > > = Changes = > > 1. Add filter-node-name argument for backup qmp api. We have to do it > in this commit, as 257 needs to be fixed. > > 2. There are no more write notifiers here, so is_wr

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-04 Thread Peter Maydell
On Fri, 4 Oct 2019 at 14:50, Max Reitz wrote: > On 04.10.19 15:16, Peter Maydell wrote: > > 'make check' does have the restriction > > that we don't want the tests to take too long to run, but in > > general the block layer should be running some reasonable subset > > of tests in the project's sta

Re: [PATCH v6 00/10] Introduce the microvm machine type

2019-10-04 Thread Michael S. Tsirkin
On Fri, Oct 04, 2019 at 11:37:42AM +0200, Sergio Lopez wrote: > Microvm is a machine type inspired by Firecracker and constructed > after the its machine model. > > It's a minimalist machine type without PCI nor ACPI support, designed > for short-lived guests. Microvm also establishes a baseline f

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-04 Thread Max Reitz
On 04.10.19 15:16, Peter Maydell wrote: > On Fri, 4 Oct 2019 at 13:45, Max Reitz wrote: >>> In the end, I don't care what code these patches touched. I do an >>> innocent git pull, and when I finally see that it's master that breaks >>> iotests and not my patches on top of it, I'm annoyed. >> >> H

[PATCH v2] target/ppc: Fix for optimized vsl/vsr instructions

2019-10-04 Thread Stefan Brankovic
This patch fixes bug in optimized vsl/vsr instructions reported by Mark Cave-Ayland and Paul Clarke. Sorry for not responding earlier, I was absent last couple of days. I also integrated some suggestions made by Aleksandar Markovic. New soultion is tested and still has noticable performance improve

[PATCH v2] target/ppc: Fix for optimized vsl/vsr instructions

2019-10-04 Thread Stefan Brankovic
In previous implementation, invocation of TCG shift function could request shift of TCG variable by 64 bits when variable 'sh' is 0, which is not supported in TCG (values can be shifted by 0 to 63 bits). This patch fixes this by using two separate invocation of TCG shift functions, with maximum shi

Re: [PATCH v15 4/5] block: introduce backup-top filter driver

2019-10-04 Thread Max Reitz
On 01.10.19 15:14, Vladimir Sementsov-Ogievskiy wrote: > Backup-top filter caches write operations and does copy-before-write > operations. > > The driver will be used in backup instead of write-notifiers. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup-top.h | 41 +++

Re: [PATCH v1 0/5] s390x/mmu: Implement more facilities

2019-10-04 Thread David Hildenbrand
On 26.09.19 12:16, David Hildenbrand wrote: > This is the follow up of: > [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions > Without the general MMU rework. It's based on: > [PATCH v2 0/7] s390x/mmu: DAT translation rewrite > > This series adds adds EDAT2 MMU support, and implement

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2019 15:59, Max Reitz wrote: > On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: >> 02.10.2019 18:52, Max Reitz wrote: >>> On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: 02.10.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 17:57, Max Reitz wrote: >> On

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-04 Thread Peter Maydell
On Fri, 4 Oct 2019 at 13:45, Max Reitz wrote: > > In the end, I don't care what code these patches touched. I do an > > innocent git pull, and when I finally see that it's master that breaks > > iotests and not my patches on top of it, I'm annoyed. > > Hm. Part of my point was that this still hap

Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-04 Thread Alex Bennée
David Hildenbrand writes: > On 04.10.19 14:11, Peter Maydell wrote: >> On Fri, 4 Oct 2019 at 09:02, David Hildenbrand wrote: >>> So shall we leave this patch as-is (adding a summary of what you >>> explained to the description) or shall we somehow factor out the >>> TCG-internal-thingy check?

Re: [PATCH] netmap: support git-submodule build otption

2019-10-04 Thread Peter Maydell
On Fri, 4 Oct 2019 at 14:03, Giuseppe Lettieri wrote: > > From: Giuseppe Lettieri > > With this patch, netmap support can be enabled with > the following options to the configure script: > > --enable-netmap[=system] > > Use the host system netmap installation. > Fail if not foun

[PATCH v3] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-04 Thread David Hildenbrand
MVCL is interruptible and we should check for interrupts and process them after writing back the variables to the registers. Let's check for any exit requests and exit to the main loop. Introduce a new helper function for that: cpu_cond_loop_exit_restore(). When booting Fedora 30, I can see a hand

Re: bitmap migration bug with -drive while block mirror runs

2019-10-04 Thread Eric Blake
On 10/4/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote: The way I see it, we know an auto-generated node name will never be correct, but an explicitly specified one represents an explicit user configuration. It's wrong to use generated names for migration details, but it's never wrong to use ex

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-04 Thread Max Reitz
On 03.10.19 11:34, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 18:52, Max Reitz wrote: >> On 02.10.19 17:06, Vladimir Sementsov-Ogievskiy wrote: >>> 02.10.2019 18:03, Vladimir Sementsov-Ogievskiy wrote: 02.10.2019 17:57, Max Reitz wrote: > On 12.09.19 17:13, Vladimir Sementsov-Ogievsk

Re: [PATCH] audio: add -audiodev pa,in|out.latency= to documentation

2019-10-04 Thread Marc-André Lureau
Hi On Fri, Oct 4, 2019 at 4:57 PM Stefan Hajnoczi wrote: > > The "latency" parameter wasn't covered by the documentation. > > Signed-off-by: Stefan Hajnoczi > --- > Hi Gerd, > You asked me to resend this patch because there was a conflict. I have > rebased it onto qemu.git/master (4f59102571fc)

Re: [RFC 3/4] ptimer: Provide new transaction-based API

2019-10-04 Thread Peter Maydell
On Fri, 4 Oct 2019 at 12:48, Peter Maydell wrote: > > Provide the new transaction-based API. > +void ptimer_transaction_begin(ptimer_state *s) > +{ > +assert(!s->in_transaction && s->callback); > +s->in_transaction = true; As I was working on converting the ptimer tests to the new API I

[PATCH] audio: add -audiodev pa,in|out.latency= to documentation

2019-10-04 Thread Stefan Hajnoczi
The "latency" parameter wasn't covered by the documentation. Signed-off-by: Stefan Hajnoczi --- Hi Gerd, You asked me to resend this patch because there was a conflict. I have rebased it onto qemu.git/master (4f59102571fc). qemu-options.hx | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH 02/67] iotests.py: Add @skip_for_imgopts()

2019-10-04 Thread Max Reitz
On 03.10.19 17:19, Vladimir Sementsov-Ogievskiy wrote: > 01.10.2019 22:46, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/iotests.py | 13 + >> 1 file changed, 13 insertions(+) >> >> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.p

[Virtio-fs] [PATCH] virtiofsd: Add pread64() to seccomp list for posix_fallocate()

2019-10-04 Thread Misono Tomohiro
I test virtiofs with NFS 4.0 as backend and notice that fallocate causes system hang (kernel: 5.4-rc1, qemu: virtio-fs-dev branch): $ mount -t virtiofs myfs /mnt $ dd if=/dev/urandom bs=1000 seek=1 count=1 of=/mnt/file $ fallocate -l 2000 /mnt/file # system hang This is because: 1. virtiofs su

Re: libvirt? qemu change that mmaps ELF files breaks libvirt svirt handling for os.kernel

2019-10-04 Thread Christian Borntraeger
On 04.10.19 14:36, Daniel P. Berrangé wrote: > On Fri, Oct 04, 2019 at 02:18:49PM +0200, Christian Borntraeger wrote: >> >> >> On 04.10.19 14:13, Paolo Bonzini wrote: >>> On 04/10/19 14:03, Christian Borntraeger wrote: Stefano, Paolo, I have an interesting fail in QEMU

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-04 Thread Max Reitz
On 04.10.19 12:19, Kevin Wolf wrote: > Am 02.10.2019 um 19:47 hat Max Reitz geschrieben: >> On 02.10.19 18:44, Kevin Wolf wrote: >>> Am 02.10.2019 um 13:57 hat Max Reitz geschrieben: It usually worked fine for me because it’s rather rare that non-block patches broke the iotests. >>> >>> I

[Bug 1777777] Re: arm9 clock pending (SP804)

2019-10-04 Thread Peter Maydell
I sent out an initial RFC patchset which fixes this (it's just an RFC because it only converts this one device to the new ptimer API, and we should do a proper conversion of all devices); it seems to make the test case in this bug work correctly: https://patchew.org/QEMU/20191004114848.16831-1-p

Re: libvirt? qemu change that mmaps ELF files breaks libvirt svirt handling for os.kernel

2019-10-04 Thread Daniel P . Berrangé
On Fri, Oct 04, 2019 at 02:18:49PM +0200, Christian Borntraeger wrote: > > > On 04.10.19 14:13, Paolo Bonzini wrote: > > On 04/10/19 14:03, Christian Borntraeger wrote: > >> Stefano, Paolo, > >> > >> I have an interesting fail in QEMU > >> > >> 2019-10-04T12:00:32.675188Z qemu-system-s390x: GLib

Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-04 Thread David Hildenbrand
On 04.10.19 14:11, Peter Maydell wrote: > On Fri, 4 Oct 2019 at 09:02, David Hildenbrand wrote: >> So shall we leave this patch as-is (adding a summary of what you >> explained to the description) or shall we somehow factor out the >> TCG-internal-thingy check? > > Nothing else in target code tou

Re: [PATCH] target/arm/arch_dump: Add SVE notes

2019-10-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191004094609.32714-1-drjo...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20191004094609.32714-1-drjo...@redhat.com Subject: [PATCH] target/arm/arch_dump: Add SVE no

Re: [PULL v2 00/22] Misc patches for 2010-10-02

2019-10-04 Thread Peter Maydell
On Thu, 3 Oct 2019 at 12:05, Paolo Bonzini wrote: > > The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 > 13:13:38 +0100) > > are available in the git repos

libvirt? qemu change that mmaps ELF files breaks libvirt svirt handling for os.kernel

2019-10-04 Thread Christian Borntraeger
Stefano, Paolo, I have an interesting fail in QEMU 2019-10-04T12:00:32.675188Z qemu-system-s390x: GLib: g_mapped_file_unref: assertion 'file != NULL' failed that bisected to commit 816b9fe450220e19acb91a0ce4a8ade7000648d1 (refs/bisect/bad) elf-ops.h: Map into memory the ELF to load strace

Re: [RFC 0/4] transaction-based ptimer API

2019-10-04 Thread Paolo Bonzini
On 04/10/19 14:00, Peter Maydell wrote: > No, because stop/run causes the ptimer to "lose time" > (we stop the underlying timer and restart it). It's > very common for a device to want to change the ptimer > properties without a stop/restart -- "set the ptimer > count value when the guest writes to

[PATCH v2] target/arm/arch_dump: Add SVE notes

2019-10-04 Thread Andrew Jones
When dumping a guest with dump-guest-memory also dump the SVE registers if they are in use. Signed-off-by: Andrew Jones --- include/elf.h | 2 + target/arm/arch_dump.c | 135 - 2 files changed, 135 insertions(+), 2 deletions(-) diff --git a/inc

  1   2   3   >