Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Thomas Huth
On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: > The MC146818 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé [...] > diff --git a/include/hw/rtc/mc146818rtc.h b/include/hw/rtc/mc146818rtc.h > new file mode 100644 > index

Re: [Qemu-devel] [PATCH 01/13] hw/timer: Compile devices not target-dependent as common object

2019-09-16 Thread Thomas Huth
On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: > All these devices do not contain any target-specific. While most > of them are arch-specific, they are shared between different > targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, > endianess, ...). > Put them into common-obj-y to

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread David Gibson
On Mon, Sep 16, 2019 at 05:48:37PM +0200, Philippe Mathieu-Daudé wrote: > The MC146818 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé ppc parts Acked-by: David Gibson > --- > MAINTAINERS

Re: [Qemu-devel] [PATCH 04/13] hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread David Gibson
On Mon, Sep 16, 2019 at 05:48:38PM +0200, Philippe Mathieu-Daudé wrote: > The M48T59 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 4 +- > hw/ppc/ppc405_boards.c |

[Qemu-devel] [PATCH] nbd: Grab aio context lock in more places

2019-09-16 Thread Eric Blake
When iothreads are in use, the failure to grab the aio context results in an assertion failure when trying to unlock things during blk_unref, when trying to unlock a mutex that was not locked. In short, all calls to nbd_export_put need to done while within the correct aio context. But since nbd_e

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: fix signal delivery for ppc64abi32

2019-09-16 Thread David Gibson
On Mon, Sep 16, 2019 at 08:22:42AM +0100, Alex Bennée wrote: > > David Gibson writes: > > > On Wed, Sep 11, 2019 at 10:33:45AM -0400, Richard Henderson wrote: > >> On 9/11/19 5:39 AM, Alex Bennée wrote: > >> > We were incorrectly setting NIP resulting in a segfault. This fixes > >> > linux-test

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

2019-09-16 Thread David Gibson
On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote: > On 9/16/19 11:52 AM, Alex Bennée wrote: > > > > Philippe Mathieu-Daudé writes: > > > >> Hi David, > >> > >> On 9/16/19 2:42 AM, David Gibson wrote: > >>> On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wro

Re: [Qemu-devel] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-16 Thread Eric Blake
On 9/12/19 6:31 AM, Kevin Wolf wrote: >> >> Yes, I think locking the context during the "if (exp->blk) {" block at >> nbd/server.c:1646 should do the trick. That line number has moved over time; which function are you referring to? > > We need to be careful to avoid locking things twice, so may

Re: [Qemu-devel] [PATCH 13/13] hw/rtc/xlnx-zynqmp-rtc: Remove unused "ptimer.h" include

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:46 AM Philippe Mathieu-Daudé wrote: > > The "hw/ptimer.h" header is not used, remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/rtc/xlnx-zynqmp-rtc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/rtc/

Re: [Qemu-devel] [PATCH 11/13] hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:17 AM Philippe Mathieu-Daudé wrote: > > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/rtc/Makefile.objs | 1 + > hw/{timer => rtc}/aspeed_rtc.c |

Re: [Qemu-devel] [PATCH 12/13] hw/rtc/mc146818: Include mc146818rtc_regs.h a bit less

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:42 AM Philippe Mathieu-Daudé wrote: > > Only 2 source files require the "mc146818rtc_regs.h" header. > Instead of having it processed 12 times, by all objects > using "mc146818rtc.h", include it directly where used. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [Qemu-devel] [PATCH 10/13] hw: Move Exynos4210 RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:00 AM Philippe Mathieu-Daudé wrote: > > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/rtc/Makefile.objs | 1 + > hw/{timer => rtc}/exynos4210_rtc.c | 0 > hw

Re: [Qemu-devel] [PATCH 09/13] hw: Move Xilinx ZynqMP RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 8:56 AM Philippe Mathieu-Daudé wrote: > > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/Makefile.objs| 1 + > hw/rtc/trace-events | 3 +++ > hw/{timer => rtc}/xlnx-

Re: [Qemu-devel] [PATCH 08/13] hw: Move DS1338 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:39 AM Philippe Mathieu-Daudé wrote: > > The DS1338 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/rtc/Kconfig | 4 > hw/rtc/Mak

Re: [Qemu-devel] [PATCH 07/13] hw: Move TWL92230 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:37 AM Philippe Mathieu-Daudé wrote: > > The TWL92230 is an "energy management device" companion with > a RTC. Since we mostly model the RTC, move it under the hw/rtc/ > subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > -

Re: [Qemu-devel] [PATCH v1] gdbstub: riscv: fix the fflags registers

2019-09-16 Thread Alistair Francis
On Tue, Sep 10, 2019 at 1:16 AM KONRAD Frederic wrote: > > While debugging an application with GDB the following might happen: > > (gdb) return > Make xxx return now? (y or n) y > Could not fetch register "fflags"; remote failure reply 'E14' > > This is because riscv_gdb_get_fpu calls riscv_csrrw_

Re: [Qemu-devel] [PATCH 06/13] hw: Move sun4v hypervisor RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:30 AM Philippe Mathieu-Daudé wrote: > > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS | 4 ++-- > hw/rtc/Kconfig| 3 +++ > hw/

Re: [Qemu-devel] [PATCH 05/13] hw: Move M41T80 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:35 AM Philippe Mathieu-Daudé wrote: > > The M41T80 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS| 2 +- > hw/rtc/Kconf

Re: [Qemu-devel] [PATCH 04/13] hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:26 AM Philippe Mathieu-Daudé wrote: > > The M48T59 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS | 4 +- > hw

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:31 AM Philippe Mathieu-Daudé wrote: > > The MC146818 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS |

[Qemu-devel] ELF load command alignment not page-aligned

2019-09-16 Thread Niccolò Belli
Hi, I'm trying to use qemu-user-static to chroot into a foreign amd64 environment from my ppc64le host. The host has a 64k page size, while x86_64 uses 4k. I get those errors while loading shared libraries: "ELF load command alignment not page-aligned" Is there any way to fix this? I cannot sim

Re: [Qemu-devel] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-16 Thread Eric Blake
On 9/12/19 1:37 AM, Sergio Lopez wrote: >> I tried to test this patch, but even with it applied, I still got an >> aio-context crasher by attempting an nbd-server-start, nbd-server-add, >> nbd-server-stop (intentionally skipping the nbd-server-remove step) on a >> domain using iothreads, with a ba

Re: [Qemu-devel] [PATCH v2 3/6] tests/acceptance: Test OpenBIOS on the PReP/40p

2019-09-16 Thread Cleber Rosa
On Sun, Sep 15, 2019 at 11:19:37PM +0200, Philippe Mathieu-Daudé wrote: > User case from: > https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/ppc_prep_40p.py | 32 > 1 file changed

Re: [Qemu-devel] [PATCH v3 5/6] docs: start a document to describe D-Bus usage

2019-09-16 Thread Marc-André Lureau
Hi On Mon, Sep 16, 2019 at 5:15 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Mon, Sep 16, 2019 at 2:02 PM Dr. David Alan Gilbert > > wrote: > > > > > > (Copying in Stefan since he was looking at DBus for virtiofs) > > > > > > * Ma

Re: [Qemu-devel] [PATCH v2 2/6] tests/acceptance: Test Open Firmware on the PReP/40p

2019-09-16 Thread Cleber Rosa
On Mon, Sep 16, 2019 at 01:59:22PM -0400, Cleber Rosa wrote: > On Sun, Sep 15, 2019 at 11:19:36PM +0200, Philippe Mathieu-Daudé wrote: > > User case from: > > https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > tests/acceptan

Re: [Qemu-devel] [PATCH 1/3] tests/acceptance/migration: fix post migration check

2019-09-16 Thread Dr. David Alan Gilbert
* Balamuruhan S (bal...@linux.ibm.com) wrote: > assert `query-migrate` in target doesn't give migration > status and test errors even if migration succeeds. > > In target: > {'execute': 'query-migrate'} > {"return": {}} On which version of qemu? On the current version I see: {"QMP": {"version":

Re: [Qemu-devel] [PATCH 02/13] hw: Move PL031 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:06 AM Philippe Mathieu-Daudé wrote: > > The PL031 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS | 4 ++-- > Make

[Qemu-devel] [PATCH v5 0/5] qcow2: async handling of fragmented io

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is an asynchronous scheme for handling fragmented qcow2 reads and writes. Both qcow2 read and write functions loops through sequential portions of data. The series aim it to parallelize these loops iterations. It improves performance for fragmented qcow2 images, I've tested it as desc

[Qemu-devel] [PATCH v5 5/5] block/qcow2: introduce parallel subrequest handling in read and write

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
It improves performance for fragmented qcow2 images. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 3 ++ block/qcow2.c | 125 - block/trace-events | 1 + 3 files changed, 117 insertions(+), 12 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH v2 2/6] tests/acceptance: Test Open Firmware on the PReP/40p

2019-09-16 Thread Cleber Rosa
On Sun, Sep 15, 2019 at 11:19:36PM +0200, Philippe Mathieu-Daudé wrote: > User case from: > https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/ppc_prep_40p.py | 21 + > 1 file changed, 21 inserti

[Qemu-devel] [PATCH v5 4/5] block/qcow2: refactor qcow2_co_pwritev_part

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Similarly to previous commit, prepare for parallelizing write-loop iterations. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2.c | 154 +- 1 file changed, 90 insertions(+), 64 deletions(-) diff --git a/block/qco

[Qemu-devel] [PATCH v5 3/5] block/qcow2: refactor qcow2_co_preadv_part

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Further patch will run partial requests of iterations of qcow2_co_preadv in parallel for performance reasons. To prepare for this, separate part which may be parallelized into separate function (qcow2_co_preadv_task). While being here, also separate encrypted clusters reading to own function, like

[Qemu-devel] [PATCH v5 1/5] qemu-iotests: ignore leaks on failure paths in 026

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Upcoming asynchronous handling of sub-parts of qcow2 requests will change number of leaked clusters and even make it racy. As a preparation, ignore leaks on failure parts in 026. It's not trivial to just grep or substitute qemu-img output for such thing. Instead do better: 3 is a error code of qem

Re: [Qemu-devel] [PATCH 1/4] block/dirty-bitmap: drop meta

2019-09-16 Thread John Snow
On 9/16/19 10:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Drop meta bitmaps, as they are unused. > > Signed-off-by: Vladimir Sementsov-Ogievskiy believe it or not, I had a local patch that does the same :) Reviewed-by: John Snow

[Qemu-devel] [PATCH v5 2/5] block: introduce aio task pool

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Common interface for aio task loops. To be used for improving performance of synchronous io loops in qcow2, block-stream, copy-on-read, and may be other places. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/block/aio_task.h | 54 + block/aio_tas

Re: [Qemu-devel] [PATCH 01/13] hw/timer: Compile devices not target-dependent as common object

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:02 AM Philippe Mathieu-Daudé wrote: > > All these devices do not contain any target-specific. While most > of them are arch-specific, they are shared between different > targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, > endianess, ...). > Put them into co

Re: [Qemu-devel] [PATCH 11/13] hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Cédric Le Goater
On 16/09/2019 17:48, Philippe Mathieu-Daudé wrote: > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé I suppose the removal of the header files in "aspeed_rtc.h" is OK. Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/rtc/Makefile.objs

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-16 Thread John Snow
On 9/16/19 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > 16.09.2019 19:32, John Snow wrote: >> >> >> On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 12.09.2019 3:16, John Snow wrote: Like script_main, but doesn't require a single point of entry. Replace all existing init

Re: [Qemu-devel] [PATCH v2] target/s390x/kvm: Officially require at least kernel 3.15

2019-09-16 Thread Cornelia Huck
On Fri, 13 Sep 2019 11:14:43 +0200 Thomas Huth wrote: Modified the subject, as suggested by David. > Since QEMU v2.10, the KVM acceleration does not work on older kernels > anymore since the code accidentally requires the KVM_CAP_DEVICE_CTRL > capability now - it should have been optional instea

Re: [Qemu-devel] [PATCH v8 18/32] riscv: sifive_u: Set the minimum number of cpus to 2

2019-09-16 Thread Alistair Francis
On Sun, Sep 15, 2019 at 6:07 AM Bin Meng wrote: > > Hi Palmer, > > On Sun, Sep 15, 2019 at 3:00 AM Palmer Dabbelt wrote: > > > > On Fri, 13 Sep 2019 08:25:21 PDT (-0700), bmeng...@gmail.com wrote: > > > Hi Palmer, > > > > > > On Fri, Sep 13, 2019 at 10:33 PM Palmer Dabbelt wrote: > > >> > > >> O

[Qemu-devel] [PATCH v2 1/2] ppc: Add support for 'mffscrn', 'mffscrni' instructions

2019-09-16 Thread Paul A. Clarke
From: "Paul A. Clarke" ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. This patch adds support for 'mffscrn' and 'mffscrni' instructions. 'mffscrn' and 'mffscrni' are similar to 'mffsl', except they d

[Qemu-devel] [PATCH v2 2/2] ppc: Add support for 'mffsce' instruction

2019-09-16 Thread Paul A. Clarke
From: "Paul A. Clarke" ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. This patch adds support for 'mffsce' instruction. 'mffsce' is identical to 'mffs', except that it also clears the exception enabl

[Qemu-devel] [PATCH] Acceptance tests: refactor wait_for_console_pattern

2019-09-16 Thread Cleber Rosa
The same utility method is already present in two different test files, so let's consolidate it into a single utility function. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 26 + tests/acceptance/boot_linux_console.py| 47 +++ tes

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
16.09.2019 19:32, John Snow wrote: > > > On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: >> 12.09.2019 3:16, John Snow wrote: >>> Like script_main, but doesn't require a single point of entry. >>> Replace all existing initialization sections with this drop-in replacement. >>> >>> This br

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-09-16 Thread John Snow
On 9/16/19 4:00 AM, Kevin Wolf wrote: > Am 13.09.2019 um 20:49 hat John Snow geschrieben: >> On 9/12/19 4:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Also, I'm not sure about "are" suggested by Max. "are" is for plural, but >>> here I meant >>> one object: sum of @start and @count. >>> >> >>

Re: [Qemu-devel] [PATCH v2 0/1] Handle /proc/self/exe in execve

2019-09-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190916155545.29928-1-olivier.d...@polymtl.ca/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commi

Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events

2019-09-16 Thread Eric Blake
On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote: > While the tracing frawework does not forbid trailing newline in framework > events format string, using them lead to confuse output. > It is the responsibility of the backend to properly end an event > line. Why just trailing newline? Should we

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-16 Thread John Snow
On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: > 12.09.2019 3:16, John Snow wrote: >> Like script_main, but doesn't require a single point of entry. >> Replace all existing initialization sections with this drop-in replacement. >> >> This brings debug support to all existing script-sty

Re: [Qemu-devel] [PATCH v2 1/6] tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p

2019-09-16 Thread Philippe Mathieu-Daudé
On 9/16/19 6:08 PM, Cleber Rosa wrote: > On Sun, Sep 15, 2019 at 11:19:35PM +0200, Philippe Mathieu-Daudé wrote: >> As of this commit, NetBSD 4.0 is very old. However it is enough to >> test the PRep/40p machine. >> >> User case from: >> http://mail-index.netbsd.org/port-prep/2017/04/11/msg000112.h

[Qemu-devel] [PATCH v2 0/1] Handle /proc/self/exe in execve

2019-09-16 Thread Olivier Dion
* Changes from v1 - Introduce the patch as a bug fix, rather than a security fix - Use do_openat and safe_execveat instead of copying exec_path - Extensive test case example * Test case I will present a short program that demonstrated the bug, i.e. what is the expected behavior and w

[Qemu-devel] [PATCH 13/13] hw/rtc/xlnx-zynqmp-rtc: Remove unused "ptimer.h" include

2019-09-16 Thread Philippe Mathieu-Daudé
The "hw/ptimer.h" header is not used, remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/xlnx-zynqmp-rtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/rtc/xlnx-zynqmp-rtc.c b/hw/rtc/xlnx-zynqmp-rtc.c index f9f09b7296..2bcd14d779 100644 --- a/hw/rtc/xlnx-zynqmp-rtc.c +++ b/hw/r

[Qemu-devel] [PATCH 12/13] hw/rtc/mc146818: Include mc146818rtc_regs.h a bit less

2019-09-16 Thread Philippe Mathieu-Daudé
Only 2 source files require the "mc146818rtc_regs.h" header. Instead of having it processed 12 times, by all objects using "mc146818rtc.h", include it directly where used. Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/mc146818rtc.c | 1 + hw/timer/hpet.c | 1 + include/hw

Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events

2019-09-16 Thread Philippe Mathieu-Daudé
On 9/16/19 6:36 PM, Eric Blake wrote: > On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote: >> While the tracing frawework does not forbid trailing newline in > > framework > >> events format string, using them lead to confuse output. >> It is the responsibility of the backend to properly end an ev

Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events

2019-09-16 Thread John Snow
On 9/16/19 12:40 PM, Philippe Mathieu-Daudé wrote: > On 9/16/19 6:36 PM, Eric Blake wrote: >> On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote: >>> While the tracing frawework does not forbid trailing newline in >> >> framework >> >>> events format string, using them lead to confuse output. >>>

[Qemu-devel] [PATCH 08/13] hw: Move DS1338 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The DS1338 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/Kconfig | 4 hw/rtc/Makefile.objs | 1 + hw/{timer => rtc}/ds1338.c | 0 hw/timer/Kconfig | 4 hw/timer/Makefile.objs |

[Qemu-devel] [PATCH 07/13] hw: Move TWL92230 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The TWL92230 is an "energy management device" companion with a RTC. Since we mostly model the RTC, move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/rtc/Kconfig | 4 hw/rtc/Makefile.objs | 1 + hw/

[Qemu-devel] [PATCH 05/13] hw: Move M41T80 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The M41T80 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 2 +- hw/rtc/Kconfig | 4 hw/rtc/Makefile.objs | 1 + hw/{timer => rtc}/m41t80.c | 0 hw/timer/Kconfig | 4

[Qemu-devel] [PATCH v2 1/1] Handle /proc/self/exe in syscall execve

2019-09-16 Thread Olivier Dion
If not handled, QEMU will execve itself instead of the emulated process. The function do_openat already solves the /proc/self/exe problem, so we can use it to get the executable file descriptor. We then make a safe call to execveat. Note that safe_execve has been replaced by safe_execveat, since

[Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The MC146818 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 +-- hw/alpha/dp264.c | 2 +- hw/hppa/machine.c| 2 +- hw/

[Qemu-devel] [PATCH 06/13] hw: Move sun4v hypervisor RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
Move RTC devices under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 ++-- hw/rtc/Kconfig| 3 +++ hw/rtc/Makefile.objs | 1 + hw/{timer => rtc}/sun4v-rtc.c | 2 +- hw/rtc/trace-events | 4 hw/spa

Re: [Qemu-devel] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

2019-09-16 Thread Eduardo Habkost
On Mon, Sep 16, 2019 at 11:28:23AM +0200, Philippe Mathieu-Daudé wrote: > Hi David, > > On 9/16/19 2:42 AM, David Gibson wrote: > > On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote: > >> Quick tests worth to avoid regressions with the 40p machine. > >> idea from the "Maintain

[Qemu-devel] [PATCH 04/13] hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The M48T59 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 +- hw/ppc/ppc405_boards.c | 2 +- hw/ppc/prep.c | 2 +- hw/rtc/Kconfig

Re: [Qemu-devel] test-aio-multithread assertion

2019-09-16 Thread Stefan Hajnoczi
On Wed, Sep 04, 2019 at 12:50:21PM +0100, Peter Maydell wrote: > Hi; I've been seeing intermittently on the BSDs this assertion > running test-aio-multithread as part of 'make check': > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > tests/test-aio-multithread -m=quick -k --ta

Re: [Qemu-devel] [PULL 00/16] Block patches

2019-09-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190916142246.31474-1-mre...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [Qemu-devel] [RFC v2 1/2] docs: vhost-user: add in-band kick/call messages

2019-09-16 Thread Michael S. Tsirkin
On Mon, Sep 16, 2019 at 01:40:35PM +0200, Johannes Berg wrote: > Hi Michael, > > I had just wanted to prepare a resend, but > > > > Hmm I don't like this. I propose that with > > > VHOST_USER_PROTOCOL_F_IN_BAND_NOTIFICATIONS > > > we just don't allow VHOST_USER_SET_VRING_CALL (if you think it's

[Qemu-devel] [PATCH 11/13] hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
Move RTC devices under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/Makefile.objs | 1 + hw/{timer => rtc}/aspeed_rtc.c | 2 +- hw/rtc/trace-events| 4 hw/timer/Makefile.objs | 2 +- hw/timer/trace-e

Re: [Qemu-devel] [PATCH v2 1/6] tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p

2019-09-16 Thread Cleber Rosa
On Sun, Sep 15, 2019 at 11:19:35PM +0200, Philippe Mathieu-Daudé wrote: > As of this commit, NetBSD 4.0 is very old. However it is enough to > test the PRep/40p machine. > > User case from: > http://mail-index.netbsd.org/port-prep/2017/04/11/msg000112.html > > Reviewed-by: Hervé Poussineau > Sig

[Qemu-devel] [PULL v2 00/29] Misc patches for 2019-09-16

2019-09-16 Thread Paolo Bonzini
The following changes since commit 138985c1ef8b66e4e5b383354e133e05d01d0b5f: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-sep-12-2019' into staging (2019-09-13 16:04:46 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream fo

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
12.09.2019 3:16, John Snow wrote: > Like script_main, but doesn't require a single point of entry. > Replace all existing initialization sections with this drop-in replacement. > > This brings debug support to all existing script-style iotests. > > Note: supported_oses=['linux'] was omitted, as i

Re: [Qemu-devel] [PATCH v1 02/28] target/riscv: Add the virtulisation mode

2019-09-16 Thread Alistair Francis
On Tue, Sep 10, 2019 at 6:44 AM Palmer Dabbelt wrote: > > On Fri, 23 Aug 2019 16:37:54 PDT (-0700), Alistair Francis wrote: > > Signed-off-by: Alistair Francis > > --- > > target/riscv/cpu.h| 4 > > target/riscv/cpu_bits.h | 6 ++ > > target/riscv/cpu_helper.c | 23 +

Re: [Qemu-devel] [PATCH qemu] loader: Trace loaded images

2019-09-16 Thread Stefan Hajnoczi
On Thu, Jun 13, 2019 at 03:09:37PM +1000, Alexey Kardashevskiy wrote: > This adds a trace point which prints every loaded image. This includes > bios/firmware/kernel/initradmdisk/pcirom. > > Signed-off-by: Alexey Kardashevskiy > --- > > The example for a pseries guest: > > loader_write_rom slof

Re: [Qemu-devel] [RFC v3 3/3] ARM: KVM: Check KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 for smp_cpus > 256

2019-09-16 Thread Andrew Jones
On Fri, Sep 13, 2019 at 11:56:39AM +0200, Eric Auger wrote: > Host kernel within [4.18, 5.3] report an erroneous KVM_MAX_VCPUS=512 > for ARM. The actual capability to instantiate more than 256 vcpus > was fixed in 5.4 with the upgrade of the KVM_IRQ_LINE ABI to support > vcpu id encoded on 12 bits

[Qemu-devel] [PATCH 02/13] hw: Move PL031 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The PL031 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 ++-- Makefile.objs | 1 + hw/Kconfig| 1 + hw/Makefile.objs | 1 + hw

Re: [Qemu-devel] [PATCH 3/3] tests/acceptance/migration: test to migrate will all machine types

2019-09-16 Thread Dr. David Alan Gilbert
* Balamuruhan S (bal...@linux.ibm.com) wrote: > add migration test to query machine types supported by qemu binary > and migrate vm will all supported type. > > Signed-off-by: Balamuruhan S Depending on the architecture you might find that some machine types aren't migratable while some are. Da

Re: [Qemu-devel] Is network backend netmap worth keeping?

2019-09-16 Thread Giuseppe Lettieri
Il 13/09/19 15:04, Markus Armbruster ha scritto: What happens when I build with --enable-netmap=system on host A, then run the resulting binary on some host B that doesn't have netmap installed? Qemu will fail at startup, complaining that /dev/netmap does not exists. Yes. We default to n

[Qemu-devel] [PATCH 01/13] hw/timer: Compile devices not target-dependent as common object

2019-09-16 Thread Philippe Mathieu-Daudé
All these devices do not contain any target-specific. While most of them are arch-specific, they are shared between different targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, endianess, ...). Put them into common-obj-y to compile them once for all targets. Signed-off-by: Philippe M

[Qemu-devel] [PULL 29/29] hw/i386/pc: Extract the x86 generic fw_cfg code

2019-09-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Extract all the functions that are not PC-machine specific into the (arch-specific) fw_cfg.c file. This will allow other X86-machine to reuse these functions. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190818225414.22590-16-phi.

[Qemu-devel] [PATCH 10/13] hw: Move Exynos4210 RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
Move RTC devices under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/Makefile.objs | 1 + hw/{timer => rtc}/exynos4210_rtc.c | 0 hw/timer/Makefile.objs | 1 - 3 files changed, 1 insertion(+), 1 deletion(-) rename hw/{timer => rtc}/exynos42

[Qemu-devel] [PULL 23/29] hw/i386/pc: Let pc_build_smbios() take a FWCfgState argument

2019-09-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Pass the FWCfgState object by argument, this will allow us to remove the PCMachineState argument later. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190818225414.22590-10-phi...@redhat.com> --- hw/i386/pc.c | 10 +- 1 fil

Re: [Qemu-devel] [PATCH v4 0/5] qcow2: async handling of fragmented io

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
16.09.2019 16:26, Max Reitz wrote: > On 13.09.19 10:58, Max Reitz wrote: >> On 16.08.19 17:30, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is an asynchronous scheme for handling fragmented qcow2 >>> reads and writes. Both qcow2 read and write functions loops through >>> sequential

[Qemu-devel] [PULL 24/29] hw/i386/pc: Let pc_build_smbios() take a generic MachineState argument

2019-09-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Let the pc_build_smbios() function take a generic MachineState argument. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190818225414.22590-11-phi...@redhat.com> --- hw/i386/pc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletio

[Qemu-devel] [PATCH 09/13] hw: Move Xilinx ZynqMP RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
Move RTC devices under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/Makefile.objs| 1 + hw/rtc/trace-events | 3 +++ hw/{timer => rtc}/xlnx-zynqmp-rtc.c | 2 +- hw/timer/Makefile.objs | 1 -

[Qemu-devel] [PULL 19/29] hw/i386/pc: Pass the boot_cpus value by argument

2019-09-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The boot_cpus is used once. Pass it by argument, this will allow us to remove the PCMachineState argument later. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190818225414.22590-6-phi...@redhat.com> --- hw/i386/pc.c | 7 --- 1

Re: [Qemu-devel] [PATCH] hw/*/Makefile.objs: Move many .o files to common-objs

2019-09-16 Thread Stefan Hajnoczi
On Thu, Sep 12, 2019 at 03:10:11PM +0200, Thomas Huth wrote: > We have many files that apparently do not depend on the target CPU > configuration, i.e. which can be put into common-obj-y instead of > obj-y. This way, the code can be shared for example between > qemu-system-arm and qemu-system-aarch

[Qemu-devel] [PULL 25/29] hw/i386/pc: Rename pc_build_smbios() as generic fw_cfg_build_smbios()

2019-09-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Now that the pc_build_smbios() function has been refactored to not depend of PC specific types, rename it to a more generic name. Suggested-by: Samuel Ortiz Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190818225414.22590-12-phi...@redhat.com> --- hw/i386/p

[Qemu-devel] [PULL 18/29] hw/i386/pc: Rename bochs_bios_init as more generic fw_cfg_arch_create

2019-09-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The bochs_bios_init() function is not restricted to the Bochs BIOS and is useful to other BIOS. Since it is not specific to the PC machine, and can be reused by other machines of the X86 architecture, rename it as fw_cfg_arch_create(). Suggested-by: Samuel Ortiz Rev

[Qemu-devel] [PATCH 00/13] hw: Split RTC devices from hw/timer/ to hw/rtc/

2019-09-16 Thread Philippe Mathieu-Daudé
When working on timers, I found it confuse to have RTC devices mixed in the hw/timer/ directory. We can see the models use slighly different APIs: $ git grep '#include' hw/timer/|cut -d: -f3-|sort|uniq -c|egrep -v '^ 1 '|sort -rn 33 #include "qemu/osdep.h" 29 #include "hw/irq.h"

[Qemu-devel] [PULL 17/29] hw/i386/pc: Use address_space_memory in place

2019-09-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The address_space_memory variable is used once. Use it in place and remove the argument. Suggested-by: Samuel Ortiz Reviewed-by: Li Qiang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190818225414.22590-4-phi...@redhat.com> --- hw/i386/pc.c | 7 --- 1

[Qemu-devel] [PULL 16/29] hw/i386/pc: Extract e820 memory layout code

2019-09-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Suggested-by: Samuel Ortiz Reviewed-by: Li Qiang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190818225414.22590-3-phi...@redhat.com> --- hw/i386/Makefile.objs| 2 +- hw/i386/e820_memory_layout.c | 59 ++ hw

[Qemu-devel] [PULL 14/29] cpus: Fix throttling during vm_stop

2019-09-16 Thread Paolo Bonzini
From: Yury Kotov Throttling thread sleeps in VCPU thread. For high throttle percentage this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. vm_stop() kicks all VCPUs and waits for them. It's called at the end of migration and because of the long sleep the migration downtime might b

Re: [Qemu-devel] [PATCH v7 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335

2019-09-16 Thread Maxim Levitsky
On Mon, 2019-09-16 at 16:59 +0300, Maxim Levitsky wrote: > On Mon, 2019-09-16 at 15:39 +0200, Max Reitz wrote: > > On 15.09.19 22:36, Maxim Levitsky wrote: > > > Commit 8ac0f15f335 accidently broke the COW of non changed areas > > > of newly allocated clusters, when the write spans multiple cluster

[Qemu-devel] [PULL 15/29] hw/i386/pc: Use e820_get_num_entries() to access e820_entries

2019-09-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé To be able to extract the e820* code out of this file (in the next patch), access e820_entries with its correct helper. Reviewed-by: Li Qiang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190818225414.22590-2-phi...@redhat.com> --- hw/i386/pc.c | 2 +- 1 fi

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2019-09-16 Thread Michael S. Tsirkin
On Mon, Dec 24, 2018 at 04:11:43PM +0800, Yi Zhang wrote: > On 2018-12-21 at 11:36:07 -0500, Michael S. Tsirkin wrote: > > On Fri, Dec 21, 2018 at 11:18:18AM +0800, Yi Zhang wrote: > > > On 2018-12-20 at 09:06:41 -0500, Michael S. Tsirkin wrote: > > > > On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi

[Qemu-devel] [PULL 11/29] memory: fetch pmem size in get_file_size()

2019-09-16 Thread Paolo Bonzini
From: Stefan Hajnoczi Neither stat(2) nor lseek(2) report the size of Linux devdax pmem character device nodes. Commit 314aec4a6e06844937f1677f6cba21981005f389 ("hostmem-file: reject invalid pmem file sizes") added code to hostmem-file.c to fetch the size from sysfs and compare against the user-

[Qemu-devel] [PULL 12/29] memory: inline and optimize devend_memop

2019-09-16 Thread Paolo Bonzini
devend_memop can rely on the fact that the result is always either 0 or MO_BSWAP, corresponding respectively to host endianness and the opposite. Native (target) endianness in turn can be either the host endianness, in which case MO_BSWAP is only returned for host-opposite endianness, or the oppos

[Qemu-devel] [PULL 09/29] hw/i386: Move CONFIG_ACPI_PCI to CONFIG_PC

2019-09-16 Thread Paolo Bonzini
From: Cole Robinson CONFIG_ACPI_PCI is a hard requirement of acpi-build.c, which is built unconditionally for x86 target. Putting it in default-configs/ suggests that it can be easily disabled, which isn't true. Relocate the symbol with the other acpi-build.c requirements, under 'config PC'. Thi

Re: [Qemu-devel] [RFC v3 2/3] intc/arm_gic: Support IRQ injection for more than 256 vpus

2019-09-16 Thread Andrew Jones
On Fri, Sep 13, 2019 at 11:56:38AM +0200, Eric Auger wrote: > Host kernels that expose the KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 capability > allow injection of interrupts along with vcpu ids larger than 255. > Let's encode the vpcu id on 12 bits according to the upgraded KVM_IRQ_LINE > ABI when needed. >

[Qemu-devel] [PULL 01/29] i386/kvm: support guest access CORE cstate

2019-09-16 Thread Paolo Bonzini
From: Wanpeng Li Allow guest reads CORE cstate when exposing host CPU power management capabilities to the guest. PKG cstate is restricted to avoid a guest to get the whole package information in multi-tenant scenario. Cc: Eduardo Habkost Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wan

[Qemu-devel] [PULL 06/29] exec.c: add a check between constants to see whether we could skip

2019-09-16 Thread Paolo Bonzini
From: Wei Yang The maximum level is defined as P_L2_LEVELS and skip is defined with 6 bits, which means if P_L2_LEVELS < (1 << 6), skip never exceeds the boundary. Since this check is between two constants, which leverages compiler to optimize the code based on different configuration. Signed-o

Re: [Qemu-devel] [PATCH v6 28/42] stream: Deal with filters

2019-09-16 Thread Kevin Wolf
Am 16.09.2019 um 11:52 hat Max Reitz geschrieben: > On 13.09.19 16:16, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> @@ -261,16 +272,19 @@ void stream_start(const char *job_id, > >> BlockDriverState *bs, > >> * disappear from the chain after this operation. The

  1   2   3   >