Re: [Qemu-devel] [PATCH v2 01/16] scripts/git.orderfile: Match QAPI schema more precisely

On 9/10/19 8:37 AM, Markus Armbruster wrote: > Pattern *.json also matches the tests/qapi-schema/*.json. Separates > them from the tests/qapi-schema/*.{err,exit,out} in diffs. I hate > that. Change the pattern to match just the "real" QAPI schemata. > > Signed-off-by: Markus Armbruster > --- >

[Qemu-devel] [PATCH v2 15/16] docs/devel/qapi-code-gen: Improve QAPI schema language doc

We document the language by giving patterns of valid JSON objects. The patterns contain placeholders we don't define anywhere; their names have to speak for themselves. I guess they do, but I'd prefer a bit more rigor. Provide a grammar instead, and rework the text accordingly. Documentation for

[Qemu-devel] [PATCH v2 08/16] qapi: Permit 'boxed' with empty type

We reject empty types with 'boxed': true. We don't really need that to work, but making it work is actually simpler than rejecting it, so do that. Signed-off-by: Markus Armbruster --- tests/test-qmp-cmds.c | 4 scripts/qapi/commands.py| 4 ++-- scripts/q

[Qemu-devel] [PATCH v2 00/16] qapi: Schema language cleanups & doc improvements

v2: * PATCH v1 05: Dropped * PATCH 01,05,07-11,16: New * PATCH 03: - Commit message typo fixed - Assertions tightened * PATCH 04: - Document member name 'u' is reserved - Drop an accidental change to section "Enumeration types" - Typo fixed * PATCH 06: - Outlaw anything but printable AS

[Qemu-devel] [PATCH v2 09/16] qapi: Permit alternates with just one branch

A union or alternate without branches makes no sense and doesn't work: it can't be instantiated. A union or alternate with just one branch works, but is degenerate. We accept the former, but reject the latter. Weird. docs/devel/qapi-code-gen.txt doesn't mention the difference. It claims an alt

[Qemu-devel] [PATCH v2 13/16] docs/devel/qapi-code-gen: Rewrite compatibility considerations

We have some compatibility advice buried in sections "Enumeration types" and "Struct types". Compatibility is actually about commands and events. It devolves to the types used there. All kinds of types, not just enumerations and structs. Replace the existing advice by a new section "Compatibili

[Qemu-devel] [PATCH v2 02/16] qapi: Drop check_type()'s redundant parameter @allow_optional

check_type() uses @allow_optional only when @value is a dictionary and @allow_dict is True. All callers that pass allow_dict=True also pass allow_optional=True. Therefore, @allow_optional is always True when check_type() uses it. Drop the redundant parameter. Signed-off-by: Markus Armbruster --

[Qemu-devel] [PATCH v2 16/16] qapi: Tweak code to match docs/devel/qapi-code-gen.txt

The previous commit made qapi-code-gen.txt define "(top-level) expression" as either "directive" or "definition". The code still uses "expression" when it really means "definition". Tidy up. The previous commit made qapi-code-gen.txt use "object" rather than "dictionary". The code still uses "d

[Qemu-devel] [PATCH v2 07/16] qapi: Drop support for escape sequences other than \\

Since the previous commit restricted strings to printable ASCII, \u's only use is obfuscation. Drop it. This leaves \\, \/, \', and \". Since QAPI schema strings are all names, and names are restricted to ASCII letters, digits, hyphen, and underscore, none of them is useful. The latter thre

[Qemu-devel] [PATCH v2 14/16] docs/devel/qapi-code-gen: Rewrite introduction to schema

The introduction to the QAPI schema is somewhat rambling. Rewrite for clarity. Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt | 106 --- 1 file changed, 47 insertions(+), 59 deletions(-) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/q

[Qemu-devel] [PATCH v2 01/16] scripts/git.orderfile: Match QAPI schema more precisely

Pattern *.json also matches the tests/qapi-schema/*.json. Separates them from the tests/qapi-schema/*.{err,exit,out} in diffs. I hate that. Change the pattern to match just the "real" QAPI schemata. Signed-off-by: Markus Armbruster --- scripts/git.orderfile | 4 ++-- 1 file changed, 2 inserti

[Qemu-devel] [PATCH v2 11/16] qapi: Adjust frontend errors to say enum value, not member

For consistency with docs/devel/qapi-code-gen.txt. Signed-off-by: Markus Armbruster --- scripts/qapi/common.py | 11 --- tests/qapi-schema/enum-clash-member.err | 2 +- tests/qapi-schema/enum-member-case.err | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) d

[Qemu-devel] [PATCH v2 03/16] qapi: Drop support for boxed alternate arguments

Commands and events can define their argument type inline (default) or by referring to another type ('boxed': true, since commit c818408e44 "qapi: Implement boxed types for commands/events", v2.7.0). The unboxed inline definition is an (anonymous) struct type. The boxed type may be a struct, unio

[Qemu-devel] [PATCH v2 06/16] qapi: Restrict strings to printable ASCII

RFC 8259 on string contents: All Unicode characters may be placed within the quotation marks, except for the characters that MUST be escaped: quotation mark, reverse solidus, and the control characters (U+ through U+001F). The QAPI schema parser accepts both less and more than JSO

[Qemu-devel] [PATCH v2 04/16] docs/devel/qapi-code-gen: Minor specification fixes

The specification claims "Each expression that isn't an include directive may be preceded by a documentation block", but the code also rejects them for pragma directives. The code is correct. Fix the specification. The specification reserves member names starting with 'has_', but the code also r

[Qemu-devel] [PATCH v2 12/16] docs/devel/qapi-code-gen: Reorder sections for readability

Section "QMP/Guest agent schema" starts with a brief introduction, then subsection "Comments", then subsection "Schema overview" (more elaborate introduction), and only then talks about schema entities like types, commands, and so forth. Subsection "Comments" is long and tiring: almost 500 words,

[Qemu-devel] [PATCH v2 05/16] tests/qapi-schema: Demonstrate bad reporting of funny characters

Invalid name 'not\\possible' is reported as 'not\possible'. Control characters (quoted or not) are even more confusing. Mark FIXME. Signed-off-by: Markus Armbruster --- tests/qapi-schema/enum-bad-name.err | 2 +- tests/qapi-schema/enum-bad-name.json | 3 ++- 2 files changed, 3 insertions(+),

[Qemu-devel] [PATCH v2 10/16] qapi: Permit omitting all flat union branches

Absent flat union branches default to the empty struct (since commit 800877bb16 "qapi: allow empty branches in flat unions"). But am attempt to omit all of them is rejected with "Union 'FOO' has no branches". Harmless oddity, but it's easy to avoid, so do that. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

Hi John, This issue can only be reproduced on Windows 10. I've observed and compared the behavior of Windows 10 and Windows 7. It seems Windows 7 wouldn't disable the PCI_COMMAND_MASTER flag when disabling ahci devices. That's why this issue won't happen on Win7. Here's the trace log on both gue

[Qemu-devel] [PATCH] spapr/irq: Only claim VALID interrupts at the KVM level

A typical pseries VM with 16 vCPUs, one disk, one network adapater uses less than 100 interrupts but the whole IRQ number space of the QEMU machine is allocated at reset time and it is 8K wide. This is wasting considerably the global IRQ space of the overall system which has 1M interrupts per socke

[Qemu-devel] [Bug 1832250] Re: arm32v6/golang:1.10-alpine is broken for qemu 2.8 on MacOS cross-compilation

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1832250 Title: arm32v6/gol

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on high core count ARM system

Alright, I'm still investigating this but wanted to share some findings... I haven't got a kernel dump yet after the task is frozen, I have analyzed only the userland part of it (although I have checked if code was running inside kernel with perf cycles:u/cycles:k at some point). The big picture

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

On 2019-08-28 12:39, Maxim Levitsky wrote: On Wed, 2019-08-28 at 11:26 +0100, Daniel P. Berrangé wrote: On Wed, Aug 28, 2019 at 01:14:03PM +0300, Maxim Levitsky wrote: On Wed, 2019-08-28 at 10:53 +0100, Daniel P. Berrangé wrote: On Wed, Aug 28, 2019 at 12:43:49AM +0200, Zoltán Kővágó wrote: O

Re: [Qemu-devel] [PATCH] spapr-tpm-proxy: Drop misleading check

On Mon, Sep 09, 2019 at 08:10:09PM +0200, Greg Kurz wrote: > Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL > tpm_proxy->host_path pointer to open(). This is based on the fact that > h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes > tpm_proxy to tpm_e

Re: [Qemu-devel] [Qemu-block] [PATCH v4 1/5] tests/qemu-iotests: Fix qemu-io related output in 026.out.nocache

On 8/16/19 11:30 AM, Vladimir Sementsov-Ogievskiy wrote: > qemu-io now prefixes its error and warnings with "qemu-io:". > 36b9986b08787019e fixed a lot of iotests output but forget about > 026.out.nocache. Fix it too. > > Fixes: 99e98d7c9fc1a1639fad ("qemu-io: Use error_[gs]et_progname()") > Si

Re: [Qemu-devel] [PATCH 3/3] hw/mips/mips_jazz: Remove no-longer-necessary override of do_unassigned_access

Le 02/08/2019 à 18:04, Peter Maydell a écrit : Now that the MIPS CPU implementation uses the new do_transaction_failed hook, we can remove the old code that handled the do_unassigned_access hook. Signed-off-by: Peter Maydell --- hw/mips/mips_jazz.c | 27 --- 1 file ch

Re: [Qemu-devel] [PATCH 2/3] target/mips: Switch to do_transaction_failed() hook

Le 02/08/2019 à 18:04, Peter Maydell a écrit : Switch the MIPS target from the old unassigned_access hook to the new do_transaction_failed hook. Unlike the old hook, do_transaction_failed is only ever called from the TCG memory access paths, so there is no need for the "ignore this if we're usin

Re: [Qemu-devel] [PATCH 1/3] hw/mips/mips_jazz: Override do_transaction_failed hook

Le 02/08/2019 à 18:04, Peter Maydell a écrit : The MIPS Jazz ('magnum' and 'pica61') boards have some code which overrides the CPU's do_unassigned_access hook, so they can intercept it and not raise exceptions on data accesses to invalid addresses, only for instruction fetches. We want to switch

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.277

Re: [Qemu-devel] [Qemu-block] [PATCH 6/6] curl: Check curl_multi_add_handle()'s return code

On 8/27/19 12:34 PM, Max Reitz wrote: > If we had done that all along, debugging would have been much simpler. > (Also, I/O errors are better than hangs.) > > Signed-off-by: Max Reitz > --- > block/curl.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/block/c

Re: [Qemu-devel] [Qemu-block] [PATCH 5/6] curl: Handle success in multi_check_completion

On 8/27/19 12:34 PM, Max Reitz wrote: > Background: As of cURL 7.59.0, it verifies that several functions are > not called from within a callback. Among these functions is > curl_multi_add_handle(). > > curl_read_cb() is a callback from cURL and not a coroutine. Waking up > acb->co will lead

Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] curl: Report only ready sockets

On 8/27/19 12:34 PM, Max Reitz wrote: > Instead of reporting all sockets to cURL, only report the one that has > caused curl_multi_do_locked() to be called. This lets us get rid of the > QLIST_FOREACH_SAFE() list, which was actually wrong: SAFE foreaches are > only safe when the current element

Re: [Qemu-devel] [Qemu-block] [PATCH 3/6] curl: Pass CURLSocket to curl_multi_{do, read}()

On 8/27/19 12:34 PM, Max Reitz wrote: > curl_multi_do_locked() currently marks all sockets as ready. That is > not only inefficient, but in fact unsafe (the loop is). A follow-up > patch will change that, but to do so, curl_multi_do_locked() needs to > know exactly which socket is ready; and t

Re: [Qemu-devel] [Qemu-block] [PATCH 2/6] curl: Keep *socket until the end of curl_sock_cb()

On 8/27/19 12:34 PM, Max Reitz wrote: > This does not really change anything, but it makes the code a bit easier > to follow once we use @socket as the opaque pointer for > aio_set_fd_handler(). > > (Also, this change stops us from creating new CURLSocket objects when > the cURL library just wa

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.277

Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] curl: Keep pointer to the CURLState in CURLSocket

On 8/27/19 12:34 PM, Max Reitz wrote: > A follow-up patch will make curl_multi_do() and curl_multi_read() take a > CURLSocket instead of the CURLState. They still need the latter, > though, so add a pointer to it to the former. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Reitz > --- >

Re: [Qemu-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

On 09/09/19 21:15, Laszlo Ersek wrote: > ... I've done some testing too. Applying the QEMU patch on top of > 89ea03a7dc83, my plan was: > > - do not change OVMF, just see if it continues booting with the QEMU > patch > > - then negotiate bit#1 too, in step (1a) -- this is when I'd expect (3a) >

Re: [Qemu-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

Hi Igor, On 09/05/19 17:49, Igor Mammedov wrote: > lpc already has SMI negotiation feature, extend it by adding > optin ICH9_LPC_SMI_F_LOCKED_SMBASE_BIT to supported features. > > Writing this bit into "etc/smi/requested-features" fw_cfg file, > tells QEMU to alias 0x3,128K RAM range into SMRA

Re: [Qemu-devel] [PATCH] spapr-tpm-proxy: Drop misleading check

Quoting Greg Kurz (2019-09-09 13:10:09) > Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL > tpm_proxy->host_path pointer to open(). This is based on the fact that > h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes > tpm_proxy to tpm_execute(). > > The

Re: [Qemu-devel] [PATCH v2 2/3] iotests: add protocol support to initialization info

On 9/9/19 6:09 AM, Max Reitz wrote: > On 29.07.19 23:35, John Snow wrote: >> This will add supported_protocols and unsupported_protocols to all of >> iotests.main, iotests.script_main, and iotests.script_initialize. >> >> Signed-off-by: John Snow >> --- >> tests/qemu-iotests/207| 4 ++-

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

Eric Blake writes: > How hard would it be to improve 'git format-patch'/'git send-email' to > have an option to ALWAYS output a From: line in the body, even when the > sender is the author, for the case of a mailing list that munges the > mail headers due to DMARC/DKIM reasons? I'd say that it s

Re: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

Patchew URL: https://patchew.org/QEMU/1568049517-10261-1-git-send-email-andyc...@synology.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines M

Re: [Qemu-devel] [PATCH v2 1/3] iotests: add script_initialize

On 9/9/19 6:06 AM, Max Reitz wrote: > On 29.07.19 23:35, John Snow wrote: >> Like script_main, but doesn't require a single point of entry. >> Replace all existing initialization sections with this drop-in replacement. >> >> This brings debug support to all existing script-style iotests. >> >> N

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

Le 09/09/2019 à 18:11, Peter Maydell a écrit : > On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> Reviewed-by: Hervé Poussineau > >> +static void sysbus_swim_class_init(ObjectClass

Re: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

On 9/9/19 1:18 PM, andychiu via Qemu-devel wrote: > If Windows 10 guests have enabled 'turn off hard disk after idle' > option in power settings, and the guest has a SATA disk plugged in, > the SATA disk will be turned off after a specified idle time. > If the guest is live migrated or saved/loa

[Qemu-devel] [PATCH] spapr-tpm-proxy: Drop misleading check

Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL tpm_proxy->host_path pointer to open(). This is based on the fact that h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes tpm_proxy to tpm_execute(). The check in h_tpm_comm() is abusive actually since a sp

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.277

Re: [Qemu-devel] [PATCH] Replace '-machine accel=xyz' with '-accel xyz'

On 09/09/2019 19.06, Paolo Bonzini wrote: [...] > > Thanks. While "-accel kvm:tcg" is not going to be supported, the above > replacement are all good. I guess we should really do something about that before people start using it in the wild... Thomas

[Qemu-devel] [PATCH] MAINTAINERS: update virtio-rng and virtio-serial maintainer

As discussed with Amit, I volunteer to maintain virtio-rng and virtio-serial previously maintained by Amit. Signed-off-by: Laurent Vivier --- MAINTAINERS | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 50eaf005f40e..db916ade55cd 100644 --

Re: [Qemu-devel] [PULL 20/42] spapr: initial implementation for H_TPM_COMM/spapr-tpm-proxy

On Mon, 9 Sep 2019 18:23:20 +0100 Peter Maydell wrote: > On Wed, 21 Aug 2019 at 08:26, David Gibson > wrote: > > > > From: Michael Roth > > > > This implements the H_TPM_COMM hypercall, which is used by an > > Ultravisor to pass TPM commands directly to the host's TPM device, or > > a TPM Reso

Re: [Qemu-devel] qcow2 lock

09.09.2019 15:57, Kevin Wolf wrote: > Am 09.09.2019 um 14:16 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 09.09.2019 13:47, Kevin Wolf wrote: >>> Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi! I have a (may be stupid) question: what is BDRVQcow2State.loc

Re: [Qemu-devel] [PATCH] hw/i386: Move CONFIG_ACPI_PCI to CONFIG_PC

On 09/09/19 19:34, Cole Robinson wrote: > CONFIG_ACPI_PCI is a hard requirement of acpi-build.c, which is built > unconditionally for x86 target. Putting it in default-configs/ suggests > that it can be easily disabled, which isn't true. > > Relocate the symbol with the other acpi-build.c requirem

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

09.09.2019. 18.32, "Aleksandar Markovic" је написао/ла: > > > 09.09.2019. 18.03, "Laurent Vivier" је написао/ла: > > > > Co-developed-by: Mark Cave-Ayland > > Signed-off-by: Mark Cave-Ayland > > Signed-off-by: Laurent Vivier > > Reviewed-by: Hervé Poussineau > > --- > > Laurent, hi! > > I am

Re: [Qemu-devel] [PULL 01/12] util/iov: introduce qemu_iovec_init_extended

On Tue, 27 Aug 2019 at 21:16, Stefan Hajnoczi wrote: > > From: Vladimir Sementsov-Ogievskiy > > Introduce new initialization API, to create requests with padding. Will > be used in the following patch. New API uses qemu_iovec_init_buf if > resulting io vector has only one element, to avoid extra

Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages

On Mon, 2019-09-09 at 18:00 +0200, Stefan Hajnoczi wrote: > Is this really necessary? Yes* :) > Can the simulation interpose between the > call/kick eventfds in order to control when events happen? > > CPU --cpu_kickfd--> Simulation --vhost_kickfd--> vhost-user device > > and: > > vhost

[Qemu-devel] [PATCH] hw/i386: Move CONFIG_ACPI_PCI to CONFIG_PC

CONFIG_ACPI_PCI is a hard requirement of acpi-build.c, which is built unconditionally for x86 target. Putting it in default-configs/ suggests that it can be easily disabled, which isn't true. Relocate the symbol with the other acpi-build.c requirements, under 'config PC'. This is similar to what i

Re: [Qemu-devel] [PULL 1/9] qapi: Add InetSocketAddress member keep-alive

On Thu, 15 Aug 2019 at 19:34, Eric Blake wrote: > > From: Vladimir Sementsov-Ogievskiy > > It's needed to provide keepalive for nbd client to track server > availability. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Message-Id: <20190725094937.32454-1-vsement...@virtuozzo.com> > Reviewed-by

Re: [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host

On 28/08/19 19:22, Mark Kanda wrote: > Gentle ping - I would like to confirm this patch is acceptable. Yes, it was squashed in Marcelo's patch (commit d645e1328726b38b3c79525eb57842ce29c1df7c). Paolo > Thanks/regards, > -Mark > > On 7/17/2019 9:38 AM, Mark Kanda wrote: >> The halt poll control

Re: [Qemu-devel] [PULL v2 01/16] qemu-io: add pattern file for write command

On Tue, 3 Sep 2019 at 14:35, Max Reitz wrote: > > From: Denis Plotnikov > > The patch allows to provide a pattern file for write > command. There was no similar ability before. > > Signed-off-by: Denis Plotnikov > Message-id: 20190820164616.4072-1-dplotni...@virtuozzo.com > Reviewed-by: Eric Bla

Re: [Qemu-devel] IOTEST 162

On 9/6/19 1:25 PM, Maxim Levitsky wrote: > Hi! > > I just had a very fun rabbit hole dive, and I want to share it with you. > > I notice for some time that iotest 162 fails with that: > > -qemu-img: Could not open 'json:{"driver": "nbd", "host": 42}': Failed to > connect socket: Invalid argu

Re: [Qemu-devel] [PULL 20/42] spapr: initial implementation for H_TPM_COMM/spapr-tpm-proxy

On Wed, 21 Aug 2019 at 08:26, David Gibson wrote: > > From: Michael Roth > > This implements the H_TPM_COMM hypercall, which is used by an > Ultravisor to pass TPM commands directly to the host's TPM device, or > a TPM Resource Manager associated with the device. > > This also introduces a new vi

Re: [Qemu-devel] [PULL 03/15] audio: basic support for multi backend audio

On Wed, 21 Aug 2019 at 09:49, Gerd Hoffmann wrote: > > From: Kővágó, Zoltán > > Audio functions no longer access glob_audio_state, instead they get an > AudioState as a parameter. This is required in order to support > multiple backends. > > glob_audio_state is also gone, and replaced with a tai

[Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

If Windows 10 guests have enabled 'turn off hard disk after idle' option in power settings, and the guest has a SATA disk plugged in, the SATA disk will be turned off after a specified idle time. If the guest is live migrated or saved/loaded with its SATA disk turned off, the following error will o

Re: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect

On 02/09/19 11:02, Daniel P. Berrangé wrote: >>> === OUTPUT BEGIN === >>> ERROR: spaces required around that '*' (ctx:WxB) >>> #118: FILE: ui/vnc-enc-tight.c:355: >>> +data = (uint##bpp##_t *)vs->tight->tight.buffer;\ >>>^ >>> >>> >> Hello Pao

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.277

Re: [Qemu-devel] [Qemu-arm] [RFC PATCH 12/14] hw/arm/bcm2836: Add the BCM2838 which uses a GICv2

Hi Luc, On 9/5/19 10:41 AM, Luc Michel wrote: > On 9/4/19 7:13 PM, Philippe Mathieu-Daudé wrote: >> The BCM2838 is improvement of the BCM2837: >> - Cortex-A72 instead of the A53 >> - peripheral block and local soc controller are mapped differently, >> - GICv2 >> - PCIe block >> - exhanced MMU to a

Re: [Qemu-devel] [PATCH] Replace '-machine accel=xyz' with '-accel xyz'

On 04/09/19 07:27, Thomas Huth wrote: > We've got a separate option to configure the accelerator nowadays, which > is shorter to type and the preferred way of specifying an accelerator. > Use it in the source and examples to show that it is the favored option. > (However, do not touch the places ye

Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

On 9/9/19 5:25 AM, Max Reitz wrote: > On 05.09.19 19:27, John Snow wrote: > > [...] > >> You also probably require review (or at least an ACK) from Keith Busch >> who maintains this file. > > Keith actually maintains the NVMe guest device; technically, Fam is the > NVMe block driver maintaine

Re: [Qemu-devel] Greetings qemu folks

On Mon, 9 Sep 2019 at 17:56, John Snow wrote: > On 9/7/19 9:58 AM, Toe Dev wrote: > > 2) My main target is to output a lot of this to console cause I new to qemu > > and I want fastfeedback on stuff like this. I try start > > qemu with -D option but the log files never have bee

Re: [Qemu-devel] [PATCH v2 0/3] tests/tcg: disentangle makefiles

On 04/09/19 16:27, Alex Bennée wrote: >> Ping? > > Sorry I should have said I've queued it to testing/next. I'll post the > series shortly after I've squashed the last annoying python 3.<>6 > problem. Great, thanks. Paolo

Re: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.277

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on high core count ARM system

Alright, with a d06 aarch64 machine I was able to reproduce it after 8 attempts.I'll debug it today and provide feedback on my findings. (gdb) bt full #0 0xb0b2181c in __GI_ppoll (fds=0xce5ab770, nfds=4, timeout=, timeout@entry=0x0, sigmask=sigmask@entry=0x0) at ../sysdeps/unix/s

Re: [Qemu-devel] Greetings qemu folks

On 9/7/19 9:58 AM, Toe Dev wrote: > I am new in QEMU developing and I have general questions about QEMU source > code as I could not find any guidelines about it. > Hi, welcome! > 1) I have no success running qemu in nographic mode. >The internet says using chardev driver to redirect kern

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

Le 09/09/2019 à 18:32, Aleksandar Markovic a écrit : > > 09.09.2019. 18.03, "Laurent Vivier" > је написао/ла: >> >> Co-developed-by: Mark Cave-Ayland > >> Signed-off-by: Mark Cave-Ayland > >> S

Re: [Qemu-devel] [PATCH] nbd/client: Add hint when TLS is missing

On 9/9/19 4:13 AM, Daniel P. Berrangé wrote: > On Sat, Sep 07, 2019 at 12:20:55PM -0500, Eric Blake wrote: >> I received an off-list report of failure to connect to an NBD server >> expecting an x509 certificate, when the client was attempting something >> similar to this command line: >> >> +++ b

Re: [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text

On 9/6/19 7:39 AM, Thomas Huth wrote: > When running "make check -j8" or something similar, the iotests are > running in parallel with the other tests. So when they are printing > out "Passed all xx tests" or a similar status message at the end, > it might not be quite clear that this message be

Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script

On 9/6/19 7:35 AM, Thomas Huth wrote: > The check script is already printing out which iotest is currently > running, so printing out the name of the check-block.sh shell script > looks superfluous here. > > Signed-off-by: Thomas Huth Makes sense. Acked-by: John Snow > --- > tests/Makefil

Re: [Qemu-devel] [PATCH] tests/Makefile: test-char does not need libqtest

On 9/6/19 11:26 AM, Thomas Huth wrote: > No need to link the libqtest objects here. > > Signed-off-by: Thomas Huth Reviewed-by: John Snow > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

Le 09/09/2019 à 18:18, Dr. David Alan Gilbert a écrit : > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: >>> >>> Co-developed-by: Mark Cave-Ayland >>> Signed-off-by: Mark Cave-Ayland >>> Signed-off-by: Laurent Vivier >>> Reviewed-by: Herv

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

09.09.2019. 18.03, "Laurent Vivier" је написао/ла: > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > Reviewed-by: Hervé Poussineau > --- Laurent, hi! I am not sure how "Co-developed-by:" fits in our workflow. There was some recent talk

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 3/5] s390: vfio_pci: Use a PCI Group structure

On 9/9/19 1:18 AM, Thomas Huth wrote: > On 07/09/2019 02.16, Matthew Rosato wrote: >> From: Pierre Morel >> >> We use a S390PCIGroup structure to hold the information >> related to zPCI Function group. >> >> This allows us to be ready to support multiple groups and to retrieve >> the group informa

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

On Mon, 9 Sep 2019 at 17:18, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > Missing reset and VMState for migration. These should be > > baseline requirements for adding new device models to the > > tree, because in an ideal world every device would support

Re: [Qemu-devel] [PATCH v8 21/32] riscv: sifive: Implement PRCI model for FU540

On Fri, 06 Sep 2019 09:20:08 PDT (-0700), bmeng...@gmail.com wrote: This adds a simple PRCI model for FU540 (sifive_u). It has different register layout from the existing PRCI model for FE310 (sifive_e). Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v8: None Changes in

Re: [Qemu-devel] [PATCH v8 01/32] riscv: hw: Remove duplicated "hw/hw.h" inclusion

On Fri, 06 Sep 2019 09:19:48 PDT (-0700), bmeng...@gmail.com wrote: Commit a27bd6c779ba ("Include hw/qdev-properties.h less") wrongly added "hw/hw.h" to sifive_prci.c and sifive_test.c. Another inclusion of "hw/hw.h" was later added via commit 650d103d3ea9 ("Include hw/hw.h exactly where needed"

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: > > > > Co-developed-by: Mark Cave-Ayland > > Signed-off-by: Mark Cave-Ayland > > Signed-off-by: Laurent Vivier > > Reviewed-by: Hervé Poussineau > > > +static void sysbus_swim_class_init(Ob

Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages

On Thu, Sep 05, 2019 at 10:28:33PM +0200, Johannes Berg wrote: > > > +``VHOST_USER_VQ_CALL`` > > + :id: 34 > > + :equivalent ioctl: N/A > > + :slave payload: vring state description > > + :master payload: N/A > > Oops. This message should be called VHOST_USER_VRING_KICK. > > This file doesn

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

Am 09.09.2019 um 16:04 hat Max Reitz geschrieben: > On 09.09.19 11:36, Kevin Wolf wrote: > > Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: > >> On 04.09.19 18:16, Kevin Wolf wrote: > >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > There are BDS children that the general block layer

Re: [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

On Mon, 9 Sep 2019 at 17:05, Laurent Vivier wrote: > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > Reviewed-by: Hervé Poussineau > +static void sysbus_swim_class_init(ObjectClass *oc, void *data) > +{ > +DeviceClass *dc = DEVICE_CL

[Qemu-devel] [PATCH v9 3/9] hw/m68k: add via support

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/misc/Kconfig | 4 + hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 692 ++ include/hw/misc/mac_vi

[Qemu-devel] [PATCH v9 9/9] hw/m68k: define Macintosh Quadra 800

If you want to test the machine, it doesn't yet boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer with: ./qemu-system-m68k \ -M q800 \ -serial none -serial mon:stdio \ -m 1000M -drive file=m68k.qcow2,format=q

[Qemu-devel] [PATCH v9 6/9] hw/m68k: add Nubus support

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth --- hw/Kconfig | 1 + hw/Makefile.objs| 1 + hw/nubus/Kconfig| 2 + hw/nubus/Makefile.objs

[Qemu-devel] [PATCH v9 5/9] hw/m68k: add macfb video card

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- arch_init.c| 4 + hw/display/Kconfig | 3 + hw/display/Makefile.objs | 1 + hw/display/macfb.c | 4

[Qemu-devel] [PATCH v9 1/9] esp: add pseudo-DMA as used by Macintosh

There is no DMA in Quadra 800, so the CPU reads/writes the data from the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them to/from the memory. There is a nice assembly loop in the kernel to do that, see linux/drivers/scsi/mac_esp.c:MAC_ESP_PDMA_LOOP(). The start of the tran

[Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/block/Kconfig| 3 + hw/block/Makefile.objs | 1 + hw/block/swim.c | 421 include/hw/block/swim.h |

[Qemu-devel] [PATCH v9 2/9] dp8393x: manage big endian bus

This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau --- hw/net/dp8393x.c | 88 +++- 1 file ch

[Qemu-devel] [PATCH v9 4/9] hw/m68k: implement ADB bus support for via

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- hw/misc/mac_via.c | 190 ++ include/hw/misc/mac_via.h | 7 ++ 2 files changed, 197 insertion

[Qemu-devel] [PATCH v9 7/9] hw/m68k: add Nubus support for macfb video card

From: Mark Cave-Ayland Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/display/Kconfig | 1 + hw/display/macfb.c | 56 ++ include/hw/display/macfb.h | 21

[Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

I'm rebasing some of these patches for seven years now, too many years... if you want to test the machine, I'm sorry, it doesn't boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer, with: ... -M q800 \ -serial non

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

On Mon, 2019-09-09 at 11:45 -0400, Michael S. Tsirkin wrote: > On Mon, Sep 09, 2019 at 05:34:13PM +0200, Johannes Berg wrote: > > On Mon, 2019-09-09 at 17:26 +0200, Johannes Berg wrote: > > > Maybe instead we should just add a "VHOST_USER_REPLY_ERROR" bit (e.g. > > > bit 4 after NEED_REPLY). Qemu i

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

On Mon, Sep 09, 2019 at 05:34:13PM +0200, Johannes Berg wrote: > On Mon, 2019-09-09 at 17:26 +0200, Johannes Berg wrote: > > > > Maybe instead we should just add a "VHOST_USER_REPLY_ERROR" bit (e.g. > > bit 4 after NEED_REPLY). Qemu in vhost_user_read_header() validates that > > it received REPLY_

  1   2   3   >