Re: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation

2019-07-09 Thread Richard Henderson
On 7/5/19 6:04 PM, Alex Bennée wrote: > We never shipped the reference data in the source tree because it was > quite big (64M). As a result the only option is to generate it > locally. Although we have a rule to generate the reference file we > missed the dependency and location changes, probably

Re: [Qemu-devel] [PATCH] configure: remove obsoleted $sparc_cpu variable

2019-07-09 Thread Richard Henderson
On 7/10/19 1:43 AM, Carlo Marcelo Arenas Belón wrote: > 9b9c37c364 ("tcg-sparc: Assume v9 cpu always, i.e. force v8plus in > 32-bit mode.", 2012-09-21) removed the need for this variable and > most of the references to it, but this one. > > Remove defunct code, no effect or functionality change ex

Re: [Qemu-devel] [PATCH 3/3] Add dbus-vmstate object

2019-07-09 Thread Paolo Bonzini
On 08/07/19 09:24, Marc-André Lureau wrote: > + > +dstaddr = g_strsplit(g_test_dbus_get_bus_address(dstbus), ",", 2); > +dst_qemu_args = > +g_strdup_printf("-object dbus-vmstate,id=dv,addr=%s -incoming %s", > +dstaddr[0], uri); > + Stupid question: what does

Re: [Qemu-devel] [PATCH v0] ppc/spapr: Support reboot of secure pseries guest

2019-07-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190710060621.16430-1-bhar...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190710060621.16430-1-bhar...@linux.ibm.com Type: series Subject: [Qemu-devel] [PATCH v0] ppc/spapr

[Qemu-devel] [PATCH v0] ppc/spapr: Support reboot of secure pseries guest

2019-07-09 Thread Bharata B Rao
A pseries guest can be run as a secure guest on Ultravisor-enabled POWER platforms. When such a secure guest is reset, we need to release/reset a few resources both on ultravisor and hypervisor side. This is achieved by invoking this new ioctl KVM_PPC_SVM_OFF from the machine reset path. As part o

Re: [Qemu-devel] [PATCH for-4.1] pl031: Correctly migrate state when using -rtc clock=host

2019-07-09 Thread Paolo Bonzini
On 09/07/19 16:39, Peter Maydell wrote: > Reported-by: Russell King > Signed-off-by: Peter Maydell > --- > I think this is correct, and it makes the "rtc clock should > not stay still across a save/reload" work, but I feel like > there might be some subtlety I've missed here. Review > definitely

[Qemu-devel] [PATCH 0/2] migration/postcopy: cleanup function postcopy_chunk_hostpages_pass

2019-07-09 Thread Wei Yang
Here are two trivial function cleanup. BTW, I didn't test them since TPS == HPS. How could I setup a guest with TPS != HPS? Wei Yang (2): migration/postcopy: reduce one operation to calculate fixup_start_addr migration/postcopy: do_fixup is true when host_offset is non-zero migration/ram.c

[Qemu-devel] [PATCH 1/2] migration/postcopy: reduce one operation to calculate fixup_start_addr

2019-07-09 Thread Wei Yang
Use the same way for run_end to calculate run_start, which saves one operation. Signed-off-by: Wei Yang --- migration/ram.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 410e0f89fe..c4dc36e525 100644 --- a/migration/ram.c +

[Qemu-devel] [PATCH 2/2] migration/postcopy: do_fixup is true when host_offset is non-zero

2019-07-09 Thread Wei Yang
This means it is not necessary to spare an extra variable to hold this condition. Use host_offset directly is fine. Signed-off-by: Wei Yang --- migration/ram.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c4dc36e525..b0ca0059c4 1

Re: [Qemu-devel] [PATCH v4 04/18] qapi: add BitmapSyncMode enum

2019-07-09 Thread Markus Armbruster
John Snow writes: > Depending on what a user is trying to accomplish, there might be a few > bitmap cleanup actions that occur when an operation is finished that > could be useful. > > I am proposing three: > - NEVER: The bitmap is never synchronized against what was copied. > - ALWAYS: The bitma

Re: [Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommon

2019-07-09 Thread Markus Armbruster
John Snow writes: > On 7/9/19 7:25 PM, John Snow wrote: >> drive-backup and blockdev-backup have an awful lot of things in common >> that are the same. Let's fix that. >> >> I don't deduplicate 'target', because the semantics actually did change >> between each structure. Leave that one alone so

Re: [Qemu-devel] [PATCH 02/11] audio: basic support for multi backend audio

2019-07-09 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > Audio functions no longer access glob_audio_state, instead they get an > AudioState as a parameter. This is required in order to support > multiple backends. > > glob_audio_state is also gone, and replaced with a tailq so we can store > more than one states. > > Signed

Re: [Qemu-devel] [BUG] VM abort after migration

2019-07-09 Thread Jason Wang
On 2019/7/10 上午11:36, Longpeng (Mike) wrote: 在 2019/7/10 11:25, Jason Wang 写道: On 2019/7/8 下午5:47, Dr. David Alan Gilbert wrote: * longpeng (longpe...@huawei.com) wrote: Hi guys, We found a qemu core in our testing environment, the assertion 'assert(bus->irq_count[i] == 0)' in pcibus_reset()

Re: [Qemu-devel] [PATCH V2] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-09 Thread Jason Wang
On 2019/7/4 下午4:36, Zhang Chen wrote: From: Zhang Chen This patch to fix the origin "char *data" menory leak, code style issue and add necessary check here. Reported-by: Coverity (CID 1402785) Signed-off-by: Zhang Chen --- net/colo-compare.c | 28 +--- 1 file chan

Re: [Qemu-devel] [BUG] VM abort after migration

2019-07-09 Thread Longpeng (Mike)
在 2019/7/10 11:25, Jason Wang 写道: > > On 2019/7/8 下午5:47, Dr. David Alan Gilbert wrote: >> * longpeng (longpe...@huawei.com) wrote: >>> Hi guys, >>> >>> We found a qemu core in our testing environment, the assertion >>> 'assert(bus->irq_count[i] == 0)' in pcibus_reset() was triggered and >>> the b

Re: [Qemu-devel] [BUG] VM abort after migration

2019-07-09 Thread Jason Wang
On 2019/7/8 下午5:47, Dr. David Alan Gilbert wrote: * longpeng (longpe...@huawei.com) wrote: Hi guys, We found a qemu core in our testing environment, the assertion 'assert(bus->irq_count[i] == 0)' in pcibus_reset() was triggered and the bus->irq_count[i] is '-1'. Through analysis, it was happ

Re: [Qemu-devel] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-09 Thread Jason Dillaman
On Tue, Jul 9, 2019 at 11:32 AM Max Reitz wrote: > > On 09.07.19 15:09, Stefano Garzarella wrote: > > On Tue, Jul 09, 2019 at 08:55:19AM -0400, Jason Dillaman wrote: > >> On Tue, Jul 9, 2019 at 5:45 AM Max Reitz wrote: > >>> > >>> On 09.07.19 10:55, Max Reitz wrote: > On 09.07.19 05:08, Jaso

Re: [Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommon

2019-07-09 Thread John Snow
On 7/9/19 7:25 PM, John Snow wrote: > drive-backup and blockdev-backup have an awful lot of things in common > that are the same. Let's fix that. > > I don't deduplicate 'target', because the semantics actually did change > between each structure. Leave that one alone so it can be documented >

[Qemu-devel] [PATCH 3/8] iotests/257: Refactor backup helpers

2019-07-09 Thread John Snow
This test needs support for non-bitmap backups and missing or unspecified bitmap sync modes, so rewrite the helpers to be a little more generic. Signed-off-by: John Snow --- tests/qemu-iotests/257 | 46 + tests/qemu-iotests/257.out | 192 ++--- 2 file

[Qemu-devel] [PATCH 7/8] block/backup: support bitmap sync modes for non-bitmap backups

2019-07-09 Thread John Snow
Accept bitmaps and sync policies for the other backup modes. This allows us to do things like create a bitmap synced to a full backup without a transaction, or start a resumable backup process. Some combinations don't make sense, though: - NEVER policy combined with any non-BITMAP mode doesn't do

[Qemu-devel] [PATCH 8/8] iotests/257: test traditional sync modes

2019-07-09 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/257 | 31 + tests/qemu-iotests/257.out | 3089 2 files changed, 3120 insertions(+) diff --git a/tests/qemu-iotests/257 b/tests/qemu-iotests/257 index de8707cb19..8de1c4da19 100755 --- a/tests/qemu-iotests/

[Qemu-devel] [PATCH 2/8] iotests/257: add EmulatedBitmap class

2019-07-09 Thread John Snow
Represent a bitmap with an object that we can mark and clear bits in. This makes it easier to manage partial writes when we don't write a full group's worth of patterns before an error. Signed-off-by: John Snow --- tests/qemu-iotests/257 | 125 + 1 file ch

[Qemu-devel] [PATCH 1/8] iotests/257: add Pattern class

2019-07-09 Thread John Snow
Just kidding, this is easier to manage with a full class instead of a namedtuple. Signed-off-by: John Snow --- tests/qemu-iotests/257 | 58 +++--- 1 file changed, 32 insertions(+), 26 deletions(-) diff --git a/tests/qemu-iotests/257 b/tests/qemu-iotests/257 i

[Qemu-devel] [PATCH 5/8] iotests/257: test API failures

2019-07-09 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/257 | 69 +++ tests/qemu-iotests/257.out | 85 ++ 2 files changed, 154 insertions(+) diff --git a/tests/qemu-iotests/257 b/tests/qemu-iotests/257 index 2eb4f26c28..de8707cb19 10075

[Qemu-devel] [PATCH 0/8] bitmaps: allow bitmaps to be used with full and top

2019-07-09 Thread John Snow
Requires: <20190709232550.10724-1-js...@redhat.com> [PATCH v4 00/18] bitmaps: introduce 'bitmap' sync mode This follows the previous series which adds the 'bitmap' sync mode and uses it to add interactions with bitmaps to the 'full' and 'top' modes to blockdev-backup and drive-backup. Why? on-su

[Qemu-devel] [PATCH 6/8] block/backup: issue progress updates for skipped regions

2019-07-09 Thread John Snow
The way bitmap backups work is by starting at 75% if it needs to copy just 25% of the disk. The way sync=top currently works, however, is to start at 0% and then never update the progress if it doesn't copy a region. If it needs to copy 25% of the disk, we'll finish at 25%. Update the progress wh

[Qemu-devel] [PATCH 4/8] block/backup: hoist bitmap check into QMP interface

2019-07-09 Thread John Snow
This is nicer to do in the unified QMP interface that we have now, because it lets us use the right terminology back at the user. Signed-off-by: John Snow --- block/backup.c | 13 - blockdev.c | 10 ++ 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/block/

[Qemu-devel] [PATCH] configure: remove obsoleted $sparc_cpu variable

2019-07-09 Thread Carlo Marcelo Arenas Belón
9b9c37c364 ("tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode.", 2012-09-21) removed the need for this variable and most of the references to it, but this one. Remove defunct code, no effect or functionality change expected. Signed-off-by: Carlo Marcelo Arenas Belón --- configu

[Qemu-devel] [PATCH v4 17/18] iotests: add test 257 for bitmap-mode backups

2019-07-09 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/257 | 416 +++ tests/qemu-iotests/257.out | 2247 tests/qemu-iotests/group |1 + 3 files changed, 2664 insertions(+) create mode 100755 tests/qemu-iotests/257 create mode 100644 tests/qemu-iotest

[Qemu-devel] [PATCH v4 11/18] block/backup: upgrade copy_bitmap to BdrvDirtyBitmap

2019-07-09 Thread John Snow
This simplifies some interface matters; namely the initialization and (later) merging the manifest back into the sync_bitmap if it was provided. Signed-off-by: John Snow --- block/backup.c | 81 ++ 1 file changed, 42 insertions(+), 39 deletions(-)

[Qemu-devel] [PATCH v4 15/18] iotests: teach FilePath to produce multiple paths

2019-07-09 Thread John Snow
Use "FilePaths" instead of "FilePath" to request multiple files be cleaned up after we leave that object's scope. This is not crucial; but it saves a little typing. Signed-off-by: John Snow Reviewed-by: Max Reitz --- tests/qemu-iotests/iotests.py | 34 -- 1 file

Re: [Qemu-devel] [PATCH v2 0/5] tests/docker: add podman support

2019-07-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190709194330.837-1-marcandre.lur...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/ba

[Qemu-devel] [PATCH v4 12/18] block/backup: add 'always' bitmap sync policy

2019-07-09 Thread John Snow
This adds an "always" policy for bitmap synchronization. Regardless of if the job succeeds or fails, the bitmap is *always* synchronized. This means that for backups that fail part-way through, the bitmap retains a record of which sectors need to be copied out to accomplish a new backup using the o

[Qemu-devel] [PATCH v4 18/18] block/backup: loosen restriction on readonly bitmaps

2019-07-09 Thread John Snow
With the "never" sync policy, we actually can utilize readonly bitmaps now. Loosen the check at the QMP level, and tighten it based on provided arguments down at the job creation level instead. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block/backup.c | 6 ++ blockdev.c | 2 +-

[Qemu-devel] [PATCH v4 03/18] blockdev-backup: utilize do_backup_common

2019-07-09 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz --- blockdev.c | 65 +- 1 file changed, 6 insertions(+), 59 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5bc8ecd087..77365d8166 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3624,78 +36

[Qemu-devel] [PATCH v4 02/18] drive-backup: create do_backup_common

2019-07-09 Thread John Snow
Create a common core that comprises the actual meat of what the backup API boundary needs to do, and then switch drive-backup to use it. Signed-off-by: John Snow Reviewed-by: Max Reitz --- blockdev.c | 122 + 1 file changed, 67 insertions(+),

[Qemu-devel] [PATCH v4 09/18] block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal

2019-07-09 Thread John Snow
I'm surprised it didn't come up sooner, but sometimes we have a +busy bitmap as a source. This is dangerous from the QMP API, but if we are the owner that marked the bitmap busy, it's safe to merge it using it as a read only source. It is not safe in the general case to allow users to read from in

[Qemu-devel] [PATCH v4 04/18] qapi: add BitmapSyncMode enum

2019-07-09 Thread John Snow
Depending on what a user is trying to accomplish, there might be a few bitmap cleanup actions that occur when an operation is finished that could be useful. I am proposing three: - NEVER: The bitmap is never synchronized against what was copied. - ALWAYS: The bitmap is always synchronized, even on

[Qemu-devel] [PATCH v4 05/18] block/backup: Add mirror sync mode 'bitmap'

2019-07-09 Thread John Snow
We don't need or want a new sync mode for simple differences in semantics. Create a new mode simply named "BITMAP" that is designed to make use of the new Bitmap Sync Mode field. Because the only bitmap sync mode is 'on-success', this adds no new functionality to the backup job (yet). The old inc

[Qemu-devel] [PATCH v4 16/18] iotests: Add virtio-scsi device helper

2019-07-09 Thread John Snow
Seems that it comes up enough. Signed-off-by: John Snow Reviewed-by: Max Reitz --- tests/qemu-iotests/040| 6 +- tests/qemu-iotests/093| 6 ++ tests/qemu-iotests/139| 7 ++- tests/qemu-iotests/238| 5 + tests/qemu-iotests/iotests.py | 4 5 fi

[Qemu-devel] [PATCH v4 13/18] iotests: add testing shim for script-style python tests

2019-07-09 Thread John Snow
Because the new-style python tests don't use the iotests.main() test launcher, we don't turn on the debugger logging for these scripts when invoked via ./check -d. Refactor the launcher shim into new and old style shims so that they share environmental configuration. Two cleanup notes: debug was

[Qemu-devel] [PATCH v4 06/18] block/backup: add 'never' policy to bitmap sync mode

2019-07-09 Thread John Snow
This adds a "never" policy for bitmap synchronization. Regardless of if the job succeeds or fails, we never update the bitmap. This can be used to perform differential backups, or simply to avoid the job modifying a bitmap. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block/backup.c

[Qemu-devel] [PATCH v4 10/18] block/dirty-bitmap: add bdrv_dirty_bitmap_get

2019-07-09 Thread John Snow
Add a public interface for get. While we're at it, rename "bdrv_get_dirty_bitmap_locked" to "bdrv_dirty_bitmap_get_locked". (There are more functions to rename to the bdrv_dirty_bitmap_VERB form, but they will wait until the conclusion of this series.) Signed-off-by: John Snow Reviewed-by: Max R

[Qemu-devel] [PATCH v4 14/18] iotests: teach run_job to cancel pending jobs

2019-07-09 Thread John Snow
run_job can cancel pending jobs to simulate failure. This lets us use the pending callback to issue test commands while the job is open, but then still have the job fail in the end. Signed-off-by: John Snow Reviewed-by: Max Reitz --- tests/qemu-iotests/iotests.py | 22 -- 1

[Qemu-devel] [PATCH v4 01/18] qapi/block-core: Introduce BackupCommon

2019-07-09 Thread John Snow
drive-backup and blockdev-backup have an awful lot of things in common that are the same. Let's fix that. I don't deduplicate 'target', because the semantics actually did change between each structure. Leave that one alone so it can be documented separately. Signed-off-by: John Snow Reviewed-by:

[Qemu-devel] [PATCH v4 00/18] bitmaps: introduce 'bitmap' sync mode

2019-07-09 Thread John Snow
This series adds a new "BITMAP" sync mode that is meant to replace the existing "INCREMENTAL" sync mode. This mode can have its behavior modified by issuing any of three bitmap sync modes, passed as arguments to the job. The three bitmap sync modes are: - ON-SUCCESS: This is an alias for the old

[Qemu-devel] [PATCH v4 07/18] hbitmap: Fix merge when b is empty, and result is not an alias of a

2019-07-09 Thread John Snow
Nobody calls the function like this currently, but we neither prohibit or cope with this behavior. I decided to make the function cope with it. Signed-off-by: John Snow Reviewed-by: Max Reitz --- util/hbitmap.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/u

[Qemu-devel] [PATCH v4 08/18] hbitmap: enable merging across granularities

2019-07-09 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz --- util/hbitmap.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/util/hbitmap.c b/util/hbitmap.c index 3b6acae42b..306bc4876d 100644 --- a/util/hbitmap.c +++ b/util/hbitmap.c @@ -777,7 +777

Re: [Qemu-devel] [PATCH v3 17/18] iotests: add test 257 for bitmap-mode backups

2019-07-09 Thread John Snow
On 7/9/19 2:49 PM, Max Reitz wrote: > On 05.07.19 22:16, John Snow wrote: >> Signed-off-by: John Snow >> --- >> tests/qemu-iotests/257 | 409 +++ >> tests/qemu-iotests/257.out | 2199 >> tests/qemu-iotests/group |1 + >> 3 files changed, 2609

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations

2019-07-09 Thread Collin Walling
On 7/8/19 9:23 AM, Christian Borntraeger wrote: On 08.07.19 14:54, Cornelia Huck wrote: According to the comment, the bits are supposed to accumulate. Reported-by: Stefan Weil Fixes: 5d1abf234462 ("s390x/pci: enforce zPCI state checking") Signed-off-by: Cornelia Huck This patch does not c

Re: [Qemu-devel] [PATCH 00/11] Multiple simultaneous audio backends

2019-07-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1562695780.git.dirty.ice...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash ma

Re: [Qemu-devel] [PATCH 00/11] Multiple simultaneous audio backends

2019-07-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1562695780.git.dirty.ice...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1562695780.git.dirty.ice...@gmail.com Subject: [Qemu-devel] [PATCH 00/11] Multiple

Re: [Qemu-devel] Should memory hotplug work with vhost-user backends?

2019-07-09 Thread Raphael Norwitz
On Jul 3, 2019, at 11:57 AM, Michael S. Tsirkin mailto:m...@redhat.com>> wrote: On Tue, Jul 02, 2019 at 10:08:54PM +, Raphael Norwitz wrote: For background I am trying to work around a ram slot limit imposed by the vhost-user protocol. We are having trouble reconciling the comment here: htt

Re: [Qemu-devel] [PATCH v24 0/7] QEMU AVR 8 bit cores

2019-07-09 Thread Michael Rolnik
Hi Philippe. I am working on it. On Tue, Jul 2, 2019 at 6:55 PM Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 6/28/19 2:01 PM, Michael Rolnik wrote: > > This series of patches adds 8bit AVR cores to QEMU. > > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully > tested y

[Qemu-devel] [PATCH v25 4/7] target/avr: Add instruction translation

2019-07-09 Thread Michael Rolnik
This includes: - TCG translations for each instruction Signed-off-by: Michael Rolnik --- target/avr/translate.c | 2888 1 file changed, 2888 insertions(+) create mode 100644 target/avr/translate.c diff --git a/target/avr/translate.c b/target/avr/transla

[Qemu-devel] [PATCH v25 6/7] target/avr: Add example board configuration

2019-07-09 Thread Michael Rolnik
From: Sarah Harris A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. Signed-off-by: Michael Rolnik --- hw/Kconfig | 1 + hw/avr/Kconf

[Qemu-devel] [PATCH v25 5/7] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-07-09 Thread Michael Rolnik
From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins). Signed-o

[Qemu-devel] [PATCH v25 1/7] target/avr: Add outward facing interfaces and core CPU logic

2019-07-09 Thread Michael Rolnik
From: Sarah Harris This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Signed-off-by: Michael Rolnik --- gdb-xml/avr-cpu.xml| 49 target/avr/cpu-param.h | 37 +++ target/avr/cpu.c | 584 +++

[Qemu-devel] [PATCH v25 2/7] target/avr: Add instruction helpers

2019-07-09 Thread Michael Rolnik
From: Sarah Harris Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peripherals to generate wake

[Qemu-devel] [PATCH v25 7/7] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

2019-07-09 Thread Michael Rolnik
From: Sarah Harris Signed-off-by: Michael Rolnik --- MAINTAINERS | 6 ++ arch_init.c | 2 ++ configure | 7 +++ default-configs/avr-softmmu.mak | 5 + hw/avr/sample.c | 2 +- include/disas/dis-asm.h

[Qemu-devel] [PATCH v25 0/7] QEMU AVR 8 bit cores

2019-07-09 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support yet

[Qemu-devel] [PATCH v25 3/7] target/avr: Add instruction decoding

2019-07-09 Thread Michael Rolnik
This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik --- target/avr/insn.decode | 175 + 1 file changed, 175 insertions(+) create mode 100644 target/avr/insn.decode diff --git a/target/a

Re: [Qemu-devel] [PATCH v2 5/5] tcg: Release mmap_lock on translation fault

2019-07-09 Thread Alex Bennée
Richard Henderson writes: > Turn helper_retaddr into a multi-state flag that may now also > indicate when we're performing a read on behalf of the translator. > In this case, release the mmap_lock before the longjmp back to > the main cpu loop, and thereby avoid a failing assert therein. > > Fi

[Qemu-devel] [PATCH 2/4] raw: Recognize zoned backing devices

2019-07-09 Thread Dmitry Fomichev
The purpose of this patch is to recognize a zoned block device (ZBD) when it is opened as a raw file. The new code initializes the zoned model propery introduced by the previous commit. This commit is Linux-specific and in essence it checks the Zoned Block Device Model (None/Host-managed/Host-awar

[Qemu-devel] [PATCH 4/4] hw/scsi: Don't realize zoned block devices for virtio-scsi legacy drivers

2019-07-09 Thread Dmitry Fomichev
From: Shin'ichiro Kawasaki Prevent scsi-hd and scsi-disk drivers from attaching a zoned block device because it will appear as a regular block device at the guest and will most certainly cause problems. The functionality to support ZBDs is not planned for scsi-hd and scsi-disk legacy drivers. It

[Qemu-devel] [PATCH 1/4] block: Add zoned device model property

2019-07-09 Thread Dmitry Fomichev
This commit adds Zoned Device Model as defined in T10 ZBC and T13 ZAC standards, along with some useful accessor functions. Since the default value of zero in the zoned model field corresponds to a regular (non-zoned) block device, there is no functionality change with this commit. Signed-off-by:

[Qemu-devel] [PATCH 3/4] virtio-blk: Don't realize zoned block devices

2019-07-09 Thread Dmitry Fomichev
Prevent virtio-blk code from attaching a zoned block device because it will otherwise appear as a reqular block device at the guest and that will most certainly cause problems. The functionality to support ZBDs via virtio-blk should be pretty useful and there are some attempts underway to get it i

[Qemu-devel] [PATCH 0/4] virtio: handle zoned backing devices

2019-07-09 Thread Dmitry Fomichev
Currently, attaching zoned block devices (i.e. storage devices compliant to ZAC/ZBC standards) using several virtio methods doesn't work - the zoned devices appear as regular block devices at the guest. This may cause unexpected i/o errors and, potentially, some data corruption. To be more precise

[Qemu-devel] [PATCH v2 1/5] docker.py: add podman support

2019-07-09 Thread Marc-André Lureau
Add a --engine option to select either docker, podman or auto. Among other advantages, podman allows to run rootless & daemonless containers, fortunately sharing compatible CLI with docker. Signed-off-by: Marc-André Lureau --- tests/docker/docker.py | 43 +---

[Qemu-devel] [PATCH v2 4/5] test-char: skip tcp tests if ipv4 check failed

2019-07-09 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- tests/Makefile.include | 2 +- tests/test-char.c | 17 + 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index a983dd32da..2bddebaf4b 100644 --- a/tests/Makefile.include +++

[Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support

2019-07-09 Thread Marc-André Lureau
Allow to specify the container engine to run with ENGINE variable. By default, ENGINE=auto and will select either podman or docker. With current podman, we have to use a uidmap trick in order to be able to rw-share the ccache directory with the container user. With a user 1000, the default mappi

[Qemu-devel] [PATCH v2 5/5] test: skip tests if socket_check_protocol_support() failed

2019-07-09 Thread Marc-André Lureau
Skip the tests if socket_check_protocol_support() failed, but do run g_test_run() to keep TAP harness happy. Signed-off-by: Marc-André Lureau --- tests/test-char.c | 4 +++- tests/test-io-channel-socket.c | 4 +++- tests/test-util-sockets.c | 4 +++- 3 files changed, 9 insertio

[Qemu-devel] [PATCH v2 0/5] tests/docker: add podman support

2019-07-09 Thread Marc-André Lureau
Hi, podman allows to run containers in a similar fashion as docker, but without daemon or root privileges. Thank you podman! There is a weird issue with getaddrinfo(), that I reported upstream https://github.com/containers/libpod/issues/3535. For now, it is worked around with extra socket_check_p

[Qemu-devel] [PATCH v2 3/5] tests: specify the address family when checking bind

2019-07-09 Thread Marc-André Lureau
getaddrinfo() may succeed with PF_UNSPEC, but fail when more specific. (this allows to skip some tests that would fail under podman) Signed-off-by: Marc-André Lureau --- tests/socket-helpers.c | 17 + tests/socket-helpers.h | 11 --- 2 files changed, 13 insertions(+), 15

Re: [Qemu-devel] RFC: Why does target/m68k RTE insn. use gen_exception

2019-07-09 Thread Richard Henderson
On 7/9/19 6:58 PM, Lucien Murray-Pitts wrote: > Any suggestions on how to obtain pc_next from the "m68k_cpu_do_interrupt( > CPUState *cs)" ? I did have a suggestion. It was fairly detailed. https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg06522.html r~

[Qemu-devel] [ANNOUNCE] QEMU 4.1.0-rc0 is now available

2019-07-09 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 4.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.1.0-rc0.tar.xz http://downl

Re: [Qemu-devel] [PATCH v3 17/18] iotests: add test 257 for bitmap-mode backups

2019-07-09 Thread Max Reitz
On 05.07.19 22:16, John Snow wrote: > Signed-off-by: John Snow > --- > tests/qemu-iotests/257 | 409 +++ > tests/qemu-iotests/257.out | 2199 > tests/qemu-iotests/group |1 + > 3 files changed, 2609 insertions(+) > create mode 100755 tests/qemu

Re: [Qemu-devel] [PATCH v3 12/18] block/backup: add 'always' bitmap sync policy

2019-07-09 Thread Max Reitz
On 05.07.19 22:16, John Snow wrote: > This adds an "always" policy for bitmap synchronization. Regardless of if > the job succeeds or fails, the bitmap is *always* synchronized. This means > that for backups that fail part-way through, the bitmap retains a record of > which sectors need to be copie

Re: [Qemu-devel] [PATCH v3 2/9] hw/block/pflash_cfi01: Use the correct READ_ARRAY value

2019-07-09 Thread Philippe Mathieu-Daudé
On 7/9/19 7:10 PM, Dr. David Alan Gilbert wrote: > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: >> Hi David, >> >> On 7/9/19 12:30 PM, Dr. David Alan Gilbert wrote: >>> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: In the "Read Array Flowchart" the command has a value of 0xFF. >>>

Re: [Qemu-devel] [PATCH v3 05/18] block/backup: Add mirror sync mode 'bitmap'

2019-07-09 Thread Max Reitz
On 05.07.19 22:16, John Snow wrote: > We don't need or want a new sync mode for simple differences in > semantics. Create a new mode simply named "BITMAP" that is designed to > make use of the new Bitmap Sync Mode field. > > Because the only bitmap sync mode is 'on-success', this adds no new > fu

[Qemu-devel] [PATCH 07/11] audio: remove audio_MIN, audio_MAX

2019-07-09 Thread Kővágó, Zoltán
There's already a MIN and MAX macro in include/qemu/osdep.h, use them instead. Signed-off-by: Kővágó, Zoltán --- audio/audio.h | 17 - audio/alsaaudio.c | 6 +++--- audio/audio.c | 20 ++-- audio/coreaudio.c | 2 +- audio/

[Qemu-devel] [PATCH 11/11] audio: use size_t where makes sense

2019-07-09 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.h | 4 +- audio/audio_int.h | 26 +++ audio/audio_template.h | 14 ++-- audio/mixeng.h | 9 +-- audio/rate_template.h | 2 +- include/sysemu/replay.h | 4 +- audio/alsaaudio.c | 26 +++ audio/audio.

[Qemu-devel] [PATCH 02/11] audio: basic support for multi backend audio

2019-07-09 Thread Kővágó, Zoltán
Audio functions no longer access glob_audio_state, instead they get an AudioState as a parameter. This is required in order to support multiple backends. glob_audio_state is also gone, and replaced with a tailq so we can store more than one states. Signed-off-by: Kővágó, Zoltán --- audio/audio

[Qemu-devel] [PATCH] qdev: Collect HMP handlers command handlers in qdev-monitor.c

2019-07-09 Thread Markus Armbruster
Move hmp_device_add(), hmp_device_del() from monitor/hmp-cmds.c to qdev-monitor.c, where they are covered by MAINTAINERS section "QOM", just like qapi/qdev.json. hmp_info_qtree() and hmp_info_qdm() are already there. Signed-off-by: Markus Armbruster --- This is a follow-up to my "Move QOM, qdev,

[Qemu-devel] [PATCH 04/11] audio: audiodev= parameters no longer optional when -audiodev present

2019-07-09 Thread Kővágó, Zoltán
This means you should probably stop using -soundhw (as it doesn't allow you to specify any options) and add the device manually with -device. The exception is pcspk, it's currently not possible to manually add it. To use it with audiodev, use something like this: -audiodev id=foo,... -global i

[Qemu-devel] [PATCH 03/11] audio: add audiodev properties to frontends

2019-07-09 Thread Kővágó, Zoltán
Finally add audiodev= options to audio frontends so users can specify which backend to use when multiple backends exist. Not specifying an audiodev= option currently causes the first audiodev to be used, this is fixed in the next commit. Example usage: -audiodev pa,id=foo -device AC97,audiodev=fo

[Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes

2019-07-09 Thread Richard Henderson
The aarch64 argument ordering for the operands is big-endian, whereas the tcg argument ordering is little-endian. Use REG0 so that we honor the rZ constraints. Fixes: 464c2969d5d Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 2 +- 1 file changed

[Qemu-devel] [PATCH 01/11] audio: reduce glob_audio_state usage

2019-07-09 Thread Kővágó, Zoltán
Remove glob_audio_state from functions, where possible without breaking the API. This means that most static functions in audio.c now take an AudioState pointer instead of implicitly using glob_audio_state. Also included a pointer in SWVoice*, HWVoice* structs, so that functions dealing them can

[Qemu-devel] [PATCH 10/11] audio: remove read and write pcm_ops

2019-07-09 Thread Kővágó, Zoltán
They just called audio_pcm_sw_read/write anyway, so it makes no sense to have them too. (The noaudio's read is the only exception, but it should work with the generic code too.) Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h | 5 - audio/alsaaudio.c | 12 audio/audio.

[Qemu-devel] [PATCH 05/11] paaudio: do not move stream when sink/source name is specified

2019-07-09 Thread Kővágó, Zoltán
Unless we disable stream moving, pulseaudio can easily move the stream on connect, effectively ignoring the source/sink specified by the user. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/audio/paaudio.c b/audio/paaudio.c index cc3a34

[Qemu-devel] [PATCH 06/11] paaudio: properly disconnect streams in fini_*

2019-07-09 Thread Kővágó, Zoltán
Currently this needs a workaround due to bug #247 in pulseaudio. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 24d98b344a..490bcd770e 100644 --- a/audio/paau

[Qemu-devel] [PATCH 08/11] audio: do not run each backend in audio_run

2019-07-09 Thread Kővágó, Zoltán
audio_run is called manually by alsa and oss backends when polling. In this case only the requesting backend should be run, not all of them. Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h | 2 +- audio/alsaaudio.c | 7 +-- audio/audio.c | 14 +- audio/ossaudio.c | 12

[Qemu-devel] [PATCH 09/11] paaudio: fix playback glitches

2019-07-09 Thread Kővágó, Zoltán
Pulseaudio normally assumes that when the server wants it, the client can generate the audio samples and send it right away. Unfortunately this is not the case with QEMU -- it's up to the emulated system when does it generate the samples. Buffering the samples and sending them from a background t

Re: [Qemu-devel] [PATCH 1/2] target/arm: Use extract2 for EXTR

2019-07-09 Thread Richard Henderson
On 7/9/19 6:40 PM, Peter Maydell wrote: > On Tue, 14 May 2019 at 02:11, Richard Henderson > wrote: >> >> This is, after all, how we implement extract2 in tcg/aarch64. >> >> Reviewed-by: Peter Maydell >> Signed-off-by: Richard Henderson >> --- >> target/arm/translate-a64.c | 38 +

[Qemu-devel] [PATCH 00/11] Multiple simultaneous audio backends

2019-07-09 Thread Kővágó, Zoltán
Hello, This is my next set of audio patches. This series makes it possible to use multiple audio backends in a single qemu instance, and contains a few random cleanup/fix patches. Regards, Zoltan Kővágó, Zoltán (11): audio: reduce glob_audio_state usage audio: basic support for multi backend

Re: [Qemu-devel] [PATCH v3 06/18] block/backup: add 'never' policy to bitmap sync mode

2019-07-09 Thread Max Reitz
On 05.07.19 22:16, John Snow wrote: > This adds a "never" policy for bitmap synchronization. Regardless of if > the job succeeds or fails, we never update the bitmap. This can be used > to perform differential backups, or simply to avoid the job modifying a > bitmap. > > Signed-off-by: John Snow

Re: [Qemu-devel] [PATCH v3 04/18] qapi: add BitmapSyncMode enum

2019-07-09 Thread Max Reitz
On 05.07.19 22:16, John Snow wrote: > Depending on what a user is trying to accomplish, there might be a few > bitmap cleanup actions that occur when an operation is finished that > could be useful. > > I am proposing three: > - NEVER: The bitmap is never synchronized against what was copied. > -

Re: [Qemu-devel] [PATCH v3 03/18] blockdev-backup: utilize do_backup_common

2019-07-09 Thread Max Reitz
On 05.07.19 22:16, John Snow wrote: > Signed-off-by: John Snow > --- > blockdev.c | 65 +- > 1 file changed, 6 insertions(+), 59 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3 02/18] drive-backup: create do_backup_common

2019-07-09 Thread Max Reitz
On 05.07.19 22:16, John Snow wrote: > Create a common core that comprises the actual meat of what the backup API > boundary needs to do, and then switch drive-backup to use it. > > Signed-off-by: John Snow > --- > blockdev.c | 122 + > 1 file c

Re: [Qemu-devel] [PATCH for-4.1] pl031: Correctly migrate state when using -rtc clock=host

2019-07-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190709143912.28905-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190709143912.28905-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH for-4.1] pl031: Corr

  1   2   3   >