[Qemu-devel] [Bug 1529226] Re: qemu-i386-user on 32-bit Linux: uncaught target signal 11

2019-06-15 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1529226 Title: qemu-i386-u

[Qemu-devel] [Bug 1574572] Re: config 20 sriov direct bond ports,vm create failed.

2019-06-15 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1574572 Title: config 20 s

Re: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.06.2019 um 11:06 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > monitor.c mixes a lot of different things in a single file: The core >> > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the >> > implementation of several HMP and QM

[Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-15 Thread Eduardo Habkost
The current default value for hv-spinlocks is 0x (meaning "never retry"). However, the value is stored as a signed integer, making the getter of the hv-spinlocks QOM property return -1 instead of 0x. Fix this by changing the type of X86CPU::hyperv_spinlock_attempts to uint32_t. T

Re: [Qemu-devel] [PATCH] block/replication.c: Fix crash issue after failover

2019-06-15 Thread Zhang, Chen
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Friday, June 14, 2019 6:18 PM > To: Zhang, Chen > Cc: Xie Changlong ; Max Reitz > ; qemu-block ; qemu-dev > ; Zhang Chen ; > vsement...@virtuozzo.com > Subject: Re: [PATCH] block/replication.c: Fix crash issue afte

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: do not advertise support for unsupported arbitration mechanism

2019-06-15 Thread Maxim Levitsky
On Fri, 2019-06-14 at 22:39 +0200, Max Reitz wrote: > On 06.06.19 11:25, Klaus Birkelund Jensen wrote: > > The device mistakenly reports that the Weighted Round Robin with Urgent > > Priority Class arbitration mechanism is supported. > > > > It is not. > > I believe you based on the fact that the

[Qemu-devel] [NOTFORMERGE PATCH v2 23/23] Missing symbols when building with --disable-tcg

2019-06-15 Thread Philippe Mathieu-Daudé
While it might be normal to disable PSCI on KVM, I doubt the VFP helpers are correct ;) Anyway this allow to link the binary and run a KVM guest. Tested using: $ make pc-bios/edk2-aarch64-code.fd $ dd if=/dev/zero of=flash1.img bs=1M count=64 $ aarch64-softmmu/qemu-system-aarch64 \ -no

[Qemu-devel] [PATCH v2 19/23] target/arm: Move watchpoints APIs to helper.c

2019-06-15 Thread Philippe Mathieu-Daudé
From: Samuel Ortiz Here again, those APIs are not TCG dependent and can move to the always built helper.c. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford [PMD: Rebased] Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c| 213 +

[Qemu-devel] [PATCH v2 16/23] target/arm: Make arm_deliver_fault() static

2019-06-15 Thread Philippe Mathieu-Daudé
This function is now only called within op_helper.c. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/internals.h | 3 --- target/arm/op_helper.c | 5 +++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 37ca493635..06e676

[Qemu-devel] [PATCH v2 21/23] target/arm: Do not build TCG objects when TCG is off

2019-06-15 Thread Philippe Mathieu-Daudé
From: Samuel Ortiz We can now safely turn all TCG dependent build off when CONFIG_TCG is off. This allows building ARM binaries with --disable-tcg. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford [PMD: Rebased] Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v2 17/23] target/arm: Fix coding style issues

2019-06-15 Thread Philippe Mathieu-Daudé
Since we'll move this code around, fix its style first. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/translate.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index c274c8b460..d0ab3e27e6 100644 --- a/targe

[Qemu-devel] [PATCH v2 18/23] target/arm: Move CPU state dumping routines to helper.c

2019-06-15 Thread Philippe Mathieu-Daudé
From: Samuel Ortiz They're not TCG specific and should be living the generic helper file instead. Signed-off-by: Samuel Ortiz Reviewed-by: Robert Bradford [PMD: Rebased] Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c| 214 + target/a

[Qemu-devel] [PATCH v2 15/23] target/arm: Make ARM TLB filling routine static

2019-06-15 Thread Philippe Mathieu-Daudé
From: Samuel Ortiz It's only used in op_helper.c, it does not need to be exported and moreover it should only be build when TCG is enabled. Signed-off-by: Samuel Ortiz [PMD: Rebased] Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c| 53 ---

[Qemu-devel] [PATCH v2 14/23] target/arm: Move the DC ZVA helper into op_helper

2019-06-15 Thread Philippe Mathieu-Daudé
From: Samuel Ortiz Those helpers are a software implementation of the ARM v8 memory zeroing op code. They should be moved to the op helper file, which is going to eventually be built only when TCG is enabled. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Robert B

[Qemu-devel] [RFC PATCH v2 22/23] target/arm: Restrict semi-hosting to TCG

2019-06-15 Thread Philippe Mathieu-Daudé
Per Peter Maydell: semihosting hooks either SVC or HLT instructions, and inside KVM both of those go to EL1, ie to the guest, and can't be trapped to KVM. Let check_for_semihosting() return False when not running on TCG. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c | 8 +

[Qemu-devel] [PATCH v2 07/23] target/arm: Declare some function publicly

2019-06-15 Thread Philippe Mathieu-Daudé
In few commits we will split the v7-M functions from this file. Some function will be called out of helper.c. Declare them in the "internals.h" header. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c| 69 +- target/arm/internals.h | 45 ++

[Qemu-devel] [PATCH v2 10/23] target/arm: Move the v7-M Security State helpers to v7m_helper

2019-06-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c | 73 - target/arm/v7m_helper.c | 73 + 2 files changed, 73 insertions(+), 73 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c inde

[Qemu-devel] [PATCH v2 06/23] target/arm: Fix multiline comment syntax

2019-06-15 Thread Philippe Mathieu-Daudé
Since commit 8c06fbdf36b checkpatch.pl enforce a new multiline comment syntax. Since we'll move this code around, fix its style first. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c| 213 +++-- target/arm/op_helper.c | 27 -- 2 files ch

[Qemu-devel] [PATCH v2 20/23] target/arm: Define TCG dependent functions when TCG is enabled

2019-06-15 Thread Philippe Mathieu-Daudé
From: Samuel Ortiz do_interrupt, do_unaligned_access, do_transaction_failed and debug_excp are only relevant in the TCG context, so we should not define them when TCG is disabled. Signed-off-by: Samuel Ortiz Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford [PMD: Rebased] Signe

[Qemu-devel] [PATCH v2 11/23] target/arm: Declare v7m_cpacr_pass() publicly

2019-06-15 Thread Philippe Mathieu-Daudé
In the next commit we will move exception handling routines to v7m_helper, so this function will be called from 2 different files. Declare it inlined in the "internals.h" header. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c| 19 --- target/arm/internals.h | 2

[Qemu-devel] [PATCH v2 09/23] target/arm: Move code around

2019-06-15 Thread Philippe Mathieu-Daudé
To ease the review of the next commit, move the write_v7m_exception() function around. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/target/arm/helper.c b/target/arm/hel

[Qemu-devel] [PATCH v2 08/23] target/arm: Move all v7m insn helpers into their own file

2019-06-15 Thread Philippe Mathieu-Daudé
From: Samuel Ortiz In preparation for supporting TCG disablement on ARM, we move most of TCG related v7m helpers and APIs into their own file. Signed-off-by: Samuel Ortiz [PMD: Patch rewritten] Signed-off-by: Philippe Mathieu-Daudé --- Is there a way to not use $CONFIG_USER_ONLY? target/arm/

[Qemu-devel] [PATCH v2 05/23] target/arm: Add copyright boilerplate

2019-06-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Robert Bradford Reviewed-by: Samuel Ortiz --- target/arm/helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index df4276f5f6..d3f3cb57d5 100644 --- a/target/arm/helper.c +++ b/target/ar

[Qemu-devel] [PATCH v2 03/23] target/arm: Makefile cleanup (KVM)

2019-06-15 Thread Philippe Mathieu-Daudé
Group KVM objects together. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/Makefile.objs | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target/arm/Makefile.objs b/target/arm/Makefile.objs index 3269dda613..626e340f55 100644 --- a/target/arm/Makefile.objs +++ b

[Qemu-devel] [PATCH v2 04/23] target/arm: Makefile cleanup (softmmu)

2019-06-15 Thread Philippe Mathieu-Daudé
Group SOFTMMU objects together. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/Makefile.objs | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/Makefile.objs b/target/arm/Makefile.objs index 626e340f55..72b42f825f 100644 --- a/target/arm/Makefile.objs ++

[Qemu-devel] [PATCH v2 13/23] target/arm: Make the v7-M Security State routines

2019-06-15 Thread Philippe Mathieu-Daudé
The Security State helpers are now only called within v7m_helper.c. Remove them from "internals.h". Signed-off-by: Philippe Mathieu-Daudé --- target/arm/internals.h | 8 target/arm/v7m_helper.c | 10 +- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/target/arm

[Qemu-devel] [PATCH v2 02/23] target/arm: Makefile cleanup (ARM)

2019-06-15 Thread Philippe Mathieu-Daudé
Group ARM objects together, TCG related ones at the bottom. This will help when restricting TCG-only objects. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/Makefile.objs | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target/arm/Makefile.objs b/target/arm/Make

[Qemu-devel] [PATCH v2 01/23] target/arm: Makefile cleanup (Aarch64)

2019-06-15 Thread Philippe Mathieu-Daudé
Group Aarch64 objects together, TCG related ones at the bottom. This will help when restricting TCG-only objects. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/Makefile.objs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/arm/Makefile.objs b/target/arm/Make

[Qemu-devel] [PATCH v2 00/23] Support disabling TCG on ARM

2019-06-15 Thread Philippe Mathieu-Daudé
Paolo motived me to salvage this (other!) previous series fromi Samuel Ortiz (NEMU project). v1 cover from Samuel [1]: This patchset allows for building and running ARM targets with TCG disabled. It splits the target/arm/helper.c file into logical TCG and non TCG dependent files so that one

[Qemu-devel] [PATCH] fix microphone lag with PA

2019-06-15 Thread Martin Schrodt
Several people have reported to have bag microphone lag with the PA backend. While I cannot reproduce the problem here, it seems that their PA somehow decides to buffer the microphone input for way too long, causing this delay. This patch sets an upper limit to the amount of data PA should hold. Th

Re: [Qemu-devel] [RFC PATCH 0/2] target: Build with CONFIG_SEMIHOSTING disabled

2019-06-15 Thread Philippe Mathieu-Daudé
On 6/3/19 10:11 AM, Paolo Bonzini wrote: > On 31/05/19 18:54, Miroslav Rezanina wrote: >> What about CONFIG_ARM_VIRT - can we use it to introduce dependency on >> CONFIG_SEMIHOSTING or is there valid scenario of qemu build with >> CONFIG_ARM_VIRT >> enabled and CONFIG_SEMIHOSTING disabled? > > If

[Qemu-devel] [PATCH] target/ppc: fix compile error in kvmppc_define_rtas_kernel_token()

2019-06-15 Thread Cédric Le Goater
gcc9 reports : In file included from /usr/include/string.h:494, from ./include/qemu/osdep.h:101, from ./target/ppc/kvm.c:17: In function ‘strncpy’, inlined from ‘kvmppc_define_rtas_kernel_token’ at ./target/ppc/kvm.c:2648:5: /usr/include/bits/string_fortified.