Re: [Qemu-devel] [PATCH v2 1/2] virtio-input-host-pci: cleanup types

2019-05-11 Thread Michael S. Tsirkin
On Fri, May 10, 2019 at 12:51:36PM +0200, Gerd Hoffmann wrote: > virtio input is virtio-1.0 only, so we don't need the -transitional and > -non-transitional variants. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin I assume you are merging this? > --- > hw/virtio/virtio-inpu

Re: [Qemu-devel] [PULL v2 00/27] tcg: Add CPUClass::tlb_fill

2019-05-11 Thread Aleksandar Markovic
On May 10, 2019 8:55 PM, "Richard Henderson" wrote: > > Changes in v2: > > * Fix --disable-tcg compilation for x86 and s390x. > I adjusted every target/ that used any CONFIG_TCG in cpu.c. > but then afterward I see that only x86 and s390x have had > their Makefiles adjusted to make -

Re: [Qemu-devel] [PATCH v3 38/39] tcg/arm: Use LDRD to load tlb mask+table

2019-05-11 Thread Richard Henderson
On 5/10/19 2:08 PM, Alistair Francis wrote: >> +if (use_armv6_instructions && TARGET_LONG_BITS == 64) { >> +tcg_out_ldrd_8(s, COND_AL, TCG_REG_R2, TCG_REG_R1, cmp_off); ... > > This is complex and I'm probably misunderstanding something but isn't > it possible for TCG_REG_R3 to

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-11 Thread Programmingkid
> On May 11, 2019, at 2:05 PM, Thomas Huth wrote: > > On 11/05/2019 19.21, Programmingkid wrote: >> >>> On Apr 20, 2019, at 6:40 AM, Thomas Huth wrote: >>> >>> On 19/04/2019 15.44, G 3 wrote: On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: > On 19/04/2019 00.47, John Arb

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-11 Thread Thomas Huth
On 11/05/2019 19.21, Programmingkid wrote: > >> On Apr 20, 2019, at 6:40 AM, Thomas Huth wrote: >> >> On 19/04/2019 15.44, G 3 wrote: >>> >>> On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: >>> On 19/04/2019 00.47, John Arbuckle wrote: > Capstone is not necessary in order to use QEMU. Di

Re: [Qemu-devel] [PATCH v1 05/23] semihosting: enable chardev backed output

2019-05-11 Thread Alex Bennée
Peter Maydell writes: > On Fri, 10 May 2019 at 17:59, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Thu, 9 May 2019 at 17:59, Alex Bennée wrote: >> >> >> >> For running system tests we want to be able to re-direct output to a >> >> file like we do with serial output. This does

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-11 Thread Programmingkid
> On Apr 20, 2019, at 6:40 AM, Thomas Huth wrote: > > On 19/04/2019 15.44, G 3 wrote: >> >> On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: >> >>> On 19/04/2019 00.47, John Arbuckle wrote: Capstone is not necessary in order to use QEMU. Disable it by default. This will save the user

Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu

2019-05-11 Thread Aleksandar Markovic
On May 8, 2019 4:33 PM, "Richard Henderson" wrote: > > On 5/8/19 1:15 AM, Aleksandar Markovic wrote: > > > > On May 8, 2019 2:19 AM, "Richard Henderson" < richard.hender...@linaro.org > > > wrote: > >> > >> > >> > > > > This commit message doesnˊt explain the r

Re: [Qemu-devel] [PULL v2 12/27] target/mips: Convert to CPUClass::tlb_fill

2019-05-11 Thread Aleksandar Markovic
On May 10, 2019 8:57 PM, "Richard Henderson" wrote: > Please change the title to 'target/mips: Switch to using mips_cpu_tlb_fill()', or something along that line. Also, the reason for changing the field access_type to mips_access type should be explained in the commit message. This commit messa

Re: [Qemu-devel] [PATCH v3 36/39] cpu: Remove CPU_COMMON

2019-05-11 Thread Aleksandar Markovic
On May 8, 2019 2:32 AM, "Richard Henderson" wrote: > > This macro is now always empty, so remove it. This leaves the > entire contents of CPUArchState under the control of the guest > architecture. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > include/exec/cpu-defs.

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-11 Thread Aleksandar Markovic
On May 10, 2019 10:36 PM, "Richard Henderson" wrote: > > For linux-user, there is no need to add slirp to the set of > git modules checked out, nor build it. > > This also avoids a makefile bug wrt insufficient dependencies > on subdir-slirp. If slirp/ is not initially present, the > dependencies

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-11 Thread Xiang Zheng
On 2019/5/10 23:16, Markus Armbruster wrote: > Xiang Zheng writes: > >> On 2019/5/9 19:59, Markus Armbruster wrote: >>> Xiang Zheng writes: >>> On 2019/5/8 21:20, Markus Armbruster wrote: > Laszlo Ersek writes: > >> Hi Markus, >> >> On 05/07/19 20:01, Markus Armbruste