Re: [Qemu-devel] [PATCH 2/2] configure: Use quotes around uses of $CPU_CFLAGS

2019-05-01 Thread Eric Blake
On 5/1/19 5:38 PM, Richard Henderson wrote: > About half of the values to which CPU_CFLAGS is set > have multiple space separated arguments. > > Signed-off-by: Richard Henderson > --- > configure | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/configure

Re: [Qemu-devel] [PATCH v2 4/5] hw/usb: avoid format truncation warning when formatting port name

2019-05-01 Thread Gerd Hoffmann
On Fri, Apr 12, 2019 at 01:16:25PM +0100, Daniel P. Berrangé wrote: > hw/usb/hcd-xhci.c: In function ‘usb_xhci_realize’: > hw/usb/hcd-xhci.c:3339:66: warning: ‘%d’ directive output may be truncated > writing between 1 and 10 bytes into a region of size 5 [-Wformat-trunca\ > tion=] > 3339 |

Re: [Qemu-devel] [PATCH v2 for-4.1 0/2] Fix ohci_die() and move PCI code to separate file

2019-05-01 Thread Gerd Hoffmann
On Fri, Apr 19, 2019 at 09:56:23AM +0200, Thomas Huth wrote: > First patch fixes a problem with ohci_die(), second patch moves PCI code into > a separate file, so that the sysbus OHCI device can also be used without > the dependency on the PCI code. > > v2: Split the patch into two patches, one fo

Re: [Qemu-devel] [PATCH v2] usb/xchi: avoid trigger assertion if guest write wrong epid

2019-05-01 Thread Gerd Hoffmann
On Tue, Apr 30, 2019 at 02:21:41PM +0800, Longpeng(Mike) wrote: > From: Longpeng > > we found the following core in our environment: > 0 0x7fc6b06c2237 in raise () > 1 0x7fc6b06c3928 in abort () > 2 0x7fc6b06bb056 in __assert_fail_base () > 3 0x7fc6b06bb102 in __assert_fail ()

Re: [Qemu-devel] [PATCH 2/2] configure: Use quotes around uses of $CPU_CFLAGS

2019-05-01 Thread Philippe Mathieu-Daudé
On 5/2/19 12:38 AM, Richard Henderson wrote: > About half of the values to which CPU_CFLAGS is set > have multiple space separated arguments. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > configure | 16 >

Re: [Qemu-devel] [PATCH v2 7/8] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

2019-05-01 Thread Thomas Huth
On 01/05/2019 18.37, Alex Bennée wrote: > > Thomas Huth writes: > >> Currently, all tests are in the "auto" group. This is a little bit pointless. >> OTOH, we need a group for the tests that we can automatically run during >> "make check" each time, too. Tests in this new group are supposed to r

[Qemu-devel] [PATCH v1 5/5] hw/arm: Add the Netduino Plus 2

2019-05-01 Thread Alistair Francis
Signed-off-by: Alistair Francis --- MAINTAINERS | 6 +++ default-configs/arm-softmmu.mak | 1 + hw/arm/Kconfig | 3 ++ hw/arm/Makefile.objs| 1 + hw/arm/netduinoplus2.c | 77 + 5 files changed, 88 insert

[Qemu-devel] [PATCH v1 3/5] armv7m: Allow entry information to be returned

2019-05-01 Thread Alistair Francis
Allow the kernel's entry point information to be returned when loading a kernel. Signed-off-by: Alistair Francis --- hw/arm/armv7m.c | 4 +++- include/hw/arm/arm.h | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index c4b2a9a1f5..2f

[Qemu-devel] [PATCH v1 1/5] hw/misc: Add the STM32F4xx Sysconfig device

2019-05-01 Thread Alistair Francis
Signed-off-by: Alistair Francis --- default-configs/arm-softmmu.mak| 1 + hw/misc/Kconfig| 3 + hw/misc/Makefile.objs | 1 + hw/misc/stm32f4xx_syscfg.c | 168 + hw/misc/trace-events | 6 ++ include/hw/m

[Qemu-devel] [PATCH v1 2/5] hw/misc: Add the STM32F4xx EXTI device

2019-05-01 Thread Alistair Francis
Signed-off-by: Alistair Francis --- default-configs/arm-softmmu.mak | 1 + hw/misc/Kconfig | 3 + hw/misc/Makefile.objs| 1 + hw/misc/stm32f4xx_exti.c | 187 +++ hw/misc/trace-events | 5 + include/hw/misc/stm32

[Qemu-devel] [PATCH v1 0/5] Add the STM32F405 and Netduino Plus 2 machine

2019-05-01 Thread Alistair Francis
Now that the Arm-M4 CPU has been added to QEMU we can add the Netduino Plus 2 machine. This is very similar to the STM32F205 and Netduino 2 SoC and machine. v2: - Reorder patchset - Return the kernel entry point instead of using a pointer - Address Peter's comments Alistair Francis (5): hw

[Qemu-devel] [PATCH v1 4/5] hw/arm: Add the STM32F4xx SoC

2019-05-01 Thread Alistair Francis
Signed-off-by: Alistair Francis --- MAINTAINERS | 8 + default-configs/arm-softmmu.mak | 1 + hw/arm/Kconfig | 3 + hw/arm/Makefile.objs| 1 + hw/arm/stm32f405_soc.c | 306 include/hw/arm/stm32f405_

Re: [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c

2019-05-01 Thread Wei Yang
On Wed, May 01, 2019 at 09:24:06PM -0700, no-re...@patchew.org wrote: >Patchew URL: >https://patchew.org/QEMU/20190430034412.12935-1-richardw.y...@linux.intel.com/ > > > >Hi, > >This series failed the asan build test. Please find the testing commands and >their output below. If you have Docker ins

Re: [Qemu-devel] [PATCH v1 4/5] hw/arm: Add the STM32F4xx SoC

2019-05-01 Thread Alistair Francis
On Tue, Apr 30, 2019 at 8:59 AM Peter Maydell wrote: > > On Mon, 29 Apr 2019 at 06:38, Alistair Francis wrote: > > > > Signed-off-by: Alistair Francis > > --- > > MAINTAINERS | 8 + > > default-configs/arm-softmmu.mak | 1 + > > hw/arm/Kconfig | 3 + >

Re: [Qemu-devel] [PATCH 0/2] configure: Fix make check-tcg for ppc64le

2019-05-01 Thread Richard Henderson
On 5/1/19 9:04 PM, David Gibson wrote: > I've staged this tentatively in ppc-for-4.1. However while it removes > the "Invalid ELF image" message I still get: > > TESTtest-mmap (4096 byte pages) on ppc64le > test-mmap: Invalid argument > make[2]: *** [/home/dwg/qemu/tests/tcg/multiarch/Makef

Re: [Qemu-devel] [PATCH v1 3/5] hw/misc: Add the STM32F4xx EXTI device

2019-05-01 Thread Alistair Francis
On Tue, Apr 30, 2019 at 8:48 AM Peter Maydell wrote: > > On Mon, 29 Apr 2019 at 06:37, Alistair Francis wrote: > > > > Signed-off-by: Alistair Francis > > --- > > default-configs/arm-softmmu.mak | 1 + > > hw/misc/Kconfig | 3 + > > hw/misc/Makefile.objs| 1 +

Re: [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190430034412.12935-1-richardw.y...@linux.intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bi

Re: [Qemu-devel] [PATCH 0/2] configure: Fix make check-tcg for ppc64le

2019-05-01 Thread David Gibson
On Wed, May 01, 2019 at 03:38:17PM -0700, Richard Henderson wrote: > At present make check-tcg will produce errors like > > RUN tests for ppc64 > TESTtest-mmap (default) on ppc64 > test-mmap: Invalid ELF image for this architecture > make[2]: *** [run-test-mmap] Error 255 > make[1]: **

[Qemu-devel] [Bug 1809291] Re: SD Card not working in Ubuntu 18.10 (CMD 2, 3 timeout). The device worked fine in Ubuntu 18.04 and earlier versions but not in Ubuntu 18.10

2019-05-01 Thread Philippe Mathieu-Daudé
The offending code is: $ git diff -w 4e5cc6756586e967993187657dfcdde4e00288d9~..4e5cc6756586e967993187657dfcdde4e00288d9 diff --git a/hw/sd/sd.c b/hw/sd/sd.c --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1537,7 +1537,7 @@ static sd_rsp_type_t sd_app_command(SDState *sd, } } -

Re: [Qemu-devel] [PATCH 2/2] ppc: Add dump-stack implementation

2019-05-01 Thread Alexey Kardashevskiy
On 02/05/2019 10:43, David Gibson wrote: > On Wed, May 01, 2019 at 07:48:48PM +1000, Alexey Kardashevskiy wrote: >> >> >> On 01/05/2019 15:35, Suraj Jitindar Singh wrote: >>> The monitor function dump-stack is used to dump the stack for a cpu. >>> This can be useful for debugging purposes when t

Re: [Qemu-devel] [PATCH v2] gitmodules: use qemu.org git mirrors

2019-05-01 Thread Philippe Mathieu-Daudé
On 5/1/19 7:06 PM, Stefan Hajnoczi wrote: > On Tue, Apr 30, 2019 at 04:53:08PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Thu, Apr 25, 2019 at 4:54 PM Stefan Hajnoczi wrote: >>> >>> qemu.org hosts git repository mirrors of all submodules. Update >>> .gitmodules to use the mirrors and not the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] monitor: Add dump-stack command

2019-05-01 Thread Alexey Kardashevskiy
On 02/05/2019 10:44, David Gibson wrote: > On Wed, May 01, 2019 at 03:35:21PM +1000, Suraj Jitindar Singh wrote: >> Add a monitor command "dump-stack" to be used to dump the stack for the >> current cpu. > > So, you can already get guest backtraces by using the gdbstub Not in the field - this

Re: [Qemu-devel] [PATCH v2] usb/xchi: avoid trigger assertion if guest write wrong epid

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1556605301-44112-1-git-send-email-longpe...@huawei.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRI

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-05-01 Thread David Gibson
On Wed, May 01, 2019 at 03:35:21PM +1000, Suraj Jitindar Singh wrote: > Add a monitor command "dump-stack" to be used to dump the stack for the > current cpu. So, you can already get guest backtraces by using the gdbstub functionality. I can see some benefit in allowing this more easily through h

Re: [Qemu-devel] [PATCH 2/2] ppc: Add dump-stack implementation

2019-05-01 Thread David Gibson
On Wed, May 01, 2019 at 07:48:48PM +1000, Alexey Kardashevskiy wrote: > > > On 01/05/2019 15:35, Suraj Jitindar Singh wrote: > > The monitor function dump-stack is used to dump the stack for a cpu. > > This can be useful for debugging purposes when the stack cannot be > > dumped by another means.

Re: [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c

2019-05-01 Thread Wei Yang
On Wed, May 01, 2019 at 03:53:01PM -0700, no-re...@patchew.org wrote: >Patchew URL: >https://patchew.org/QEMU/20190430034412.12935-1-richardw.y...@linux.intel.com/ > > > >Hi, > >This series failed the docker-mingw@fedora build test. Please find the testing >commands and >their output below. If yo

Re: [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190430034412.12935-1-richardw.y...@linux.intel.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

[Qemu-devel] [PATCH 1/2] configure: Distinguish ppc64 and ppc64le hosts

2019-05-01 Thread Richard Henderson
We cannot use the ppc64le host compiler to build ppc64(be) guest code. Clean up confusion between cross_cc_powerpc and cross_cc_ppc; make use of the cflags variable as well. Signed-off-by: Richard Henderson --- configure | 38 ++ 1 file changed, 26 insertions(

[Qemu-devel] [PATCH 2/2] configure: Use quotes around uses of $CPU_CFLAGS

2019-05-01 Thread Richard Henderson
About half of the values to which CPU_CFLAGS is set have multiple space separated arguments. Signed-off-by: Richard Henderson --- configure | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 234cb929ca..16bd4375d1 100755 --- a/configu

[Qemu-devel] [PATCH 0/2] configure: Fix make check-tcg for ppc64le

2019-05-01 Thread Richard Henderson
At present make check-tcg will produce errors like RUN tests for ppc64 TESTtest-mmap (default) on ppc64 test-mmap: Invalid ELF image for this architecture make[2]: *** [run-test-mmap] Error 255 make[1]: *** [run-guest-tests] Error 2 make: *** [run-tcg-tests-ppc64-linux-user] Error 2 w

[Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-01 Thread Collin Walling
DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must be intercepted by SIE and handled via KVM. Let's introduce some functions to communicate between QEMU and KVM via ioctls. These will be used to get/set the diag318 related information (also known as the "Control Program Code" or "

Re: [Qemu-devel] [PATCH v2 06/29] tcg: Return bool success from tcg_out_mov

2019-05-01 Thread Richard Henderson
On 5/1/19 10:29 AM, Alex Bennée wrote: >> +static inline bool tcg_out_mov(TCGContext *s, TCGType type, >> TCGReg ret, TCGReg arg) >> { >> -tcg_out_dat_reg(s, COND_AL, ARITH_MOV, ret, 0, arg, SHIFT_IMM_LSL(0)); >> +if (ret != arg) { >> +tcg_out_dat_re

[Qemu-devel] [PULL 0/2] Bitmaps patches

2019-05-01 Thread John Snow
The following changes since commit 46316f1dfffc6be72e94e89f7b0e9162e7dcdcf1: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20190311.0' into staging (2019-03-12 13:37:29 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/bitmaps-pull-req

[Qemu-devel] [PULL 2/2] docs/interop/bitmaps: rewrite and modernize doc

2019-05-01 Thread John Snow
This just about rewrites the entirety of the bitmaps.rst document to make it consistent with the 4.0 release. I have added new features seen in the 4.0 release, as well as tried to clarify some points that keep coming up when discussing this feature both in-house and upstream. It does not yet cove

[Qemu-devel] [PULL 1/2] Makefile: add nit-picky mode to sphinx-build

2019-05-01 Thread John Snow
If we add references that don't resolve (or accidentally remove them), it will be helpful to have warning messages alerting us to that. Further, turn those warnings into errors so we can be alerted to these problems sooner rather than later. Signed-off-by: John Snow Reviewed-by: Vladimir Sements

Re: [Qemu-devel] [PATCH v2 08/29] tcg: Promote tcg_out_{dup, dupi}_vec to backend interface

2019-05-01 Thread Richard Henderson
On 5/1/19 10:37 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> The i386 backend already has these functions, and the aarch64 >> backend could easily split out one. Nothing is done with these >> functions yet, but this will aid register allocation of >> INDEX_op_dup_vec in a later pat

Re: [Qemu-devel] [PATCH v2 07/29] tcg: Support cross-class moves without instruction support

2019-05-01 Thread Richard Henderson
On 5/1/19 10:34 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> PowerPC Altivec does not support direct moves between vector registers >> and general registers. So when tcg_out_mov fails, we can use the >> backing memory for the temporary to perform the move. > > I couldn't see where

[Qemu-devel] [Bug 1809291] Re: ARM PL181 (mmc for Security Digital Card) not working in Ubuntu 18.10 (CMD 2, 3 timeout). The SDC driver worked fine in Ubuntu 18.04 and earlier versions but not in Ubun

2019-05-01 Thread Philippe Mathieu-Daudé
I googled some code from comment #2 and got a hit for "u32 RCA = (u32)0x4567; // QEMU's hard-coded RCA". Then I found kcwang's book: https://link.springer.com/content/pdf/10.1007%2F978-3-319-51517-5.pdf and read: "I am also grateful to Springer International Publishing AG for allowing me to

Re: [Qemu-devel] [PATCH v1] target/arm/arm-powerctl: mask the cpuid with affinity bits when get cpu

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190430031238.40499-1-yangchuanl...@huawei.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [Qemu-devel] [PATCH] tests/tcg/alpha: add system boot.S

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190501184306.15208-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190501184306.15208-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH

[Qemu-devel] [PATCH] tests/tcg/alpha: add system boot.S

2019-05-01 Thread Richard Henderson
This provides the bootstrap and low level helper functions for an alpha kernel. We use direct access to the DP264 serial port for test output, and hard machine halt to exit the emulation. Signed-off-by: Richard Henderson --- tests/tcg/alpha/Makefile.softmmu-target | 32 ++ tests/tcg/alpha/syst

Re: [Qemu-devel] [PATCH v6 02/30] hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device

2019-05-01 Thread John Snow
On 4/30/19 3:13 AM, Thomas Huth wrote: > Some of our machines (like the ARM cubieboard) use CONFIG_AHCI for an AHCI > sysbus device, but do not use CONFIG_PCI since they do not feature a PCI > bus. With CONFIG_AHCI but without CONFIG_PCI, currently linking fails: > > ../hw/ide/ich.o: In fun

Re: [Qemu-devel] [PATCH v5 00/15] demacro softmmu (plus tests/coverage)

2019-05-01 Thread Richard Henderson
On 4/30/19 9:52 AM, Alex Bennée wrote: > I've also moved the existing system memory test and made it multiarch > and added the bootstrapping for aarch64 system tests. I would like to > add support for Big Endian as well but I didn't want to delay the > posting of the series. It would also be nice t

Re: [Qemu-devel] [PATCH v1] target/arm/arm-powerctl: mask the cpuid with affinity bits when get cpu

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190430031238.40499-1-yangchuanl...@huawei.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bas

Re: [Qemu-devel] [PATCH v5 04/15] tests/tcg/multiarch: move the system memory test

2019-05-01 Thread Richard Henderson
On 4/30/19 9:52 AM, Alex Bennée wrote: > There is nothing inherently architecture specific about the memory > test although we may have to manage different restrictions of > unaligned access across architectures. > > Signed-off-by: Alex Bennée > --- > tests/tcg/{i386 => multiarch}/system/memory.

Re: [Qemu-devel] [PATCH v5 02/15] tests/tcg/multiarch: add hello world system test

2019-05-01 Thread Richard Henderson
On 4/30/19 9:52 AM, Alex Bennée wrote: > This is not really i386 only, we can have the same test for all > architectures supporting system tests. > > Signed-off-by: Alex Bennée > --- > tests/tcg/i386/Makefile.softmmu-target | 2 +- > tests/tcg/{i386 => multiarch}/system/hello.c | 0 > 2 fi

Re: [Qemu-devel] [PATCH v5 01/15] tests/tcg/multiarch: add support for multiarch system tests

2019-05-01 Thread Richard Henderson
On 4/30/19 9:52 AM, Alex Bennée wrote: > We can certainly support some common tests for system emulation that > make use of our minimal defined boot.S support. It will still be up to > individual architectures to ensure they build so we provide a > MULTIARCH_TESTS variable that they can tack onto T

[Qemu-devel] [PATCH v2 3/5] vvfat: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}()

2019-05-01 Thread Alberto Garcia
There's only a couple of bdrv_read() and bdrv_write() calls left in the vvfat code, and they can be trivially replaced with the byte-based bdrv_pread() and bdrv_pwrite(). Signed-off-by: Alberto Garcia --- block/vvfat.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --gi

[Qemu-devel] [PATCH v2 2/5] vdi: Replace bdrv_{read, write}() with bdrv_{pread, pwrite}()

2019-05-01 Thread Alberto Garcia
There's only a couple of bdrv_read() and bdrv_write() calls left in the vdi code, and they can be trivially replaced with the byte-based bdrv_pread() and bdrv_pwrite(). Signed-off-by: Alberto Garcia --- block/vdi.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/5] Remove bdrv_read() and bdrv_write()

2019-05-01 Thread Alberto Garcia
Hi, this API only had a few users left so it can be easily removed. Regards, Berto v2: - Patch 2: Add QEMU_BUILD_BUG_ON(sizeof(VdiHeader) != 512) [Kevin] Correct size parameter in bdrv_pwrite() call [Kevin] Return 0 on success, never a positive number [Kevin] - Patch 3: Ch

[Qemu-devel] [PATCH v2 5/5] qcow2: Remove BDRVQcow2State.cluster_sectors

2019-05-01 Thread Alberto Garcia
The last user of this field disappeared when we replace the sector-based bdrv_write() with the byte-based bdrv_pwrite(). Signed-off-by: Alberto Garcia --- block/qcow2.c | 1 - block/qcow2.h | 1 - 2 files changed, 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index a520d116ef..8e024

[Qemu-devel] [PATCH v2 1/5] qcow2: Replace bdrv_write() with bdrv_pwrite()

2019-05-01 Thread Alberto Garcia
There's only one bdrv_write() call left in the qcow2 code, and it can be trivially replaced with the byte-based bdrv_pwrite(). Signed-off-by: Alberto Garcia --- block/qcow2-refcount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-ref

[Qemu-devel] [PATCH v2 4/5] block: Remove bdrv_read() and bdrv_write()

2019-05-01 Thread Alberto Garcia
No one is using these functions anymore, all callers have switched to the byte-based bdrv_pread() and bdrv_pwrite() Signed-off-by: Alberto Garcia --- block/io.c| 43 +++ include/block/block.h | 4 2 files changed, 7 insertions(+), 40 dele

[Qemu-devel] [Bug 1809291] Re: ARM PL181 (mmc for Security Digital Card) not working in Ubuntu 18.10 (CMD 2, 3 timeout). The SDC driver worked fine in Ubuntu 18.04 and earlier versions but not in Ubun

2019-05-01 Thread Philippe Mathieu-Daudé
** Changed in: qemu Assignee: (unassigned) => Philippe Mathieu-Daudé (philmd) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1809291 Title: ARM PL181 (mmc for Security Digital Card) not working

Re: [Qemu-devel] [PATCH v2 08/29] tcg: Promote tcg_out_{dup, dupi}_vec to backend interface

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > The i386 backend already has these functions, and the aarch64 > backend could easily split out one. Nothing is done with these > functions yet, but this will aid register allocation of > INDEX_op_dup_vec in a later patch. "Also use correct type for tcg_out_dupi_v

Re: [Qemu-devel] [PATCH v2 07/29] tcg: Support cross-class moves without instruction support

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > PowerPC Altivec does not support direct moves between vector registers > and general registers. So when tcg_out_mov fails, we can use the > backing memory for the temporary to perform the move. I couldn't see where tcg_out_mov fails in this way for ppc, it is still

Re: [Qemu-devel] [PATCH] scsi-disk: handle invalid cdb length

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190429235109.20307-1-brog...@suse.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time ma

[Qemu-devel] [Bug 1797262] Re: qemu arm no longer able to boot RPI Kernels

2019-05-01 Thread Philippe Mathieu-Daudé
** Tags added: arm ** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Assignee: (unassigned) => Philippe Mathieu-Daudé (philmd) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

Re: [Qemu-devel] [PATCH v2 06/29] tcg: Return bool success from tcg_out_mov

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > This patch merely changes the interface, aborting on all failures, You say this but... > > -static inline void tcg_out_mov(TCGContext *s, TCGType type, > +static inline bool tcg_out_mov(TCGContext *s, TCGType type, > TCGReg ret, TCG

Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-05-01 Thread Stefan Hajnoczi
On Tue, Apr 30, 2019 at 07:48:16PM -0300, Eduardo Habkost wrote: > On Tue, Apr 30, 2019 at 10:36:18PM +, Wei Yang wrote: > [...] > > >> +#ifdef CONFIG_LINUX > > >> +#include > > >> +#endif /* CONFIG_LINUX */ > > >> + > > >> +#ifndef MAP_SYNC > > >> +#define MAP_SYNC 0 > > >> +#endif > > >> +#i

Re: [Qemu-devel] [PATCH v2 05/29] tcg: Assert fixed_reg is read-only

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > The only fixed_reg is cpu_env, and it should not be modified > during any TB. Therefore code that tries to special-case moves > into a fixed_reg is dead. Remove it. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PATCH v2 04/29] tcg: Specify optional vector requirements with a list

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > Replace the single opcode in .opc with a null-terminated > array in .opt_opc. We still require that all opcodes be > used with the same .vece. > > Validate the contents of this list with CONFIG_DEBUG_TCG. > All tcg_gen_*_vec functions will check any list active > du

Re: [Qemu-devel] Spreading the load on QEMU pullreq handling and release work

2019-05-01 Thread Stefan Hajnoczi
On Tue, Apr 30, 2019 at 06:27:03PM +0100, Peter Maydell wrote: > For the moment I'd like to ask for in-principle volunteers > to be on the release-handling rota. I am willing to handle one release per year. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH 2/2] target/riscv: Add checks for several RVC reserved operands

2019-05-01 Thread Palmer Dabbelt
On Thu, 25 Apr 2019 10:32:43 PDT (-0700), richard.hender...@linaro.org wrote: On 4/25/19 10:26 AM, Richard Henderson wrote: { + illegal 011 0 - 0 01 # c.addi16sp, RES nzimm=0 addi011 . 00010 . 01 @c_addi16sp lui 011 . . . 01 @c_lu

Re: [Qemu-devel] [PATCH 1/2] fixup! target/riscv: Name the argument sets for all of insn32 formats

2019-05-01 Thread Palmer Dabbelt
On Thu, 25 Apr 2019 10:26:35 PDT (-0700), richard.hender...@linaro.org wrote: --- target/riscv/translate.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index d1f599a92d..009c146e8f 100644 --- a/target/riscv

Re: [Qemu-devel] [PATCH v2] gitmodules: use qemu.org git mirrors

2019-05-01 Thread Stefan Hajnoczi
On Tue, Apr 30, 2019 at 04:53:08PM +0200, Marc-André Lureau wrote: > Hi > > On Thu, Apr 25, 2019 at 4:54 PM Stefan Hajnoczi wrote: > > > > qemu.org hosts git repository mirrors of all submodules. Update > > .gitmodules to use the mirrors and not the upstream repositories. > > > > Mirroring upstr

Re: [Qemu-devel] [PATCH] scsi-disk: assert positive value to avoid compiler warning

2019-05-01 Thread John Snow
On 5/1/19 1:01 PM, Bruce Rogers wrote: > While investigating link-time-optimization, the compiler complained as > follows: > In function ‘scsi_disk_new_request_dump’, > inlined from ‘scsi_new_request.part.24’ at hw/scsi/scsi-disk.c:2549:9, > inlined from ‘scsi_new_request’ at hw/scsi/scs

[Qemu-devel] [PATCH] scsi-disk: assert positive value to avoid compiler warning

2019-05-01 Thread Bruce Rogers
While investigating link-time-optimization, the compiler complained as follows: In function ‘scsi_disk_new_request_dump’, inlined from ‘scsi_new_request.part.24’ at hw/scsi/scsi-disk.c:2549:9, inlined from ‘scsi_new_request’ at hw/scsi/scsi-disk.c:2533:21: hw/scsi/scsi-disk.c:2523:19: error

Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-05-01 Thread Eduardo Habkost
On Tue, Apr 30, 2019 at 07:38:59PM -0400, Michael S. Tsirkin wrote: > On Wed, May 01, 2019 at 01:11:34AM +0200, Paolo Bonzini wrote: > > On 01/05/19 00:50, Michael S. Tsirkin wrote: > > >> Stefan, did you hit a build failure, or it was just theoretical? > > >> > > >> linux-headers/*/mman.h is updat

Re: [Qemu-devel] [PATCH] vhost: fix memory leak in vhost_user_scsi_realize

2019-05-01 Thread Stefan Hajnoczi
On Tue, Apr 30, 2019 at 03:15:00PM +0800, Jie Wang wrote: > fix memory leak in vhost_user_scsi_realize > > Signed-off-by: Jie Wang > --- > hw/scsi/vhost-user-scsi.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH] vhost: remove the dead code

2019-05-01 Thread Stefan Hajnoczi
On Tue, Apr 30, 2019 at 02:10:14PM +0800, Jie Wang wrote: > remove the dead code > > Signed-off-by: Jie Wang > --- > hw/virtio/vhost.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v2 7/8] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

2019-05-01 Thread Alex Bennée
Thomas Huth writes: > Currently, all tests are in the "auto" group. This is a little bit pointless. > OTOH, we need a group for the tests that we can automatically run during > "make check" each time, too. Tests in this new group are supposed to run > with every possible QEMU configuration, for

Re: [Qemu-devel] Following up questions related to QEMU and I/O Thread

2019-05-01 Thread Stefan Hajnoczi
On Mon, Apr 29, 2019 at 10:56:31AM -0700, Wei Li wrote: > Does this mean the performance could be improved via adding Batch I/O > submission support in Guest driver side which will be able to reduce the > number of virtqueue kicks? Yes, I think so. It's not obvious to me how a Linux SCSI driver

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-05-01 Thread John Snow
On 5/1/19 11:24 AM, Eric Blake wrote: > On 4/30/19 6:08 PM, John Snow wrote: >> >> >> On 11/20/18 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 16.11.2018 21:43, John Snow wrote: Coverity warns that backing_bs() could give us a NULL pointer, which we then use without checking that

Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument"

2019-05-01 Thread Stefan Hajnoczi
On Mon, Apr 29, 2019 at 01:58:46PM +0100, Peter Maydell wrote: > On Mon, 29 Apr 2019 at 13:28, Stefan Hajnoczi wrote: > > > > On Fri, Apr 26, 2019 at 12:45:37PM +0100, Peter Maydell wrote: > > I was going to add a function to check kernel_filename and the presence > > of -device loader. Then each

Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument"

2019-05-01 Thread Stefan Hajnoczi
On Mon, Apr 29, 2019 at 12:53:48PM +, Joel Stanley wrote: > On Fri, 26 Apr 2019 at 09:17, Stefan Hajnoczi wrote: > > > > A user-friendly error message is needed here. The check for -kernel was > > too specific and is not desirable for microbit where we use -device > > loader. > > > > Old boar

Re: [Qemu-devel] [PATCH v2] virtio: clarify VirtioPCIDeviceTypeInfo usage

2019-05-01 Thread Stefan Hajnoczi
On Thu, Apr 25, 2019 at 02:09:39PM +0100, Stefan Hajnoczi wrote: > How to use .base_name, .generic_name, .transitional_name, and > .non_transitional_name can be confusing. > > Existing devices have .generic_name but its behavior is somewhat magic. > > Devices added to new versions of the VIRTIO s

Re: [Qemu-devel] [PATCH v2] gitmodules: use qemu.org git mirrors

2019-05-01 Thread Stefan Hajnoczi
On Thu, Apr 25, 2019 at 03:54:20PM +0100, Stefan Hajnoczi wrote: > qemu.org hosts git repository mirrors of all submodules. Update > .gitmodules to use the mirrors and not the upstream repositories. > > Mirroring upstream repositories ensures that QEMU continues to build > even when upstream repo

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-01 Thread Stefan Hajnoczi
On Thu, Apr 25, 2019 at 02:35:03PM +0100, Stefan Hajnoczi wrote: > At KVM Forum 2018 I gave a presentation on security in QEMU: > https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) > https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) > > This patch adds a security guide to the deve

Re: [Qemu-devel] [PATCH v2] scsi-disk: handle invalid cdb length

2019-05-01 Thread Bruce Rogers
>>> On 4/30/2019 at 2:40 PM, John Snow wrote: > > On 4/30/19 9:19 AM, Bruce Rogers wrote: >> While investigating link-time-optimization, the compiler flagged this >> case of not handling the error return from scsi_cdb_length(). Handle >> this error case with a trace report. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v2 03/29] tcg: Allow add_vec, sub_vec, neg_vec, not_vec to be expanded

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/tcg-op-vec.c | 49 > 1 file changed, 33 insertions(+), 16 deletions(-) > > diff --git a/tcg/tcg-op-vec.c b/tc

Re: [Qemu-devel] [PATCH v2] sockets: avoid string truncation warnings when copying UNIX path

2019-05-01 Thread Eric Blake
On 5/1/19 9:50 AM, Daniel P. Berrangé wrote: > In file included from /usr/include/string.h:494, > from include/qemu/osdep.h:101, > from util/qemu-sockets.c:18: > In function ‘strncpy’, > inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: > /

Re: [Qemu-devel] [PATCH v2 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info()

2019-05-01 Thread Philippe Mathieu-Daudé
On 4/30/19 9:12 PM, Philippe Mathieu-Daudé wrote: > On 4/30/19 8:13 PM, Cao Jiaxi wrote: >> Windows ARM64 uses LLP64 model, which breaks current assumptions. >> >> Signed-off-by: Cao Jiaxi >> --- >> util/cacheinfo.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/util/

Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190501061827.23080-1-j...@jms.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190501061827.23080-1-j...@jms.id.au Subject: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size

Re: [Qemu-devel] [PATCH v2] linux-user: avoid string truncation warnings in uname field copying

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190501144646.4851-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190501144646.4851-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH v2] linux-user: avoi

Re: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size

2019-05-01 Thread Philippe Mathieu-Daudé
On 5/1/19 8:18 AM, Joel Stanley wrote: > We currently use Qemu's default of 128MB. As we know how much ram each > machine ships with, make it easier on users by setting a default. > > It can still be overridden with -m on the command line. > > Signed-off-by: Joel Stanley > --- > hw/arm/aspeed.c

Re: [Qemu-devel] [PATCH v2 02/29] tcg: Do not recreate INDEX_op_neg_vec unless supported

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > Use tcg_can_emit_vec_op instead of just TCG_TARGET_HAS_neg_vec, > so that we check the type and vece for the actual operation. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/optimize.c | 8 ++-- > 1 file changed, 6 insertions(+), 2

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-05-01 Thread Eric Blake
On 4/30/19 6:08 PM, John Snow wrote: > > > On 11/20/18 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: >> 16.11.2018 21:43, John Snow wrote: >>> Coverity warns that backing_bs() could give us a NULL pointer, which >>> we then use without checking that it isn't. >>> >>> In our loop condition, we che

Re: [Qemu-devel] [PATCH v2] linux-user: avoid string truncation warnings in uname field copying

2019-05-01 Thread Philippe Mathieu-Daudé
On 5/1/19 4:46 PM, Daniel P. Berrangé wrote: > In file included from /usr/include/string.h:494, > from include/qemu/osdep.h:101, > from linux-user/uname.c:20: > In function ‘strncpy’, > inlined from ‘sys_uname’ at linux-user/uname.c:94:3: > /usr/include/bits/st

Re: [Qemu-devel] [PATCH v2 01/29] tcg: Implement tcg_gen_gvec_3i()

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > From: David Hildenbrand > > Let's add tcg_gen_gvec_3i(), similar to tcg_gen_gvec_2i(), however > without introducing "gen_helper_gvec_3i *fnoi", as it isn't needed > for now. > > Signed-off-by: David Hildenbrand > Message-Id: <20190416185301.25344-2-da...@redhat.co

Re: [Qemu-devel] [PATCH v2 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-05-01 Thread Philippe Mathieu-Daudé
On 5/1/19 4:12 PM, Richard Henderson wrote: > On 4/30/19 4:28 PM, Alistair Francis wrote: >> for (i = 0; i < usbports; i++) { >> +g_assert(i < MAX(MAXPORTS_2, MAXPORTS_3)); > > I would hope that it works to move this out of the loop: > > g_assert(usbports <= MAX(MAXPORTS_2, MAXPORT

Re: [Qemu-devel] [PATCH v2 3/8] tests/qemu-iotests/check: Pick a default machine if necessary

2019-05-01 Thread Philippe Mathieu-Daudé
On 4/28/19 5:54 PM, Thomas Huth wrote: > qemu-system-arm, qemu-system-aarch64 and qemu-system-tricore do not have > a default machine, so when running the qemu-iotests with such a binary, > lots of tests are failing. Fix it by picking a default machine in the > "check" script instead. > > Signed-o

Re: [Qemu-devel] [PATCH v2 5/8] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD

2019-05-01 Thread Philippe Mathieu-Daudé
On 4/28/19 5:54 PM, Thomas Huth wrote: > We are going to enable the qemu-iotests during "make check" again, > and for running the iotests, we need bash and gnu-sed. > > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > .cirrus.yml | 4 ++-- > .travis.yml | 1 + > 2 files

Re: [Qemu-devel] [PATCH v2] hw/virtio/virtio-mmio: Convert DPRINTF to traces

2019-05-01 Thread Alex Bennée
Yuval Shaia writes: > On Wed, May 01, 2019 at 08:42:35PM +0800, LI, BO XUAN wrote: >>On Wed, May 1, 2019 at 4:58 PM Yuval Shaia <[1]yuval.sh...@oracle.com> >>wrote: >> >> On Wed, May 01, 2019 at 04:10:39PM +0800, Boxuan Li wrote: >> > Signed-off-by: Boxuan Li <[2]libox...@conn

Re: [Qemu-devel] [PATCH v2 29/29] target/xtensa: Use tcg_gen_abs_i32

2019-05-01 Thread Max Filippov
On Tue, Apr 30, 2019 at 10:06 PM Richard Henderson wrote: > > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > target/xtensa/translate.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) Acked-by: Max Filippov -- Thanks. -- Max

Re: [Qemu-devel] [PATCH v5 09/15] accel/tcg: remove softmmu_template.h

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > On 4/30/19 9:52 AM, Alex Bennée wrote: >> Signed-off-by: Alex Bennée >> --- >> accel/tcg/softmmu_template.h | 454 --- >> 1 file changed, 454 deletions(-) >> delete mode 100644 accel/tcg/softmmu_template.h > > Why is this separate f

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

2019-05-01 Thread Stefan Hajnoczi
On Mon, Apr 29, 2019 at 12:57:41PM +0200, Kevin Wolf wrote: > make_completely_empty() is an optimisated path for bdrv_make_empty() > where completely new metadata is created inside the image file instead > of going through all clusters and discarding them. For an external data > file, however, we a

Re: [Qemu-devel] [PATCH v5 03/15] tests/tcg/aarch64: add system boot.S

2019-05-01 Thread Alex Bennée
Richard Henderson writes: > On 4/30/19 9:52 AM, Alex Bennée wrote: >> +.error: >> +.string "Terminated by exception.\n" > > Put it in .rodata just because we can? Sure. > >> +/* Page table setup (identity mapping). */ >> +adrpx0, ttb >> +add x0, x0, :lo12:ttb > >

Re: [Qemu-devel] [PATCH v2] linux-user: avoid string truncation warnings in uname field copying

2019-05-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190501144646.4851-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190501144646.4851-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH v2] linux-user: avoi

[Qemu-devel] [PATCH v2] sockets: avoid string truncation warnings when copying UNIX path

2019-05-01 Thread Daniel P . Berrangé
In file included from /usr/include/string.h:494, from include/qemu/osdep.h:101, from util/qemu-sockets.c:18: In function ‘strncpy’, inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: /usr/include/bits/string_fortified.h:106:10: warning: ‘__b

  1   2   >