[Qemu-devel] [PATCH] qxl: check release info object

2019-04-24 Thread P J P
From: Prasad J Pandit When releasing spice resources in release_resource() routine, if release info object 'ext.info' is null, it leads to null pointer dereference. Add check to avoid it. Reported-by: Bugs SysSec Signed-off-by: Prasad J Pandit --- hw/display/qxl.c | 3 +++ 1 file changed, 3 i

Re: [Qemu-devel] [PATCH 4/6] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD

2019-04-24 Thread Thomas Huth
On 24/04/2019 23.29, Wainer dos Santos Moschetta wrote: > Hello Thomas, > > On 04/24/2019 07:37 AM, Thomas Huth wrote: >> We are going to enable the qemu-iotests during "make check" again, >> and for running the iotests, we need bash and gnu-sed. >> >> Signed-off-by: Thomas Huth >> --- >>   .cirr

Re: [Qemu-devel] [PATCH 5/6] tests: Run the iotests during "make check" again

2019-04-24 Thread Thomas Huth
On 24/04/2019 22.42, Wainer dos Santos Moschetta wrote: > Hi Thomas, > > > On 04/24/2019 07:37 AM, Thomas Huth wrote: >> People often forget to run the iotests before submitting patches or >> pull requests - this is likely due to the fact that we do not run the >> tests during our mandatory "make

[Qemu-devel] [PATCH v3 00/13] tests: acpi: add UEFI (ARM) testing support

2019-04-24 Thread Igor Mammedov
Changelog: - from v2: * rebase on top current master (with UEFI blobs merged) * added a Makefile rule to include bios-tables-test to aarch64 tests by default into 11/13 (kept Reviewed-bys) * other trivial fixes and cleanups (see per patch changelogs) - from v1:

[Qemu-devel] [PATCH v3 02/13] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()

2019-04-24 Thread Igor Mammedov
so name would reflect what the function does Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- tests/acpi-utils.h | 2 +- tests/acpi-utils.c | 2 +- tests/bios-tables-test.c | 2 +- tests/vmgenid-test.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v3 03/13] tests: acpi: make pointer to RSDP 64bit

2019-04-24 Thread Igor Mammedov
In case of UEFI, RSDP doesn't have to be located in lowmem, it could be placed at any address. Make sure that test won't break if it is placed above the first 4Gb of address space. PS: While at it cleanup some local variables as we don't really need them. Signed-off-by: Igor Mammedov Reviewed-by

[Qemu-devel] [PATCH v3 07/13] tests: acpi: add acpi_find_rsdp_address_uefi() helper

2019-04-24 Thread Igor Mammedov
introduce UEFI specific counterpart to acpi_find_rsdp_address() that will help to find RSDP address when [OA]VMF is used as firmware. It requires guest firmware or other guest app to place 1Mb aligned UefiTestSupport structure (defined in this patch) in RAM with UefiTestSupport::signature_guid set

Re: [Qemu-devel] [PATCH for-4.1 1/8] target/riscv: Name the argument sets for all of insn32 formats

2019-04-24 Thread Aleksandar Markovic
On Apr 25, 2019 7:17 AM, "Richard Henderson" wrote: > > On 4/24/19 8:31 PM, Palmer Dabbelt wrote: > >> # Argument sets: > >> +&empty > > > > If I understand decodetree correctly, this isn't used until patch 5. > > Otherwise, > > > > I think it's used as early as patch 3, but I haven't looked in d

[Qemu-devel] [PATCH v3 01/13] tests: acpi: make RSDT test routine handle XSDT

2019-04-24 Thread Igor Mammedov
If RSDP revision is more than 0 fetch table pointed by XSDT and fallback to legacy RSDT table otherwise. While at it drop unused acpi_get_xsdt_address(). Signed-off-by: Igor Mammedov --- PS: it doesn't affect existing pc/q35 machines as they use RSDP.revision == 0 but it will be used by follow

[Qemu-devel] [PATCH v3 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-04-24 Thread Igor Mammedov
once FW provides a pointer to SMBIOS entry point like it does for RSDP it should be possible to enable this one the same way. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek --- v3: - add ref to a uefi-test-tools feature req into comment (Laszlo) --- tests/bios-tables-test.c | 11 +

[Qemu-devel] [PATCH v3 04/13] tests: acpi: fetch X_DSDT if pointer to DSDT is 0

2019-04-24 Thread Igor Mammedov
that way it would be possible to test a DSDT pointed by 64bit X_DSDT field in FADT. PS: it will allow to enable testing arm/virt board, which sets only newer X_DSDT field. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- v2: add 'val = le32_to_cpu(val)' even if it doesn't

[Qemu-devel] [PATCH v3 05/13] tests: acpi: skip FACS table if board uses hw reduced ACPI profile

2019-04-24 Thread Igor Mammedov
If FADT has HW_REDUCED_ACPI flag set, do not attempt to fetch FACS as it's not provided by the board. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- tests/bios-tables-test.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/bios-tables-te

[Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase

2019-04-24 Thread Igor Mammedov
adds simple arm/virt test case that starts guest with bios-tables-test.aarch64.iso.qcow2 boot image which initializes UefiTestSupport* structure in RAM once guest is booted. * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Erse

[Qemu-devel] [PATCH v3 06/13] tests: acpi: move boot_sector_init() into x86 tests branch

2019-04-24 Thread Igor Mammedov
boot_sector_init() won't be used by arm/virt board, so move it from global scope to x86 branch that uses it. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- v3: - fix checkpatch errors triggered by moved old code (ident/space/braces) --- tests/bios-tables-test.c | 9 +

[Qemu-devel] [PATCH v3 08/13] tests: acpi: add a way to start tests with UEFI firmware

2019-04-24 Thread Igor Mammedov
For testcase to use UEFI firmware, one needs to provide and specify firmwarei and varstore blobs names in test_data { uefi_fl1, uefi_fl2) } fields respectively and RAM start address plus size where to look for test structure signature. Additionally testcase should specify bootable cdrom image uefi-

[Qemu-devel] [PATCH v3 13/13] tests: acpi: print error unable to dump ACPI table during rebuild

2019-04-24 Thread Igor Mammedov
Instead of just asserting print the error that lead to assert first. While at it move assert into rebuild branch, which removes reduntant check done in case of !rebuild branch is taken (the later is taken care of by g_assert_no_error). Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c |

[Qemu-devel] [PATCH v3 12/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets

2019-04-24 Thread Igor Mammedov
Make initial list contain aarch64 and x86_64 targets. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- v2: * fix up error message (Philippe Mathieu-Daudé ) --- tests/data/acpi/rebuild-expected-aml.sh | 23 +++ 1 file changed, 11 insertions(+), 12 deletio

[Qemu-devel] [PATCH v3 10/13] tests: add expected ACPI tables for arm/virt board

2019-04-24 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- this patch is ahead fo "tests: acpi: add simple arm/virt testcase" to keep 'make check' working during bisection and not to pollute code with binary blobs which are not reviewable. --- tests/data/acpi/virt/APIC | Bin 0 -> 168 bytes tests/data/acpi/virt/DSDT | Bi

Re: [Qemu-devel] [PATCH for-4.1 1/8] target/riscv: Name the argument sets for all of insn32 formats

2019-04-24 Thread Richard Henderson
On 4/24/19 8:31 PM, Palmer Dabbelt wrote: >>  # Argument sets: >> +&empty > > If I understand decodetree correctly, this isn't used until patch 5. > Otherwise, > I think it's used as early as patch 3, but I haven't looked in detail to be sure. r~

Re: [Qemu-devel] [PATCH v8 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-04-24 Thread Aravinda Prasad
On Tuesday 23 April 2019 12:15 PM, David Gibson wrote: > On Mon, Apr 22, 2019 at 12:32:58PM +0530, Aravinda Prasad wrote: >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls. >> >> The machine check notification address is saved when the >> OS is

Re: [Qemu-devel] [PATCH for-4.1 2/8] target/riscv: Use --static-decode for decodetree

2019-04-24 Thread Palmer Dabbelt
On Sun, 31 Mar 2019 20:11:49 PDT (-0700), richard.hender...@linaro.org wrote: The generated functions are only used within translate.c and do not need to be global, or declared. Signed-off-by: Richard Henderson --- target/riscv/translate.c | 2 -- target/riscv/Makefile.objs | 8 2 f

Re: [Qemu-devel] [PATCH for-4.1 1/8] target/riscv: Name the argument sets for all of insn32 formats

2019-04-24 Thread Palmer Dabbelt
On Sun, 31 Mar 2019 20:11:48 PDT (-0700), richard.hender...@linaro.org wrote: Signed-off-by: Richard Henderson --- target/riscv/insn32.decode | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 6f3ab7aa52..

[Qemu-devel] [PATCH] bitmap: get last word mask from nr directly

2019-04-24 Thread Wei Yang
The value left in nr is the number of bits for the last word, which could be calculate the last word mask directly. Remove the unnecessary size. Signed-off-by: Wei Yang --- util/bitmap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/util/bitmap.c b/util/bitmap.c inde

Re: [Qemu-devel] [PATCH v3 2/2] core/qdev: refactor qdev_get_machine() with type assertion

2019-04-24 Thread Like Xu
On 2019/4/25 1:21, Eduardo Habkost wrote: On Tue, Apr 23, 2019 at 03:59:31PM +0800, Like Xu wrote: On 2019/4/18 1:10, Eduardo Habkost wrote: On Wed, Apr 17, 2019 at 07:14:10AM +0200, Markus Armbruster wrote: Eduardo Habkost writes: On Mon, Apr 15, 2019 at 03:59:45PM +0800, Like Xu wrote: T

Re: [Qemu-devel] [PATCH V3] vhost_net: don't set backend for the uninitialized virtqueue

2019-04-24 Thread Jason Wang
On 2019/4/24 下午9:51, Michael S. Tsirkin wrote: On Tue, Apr 09, 2019 at 01:58:50PM +0800, Jason Wang wrote: We used to set backend unconditionally, this won't work for some guests (e.g windows driver) who may not initialize all virtqueues. For kernel backend, this will fail since it may try to

Re: [Qemu-devel] [RFC PATCH v1 00/10] Add AMD SEV guest live migration support

2019-04-24 Thread Singh, Brijesh
On 4/24/19 7:18 PM, Steve Rutherford wrote: > Do you mean MiB/s, MB/s or Mb/s? Since you are talking about network > speeds, sometimes these get conflated. It's megabits/sec. The QMP query-migration command shows the throughput in Mbits/s. It includes PSP command execution and the network write.

Re: [Qemu-devel] [PATCH] mips: Fix "Unexpected FPU mode"

2019-04-24 Thread Daniel Santos
Hello, Sorry for my slow reply.  I don't mind that, as long as I end up being shown as the author in git. :)  I've never committed from an email before, so I'm not sure how that works.  Does adding another "From: " header in the body patch that up with git-am? I don't know how much I'll be contri

Re: [Qemu-devel] [RFC PATCH v1 00/10] Add AMD SEV guest live migration support

2019-04-24 Thread Steve Rutherford via Qemu-devel
Do you mean MiB/s, MB/s or Mb/s? Since you are talking about network speeds, sometimes these get conflated. I'm guessing you mean MB/s since you are also using 4kb for page size. On Wed, Apr 24, 2019 at 2:32 PM Singh, Brijesh wrote: > > > On 4/24/19 2:15 PM, Steve Rutherford wrote: > > On Wed,

[Qemu-devel] [PATCH v2] hmp: delvm: use hmp_handle_error

2019-04-24 Thread Cole Robinson
This gives us the consistent 'Error:' prefix added in 66363e9a43f, which helps users like libvirt who still need to scrape hmp error messages to detect failure. Reviewed-by: Eric Blake Signed-off-by: Cole Robinson --- v2: Drop now redundant "Error while" string prefix hmp.c | 7 --- 1

Re: [Qemu-devel] [PATCH 4/6] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD

2019-04-24 Thread Wainer dos Santos Moschetta
Hello Thomas, On 04/24/2019 07:37 AM, Thomas Huth wrote: We are going to enable the qemu-iotests during "make check" again, and for running the iotests, we need bash and gnu-sed. Signed-off-by: Thomas Huth --- .cirrus.yml | 4 ++-- .travis.yml | 1 + 2 files changed, 3 insertions(+), 2 del

Re: [Qemu-devel] [RFC PATCH v1 00/10] Add AMD SEV guest live migration support

2019-04-24 Thread Singh, Brijesh
On 4/24/19 2:15 PM, Steve Rutherford wrote: > On Wed, Apr 24, 2019 at 9:10 AM Singh, Brijesh wrote: >> >> The series add support for AMD SEV guest live migration commands. To protect >> the >> confidentiality of an SEV protected guest memory while in transit we need to >> use the SEV commands d

[Qemu-devel] [Bug 1823458] Please test proposed package

2019-04-24 Thread Corey Bryant
Hello Dan, or anyone else affected, Accepted qemu into ocata-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository. Please help us by testing this new package. To enable the -proposed repository: sudo add-apt-repo

[Qemu-devel] [Bug 1823458] Please test proposed package

2019-04-24 Thread Corey Bryant
Hello Dan, or anyone else affected, Accepted qemu into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository. Please help us by testing this new package. To enable the -proposed repository: sudo add-apt-rep

Re: [Qemu-devel] [PATCH 5/6] tests: Run the iotests during "make check" again

2019-04-24 Thread Wainer dos Santos Moschetta
Hi Thomas, On 04/24/2019 07:37 AM, Thomas Huth wrote: People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet. Now that we've got a new "ci" group of iotests that

Re: [Qemu-devel] [RFC PATCH v1 00/10] Add AMD SEV guest live migration support

2019-04-24 Thread Steve Rutherford via Qemu-devel
On Wed, Apr 24, 2019 at 9:10 AM Singh, Brijesh wrote: > > The series add support for AMD SEV guest live migration commands. To protect > the > confidentiality of an SEV protected guest memory while in transit we need to > use the SEV commands defined in SEV API spec [1]. > > SEV guest VMs have th

[Qemu-devel] [PATCH v5 17/21] gdbstub: Implement v commands with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 809503c20a..7bc00d7f77 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1816,6 +1816,106 @@ static void handl

[Qemu-devel] [PATCH v5 20/21] gdbstub Implement target halted (? pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 779da2aa77..8838241209 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2248,13 +2248,30 @@ static void handle_gen_set(GdbCmdCont

[Qemu-devel] [PATCH v5 14/21] gdbstub: Implement read all registers (g pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index acf0e75908..3a7ef5eea6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1758,6 +1758,21 @@ static void handle_write_all_regs(GdbCmdCont

[Qemu-devel] [PATCH v5 19/21] gdbstub: Implement generic set (Q pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 213 +++--- 1 file changed, 25 insertions(+), 188 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a2db1ec661..779da2aa77 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1130,14 +1130,6 @@ static GDBThreadId

[Qemu-devel] [PATCH v5 13/21] gdbstub: Implement write all registers (G pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 5b60c1369c..acf0e75908 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1735,6 +1735,29 @@ static void handle_read_mem(GdbCm

[Qemu-devel] [PATCH v5 16/21] gdbstub: Implement step (s pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 18949120be..809503c20a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1806,6 +1806,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx,

[Qemu-devel] [PATCH v5 21/21] gdbstub: Clear unused variables in gdb_handle_packet

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8838241209..32aeefbbe6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2268,17 +2268,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void *us

[Qemu-devel] [PATCH v5 12/21] gdbstub: Implement read memory (m pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 4522c93fa2..5b60c1369c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1711,6 +1711,30 @@ static void handle_write_m

[Qemu-devel] [PATCH v5 08/21] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 49 - 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8e0446d305..80f2a92da6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1612,6 +1612,29 @@ static void handle_insert

[Qemu-devel] [PATCH v5 15/21] gdbstub: Implement file io (F pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 62 +++ 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3a7ef5eea6..18949120be 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1773,6 +1773,39 @@ static void handle_

[Qemu-devel] [PATCH v5 11/21] gdbstub: Implement write memory (M pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c439b8e796..4522c93fa2 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1686,6 +1686,31 @@ static void handle_get_

[Qemu-devel] [PATCH v5 18/21] gdbstub: Implement generic query (q pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 335 ++ 1 file changed, 335 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 7bc00d7f77..a2db1ec661 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1916,6 +1916,331 @@ static void handle_v_commands(GdbC

[Qemu-devel] [PATCH v5 10/21] gdbstub: Implement get register (p pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 49db09ef52..c439b8e796 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1656,6 +1656,36 @@ static void handle_set_r

[Qemu-devel] [PATCH v5 06/21] gdbstub: Implement set_thread (H pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 79 ++- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8e922a2df4..83757def9b 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1548,6 +1548,47 @@ static void handle_

[Qemu-devel] [PATCH v5 05/21] gdbstub: Implement continue with signal (C pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a38f9d4ef9..8e922a2df4 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1533,6 +1533,21 @@ static void handle_continue(GdbCmdContext *gd

[Qemu-devel] [PATCH v5 07/21] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 33 + 1 file changed, 33 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 83757def9b..8e0446d305 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1589,6 +1589,29 @@ static void handle_set_thread(GdbCmdContext *gdb_ctx, voi

[Qemu-devel] [PATCH v5 03/21] gdbstub: Implement thread_alive (T pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index fdad1ac466..29ca6be3df 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1499,6 +1499,30 @@ static void handle_detach(GdbCm

[Qemu-devel] [PATCH v5 01/21] gdbstub: Add infrastructure to parse cmd packets

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 200 ++ 1 file changed, 200 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..3308279fa8 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,206 @@ out: return res; } +typede

[Qemu-devel] [PATCH v5 04/21] gdbstub: Implement continue (c pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 29ca6be3df..a38f9d4ef9 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1523,6 +1523,16 @@ static void handle_thread_alive(GdbCmdContext *gdb

[Qemu-devel] [PATCH v5 09/21] gdbstub: Implement set register (P pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 80f2a92da6..49db09ef52 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1635,6 +1635,27 @@ static void handle_remove_bp(GdbCmdC

[Qemu-devel] [PATCH v5 02/21] gdbstub: Implement deatch (D pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-otff-by: Jon Doron --- gdbstub.c | 89 +++ 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3308279fa8..fdad1ac466 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1420,10 +1420,6 @@ static inline int

[Qemu-devel] [PATCH v2 1/1] util/path: Do not cache all filenames at startup

2019-04-24 Thread Richard Henderson
If one uses -L $PATH to point to a full chroot, the startup time is significant. In addition, the existing probing algorithm fails to handle symlink loops. Instead, probe individual paths on demand. Cache both positive and negative results within $PATH, so that any one filename is probed only on

[Qemu-devel] [PATCH v2 0/1] util/path: Do not cache all filenames at startup

2019-04-24 Thread Richard Henderson
Changes for v2: Drop use of g_canonicalize_filename. While Daniel pointed out how to add stuff to glib-compat.h, full canonicalization is overkill for path() in any case. I also discovered that I'd been testing w/ glib 2.56 and so hadn't been testing the g_canonicalize_filename case anyway. Cove

Re: [Qemu-devel] [PULL 00/12] bundle edk2 platform firmware with QEMU

2019-04-24 Thread Laszlo Ersek
On 04/24/19 15:47, Peter Maydell wrote: > On Tue, 23 Apr 2019 at 18:15, Laszlo Ersek wrote: >> >> Picked up the new feedback tags from the v4 thread, which had been >> posted at: >> - https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01549.html >> - 20190409230022.6462-1-lersek@redhat.com">

[Qemu-devel] [PATCH v4 05/20] gdbstub: Implement continue with signal (C pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 47b1e7e7a4..edcb7bfd17 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1542,6 +1542,21 @@ static void handle_continue(GdbCmdContext *gd

[Qemu-devel] [PATCH v4 12/20] gdbstub: Implement read memory (m pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index f29042cac0..af37222034 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1720,6 +1720,30 @@ static void handle_write_m

[Qemu-devel] [PATCH v4 03/20] gdbstub: Implement thread_alive (T pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 952a6d92ef..7704edd69c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1508,6 +1508,30 @@ static void handle_detach(GdbCm

[Qemu-devel] [PATCH v4 07/20] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 33 + 1 file changed, 33 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index c1ec36a062..03553a1a32 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1598,6 +1598,29 @@ static void handle_set_thread(GdbCmdContext *gdb_ctx, voi

[Qemu-devel] [PATCH v4 11/20] gdbstub: Implement write memory (M pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 58b665d303..f29042cac0 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1695,6 +1695,31 @@ static void handle_get_

[Qemu-devel] [PATCH v4 04/20] gdbstub: Implement continue (c pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 7704edd69c..47b1e7e7a4 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1532,6 +1532,16 @@ static void handle_thread_alive(GdbCmdContext *gdb

[Qemu-devel] [PATCH v4 15/20] gdbstub: Implement file io (F pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 62 +++ 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b9ac9401ed..772bcd2e1f 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1782,6 +1782,39 @@ static void handle_

[Qemu-devel] [PATCH v4 02/20] gdbstub: Implement deatch (D pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-otff-by: Jon Doron --- gdbstub.c | 82 +-- 1 file changed, 43 insertions(+), 39 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 64680722fc..952a6d92ef 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1429,10 +1429,6 @@ static inline int

[Qemu-devel] [PATCH v4 09/20] gdbstub: Implement set register (P pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b5d568603c..d3d688a747 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1644,6 +1644,27 @@ static void handle_remove_bp(GdbCmdC

[Qemu-devel] [PATCH v4 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 209 ++ 1 file changed, 209 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..64680722fc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,215 @@ out: return res; } +typede

[Qemu-devel] [PATCH v4 06/20] gdbstub: Implement set_thread (H pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 79 ++- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index edcb7bfd17..c1ec36a062 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1557,6 +1557,47 @@ static void handle_

[Qemu-devel] [PATCH v4 14/20] gdbstub: Implement read all registers (g pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 084c688f75..b9ac9401ed 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1767,6 +1767,21 @@ static void handle_write_all_regs(GdbCmdCont

[Qemu-devel] [PATCH v4 18/20] gdbstub: Implement generic query (q pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 335 ++ 1 file changed, 335 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 8c79e36923..8de4e09caa 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1925,6 +1925,331 @@ static void handle_v_commands(GdbC

[Qemu-devel] [PATCH v4 10/20] gdbstub: Implement get register (p pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d3d688a747..58b665d303 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1665,6 +1665,36 @@ static void handle_set_r

[Qemu-devel] [PATCH v4 16/20] gdbstub: Implement step (s pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 772bcd2e1f..265a6e3aeb 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1815,6 +1815,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx,

[Qemu-devel] [PATCH v4 08/20] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 49 - 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 03553a1a32..b5d568603c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1621,6 +1621,29 @@ static void handle_insert

[Qemu-devel] [PATCH v4 20/20] gdbstub: Refactor parse handle packet to work with a static array

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 386 ++ 1 file changed, 158 insertions(+), 228 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 61ab630d9e..69b3a5185e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2257,240 +2257,170 @@ static void ha

[Qemu-devel] [PATCH v4 19/20] gdbstub: Implement generic set (Q pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 213 +++--- 1 file changed, 25 insertions(+), 188 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8de4e09caa..61ab630d9e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1130,14 +1130,6 @@ static GDBThreadId

[Qemu-devel] [PATCH v4 17/20] gdbstub: Implement v commands with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 265a6e3aeb..8c79e36923 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1825,6 +1825,106 @@ static void handl

[Qemu-devel] [PATCH v4 13/20] gdbstub: Implement write all registers (G pkt) with new infra

2019-04-24 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index af37222034..084c688f75 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1744,6 +1744,29 @@ static void handle_read_mem(GdbCm

Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct

2019-04-24 Thread Eduardo Habkost
On Wed, Apr 24, 2019 at 09:26:52AM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 23, 2019 at 06:22:44PM -0300, Eduardo Habkost wrote: > > This struct will be used to represent support and deprecation > > status of QEMU features. > > > > Signed-off-by: Eduardo Habkost > > --- > > qapi/common.jso

Re: [Qemu-devel] [PATCH 2/3] machine: Use SupportStatusInfo for deprecation info

2019-04-24 Thread Eduardo Habkost
On Wed, Apr 24, 2019 at 09:23:09AM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 23, 2019 at 06:22:45PM -0300, Eduardo Habkost wrote: > > Use SupportStatusInfo to represent deprecation information of > > machine types. > > > > Instead of using a generic "use XXX instead" message for humans, > > e

Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct

2019-04-24 Thread Eduardo Habkost
On Wed, Apr 24, 2019 at 12:23:33AM +0200, Philippe Mathieu-Daudé wrote: > Hi Eduardo, > > On 4/23/19 11:22 PM, Eduardo Habkost wrote: > > This struct will be used to represent support and deprecation > > status of QEMU features. > > Excellent idea! > > > > > Signed-off-by: Eduardo Habkost > >

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-04-24 Thread Eduardo Habkost
On Wed, Apr 24, 2019 at 09:31:13AM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: > > On 23/04/2019 23.22, Eduardo Habkost wrote: > > > This series adds machine type deprecation information to the > > > output of the `query-machines` QMP command. Wi

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-04-24 Thread Eduardo Habkost
On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: > On 23/04/2019 23.22, Eduardo Habkost wrote: > > This series adds machine type deprecation information to the > > output of the `query-machines` QMP command. With this, libvirt > > and management software will be able to show this infor

Re: [Qemu-devel] [PATCH v3 02/20] gdbstub: Implement deatch (D pkt) with new infra

2019-04-24 Thread Richard Henderson
On 4/24/19 7:26 AM, ari...@gmail.com wrote: > +{ > +static GdbCmdParseEntry deatch_cmd_desc = { static const. s/deatch/detach/. That'll require changes to patch 1, since process_string_cmd doesn't take a const GdbCmdParseEntry pointer. > +.handler = handle_de

Re: [Qemu-devel] [PATCH v3 20/20] gdbstub: Refactor parse handle packet to work with a static array

2019-04-24 Thread Richard Henderson
On 4/24/19 7:27 AM, ari...@gmail.com wrote: > +static GdbCmdParseEntry gdb_packet_table[0x100] = { 21 out of 256 entries used? That's a pretty poor occupancy rate. What was wrong with the switch statement? Or a modified version in which you sink the call to process_string_cmd and only load the p

Re: [Qemu-devel] [PATCH v3 2/2] core/qdev: refactor qdev_get_machine() with type assertion

2019-04-24 Thread Eduardo Habkost
On Tue, Apr 23, 2019 at 03:59:31PM +0800, Like Xu wrote: > On 2019/4/18 1:10, Eduardo Habkost wrote: > > On Wed, Apr 17, 2019 at 07:14:10AM +0200, Markus Armbruster wrote: > > > Eduardo Habkost writes: > > > > > > > On Mon, Apr 15, 2019 at 03:59:45PM +0800, Like Xu wrote: > > > > > To avoid the m

Re: [Qemu-devel] [PATCH v3 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-24 Thread Richard Henderson
On 4/24/19 7:26 AM, ari...@gmail.com wrote: > +static const char *cmd_next_param(const char *param, const char delimiter) > +{ > +const char *delim; > +static char all_delimiters[] = ",;:="; static const char > +static char no_delimiter[] = "\0"; > +char curr_delimiters[2] = {0};

Re: [Qemu-devel] [PATCH] virtio: clarify VirtioPCIDeviceTypeInfo usage

2019-04-24 Thread Eduardo Habkost
On Wed, Apr 24, 2019 at 04:24:01PM +0100, Stefan Hajnoczi wrote: > How to use .base_name, .generic_name, .transitional_name, and > .non_transitional_name can be confusing. > > Existing devices have .generic_name but its behavior is somewhat magic. > > Devices added to new versions of the VIRTIO s

Re: [Qemu-devel] [PATCH v1] gdbstub: Refactor gdb packets handler

2019-04-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190424124414.17775-1-ari...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time ma

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-04-24 Thread Dan Streetman
** Patch added: "lp1823458-ocata.debdiff" https://bugs.launchpad.net/cloud-archive/+bug/1823458/+attachment/5258683/+files/lp1823458-ocata.debdiff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/182

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-04-24 Thread Dan Streetman
uca: workaround patches are needed in mitaka and ocata. Mitaka can pull from Xenial build as usual, and debdiff for Ocata attached. Other UCA releases are later than 2.9 and so are fixed with the upstream fix mentioned in the description. -- You received this bug notification because you are a

Re: [Qemu-devel] [PATCH v2 0/3] vhost-scsi: Support migration

2019-04-24 Thread Liran Alon
> On 18 Apr 2019, at 12:41, Stefan Hajnoczi wrote: > > On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: >> Hi, >> >> This patch series aims to add supprot to migrate a VM with a vhost-scsi >> device. >> >> The 1st patch fixes a bug of mistakenly not stopping vhost-scsi backend wh

Re: [Qemu-devel] [PATCH v4 02/11] block: Filtered children access functions

2019-04-24 Thread Max Reitz
On 19.04.19 12:23, Vladimir Sementsov-Ogievskiy wrote: > 17.04.2019 19:22, Max Reitz wrote: >> On 16.04.19 12:02, Vladimir Sementsov-Ogievskiy wrote: >>> 10.04.2019 23:20, Max Reitz wrote: What bs->file and bs->backing mean depends on the node. For filter nodes, both signify a node that

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-04-24 Thread Corey Bryant
** Also affects: cloud-archive/ocata Importance: Undecided Status: New ** Changed in: cloud-archive/ocata Importance: Undecided => Medium ** Changed in: cloud-archive/ocata Status: New => Triaged ** Changed in: cloud-archive Status: New => Fix Released -- You receive

[Qemu-devel] [RFC PATCH v1 06/10] KVM: SVM: Add KVM_SEV_RECEIVE_FINISH command

2019-04-24 Thread Singh, Brijesh
The command finalize the guest receiving process and make the SEV guest ready for the execution. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Paolo Bonzini Cc: "Radim Krčmář" Cc: Joerg Roedel Cc: Borislav Petkov Cc: Tom Lendacky Cc: x...@kernel.org Cc: k...@vger.kernel.org

[Qemu-devel] [RFC PATCH v1 03/10] KVM: SVM: Add KVM_SEV_SEND_FINISH command

2019-04-24 Thread Singh, Brijesh
The command is used to finailize the encryption context created with KVM_SEV_SEND_START command. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Paolo Bonzini Cc: "Radim Krčmář" Cc: Joerg Roedel Cc: Borislav Petkov Cc: Tom Lendacky Cc: x...@kernel.org Cc: k...@vger.kernel.org

[Qemu-devel] [RFC PATCH v1 08/10] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall

2019-04-24 Thread Singh, Brijesh
The hypercall can be used by the SEV guest to notify the page encryption status to the hypervisor. The hypercall should be invoked only when the encryption attribute is changed from encrypted -> decrypted and vice versa. By default all the guest pages should be considered encrypted. Cc: Thomas Gle

[Qemu-devel] [RFC PATCH v1 09/10] KVM: x86: Introduce KVM_GET_PAGE_ENC_BITMAP ioctl

2019-04-24 Thread Singh, Brijesh
The ioctl can be used to retrieve page encryption bitmap for a given kvm memory slot. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Paolo Bonzini Cc: "Radim Krčmář" Cc: Joerg Roedel Cc: Borislav Petkov Cc: Tom Lendacky Cc: x...@kernel.org Cc: k...@vger.kernel.org Cc: linux-k

[Qemu-devel] [RFC PATCH v1 07/10] KVM: x86: Add AMD SEV specific Hypercall3

2019-04-24 Thread Singh, Brijesh
KVM hypercall framework relies on alternative framework to patch the VMCALL -> VMMCALL on AMD platform. If a hypercall is made before apply_alternative() is called then it defaults to VMCALL. The approach works fine on non SEV guest. A VMCALL would causes #UD, and hypervisor will be able to decode

  1   2   3   >