Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-04-21 Thread Leon Romanovsky
On Fri, Apr 19, 2019 at 01:16:06PM +0200, Hannes Reinecke wrote: > On 4/15/19 12:35 PM, Yuval Shaia wrote: > > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > > > On Thu, 11 Apr 2019 14:01:54 +0300 > > > Yuval Shaia wrote: > > > > > > > Data center backends use more and more RDMA

Re: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix absolute and relative input issues on Mojave

2019-04-21 Thread Chen Zhang via Qemu-devel
Ping https://patchwork.kernel.org/patch/10888727/ https://patchwork.kernel.org/patch/10888725/ > On Apr 8, 2019, at 10:04 AM, Chen Zhang wrote: > > The following patches fixed absolute and relative

Re: [Qemu-devel] [PATCH] hvf: Add missing break statement

2019-04-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/087f1d9c-109d-41d1-be2c-ce5d840c9...@me.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 087f1d9c-109d-41d1-be2c-ce5d840c9...@me.com Subject: [Qemu-devel] [PATCH] hvf: Add missi

[Qemu-devel] [PATCH] hvf: Add missing break statement

2019-04-21 Thread Chen Zhang via Qemu-devel
In target/i386/hvf/hvf.c, a break statement was probably missing in `hvf_vcpu_exec()`, in handling EXIT_REASON_HLT. These lines seemed to be equivalent to `kvm_handle_halt()`. Signed-off-by: Chen Zhang --- target/i386/hvf/hvf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/hv

Re: [Qemu-devel] [PATCH 1/2] add VirtIONet vhost_stopped flag to prevent multiple stops

2019-04-21 Thread Jason Wang
On 2019/4/17 上午2:46, Dan Streetman wrote: From: Dan Streetman Buglink: https://launchpad.net/bugs/1823458 There is a race condition when using the vhost-user driver, between a guest shutdown and the vhost-user interface being closed. This is explained in more detail at the bug link above; t

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-04-21 Thread Xiang Zheng
Ping? On 2019/4/15 10:39, Xiang Zheng wrote: > On 2019/4/12 18:57, Kevin Wolf wrote: >> Am 12.04.2019 um 11:50 hat Xiang Zheng geschrieben: >>> >>> On 2019/4/12 9:52, Xiang Zheng wrote: On 2019/4/11 20:22, Kevin Wolf wrote: > Okay, so your problem is that blk_pread() writes to the whole b

Re: [Qemu-devel] [PATCH v2 2/3] edu: mmio: allow mmio read dispatch accept 8 bytes

2019-04-21 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年4月21日周日 下午6:44写道: > Hi Li, > > On 4/20/19 6:14 PM, Li Qiang wrote: > > The edu spec said when address >= 0x80, the MMIO area can > > "says" > > > be accessed by 8 bytes. > > > > Signed-off-by: Li Qiang > > --- > > hw/misc/edu.c | 4 > > 1 file changed, 4 insert

Re: [Qemu-devel] [PATCH v2 3/3] edu: uses uint64_t in dma operation

2019-04-21 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年4月21日周日 下午6:32写道: > On 4/20/19 6:14 PM, Li Qiang wrote: > > The dma related variable is dma_addr_t, it is uint64_t in > > x64 platform. Change these usage from uint32_to uint64_t to > > avoid trancation. > > "to avoid address truncation"? > > The dma.dst/src/cnt..is

Re: [Qemu-devel] [PATCH v2 1/3] edu: mmio: set 'max_access_size' to 8

2019-04-21 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年4月21日周日 下午6:28写道: > Hi Li, > > The patch title is not very descriptive, maybe "allow 64-bit access" > > > On 4/20/19 6:14 PM, Li Qiang wrote: > > The edu spec said, the MMIO area can be accessed by 8 bytes. > > or 64-bit... > > > However currently the 'max_access_size

Re: [Qemu-devel] [PATCH 0/6] Refine exec

2019-04-21 Thread Wei Yang
Ping for this trivial series. On Thu, Mar 21, 2019 at 04:25:49PM +0800, Wei Yang wrote: >This serial refine exec a little. > >Wei Yang (6): > exec.c: replace hwaddr with uint64_t for better understanding > exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in >phys_map_node_alloc() >

[Qemu-devel] [PATCH v14 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-21 Thread Wei Yang
From: Zhang Yi When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition which can ensure file system metadata synced in each guest writes to the backend file, without other QEMU actions (e.g., periodic fsync() by QEMU). Current, We have below different possib

[Qemu-devel] [PATCH v14 2/2] docs: Added MAP_SYNC documentation

2019-04-21 Thread Wei Yang
From: Zhang Yi Signed-off-by: Zhang Yi --- docs/nvdimm.txt | 22 +++--- qemu-options.hx | 5 + 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt index 7231c2d78f..bcd1456e72 100644 --- a/docs/nvdimm.txt +++ b/docs/nvdimm.txt @

[Qemu-devel] [PATCH v14 0/2] support MAP_SYNC for memory-backend-file

2019-04-21 Thread Wei Yang
Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to guarantee the write persistence to mmap'ed files supporting DAX (e.g., files on ext4/xfs file system mounted with '-o dax'). A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at https://patchwork.kernel.org/patch

Re: [Qemu-devel] [PATCH V13 4/5] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-21 Thread Wei Yang
On Thu, Apr 18, 2019 at 07:33:01PM -0300, Eduardo Habkost wrote: >On Thu, Apr 18, 2019 at 07:05:16PM -0300, Eduardo Habkost wrote: >> Hi, >> >> I found out that this series missed QEMU 4.0 and I was going to >> queue for 4.1, but unfortunately this patch conflicts with: >> >> commit 2044c3e7116ee

[Qemu-devel] [Bug 1758819] Re: HVF Illegal instruction: 4, High Sierra, v2.12-rc0

2019-04-21 Thread MIke Pestorich
According to the response here: https://www.mail-archive.com/qemu- de...@nongnu.org/msg572220.html ...the call to xgetbv should be guarded against processors that don't support the instruction. The attached patch seems to work for me but must admit I am way out of my depth here (I understand nothi

[Qemu-devel] [Bug 1824768] Re: Qemu ARMv7 TCG MultiThreading for i386 guest doesn't work

2019-04-21 Thread Richard Henderson
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1824768 Title: Qemu ARMv7 TCG MultiThreading for i386 guest doesn't work Status in QEMU: Incomp

Re: [Qemu-devel] [PATCH 1/2] tests: fw_cfg: add a function to get the fw_cfg file

2019-04-21 Thread Philippe Mathieu-Daudé
Hi Thomas, On 4/19/19 9:03 AM, Thomas Huth wrote: > On 19/03/2019 03.30, Li Qiang wrote: >> This is useful to write qtest about fw_cfg file entry. >> >> Signed-off-by: Li Qiang >> --- >> tests/libqos/fw_cfg.c | 45 +++ >> tests/libqos/fw_cfg.h | 2 ++ >>

[Qemu-devel] [Bug 1824768] Re: Qemu ARMv7 TCG MultiThreading for i386 guest doesn't work

2019-04-21 Thread Richard Henderson
When you say > ./qemu-system-i386 -cdrom alpine.iso --accel tcg,thread=multi you have not created multiple cpus for the guest, so thread=multi should have no effect. For what it's worth, a boot of debian-9.8.0-i386-netinst.iso (which is what I happened to have handy) works fine with ./qemu-s

Re: [Qemu-devel] [PATCH] libvhost-user: fix bad vu_log_write

2019-04-21 Thread Marc-André Lureau
On Sat, Apr 20, 2019 at 11:11 AM Li Feng wrote: > > Mark dirty as page, the step of each call is 1. > > Signed-off-by: Li Feng Reviewed-by: Marc-André Lureau > --- > contrib/libvhost-user/libvhost-user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/libvhost

Re: [Qemu-devel] [PATCH] cputlb: Fix io_readx() to respect the access_type

2019-04-21 Thread Peter Maydell
On Sun, 21 Apr 2019 at 09:03, Shahab Vahedi wrote: > > Hi Peter, > > On Sat, Apr 20, 2019 at 07:57:31PM +0100, Peter Maydell wrote: > > On Fri, 19 Apr 2019 at 12:46, Shahab Vahedi wrote: > > > > > > This change adapts io_readx() to its input access_type. Currently > > > io_readx() treats any memo

[Qemu-devel] [Bug 1793904] Re: files are randomly overwritten by Zero Bytes

2019-04-21 Thread Hans
I will have to put more efford into that: The bug applies to oVirt 4.3 too which seems to use a fuse filesystem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1793904 Title: files are randomly over

Re: [Qemu-devel] [PATCH v2 2/3] edu: mmio: allow mmio read dispatch accept 8 bytes

2019-04-21 Thread Philippe Mathieu-Daudé
Hi Li, On 4/20/19 6:14 PM, Li Qiang wrote: > The edu spec said when address >= 0x80, the MMIO area can "says" > be accessed by 8 bytes. > > Signed-off-by: Li Qiang > --- > hw/misc/edu.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/misc/edu.c b/hw/misc/edu.c > index 65fc32b

Re: [Qemu-devel] [PATCH v2 3/3] edu: uses uint64_t in dma operation

2019-04-21 Thread Philippe Mathieu-Daudé
On 4/20/19 6:14 PM, Li Qiang wrote: > The dma related variable is dma_addr_t, it is uint64_t in > x64 platform. Change these usage from uint32_to uint64_t to > avoid trancation. "to avoid address truncation"? > > Signed-off-by: Li Qiang > --- > Change since v1: > Fix format compile error on Win

Re: [Qemu-devel] [PATCH v2 1/3] edu: mmio: set 'max_access_size' to 8

2019-04-21 Thread Philippe Mathieu-Daudé
Hi Li, The patch title is not very descriptive, maybe "allow 64-bit access" On 4/20/19 6:14 PM, Li Qiang wrote: > The edu spec said, the MMIO area can be accessed by 8 bytes. or 64-bit... > However currently the 'max_access_size' is not so the MMIO > access dispatch can only access 4 bytes one

Re: [Qemu-devel] [PATCH v2] net/colo-compare.c: Fix a crash in COLO Primary.

2019-04-21 Thread Philippe Mathieu-Daudé
On 4/20/19 7:14 PM, Lukas Straub wrote: > From: Lukas Straub > Because event_unhandled_count may be accessed concurrently, it needs > to be protected by taking the lock. However the assert is outside the > lock, probably causing it to read garbage and aborting Qemu erroneously. > > The Bug only h

Re: [Qemu-devel] [PATCH] cputlb: Fix io_readx() to respect the access_type

2019-04-21 Thread Shahab Vahedi
Hi Peter, On Sat, Apr 20, 2019 at 07:57:31PM +0100, Peter Maydell wrote: > On Fri, 19 Apr 2019 at 12:46, Shahab Vahedi wrote: > > > > This change adapts io_readx() to its input access_type. Currently > > io_readx() treats any memory access as a read, although it has an > > input argument "MMUAcce

[Qemu-devel] [Bug 1824622] Re: Qemu 4.0.0-rc3 COLO Primary Crashes with "Assertion `event_unhandled_count > 0' failed."

2019-04-21 Thread Lukas Straub
There is a Patch available which fixes this bug: https://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg03497.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1824622 Title: Qemu 4.0.0-rc3 C