Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-27 Thread Xiao Guangrong
On 3/27/19 5:41 PM, Stefano Garzarella wrote: Hi Yang, Xiao, Just adding few things, because I'm currently exploring the QEMU modules in order to reduce the boot time and the footprint. Hi Stefan Hajnoczi and Stefano Garzarella, The work exploring the QEMU modules looks really good. we wil

Re: [Qemu-devel] [PATCH v7 6/6] migration: Block migration while handling machine check

2019-03-27 Thread Aravinda Prasad
On Thursday 28 March 2019 06:18 AM, David Gibson wrote: > On Tue, Mar 26, 2019 at 12:22:50PM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 26 March 2019 09:49 AM, David Gibson wrote: >>> On Mon, Mar 25, 2019 at 02:31:10PM +0530, Aravinda Prasad wrote: On Monday 25 March 2019 1

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-27 Thread Aravinda Prasad
On Thursday 28 March 2019 06:20 AM, David Gibson wrote: > On Wed, Mar 27, 2019 at 12:18:31PM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 26 March 2019 03:35 PM, Greg Kurz wrote: >>> On Tue, 26 Mar 2019 14:45:57 +0530 >>> Aravinda Prasad wrote: >>> On Tuesday 26 March 2019 02:00 PM, G

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-27 Thread Aravinda Prasad
On Wednesday 27 March 2019 08:16 PM, Greg Kurz wrote: > On Wed, 27 Mar 2019 12:18:31 +0530 > Aravinda Prasad wrote: > >> On Tuesday 26 March 2019 03:35 PM, Greg Kurz wrote: >>> On Tue, 26 Mar 2019 14:45:57 +0530 >>> Aravinda Prasad wrote: >>> On Tuesday 26 March 2019 02:00 PM, Greg Ku

Re: [Qemu-devel] [PATCH] block/file-posix: ignore fail on unlock bytes

2019-03-27 Thread Fam Zheng
On Wed, 03/27 15:49, Vladimir Sementsov-Ogievskiy wrote: > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > loosening permissions. However file-locking operations may fail even > in this case, for example on NFS. And this leads to Qemu crash. > > Let's ignore such errors, as we d

Re: [Qemu-devel] intel_iommu migration compatibiltiy for scalable mode emulation

2019-03-27 Thread Peter Xu
On Wed, Mar 27, 2019 at 06:17:08PM -0400, Michael S. Tsirkin wrote: > On Wed, Mar 27, 2019 at 08:02:24PM +, Dr. David Alan Gilbert wrote: > > (Oops, originally forgot to cc the list) > > > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > Hi, > > > Commit fb43cf739 introduced a n

[Qemu-devel] [PATCH 0/2] arm: aspeed: Add RTC Model

2019-03-27 Thread Joel Stanley
A model for the ASPEED BMC real time clock (RTC). The model is sufficient for running the guest Linux kernel driver, and ticks in time with the host when programmed. It does not implement the alarm functionality, which includes the interrupt. Joel Stanley (2): hw: timer: Add ASPEED RTC device

[Qemu-devel] [PATCH 1/2] hw: timer: Add ASPEED RTC device

2019-03-27 Thread Joel Stanley
Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/timer/Makefile.objs| 2 +- hw/timer/aspeed_rtc.c | 157 ++ hw/timer/trace-events | 4 + include/hw/timer/aspeed_rtc.h | 31 +++ 4 files changed, 193 insertions(+),

[Qemu-devel] [PATCH 2/2] hw/arm/aspeed: Add RTC to SoC

2019-03-27 Thread Joel Stanley
Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/arm/aspeed_soc.c | 15 +++ include/hw/arm/aspeed_soc.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index a27233d4876b..628ec633c91a 100644 --- a/hw/arm/as

[Qemu-devel] [PATCH for-4.0] spapr: Simplify handling of host-serial and host-model values

2019-03-27 Thread David Gibson
27461d69a0f "ppc: add host-serial and host-model machine attributes (CVE-2019-8934)" introduced 'host-serial' and 'host-model' machine properties for spapr to explicitly control the values advertised to the guest in device tree properties with the same names. The previous behaviour on KVM was to u

Re: [Qemu-devel] [PATCH for 4.0 v1 1/5] riscv: plic: Fix incorrect irq calculation

2019-03-27 Thread Palmer Dabbelt
On Wed, 27 Mar 2019 09:29:56 PDT (-0700), alistai...@gmail.com wrote: On Wed, Mar 27, 2019 at 3:29 AM Palmer Dabbelt wrote: On Wed, 20 Mar 2019 17:46:09 PDT (-0700), Alistair Francis wrote: > The irq is incorrectly calculated to be off by one. It has worked in the > past as the priority_base o

Re: [Qemu-devel] [PATCH for 4.0 v2 0/2] Update the QEMU PLIC addresses

2019-03-27 Thread Palmer Dabbelt
On Wed, 27 Mar 2019 11:51:15 PDT (-0700), Alistair Francis wrote: This series updates the PLIC address to match the documentation. This fixes: https://github.com/riscv/opensbi/issues/97 V2: - Squash patches to ensure biesctability Alistair Francis (2): riscv: plic: Fix incorrect irq calcula

Re: [Qemu-devel] [PATCH for 4.0 v2 2/2] riscv: plic: Log guest errors

2019-03-27 Thread Palmer Dabbelt
On Wed, 27 Mar 2019 11:52:53 PDT (-0700), alistai...@gmail.com wrote: On Wed, Mar 27, 2019 at 11:51 AM Alistair Francis wrote: Instead of using error_report() to print guest errors let's use qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. Signed-off-by: Alistair Francis I dropped Phil

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Peter Xu
On Wed, Mar 27, 2019 at 11:35:35AM -0400, Michael S. Tsirkin wrote: > On Wed, Mar 27, 2019 at 02:25:00PM +0800, Peter Xu wrote: > > On Tue, Mar 26, 2019 at 04:55:19PM -0600, Alex Williamson wrote: > > > Conventional PCI buses pre-date requester IDs. An IOMMU cannot > > > distinguish by devfn & bus

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Peter Xu
On Wed, Mar 27, 2019 at 10:37:09AM -0600, Alex Williamson wrote: > On Wed, 27 Mar 2019 14:25:00 +0800 > Peter Xu wrote: > > > On Tue, Mar 26, 2019 at 04:55:19PM -0600, Alex Williamson wrote: > > > Conventional PCI buses pre-date requester IDs. An IOMMU cannot > > > distinguish by devfn & bus bet

Re: [Qemu-devel] [PATCH v2] ui/cocoa: Fix absolute input device grabbing issues on Mojave

2019-03-27 Thread Chen Zhang via Qemu-devel
> On Mar 27, 2019, at 7:37 PM, Peter Maydell wrote: > > On Wed, 27 Mar 2019 at 01:09, Chen Zhang wrote: >> Just double-checked on a MacMini mid 2011 with macOS 10.13.6, Xcode 10.1. >> This NSWindow API did exist, and the patch could be built without error. >> Searching convertPointFromScreen

[Qemu-devel] [PATCH for-4.0?] nbd/client: Deal with unaligned size from server

2019-03-27 Thread Eric Blake
When a server advertises an unaligned size but no block sizes, the code was rounding up to a sector-aligned size (a known limitation of bdrv_getlength(); maybe 4.1 will fix it to be byte-accurate), then assuming a request_alignment of 512 (the recommendation of the NBD spec for maximum portability)

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-27 Thread David Gibson
On Wed, Mar 27, 2019 at 12:18:31PM +0530, Aravinda Prasad wrote: > > > On Tuesday 26 March 2019 03:35 PM, Greg Kurz wrote: > > On Tue, 26 Mar 2019 14:45:57 +0530 > > Aravinda Prasad wrote: > > > >> On Tuesday 26 March 2019 02:00 PM, Greg Kurz wrote: > >>> On Tue, 26 Mar 2019 10:32:35 +1100 > >>

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-27 Thread David Gibson
On Wed, Mar 27, 2019 at 09:06:53PM +0100, David Hildenbrand wrote: > On 27.03.19 17:45, Igor Mammedov wrote: > > On Wed, 27 Mar 2019 14:59:44 +0100 > > David Hildenbrand wrote: > > > >> Right now we configure the pagesize quite early, when initializing KVM. > >> This is long before system memory

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-27 Thread David Gibson
On Wed, Mar 27, 2019 at 02:19:41PM +0100, David Hildenbrand wrote: > On 27.03.19 10:03, David Gibson wrote: > > On Wed, Mar 27, 2019 at 09:10:01AM +0100, David Hildenbrand wrote: > >> On 27.03.19 01:12, David Gibson wrote: > >>> On Tue, Mar 26, 2019 at 06:02:51PM +0100, David Hildenbrand wrote: > >

Re: [Qemu-devel] [PATCH for-4.0] target/ppc: Fix QEMU crash with stxsdx

2019-03-27 Thread David Gibson
On Wed, Mar 27, 2019 at 07:59:12PM +, Mark Cave-Ayland wrote: > On 27/03/2019 18:12, Greg Kurz wrote: > > > I've been hitting several QEMU crashes while running a fedora29 ppc64le > > guest under TCG. Each time, this would occur several minutes after the > > guest reached login: > > > > Fedor

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-27 Thread David Gibson
On Wed, Mar 27, 2019 at 01:36:59PM +0100, Greg Kurz wrote: > On Wed, 27 Mar 2019 23:06:42 +1100 > David Gibson wrote: > > > On Wed, Mar 27, 2019 at 10:44:03AM +0100, Greg Kurz wrote: > > > On Wed, 27 Mar 2019 19:38:27 +1100 > > > David Gibson wrote: > > > > > > > On Wed, Mar 27, 2019 at 08:09

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-27 Thread David Gibson
On Wed, Mar 27, 2019 at 03:22:58PM +0100, David Hildenbrand wrote: > On 27.03.19 10:03, David Gibson wrote: > > On Wed, Mar 27, 2019 at 09:10:01AM +0100, David Hildenbrand wrote: > >> On 27.03.19 01:12, David Gibson wrote: > >>> On Tue, Mar 26, 2019 at 06:02:51PM +0100, David Hildenbrand wrote: > >

Re: [Qemu-devel] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-27 Thread David Gibson
On Wed, Mar 27, 2019 at 06:24:17PM +0100, Igor Mammedov wrote: > On Wed, 27 Mar 2019 23:03:58 +1100 > David Gibson wrote: > > > On Wed, Mar 27, 2019 at 10:38:38AM +0100, Igor Mammedov wrote: > > > On Wed, 27 Mar 2019 20:07:57 +1100 > > > David Gibson wrote: > > > > > > > On Wed, Mar 27, 2019 at

Re: [Qemu-devel] [PATCH v7 6/6] migration: Block migration while handling machine check

2019-03-27 Thread David Gibson
On Tue, Mar 26, 2019 at 12:22:50PM +0530, Aravinda Prasad wrote: > > > On Tuesday 26 March 2019 09:49 AM, David Gibson wrote: > > On Mon, Mar 25, 2019 at 02:31:10PM +0530, Aravinda Prasad wrote: > >> > >> > >> On Monday 25 March 2019 12:03 PM, David Gibson wrote: > >>> On Fri, Mar 22, 2019 at 12:

Re: [Qemu-devel] megasas: Unexpected response from lun 1 while scanning, scan aborted

2019-03-27 Thread Dongli Zhang
On 3/27/19 7:31 PM, Hannes Reinecke wrote: > On 3/26/19 5:47 PM, Dongli Zhang wrote: >> I am reporting an error that the scsi lun cannot initialize successfully >> when I >> am emulating megasas scsi controller with qemu. >> >> I am not sure if this is issue in qemu or linux kernel. >> >> When

[Qemu-devel] [Bug 1822012] [NEW] powernv machine complains of missing skiboot files

2019-03-27 Thread mcandre
Public bug reported: Hi, I want to use the powernv machine from the qemu-system-ppcle application. However, when I specify this machine, qemu complains that it can't find the skiboot files. I noticed that skiboot is available for Ubuntu, but only for the PPC[64] hosts. Well, I just need skiboot f

[Qemu-devel] [PATCH v2 1/3] iotests: Add 241 to test NBD on unaligned images

2019-03-27 Thread Eric Blake
Add a test for the NBD client workaround in the previous patch. It's not really feasible for an iotest to assume a specific tracing engine, so we can't really probe for the new trace_nbd_parse_blockstatus_compliance to see if the server was fixed vs. whether the client just worked around the serve

[Qemu-devel] [PATCH v2 2/3] block: Add bdrv_get_request_alignment()

2019-03-27 Thread Eric Blake
The next patch needs access to a device's minimum permitted alignment, since NBD wants to advertise this to clients. Add an accessor function, borrowing from blk_get_max_transfer() for accessing a backend's block limits. Signed-off-by: Eric Blake Message-Id: <20180802144834.520904-2-ebl...@redhat

[Qemu-devel] [PATCH for-4.0 v2 0/3] NBD server alignment improvement

2019-03-27 Thread Eric Blake
v1 was here (yes, blast from the past): https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg00305.html Since then: - retitle the iotest (228 is now 241) - rebase on top of other alignment fixes/workarounds that have landed in meantime - hoist test earlier, to demonstrate (according to which o

[Qemu-devel] [PATCH v2 3/3] nbd/server: Advertise actual minimum block size

2019-03-27 Thread Eric Blake
Both NBD_CMD_BLOCK_STATUS and structured NBD_CMD_READ will split their reply according to bdrv_block_status() boundaries. If the block device has a request_alignment smaller than 512, but we advertise a block alignment of 512 to the client, then this can result in the server reply violating client

Re: [Qemu-devel] intel_iommu migration compatibiltiy for scalable mode emulation

2019-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2019 at 08:02:24PM +, Dr. David Alan Gilbert wrote: > (Oops, originally forgot to cc the list) > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > Hi, > > Commit fb43cf739 introduced a new iommu migration field called > > 'root_scalable' - but it doesn't do any mach

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-27 Thread Alex Williamson
On Wed, 27 Mar 2019 20:18:54 + "Dr. David Alan Gilbert" wrote: > * Zhao Yan (yan.y.z...@intel.com) wrote: > > On Wed, Feb 20, 2019 at 07:42:42PM +0800, Cornelia Huck wrote: > > > > > > > b) How do we detect if we're migrating from/to the wrong device > > > > > > > or > > > > > > > versio

Re: [Qemu-devel] [PATCH for 4.0 v2 2/2] riscv: plic: Log guest errors

2019-03-27 Thread Philippe Mathieu-Daudé
Le mer. 27 mars 2019 19:57, Alistair Francis a écrit : > Instead of using error_report() to print guest errors let's use > qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. > > Signed-off-by: Alistair Francis > --- > hw/riscv/sifive_plic.c | 12 +--- > 1 file changed, 9 insertions(+)

Re: [Qemu-devel] [PATCH] migration: remove not used field xfer_limit

2019-03-27 Thread Wei Yang
On Wed, Mar 27, 2019 at 08:24:21PM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> MigrationState->xfer_limit is only set to 0 in migrate_init(). >> >> Remove this unnecessary field. >> >> Signed-off-by: Wei Yang > >Nice; I think that field has been unn

Re: [Qemu-devel] [Qemu-block] [PATCH] block/file-posix: ignore fail on unlock bytes

2019-03-27 Thread Eric Blake
On 3/27/19 3:33 PM, John Snow wrote: > > > On 3/27/19 8:49 AM, Vladimir Sementsov-Ogievskiy wrote: >> bdrv_replace_child() calls bdrv_check_perm() with error_abort on >> loosening permissions. However file-locking operations may fail even >> in this case, for example on NFS. And this leads to Qem

[Qemu-devel] [PATCH for-4.0] nbd-client: Work around server BLOCK_STATUS misalignment at EOF

2019-03-27 Thread Eric Blake
On 3/27/19 11:56 AM, Vladimir Sementsov-Ogievskiy wrote: > 26.03.2019 20:13, Eric Blake wrote: >> The NBD spec is clear that a server that advertises a minimum block >> size should reply to NBD_CMD_BLOCK_STATUS with extents aligned >> accordingly. However, we know that the qemu NBD server implement

[Qemu-devel] [PATCH v7 2/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-03-27 Thread Maxiwell S. Garcia
This adds a handler for ibm,get-vpd RTAS calls, allowing pseries guest to collect host information. It is disabled by default to avoid unwanted information leakage. To enable it, use: -M pseries,host-serial={passthrough|string},host-model={passthrough|string} Only the SE and TM keywords are retur

Re: [Qemu-devel] [Qemu-block] [PATCH for-4.0] qemu-img: Gracefully shutdown when map can't finish

2019-03-27 Thread John Snow
On 3/26/19 2:40 PM, Eric Blake wrote: > Trying 'qemu-img map -f raw nbd://localhost:10809' causes the > NBD server to output a scary message: > > qemu-nbd: Disconnect client, due to: Failed to read request: Unexpected > end-of-file before all bytes were read > > This is because the NBD client

[Qemu-devel] [PATCH v7 1/2] spapr: helper functions to get valid host fields

2019-03-27 Thread Maxiwell S. Garcia
The pseries options 'host-serial' and 'host-model' accepts 'none', 'passthrough', or content. The helper functions in this commit return a valid host field based on user options. Signed-off-by: Maxiwell S. Garcia Reviewed-by: Greg Kurz --- hw/ppc/spapr.c | 48 +++---

[Qemu-devel] [PATCH v7 0/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-03-27 Thread Maxiwell S. Garcia
Here are two patches to add a handler for ibm,get-vpd RTAS calls. This RTAS exposes host information in case of set QEMU options 'host-serial' and 'host-model' as 'passthrough'. The patch 1 creates helper functions to get valid 'host-serial' and 'host-model' parameters, guided by QEMU command line

Re: [Qemu-devel] [Qemu-block] [PATCH] block/file-posix: ignore fail on unlock bytes

2019-03-27 Thread John Snow
On 3/27/19 8:49 AM, Vladimir Sementsov-Ogievskiy wrote: > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > loosening permissions. However file-locking operations may fail even > in this case, for example on NFS. And this leads to Qemu crash. > > Let's ignore such errors, as we

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-27 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 27 March 2019 18:20 > To: Paul Durrant ; xen-de...@lists.xenproject.org; > qemu-bl...@nongnu.org; > qemu-devel@nongnu.org > Cc: Kevin Wolf ; Stefano Stabellini > ; Max Reitz > ; Stefan Hajnoczi ; Anthony Perard > > Subject: Re: [Xen-dev

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-27 Thread Philippe Mathieu-Daudé
Le mer. 27 mars 2019 17:06, Daniel P. Berrangé a écrit : > On Wed, Mar 27, 2019 at 04:58:23PM +0100, Paolo Bonzini wrote: > > On 27/03/19 16:30, Daniel P. Berrangé wrote: > > > Perhaps the VM test scripts should do a "HEAD" request for the image > > > every time to discover if it has been changed

Re: [Qemu-devel] [PATCH] migration: remove not used field xfer_limit

2019-03-27 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > MigrationState->xfer_limit is only set to 0 in migrate_init(). > > Remove this unnecessary field. > > Signed-off-by: Wei Yang Nice; I think that field has been unneeded since 1964a397063967 just over 5 years ago :-) Reviewed-by: Dr. David Al

Re: [Qemu-devel] [PATCH v2 1/2] block/vhdx: Remove redundant IEC binary prefixes definition

2019-03-27 Thread Philippe Mathieu-Daudé
Le mer. 27 mars 2019 18:18, John Snow a écrit : > > > On 3/27/19 5:56 AM, Stefano Garzarella wrote: > > IEC binary prefixes are already defined in "qemu/units.h", > > so we can remove redundant definitions in "block/vhdx.h". > > > > Signed-off-by: Stefano Garzarella > > --- > > block/vhdx.c | 3

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-27 Thread Dr. David Alan Gilbert
* Zhao Yan (yan.y.z...@intel.com) wrote: > On Wed, Feb 20, 2019 at 07:42:42PM +0800, Cornelia Huck wrote: > > > > > > b) How do we detect if we're migrating from/to the wrong device or > > > > > > version of device? Or say to a device with older firmware or > > > > > > perhaps > > > > > > a dev

Re: [Qemu-devel] Question about hostfwd IPv6 parameter

2019-03-27 Thread Hikmat Jafarli
Appears that this was already done in 2018 October: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg05734.html Disregard this thread, I should have searched better. On Wed, Mar 27, 2019 at 4:02 PM Hikmat Jafarli wrote: > So I'm trying to add IPv6 support to hostfwd, as requested in > ht

Re: [Qemu-devel] intel_iommu migration compatibiltiy for scalable mode emulation

2019-03-27 Thread Dr. David Alan Gilbert
(Oops, originally forgot to cc the list) * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > Hi, > Commit fb43cf739 introduced a new iommu migration field called > 'root_scalable' - but it doesn't do any machine type checks, which means > it breaks migration between 3.1<->4.0 - we should fi

Re: [Qemu-devel] 4.0->3.1 audio compat

2019-03-27 Thread Dr. David Alan Gilbert
Oops, originally didn't cc the list. * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > Hi Gerd, > I bisected a migration compatibiltiy issue down to: > bd56d378842c238c audio: fix pc speaker init > > migrating a simple VM from 4.0rc1->3.1 gives me: > ./x86_64-softmmu/qemu-system-x86

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-27 Thread David Hildenbrand
On 27.03.19 17:45, Igor Mammedov wrote: > On Wed, 27 Mar 2019 14:59:44 +0100 > David Hildenbrand wrote: > >> Right now we configure the pagesize quite early, when initializing KVM. >> This is long before system memory is actually allocated via >> memory_region_allocate_system_memory(), and theref

Re: [Qemu-devel] [PATCH for-4.0] target/ppc: Fix QEMU crash with stxsdx

2019-03-27 Thread Mark Cave-Ayland
On 27/03/2019 18:12, Greg Kurz wrote: > I've been hitting several QEMU crashes while running a fedora29 ppc64le > guest under TCG. Each time, this would occur several minutes after the > guest reached login: > > Fedora 29 (Twenty Nine) > Kernel 4.20.6-200.fc29.ppc64le on an ppc64le (hvc0) > > We

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Alex Williamson
On Wed, 27 Mar 2019 19:07:44 +0100 Auger Eric wrote: > Hi Alex, > > On 3/27/19 7:02 PM, Alex Williamson wrote: > > On Wed, 27 Mar 2019 12:46:41 +0100 > > Auger Eric wrote: > > > >> Hi Alex, > >> > >> On 3/26/19 11:55 PM, Alex Williamson wrote: > >>> Conventional PCI buses pre-date requeste

[Qemu-devel] [PATCH for 4.0 v2 1/2] riscv: plic: Fix incorrect irq calculation

2019-03-27 Thread Alistair Francis
This patch fixes four different things, to maintain bisectability they have been merged into a single patch. The following fixes are below: sifive_plic: Fix incorrect irq calculation The irq is incorrectly calculated to be off by one. It has worked in the past as the priority_base offset has also

[Qemu-devel] [PATCH for 4.0 v2 0/2] Update the QEMU PLIC addresses

2019-03-27 Thread Alistair Francis
This series updates the PLIC address to match the documentation. This fixes: https://github.com/riscv/opensbi/issues/97 V2: - Squash patches to ensure biesctability Alistair Francis (2): riscv: plic: Fix incorrect irq calculation riscv: plic: Log guest errors hw/riscv/sifive_plic.c |

[Qemu-devel] [PATCH for 4.0 v2 2/2] riscv: plic: Log guest errors

2019-03-27 Thread Alistair Francis
Instead of using error_report() to print guest errors let's use qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. Signed-off-by: Alistair Francis --- hw/riscv/sifive_plic.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/riscv/sifive_plic.c b/hw/riscv/sifiv

Re: [Qemu-devel] [PATCH for 4.0 v2 2/2] riscv: plic: Log guest errors

2019-03-27 Thread Alistair Francis
On Wed, Mar 27, 2019 at 11:51 AM Alistair Francis wrote: > > Instead of using error_report() to print guest errors let's use > qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. > > Signed-off-by: Alistair Francis I dropped Philippe's review in this series. This should be included from v1: Re

Re: [Qemu-devel] [PATCH v2 3/6] Categorize devices: DIMM

2019-03-27 Thread Ernest Esene
On Wed, Mar 27, 2019 at 01:47:48PM +0100, Philippe Mathieu-Daudé wrote: > Le mer. 27 mars 2019 13:32, Ernest Esene a écrit : > > > Set category and describe DIMM devices > > > > Signed-off-by: Ernest Esene > > > > --- > > v2: > > * split into separate patches > > --- > > hw/mem/nvdimm.c | 1

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-27 Thread Andrew Cooper
On 27/03/2019 17:32, Paul Durrant wrote: > The Xen blkif protocol is confusing but discussion with the maintainer > has clarified that sector based quantities in requests and the 'sectors' > value advertized in xenstore should always be in terms of 512-byte > units and not the advertised logical 's

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-27 Thread Wainer dos Santos Moschetta
On 03/27/2019 01:15 PM, Paolo Bonzini wrote: On 27/03/19 17:05, Daniel P. Berrangé wrote: On Wed, Mar 27, 2019 at 04:58:23PM +0100, Paolo Bonzini wrote: On 27/03/19 16:30, Daniel P. Berrangé wrote: Perhaps the VM test scripts should do a "HEAD" request for the image every time to discover i

[Qemu-devel] [PATCH v2] target/mips: add * to comments and realign them to fix checkpatch warnings

2019-03-27 Thread Jules Irenge
Add * to comments and realign to fix warnings issued by checkpatch.pl tool "WARNING: Block comments use a leading /* on a separate line" within the file "target/mips/cp0_timer.c". Signed-off-by: Jules Irenge --- This v2 improves on writing the comment style and get rid of the warnings completel

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Alex Williamson
On Wed, 27 Mar 2019 12:46:41 +0100 Auger Eric wrote: > Hi Alex, > > On 3/26/19 11:55 PM, Alex Williamson wrote: > > Conventional PCI buses pre-date requester IDs. An IOMMU cannot > > distinguish by devfn & bus between devices in a conventional PCI > > topology and therefore we cannot assign the

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Auger Eric
Hi Alex, On 3/27/19 7:02 PM, Alex Williamson wrote: > On Wed, 27 Mar 2019 12:46:41 +0100 > Auger Eric wrote: > >> Hi Alex, >> >> On 3/26/19 11:55 PM, Alex Williamson wrote: >>> Conventional PCI buses pre-date requester IDs. An IOMMU cannot >>> distinguish by devfn & bus between devices in a con

[Qemu-devel] [PATCH for-4.0] target/ppc: Fix QEMU crash with stxsdx

2019-03-27 Thread Greg Kurz
I've been hitting several QEMU crashes while running a fedora29 ppc64le guest under TCG. Each time, this would occur several minutes after the guest reached login: Fedora 29 (Twenty Nine) Kernel 4.20.6-200.fc29.ppc64le on an ppc64le (hvc0) Web console: https://localhost:9090/ localhost login: tc

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-27 Thread Paolo Bonzini
On 27/03/19 19:08, Wainer dos Santos Moschetta wrote: > > > On 03/27/2019 01:15 PM, Paolo Bonzini wrote: >> On 27/03/19 17:05, Daniel P. Berrangé wrote: >>> On Wed, Mar 27, 2019 at 04:58:23PM +0100, Paolo Bonzini wrote: On 27/03/19 16:30, Daniel P. Berrangé wrote: > Perhaps the VM test s

Re: [Qemu-devel] [PATCH 1/2] vl: Fix to create accel compat props before migration object again

2019-03-27 Thread Anthony PERARD
On Wed, Mar 27, 2019 at 04:03:46PM +0100, Markus Armbruster wrote: > Recent commit cda4aa9a5a0 moved block backend creation before machine > property evaluation. This broke block backends registering migration > blockers. Commit e60483f2f84 fixed it by moving migration object > creation before bl

[Qemu-devel] [PATCH v2 1/2] xen-block: scale sector based quantities correctly

2019-03-27 Thread Paul Durrant
The Xen blkif protocol requires that sector based quantities should be interpreted strictly as multiples of 512 bytes. Specifically: "first_sect and last_sect in blkif_request_segment, as well as sector_number in blkif_request, are always expressed in 512-byte units." This patch modifies the xen-

[Qemu-devel] [PATCH v2 2/2] xen-block: always report 'sectors' in terms of 512-byte units

2019-03-27 Thread Paul Durrant
The mail thread at [1] clarifies that the Xen blkif protocol requires that 'sectors' value reported in xenstore is strictly in terms of 512-byte units and is not dependent on the logical sector size reported in 'sector-size'. [1] https://lists.xenproject.org/archives/html/xen-devel/2019-03/msg0160

[Qemu-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-27 Thread Paul Durrant
The Xen blkif protocol is confusing but discussion with the maintainer has clarified that sector based quantities in requests and the 'sectors' value advertized in xenstore should always be in terms of 512-byte units and not the advertised logical 'sector-size' value. This series fixes xen-block t

Re: [Qemu-devel] [PATCH] block/file-posix: ignore fail on unlock bytes

2019-03-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190327124915.22265-1-vsement...@virtuozzo.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bas

Re: [Qemu-devel] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-27 Thread Igor Mammedov
On Wed, 27 Mar 2019 23:03:58 +1100 David Gibson wrote: > On Wed, Mar 27, 2019 at 10:38:38AM +0100, Igor Mammedov wrote: > > On Wed, 27 Mar 2019 20:07:57 +1100 > > David Gibson wrote: > > > > > On Wed, Mar 27, 2019 at 09:57:45AM +0100, Igor Mammedov wrote: > > > > On Wed, 27 Mar 2019 11:11:46 +1

Re: [Qemu-devel] [PATCH v2 1/2] block/vhdx: Remove redundant IEC binary prefixes definition

2019-03-27 Thread Stefano Garzarella
On Wed, Mar 27, 2019 at 01:16:49PM -0400, John Snow wrote: > > > On 3/27/19 5:56 AM, Stefano Garzarella wrote: > > IEC binary prefixes are already defined in "qemu/units.h", > > so we can remove redundant definitions in "block/vhdx.h". > > > > Signed-off-by: Stefano Garzarella > > --- > > bloc

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Alex Williamson
On Wed, 27 Mar 2019 17:43:45 +0100 Auger Eric wrote: > Hi, > > On 3/27/19 4:32 PM, Michael S. Tsirkin wrote: > > On Tue, Mar 26, 2019 at 04:55:19PM -0600, Alex Williamson wrote: > >> Conventional PCI buses pre-date requester IDs. An IOMMU cannot > >> distinguish by devfn & bus between devices

Re: [Qemu-devel] [PATCH] iotests: Fix test 200 on s390x without virtio-pci

2019-03-27 Thread John Snow
On 3/27/19 2:43 AM, Thomas Huth wrote: > virtio-pci is optional on s390x, e.g. in downstream RHEL builds, it > is disabled. On s390x, virtio-ccw should be used instead. Other tests > like 051 or 240 already use virtio-scsi-ccw instead of virtio-scsi-pci > on s390x, so let's do the same here and

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-27 Thread David Hildenbrand
On 27.03.19 18:08, Igor Mammedov wrote: > On Wed, 27 Mar 2019 15:01:37 +0100 > David Hildenbrand wrote: > >> On 27.03.19 10:09, Igor Mammedov wrote: >>> On Wed, 27 Mar 2019 09:10:01 +0100 >>> David Hildenbrand wrote: >>> On 27.03.19 01:12, David Gibson wrote: > On Tue, Mar 26, 2019 at 0

Re: [Qemu-devel] [PATCH v2 2/2] block/vhdx: Use IEC binary prefixes for size constants

2019-03-27 Thread John Snow
On 3/27/19 5:56 AM, Stefano Garzarella wrote: > Using IEC binary prefixes in order to make the code more readable, > with the exception of DEFAULT_LOG_SIZE because it's passed to > stringify(). > > Signed-off-by: Stefano Garzarella Looks good to me; Reviewed-by: John Snow

Re: [Qemu-devel] [PATCH v2 1/2] block/vhdx: Remove redundant IEC binary prefixes definition

2019-03-27 Thread John Snow
On 3/27/19 5:56 AM, Stefano Garzarella wrote: > IEC binary prefixes are already defined in "qemu/units.h", > so we can remove redundant definitions in "block/vhdx.h". > > Signed-off-by: Stefano Garzarella > --- > block/vhdx.c | 3 ++- > block/vhdx.h | 6 +- > 2 files changed, 3 insertions

Re: [Qemu-devel] [PATCH v3] configure: automatically pick python3 is available

2019-03-27 Thread Eduardo Habkost
On Wed, Mar 27, 2019 at 05:07:01PM +, Daniel P. Berrangé wrote: > Unless overridden via an env var or configure arg, QEMU will only look > for the 'python' binary in $PATH. This is unhelpful on distros which > are only shipping Python 3.x (eg Fedora) in their default install as, > if they compl

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-27 Thread Igor Mammedov
On Wed, 27 Mar 2019 15:01:37 +0100 David Hildenbrand wrote: > On 27.03.19 10:09, Igor Mammedov wrote: > > On Wed, 27 Mar 2019 09:10:01 +0100 > > David Hildenbrand wrote: > > > >> On 27.03.19 01:12, David Gibson wrote: > >>> On Tue, Mar 26, 2019 at 06:02:51PM +0100, David Hildenbrand wrote: >

[Qemu-devel] [PATCH v3] configure: automatically pick python3 is available

2019-03-27 Thread Daniel P . Berrangé
Unless overridden via an env var or configure arg, QEMU will only look for the 'python' binary in $PATH. This is unhelpful on distros which are only shipping Python 3.x (eg Fedora) in their default install as, if they comply with PEP 394, the bare 'python' binary won't exist. This changes configur

[Qemu-devel] [PATCH v2 6/6] Categorize devices: iommu

2019-03-27 Thread Ernest Esene
Set category and description for iommu devices Signed-off-by: Ernest Esene --- v2: * split into separate patches --- hw/i386/amd_iommu.c | 2 ++ hw/i386/intel_iommu.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 6eabdf9917..4a4e2c7fd4

[Qemu-devel] [PULL 0/1] device-tree queue

2019-03-27 Thread Alistair Francis
The following changes since commit 49fc899f8d673dd9e73f3db0d9e9ea60b77c331b: Update version for v4.0.0-rc1 release (2019-03-26 17:02:29 +) are available in the Git repository at: g...@github.com:alistair23/qemu.git tags/pull-device-tree-20190327 for you to fetch changes up to

[Qemu-devel] [PULL 1/1] MAINTAINERS: Update the device tree maintainers

2019-03-27 Thread Alistair Francis
Remove Alex as a Device Tree maintainer as requested by him. Add myself as a maintainer to avoid it being orphaned. Also add David as a Reviewer (R) as he is the libfdt and DTC maintainer. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alexander Graf Acked-by:

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Alex Williamson
On Wed, 27 Mar 2019 11:32:55 -0400 "Michael S. Tsirkin" wrote: > On Tue, Mar 26, 2019 at 04:55:19PM -0600, Alex Williamson wrote: > > Conventional PCI buses pre-date requester IDs. An IOMMU cannot > > distinguish by devfn & bus between devices in a conventional PCI > > topology and therefore we

Re: [Qemu-devel] [PATCH for-4.0] nbd-client: Work around server BLOCK_STATUS misalignment at EOF

2019-03-27 Thread Vladimir Sementsov-Ogievskiy
26.03.2019 20:13, Eric Blake wrote: > The NBD spec is clear that a server that advertises a minimum block > size should reply to NBD_CMD_BLOCK_STATUS with extents aligned > accordingly. However, we know that the qemu NBD server implementation > has had a corner-case bug where it is not compliant wi

[Qemu-devel] [PATCH v2 5/6] Categorize devices: IGD passthrough ISA bridge

2019-03-27 Thread Ernest Esene
Set category for the device Signed-off-by: Ernest Esene --- v2: * split into separate patches --- hw/i386/pc_piix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 8ad8e885c6..03a9cb8af3 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2019 at 05:43:45PM +0100, Auger Eric wrote: > Hi, > > On 3/27/19 4:32 PM, Michael S. Tsirkin wrote: > > On Tue, Mar 26, 2019 at 04:55:19PM -0600, Alex Williamson wrote: > >> Conventional PCI buses pre-date requester IDs. An IOMMU cannot > >> distinguish by devfn & bus between devi

Re: [Qemu-devel] [PATCH 2/2] accel: Unbreak accelerator fallback

2019-03-27 Thread Igor Mammedov
On Wed, 27 Mar 2019 16:03:47 +0100 Markus Armbruster wrote: > When the user specifies a list of accelerators, we pick the first one > that initializes successfully. Recent commit 1a3ec8c1564 broke that. > Reproducer: > > $ qemu-system-x86_64 --machine accel=xen:tcg > xencall: error: Cou

Re: [Qemu-devel] [PATCH v2] configure: automatically pick python3 is available

2019-03-27 Thread Daniel P . Berrangé
On Wed, Mar 27, 2019 at 01:38:07PM -0300, Eduardo Habkost wrote: > On Tue, Mar 19, 2019 at 11:02:08AM +, Daniel P. Berrangé wrote: > > Unless overridden via an env var or configure arg, QEMU will only look > > for the 'python' binary in $PATH. This is unhelpful on distros which > > are only shi

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-27 Thread Igor Mammedov
On Wed, 27 Mar 2019 14:59:44 +0100 David Hildenbrand wrote: > Right now we configure the pagesize quite early, when initializing KVM. > This is long before system memory is actually allocated via > memory_region_allocate_system_memory(), and therefore memory backends > marked as mapped. > > Inst

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Auger Eric
Hi, On 3/27/19 4:32 PM, Michael S. Tsirkin wrote: > On Tue, Mar 26, 2019 at 04:55:19PM -0600, Alex Williamson wrote: >> Conventional PCI buses pre-date requester IDs. An IOMMU cannot >> distinguish by devfn & bus between devices in a conventional PCI >> topology and therefore we cannot assign the

Re: [Qemu-devel] QEMU event loop optimizations

2019-03-27 Thread Stefan Hajnoczi
On Tue, Mar 26, 2019 at 02:37:35PM +0100, Paolo Bonzini wrote: > On 26/03/19 14:18, Stefan Hajnoczi wrote: > > Hi Sergio, > > Here are the forgotten event loop optimizations I mentioned: > > > > https://github.com/stefanha/qemu/commits/event-loop-optimizations > > > > The goal was to eliminate

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-27 Thread Paolo Bonzini
On 27/03/19 17:24, Laszlo Ersek wrote: > On 03/27/19 17:15, Paolo Bonzini wrote: >> On 27/03/19 17:05, Daniel P. Berrangé wrote: >>> On Wed, Mar 27, 2019 at 04:58:23PM +0100, Paolo Bonzini wrote: On 27/03/19 16:30, Daniel P. Berrangé wrote: > Perhaps the VM test scripts should do a "HEAD"

Re: [Qemu-devel] [PATCH v2] configure: automatically pick python3 is available

2019-03-27 Thread Eduardo Habkost
On Tue, Mar 19, 2019 at 11:02:08AM +, Daniel P. Berrangé wrote: > Unless overridden via an env var or configure arg, QEMU will only look > for the 'python' binary in $PATH. This is unhelpful on distros which > are only shipping Python 3.x (eg Fedora) in their default install as, > if they compl

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-27 Thread Stefan Hajnoczi
On Tue, Mar 26, 2019 at 10:31:53AM -0400, Jag Raman wrote: > > > On 3/26/2019 4:08 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 08, 2019 at 09:50:36AM +, Stefan Hajnoczi wrote: > > > On Thu, Mar 07, 2019 at 03:29:41PM -0800, John G Johnson wrote: > > > > > On Mar 7, 2019, at 11:27 AM, Stefan Ha

Re: [Qemu-devel] [RFC PATCH] pci: Use PCI aliases when determining device IOMMU address space

2019-03-27 Thread Alex Williamson
On Wed, 27 Mar 2019 14:25:00 +0800 Peter Xu wrote: > On Tue, Mar 26, 2019 at 04:55:19PM -0600, Alex Williamson wrote: > > Conventional PCI buses pre-date requester IDs. An IOMMU cannot > > distinguish by devfn & bus between devices in a conventional PCI > > topology and therefore we cannot assig

Re: [Qemu-devel] [PATCH for 4.0 v1 1/5] riscv: plic: Fix incorrect irq calculation

2019-03-27 Thread Alistair Francis
On Wed, Mar 27, 2019 at 3:29 AM Palmer Dabbelt wrote: > > On Wed, 20 Mar 2019 17:46:09 PDT (-0700), Alistair Francis wrote: > > The irq is incorrectly calculated to be off by one. It has worked in the > > past as the priority_base offset has also been set incorrectly. We are > > about to fix the p

Re: [Qemu-devel] [PATCH v7 0/2] log: Make glib logging go through QEMU

2019-03-27 Thread Markus Armbruster
Uh, I totally missed this one... my apologies! Christophe Fergeau writes: > The main goal of this patch series is to make logs output by > libspice-server.so go through qemu logging infrastructure so that their > format is the same as the rest of QEMU messages (in particular, > timestamps). Thi

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-27 Thread Laszlo Ersek
On 03/27/19 17:15, Paolo Bonzini wrote: > On 27/03/19 17:05, Daniel P. Berrangé wrote: >> On Wed, Mar 27, 2019 at 04:58:23PM +0100, Paolo Bonzini wrote: >>> On 27/03/19 16:30, Daniel P. Berrangé wrote: Perhaps the VM test scripts should do a "HEAD" request for the image every time to disc

Re: [Qemu-devel] [PATCH v2 0/4] pvrdma: Add support for SRQ

2019-03-27 Thread Yuval Shaia
On Tue, Mar 26, 2019 at 02:54:29PM +0200, Kamal Heib wrote: > This series implements the SRQ (Shared Receive Queue) for the pvrdma > device, It also includes all the needed functions and definitions for > support SRQ in the backend and resource management layers. > > Changes from v1->v2: > - Handl

  1   2   3   >