[Qemu-devel] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-21 Thread Aravinda Prasad
This patch builds the rtas error log, copies it to the rtas_addr and then invokes the guest registered machine check handler. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |4 + hw/ppc/spapr_events.c | 247 include/hw/ppc/spapr.h

[Qemu-devel] [PATCH v7 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-03-21 Thread Aravinda Prasad
This patch set adds support for FWNMI in PowerKVM guests. System errors such as SLB multihit and memory errors that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exceptions, if the address in error belon

[Qemu-devel] [PATCH v7 3/6] target/ppc: Handle NMI guest exit

2019-03-21 Thread Aravinda Prasad
Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reason set to KVM_EXIT_NMI in

[Qemu-devel] [PATCH v7 6/6] migration: Block migration while handling machine check

2019-03-21 Thread Aravinda Prasad
Block VM migration requests until the machine check error handling is complete as (i) these errors are specific to the source hardware and is irrelevant on the target hardware, (ii) these errors cause data corruption and should be handled before migration. Signed-off-by: Aravinda Prasad --- hw/p

[Qemu-devel] [PATCH v7 5/6] ppc: spapr: Enable FWNMI capability

2019-03-21 Thread Aravinda Prasad
Enable the KVM capability KVM_CAP_PPC_FWNMI so that the KVM causes guest exit with NMI as exit reason when it encounters a machine check exception on the address belonging to a guest. Without this capability enabled, KVM redirects machine check exceptions to guest's 0x200 vector. Signed-off-by: Ar

[Qemu-devel] [PATCH v7 2/6] Wrapper function to wait on condition for the main loop mutex

2019-03-21 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. Signed-off-by: Aravinda Prasad --- cpus.c |5 + include/qemu/main-loop.h |8

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-21 Thread Peter Xu
On Thu, Mar 21, 2019 at 11:31:30PM +0800, Catherine Ho wrote: > Thanks, Peter > See my comments below, please > > On Thu, 21 Mar 2019 at 14:10, Peter Xu wrote: > > > > On Wed, Mar 20, 2019 at 04:05:58PM +0800, chenxi He wrote: > > > On Wed, 20 Mar 2019 at 13:07, Peter Xu wrote: > > > > > > > > O

[Qemu-devel] [PATCH v7 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-03-21 Thread Aravinda Prasad
This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine check at or about the same

Re: [Qemu-devel] [PATCH] i386: Disable OSPKE on CPU model definitions

2019-03-21 Thread Robert Hoo
On Tue, 2019-03-19 at 17:05 -0300, Eduardo Habkost wrote: > Currently, the Cascadelake-Server, Icelake-Client, and > Icelake-Server are always generating the following warning: > >   qemu-system-x86_64: warning: \ > host doesn't support requested feature: CPUID.07H:ECX [bit 4] > > This happen

Re: [Qemu-devel] [BUG] [low severity] a strange appearance of message involving slirp while doing "empty" make

2019-03-21 Thread Thomas Huth
On 20/03/2019 22.08, Aleksandar Markovic wrote: > Folks, > > If qemu tree is already fully built, and "make" is attempted, for 3.1, the > outcome is: > > $ make > CHK version_gen.h > $ > > For 4.0-rc0, the outcome seems to be different: > > $ make > make[1]: Entering directory '/home/bui

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-21 Thread Thomas Huth
On 15/03/2019 20.06, Aleksandar Markovic wrote: >> From: Thomas Huth >> Subject: Re: Maintainers, please tell us how to boot your machines! >> >>> On Tue, Mar 12, 2019 at 6:44 PM Markus Armbruster >>> wrote: >> [...] I gathered the machine types, mapped them to source files, which I fed

[Qemu-devel] [PATCH] target/xtensa: fix break_dependency for repeated resources

2019-03-21 Thread Max Filippov
break_dependency incorrectly handles the case of dependency on an opcode that references the same register multiple times. E.g. the following instruction is translated incorrectly: { or a2, a3, a3 ; or a3, a2, a2 } This happens because resource indices of both dependency graph nodes are increme

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-21 Thread John G Johnson
> On Thu, Mar 07, 2019 at 02:51:20PM +, Daniel P. Berrangé wrote: > >> On Mar 7, 2019, at 11:27 AM, Stefan Hajnoczi wrote: >>> >>> On Thu, Mar 07, 2019 at 02:51:20PM +, Daniel P. Berrangé wrote: I guess one obvious answer is that the existing security mechanisms like SELin

Re: [Qemu-devel] [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

2019-03-21 Thread Roger Pau Monné
On Wed, Mar 20, 2019 at 01:28:47PM -0400, Jason Andryuk wrote: > On Fri, Mar 15, 2019 at 12:28 PM Andrew Cooper > wrote: > > > > On 15/03/2019 09:17, Paul Durrant wrote: > > >> -Original Message- > > >> From: Jason Andryuk [mailto:jandr...@gmail.com] > > >> Sent: 14 March 2019 18:16 > > >>

[Qemu-devel] Re [Qemu-block] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

2019-03-21 Thread lizhengui
The fcntl call fails in the actual scene and it is really hard to happen. But according to a good coding style, I think there should be a error handling for a system call. + if (((unsigned int) flags & O_ACCMODE) == O_RDONLY) { The flags is a int type. According to strict programming specifica

Re: [Qemu-devel] [PATCH v3 13/15] spapr/irq: introduce a spapr_irq_init_device() helper

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 03:49:12PM +0100, Cédric Le Goater wrote: > The way the XICS and the XIVE devices are initialized follows the same > pattern. First, try to connect to the KVM device and if not possible > fallback on the emulated device, unless a kernel_irqchip is required. > The spapr_irq_i

Re: [Qemu-devel] [RFC for-4.1 00/25] Many style fixes for target/ppc

2019-03-21 Thread David Gibson
On Fri, Mar 22, 2019 at 11:15:19AM +1100, David Gibson wrote: > target/ppc has a lot of old code that doesn't stick to the modern > style guidelines. That means we keep getting checkpatch warnings from > code motions in there, or from people copying the local style rather > than the global style.

Re: [Qemu-devel] [PATCH v3 14/15] spapr/irq: initialize the IRQ device only once

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 03:49:13PM +0100, Cédric Le Goater wrote: > Add a check to make sure that the routine initializing the emulated > IRQ device is called once. We don't have much to test on the XICS > side, so we introduce a 'static bool'. Not very elegant but works well > enough. What's the

Re: [Qemu-devel] [PATCH v3 15/15] spapr/irq: add KVM support to the 'dual' machine

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 03:49:14PM +0100, Cédric Le Goater wrote: > The interrupt mode is chosen by the CAS negotiation process and > activated after a reset to take into account the required changes in > the machine. This brings new constraints on how the associated KVM IRQ > device is initialized

Re: [Qemu-devel] [PATCH v3 08/15] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 03:49:07PM +0100, Cédric Le Goater wrote: > Removing RTAS handlers will become necessary when the new pseries > machine supporting multiple interrupt mode is introduced. > > Signed-off-by: Cédric Le Goater This makes sense independent of the rest, so I've applied it to pp

Re: [Qemu-devel] [PATCH v3 12/15] spapr/irq: remove spapr_ics_create()

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 03:49:11PM +0100, Cédric Le Goater wrote: > spapr_ics_create() is only called once. Merge it in spapr_irq_init_xics() > and simplify a bit the error handling by using 'error_fatal' . > > Signed-off-by: Cédric Le Goater Seems like a good cleanup, regardless of the rest. A

Re: [Qemu-devel] [PATCH v3 04/15] spapr/xive: add state synchronization with KVM

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 03:49:03PM +0100, Cédric Le Goater wrote: > This extends the KVM XIVE device backend with 'synchronize_state' > methods used to retrieve the state from KVM. The HW state of the > sources, the KVM device and the thread interrupt contexts are > collected for the monitor usage

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

2019-03-21 Thread Eric Blake
[top-posting is harder to read on technical lists; I'm reordering your message before replying inline] > On 20/03/19 15:07, Zhengui li wrote: >> The function fcntl maybe return -1, which is not a unsigned type. >> Unsigned type or Negative values should not do bitwise operator with >> O_ACCMODE.

Re: [Qemu-devel] [PATCH v3 2/2] vfio-ccw: support async command subregion

2019-03-21 Thread Eric Farman
On 3/1/19 4:39 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clear request to the device; if not, fall back to emulation (as done today). Signed-off-by: Cornelia Huck ---

Re: [Qemu-devel] [PATCH v3 0/2] vfio-ccw: support hsch/csch (QEMU part)

2019-03-21 Thread Eric Farman
On 3/1/19 4:39 AM, Cornelia Huck wrote: [I'm not quite happy with how this async processing hooks up in css.c; ideas welcome.] I guess I'm not unhappy with it, but it does look a little odd. Not sure I have a better idea right now... Will ponder that for a while. - Eric

Re: [Qemu-devel] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

2019-03-21 Thread lizhengui
If the fd is invalid or interrupted by signal. -邮件原件- 发件人: Paolo Bonzini [mailto:pbonz...@redhat.com] 发送时间: 2019年3月21日 18:38 收件人: lizhengui; stefa...@redhat.com; mre...@redhat.com; kw...@redhat.com 抄送: qemu-bl...@nongnu.org; qemu-devel@nongnu.org; Fangyi (C); wangjie (P) 主题: Re: [PATCH] q

Re: [Qemu-devel] [RFC for-4.1 00/25] Many style fixes for target/ppc

2019-03-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190322001544.9794-1-da...@gibson.dropbear.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190322001544.9794-1-da...@gibson.dropbear.id.au Subject: [Qemu-devel] [RFC for-4.1 00/25] Man

[Qemu-devel] [RFC for-4.1 15/25] target/ppc: Style fixes for misc_helper.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/misc_helper.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c index c65d1ade15..0a81e98ee9 100644 --- a/target/ppc/misc_helper.c +++ b/target/ppc/misc_helper.c @@ -210,10 +2

Re: [Qemu-devel] [PATCH v3 02/15] spapr/xive: add KVM support

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 03:49:01PM +0100, Cédric Le Goater wrote: > This introduces a set of helpers when KVM is in use, which create the > KVM XIVE device, initialize the interrupt sources at a KVM level and > connect the interrupt presenters to the vCPU. > > They also handle the initialization o

[Qemu-devel] [RFC for-4.1 13/25] target/ppc: Style fixes for mem_helper.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/mem_helper.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 9c5a68579e..5b0f9ee50d 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_

Re: [Qemu-devel] [PATCH] sifive_prci: Read and write PRCI registers

2019-03-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190322002749.26561-1-pal...@sifive.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190322002749.26561-1-pal...@sifive.com Subject: [Qemu-devel] [PATCH] sifive_prci: Read and write PRCI r

[Qemu-devel] [RFC for-4.1 16/25] target/ppc: Style fixes for mmu-hash32.[ch]

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/mmu-hash32.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c index e8562a7c87..f83944b78c 100644 --- a/target/ppc/mmu-hash32.c +++ b/target/ppc/mmu-hash32.c @@ -27

Re: [Qemu-devel] [PATCH v3 03/15] spapr/xive: add hcall support when under KVM

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 03:49:02PM +0100, Cédric Le Goater wrote: > XIVE hcalls are all redirected to QEMU as none are on a fast path. > When necessary, QEMU invokes KVM through specific ioctls to perform > host operations. QEMU should have done the necessary checks before > calling KVM and, in cas

[Qemu-devel] [RFC for-4.1 17/25] target/ppc: Style fixes for mmu-hash64.[ch]

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/mmu-hash64.c | 62 + 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/target/ppc/mmu-hash64.c b/target/ppc/mmu-hash64.c index a2b1ec5040..90f4b306b2 100644 --- a/target/ppc/mmu-hash64.c +++ b/target/

[Qemu-devel] [RFC for-4.1 14/25] target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/mfrom_table.inc.c | 3 +-- target/ppc/mfrom_table_gen.c | 8 +--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/target/ppc/mfrom_table.inc.c b/target/ppc/mfrom_table.inc.c index 6a1fa375c9..1653b974a4 100644 --- a/target/ppc/mfrom_ta

[Qemu-devel] [RFC for-4.1 21/25] target/ppc: Style fixes for translate.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/translate.c | 507 + 1 file changed, 315 insertions(+), 192 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 98b37cebc2..67aa128ef1 100644 --- a/target/ppc/translate.c +++ b/target/p

Re: [Qemu-devel] [PATCH v3 01/15] linux-headers: update to 5.1-rc1

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 03:49:00PM +0100, Cédric Le Goater wrote: > These changes provide the interface with the KVM device implementing > the XIVE native exploitation interrupt mode. Also used to retrieve the > state of the KVM device for the monitor usage and for migration. > > Available from :

[Qemu-devel] [RFC for-4.1 23/25] target/ppc: Style fixes for translate/vsx-impl.inc.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/translate/vsx-impl.inc.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx-impl.inc.c index 508e9199c8..0cb09891a6 100644 --- a/target/ppc/translate/vsx-imp

[Qemu-devel] [RFC for-4.1 07/25] target/ppc: Style fixes for dfp_helper.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/dfp_helper.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c index 9164fe701b..ddab65c7ba 100644 --- a/target/ppc/dfp_helper.c +++ b/target/ppc/dfp_helper.c @@ -1104,19

[Qemu-devel] [RFC for-4.1 19/25] target/ppc: Style fixes for monitor.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/monitor.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/target/ppc/monitor.c b/target/ppc/monitor.c index 04deec8030..451ca722b3 100644 --- a/target/ppc/monitor.c +++ b/target/ppc/monitor.c @@ -27,32 +27,33 @@ #includ

[Qemu-devel] [RFC for-4.1 00/25] Many style fixes for target/ppc

2019-03-21 Thread David Gibson
target/ppc has a lot of old code that doesn't stick to the modern style guidelines. That means we keep getting checkpatch warnings from code motions in there, or from people copying the local style rather than the global style. I'm sick of it, so here's a big series to fix many of the style probl

[Qemu-devel] [RFC for-4.1 20/25] target/ppc: Style fixes for translate_init.inc.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/translate_init.inc.c | 240 +++- 1 file changed, 146 insertions(+), 94 deletions(-) diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c index 0bd555eb19..78e4cd3e87 100644 --- a/target/ppc/translate

[Qemu-devel] [RFC for-4.1 25/25] target/ppc: Style fixes for translate/spe-impl.inc.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/translate/spe-impl.inc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/target/ppc/translate/spe-impl.inc.c b/target/ppc/translate/spe-impl.inc.c index 8c1c16c63e..7ab0a29b5f 100644 --- a/target/ppc/translate/spe-impl

[Qemu-devel] [RFC for-4.1 06/25] target/ppc: Style fixes for fpu_helper.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/fpu_helper.c | 134 +--- 1 file changed, 83 insertions(+), 51 deletions(-) diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c index 2ed4f42275..0b7308f539 100644 --- a/target/ppc/fpu_helper.c +++ b/target/

[Qemu-devel] [RFC for-4.1 02/25] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h"

2019-03-21 Thread David Gibson
From: Philippe Mathieu-Daudé In commit 47973a2dbf we split the last generic chipset out of the PC board, but missed to remove the i8042 keyboard controller. This omission was later fixed in commit 7cb00357c1, but here we forgot to remove the "i8042.h" include. Do it now. Signed-off-by: Philippe

[Qemu-devel] [RFC for-4.1 01/25] spapr: Support NVIDIA V100 GPU with NVLink2

2019-03-21 Thread David Gibson
From: Alexey Kardashevskiy NVIDIA V100 GPUs have on-board RAM which is mapped into the host memory space and accessible as normal RAM via an NVLink bus. The VFIO-PCI driver implements special regions for such GPUs and emulates an NVLink bridge. NVLink2-enabled POWER9 CPUs also provide address tra

[Qemu-devel] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_regs.h

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/helper_regs.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/ppc/helper_regs.h b/target/ppc/helper_regs.h index a2205e1044..8397819dee 100644 --- a/target/ppc/helper_regs.h +++ b/target/ppc/helper_regs.h @@ -44,10 +

[Qemu-devel] [RFC for-4.1 22/25] target/ppc: Style fixes for translate/fp-impl.inc.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/translate/fp-impl.inc.c | 52 ++ 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/target/ppc/translate/fp-impl.inc.c b/target/ppc/translate/fp-impl.inc.c index 0f21a4e477..9dcff947c0 100644 --- a/target/ppc/tra

[Qemu-devel] [RFC for-4.1 03/25] target/ppc: Style fixes for ppc-models.[ch]

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/cpu-models.c | 2 +- target/ppc/cpu-models.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c index 7c75963e3c..9d7050b5fa 100644 --- a/target/ppc/cpu-models.c +++ b/target/ppc/cpu-

[Qemu-devel] [RFC for-4.1 11/25] target/ppc: Style fixes for kvm_ppc.h and kvm.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/kvm.c | 178 +++ target/ppc/kvm_ppc.h | 3 +- 2 files changed, 115 insertions(+), 66 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 2427c8ee13..a1c223385d 100644 --- a/target/ppc/kvm.c +

[Qemu-devel] [RFC for-4.1 04/25] target/ppc: Style fixes for cpu.[ch]

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/cpu.h | 239 ++- 1 file changed, 130 insertions(+), 109 deletions(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index fc12b4688e..5d25b17539 100644 --- a/target/ppc/cpu.h +++ b/target/ppc/cpu.h @@ -23,23

[Qemu-devel] [RFC for-4.1 18/25] target/ppc: Style fixes for mmu_helper.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/mmu_helper.c | 131 1 file changed, 80 insertions(+), 51 deletions(-) diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index 4a6be4d63b..a01a12a4af 100644 --- a/target/ppc/mmu_helper.c +++ b/target/

[Qemu-devel] [RFC for-4.1 24/25] target/ppc: Style fixes for translate/vmx-impl.inc.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/translate/vmx-impl.inc.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/target/ppc/translate/vmx-impl.inc.c b/target/ppc/translate/vmx-impl.inc.c index eb10c533ca..bd3ff40e68 100644 --- a/target/ppc/tran

[Qemu-devel] [RFC for-4.1 12/25] target/ppc: Style fixes for machine.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/machine.c | 106 +-- 1 file changed, 63 insertions(+), 43 deletions(-) diff --git a/target/ppc/machine.c b/target/ppc/machine.c index a92d0ad3a3..25cdb9088b 100644 --- a/target/ppc/machine.c +++ b/target/ppc/machi

[Qemu-devel] [RFC for-4.1 08/25] target/ppc: Style fixes for excp_helper.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/excp_helper.c | 87 1 file changed, 53 insertions(+), 34 deletions(-) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index beafcf1ebd..ec2c177091 100644 --- a/target/ppc/excp_helper.c +++ b/targ

[Qemu-devel] [RFC for-4.1 09/25] target/ppc: Style fixes for gdbstub.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/gdbstub.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index fbf3821f4b..ce3625f44e 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -3

[Qemu-devel] [RFC for-4.1 05/25] target/ppc: Style fixes for int_helper.c

2019-03-21 Thread David Gibson
Signed-off-by: David Gibson --- target/ppc/int_helper.c | 70 +++-- 1 file changed, 39 insertions(+), 31 deletions(-) diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c index 162add561e..f6a088ac08 100644 --- a/target/ppc/int_helper.c +++ b/target/

Re: [Qemu-devel] [PATCH v4] hw/acpi: extract acpi_add_rom_blob()

2019-03-21 Thread Wei Yang
On Thu, Mar 21, 2019 at 02:50:42PM +0100, Igor Mammedov wrote: >On Thu, 21 Mar 2019 08:21:53 +0800 >Wei Yang wrote: > >> arm and i386 has almost the same function acpi_add_rom_blob(), except >> giving different FWCfgCallback function. >> >> This patch moves acpi_add_rom_blob() to utils.c by passi

[Qemu-devel] [PATCH] sifive_prci: Read and write PRCI registers

2019-03-21 Thread Palmer Dabbelt
From: Nathaniel Graff Writes to the SiFive PRCI registers are preserved while leaving the ready bits set for the HFX/HFR oscillators and the lock bit set for the PLL. Signed-off-by: Nathaniel Graff Reviewed-by: Michael Clark Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- hw/r

Re: [Qemu-devel] [PATCH qemu] spapr/nvlink2: Correct error messages

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 05:48:27PM +1100, Alexey Kardashevskiy wrote: > This corrects rather confusing error messages; can be squashed. > > Fixes: 0afa2635ef75 ("spapr: Support NVIDIA V100 GPU with NVLink2", > 2019-03-12) > Signed-off-by: Alexey Kardashevskiy Applied and squashed. > --- > hw/

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-21 Thread Laszlo Ersek
On 03/21/19 23:32, Laszlo Ersek wrote: > Cool, so let me try this. I'm going to download the xz.old file > manually. Rename it to just xz. It will then match the built-in > checksum, and will be used as a cached copy. Then I will try building my > series in *that* ("old") VM. Summary: (1) The im

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-21 Thread Laszlo Ersek
On 03/21/19 21:58, Philippe Mathieu-Daudé wrote: > Le jeu. 21 mars 2019 18:22, Laszlo Ersek a écrit : >> Unfortunately, I got the exact same setup error: >>> ERROR: "x86_64-unknown-openbsd6.1-gcc-4.9.4" either does not exist >>> or does not work > $ VERBOSE=1 make > Or DEBUG=1. If default ./con

[Qemu-devel] [PATCH] docker: trivial changes to `make docker` help

2019-03-21 Thread Wainer dos Santos Moschetta
Apply double quotes and period punctuation uniformly. Signed-off-by: Wainer dos Santos Moschetta --- tests/docker/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 60314d293a..c0e1bf57a3

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-21 Thread Philippe Mathieu-Daudé
Le mar. 19 mars 2019 19:40, Markus Armbruster a écrit : > Markus Armbruster writes: > > > Dear board code maintainers, > > > > This is a (rather late) follow-up to the last QEMU summit. Minutes[*]: > > > > * Deprecating unmaintained features (devices, targets, backends) in QEMU > > > >QEMU

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-21 Thread Philippe Mathieu-Daudé
Le jeu. 21 mars 2019 18:22, Laszlo Ersek a écrit : > On 03/21/19 17:55, Laszlo Ersek wrote: > > On 03/21/19 12:52, Peter Maydell wrote: > >> On Thu, 21 Mar 2019 at 11:34, Laszlo Ersek wrote: > >>> > >>> Repo: https://github.com/lersek/qemu.git > >>> Branch: edk2_build_v3 > >>> > >>> Version 2,

Re: [Qemu-devel] QUEM booting from external

2019-03-21 Thread John Snow
On 3/20/19 8:38 PM, Grove, Michael wrote: > Hi All, > > Sorry for going straight to the developers but I have a very complex > problem. I have QNX application/OS that is licensed to the physical media it > exists on(media ID). When you boot on bare metal directly from the media all > is go

Re: [Qemu-devel] [PATCH v3 1/2] vfio-ccw: new capability chain support

2019-03-21 Thread Eric Farman
On 3/1/19 4:39 AM, Cornelia Huck wrote: To be replaced with a real linux-headers update. Signed-off-by: Cornelia Huck This looks straightforward. Reviewed-by: Eric Farman --- linux-headers/linux/vfio.h | 4 linux-headers/linux/vfio_ccw.h | 12 2 files changed

[Qemu-devel] [PATCH] acpi: verify file entries in bios_linker_loader_add_pointer()

2019-03-21 Thread Liam Merwick
The callers to bios_linker_find_file() assert that the file entry returned is not NULL, except for those in bios_linker_loader_add_pointer(). Add two asserts in that case for completeness and to facilitate static code analysis. Signed-off-by: Liam Merwick --- hw/acpi/bios-linker-loader.c | 2 ++

Re: [Qemu-devel] Can't build without --disable-tcg after upgrading gcc (I think)

2019-03-21 Thread Markus Armbruster
Richard Henderson writes: > On 3/21/19 11:10 AM, Markus Armbruster wrote: >> I re-ran the failing compile with "-c -o tcg/tcg-op.o" replaced by "-E >> -dD -o tcg/tcg-op.i", and uploaded the resulting tcg-op.i to >> >> https://www.pond.sub.org/~armbru/debug/tcg-op.i >> >> Diffing this agains

Re: [Qemu-devel] [PATCH RFC v4 04/12] target/rx: RX disassembler

2019-03-21 Thread Richard Henderson
On 3/20/19 7:16 AM, Yoshinori Sato wrote: > +static const char *cond[] = { > +"eq", "ne", "c", "nc", "gtu", "leu", "pz", "n", > +"ge", "lt", "gt", "le", "o", "no", "ra", "f" > +}; const char * const cond[] Or since they are all very short strings, const char cond[][4] > +static const ch

[Qemu-devel] [PULL 5/5] docs: add note about stibp CPU feature for spectre v2

2019-03-21 Thread Eduardo Habkost
From: Daniel P. Berrangé While the stibp CPU feature is not commonly used by guest OS for spectre mitigation due to its performance impact, it is none the less best practice to expose it to all guest OS. This allows the guest OS to decide whether to make use or it. Signed-off-by: Daniel P. Berra

[Qemu-devel] [PULL 2/5] i386: Make arch_capabilities migratable

2019-03-21 Thread Eduardo Habkost
Now that kvm_arch_get_supported_cpuid() will only return arch_capabilities if QEMU is able to initialize the MSR properly, we know that the feature is safely migratable. Signed-off-by: Eduardo Habkost Message-Id: <20190125220606.4864-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- tar

Re: [Qemu-devel] [PATCH RFC v4 03/12] target/rx: CPU definition

2019-03-21 Thread Richard Henderson
On 3/20/19 7:16 AM, Yoshinori Sato wrote: > +#define FPSW_MASK 0xfc007cff > +#define FPSW_RM_MASK 0x0003 > +#define FPSW_DN (1 << 8) It's slightly confusing to have this as a mask, > +#define FPSW_CAUSE_MASK 0x00fc > +#define FPSW_CAUSE_SHIFT 2 > +#define FPSW_CAUSE 2 > +#define FPSW_CA

[Qemu-devel] [PULL 3/5] i386: Disable OSPKE on CPU model definitions

2019-03-21 Thread Eduardo Habkost
Currently, the Cascadelake-Server, Icelake-Client, and Icelake-Server are always generating the following warning: qemu-system-x86_64: warning: \ host doesn't support requested feature: CPUID.07H:ECX [bit 4] This happens because OSPKE was never returned by GET_SUPPORTED_CPUID or x86_cpu_get

[Qemu-devel] [PULL 4/5] docs: clarify that spec-ctrl is only needed for Spectre v2

2019-03-21 Thread Eduardo Habkost
From: Daniel P. Berrangé The docs currently say that the spec-ctrl feature is needed for both Spectre variants, but it is only used to address Spectre v2. Also remove the note about retpolines. The guest OS is usually treated as a blackbox from host mgmt pov, so it won't have knowledge about use

[Qemu-devel] [PULL 1/5] i386: kvm: Disable arch_capabilities if MSR can't be set

2019-03-21 Thread Eduardo Habkost
KVM has two bugs in the handling of MSR_IA32_ARCH_CAPABILITIES: 1) Linux commit commit 1eaafe91a0df ("kvm: x86: IA32_ARCH_CAPABILITIES is always supported") makes GET_SUPPORTED_CPUID return arch_capabilities even if running on SVM. This makes "-cpu host,migratable=off" incorrectly expose

Re: [Qemu-devel] [PATCH] virtio-vga: only enable for specific boards

2019-03-21 Thread Laszlo Ersek
On 03/21/19 15:29, Paolo Bonzini wrote: > When virtio-vga was added, the intention was to only support it for > those machines where the firmware does not know about virtio-gpu, > and supported VGA legacy hardware before virtio-{gpu,vga} were > introduced. > > The Kconfig switch however enabled vi

[Qemu-devel] [PULL 0/5] x86 queue for -rc1

2019-03-21 Thread Eduardo Habkost
The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/x86-next-pull-request for you to fetch changes up to 21ee4787e533675

Re: [Qemu-devel] Can't build without --disable-tcg after upgrading gcc (I think)

2019-03-21 Thread Richard Henderson
On 3/21/19 11:10 AM, Markus Armbruster wrote: > I re-ran the failing compile with "-c -o tcg/tcg-op.o" replaced by "-E > -dD -o tcg/tcg-op.i", and uploaded the resulting tcg-op.i to > > https://www.pond.sub.org/~armbru/debug/tcg-op.i > > Diffing this against yours might provide clues. Either

Re: [Qemu-devel] [PATCH v6 0/2] Nios II generic board config and semihosting

2019-03-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1553193630-28611-1-git-send-email-san...@codesourcery.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 0/2] Nios II generic board config and semihosting Message-id: 1553

Re: [Qemu-devel] [PATCH 1/2] trace: handle tracefs path truncation

2019-03-21 Thread Liam Merwick
On 21/03/2019 17:08, Stefan Hajnoczi wrote: If the tracefs mountpoint has a very long path we may exceed PATH_MAX. This is a system misconfiguration and the user must resolve it so that applications can perform path-based system calls successfully. This issue does not occur on real-world systems

[Qemu-devel] [PATCH v6 1/2] Add generic Nios II board.

2019-03-21 Thread Sandra Loosemore
This patch adds support for a generic MMU-less Nios II board that can be used e.g. for bare-metal compiler testing with the linker script and startup code provided by libgloss. Nios II booting is also tweaked so that bare-metal binaries start executing in RAM starting at 0x, rather than an

Re: [Qemu-devel] [Qemu-block] [PATCH] tests/qemu-iotests/235: Allow fallback to tcg and remove it from quick group

2019-03-21 Thread Eric Blake
On 3/21/19 3:23 AM, Thomas Huth wrote: > pipelines in that case. I had to manually select the test cases in the > .gitlab-ci.yml file due to this. I don't mind too much, but IMHO "make > check-block" should simply run everywhere, with every QEMU binary, and > not only if you've compiled it with th

[Qemu-devel] [PATCH v6 2/2] Add Nios II semihosting support.

2019-03-21 Thread Sandra Loosemore
This patch adds support for libgloss semihosting to Nios II bare-metal emulation. The specification for the protocol can be found in the libgloss sources. Signed-off-by: Sandra Loosemore Signed-off-by: Julian Brown --- qemu-options.hx| 8 +- target/nios2/Makefile.objs | 2 +- t

Re: [Qemu-devel] [PATCH 2/2] trace: avoid SystemTap dtrace(1) warnings on empty files

2019-03-21 Thread Liam Merwick
On 21/03/2019 17:08, Stefan Hajnoczi wrote: target/hppa/trace-events only contains disabled events, resulting in a trace-dtrace.dtrace file that says "provider qemu {}". SystemTap's dtrace(1) tool prints a warning when processing this input file. This patch avoids the error by emitting an empty

[Qemu-devel] [PATCH v6 0/2] Nios II generic board config and semihosting

2019-03-21 Thread Sandra Loosemore
This is the sixth version of the patch series last posted here: http://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg03167.html Changes since v5 include: - The code to allow booting from a low memory address has been simplified and better commented. - Random devices not supported by the li

Re: [Qemu-devel] [PATCH 2/2] trace: avoid SystemTap dtrace(1) warnings on empty files

2019-03-21 Thread Markus Armbruster
Stefan Hajnoczi writes: > target/hppa/trace-events only contains disabled events, resulting in a > trace-dtrace.dtrace file that says "provider qemu {}". SystemTap's > dtrace(1) tool prints a warning when processing this input file. > > This patch avoids the error by emitting an empty file inste

Re: [Qemu-devel] [PULL v3 00/54] Kconfig conversion, excluding ARM and MIPS

2019-03-21 Thread Laszlo Ersek
On 03/21/19 18:58, Peter Maydell wrote: > On Thu, 21 Mar 2019 at 17:35, Laszlo Ersek wrote: >> It simply keeps the status quo from before the patchset. >> >> The specific emulation targets that virtio-vga should not be enabled for >> (regardless of other targets / machine types) are arm/aarch64. I

Re: [Qemu-devel] [PATCH 1/2] trace: handle tracefs path truncation

2019-03-21 Thread Markus Armbruster
Stefan Hajnoczi writes: > If the tracefs mountpoint has a very long path we may exceed PATH_MAX. > This is a system misconfiguration and the user must resolve it so that > applications can perform path-based system calls successfully. > > This issue does not occur on real-world systems since trac

Re: [Qemu-devel] Can't build without --disable-tcg after upgrading gcc (I think)

2019-03-21 Thread Markus Armbruster
Richard Henderson writes: > On 3/20/19 11:38 PM, Markus Armbruster wrote: >> Yesterday's "dnf upgrade" on my F28 box upgraded gcc to >> gcc-8.2.1-6.fc28.x86_64 from 8.3.1-2.fc28.x86_64. Since then (I think), >> builds fail for me, details appended. Any ideas? >> >> My temporary work-around is

Re: [Qemu-devel] [Qemu-block] [PATCH] tests/qemu-iotests/235: Allow fallback to tcg and remove it from quick group

2019-03-21 Thread John Snow
On 3/21/19 4:23 AM, Thomas Huth wrote: > On 20/03/2019 18.32, John Snow wrote: >> >> >> On 3/1/19 7:20 AM, Thomas Huth wrote: >>> iotest 235 currently only works with KVM - this is bad for systems where >>> it is not available, e.g. CI pipelines. The test also works when using >>> "tcg" as accel

[Qemu-devel] [PATCH v2] test-announce-self: convert to qgraph

2019-03-21 Thread Paolo Bonzini
This removes the duplicated initialization code. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 3 -- tests/test-announce-self.c | 73 -- tests/virtio-net-test.c| 30 3 files changed, 30

Re: [Qemu-devel] [PULL v3 00/54] Kconfig conversion, excluding ARM and MIPS

2019-03-21 Thread Peter Maydell
On Thu, 21 Mar 2019 at 17:35, Laszlo Ersek wrote: > It simply keeps the status quo from before the patchset. > > The specific emulation targets that virtio-vga should not be enabled for > (regardless of other targets / machine types) are arm/aarch64. IOW, in > the longer term, it's not that virtio

Re: [Qemu-devel] [PULL v3 00/54] Kconfig conversion, excluding ARM and MIPS

2019-03-21 Thread Laszlo Ersek
On 03/21/19 15:21, Philippe Mathieu-Daudé wrote: > Le jeu. 21 mars 2019 13:39, Laszlo Ersek a écrit : > >> On 03/21/19 01:53, Laszlo Ersek wrote: >>> Hi Paolo, >>> >>> (+libvir-list) >>> >>> I'd like to report a regression introduced by this patch set: >>> >>> On 03/07/19 21:58, Paolo Bonzini wro

Re: [Qemu-devel] [PATCH] test-announce-self: convert to qgraph

2019-03-21 Thread Thomas Huth
On 12/03/2019 17.57, Paolo Bonzini wrote: > This removes the duplicated initialization code. > > Signed-off-by: Paolo Bonzini > --- > tests/Makefile.include | 3 -- > tests/test-announce-self.c | 82 -- > tests/virtio-net-test.c| 30 ++ >

Re: [Qemu-devel] [PATCH] target/riscv: Zero extend the inputs of divuw and remuw

2019-03-21 Thread Richard Henderson
On 3/21/19 7:59 AM, Palmer Dabbelt wrote: > While running the GCC test suite against 4.0.0-rc0, Kito found a > regression introduced by the decodetree conversion that caused divuw and > remuw to sign-extend their inputs. The ISA manual says they are > supposed to be zero extended: > > DIVW an

Re: [Qemu-devel] [PULL v3 00/54] Kconfig conversion, excluding ARM and MIPS

2019-03-21 Thread Laszlo Ersek
On 03/21/19 14:04, Peter Maydell wrote: > On Thu, 21 Mar 2019 at 12:40, Laszlo Ersek wrote: >> In brief, the regression is that the aarch64 system emulator now lists >> the "virtio-vga" device for the "virt" machine type: >> >> $ qemu-system-aarch64 -M virt -device \? | grep virtio-vga >> name "vi

Re: [Qemu-devel] [PATCH RFC v4 02/12] target/rx: TCG helper

2019-03-21 Thread Richard Henderson
On 3/20/19 7:16 AM, Yoshinori Sato wrote: > +void rx_cpu_unpack_psw(CPURXState *env, int all) > +{ > +if (env->psw_pm == 0) { > +env->psw_ipl = extract32(env->psw, PSW_IPL, 4); > +if (all) { > +env->psw_pm = extract32(env->psw, PSW_PM, 1); > +} > +env

Re: [Qemu-devel] [PATCH] .travis.yml: reduce number of targets built while disabling things

2019-03-21 Thread Wainer dos Santos Moschetta
On 03/21/2019 09:48 AM, Alex Bennée wrote: This build keeps timing out on Travis and it's unlikely including the additional guest front-ends will catch any failures in the fallback code. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Rev

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-21 Thread Laszlo Ersek
On 03/21/19 17:55, Laszlo Ersek wrote: > On 03/21/19 12:52, Peter Maydell wrote: >> On Thu, 21 Mar 2019 at 11:34, Laszlo Ersek wrote: >>> >>> Repo: https://github.com/lersek/qemu.git >>> Branch: edk2_build_v3 >>> >>> Version 2, that is: >>> >>> [Qemu-devel] [PATCH v2 00/12] bundle edk2 platfor

  1   2   3   >