On 2018-12-25 23:46, liebre...@grossmann-venter.com wrote:
> I have been using Qemu in the past about 8 years ago or so to run legacy
> windows software.
>
> I installed the latest qemu and noticed a lot changed and cant find
> conclusive answers online.
>
> I am writing this post to find what is
On 12/15/18 4:42 AM, Emilio G. Cota wrote:
> +#if TCG_TARGET_IMPLEMENTS_DYN_TLB
> +#define CPU_TLB_DYN_MIN_BITS 6
> +#define CPU_TLB_DYN_DEFAULT_BITS 8
> +/*
> + * Assuming TARGET_PAGE_BITS==12, with 2**22 entries we can cover 2**(22+12)
> ==
> + * 2**34 == 16G of address space. This is roughly wh
On Tue, Dec 25, 2018 at 12:00:08PM -0500, Michael S. Tsirkin wrote:
> On Sat, Dec 22, 2018 at 08:41:37AM +0800, Yu Zhang wrote:
> > On Fri, Dec 21, 2018 at 01:10:13PM -0500, Michael S. Tsirkin wrote:
> > > On Sat, Dec 22, 2018 at 01:34:01AM +0800, Yu Zhang wrote:
> > > > On Fri, Dec 21, 2018 at 12:
On Tue, Dec 25, 2018 at 11:56:19AM -0500, Michael S. Tsirkin wrote:
> On Sat, Dec 22, 2018 at 09:11:26AM +0800, Yu Zhang wrote:
> > On Fri, Dec 21, 2018 at 02:02:28PM -0500, Michael S. Tsirkin wrote:
> > > On Sat, Dec 22, 2018 at 01:37:58AM +0800, Yu Zhang wrote:
> > > > On Fri, Dec 21, 2018 at 12:
Patchew URL: https://patchew.org/QEMU/20181220183059.20726-1-...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181220183059.20726-1-...@redhat.com
Type: series
Subject: [Qemu-devel] [PULL v3 00/44] pci, pc, virtio: fi
Patchew URL:
https://patchew.org/QEMU/20181218142629.15943-1-berra...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
The pointer may be unaligned, so we must use our routines for that.
At the same time, we might as well use the big-endian version
instead of ntohs.
This fixes sparc64 host SIGBUS during pxe boot.
Signed-off-by: Richard Henderson
---
slirp/slirp.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
QOM cpu.h uses fprintf_function which requires Qemu's
qemu/fprintf-fn.h header. Include it.
Signed-off-by: Priit Laes
---
include/qom/cpu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 1396f53e5b..6d1ba53d72 100644
--- a/include/qom/cpu.h
+++ b/
Patchew URL:
https://patchew.org/QEMU/cover.1545246859.git.alistair.fran...@wdc.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: cover.1545246859.git.alistair.fran...@wdc.com
Type: series
Subject: [Qemu-devel] [PATCH v2 00/23]
On 12/26/18 12:28 PM, Nick Renieris wrote:
> Hi Richard,
>
> I did know about https://github.com/andikleen/qemu-avx but didn't
> mention it as it seems abandoned and quite old (also it doesn't use
> `TCGv_vec`).
Yep. Mine pre-dates tcg-op-gvec.h as well.
> Do you think this could work as a GSoC
Hi Richard,
I did know about https://github.com/andikleen/qemu-avx but didn't
mention it as it seems abandoned and quite old (also it doesn't use
`TCGv_vec`).
Do you think this could work as a GSoC project? I'm potentially
interested in working on it this summer.
Thanks,
Nick R.
Στις Τετ, 26 Δεκ
On 12/26/18 10:43 AM, Nick Renieris wrote:
> Hello,
>
> What's the current status on AVX support for TCG? Is there anyone working on
> it?
> Is there interest for it?
A couple of people, including myself, have started on it, but no results posted
so far. It's a large amount of work to clean up
Hello,
What's the current status on AVX support for TCG? Is there anyone working on it?
Is there interest for it?
Effort was put into making 'TCGv_vec', as elaborated in this talk:
"[2017] Vectoring in on QEMU's TCG Engine by Alex Bennée"
(https://www.youtube.com/watch?v=IYHTwnde0g8)
,yet there
I have been using Qemu in the past about 8 years ago or so to run legacy
windows software.
I installed the latest qemu and noticed a lot changed and cant find
conclusive answers online.
I am writing this post to find what is the right way to start to set up
qemu with a windows 7 pro guest. I
I have been using Qemu in the past about 8 years ago or so to run legacy
windows software.
I installed the latest qemu and noticed a lot changed and cant find
conclusive answers online.
I am writing this post to find what is the right way to start to set up
qemu with a windows 7 pro guest. I
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.h | 3 ---
tcg/tcg.c | 44 +---
2 files changed, 37 insertions(+), 10 deletions(-)
diff --git a/tcg/tcg.h b/tcg/tcg.h
index c6721cc7a7..5e5cf686a3 100644
--- a/tcg/tcg.h
+++ b/tcg/t
Pass this through to temp_sync.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index fe060c481a..7844158a8a 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -3077,7 +3077,8 @@
Delete trivially dead code that follows unconditional branches and
noreturn helpers. These can occur either via optimization or via
the structure of a target's translator following an exception.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 76 +++
Remember which helpers have been marked noreturn.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
include/exec/helper-head.h | 13 +
include/exec/helper-tcg.h | 21 ++---
tcg/tcg.h | 2 ++
3 files changed, 29 insertions(+), 7 delet
Previously, the low 4 bits were used for TCG_CALL_TYPE_MASK,
which was removed in 6a18ae2d2947532d5c26439548afa0481c4529f9.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tcg/tcg.h b/tcg/tcg.h
Free the argument register only after we have verified that the
temporary is not already in that register. This case is likely
now that we are back propagating the preferred register.
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
This causes a build error with debian sid, riscv64 host:
disas/microblaze.c:179: error: "REG_SP" redefined [-Werror]
#define REG_SP 1 /* stack pointer */
In file included from /usr/include/signal.h:306,
from include/qemu/osdep.h:101,
from disas/microblaze.c:36:
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
disas.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/disas.c b/disas.c
index f9c517b358..d9a
Use this to notice the opcodes that exit the TB, which implies
that local temps are really dead and need not be synced.
Previously we so marked the true end of the TB, but that was
immediately overwritten by the la_bb_end invoked by any
TCG_OPF_BB_END opcode, like exit_tb.
Reviewed-by: Emilio G.
With these preferences, we can arrange for function call arguments to
be computed into the proper registers instead of requiring extra moves.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 197 +-
1 file changed,
There are two blocks of the form
if (foo) {
stuff1;
goto bar;
} else {
baz:
stuff2;
}
which have unnecessary and confusing indentation.
Remove the else and unindent stuff2.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 139
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<7c47f00cb4a9a777120456e0704b4076a5d943ab.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 496 +++
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 35 +++
1 file changed, 23 insertions(+), 12 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 0afc6ba1e6..4f0acf8863 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -2395,6 +2395,26 @@ st
Allocate storage for, but do not yet fill in, per-opcode
preferences for the output operands. Pass it in to the
register allocation routines for output operands.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.h | 3 +++
tcg/tcg.c | 18 +++---
2 files chan
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<1a0a7e8f3347764f212c5efa5c07c9be17efdec6.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 256 +++
No need for a "tcg_" prefix for a static function; we already
have another "la_" prefix for indicating liveness analysis.
Pass in nb_globals and nb_temps, as we will already have them
in registers for other loops within the parent function.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Hende
Try harder to honor the output_pref. When we're forced to allocate
a second register for the input, it does not need to use the input
constraint; that will be honored by the register we allocate for the
output and a move is already required.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Hen
Pass this through to tcg_reg_alloc.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 210bd5c6b9..351d302a68 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -283
From: Alistair Francis
Signed-off-by: Alistair Francis
Reviewed-by: Richard Henderson
Message-Id:
<5665a57809e32b35775e8e98fdab898853af37b8.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 55 ++
1
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<52160afacecc5b109dc43a412fa3e74ddd6277fb.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
configure | 12 ++--
1 file changed,
Pass this through to tcg_reg_alloc.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 351d302a68..fe060c481a 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -2865,
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<6ac4f4b0d5ea93cb0ee9a3b8b47ee9f7b3711494.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 88
This new argument will aid register allocation by indicating how
the temporary will be used in future. If the preference cannot
be satisfied, fall back to the constraints of the current insn.
Short circuit the preference when it cannot be satisfied or if
it does not further constrain the operatio
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/tcg/riscv/tcg-
Increment when adding branches, and decrement when removing them.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
tcg/tcg-op.h | 1 +
tcg/tcg.h| 3 ++-
tcg/tcg-op.c | 2 ++
tcg/tcg.c| 20
4 files changed, 25 insertions(+), 1 deletion(-)
diff --g
Reviewed-by: Alistair Francis
Signed-off-by: Richard Henderson
---
linux-user/host/riscv64/hostdep.h | 23 +++
linux-user/host/riscv64/safe-syscall.inc.S | 77 ++
2 files changed, 100 insertions(+)
create mode 100644 linux-user/host/riscv64/safe-syscall.inc.S
d
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 48 ++
1 file changed, 48 insertions(+)
diff --git a/tcg/ris
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 111 +
1 file changed, 111 insertions(+)
diff --git a/tcg/ri
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<2e047a95c39c007c66cda024c095e29b0ac4c43e.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 158 +++
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
accel/tcg/user-exec.c | 75 +++
1 file changed, 75 insertions(+)
diff --git a/accel/t
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 145 +
1 file changed, 145 insertions(+)
diff --git a/tcg/ri
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 90 ++
1 file changed, 90 insertions(+)
diff --git a/tcg/ris
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 65 ++
1 file changed, 65 insertions(+)
diff --git a/tcg/ris
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tcg/riscv/t
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 168 +
1 file changed, 168 insertions(+)
diff --git a/tcg/ri
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 86 ++
1 file changed, 86 insertions(+)
diff --git a/tcg/ris
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<76f8f9383a766dbcade883e897dec8cfef669799.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
linux-user/host/riscv32/hostdep.h | 11 +
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<6e43abaa64361d57b9bc9439820d0e7701f2d47e.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.inc.c | 118 +++
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<9d777f619840a8dd8e4f3834dcfc3bd28e052ccd.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
linux-user/host/riscv64/hostdep.h | 11 +
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Richard Henderson
---
tcg/riscv/tcg-target.h | 177 +
MAINTAINERS| 10 ++-
2 files changed, 186
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<00d02e34f10b87fd61f8dc69ac93d1eb63df949c.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
include/exec/poison.h | 1 +
1 file changed,
From: Alistair Francis
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Richard Henderson
Message-Id:
<02fc0b3a733f5f08eb396bee5afd3d327941f0c9.1545246859.git.alistair.fran...@wdc.com>
Signed-off-by: Richard Henderson
---
include/elf.h | 55 +
The following changes since commit 9b2e891ec5ccdb4a7d583b77988848282606fdea:
Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into
staging (2018-12-22 11:25:31 +)
are available in the Git repository at:
https://github.com/rth7680/qemu.git tags/pull-tcg-20181226
for
On 12/22/18 6:52 AM, Emilio G. Cota wrote:
> At this point random_ops[] only contains normals, so there's
> no need to do anything to them. In fact, raising the exponent
> here can make the output !normal, which is precisely
> what the comment says we want to avoid.
>
> Signed-off-by: Emilio G. Co
On 12/22/18 6:51 AM, Emilio G. Cota wrote:
> The second test in the branches is wrong; fix while converting
> to a switch statement, which is easier to get right.
>
> Signed-off-by: Emilio G. Cota
> ---
> tests/fp/fp-bench.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
Wh
On 12/23/18 10:38 PM, Mark Cave-Ayland wrote:
> -#define VEXT_SIGNED(name, element, mask, cast, recast) \
> +#define VEXT_SIGNED(name, element, access, mask, cast, recast) \
> void helper_##name(ppc_avr_t *r, ppc_avr_t *b) \
> {
On 12/23/18 10:38 PM, Mark Cave-Ayland wrote:
> These macros can be eliminated by instead using the relavant Vsr* macros in
> the few locations where they appear.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> target/ppc/int_helper.c | 66
> -
> 1 fi
On 12/23/18 10:38 PM, Mark Cave-Ayland wrote:
> -#define VMUL_DO(name, mul_element, prod_element, cast, evenp) \
> +#define VMUL_DO_EVN(name, mul_element, mul_access, prod_access, cast) \
> void helper_v##name(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \
> {
On 12/23/18 10:38 PM, Mark Cave-Ayland wrote:
> This prepares us for eliminating the use of direct array access within the VMX
> instruction implementations.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> target/ppc/internal.h | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
Reviewe
Sorry I missed the original post, but:
> +} else if (unlikely((XRb == 0) && (XRc == 0))) {
> +/* both operands zero registers -> just set destination to zero */
> +tcg_gen_movi_i32(mxu_gpr[XRa - 1], 0);
> +} else if (unlikely((XRb == 0) || (XRc == 0))) {
> +/* exact
Patchew URL: https://patchew.org/QEMU/20181219120904.17643-1-kra...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#
On Sat, Dec 22, 2018 at 08:41:37AM +0800, Yu Zhang wrote:
> On Fri, Dec 21, 2018 at 01:10:13PM -0500, Michael S. Tsirkin wrote:
> > On Sat, Dec 22, 2018 at 01:34:01AM +0800, Yu Zhang wrote:
> > > On Fri, Dec 21, 2018 at 12:15:26PM -0500, Michael S. Tsirkin wrote:
> > > > On Sat, Dec 22, 2018 at 12:
On Sat, Dec 22, 2018 at 09:11:26AM +0800, Yu Zhang wrote:
> On Fri, Dec 21, 2018 at 02:02:28PM -0500, Michael S. Tsirkin wrote:
> > On Sat, Dec 22, 2018 at 01:37:58AM +0800, Yu Zhang wrote:
> > > On Fri, Dec 21, 2018 at 12:04:49PM -0500, Michael S. Tsirkin wrote:
> > > > On Sat, Dec 22, 2018 at 12:
Patchew URL:
https://patchew.org/QEMU/20181219183902.27273-1-alex.ben...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181219183902.27273-1-alex.ben...@linaro.org
Type: series
Subject: [Qemu-devel] [PATCH] tests/tcg:
Patchew URL: https://patchew.org/QEMU/20181219151917.3874-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181219151917.3874-1-pbonz...@redhat.com
Type: series
Subject: [Qemu-devel] [PULL v2 00/35] Misc patche
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread failed to be created in either
qemu-thread-posix.c or qemu-thread-win32.c.
Cc: Stefan Weil
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
util/qemu-thread-posix.c | 3 +++
util/qemu-thread
Update qemu_thread_create()'s callers by
- setting an error on qemu_thread_create() failure for callers that
set an error on failure;
- reporting the error and returning failure for callers that return
an error code on failure;
- reporting the error and setting some state for callers that just
qemu_thread_create() abort()s on error. Not nice. Give it a return
value and an Error ** argument, so it can return success/failure.
Considering qemu_thread_create() is quite widely used in qemu, split
this into two steps: this patch passes the &error_abort to
qemu_thread_create() everywhere, and
The callers of qemu_init_vcpu() already passed the **errp to handle
errors. In view of this, add a new Error parameter to qemu_init_vcpu()
and all qemu_X_start_vcpu() functions called by qemu_init_vcpu() to
propagate the error and let the further callers check it.
Besides, make qemu_init_vcpu() re
For iothread_complete: utilize the existed errp to propagate the
error and do the corresponding cleanup to replace the temporary
&error_abort.
For qemu_signalfd_compat: add a local_err to hold the error, and
return the corresponding error code to replace the temporary
&error_abort.
Cc: Markus Arm
Add a local_err to hold the error, and return the corresponding
error code to replace the temporary &error_abort.
Cc: Markus Armbruster
Cc: David Gibson
Signed-off-by: Fei Li
---
hw/ppc/spapr_hcall.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/ppc/spapr_
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &local_err
is never used in multifd_save_cleanup(), remove it. And make the
function be: void multifd_save_cleanup(void).
Cc: Dr. David Alan Gilbert
Signed-off-by: Fei
Supplement the error handling for touch_all_pages: add an Error
parameter for it to propagate the error to its caller to do the
handling in case it fails.
Cc: Markus Armbruster
Signed-off-by: Fei Li
---
util/oslib-posix.c | 25 -
1 file changed, 16 insertions(+), 9 delet
Utilize the existed errp to propagate the error and do the
corresponding cleanup to replace the temporary &error_abort.
Cc: Cc: Markus Armbruster
Cc: Gerd Hoffmann
Signed-off-by: Fei Li
---
hw/usb/ccid-card-emulated.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff
In the current code, if process_incoming_migration_co() fails we do
the same error handing: set the error state, close the source file,
do the cleanup for multifd, and then exit(EXIT_FAILURE). To make the
code clearer, add a "goto fail" to unify the error handling.
Cc: Markus Armbruster
Cc: Dr. D
Supplement the error handling for vnc_thread_worker_thread: add
an Error parameter for it to propagate the error to its caller to
handle in case it fails, and make it return a Boolean to indicate
whether it succeeds.
Cc: Markus Armbruster
Cc: Gerd Hoffmann
Signed-off-by: Fei Li
---
ui/vnc-jobs
Utilize the existed errp to propagate the error instead of the
temporary &error_abort.
Cc: Markus Armbruster
Cc: Marc-André Lureau
Signed-off-by: Fei Li
---
dump.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/dump.c b/dump.c
index c35d6ddd22..ef5ea324fa 100644
---
In our current code, when multifd is used during migration, if there
is an error before the destination receives all new channels, the
source keeps running, however the destination does not exit but keeps
waiting until the source is killed deliberately.
Fix this by dumping the specific error and l
Utilize the existed errp to propagate the error instead of the
temporary &error_abort.
Cc: Markus Armbruster
Cc: Jiri Slaby
Signed-off-by: Fei Li
---
hw/misc/edu.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 3f4ba7ded3..011fe6e
Call postcopy_ram_incoming_cleanup() to do the cleanup when
postcopy_ram_enable_notify fails. Besides, report the error
message when qemu_ram_foreach_migratable_block() fails.
Cc: Dr. David Alan Gilbert
Signed-off-by: Fei Li
Reviewed-by: Dr. David Alan Gilbert
---
migration/postcopy-ram.c | 1
Hi,
This idea comes from BiteSizedTasks, and this patch series implement
the error checking of qemu_thread_create: make qemu_thread_create
return a flag to indicate if it succeeded rather than failing with an
error; make all callers check it.
The first and the last patch fixes some segmentation f
When qemu_signal_init() fails in qemu_init_main_loop(), we return
without setting an error. Its callers crash then when they try to
report the error with error_report_err().
To avoid such segmentation fault, add a new Error parameter to make
the call trace to propagate the err to the final caller
vaddr needs to be equal to the paddr since the dump file represents the
physical memory image.
Without setting vaddr correctly, GDB would load all the different memory
regions on top of each other to vaddr 0, thus making GDB showing the wrong
memory data for a given address.
Signed-off-by: Jon Do
Hi all,
As I am leaving my current company and most reviewers are on holiday,
I'd like to send a new version now:
v9: "qemu_thread: Make qemu_thread_create() handle errors properly",
although some details like whether it is appropriate to report the error
to be seen by the management layer. And I
On 12/24/18 4:49 PM, Wainer dos Santos Moschetta wrote:
> Signed-off-by: Wainer dos Santos Moschetta
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/core/machine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 4439ea663f.
On Tue, Dec 25, 2018 at 12:15 PM Philippe Mathieu-Daudé wrote:
>
> Hi Emilio,
>
> On 12/25/18 8:03 AM, Emilio G. Cota wrote:
> > The added branch to the FMA ops is marked as unlikely and therefore
> > its impact on performance (measured with fp-bench) is within noise range
> > when measured on an
Hi Emilio,
On 12/25/18 8:03 AM, Emilio G. Cota wrote:
> The added branch to the FMA ops is marked as unlikely and therefore
> its impact on performance (measured with fp-bench) is within noise range
> when measured on an Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz.
Did you forget to write here the r
Hi Zoltán,
On 12/23/18 9:52 PM, Kővágó, Zoltán wrote:
> Signed-off-by: Kővágó, Zoltán
> ---
> audio/alsaaudio.c | 8 +-
> audio/audio.c | 162
> audio/audio.h | 4 +-
> audio/audio_int.h | 22 +++---
> audio/audio_temp
On 12/23/18 9:52 PM, Kővágó, Zoltán wrote:
> With stereo playback, they need about 375 minutes of continuous audio
> playback to overflow, which is usually not a problem (as stopping and
> later resuming playback resets the counters). But with 7.1 audio, they
> only need about 95 minutes to overfl
Hi Zoltán,
On 12/23/18 9:51 PM, Kővágó, Zoltán wrote:
> I've updated my audio patchset to the current git master. Other than that not
> much happened since my last update [1], fixed a few small problems that I
> noticed while rebasing my patches.
For a such series with refactors and typedefs chan
On 12/24/18 9:48 PM, Kővágó Zoltán wrote:
> On 2018-12-24 18:16, Philippe Mathieu-Daudé wrote:
>> On 12/24/18 3:16 AM, Zoltán Kővágó wrote:
>>> Hi Phil,
>>>
>>> On 2018-12-24 00:49, Philippe Mathieu-Daudé wrote:
Hi Zoltán,
On 12/23/18 9:51 PM, Kővágó, Zoltán wrote:
> There's alre
24.12.2018 23:42, Nir Soffer wrote:
> On Mon, Dec 24, 2018 at 5:50 PM Vladimir Sementsov-Ogievskiy
> mailto:vsement...@virtuozzo.com>> wrote:
>
> Hi all!
>
> bdrv_co_block_status digs bs->file for additional, more accurate search
> for hole
> inside region, reported as DATA by bs si
> From: Qemu-devel [mailto:qemu-devel-bounces+luwei.kang=intel@nongnu.org]
> On Behalf Of Paolo Bonzini
> Sent: Friday, December 21, 2018 8:44 PM
> To: qemu-devel@nongnu.org
> Cc: ehabk...@redhat.com; qemu-sta...@nongnu.org
> Subject: [Qemu-devel] [PATCH] i386: mark the 'INTEL_PT' CPUID bit as
98 matches
Mail list logo
