Re: [Qemu-devel] [PATCH v2 00/23] Add RISC-V TCG backend support

2018-12-19 Thread Richard Henderson
On 12/19/18 11:16 AM, Alistair Francis wrote: > This patch set adds RISC-V backend support to QEMU. This is based on > Michael Clark's original work with extra work on top. > > This has been somewhat tested and can run other architecture softmmu > code. It seems that any complex OS will eventually

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-19 Thread Yu Zhang
On Wed, Dec 19, 2018 at 11:47:23AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2018 at 11:40:37AM +0100, Igor Mammedov wrote: > > On Wed, 19 Dec 2018 10:57:17 +0800 > > Yu Zhang wrote: > > > > > On Tue, Dec 18, 2018 at 03:55:36PM +0100, Igor Mammedov wrote: > > > > On Tue, 18 Dec 2018 17:2

Re: [Qemu-devel] [PATCH v2 18/23] riscv: tcg-target: Add the out op decoder

2018-12-19 Thread Richard Henderson
On 12/19/18 11:19 AM, Alistair Francis wrote: > +case INDEX_op_ext32s_i64: > +case INDEX_op_extrl_i64_i32: > +case INDEX_op_extrh_i64_i32: > +case INDEX_op_ext_i32_i64: > +tcg_out_ext32s(s, a0, a1); > +break; This is the last bug that's easy to identify. It shows u

Re: [Qemu-devel] [PATCH v3 2/2] intel-iommu: extend VTD emulation to allow 57-bit IOVA address width.

2018-12-19 Thread Yu Zhang
On Wed, Dec 19, 2018 at 10:23:44AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2018 at 01:57:43PM +0800, Yu Zhang wrote: > > On Tue, Dec 18, 2018 at 11:35:34PM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 19, 2018 at 11:40:06AM +0800, Yu Zhang wrote: > > > > On Tue, Dec 18, 2018 at 09:

[Qemu-devel] [PATCH v2 2/3] x86-iommu: switch intr_supported to OnOffAuto type

2018-12-19 Thread Peter Xu
Switch the intr_supported variable from a boolean to OnOffAuto type so that we can know whether the user specified it or not. With that we'll have a chance to help the user to choose more wisely where possible. Introduce x86_iommu_ir_supported() to mask these changes. No functional change at all

Re: [Qemu-devel] Monitor and serial output window broken with SDL2

2018-12-19 Thread Gerd Hoffmann
On Wed, Dec 19, 2018 at 07:11:34PM +0100, BALATON Zoltan wrote: > On Wed, 19 Dec 2018, Daniel P. Berrangé wrote: > > On Tue, Dec 18, 2018 at 08:05:59PM +0100, BALATON Zoltan wrote: > > > On Tue, 18 Dec 2018, Daniel P. Berrangé wrote: > > > > I don't see any difference depending on whether I use Ctr

[Qemu-devel] [PATCH v2 1/3] q35: set split kernel irqchip as default

2018-12-19 Thread Peter Xu
Starting from QEMU 4.0, let's specify "split" as the default value for kernel-irqchip. So for QEMU>=4.0 we'll have: allowed=Y,required=N,split=Y for QEMU<=3.1 we'll have: allowed=Y,required=N,split=N (omitting all the "kernel_irqchip_" prefix) Note that this will let the default q35 machine

[Qemu-devel] [PATCH v2 3/3] x86-iommu: turn on IR by default if proper

2018-12-19 Thread Peter Xu
When the user didn't specify "intremap" for the IOMMU device, we turn it on by default if it is supported. This will turn IR on for the default Q35 platform as long as the IOMMU device is specified on new kernels. Signed-off-by: Peter Xu --- hw/i386/x86-iommu.c | 7 --- 1 file changed, 4 in

[Qemu-devel] [PATCH v2 0/3] q35: change defaults for kernel irqchip and IR

2018-12-19 Thread Peter Xu
v2: - drop patch 1, so we don't even need to consider old kernels for the default value [Paolo, Eduardo] - fix up commit message of the split irqchip patch to mention that = Original cover letter This only changes q35. Nothing else. Before this series, we have the

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Yi Zhang
On 2018-12-19 at 22:42:07 -0500, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi Zhang wrote: > > On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi Zhang wrote: > > > > > > + > > > > > > + - 'sync' option of memory

Re: [Qemu-devel] [PATCH 2/4] q35: set split kernel irqchip as default

2018-12-19 Thread Peter Xu
On Wed, Dec 19, 2018 at 10:45:40PM +0100, Paolo Bonzini wrote: > On 19/12/18 22:24, Eduardo Habkost wrote: > > On Wed, Dec 19, 2018 at 09:12:55PM +0100, Paolo Bonzini wrote: > >> On 19/12/18 09:50, Peter Xu wrote: > >>> Starting from QEMU 4.0, let's specify "split" as the default value for > >>> ke

[Qemu-devel] [Bug 1808824] Re: Mouse leaves VM window when Grab on Hover isn't selected Windows 10 and Intel HAX

2018-12-19 Thread William Razgunas
https://youtu.be/Vpi59ptOiyc Here is a video demonstrating the main issue. This does not show any lag but, it does show how VM doesn't capture the mouse correctly. After capture if you move the mouse far enough off the VM window the mouse goes out of the window in odd places that isn't represent

[Qemu-devel] [PATCH] disas/microblaze: Remove unused REG_SP macro

2018-12-19 Thread Richard Henderson
This causes a build error with debian sid, riscv64 host: disas/microblaze.c:179: error: "REG_SP" redefined [-Werror] #define REG_SP 1 /* stack pointer */ In file included from /usr/include/signal.h:306, from include/qemu/osdep.h:101, from disas/microblaze.c:36:

Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket

2018-12-19 Thread Yongji Xie
On Wed, 19 Dec 2018 at 23:55, Michael S. Tsirkin wrote: > > On Tue, Dec 18, 2018 at 04:09:19PM +, Daniel P. Berrangé wrote: > > On Tue, Dec 18, 2018 at 11:02:46AM -0500, Michael S. Tsirkin wrote: > > > On Tue, Dec 18, 2018 at 03:25:20PM +, Daniel P. Berrangé wrote: > > > > On Tue, Dec 18,

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Michael S. Tsirkin
On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi Zhang wrote: > On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi Zhang wrote: > > > > > + > > > > > + - 'sync' option of memory-backend-file is not 'off', and > > > > > + > > > > > + - 'share' opt

Re: [Qemu-devel] [PATCH for-4.0 v8 3/7] migration: fix the multifd code when receiving less channels

2018-12-19 Thread Fei Li
On 12/19/2018 10:11 PM, Markus Armbruster wrote: Fei Li writes: On 12/13/2018 02:17 PM, Markus Armbruster wrote: Fei Li writes: In our current code, when multifd is used during migration, if there is an error before the destination receives all new channels, the source keeps running, ho

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Fei Li
On 12/20/2018 01:29 AM, Eric Blake wrote: On 12/19/18 6:14 AM, Fei Li wrote:    28 files changed, 243 insertions(+), 101 deletions(-) I recommend to split this patch.  First part adds the Error ** parameter to qemu_thread_create(), passing &error_abort everywhere. No functional change. 

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Yi Zhang
On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi Zhang wrote: > > > > + > > > > + - 'sync' option of memory-backend-file is not 'off', and > > > > + > > > > + - 'share' option of memory-backend-file is 'on'. > > > > + > > > > + - 'pmem' optio

Re: [Qemu-devel] [PATCH v5 11/11] iotests: add iotest 236 for testing bitmap merge

2018-12-19 Thread Eric Blake
On 12/19/18 8:29 PM, John Snow wrote: New interface, new smoke test. Signed-off-by: John Snow --- tests/qemu-iotests/236 | 161 + tests/qemu-iotests/236.out | 351 + tests/qemu-iotests/group | 1 + 3 files changed, 513 insertions(

Re: [Qemu-devel] [PATCH v5 10/11] iotests: implement pretty-print for log and qmp_log

2018-12-19 Thread Eric Blake
On 12/19/18 8:29 PM, John Snow wrote: If iotests have lines exceeding >998 characters long, git doesn't want to send it plaintext to the list. We can solve this by allowing the iotests to use pretty printed QMP output that we can match against instead. As a bonus, it's much nicer for human eyes

Re: [Qemu-devel] [PATCH v5 09/11] iotests: change qmp_log filters to expect QMP objects only

2018-12-19 Thread Eric Blake
On 12/19/18 8:29 PM, John Snow wrote: As laid out in the previous commit's message: ``` Several places in iotests deal with serializing objects into JSON strings, but to add pretty-printing it seems desireable to localize s/desireable/desirable/ all of those cases. log() seems like a good c

Re: [Qemu-devel] [PATCH v5 08/11] iotests: remove default filters from qmp_log

2018-12-19 Thread Eric Blake
On 12/19/18 8:29 PM, John Snow wrote: Several places in iotests deal with serializing objects into JSON strings, but to add pretty-printing it seems desireable to localize s/desireable/desirable/ all of those cases. log() seems like a good candidate for that centralized behavior. log() can a

Re: [Qemu-devel] [PATCH v5 03/11] blockdev: n-ary bitmap merge

2018-12-19 Thread Eric Blake
On 12/19/18 8:29 PM, John Snow wrote: Especially outside of transactions, it is helpful to provide all-or-nothing semantics for bitmap merges. This facilitates the coalescing of multiple bitmaps into a single target for the "checkpoint" interpretation when assembling bitmaps that represent arbitr

Re: [Qemu-devel] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore

2018-12-19 Thread Eric Blake
On 12/19/18 8:29 PM, John Snow wrote: When making a backup of a dirty bitmap (for transactions), we want to restore that backup whether or not the bitmap is enabled or not. drop one of the two 'or not' It is perfectly valid to write into bitmaps that are disabled. It is only illegitimate for

Re: [Qemu-devel] [PATCH v5 07/11] iotests: add qmp recursive sorting function

2018-12-19 Thread Eric Blake
On 12/19/18 8:29 PM, John Snow wrote: Python before 3.6 does not sort dictionaries (including kwargs). Therefore, printing QMP objects involves sorting the keys to have a predictable ordering in the iotests output. It may be worth also mentioning that sometimes this sorting results in the log

[Qemu-devel] [PATCH v5 06/11] iotests: add filter_generated_node_ids

2018-12-19 Thread John Snow
To mimic the common filter of the same name, but for the python tests. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-

[Qemu-devel] [PATCH v5 09/11] iotests: change qmp_log filters to expect QMP objects only

2018-12-19 Thread John Snow
As laid out in the previous commit's message: ``` Several places in iotests deal with serializing objects into JSON strings, but to add pretty-printing it seems desireable to localize all of those cases. log() seems like a good candidate for that centralized behavior. log() can already serialize

[Qemu-devel] [PATCH v5 05/11] iotests.py: don't abort if IMGKEYSECRET is undefined

2018-12-19 Thread John Snow
Instead of using os.environ[], use .get with a default of empty string to match the setup in check to allow us to import the iotests module (for debugging, say) without needing a crafted environment just to import the module. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir

[Qemu-devel] [PATCH v5 07/11] iotests: add qmp recursive sorting function

2018-12-19 Thread John Snow
Python before 3.6 does not sort dictionaries (including kwargs). Therefore, printing QMP objects involves sorting the keys to have a predictable ordering in the iotests output. However, if we want to pretty-print QMP objects being sent to the QEMU process, we need to build the entire command befor

[Qemu-devel] [PATCH v5 04/11] block: remove 'x' prefix from experimental bitmap APIs

2018-12-19 Thread John Snow
The 'x' prefix was added because I was uncertain of the direction we'd take for the libvirt API. With the general approach solidified, I feel comfortable committing to this API for 4.0. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- blockdev.c

[Qemu-devel] [PATCH v5 01/11] blockdev: abort transactions in reverse order

2018-12-19 Thread John Snow
Presently, we abort transactions in the same order they were processed in. Bitmap commands, though, attempt to restore backup data structures on abort. That's not valid, they need to be aborted in reverse chronological order. Replace the QSIMPLEQ data structure with a QTAILQ one, so we can iterat

[Qemu-devel] [PATCH v5 03/11] blockdev: n-ary bitmap merge

2018-12-19 Thread John Snow
Especially outside of transactions, it is helpful to provide all-or-nothing semantics for bitmap merges. This facilitates the coalescing of multiple bitmaps into a single target for the "checkpoint" interpretation when assembling bitmaps that represent arbitrary points in time from component bitmap

[Qemu-devel] [PATCH v5 10/11] iotests: implement pretty-print for log and qmp_log

2018-12-19 Thread John Snow
If iotests have lines exceeding >998 characters long, git doesn't want to send it plaintext to the list. We can solve this by allowing the iotests to use pretty printed QMP output that we can match against instead. As a bonus, it's much nicer for human eyes too. Signed-off-by: John Snow --- tes

[Qemu-devel] [PATCH v5 08/11] iotests: remove default filters from qmp_log

2018-12-19 Thread John Snow
Several places in iotests deal with serializing objects into JSON strings, but to add pretty-printing it seems desireable to localize all of those cases. log() seems like a good candidate for that centralized behavior. log() can already serialize json objects, but when it does so, it assumes filte

[Qemu-devel] [PATCH v5 11/11] iotests: add iotest 236 for testing bitmap merge

2018-12-19 Thread John Snow
New interface, new smoke test. Signed-off-by: John Snow --- tests/qemu-iotests/236 | 161 + tests/qemu-iotests/236.out | 351 + tests/qemu-iotests/group | 1 + 3 files changed, 513 insertions(+) create mode 100755 tests/qemu-iotests/23

[Qemu-devel] [PATCH v5 00/11] bitmaps: remove x- prefix from QMP api

2018-12-19 Thread John Snow
Fix some outstanding bugs, change the design of an API element, remove the x- prefix to signify stability, and add iotests. V5: 001/11:[] [--] 'blockdev: abort transactions in reverse order' 002/11:[down] 'block/dirty-bitmap: remove assertion from restore' 003/11:[0029] [FC] 'blockdev: n-ary b

[Qemu-devel] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore

2018-12-19 Thread John Snow
When making a backup of a dirty bitmap (for transactions), we want to restore that backup whether or not the bitmap is enabled or not. It is perfectly valid to write into bitmaps that are disabled. It is only illegitimate for the guest to have done so. Remove this assertion. Signed-off-by: John

Re: [Qemu-devel] Booting Raspbian on RPi emulation

2018-12-19 Thread BALATON Zoltan
On Wed, 19 Dec 2018, Ben Hekster via Qemu-devel wrote: While the crashing has stopped, the window isn't responsive to keystrokes. This includes the frame buffer emulation itself (so I can't actually log in) I'm not sure that's supposed to work. I could be wrong but I think USB is not emulat

Re: [Qemu-devel] [PATCH v4 5/5] iotests: add iotest 236 for testing bitmap merge

2018-12-19 Thread John Snow
On 12/19/18 2:34 PM, Eric Blake wrote: > On 12/18/18 7:52 PM, John Snow wrote: >> New interface, new smoke test. >> --- >>   tests/qemu-iotests/236 | 131 >>   tests/qemu-iotests/236.out | 198 + >>   tests/qemu-iotests/group   |   1

Re: [Qemu-devel] Question about aio_poll and glib aio_ctx_dispatch

2018-12-19 Thread Fam Zheng
> On Dec 20, 2018, at 06:58, Li Qiang wrote: > > Hello Paolo > > Thanks for your kind reply. > > Yes, aio_poll and aio_ctx_dispatch mostly run in different threads, though > Sometimes they can run in a thread nested from Fam’s slides: > →http://events17.linuxfoundation.org/sites/events/files

[Qemu-devel] [PATCH v2 1/6] contrib/elf2dmp: fix elf.h including

2018-12-19 Thread Viktor Prutyanov
Before this patch QEMU elf.h was not actually included. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/qemu_elf.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/elf2dmp/qemu_elf.h b/contrib/elf2dmp/qemu_elf.h index d85d6558fa..19d1299954 100644 --- a/con

[Qemu-devel] [PATCH v2 5/6] contrib/elf2dmp: fix printf format

2018-12-19 Thread Viktor Prutyanov
Format strings for printf are changed for successful build for Windows hosts. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/main.c | 27 +++ contrib/elf2dmp/pdb.c | 4 +++- 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/contrib/elf2dmp/main.c b/c

[Qemu-devel] [PATCH v2 3/6] contrib/elf2dmp: use GLib in PDB processing

2018-12-19 Thread Viktor Prutyanov
Replace POSIX mmap with GLib g_mapped_file_new in PDB processing stage to make elf2dmp cross-platform. There are no direct POSIX in elf2dmp after this patch. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/pdb.c | 29 - contrib/elf2dmp/pdb.h | 2 +- 2 files chang

[Qemu-devel] [PATCH v2 2/6] contrib/elf2dmp: use GLib in ELF processing

2018-12-19 Thread Viktor Prutyanov
Replace POSIX mmap with GLib g_mapped_file_new in ELF processing module to make elf2dmp cross-platform. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/qemu_elf.c | 27 --- contrib/elf2dmp/qemu_elf.h | 2 +- 2 files changed, 9 insertions(+), 20 deletions(-) diff --g

[Qemu-devel] [PATCH v2 6/6] configure: enable elf2dmp build for Windows hosts

2018-12-19 Thread Viktor Prutyanov
After this patch contrib/elf2dmp can be built for Windows x86 and x86_64 hosts by mingw. Signed-off-by: Viktor Prutyanov --- Makefile | 4 ++-- configure | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index c8b9efdad4..25acb94aa6 100644 --- a/Makefi

[Qemu-devel] [PATCH v2 0/6] contrib/elf2dmp: elf2dmp for Windows hosts

2018-12-19 Thread Viktor Prutyanov
In most cases, it is more convenient to convert a dump on the same machine on which the analysis is performed. Because of WinDbg, the analysis of guest Windows problems needs Windows host anyway, so it is useful to have dump convertion tool near the debugger. After these patches elf2dmp can be buil

[Qemu-devel] [PATCH v2 4/6] contrib/elf2dmp: fix structures definitions

2018-12-19 Thread Viktor Prutyanov
Remove duplicate structures definitions in case of build for Windows hosts. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/kdbg.h | 12 contrib/elf2dmp/pdb.h | 2 ++ contrib/elf2dmp/pe.h | 6 -- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/contrib/el

Re: [Qemu-devel] [PATCH v3 0/7] bitmaps: remove x- prefix from QMP api

2018-12-19 Thread John Snow
On 12/17/18 4:14 PM, John Snow wrote: > > > On 12/14/18 6:15 PM, John Snow wrote: >> Touch up a few last things and remove the x- prefix. >> >> V3: >> - Reworked qmp_log to pretty-print the outgoing command, too [Vladimir] >> - Modified test to log only bitmap information [Vladimir] >> - Te

Re: [Qemu-devel] [PATCH 1/2] i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model

2018-12-19 Thread Robert Hoo
On Wed, 2018-12-19 at 14:01 +, Daniel P. Berrangé wrote: > On Wed, Dec 19, 2018 at 09:44:40PM +0800, Robert Hoo wrote: > > Signed-off-by: Robert Hoo > > --- > >  target/i386/cpu.c | 3 +-- > >  1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/target/i386/cpu.c b/target/i386/

Re: [Qemu-devel] [PATCH for-2.11 v3 12/16] travis/osx: silent texinfo warnings

2018-12-19 Thread Peter Maydell
On Wed, 19 Dec 2018 at 23:13, Philippe Mathieu-Daudé wrote: > I'm trying to reduce OSX warnings, as of current QEMU master I count > 80 warnings using Xcode 10, which result in me not looking at them (or > worst, at new ones...). A lot of them are the address-of-packed-member warnings, which I've

Re: [Qemu-devel] [PATCH for-2.11 v3 12/16] travis/osx: silent texinfo warnings

2018-12-19 Thread Philippe Mathieu-Daudé
On Wed, Dec 19, 2018 at 11:42 PM Peter Maydell wrote: > On Wed, 19 Dec 2018 at 21:34, Philippe Mathieu-Daudé wrote: > > > > Hey Alex, Peter, what do you think about this patch? > > > > On Wed, Aug 9, 2017 at 10:27 PM Philippe Mathieu-Daudé > > wrote: > > > > > > $ make info > > > GEN

Re: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18

2018-12-19 Thread Peter Maydell
On Wed, 19 Dec 2018 at 15:21, Paolo Bonzini wrote: > > The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 > 14:31:06 +) > > are available in the Git repo

[Qemu-devel] 答复: Question about aio_poll and glib aio_ctx_dispatch

2018-12-19 Thread Li Qiang
Hello Paolo Thanks for your kind reply. Yes, aio_poll and aio_ctx_dispatch mostly run in different threads, though Sometimes they can run in a thread nested from Fam’s slides: →http://events17.linuxfoundation.org/sites/events/files/slides/Improving%20the%20QEMU%20Event%20Loop%20-%203.pdf So you

Re: [Qemu-devel] [PATCH for-2.11 v3 12/16] travis/osx: silent texinfo warnings

2018-12-19 Thread Peter Maydell
On Wed, 19 Dec 2018 at 21:34, Philippe Mathieu-Daudé wrote: > > Hey Alex, Peter, what do you think about this patch? > > On Wed, Aug 9, 2017 at 10:27 PM Philippe Mathieu-Daudé > wrote: > > > > $ make info > > GEN qemu-doc.html > > qemu-doc.texi:8: warning: unrecognized encoding name

Re: [Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers

2018-12-19 Thread Philippe Mathieu-Daudé
On 12/19/18 10:12 AM, Markus Armbruster wrote: > Avoids pointless recompilation. Missed in commit 112ed241f5d. > > Signed-off-by: Markus Armbruster > --- > Untested; I don't have access to a Mac. You kinda do, open a GitHub account and enable Travis-CI (free for public projects), then pushing a

Re: [Qemu-devel] [PATCH 2/4] q35: set split kernel irqchip as default

2018-12-19 Thread Paolo Bonzini
On 19/12/18 22:24, Eduardo Habkost wrote: > On Wed, Dec 19, 2018 at 09:12:55PM +0100, Paolo Bonzini wrote: >> On 19/12/18 09:50, Peter Xu wrote: >>> Starting from QEMU 4.0, let's specify "split" as the default value for >>> kernel-irqchip. >>> >>> So for QEMU>=4.0 we'll have: allowed=Y,required=N,s

Re: [Qemu-devel] [PATCH for-2.11 v3 12/16] travis/osx: silent texinfo warnings

2018-12-19 Thread Philippe Mathieu-Daudé
Hey Alex, Peter, what do you think about this patch? On Wed, Aug 9, 2017 at 10:27 PM Philippe Mathieu-Daudé wrote: > > $ make info > GEN qemu-doc.html > qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. > GEN qemu-doc.txt > qemu-doc.texi:8: warning: unrecognized

Re: [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events

2018-12-19 Thread Paolo Bonzini
On 19/12/18 22:30, Paolo Bonzini wrote: > On 07/12/18 17:37, Laurent Vivier wrote: >>> TIL about trace_event_get_state_backends(), I'll use it to clean other >>> hexdump traces, thanks :) >> I've copied that from gdbstub.c where there is an hexdump() function >> using it. >> >> I'm going to send a

Re: [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events

2018-12-19 Thread Paolo Bonzini
On 07/12/18 17:37, Laurent Vivier wrote: >> TIL about trace_event_get_state_backends(), I'll use it to clean other >> hexdump traces, thanks :) > I've copied that from gdbstub.c where there is an hexdump() function > using it. > > I'm going to send a v2 of this patch, because I think it is not nee

Re: [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events

2018-12-19 Thread Paolo Bonzini
On 07/12/18 14:17, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > hw/scsi/scsi-disk.c | 105 +-- > hw/scsi/trace-events | 29 > 2 files changed, 81 insertions(+), 53 deletions(-) > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/

Re: [Qemu-devel] [PATCH 2/4] q35: set split kernel irqchip as default

2018-12-19 Thread Eduardo Habkost
On Wed, Dec 19, 2018 at 09:12:55PM +0100, Paolo Bonzini wrote: > On 19/12/18 09:50, Peter Xu wrote: > > Starting from QEMU 4.0, let's specify "split" as the default value for > > kernel-irqchip. > > > > So for QEMU>=4.0 we'll have: allowed=Y,required=N,split=Y > >for QEMU<=3.1 we'll have: allo

[Qemu-devel] [PATCH v2 0/3] MAINTAINERS: Clean up main target/mips section

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up main target/mips section. Add some new files, add email filter, and reorder items. v1->v2: - fixed typo in a commit message - removed unnecessary "?" in a line for filtering email subjects Aleksandar Markovic (3): MAINTAINERS: target/mips: Add MIPS files

[Qemu-devel] [PATCH v2 3/3] MAINTAINERS: target/mips: Reorder items alphabetically

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Reorder items alphabetically for better visibility. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 05bf140824..7b7ef

[Qemu-devel] [PATCH v2 1/3] MAINTAINERS: target/mips: Add MIPS files under default-configs directory

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Add following files as maintained within the main MIPS target section in MAINTAINERS: default-configs/mips64el-linux-user.mak default-configs/mips64-linux-user.mak default-configs/mipsn32el-linux-user.mak default-configs/mipsn32-linux-user.mak default-configs/mipsel-lin

[Qemu-devel] [PATCH v2 2/3] MAINTAINERS: target/mips: Add filter for mips in email subjects

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Add ability to redirect mails (sent to qemu-devel) containing "mips" in the subject line to MIPS maintainers and reviewers. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAIN

[Qemu-devel] [PATCH v3 7/8] disas: nanoMIPS: Fix an FP-related misnomer 2

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic -uint64 NMD::extract_fs_15_14_13_12_11(uint64 instruction) +uint64 NMD::extract_fs_20_19_18_17_16(uint64 instruction) Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 242 ++--- disas/nanomips.h | 2 +- 2 files ch

[Qemu-devel] [PATCH v3 5/8] disas: nanoMIPS: Name some function in a more descriptive way

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename some functions that have names that are hard to understand. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 112 ++--- disas/nanomips.h | 32 ++--- 2 files changed, 72

[Qemu-devel] [PATCH v3 8/8] disas: nanoMIPS: Fix an FP-related misnomer 3

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename NMD::extract_ft_20_19_18_17_16(uint64 instruction) to NMD::extract_ft_25_24_23_22_21(uint64 instruction). Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 258 ++--- disas/nanomips.h | 2 +- 2 files changed

[Qemu-devel] [PATCH v3 6/8] disas: nanoMIPS: Fix an FP-related misnomer 1

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename NMD::extract_fd_10_9_8_7_6(uint64 instruction) to NMD::extract_fd_15_14_13_12_11(uint64 instruction). Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 142 ++--- disas/nanomips.h | 2 +- 2 files changed, 72

[Qemu-devel] [PATCH v3 2/8] disas: nanoMIPS: Remove functions that are not used

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Some functions were not used at all. Compiler doesn't complain since they are class memebers. Remove them - no future usage is planned. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 208 --

[Qemu-devel] [PATCH v3 0/8] disas: nanoMIPS: Clean up several issues

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up several misc issues in nanoMIPS disassembler. There are more issues to be cleaned, and this is meant to be just the first phase. Complete cleanup should happen over the course of next few months. All these changes should not and do not affect any functionality.

[Qemu-devel] [PATCH v3 3/8] disas: nanoMIPS: Fix a function misnomer

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix wrong function name. The convention in these files is that names of extraction functions should reflect bit patterns they are extracting. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 264 ++--

[Qemu-devel] [PATCH v3 1/8] disas: nanoMIPS: Fix preamble text in nanomips.* files

2018-12-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix several mistakes in preambles of nanomips disassembler source files. Reviewed-by: Stefan Markovic Signed-off-by: Aleksandar Markovic --- disas/nanomips.cpp | 7 --- disas/nanomips.h | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a

Re: [Qemu-devel] Question about aio_poll and glib aio_ctx_dispatch

2018-12-19 Thread Paolo Bonzini
On 19/12/18 11:05, Li Qiang wrote: > Sent it to qemu-devel. > > Li Qiang mailto:liq...@gmail.com>> 于2018年12月19日周 > 三 下午6:04写道: > > Hello Paolo, Stefan, Fam and all, > > Here I have a question about 'aio_poll'. > IIUC the 'aio_poll' is (mostly) used for synchronous IO > as I see a

Re: [Qemu-devel] [PATCH 2/4] q35: set split kernel irqchip as default

2018-12-19 Thread Paolo Bonzini
On 19/12/18 16:52, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2018 at 04:50:36PM +0800, Peter Xu wrote: >> Starting from QEMU 4.0, let's specify "split" as the default value for >> kernel-irqchip. >> >> So for QEMU>=4.0 we'll have: allowed=Y,required=N,split=Y >>for QEMU<=3.1 we'll have: allow

Re: [Qemu-devel] [PATCH 1/4] kvm: let split be optional for kvm_arch_irqchip_create

2018-12-19 Thread Paolo Bonzini
On 19/12/18 16:53, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2018 at 04:50:35PM +0800, Peter Xu wrote: >> This patch allows the kvm_arch_irqchip_create() to return 0 if the >> split irqchip is specified but not forced by the user. Also, modify >> kvm_irqchip_create() similiarly. >> >> This patch

Re: [Qemu-devel] [PATCH 2/4] q35: set split kernel irqchip as default

2018-12-19 Thread Paolo Bonzini
On 19/12/18 09:50, Peter Xu wrote: > Starting from QEMU 4.0, let's specify "split" as the default value for > kernel-irqchip. > > So for QEMU>=4.0 we'll have: allowed=Y,required=N,split=Y >for QEMU<=3.1 we'll have: allowed=Y,required=N,split=N >(omitting all the "kernel_irqchip_" prefix) >

Re: [Qemu-devel] [PATCH v4 3/5] iotests: change qmp_log filters to expect QMP objects only

2018-12-19 Thread John Snow
On 12/19/18 2:01 PM, Eric Blake wrote: > On 12/19/18 5:27 AM, Vladimir Sementsov-Ogievskiy wrote: > >> But still not sure that it worth it. Isn't it better to just remove >> fields from dict, >> which are unpredictable, instead of substituting them.. > > For getting the test to pass when we ha

Re: [Qemu-devel] [PATCH v4 1/5] iotests: add qmp recursive sorting function

2018-12-19 Thread John Snow
On 12/19/18 2:19 PM, Eric Blake wrote: > On 12/19/18 12:57 PM, John Snow wrote: >> >> >> On 12/19/18 1:52 PM, Eric Blake wrote: >>> On 12/18/18 7:52 PM, John Snow wrote: Python before 3.6 does not sort kwargs by default. If we want to print out pretty-printed QMP objects while pre

Re: [Qemu-devel] [PULL 00/64] slirp updates

2018-12-19 Thread Peter Maydell
On Tue, 18 Dec 2018 at 23:04, Samuel Thibault wrote: > > The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 > 14:31:06 +) > > are available in the Git re

Re: [Qemu-devel] Booting Raspbian on RPi emulation

2018-12-19 Thread Ben Hekster via Qemu-devel
Should have tested a little more: While the crashing has stopped, the window isn't responsive to keystrokes. This includes the frame buffer emulation itself (so I can't actually log in) as well as the QEMU Monitor; nothing I type has any effect in either. Ben > On Dec 19, 2018, at 11

Re: [Qemu-devel] [QEMU-devel][PATCH v3] aio-posix: Fix concurrent aio_poll/set_fd_handler.

2018-12-19 Thread Paolo Bonzini
On 19/12/18 17:29, Remy NOEL wrote: >> >> >>> atomic_read(&ctx->poll_disable_cnt) + >>> poll_disable_change); >>>   -    aio_epoll_update(ctx, node, is_new); >>> +    if (new_node) { >>> +    aio_epoll_update(ctx, new_node, is_new); >>> +    } >>>   qemu_lockcnt_unlock(&ctx

[Qemu-devel] [PATCH v2 20/23] riscv: tcg-target: Add the target init code

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index bc1a2bc4ab..f718542d63 10

[Qemu-devel] [PATCH v2 17/23] riscv: tcg-target: Add direct load and store instructions

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 158 + 1 file changed, 158 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 7216bad086..15431

[Qemu-devel] [PATCH v2 23/23] configure: Add support for building RISC-V host

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 224d3071ac..79375affc1 100755 --- a/configure +++ b/configure @@ -710,6 +710,12

Re: [Qemu-devel] [PATCH v4 5/5] iotests: add iotest 236 for testing bitmap merge

2018-12-19 Thread Eric Blake
On 12/18/18 7:52 PM, John Snow wrote: New interface, new smoke test. --- tests/qemu-iotests/236 | 131 tests/qemu-iotests/236.out | 198 + tests/qemu-iotests/group | 1 + 3 files changed, 330 insertions(+) create mode 100

Re: [Qemu-devel] Booting Raspbian on RPi emulation

2018-12-19 Thread Ben Hekster via Qemu-devel
Checked out tag patchew/20181201123056.432-1-peter.mayd...@linaro.org from https://github.com/patchew-project/qemu and verified the crash no longer occurs. It does indeed appear that the crash previously happened right around the time where I can now see the window being resized. I've attached

[Qemu-devel] [PATCH v2 22/23] dias: Add RISC-V support

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- disas.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/disas.c b/disas.c index f9c517b358..d9aa713a40 100644 --- a/disas.c +++ b/disas.c @@ -522,8 +522,14 @@ void disa

[Qemu-devel] [PATCH v2 14/23] riscv: tcg-target: Add the add2 and sub2 instructions

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 55 ++ 1 file changed, 55 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 65718df7ad..5da850b957 100644 --- a/tcg/riscv/tc

[Qemu-devel] [PATCH v2 18/23] riscv: tcg-target: Add the out op decoder

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 493 + 1 file changed, 493 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-ta

[Qemu-devel] [PATCH v2 11/23] riscv: tcg-target: Add the mov and movi instruction

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 86 ++ 1 file changed, 86 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index a26744052f..01b4

[Qemu-devel] [PATCH v2 21/23] tcg: Add RISC-V cpu signal handler

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark --- accel/tcg/user-exec.c | 75 +++ 1 file changed, 75 insertions(+) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index cd75829cf2..941295ea49 100644 --- a/accel/tcg/user-exec.c ++

[Qemu-devel] [PATCH v2 10/23] riscv: tcg-target: Add the relocation functions

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index d198cfd5f7..a267

[Qemu-devel] [PATCH v2 08/23] riscv: tcg-target: Add the immediate encoders

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-tar

[Qemu-devel] [PATCH v2 16/23] riscv: tcg-target: Add slowpath load and store instructions

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 256 + 1 file changed, 256 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index ecc76c9ef8..721

[Qemu-devel] [PATCH v2 19/23] riscv: tcg-target: Add the prologue generation and register the JIT

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 111 + 1 file changed, 111 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index bab3d1e6d2..bc1a2

[Qemu-devel] [PATCH v2 09/23] riscv: tcg-target: Add the instruction emitters

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 08838027cd..d198cf

Re: [Qemu-devel] [PATCH v4 1/5] iotests: add qmp recursive sorting function

2018-12-19 Thread Eric Blake
On 12/19/18 12:57 PM, John Snow wrote: On 12/19/18 1:52 PM, Eric Blake wrote: On 12/18/18 7:52 PM, John Snow wrote: Python before 3.6 does not sort kwargs by default. If we want to print out pretty-printed QMP objects while preserving the "exec" > "arguments" ordering, we need a custom sort.

[Qemu-devel] [PATCH v2 01/23] elf.h: Add the RISCV ELF magic numbers

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- include/elf.h | 55 +++ 1 file changed, 55 insertions(+) diff --git a/include/elf.h b/include/elf.h index c151164b63..0ac7911b7b 100644 --- a/include/

[Qemu-devel] [PATCH v2 15/23] riscv: tcg-target: Add branch and jump instructions

2018-12-19 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 145 + 1 file changed, 145 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 5da850b957..ecc

  1   2   3   4   >