For some pci device, even its PCI_INTERRUPT_PIN is not 0, it actually
doesn't support INTx mode, so its machine irq read from host sysfs is 0.
In that case, report PCI_INTERRUPT_PIN as 0 to guest and let passthrough
continue.
Cc: Roger Pau Monné
Cc: Jan Beulich
Signed-off-by: Zhao Yan
---
v2:
hi Andrew,
It's a pci device that does not support legacy intx mode, but it accidently
reports PCI_INTERRUPT_PIN as 1, which should be 0 instead.
So, in dom0, the machine irq is 0, which will cause later
xc_physdev_map_pirq() fail and passthrough failure.
Therefore, we treat this case as PCI_INTE
On 12/3/18 10:34 PM, Eric Blake wrote:
On 12/3/18 3:26 AM, Dominik Csapak wrote:
Needed so the patch after next can add ShutdownCause to QMP events
SHUTDOWN and RESET.
Signed-off-by: Dominik Csapak
---
include/sysemu/sysemu.h | 20
qapi/run-state.json | 34 +
On 12/3/18 10:36 PM, Eric Blake wrote:
On 12/3/18 3:26 AM, Dominik Csapak wrote:
This makes it possible to determine what the exact reason was for
a RESET or a SHUTDOWN. A management layer might need the specific reason
of those events to determine which cleanups or other actions it needs
to do
On 2018-11-26 at 03:46:50 -0500, Pankaj Gupta wrote:
>
> >
> > This option controls whether QEMU mmap(2) the memory backend file with
> > MAP_SYNC flag, which can fully guarantee the guest write persistence
>
> Not sure 'persistence' is the right word here. I think it should be
> something like
On 12/3/18 10:38 PM, Eric Blake wrote:
On 12/3/18 3:26 AM, Dominik Csapak wrote:
It is interesting to know whether the shutdown cause was 'quit' or
'reset', especially when using "--no-reboot". In that case, a management
layer can now determine if the guest wanted a reboot or shutdown, and
can a
On 2018-11-29 at 04:11:11 -0500, Pankaj Gupta wrote:
>
> >
> > As more flag parameters besides the existing 'share' are going to be
> > added to qemu_ram_alloc_from_{file,fd}(), let's swith 'share' to a
> > 'flags' parameters in advance, so as to ease the further additions.
> >
> > Signed-off-by
Hi Juan,
Kindly ping again. :)
Have a nice day, thanks
Fei
On 11/12/2018 12:43 PM, Fei Li wrote:
Hi Juan,
Kindly ping, as this multifd migration topic needs your suggestions. :)
Have a nice day, thanks
Fei
On 11/03/2018 12:33 AM, Dr. David Alan Gilbert wrote:
* Peter Xu (pet...@redhat.com)
On Mon, Dec 03, 2018 at 12:20:30PM +0100, Roger Pau Monné wrote:
> Hello,
>
> Thanks for the patch.
>
> The subject should be more descriptive, "Fix a xen passthrough
> failure" is too generic. How about: "allow passthrough of devices with
> bogus interrupt pin" or something similar.
right, thank
On 2018-12-04 04:53, Jason Wang wrote:
> This test tries to build a packet whose size is greater than INT_MAX
> which tries to trigger integer overflow in qemu_net_queue_append_iov()
> which may result OOB.
>
> Signed-off-by: Jason Wang
> ---
> tests/virtio-net-test.c | 46 ++
On 2018-12-04 04:53, Jason Wang wrote:
> If we want to qtest through hub, it would be much more simpler and
> safer to configure the hub without host network. So silent this
> warnings for qtest.
>
> Signed-off-by: Jason Wang
> ---
> net/hub.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deleti
On 2018-12-04 04:53, Jason Wang wrote:
> We try to detect and drop too large packet (>INT_MAX) in 1592a9947036
> ("net: ignore packet size greater than INT_MAX") during packet
> delivering. Unfortunately, this is not sufficient as we may hit
> another integer overflow when trying to queue such larg
Eric Blake writes:
> On 12/3/18 6:26 AM, Markus Armbruster wrote:
>> Dominik Csapak writes:
>>
>>> This makes it possible to determine what the exact reason was for
>>> a RESET or a SHUTDOWN. A management layer might need the specific reason
>>> of those events to determine which cleanups or oth
On Mon, Oct 15, 2018 at 06:43:06AM -0400, Michael S. Tsirkin wrote:
> On Mon, Oct 15, 2018 at 08:54:27AM +0200, David Hildenbrand wrote:
> > On 12/10/2018 20:05, Michael S. Tsirkin wrote:
> > > On Fri, Oct 12, 2018 at 02:24:27PM +1100, David Gibson wrote:
> > >> When the balloon is inflated, we dis
This test tries to build a packet whose size is greater than INT_MAX
which tries to trigger integer overflow in qemu_net_queue_append_iov()
which may result OOB.
Signed-off-by: Jason Wang
---
tests/virtio-net-test.c | 46 +
1 file changed, 46 insertions(+)
Patchew URL: https://patchew.org/QEMU/20181203175211.8230-1-mre...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH for-next 0/6] qemu-img: Add salvaging mode to
convert
Message-id: 20181203175211.8230-1-
This allows flexibility to be reused for all kinds of command line
used by other tests.
Reviewed-by: Eric Blake
Reviewed-by: Thomas Huth
Signed-off-by: Jason Wang
---
tests/virtio-net-test.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/tests/virtio-net
If we want to qtest through hub, it would be much more simpler and
safer to configure the hub without host network. So silent this
warnings for qtest.
Signed-off-by: Jason Wang
---
net/hub.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/hub.c b/net/hub.c
index 78b671e
We try to detect and drop too large packet (>INT_MAX) in 1592a9947036
("net: ignore packet size greater than INT_MAX") during packet
delivering. Unfortunately, this is not sufficient as we may hit
another integer overflow when trying to queue such large packet in
qemu_net_queue_append_iov():
- siz
Reviewed-by: Thomas Huth
Reviewed-by: Eric Blake
Signed-off-by: Jason Wang
---
tests/virtio-net-test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/virtio-net-test.c b/tests/virtio-net-test.c
index 587a043e67..bdd6af 100644
--- a/tests/virtio-net-test.c
+++ b/tests/virtio-net-te
Hi:
This series tries to fix a possible OOB during queueing packets
through qemu_net_queue_append_iov(). This could happen when it tries
to queue a packet whose size is larger than INT_MAX which may lead
integer overflow. We've fixed similar issue in the past during
qemu_net_queue_deliver_iov() by
Patchew URL:
https://patchew.org/QEMU/1543845937-300-1-git-send-email-th...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEG
On 2018/12/4 上午2:13, Thomas Huth wrote:
On 2018-12-03 11:06, Jason Wang wrote:
We try to detect and drop too large packet (>INT_MAX) in 1592a9947036
("net: ignore packet size greater than INT_MAX") during packet
delivering. Unfortunately, this is not sufficient as we may hit
another integer ov
On 2018/12/4 上午12:46, Eric Blake wrote:
On 12/3/18 4:06 AM, Jason Wang wrote:
This test tries to build a packet whose size is greater than INT_MAX
which tries to trigger integer overflow in qemu_net_queue_append_iov()
which may result OOB.
Can you also add a packet just slightly larger than
On 2018/12/4 上午12:18, Eric Blake wrote:
On 12/3/18 4:06 AM, Jason Wang wrote:
We try to detect and drop too large packet (>INT_MAX) in 1592a9947036
("net: ignore packet size greater than INT_MAX") during packet
delivering. Unfortunately, this is not sufficient as we may hit
another integer ove
On 2018/12/4 上午12:18, Peter Maydell wrote:
On Mon, 3 Dec 2018 at 10:06, Jason Wang wrote:
Hi:
This series tries to fix a possible OOB during queueing packets
through qemu_net_queue_append_iov(). This could happen when it tries
to queue a packet whose size is larger than INT_MAX which may lea
On Mon, Dec 03, 2018 at 05:49:37PM +0100, Cédric Le Goater wrote:
> +}
> +
> +switch (qsize) {
> +case 12:
> +case 16:
> +case 21:
> +case 24:
> +end.w3 = ((uint64_t)qpage) & 0x;
> >>
On Mon, Dec 03, 2018 at 06:05:12PM +0100, Cédric Le Goater wrote:
> I forgot to reply to this one.
>
> On 11/29/18 1:47 AM, David Gibson wrote:
> > On Wed, Nov 28, 2018 at 11:59:58AM +0100, Cédric Le Goater wrote:
> >> On 11/28/18 12:49 AM, David Gibson wrote:
> >>> On Fri, Nov 16, 2018 at 11:57:0
On Mon, Dec 03, 2018 at 04:52:46PM +0100, Cédric Le Goater wrote:
> On 11/29/18 5:36 PM, Cédric Le Goater wrote:
> > On 11/29/18 5:09 AM, David Gibson wrote:
> >> On Fri, Nov 16, 2018 at 11:57:20AM +0100, Cédric Le Goater wrote:
> >>> This will be used to remove the MMIO regions of the POWER9 XIVE
Patchew URL:
https://patchew.org/QEMU/20181203170105.2367492-1-stef...@linux.vnet.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2 0/2] Cleanup and locality range check
Message-id: 20181203170105.2367492-
On Mon, Dec 03, 2018 at 10:48:51PM +0800, Li Zhijian wrote:
> It provides setup_data struct and header fields
>
> CC: Michael S. Tsirkin
> Signed-off-by: Li Zhijian
Sorry I was unclear when I said "import it from Linux".
The way to import it is to copy the header
from the linux kernel by addi
>On Mon, 3 Dec 2018 at 11:04, Peng Hao wrote:
>>
>> The first patches are simple cleanups:
>> - patch 1 move the pvpanic device with the 'ocmmon objects' so we
>> compile
>>it once for the x86/arm/aarch64 archs,
>> - patch 2 simply renames ISA fields/definitions to gener
Test 232 creates image files with read-only permission and
expects an error message when trying to access the image
files with read-only and auto-read-only turned off.
Don't run as root user, since root can open files with read/write
access for read-only files.
Signed-off-by: Farhan Ali
Reviewed
On Mon, Dec 03, 2018 at 09:28:36AM -0700, Alex Williamson wrote:
> Including all machine types that might have a pcie-root-port.
>
> Cc: Peter Maydell
> Cc: Michael S. Tsirkin
> Cc: Marcel Apfelbaum
> Cc: Paolo Bonzini
> Cc: Richard Henderson
> Cc: Eduardo Habkost
> Cc: David Gibson
> Signe
I see. That wasn't much of a problem, but thank you for the information.
I'll try to keep it in mind when building QEMU in future.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1806114
Title:
Readi
The memfd_create() compilation failure is a bug in older QEMU versions
that was only revealed by a newer glibc version (ie old QEMU built OK
with older glibc but fails with newer glibc). It's fixed in git in
commit 75e5b70e6b5dcc4f221, so backporting that to the older versions
you're trying to buil
On 12/3/18 4:19 PM, Peter Maydell wrote:
> On Mon, 3 Dec 2018 at 20:45, Aaron Lindsay
> wrote:
>>
>> On Nov 30 16:10, Peter Maydell wrote:
>>> PMCEID2 and PMCEID3 are only defined from ARMv8.1; before that they
>>> are UNDEFINED. So these registers need to be only defined if a
>>> suitable featur
Alright, I managed to compile 2.5.0, 2.5.1 and 2.6.0 by simply making
memfd_create() non-static.
It turns out that 2.6.0 is the first version causing problems. I tested
each of these with the provided SeaBIOS version and with SeaBIOS
rel-1.7.4-0-g96917a8.
--
You received this bug notification be
Patchew URL:
https://patchew.org/QEMU/20181203160840.15115-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH for-4.0 0/5] tcg/i386: Improve guest_base handling
Message-id: 2018120316084
I ran plenty of QEMU/SeaBIOS configurations and these are the results:
Ubuntu 18.04:
OK --> QEMU qemu-2.0.0 + SEABIOS rel-1.7.4-0-g96917a8
OK --> QEMU qemu-2.0.0 + SEABIOS 1.10.2-1ubuntu1 (default)
BAD --> QEMU Debian 1:2.11+dfsg-1ubuntu7.8 (default) + SEABIOS
1.10.2-1ub
On Mon, 3 Dec 2018 at 20:45, Aaron Lindsay wrote:
>
> On Nov 30 16:10, Peter Maydell wrote:
> > PMCEID2 and PMCEID3 are only defined from ARMv8.1; before that they
> > are UNDEFINED. So these registers need to be only defined if a
> > suitable feature bit or ID register field check passes.
>
> It
On 12/3/18 3:26 AM, Dominik Csapak wrote:
It is interesting to know whether the shutdown cause was 'quit' or
'reset', especially when using "--no-reboot". In that case, a management
layer can now determine if the guest wanted a reboot or shutdown, and
can act accordingly.
Changes the ouput of th
On 12/3/18 3:26 AM, Dominik Csapak wrote:
This makes it possible to determine what the exact reason was for
a RESET or a SHUTDOWN. A management layer might need the specific reason
of those events to determine which cleanups or other actions it needs to do.
This patch also fixes the iotests to i
On 12/3/18 3:26 AM, Dominik Csapak wrote:
Needed so the patch after next can add ShutdownCause to QMP events
SHUTDOWN and RESET.
Signed-off-by: Dominik Csapak
---
include/sysemu/sysemu.h | 20
qapi/run-state.json | 34 ++
2 files chan
On 12/3/18 6:26 AM, Markus Armbruster wrote:
Dominik Csapak writes:
This makes it possible to determine what the exact reason was for
a RESET or a SHUTDOWN. A management layer might need the specific reason
of those events to determine which cleanups or other actions it needs to do.
This patc
On 12/1/18 11:43 AM, Philippe Mathieu-Daudé wrote:
On 1/12/18 12:57, Peter Maydell wrote:
On Fri, 30 Nov 2018 at 20:47, Corey Minyard wrote:
On 11/30/18 11:39 AM, Peter Maydell wrote:
On Mon, 26 Nov 2018 at 20:04, wrote:
From: Philippe Mathieu-Daudé
/* XXX: make this persistent */
On 12/3/18 9:32 AM, Paolo Bonzini wrote:
There is no reason for CONFIG_VHOST_NET to be specific to a single target;
it is a host feature that can be add to all targets, as long as they support
s/add/added/
the virtio-net device. Currently CONFIG_VHOST_NET depends on CONFIG_KVM,
but ioeventfd
On 11/26/2018 08:56 PM, Eduardo Habkost wrote:
Remove the "apic initialization failed" prefix (it conveys no
useful information), replace "invalid" with "too large", and add
an error hint with two possible solutions for the problem.
Before:
$ qemu-system-x86_64 -machine q35 -smp 256
qem
Patchew URL:
https://patchew.org/QEMU/1543851204-41186-1-git-send-email-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH for-4.0 00/71] qtest: qgraph driver framework
Message-id: 1543851204-41186
Since arm_hcr_el2_eff includes a check against
arm_is_secure_below_el3, we can often remove a
nearby check against secure state.
In some cases, sort the call to arm_hcr_el2_eff
to the end of a short-circuit logical sequence.
Signed-off-by: Richard Henderson
---
target/arm/helper.c| 22 +
Replace arm_hcr_el2_{fmo,imo,amo} with a more general routine
that also takes SCR_EL3.NS (aka arm_is_secure_below_el3) into
account, as documented for the plethora of bits in HCR_EL2.
Signed-off-by: Richard Henderson
---
target/arm/cpu.h | 67 +--
hw/
On Nov 30 16:10, Peter Maydell wrote:
> On Tue, 20 Nov 2018 at 21:26, Aaron Lindsay
> wrote:
> >
> > Signed-off-by: Aaron Lindsay
> > ---
> > target/arm/cpu.h| 4 ++--
> > target/arm/helper.c | 12 ++--
> > 2 files changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git a/targe
The bulk of the work here, beyond base HPD, is defining the
TTBCR2 register. In addition we must check TTBCR.T2E, which
is not present (RES0) for AArch64.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/cpu.h| 9 +
target/arm/cpu.c| 4
target/a
Post v8.4 bits taken from SysReg_v85_xml-00bet8.
Signed-off-by: Richard Henderson
---
target/arm/cpu.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 79d58978f7..20d97b66de 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -1302,6
Because EL3 has a fixed execution mode, we can properly decide
which of the bits are RES{0,1}.
Signed-off-by: Richard Henderson
---
target/arm/cpu.h| 2 --
target/arm/helper.c | 14 +-
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/target/arm/cpu.h b/target/arm/c
Provide a trivial implementation with zero limited ordering regions,
which causes the LDLAR and STLLR instructions to devolve into the
LDAR and STLR instructions from the base ARMv8.0 instruction set.
Signed-off-by: Richard Henderson
---
v2: Mark LORID_EL1 read-only.
Add TLOR access checks.
At the same time, define the fields for these registers,
and use those defines in arm_pamax().
Signed-off-by: Richard Henderson
v2: Include the v8.5 fields; init the registers for kvm.
Upcase all of the field names.
---
target/arm/cpu.h | 26 --
target/arm
Three relatively simple post-8.0 extensions.
Changes since v1:
* Add TLOR access checks for LOR registers.
* Clean up access to HCR_EL2.
* Clean up setting of SCR_EL3.
* Other changes as noted within each patch.
r~
Richard Henderson (10):
target/arm: Move id_aa64mmfr* to ARMISARegist
Since the TCR_*.HPD bits were RES0 in ARMv8.0, we can simply
interpret the bits as if ARMv8.1-HPD is present without checking.
We will need a slightly different check for hpd for aarch32.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/cpu64.c | 1 +
target/arm/help
The enable for TGE has already occurred within arm_hcr_el2_amo
and friends. Moreover, when E2H is also set, the sense is
supposed to be reversed, which has also already occurred within
the helpers.
Signed-off-by: Richard Henderson
---
target/arm/helper.c | 3 ---
1 file changed, 3 deletions(-)
Post v8.3 bits taken from SysReg_v85_xml-00bet8.
Signed-off-by: Richard Henderson
---
target/arm/cpu.h | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 656a96a8f8..79d58978f7 100644
--- a/target/arm/cpu.h
+++ b/t
On Nov 30 16:14, Peter Maydell wrote:
> On Tue, 20 Nov 2018 at 21:26, Aaron Lindsay
> wrote:
> > diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> > index 50de58e4a2..32c3397948 100644
> > --- a/target/arm/cpu.h
> > +++ b/target/arm/cpu.h
> > @@ -993,6 +993,16 @@ void pmu_op_finish(CPUARMState *e
On 11/12/2018 02:31 PM, Eduardo Habkost wrote:
On Fri, Nov 09, 2018 at 02:58:00PM -0500, Wainer dos Santos Moschetta wrote:
This adds tests for SMP option, by passing -smp with
various combinations of cpus, cores, threads, and sockets
values it checks that invalid topologies are not accepted
a
On 12/3/18 1:50 PM, Gerd Hoffmann wrote:
Make utf16_to_str return an allocated string. Remove the assumtion that
s/assumtion/assumption/ (but probably too late to worry about commit
typos in a pull request :)
the number of string bytes equals the number of utf16 chars (which is
only true f
On 12/3/18 1:48 PM, Markus Armbruster wrote:
Eric Blake writes:
On 12/3/18 10:30 AM, Max Reitz wrote:
Hi,
QMP accepts double keys in dicts without complaining. The value it is
using is apparently the last one specified:
JSON says it is undefined what happens when a client passes double
ke
Slash is unix directory separator, so they are not allowed in filenames.
Note this also stops the classic escape via "../".
Fixes: CVE-2018-16867
Reported-by: Michael Hanselmann
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20181203101045.27976-3-kra...@redhat.com
Make utf16_to_str return an allocated string. Remove the assumtion that
the number of string bytes equals the number of utf16 chars (which is
only true for ascii chars). Instead call wcstombs twice, once to figure
the storage size and once for the actual conversion (as suggested by the
wcstombs m
The following changes since commit 039d4e3df0049bdd8f93a2de735a816483b13954:
scsi: Address spurious clang warning (2018-11-27 23:56:12 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/fixes-31-20181203-pull-request
for you to fetch changes up to
Eric Blake writes:
> On 12/3/18 10:30 AM, Max Reitz wrote:
>> Hi,
>>
>> QMP accepts double keys in dicts without complaining. The value it is
>> using is apparently the last one specified:
>
> JSON says it is undefined what happens when a client passes double
> keys. We are probably best off if
On Mon, 3 Dec 2018 at 16:46, Eric Blake wrote:
>
> The following changes since commit 4750e1a888ac3d320607f33b676f299005be98e6:
>
> Update version for v3.1.0-rc3 release (2018-11-28 17:37:34 +)
>
> are available in the Git repository at:
>
> https://repo.or.cz/qemu/ericb.git tags/pull-nbd-
Hello! Thank you for your kindly and detailed report.
Since this is via the INT 13h mechanism, the problem is likely in
SeaBIOS.
If I'm reading the version strings right, it looks like QEMU 2.0.0 QEMU
1.1.2 appear to be working correctly for you, but do you know what
versions of the SeaBIOS firmw
Eric Blake writes:
> RFC8259 obsoletes RFC7159. Fix a couple of URLs to point to the
> newer version.
>
> Signed-off-by: Eric Blake
Reviewed-by: Markus Armbruster
Hi
On Mon, Dec 3, 2018 at 9:01 PM Stefan Berger wrote:
>
> Make sure that the new locality passed to tpm_tis_prep_abort()
> is valid. This is merely a precaution since none of the current
> callers passes an invalid locality number into this function.
If this should never happen, then let's make
Hi
On Mon, Dec 3, 2018 at 9:23 PM Daniel P. Berrangé wrote:
>
> The files included are taken from formal builds of previous versions
> of QEMU, going back to 2.0.0
>
> - qemu-doc.html
> - qemu-qmp-ref.html
> - qemu-ga-ref.html
>
> To import them all content outside of is stripped and
> rep
On Mon, 3 Dec 2018 at 11:04, Peng Hao wrote:
>
> The first patches are simple cleanups:
> - patch 1 move the pvpanic device with the 'ocmmon objects' so we compile
>it once for the x86/arm/aarch64 archs,
> - patch 2 simply renames ISA fields/definitions to generic ones.
>
On Thu, 29 Nov 2018 at 16:36, Edgar E. Iglesias
wrote:
>
> From: "Edgar E. Iglesias"
>
> The Versal GIC has 192 IRQs not 256 as we previously had setup.
> This series fixes the setup and moves the virtio-mmio nodes
> to use other reserved interrupts.
>
> Since we don't have 32 reserved lines, we
On 12/3/18 11:01 AM, Kamil Rytarowski wrote:
> On 03.12.2018 17:08, Richard Henderson wrote:
>> Signed-off-by: Richard Henderson
>> ---
>> tcg/i386/tcg-target.inc.c | 9 +
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c
>> index
On 2018-12-03 11:06, Jason Wang wrote:
> This allows flexibility to be reused for all kinds of command line
> used by other tests.
>
> Signed-off-by: Jason Wang
> ---
> tests/virtio-net-test.c | 17 +++--
> 1 file changed, 11 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
On 2018-12-03 11:06, Jason Wang wrote:
> We try to detect and drop too large packet (>INT_MAX) in 1592a9947036
> ("net: ignore packet size greater than INT_MAX") during packet
> delivering. Unfortunately, this is not sufficient as we may hit
> another integer overflow when trying to queue such larg
Gerd Hoffmann writes:
> Make utf16_to_str return an allocated string. Remove the assumtion that
> the number of string bytes equals the number of utf16 chars (which is
> only true for ascii chars). Instead call wcstombs twice, once to figure
> the storage size and once for the actual conversion
On Wed, Nov 21, 2018 at 03:12:03PM +, Paul Durrant wrote:
> This patch adds the transformations necessary to get dataplane/xen-qdisk.c
> to build against the new XenBus/XenDevice framework. MAINTAINERS is also
> updated due to the introduction of dataplane/xen-qdisk.h.
>
> NOTE: Existing data
This test converts a simple image to another, but blkdebug injects
block_status and read faults at some offsets. The resulting image
should be the same as the input image, except that sectors that could
not be read have to be 0.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/236 | 164
This adds a salvaging mode (--salvage) to qemu-img convert which ignores
read errors and treats the respective areas as containing only zeroes.
This can be used for instance to at least partially recover the data
from terminally corrupted qcow2 images.
Signed-off-by: Max Reitz
---
qemu-img.c
Together with @iotypes and @sector, this can be used to trap e.g. the
first read or write access to a certain sector without having to know
what happens internally in the block layer, i.e. which "real" events
happen right before such an access.
Signed-off-by: Max Reitz
---
qapi/block-core.json |
RFC8259 obsoletes RFC7159. Fix a couple of URLs to point to the
newer version.
Signed-off-by: Eric Blake
---
docs/devel/qapi-code-gen.txt | 2 +-
docs/interop/qmp-spec.txt| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-cod
On Thu, 29 Nov 2018 at 04:55, David Gibson wrote:
>
> On Fri, Nov 16, 2018 at 11:57:20AM +0100, Cédric Le Goater wrote:
> > This will be used to remove the MMIO regions of the POWER9 XIVE
> > interrupt controller when the sPAPR machine is reseted.
> >
> > Signed-off-by: Cédric Le Goater
>
> Revie
This new error option allows users of blkdebug to inject errors only on
certain kinds of I/O operations. Users usually want to make a very
specific operation fail, not just any; but right now they simply hope
that the event that triggers the error injection is followed up with
that very operation.
Hi,
This series adds a --salvage option to qemu-img convert. With this,
qemu-img will not abort when it encounters an I/O error. Instead, it
tries to narrow it down and will treat the affected sectors as being
completely 0 (and print a warning).
Testing this is not so easy, because while real I
Peter Maydell writes:
> On Fri, 30 Nov 2018 at 07:40, Markus Armbruster wrote:
>> Peter Maydell writes:
>> > Add an assert somewhere and catch it with the usual
>> > "instantiate everything" qtest?
>
>> The troublemaker is (3), where we may end up with an overridden
>> realize-like method and a
Signed-off-by: Max Reitz
---
qapi/block-core.json | 5 -
block/blkdebug.c | 8
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 045206196b..bfe48f71f4 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -
On Mon, 3 Dec 2018 at 16:58, Kevin Wolf wrote:
>
> The following changes since commit 83ea23cd207a03c5736be0231acbf7f8b05dbf52:
>
> i386: hvf: Fix overrun of _decode_tbl1 (2018-12-03 15:09:55 +)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstre
Move img_convert()'s quiet flag into the ImgConvertState so it is
accessible by nested functions. -q dictates that it suppresses anything
but errors, so if those functions want to emit warnings, they need to
query this flag first. (There currently are no such warnings, but there
will be as of the
Make sure that the new locality passed to tpm_tis_prep_abort()
is valid. This is merely a precaution since none of the current
callers passes an invalid locality number into this function.
Add a comment to aborting_locty that it may be any locality, including
TPM_TIS_NO_LOCALITY.
Signed-off-by: S
On 12/3/18 8:26 AM, Max Reitz wrote:
So because apparently there is going to be an rc4 anyway (like basically
always...), I'd really like to bring this fix into it, unless there are
any objections from anyone (though all of you are more than welcome to
explicitly agree, too :-)).
I agree with
I forgot to reply to this one.
On 11/29/18 1:47 AM, David Gibson wrote:
> On Wed, Nov 28, 2018 at 11:59:58AM +0100, Cédric Le Goater wrote:
>> On 11/28/18 12:49 AM, David Gibson wrote:
>>> On Fri, Nov 16, 2018 at 11:57:01AM +0100, Cédric Le Goater wrote:
The last sub-engine of the XIVE archit
Remove the unused locty parameter from tpm_tis_abort() function.
Signed-off-by: Stefan Berger
Reviewed-by: Philippe Mathieu-Daudé
---
hw/tpm/tpm_tis.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index d9322692ee..176d424ed9 10064
It was found that QMP users of QEMU (e.g. libvirt) may need
HV_CPUID_ENLIGHTMENT_INFO.EAX/HV_CPUID_NESTED_FEATURES.EAX information. In
particular, 'hv_tlbflush' and 'hv_evmcs' enlightenments are only exposed in
HV_CPUID_ENLIGHTMENT_INFO.EAX.
HV_CPUID_NESTED_FEATURES.EAX is exposed for two reasons:
The following changes since commit 83ea23cd207a03c5736be0231acbf7f8b05dbf52:
i386: hvf: Fix overrun of _decode_tbl1 (2018-12-03 15:09:55 +)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to db5e8210adbafe9c6383d83643
This series of patches removes an unnecessary parameter from tpm_tis_abort()
and adds a locality range check to tpm_tis_prep_abort().
Stefan
Stefan Berger (2):
tpm: Remove unused locty parameter from tpm_tis_abort()
tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid
hw/
On 12/3/18 8:48 AM, Li Zhijian wrote:
> #include "hw/net/ne2000-isa.h"
> +#include
>
> /* debug PC/ISA interrupts */
> //#define DEBUG_IRQ
> @@ -820,20 +821,6 @@ static long get_file_size(FILE *f)
> return size;
> }
>
> -/* setup_data types */
> -#define SETUP_NONE 0
> -#define SE
1 - 100 of 377 matches
Mail list logo
