Re: [Qemu-devel] vfio failure with intel 760p 128GB nvme

2018-12-01 Thread Dongli Zhang
Hi Alex, On 12/02/2018 03:29 AM, Alex Williamson wrote: > On Sat, 1 Dec 2018 10:52:21 -0800 (PST) > Dongli Zhang wrote: > >> Hi, >> >> I obtained below error when assigning an intel 760p 128GB nvme to guest via >> vfio on my desktop: >> >> qemu-system-x86_64: -device vfio-pci,host=:01:00.0:

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update email address for Fam Zheng

2018-12-01 Thread Philippe Mathieu-Daudé
Cc'ing Trivial@ & Peter. I seems this email is now over, thus it would be nice to have this patch merged in 4.1 early opening. (Does it apply as a fix before the 4.0 release?) On 21/11/18 16:30, Fam Zheng wrote: > Since I am about to change company, update the email address in > MAINTAINERS to my

Re: [Qemu-devel] [PATCH] i2c: Move typedef of bitbang_i2c_interface to i2c.h

2018-12-01 Thread Philippe Mathieu-Daudé
Cc'ing Corey, the new I2C maintainer (since 4.0). On 28/11/18 20:27, BALATON Zoltan wrote: > Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and > bitbang_i2c.h an error even if they are identical. Move it to a common > place to allow building with this clang version. > > Reported-by: Thoma

Re: [Qemu-devel] [PATCH for-3.2 v4 24/28] arm: replace instance_post_init()

2018-12-01 Thread Marc-André Lureau
Hi On Fri, Nov 30, 2018 at 3:48 PM Igor Mammedov wrote: > > On Tue, 27 Nov 2018 13:27:57 +0400 > Marc-André Lureau wrote: > > > Replace arm_cpu_post_init() instance callback by calling it from leaf > > classes, to avoid potential the ordering issue with interfaces > > post-init. > > > > Signed-of

Re: [Qemu-devel] vfio failure with intel 760p 128GB nvme

2018-12-01 Thread Alex Williamson
On Sat, 1 Dec 2018 10:52:21 -0800 (PST) Dongli Zhang wrote: > Hi, > > I obtained below error when assigning an intel 760p 128GB nvme to guest via > vfio on my desktop: > > qemu-system-x86_64: -device vfio-pci,host=:01:00.0: vfio :01:00.0: > failed to add PCI capability 0x11[0x50]@0xb0:

Re: [Qemu-devel] [PATCH for-4.0] usb: move ehci_create_ich9_with_companions to hw/i386

2018-12-01 Thread Philippe Mathieu-Daudé
Hi Paolo, On 30/11/18 22:45, Paolo Bonzini wrote: > This function is only needed when Q35 is in use. Moving it to > the same file that uses it lets you disable the entire USB > subsystem in x86_64-softmmu.mak; of course doing that will > cause -usb to break horribly, but one thing at a time. Mov

[Qemu-devel] vfio failure with intel 760p 128GB nvme

2018-12-01 Thread Dongli Zhang
Hi, I obtained below error when assigning an intel 760p 128GB nvme to guest via vfio on my desktop: qemu-system-x86_64: -device vfio-pci,host=:01:00.0: vfio :01:00.0: failed to add PCI capability 0x11[0x50]@0xb0: table & pba overlap, or they don't fit in BARs, or don't align This is b

Re: [Qemu-devel] [PATCH v3 15/16] hw/i2c/smbus_eeprom: Create at most SMBUS_EEPROM_MAX EEPROMs on a SMBus

2018-12-01 Thread Philippe Mathieu-Daudé
On 1/12/18 12:57, Peter Maydell wrote: > On Fri, 30 Nov 2018 at 20:47, Corey Minyard wrote: >> >> On 11/30/18 11:39 AM, Peter Maydell wrote: >>> On Mon, 26 Nov 2018 at 20:04, wrote: From: Philippe Mathieu-Daudé /* XXX: make this persistent */ -uint8_t *eeprom_buf = g_ma

[Qemu-devel] [Bug 1806196] [NEW] qed leaked clusters

2018-12-01 Thread Коренберг Марк
Public bug reported: There are examples of two QED files which AFAIK does not have any errors both. But `qemu-img check` says that one of them has 1 leaked cluster. I wrote my own tool and it does not find any error. Both files attached, as well as debug output from my program. Both files are ab

Re: [Qemu-devel] [PATCH for-3.1 2/2] usb-mtp: outlaw slashes in filenames

2018-12-01 Thread Michael Hanselmann
On 01.12.18 12:55, Philippe Mathieu-Daudé wrote: > On 30/11/18 20:58, Eric Blake wrote: >> On 11/30/18 1:08 PM, Philippe Mathieu-Daudé wrote: >>> On 30/11/18 12:12, Gerd Hoffmann wrote: Slash is unix directory separator, so they are not allowed in filenames. Note this also stops the class

Re: [Qemu-devel] [PATCH for-4.0 00/14] nbd: add qemu-nbd --list

2018-12-01 Thread Richard W.M. Jones
On Sat, Dec 01, 2018 at 07:57:51AM -0600, Eric Blake wrote: > On 12/1/18 1:42 AM, Richard W.M. Jones wrote: > >On Fri, Nov 30, 2018 at 04:03:29PM -0600, Eric Blake wrote: > >>I note that upstream NBD has 'nbd-client -l $host' for querying > >>just export names (with no quoting, so you have to know

Re: [Qemu-devel] [PATCH v2] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2018-12-01 Thread Nick Hudson
On 30/11/2018 17:18, Peter Maydell wrote: On Thu, 29 Nov 2018 at 20:22, Nick Hudson wrote: noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point. Fake up a hdr so the kernel image is loaded at the right address and the entry po

Re: [Qemu-devel] [PATCH for-4.0 00/14] nbd: add qemu-nbd --list

2018-12-01 Thread Eric Blake
On 12/1/18 1:42 AM, Richard W.M. Jones wrote: On Fri, Nov 30, 2018 at 04:03:29PM -0600, Eric Blake wrote: I note that upstream NBD has 'nbd-client -l $host' for querying just export names (with no quoting, so you have to know that a blank line means the default export), but it wasn't powerful en

[Qemu-devel] [Bug 1805913] Re: readdir() returns NULL (errno=EOVERFLOW) for 32-bit user-static qemu on 64-bit host

2018-12-01 Thread Kan Li
More notes: this bug hits glibc-2.28 and later. It works on glibc-2.27. Therefore to reproduce it it needs ubuntu 18.10 or later. Seems like it works for 18.04. This bug affects all Java programs that (implicitly) uses File.list() or File.listFiles(). Also it makes dash not expanding wildcard /som

Re: [Qemu-devel] [PATCH 00/39] Windbg supporting

2018-12-01 Thread Changbin Du
I applied on top of latest master (tag: v3.1.0-rc3) and encounter below building failure. CONTEXT_CONTROL should be CPU_CONTEXT_CONTROL? $./configure --enable-kvm --enable-vhost-net --enable-libssh2 --target-list=x86_64-softmmu --enable-sdl --enable-curses --enable-vnc --enable-fdt --enable-deb

[Qemu-devel] [RFC 2/5] ui/cocoa: Use the pixman image directly in switchSurface

2018-12-01 Thread Peter Maydell
Currently the switchSurface method takes a DisplaySurface. We want to change our DisplayChangeListener's dpy_gfx_switch callback to do this work asynchronously on a different thread. The caller of the switch callback will free the old DisplaySurface immediately the callback returns, so to ensure th

[Qemu-devel] [RFC 4/5] ui/cocoa: Move console/device menu creation code up in file

2018-12-01 Thread Peter Maydell
Move the console/device menu creation code functions further up in the source file, next to the code which creates the initial menus. We're going to want to change the location we call these functions from in the next patch. This commit is a pure code move with no other changes. Signed-off-by: Pe

[Qemu-devel] [RFC 5/5] ui/cocoa: Perform UI operations only on the main thread

2018-12-01 Thread Peter Maydell
The OSX Mojave release is more picky about enforcing the Cocoa API restriction that only the main thread may perform UI calls. To accommodate this we need to restructure the Cocoa code: * the special OSX main() creates a second thread and uses that to call the vl.c qemu_main(); the original mai

[Qemu-devel] [RFC 1/5] ui/cocoa: Ensure we have the iothread lock when calling into QEMU

2018-12-01 Thread Peter Maydell
The Cocoa UI should run on the main thread; this is enforced in OSX Mojave. In order to be able to run on the main thread, we need to make sure we hold the iothread lock whenever we call into various QEMU UI midlayer functions. Signed-off-by: Peter Maydell --- ui/cocoa.m | 83 +++

[Qemu-devel] [RFC 3/5] ui/cocoa: Factor out initial menu creation

2018-12-01 Thread Peter Maydell
Factor out the long code sequence in main() which creates the initial set of menus. This will make later patches which move initialization code around a bit clearer. Signed-off-by: Peter Maydell --- ui/cocoa.m | 78 -- 1 file changed, 41 insert

[Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop

2018-12-01 Thread Peter Maydell
This set of patches rearranges how we handle events on the OSX Cocoa UI so that we use the main thread to run the OSX event loop, and we don't do a long blocking operation from the applicationDidFinishLaunching callback. Instead we create a second thread which runs qemu_main() and becomes the QEMU

Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing foradding configure interface

2018-12-01 Thread Peter Maydell
On Sat, 1 Dec 2018 at 09:28, wrote: > Peter Maydell wrote: > >This kind of thing is why a PCI device is cleaner -- it just > >works on any machine with a PCI controller, it by default is > >something that the user can provide if they want to and not if > >they don't, and it's not a custom UI that

Re: [Qemu-devel] [PATCH v3 15/16] hw/i2c/smbus_eeprom: Create at most SMBUS_EEPROM_MAX EEPROMs on a SMBus

2018-12-01 Thread Peter Maydell
On Fri, 30 Nov 2018 at 20:47, Corey Minyard wrote: > > On 11/30/18 11:39 AM, Peter Maydell wrote: > > On Mon, 26 Nov 2018 at 20:04, wrote: > >> From: Philippe Mathieu-Daudé > >>/* XXX: make this persistent */ > >> -uint8_t *eeprom_buf = g_malloc0(8 * SMBUS_EEPROM_SIZE); > >> +eep

Re: [Qemu-devel] [PATCH for-3.1 2/2] usb-mtp: outlaw slashes in filenames

2018-12-01 Thread Philippe Mathieu-Daudé
On 30/11/18 20:58, Eric Blake wrote: > On 11/30/18 1:08 PM, Philippe Mathieu-Daudé wrote: >> On 30/11/18 12:12, Gerd Hoffmann wrote: >>> Slash is unix directory separator, so they are not allowed in filenames. >>> Note this also stops the classic escape via "../". >>> >>> Fixes: CVE-2018-16867 >>>

Re: [Qemu-devel] [PATCH 05/10] hw/i386/pc.c: Don't use load_image()

2018-12-01 Thread Peter Maydell
On Fri, 30 Nov 2018 at 15:31, Peter Maydell wrote: > > The load_image() function is deprecated, as it does not let the > caller specify how large the buffer to read the file into is. > Use the glib g_file_get_contents() function instead, which does > the whole "allocate memory for the file and rea

Re: [Qemu-devel] [for-3.2 PATCH 8/9] q35/440fx/arm/spapr: Add QEMU 3.2 machine type

2018-12-01 Thread Peter Maydell
On Sat, 1 Dec 2018 at 00:14, Alex Williamson wrote: > > Including all machine types that might have a pcie-root-port. The next release will be 4.0, not 3.2. Our new version numbering system rolls the major version number for the first release of every calendar year. thanks -- PMM

Re: [Qemu-devel] [for-3.2 PATCH 0/9] pcie: Enhanced link speed and width support

2018-12-01 Thread Daniel P . Berrangé
NB, next QEMU version is 4.0, not 3.2, since we bump for first release of each year as mentioned here https://www.qemu.org/download/ On Fri, Nov 30, 2018 at 05:13:23PM -0700, Alex Williamson wrote: > RFC->v1: > - Add Cc reported by get_maintainer > - Fixup some commit logs (no code changes in pa

Re: [Qemu-devel] [PATCH 14/14] iotests: Enhance 223, 233 to cover 'qemu-nbd --list'

2018-12-01 Thread Richard W.M. Jones
On Fri, Nov 30, 2018 at 04:03:43PM -0600, Eric Blake wrote: > Any good new feature deserves some regression testing :) > Coverage includes: > - 223: what happens when there are 0 or more than 1 export, > proof that we can see multiple contexts including qemu:dirty-bitmap > - 233: proof that we can

Re: [Qemu-devel] [PATCH 13/14] qemu-nbd: Add --list option

2018-12-01 Thread Richard W.M. Jones
On Fri, Nov 30, 2018 at 04:03:42PM -0600, Eric Blake wrote: > We want to be able to detect whether a given qemu NBD server is > exposing the right export(s) and dirty bitmaps, at least for > regression testing. We could use 'nbd-client -l' from the upstream > NBD project to list exports, but it's

Re: [Qemu-devel] [PATCH 11/14] nbd/client: Add nbd_receive_export_list()

2018-12-01 Thread Richard W.M. Jones
On Fri, Nov 30, 2018 at 04:03:40PM -0600, Eric Blake wrote: > We want to be able to detect whether a given qemu NBD server is > exposing the right export(s) and dirty bitmaps, at least for > regression testing. We could use 'nbd-client -l' from the upstream > NBD project to list exports, but it's

Re: [Qemu-devel] [PATCH 10/14] nbd/client: Split handshake into two functions

2018-12-01 Thread Richard W.M. Jones
On Fri, Nov 30, 2018 at 04:03:39PM -0600, Eric Blake wrote: > An upcoming patch will add the ability for qemu-nbd to list > the services provided by an NBD server. Share the common > code of the TLS handshake by splitting the initial exchange > into a separate function, leaving only the export han

Re: [Qemu-devel] [PATCH 08/14] nbd/client: Refactor nbd_receive_list()

2018-12-01 Thread Richard W.M. Jones
On Fri, Nov 30, 2018 at 04:03:37PM -0600, Eric Blake wrote: > Add some parameters to make this function reusable in upcoming > export listing, where we will want to capture the name and > description rather than compare against a user-supplied name. > No change in semantics to the existing caller.

Re: [Qemu-devel] [PATCH 07/14] nbd/client: Refactor nbd_negotiate_simple_meta_context()

2018-12-01 Thread Richard W.M. Jones
On Fri, Nov 30, 2018 at 04:03:36PM -0600, Eric Blake wrote: > Change the signature to make it easier for a future patch to > reuse this function for calling NBD_OPT_LIST_META_CONTEXT with > 0 or 1 queries. Also, always allocate space for the received > name, even if it doesn't match expected lengt

Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing foradding configure interface

2018-12-01 Thread peng.hao2
>On Fri, 30 Nov 2018 at 16:14, Andrew Jones wrote: >> >> On Fri, Nov 30, 2018 at 03:57:13PM +, Peter Maydell wrote: >> > On Fri, 30 Nov 2018 at 15:56, Peter Maydell >> > wrote: >> > > I suspect the reason you've done this is that you're >> > > trying to get "-device pvpanic" to work on the c

[Qemu-devel] [Bug 1805697] Re: egl-headless crashes

2018-12-01 Thread Anton Sharpaev
I mean this works: -device virtio-vga,xres=1920,yres=1080 Not the patch. I try to patch 3.0 version. No result -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805697 Title: egl-headless crashes St

Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface

2018-12-01 Thread peng.hao2
>On Wed, 28 Nov 2018 at 03:50, Peng Hao wrote: >> >> Prepare for pvpanic-mmio configure interface. >> >> Signed-off-by: Peng Hao >> --- >> hw/arm/sysbus-fdt.c | 2 ++ >> hw/arm/virt.c | 2 ++ >> hw/misc/pvpanic.c | 11 +-- >> 3 files changed, 13 insertions(+), 2 deletions(-) >