Re: [Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype

2018-08-28 Thread Pavel Dovgalyuk
Ping? Pavel Dovgalyuk > -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Tuesday, July 10, 2018 4:07 PM > To: Pavel Dovgalyuk > Cc: 'Peter Maydell'; 'Pavel Dovgalyuk'; 'Paolo Bonzini'; > maria.klimushenk...@ispras.ru; 'QEMU > Developers'; 'Lluís Vilanova'

[Qemu-devel] [PATCH v2 1/2] target/xtensa: convert to do_transaction_failed

2018-08-28 Thread Max Filippov
Signed-off-by: Max Filippov --- Changes v1->v2: - change ldl_phys to address_space_ldl in get_pte and check transaction for success; target/xtensa/cpu.c | 2 +- target/xtensa/cpu.h | 7 --- target/xtensa/helper.c| 22 +++--- target/xtensa/op_helper.c | 12

[Qemu-devel] [PATCH v2 0/2] target/xtensa: convert to do_transaction_failed

2018-08-28 Thread Max Filippov
Hello, this series converts target/xtensa to use do_transaction_failed callback and adds a test that checks various types of access to the physically unmapped addresses. Changes v1->v2: - change ldl_phys to address_space_ldl in get_pte and check transaction for success; - add tests that attempt

[Qemu-devel] [PATCH v2 2/2] tests/tcg/xtensa: add test for failed memory transactions

2018-08-28 Thread Max Filippov
Failed memory transactions should raise exceptions 14 (for fetch) or 15 (for load/store) with XEA2. Memory accesses that result in TLB miss followed by an attempt to load PTE from physical memory which fails should raise InstTLBMiss or LoadStoreTLBMiss with XEA2. Signed-off-by: Max Filippov ---

Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume

2018-08-28 Thread Peter Xu
On Tue, Aug 28, 2018 at 05:46:29PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Sat, Aug 25, 2018 at 03:57:19PM +0200, Marc-André Lureau wrote: > >> There is no need for per-command need_resume granularity, it should > >> resume after running an non-oob command on oob-disabled moni

Re: [Qemu-devel] [PATCH v3 9/9] qmp: common 'id' handling & make QGA conform to QMP spec

2018-08-28 Thread Michael Roth
Quoting Marc-André Lureau (2018-08-25 08:57:24) > Let qmp_dispatch() copy the 'id' field. That way any qmp client will > conform to the specification, including QGA. Furthermore, it > simplifies the work for qemu monitor. > > CC: Michael Roth > Signed-off-by: Marc-André Lureau > Reviewed-by: Mar

Re: [Qemu-devel] [PATCH v3 8/9] qga: process_event() simplification

2018-08-28 Thread Michael Roth
Quoting Marc-André Lureau (2018-08-28 06:56:51) > Hi > On Tue, Aug 28, 2018 at 2:05 AM Michael Roth > wrote: > > > > Quoting Marc-André Lureau (2018-08-25 08:57:23) > > > Simplify the code around qmp_dispatch(): > > > - rely on qmp_dispatch/check_obj() for message checking > > > - have a single s

Re: [Qemu-devel] [PATCH v4 21/29] util: use fcntl() for qemu_write_pidfile() locking

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 6:01 PM Daniel P. Berrangé wrote: > > On Fri, Jul 13, 2018 at 03:09:08PM +0200, Marc-André Lureau wrote: > > According to Daniel Berrange, fcntl() locks have better portable > > semantics than lockf(). > > Specifically I was referring to this from 'man lockf': > >On

[Qemu-devel] blkdebug get_status bug [was: [Qemu-block] NBD structured reads vs. block size]

2018-08-28 Thread Eric Blake
[following up to a different set of emails] On 08/28/2018 03:41 PM, Eric Blake wrote: Revisiting this: On 08/01/2018 09:41 AM, Eric Blake wrote: Rich Jones pointed me to questionable behavior in qemu's NBD server implementation today: qemu advertises a minimum block size of 512 to any client

Re: [Qemu-devel] [PATCH 5/7] block/mirror: utilize job_exit shim

2018-08-28 Thread John Snow
On 08/25/2018 11:02 AM, Max Reitz wrote: > On 2018-08-23 00:05, John Snow wrote: >> >> >> On 08/22/2018 08:15 AM, Max Reitz wrote: >>> On 2018-08-17 21:04, John Snow wrote: Change the manual deferment to mirror_exit into the implicit callback to job_exit and the mirror_exit callback. >

Re: [Qemu-devel] [PATCH v2] linux-user: elf: mmap all the target-pages of hostpage for data segment

2018-08-28 Thread Laurent Vivier
Le 28/08/2018 à 17:22, Shivaprasad G Bhat a écrit : > If the hostpage size is greater than the TARGET_PAGESIZE, the > target-pages of size TARGET_PAGESIZE are marked valid only till the > length requested during the elfload. The glibc attempts to consume unused > space in the last page of data segm

Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Janeczek, Craig via Qemu-devel
To clarify, if MXU is present (a cpu defined to have MXU instructions is selected) we will never run any of the other special2 commands? That would actually simplify the implementation. Also I understand the want for clean code, I appreciate the comments. -Original Message- From: Aleksa

Re: [Qemu-devel] [PATCH v5 06/13] target/arm: Implement PMOVSSET

2018-08-28 Thread Aaron Lindsay
On Jun 28 17:23, Peter Maydell wrote: > On 22 June 2018 at 21:32, Aaron Lindsay wrote: > > Add an array for PMOVSSET so we only define it for v7ve+ platforms > > > > Signed-off-by: Aaron Lindsay > > --- > > target/arm/helper.c | 28 > > 1 file changed, 28 insertions(

Re: [Qemu-devel] nbd oldstyle negotiation

2018-08-28 Thread Richard W.M. Jones
Just following up on this old thread for documentation purposes: Was it finally decided to drop oldstyle from qemu client in 3.1? Was anything posted to make that happen? I don't see any patches on the list. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjone

Re: [Qemu-devel] [PATCH 5/7] block/mirror: utilize job_exit shim

2018-08-28 Thread John Snow
On 08/25/2018 11:02 AM, Max Reitz wrote: > If you say so... I have to admit I don't really understand. The > comment doesn't explain why it's so important to keep src around until > job_completed(), so I don't know. I thought AioContexts are recursive > so it doesn't matter whether you take t

Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Aleksandar Markovic
> To clarify, if MXU is present (a cpu defined to have MXU instructions is > selected) we will never run any of the other special2 commands? That would > actually simplify the implementation. If presence of "special2_legacy" instructions and presence of MXU instructions are mutually exclusive (

Re: [Qemu-devel] [PATCH v8 0/3] wakeup-from-suspend and system_wakeup changes

2018-08-28 Thread Daniel Henrique Barboza
Ping On 07/05/2018 05:08 PM, Daniel Henrique Barboza wrote: changes in v8: - created 'query-current-machine' API to hold the wakeup-suspend-support flag - wake-up flag now considers the --no-acpi config option for PC archs - fixes in patch 3 proposed by Markus. Previous series link: https://l

Re: [Qemu-devel] [PATCH v5 01/13] target/arm: Reorganize PMCCNTR accesses

2018-08-28 Thread Aaron Lindsay
On Jun 28 17:40, Peter Maydell wrote: > On 22 June 2018 at 21:32, Aaron Lindsay wrote: > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > > index 8488273..ba2c876 100644 > > --- a/target/arm/cpu.h > > +++ b/target/arm/cpu.h > > @@ -467,10 +467,20 @@ typedef struct CPUARMState { > > ui

Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Aleksandar Markovic
> From: Janeczek, Craig > Sent: Tuesday, August 28, 2018 8:54 PM > > Subject: RE: [PATCH v3 2/8] target/mips: Add all MXU opcodes > > I will re-work each of the mxu_gen_ functions to check for MXUEN and > jump over the implementation of the instruction if not enabled. > > I would like to clarify

Re: [Qemu-devel] [PATCH v6 00/13] monitor: enable OOB by default

2018-08-28 Thread Markus Armbruster
Peter Xu writes: > Hi, Markus, Marc-Andre, > > I didn't follow up the latest discussions on the response queue or > monitor changes. For now this series still makes sense to me, so I'm > just rebasing the series to master and repost (with some additional > changes/patches to address Markus's con

Re: [Qemu-devel] [PATCH 0/2] qapi: A whitespace touch-up, and a doc update

2018-08-28 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster (2): > qapi: Emit a blank line before dummy declaration > qapi: Update docs for generator changes since commit 9ee86b85267 > > docs/devel/qapi-code-gen.txt | 131 ++- > scripts/qapi/common.py | 1 + > 2 fil

Re: [Qemu-devel] [PATCH v2 0/2] qapi: easier debugging of introspection file

2018-08-28 Thread Markus Armbruster
Eric Blake writes: > When inspecting the generated qapi-introspect.c (for debugging, > or to see what QAPI changes are user visible vs. internal only), > the fact that we've intentionally masked names from the QMP client > makes it harder to tie back generated code back to the original > QAPI .js

Re: [Qemu-devel] [PATCH v3 0/9] monitor: various code simplification and fixes

2018-08-28 Thread Markus Armbruster
Marc-André Lureau writes: > Hi, > > This series is a rebased subset of "[PATCH v3 00/38] RFC: monitor: add > asynchronous command type". PATCH 1-2 queued. Thanks!

[Qemu-devel] [PULL 3/6] qapi: Emit a blank line before dummy declaration

2018-08-28 Thread Markus Armbruster
We emit a dummy variable in each .c file "to shut up OSX toolchain warnings about empty .o files" (commit 252dc3105fc). Separate it from the code preceding it (if any) with a blank line. Signed-off-by: Markus Armbruster Message-Id: <20180828120736.32323-2-arm...@redhat.com> Reviewed-by: Eric Bla

[Qemu-devel] [PULL 0/6] QAPI patches for 2018-08-28

2018-08-28 Thread Markus Armbruster
The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2018-08-2

[Qemu-devel] [PULL 4/6] qapi: Update docs for generator changes since commit 9ee86b85267

2018-08-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20180828120736.32323-3-arm...@redhat.com> Reviewed-by: Eric Blake --- docs/devel/qapi-code-gen.txt | 131 ++- 1 file changed, 100 insertions(+), 31 deletions(-) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/q

[Qemu-devel] [PULL 1/6] qapi: Fix build_params() for empty parameter list

2018-08-28 Thread Markus Armbruster
build_params() returns '' instead of 'void' when there are no parameters. Can't happen now, but the next commit will change that. Signed-off-by: Markus Armbruster [peterx: compose the patch from email replies] Signed-off-by: Peter Xu Message-Id: <20180815133747.25032-3-pet...@redhat.com> --- s

[Qemu-devel] [PULL 5/6] qapi: Minor introspect.py cleanups

2018-08-28 Thread Markus Armbruster
From: Eric Blake Commit 7d0f982b changed generated introspection output to no longer produce long lines in the generated .c file, but failed to adjust comments to match. Add some clarity that the shorter length that matters most is the overall QMP response on the wire. Commit 25b1ef31 triggers

[Qemu-devel] [PULL 2/6] qapi: Drop qapi_event_send_FOO()'s Error ** argument

2018-08-28 Thread Markus Armbruster
From: Peter Xu The generated qapi_event_send_FOO() take an Error ** argument. They can't actually fail, because all they do with the argument is passing it to functions that can't fail: the QObject output visitor, and the @qmp_emit callback, which is either monitor_qapi_event_queue() or event_te

[Qemu-devel] [PULL 6/6] qapi: Add comments to aid debugging generated introspection

2018-08-28 Thread Markus Armbruster
From: Eric Blake We consciously chose in commit 1a9a507b to hide QAPI type names from the introspection output on the wire, but added a command line option -u to unmask the type name when doing a debug build. The unmask option still remains useful to some other forms of automated analysis, so it

Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Janeczek, Craig via Qemu-devel
I will re-work each of the mxu_gen_ functions to check for MXUEN and jump over the implementation of the instruction if not enabled. I would like to clarify the structure of the switch statement before implementing it. I was originally planning on checking if there was a MXU hit and MXUEN was s

Re: [Qemu-devel] [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-28 Thread Aleksandar Markovic
> The only commands that have the 5th bit required to address XR16 are > S32M2I/S32I2M. > > I can split it out into a separate utility function and put a conditional > into the S32M2I/S32I2M functions if you are more comfortable with that. It is not a bad idea. (preventing all instructions othe

Re: [Qemu-devel] [SeaBIOS] [RFC v2 0/3] Support multiple pci domains in pci_device

2018-08-28 Thread Kevin O'Connor
On Tue, Aug 28, 2018 at 08:17:19PM +0300, Marcel Apfelbaum wrote: > On 08/28/2018 08:02 PM, Kevin O'Connor wrote: > > On Tue, Aug 28, 2018 at 12:14:58PM +0200, Gerd Hoffmann wrote: > > > > > Where is the pxb-pcie device? :$somewhere? Or $domain:00:00.0? > > > > :$somewhere (On PCI domai

Re: [Qemu-devel] [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-28 Thread Janeczek, Craig via Qemu-devel
The only commands that have the 5th bit required to address XR16 are S32M2I/S32I2M. I can split it out into a separate utility function and put a conditional into the S32M2I/S32I2M functions if you are more comfortable with that. -Original Message- From: Aleksandar Markovic Sent: Tues

Re: [Qemu-devel] [Query] Live Migration between machines with different processor ids

2018-08-28 Thread Dr. David Alan Gilbert
(Cc'ing in Eric, Drew, and Peter for ARM stuff) * Jaggi, Manish (manish.ja...@cavium.com) wrote: > > > > On 23-Aug-2018, at 7:59 PM, Juan Quintela wrote: > > > > External Email > > > > "Jaggi, Manish" wrote: > >> Hi, > > > > Hi > > > > [Note that I was confused about what do you mean with

[Qemu-devel] [Bug 1788665] Re: Low 2D graphics performance with Windows 10 (1803) VGA passthrough VM using "Spectre" protection

2018-08-28 Thread Heiko Sieger
Thanks, I will do that tomorrow and report back. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1788665 Title: Low 2D graphics performance with Windows 10 (1803) VGA passthrough VM using "Spectre"

Re: [Qemu-devel] [SeaBIOS] [RFC v2 0/3] Support multiple pci domains in pci_device

2018-08-28 Thread Marcel Apfelbaum
Hi Kevin, On 08/28/2018 08:02 PM, Kevin O'Connor wrote: On Tue, Aug 28, 2018 at 12:14:58PM +0200, Gerd Hoffmann wrote: Hi, Where is the pxb-pcie device? :$somewhere? Or $domain:00:00.0? :$somewhere (On PCI domain 0) Cool, so we don't have an chicken-and-egg issue. If we can

Re: [Qemu-devel] [SeaBIOS] [RFC v2 0/3] Support multiple pci domains in pci_device

2018-08-28 Thread Kevin O'Connor
On Tue, Aug 28, 2018 at 12:14:58PM +0200, Gerd Hoffmann wrote: > Hi, > > > > Where is the pxb-pcie device? :$somewhere? Or $domain:00:00.0? > > > > :$somewhere (On PCI domain 0) > > Cool, so we don't have an chicken-and-egg issue. > > > > If we can access pxb-pcie registers before

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-28 Thread Marc-André Lureau
On Tue, Aug 28, 2018 at 6:54 PM Marc-André Lureau wrote: > > Hi > > On Tue, Aug 28, 2018 at 6:49 PM Igor Mammedov wrote: > > > > On Tue, 28 Aug 2018 17:38:40 +0200 > > Marc-André Lureau wrote: > > > > > The share=on/off property is used to modified mmap() MAP_SHARED > > > setting. Make it on by

Re: [Qemu-devel] [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-28 Thread Aleksandar Markovic
> > This does not handle the case xra == XR16. > I do not see where the case is un-handled. XR16 maps to index 15 in the > mxu_gpr array. But, XR16 has its own rules for read/write, and you are treating it just as a regular register.

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 6:49 PM Igor Mammedov wrote: > > On Tue, 28 Aug 2018 17:38:40 +0200 > Marc-André Lureau wrote: > > > The share=on/off property is used to modified mmap() MAP_SHARED > > setting. Make it on by default for convenience and compatibility > > reasons. > it would be nice to

Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Aleksandar Markovic
> I see that I can check the loongson instructions by checking for > INSN_LOONGSON2F. Using MXU if that is not set One more thing to check is MXUEN bit of MXU control register. This should be done before handling any MXU instructions, except S32M2I/S32I2M. > What should I check for the mult or

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-28 Thread Igor Mammedov
On Tue, 28 Aug 2018 17:38:40 +0200 Marc-André Lureau wrote: > The share=on/off property is used to modified mmap() MAP_SHARED > setting. Make it on by default for convenience and compatibility > reasons. it would be nice to state reasons here. also flipping default to on is behavioral change whe

[Qemu-devel] [Bug 1788665] Re: Low 2D graphics performance with Windows 10 (1803) VGA passthrough VM using "Spectre" protection

2018-08-28 Thread Daniel Berrange
I'm not convinced we can trust the output from cygwin wrt CPU flags. A better test would be to install a modern Linux guest which has the mitigations, and see if that reports the flags. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v4 20/29] util: add qemu_write_pidfile()

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 5:53 PM Daniel P. Berrangé wrote: > > On Fri, Jul 13, 2018 at 03:09:07PM +0200, Marc-André Lureau wrote: > > There are variants of qemu_create_pidfile() in qemu-pr-helper and > > qemu-ga. Let's have a common implementation in libqemuutil. > > > > The code is based from p

Re: [Qemu-devel] [PATCH v4 21/29] util: use fcntl() for qemu_write_pidfile() locking

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 6:01 PM Daniel P. Berrangé wrote: > > On Fri, Jul 13, 2018 at 03:09:08PM +0200, Marc-André Lureau wrote: > > According to Daniel Berrange, fcntl() locks have better portable > > semantics than lockf(). > > Specifically I was referring to this from 'man lockf': > >On

[Qemu-devel] ANNOUNCE: nbdkit 1.6 - an NBD server toolkit with stable plugin API and permissive license

2018-08-28 Thread Richard W.M. Jones
NBD — Network Block Device — is a protocol for accessing Block Devices (hard disks and disk-like things) over a Network. nbdkit is a toolkit for creating NBD servers. The key features are: * Multithreaded NBD server written in C with good performance. * Minimal dependencies for the basic serve

Re: [Qemu-devel] [PATCH v4 21/29] util: use fcntl() for qemu_write_pidfile() locking

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:09:08PM +0200, Marc-André Lureau wrote: > According to Daniel Berrange, fcntl() locks have better portable > semantics than lockf(). Specifically I was referring to this from 'man lockf': On Linux, lockf() is just an interface on top of fcntl(2) locking. Many

Re: [Qemu-devel] [PATCH v4 20/29] util: add qemu_write_pidfile()

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:09:07PM +0200, Marc-André Lureau wrote: > There are variants of qemu_create_pidfile() in qemu-pr-helper and > qemu-ga. Let's have a common implementation in libqemuutil. > > The code is based from pr-helper write_pidfile(), but allows the > caller to deal with error repo

Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume

2018-08-28 Thread Markus Armbruster
Peter Xu writes: > On Sat, Aug 25, 2018 at 03:57:19PM +0200, Marc-André Lureau wrote: >> There is no need for per-command need_resume granularity, it should >> resume after running an non-oob command on oob-disabled monitor. >> >> Signed-off-by: Marc-André Lureau >> Reviewed-by: Markus Armbrust

[Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-28 Thread Marc-André Lureau
The share=on/off property is used to modified mmap() MAP_SHARED setting. Make it on by default for convenience and compatibility reasons. Signed-off-by: Marc-André Lureau --- backends/hostmem-memfd.c | 4 +++- qemu-options.hx | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) d

Re: [Qemu-devel] [PATCH v4 11/29] vhost-user: split vhost_user_read()

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:58PM +0200, Marc-André Lureau wrote: > Split vhost_user_read(), so only header can be read with > vhost_user_read_header(). > > Signed-off-by: Marc-André Lureau > --- > hw/virtio/vhost-user.c | 27 +++ > 1 file changed, 19 insertions(+), 8 de

Re: [Qemu-devel] [PATCH v4 10/29] HACK: vhost-user-backend: allow to specify binary to execute

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:57PM +0200, Marc-André Lureau wrote: > An executable with its arguments may be given as 'cmd' property, ex: > -object vhost-user-backend,id=vui,cmd="./vhost-user-input > /dev/input..". The executable is then spawn and, by convention, the > vhost-user socket is passed a

Re: [Qemu-devel] [RFC V1] hw/pci/pci_example.c : Added a new pci device

2018-08-28 Thread Yoni Bettan
On 8/28/18 10:24 AM, Yoni Bettan wrote: - this is a simple example of how to write a pci device that supports portio, mmio, irq and dma As the commit message miss a little bit of information I will add it here and update the commit message in the next Version. The main goal is

[Qemu-devel] [PATCH v2] linux-user: elf: mmap all the target-pages of hostpage for data segment

2018-08-28 Thread Shivaprasad G Bhat
If the hostpage size is greater than the TARGET_PAGESIZE, the target-pages of size TARGET_PAGESIZE are marked valid only till the length requested during the elfload. The glibc attempts to consume unused space in the last page of data segment(__libc_memalign() in elf/dl-minimal.c). If PT_LOAD p_ali

Re: [Qemu-devel] [PATCH] linux-user: elf: mmap all the target-pages of hostpage for data segment

2018-08-28 Thread Shivaprasad G Bhat
On 08/27/2018 06:55 PM, Laurent Vivier wrote: Le 27/08/2018 à 14:37, Shivaprasad G Bhat a écrit : If the hostpage size is greater than the TARGET_PAGESIZE, the target-pages of size TARGET_PAGESIZE are marked valid only till the length requested during the elfload. The glibc attempts to consum

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Add comments to aid debugging generated introspection

2018-08-28 Thread Eric Blake
On 08/28/2018 07:27 AM, Markus Armbruster wrote: --- v2: rebase on conditional code additions, drop patch to remove -u, update documentation to match My update wasn't very accurate, as you discovered :) Let's rebase onto my "[PATCH 0/2] qapi: A whitespace touch-up, and a doc update". The a

Re: [Qemu-devel] [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-28 Thread Janeczek, Craig via Qemu-devel
What happens if reg > 16? Also, the argument reg should be unsigned. If rev > 16 the instruction is invalid. What type of error can/should I throw here. This does not handle the case xra == XR16. From the doc: I do not see where the case is un-handled. XR16 maps to index 15 in the mxu_gpr array.

Re: [Qemu-devel] [PATCH 0/2] qapi: A whitespace touch-up, and a doc update

2018-08-28 Thread Eric Blake
On 08/28/2018 07:07 AM, Markus Armbruster wrote: Markus Armbruster (2): qapi: Emit a blank line before dummy declaration qapi: Update docs for generator changes since commit 9ee86b85267 Reviewed-by: Eric Blake (Nothing like my patch to the same file to make it obvious that we're not al

Re: [Qemu-devel] [PATCH 5/6] json: Eliminate lexer state IN_ERROR

2018-08-28 Thread Eric Blake
On 08/27/2018 11:40 PM, Markus Armbruster wrote: typedef enum json_token_type { -JSON_MIN = 100, -JSON_LCURLY = JSON_MIN, +JSON_ERROR = 0, /* must be zero, see json_lexer[] */ +/* Gap for lexer states */ +JSON_LCURLY = 100, +JSON_MIN = JSON_LCURLY, In an

Re: [Qemu-devel] [PATCH v4 09/29] qio: add qio_channel_command_new_spawn_with_pre_exec()

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:56PM +0200, Marc-André Lureau wrote: > Add a new function to let caller do some tuning thanks to a callback > before exec(). > > Signed-off-by: Marc-André Lureau > --- > include/io/channel-command.h | 18 ++ > io/channel-command.c | 33 ++

Re: [Qemu-devel] [PATCH v4 02/29] chardev: remove qemu_chr_fe_read_all() counter

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:49PM +0200, Marc-André Lureau wrote: > There is no obvious reason to have a loop counter. This limits from > reading several megabytes large buffers in one go, since socket > read/write usually have a limit. The counter was there since this method's introduction in 7b

Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Janeczek, Craig via Qemu-devel
I see that I can check the loongson instructions by checking for INSN_LOONGSON2F. Using MXU if that is not set What should I check for the mult or misc instructions that were there first? -Original Message- From: Aleksandar Markovic Sent: Tuesday, August 28, 2018 11:07 AM To: Janeczek,

Re: [Qemu-devel] [PATCH v3 1/8] target/mips: Introduce MXU registers

2018-08-28 Thread Janeczek, Craig via Qemu-devel
Where is the definition of MXU control register (MXU_CR)? MXU_CR is the last element in this array. Before sending patches, it is obligatory to run scripts/checkpatch.pl - this (missing braces) will be reported by this script. I did run checkpath before sending a patch. This was not reported.

Re: [Qemu-devel] [PATCH v4 03/29] chardev: unref if underlying chardev has no parent

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:50PM +0200, Marc-André Lureau wrote: > It's possible to write code creating a chardev backend that is not > registered. When it is not user-created, it makes sense to keep it > hidden. Let the associated frontend destroy it also in this case. > > Signed-off-by: Marc-A

Re: [Qemu-devel] [PATCH 5/6] json: Eliminate lexer state IN_ERROR

2018-08-28 Thread Eric Blake
On 08/28/2018 10:01 AM, Eric Blake wrote: The question remains, then, if a fixed-size gap (by making JSON_MIN be exactly 100) is any smarter than a contiguous layout (by making JSON_MIN be IN_START_INTERP + 1).  I can't see any strong reason for preferring one form over the other, so keeping th

Re: [Qemu-devel] [PATCH V4 1/4] target-i386: introduce coalesced_pio kvm header update

2018-08-28 Thread Eduardo Habkost
On Sat, Aug 25, 2018 at 08:19:47PM +0800, Peng Hao wrote: > add coalesced_pio's struct and KVM_CAP_COALESCED_PIO header. > > Signed-off-by: Peng Hao What's the status of the corresponding KVM header patch? > --- > accel/kvm/kvm-all.c | 4 ++-- > linux-headers/linux/kvm.h | 5 +++-- > 2

Re: [Qemu-devel] [PATCH V4 0/4] introduce coalesced pio support

2018-08-28 Thread Eduardo Habkost
On Sat, Aug 25, 2018 at 08:19:46PM +0800, Peng Hao wrote: [...] > Peng Hao (4): > target-i386: introduce coalesced_pio kvm header update > target-i386:add coalesced_pio API > target-i386: add rtc 0x70 port as coalesced_pio > target-i386: add i440fx 0xcf8 port as coalesced_pio Do you have a

Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 2/8] target/mips: Add all MXU opcodes > > Adds all MXU opcodes to the opcode enum. The MXU opcodes overlap with > existi

[Qemu-devel] [PATCH] Add support for TCP path/QMP_PATH in scripts/qmp/qmp

2018-08-28 Thread Chen Zhang via Qemu-devel
From a1f93198020b8c043edab5292db39b52ac77f78b Mon Sep 17 00:00:00 2001 Signed-off-by: Zhang Chen --- scripts/qmp/qmp | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/scripts/qmp/qmp b/scripts/qmp/qmp index 6cb46fd..0e8ed19 100755 --- a/scripts/qmp/qmp +++ b/scr

Re: [Qemu-devel] [PATCH v3 1/8] target/mips: Introduce MXU registers

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 1/8] target/mips: Introduce MXU registers > > Define and initialize the 16 MXU registers. > > Signed-off-by: Craig Ja

Re: [Qemu-devel] [PATCH for-3.1 v10 30/31] block: BDS options may lack the "driver" option

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:27 PM CEST, Max Reitz wrote: > When BDSs are created by qemu itself (e.g. as filters in block jobs), > they may not have a "driver" option in their options QDict. When > generating a json:{} filename, however, it must always be present. > > Signed-off-by: Max Reitz Revie

Re: [Qemu-devel] [PATCH for-3.1 v10 21/31] block: Add strong_runtime_opts to BlockDriver

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:18 PM CEST, Max Reitz wrote: > This new field can be set by block drivers to list the runtime options > they accept that may influence the contents of the respective BDS. As of > a follow-up patch, this list will be used by the common > bdrv_refresh_filename() implementatio

Re: [Qemu-devel] [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 3/8] target/mips: Add MXU instructions S32I2M and S32M2I > > This commit makes the MXU registers and the utility functio

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-28 Thread Peter Krempa
On Fri, Aug 10, 2018 at 18:26:57 +0200, Kevin Wolf wrote: > The block-commit QMP command required specifying the top and base nodes > of the commit jobs using the file name of that node. While this works > in simple cases (local files with absolute paths), the file names > generated for more compli

Re: [Qemu-devel] [PATCH v3 4/8] target/mips: Add MXU instruction S8LDD

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 4/8] target/mips: Add MXU instruction S8LDD > > Adds support for emulating the S8LDD MXU instruction. > > Signed-off-by

Re: [Qemu-devel] [PATCH v4] vl.c deprecate incorrect CPUs topology

2018-08-28 Thread Andrew Jones
On Tue, Aug 28, 2018 at 03:48:13PM +0200, Igor Mammedov wrote: > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > so that total number of logical CPUs [sockets * cores * threads] > would be equal to [maxcpus], however historically we didn't have > such check in QEMU and it is

Re: [Qemu-devel] [PATCH v3 6/8] target/mips: Add MXU instruction D16MAC

2018-08-28 Thread Aleksandar Markovic
> From: Craig Janeczek > Sent: Tuesday, August 28, 2018 3:00 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; aurel...@aurel32.net; Craig Janeczek > Subject: [PATCH v3 6/8] target/mips: Add MXU instruction D16MAC > > Adds support for emulating the D16MAC instruction. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v9 1/6] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-08-28 Thread Marc-André Lureau
ping On Fri, Aug 10, 2018 at 5:34 PM Marc-André Lureau wrote: > > The following patch is going to add compatiblity parameters. > > Signed-off-by: Marc-André Lureau > --- > include/hw/compat.h | 4 +++- > include/hw/i386/pc.h | 5 - > hw/i386/pc_piix.c| 13 - > hw/i386/pc_q

Re: [Qemu-devel] [PATCH for-3.1 v10 26/31] block/nvme: Fix bdrv_refresh_filename()

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:23 PM CEST, Max Reitz wrote: > Currently, nvme's bdrv_refresh_filename() is an exact copy of null's > implementation. However, for null, "null-co://" and "null-aio://" are > indeed valid filenames -- for nvme, they are not, as a device address is > still required. > > The

[Qemu-devel] [PATCH v8 2/2] target: arm: Add support for VCPU event states

2018-08-28 Thread Dongjiu Geng
This patch extends the qemu-kvm state sync logic with support for KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError exception. And also it can support the exception state migration. Signed-off-by: Dongjiu Geng --- change since v7: 1. Change "pending" and "has_esr" from uint32_t to uint

[Qemu-devel] 答复: [Qemu-arm] [PATCH v7 2/2] target: arm: Add support for VCPU event states

2018-08-28 Thread gengdongjiu
Hi Shannon Ihave changed it according to your comments and repost the patches, thanks for the review. > > Hi, > > On 8/28/2018 4:46 AM, Dongjiu Geng wrote: > > This patch extends the qemu-kvm state sync logic with support for > > KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError e

[Qemu-devel] [PATCH v8 1/2] linux-headers: Update to kernel mainline commit 815f0ddb3

2018-08-28 Thread Dongjiu Geng
Update our kernel headers to mainline commit 815f0ddb346c196018d4d8f8f55c12b83da1de3f (include/linux/compiler*.h: make compiler-*.h mutually exclusive) Signed-off-by: Dongjiu Geng --- include/standard-headers/linux/input.h | 9 + linux-headers/asm-arm/kvm.h| 13 +

[Qemu-devel] [PATCH v8 0/2] add support for VCPU event states

2018-08-28 Thread Dongjiu Geng
Support for KVM_GET/SET_VCPU_EVENTS to get/set the SError exception state, and support the state migration. Now the VCPU event only includes the SError exception status, it can be extended if needed. When do migration, If source machine has serror pending, the target machine is also needed to pen

[Qemu-devel] [PATCH v4] vl.c deprecate incorrect CPUs topology

2018-08-28 Thread Igor Mammedov
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology so that total number of logical CPUs [sockets * cores * threads] would be equal to [maxcpus], however historically we didn't have such check in QEMU and it is possible to start VM with an invalid topology. Deprecate invalid option

Re: [Qemu-devel] [PATCH for-3.1 v10 19/31] block: Use bdrv_dirname() for relative filenames

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:16 PM CEST, Max Reitz wrote: > bdrv_get_full_backing_filename_from_filename() breaks down when it comes > to JSON filenames. Using bdrv_dirname() as the basis is better because > since we have BDS, we can descend through the BDS tree to the protocol > layer, which gives us

Re: [Qemu-devel] [PATCH v3] vl.c deprecate incorrect CPUs topology

2018-08-28 Thread Andrew Jones
On Tue, Aug 28, 2018 at 03:26:07PM +0200, Igor Mammedov wrote: > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology > so that total number of logical CPUs [sockets * cores * threads] > would be equal to [maxcpus], however historically we didn't have > such check in QEMU and it is

Re: [Qemu-devel] [PATCH for-3.1 v10 29/31] block/null: Generate filename even with latency-ns

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:26 PM CEST, Max Reitz wrote: > While we cannot represent the latency-ns option in a filename, it is not > a strong option so not being able to should not stop us from generating > a filename nonetheless. > > Signed-off-by: Max Reitz I thought I had reviewed this one alrea

Re: [Qemu-devel] [PATCH for-3.1 v10 05/31] block: Respect backing bs in bdrv_refresh_filename

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:02 PM CEST, Max Reitz wrote: > +backing_overridden = bdrv_backing_overridden(bs); > + > +if (bs->open_flags & BDRV_O_NO_IO) { > +/* Without I/O, the backing file does not change anything. > + * Therefore, in such a case (primarily qemu-img), we can >

[Qemu-devel] [PATCH v3] vl.c deprecate incorrect CPUs topology

2018-08-28 Thread Igor Mammedov
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology so that total number of logical CPUs [sockets * cores * threads] would be equal to [maxcpus], however historically we didn't have such check in QEMU and it is possible to start VM with an invalid topology. Deprecate invalid option

Re: [Qemu-devel] [PATCH v4 06/29] libvhost-user: exit by default on VHOST_USER_NONE

2018-08-28 Thread Jens Freimann
Since commit 2566378d6d13bf4d28c7770bdbda5f7682594bbe, libvhost-user no longer panics on disconnect (rc == 0), and instead silently ignores an invalid VHOST_USER_NONE message. Without extra work from the API user, this will simply busy-loop on HUP events. The obvious thing to do is to exit(0) ins

Re: [Qemu-devel] [PATCH] pc: make sure that guest isn't able to unplug the first cpu

2018-08-28 Thread Igor Mammedov
On Tue, 28 Aug 2018 10:52:37 +1000 David Gibson wrote: > On Mon, Aug 27, 2018 at 04:02:39PM +0200, Greg Kurz wrote: > > On Mon, 27 Aug 2018 13:07:10 +0200 > > Igor Mammedov wrote: > > > > > The first cpu unplug wasn't ever supported and corresponding > > > monitor/qmp commands refuse to unplu

[Qemu-devel] [PATCH v3 8/8] target/mips: Add MXU instructions S32LDD and S32LDDR

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the S32LDD and S32LDDR MXU instructions. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 v3 - Split gen_mxu function into command specific gen_mxu_ functions target/mips/translate.c | 47

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto device specification

2018-08-28 Thread Gonglei (Arei)
> > On Tue, Aug 28, 2018 at 03:31:02AM +, Gonglei (Arei) wrote: > > > > > -Original Message- > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > Sent: Friday, August 24, 2018 8:54 PM > > > > > > On Fri, Aug 24, 2018 at 12:07:44PM +, Gonglei (Arei) wrote: > > > > Hi Michae

Re: [Qemu-devel] [PATCH for-3.1 v10 07/31] iotests.py: Add node_info()

2018-08-28 Thread Alberto Garcia
On Thu 09 Aug 2018 11:35:04 PM CEST, Max Reitz wrote: > This function queries a node; since we cannot do that right now, it > executes query-named-block-nodes and returns the matching node's object. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 10 ++ > 1 file chang

[Qemu-devel] [PATCH v3 5/8] target/mips: Add MXU instruction D16MUL

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the D16MUL instruction. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 - used sextract_tl instructions instead of shift and ext v3 - Split gen_mxu function into command specific gen_mxu_ functions targe

[Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds all MXU opcodes to the opcode enum. The MXU opcodes overlap with existing misc and Loongson 2F copcodes. The enums were updated to reflect the multiple possible meanings where applicable. Signed-off-by: Craig Janeczek --- v1 - NA v2 - NA v3 - Initial patch, split out from prio

[Qemu-devel] [PATCH v3 7/8] target/mips: Add MXU instructions Q8MUL and Q8MULSU

2018-08-28 Thread Craig Janeczek via Qemu-devel
Adds support for emulating the Q8MUL and Q8MULSU instructions. Signed-off-by: Craig Janeczek --- v1 - initial patch v2 - changed bitfield usage to extract32 v3 - Split gen_mxu function into command specific gen_mxu_ functions target/mips/translate.c | 86 +

[Qemu-devel] [PATCH v3 0/8] Add limited MXU instruction support

2018-08-28 Thread Craig Janeczek via Qemu-devel
This patch set begins to add MXU instruction support for mips emulation. Craig Janeczek (8): target/mips: Introduce MXU registers target/mips: Add all MXU opcodes target/mips: Add MXU instructions S32I2M and S32M2I target/mips: Add MXU instruction S8LDD target/mips: Add MXU instruction D

[Qemu-devel] [PATCH v3 1/8] target/mips: Introduce MXU registers

2018-08-28 Thread Craig Janeczek via Qemu-devel
Define and initialize the 16 MXU registers. Signed-off-by: Craig Janeczek --- v1 - NA v2 - NA v3 - Initial patch, split out from prior first patch target/mips/cpu.h | 1 + target/mips/translate.c | 16 2 files changed, 17 insertions(+) diff --git a/target

  1   2   >