Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl

2018-08-22 Thread Robert Hoo
On Sat, 2018-08-18 at 12:05 -0300, Eduardo Habkost wrote: > > > > > > > > int kvm_has_pit_state2(void) > > > > { > > > > @@ -420,6 +421,41 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, > > > > uint32_t function, > > > > return ret; > > > > } > > > > > > > > +uint32_t kvm_arch_

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/3] target/s390x: use regular spaces in translate.c

2018-08-22 Thread Thomas Huth
On 2018-08-22 16:40, Pavel Zbitskiy wrote: > In a few places translate.c contains non-breaking spaces (0xc2 0xa0) > instead of regular ones (0x20): > > 7c 7c c2 a0 63 63 > 7c 7c 2063 63 > | |c c > > This confuses some text editors. Without your patch: $ file target/s390x/tra

Re: [Qemu-devel] [Bug 1775702] Re: High host CPU load and slower guest after upgrade guest OS Windows 10 to ver 1803

2018-08-22 Thread Alexandre DERUMIER
Hi, proxmox users have reported this bug https://forum.proxmox.com/threads/high-cpu-load-for-windows-10-guests-when-idle.44531/#post-213876 hv_synic && hv_stimer hyperv enlightments fix it (seem to be related to some hpet change in windows) - Mail original - De: "Lemos Lemosov" <1775

[Qemu-devel] [PATCH] input-linux: toggle for lock keys

2018-08-22 Thread Ryan El Kochta via Qemu-devel
This patch introduces three new options on the input-linux commandline: (a) ignore_caps_lock=[on|off] (b) ignore_num_lock=[on|off] (c) ignore_scroll_lock=[on|off] If enabled, the key will be disabled and not forwarded to the guest. There are two main reasons for this: (a) Without keyboard LEDs,

Re: [Qemu-devel] [PATCH 6/7] jobs: utilize job_exit shim

2018-08-22 Thread John Snow
On 08/22/2018 08:20 AM, Max Reitz wrote: > On 2018-08-17 21:04, John Snow wrote: >> Utilize the job_exit shim by not calling job_defer_to_main_loop, and >> where applicable, converting the deferred callback into the job_exit >> callback. >> >> This converts backup, stream, create, and the unit t

Re: [Qemu-devel] [PATCH 1/7] jobs: change start callback to run callback

2018-08-22 Thread John Snow
On 08/22/2018 06:51 AM, Max Reitz wrote: > On 2018-08-17 21:04, John Snow wrote: >> Presently we codify the entry point for a job as the "start" callback, >> but a more apt name would be "run" to clarify the idea that when this >> function returns we consider the job to have "finished," except f

Re: [Qemu-devel] [PATCH v4 10/16] linux-user: Split out some simple file syscalls

2018-08-22 Thread Richard Henderson
On 08/21/2018 05:50 PM, Laurent Vivier wrote: > I don't understand why you need/want to duplicate the list of syscalls here. > > If I modify your patch as following, it works without duplicating the list: > > diff --git a/linux-user/syscall-file.def.c b/linux-user/syscall-file.def.c > new file mo

Re: [Qemu-devel] [PATCH 2/7] jobs: canonize Error object

2018-08-22 Thread John Snow
On 08/22/2018 06:59 AM, Max Reitz wrote: > On 2018-08-21 02:10, John Snow wrote: >> >> >> On 08/17/2018 03:04 PM, John Snow wrote: >>> +error_setg_errno(&job->err, -job->ret, "job failed"); >> >> Kevin specifically asked for me to change this, and I lost it in the >> shuffle. I'll se

Re: [Qemu-devel] [PATCH] char-pty: remove unnecessary #ifdef

2018-08-22 Thread Roman Bolshakov
On Wed, Aug 22, 2018 at 12:38:35PM +0200, Paolo Bonzini wrote: > For some reason __APPLE__ was not checked in pty code. However, the #ifdef > is redundant: this file is already compiled only if CONFIG_POSIX, same as > util/qemu-openpty.c which it uses. > Thanks Paolo! FWIW, qemu_openpty_raw and

Re: [Qemu-devel] [PATCH 5/7] block/mirror: utilize job_exit shim

2018-08-22 Thread John Snow
On 08/22/2018 08:15 AM, Max Reitz wrote: > On 2018-08-17 21:04, John Snow wrote: >> Change the manual deferment to mirror_exit into the implicit >> callback to job_exit and the mirror_exit callback. >> >> This does change the order of some bdrv_unref calls and job_completed, >> but thanks to the

Re: [Qemu-devel] [PATCH v1 1/2] block/snapshot.c: eliminate use of ID input in snapshot operations

2018-08-22 Thread Murilo Opsfelder Araujo
Hi, Daniel. On Tue, Aug 21, 2018 at 06:00:23PM -0300, Daniel Henrique Barboza wrote: > At this moment, QEMU attempts to create/load/delete snapshots > by using either an ID (id_str) or a name. The problem is that the code > isn't consistent of whether the entered argument is an ID or a name, > cau

Re: [Qemu-devel] [RFC PATCH v1 0/2] HMP/snapshot changes - do not use ID anymore

2018-08-22 Thread Murilo Opsfelder Araujo
Hi, Daniel. On Tue, Aug 21, 2018 at 06:00:22PM -0300, Daniel Henrique Barboza wrote: > I am marking the patch series as "RFC" because it was supposed to be > a discussion but, when I was investigating, it turned out to be > easier to send the patches right away. > > It is not uncommon to see bugs

Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim

2018-08-22 Thread John Snow
On 08/22/2018 06:01 PM, Eric Blake wrote: > On 08/22/2018 06:43 AM, Max Reitz wrote: >> On 2018-08-17 21:04, John Snow wrote: >>> All jobs do the same thing when they leave their running loop: >>> - Store the return code in a structure >>> - wait to receive this structure in the main thread >>>

Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim

2018-08-22 Thread Eric Blake
On 08/22/2018 06:43 AM, Max Reitz wrote: On 2018-08-17 21:04, John Snow wrote: All jobs do the same thing when they leave their running loop: - Store the return code in a structure - wait to receive this structure in the main thread - signal job completion via job_completed Few jobs do anything

Re: [Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim

2018-08-22 Thread John Snow
On 08/22/2018 07:58 AM, Max Reitz wrote: > On 2018-08-17 21:18, John Snow wrote: >> >> >> On 08/17/2018 03:04 PM, John Snow wrote: >>> Change the manual deferment to commit_complete into the implicit >>> callback to job_exit, renaming commit_complete to commit_exit. >>> >>> This conversion does

Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim

2018-08-22 Thread John Snow
On 08/22/2018 07:43 AM, Max Reitz wrote: > On 2018-08-17 21:04, John Snow wrote: >> All jobs do the same thing when they leave their running loop: >> - Store the return code in a structure >> - wait to receive this structure in the main thread >> - signal job completion via job_completed >> >> F

Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim

2018-08-22 Thread John Snow
On 08/22/2018 07:52 AM, Max Reitz wrote: > On 2018-08-22 13:43, Max Reitz wrote: > > [...] > >> I'd like .main_loop_settle(). Or .main_loop_post_run(). I think it's >> OK to have names that aren't as cool and tense as possible, when in >> return they actually tell you what they're doing. (S

[Qemu-devel] [PATCH] postcopy: Synchronize usage of the balloon inhibitor

2018-08-22 Thread Alex Williamson
While the qemu_balloon_inhibit() interface appears rather general purpose, postcopy uses it in a last-caller-wins approach with no guarantee of balanced inhibits and de-inhibits. Wrap postcopy's usage of the inhibitor to give it one vote overall, using the same last-caller-wins approach as previou

Re: [Qemu-devel] [PULL 1/4] balloon: Allow multiple inhibit users

2018-08-22 Thread Alex Williamson
On Wed, 22 Aug 2018 11:47:09 -0600 Alex Williamson wrote: > On Wed, 22 Aug 2018 17:56:12 +0200 > Christian Borntraeger wrote: > > > This breaks qemu-io test for me. > > > > #0 0x03ff98f3e2d4 in raise () at /lib64/libc.so.6 > > #1 0x03ff98f239a8 in abort () at /lib64/libc.so.6 > > #2

Re: [Qemu-devel] [PATCH] RFC: chardev: mark the calls that allow an implicit mux monitor

2018-08-22 Thread Eric Blake
On 08/22/2018 01:02 PM, Marc-André Lureau wrote: This is mostly for readability of the code. Let's make it clear which callers can create an implicit monitor when the chardev is muxed. This will also enforce a safer behaviour, as we don't really support creating monitor anywhere/anytime at the m

Re: [Qemu-devel] [PATCH] pc: acpi: revert back to 1 SRAT entry for hotpluggable area

2018-08-22 Thread Eduardo Habkost
CCing NVDIMM maintainer, and Intel people who may be able to help. Summary: SRAT changes added for NVDIMM break memory hotplug on Windows, and our best option right now is to revert the changes. On Wed, Aug 22, 2018 at 11:46:44AM +0200, Igor Mammedov wrote: > Commit > 10efd7e108 "pc: acpi: f

Re: [Qemu-devel] [PATCH v10 62/65] linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh

2018-08-22 Thread Laurent Vivier
Le 17/08/2018 à 16:03, Aleksandar Markovic a écrit : > From: Aleksandar Rikalo > > Add support for nanomips[eb] variant in scripts/qemu-binfmt-conf.sh. > > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan Markovic > --- > scripts/qemu-binfmt-conf.sh | 16 +++- > 1 file c

[Qemu-devel] [PATCH] RFC: chardev: mark the calls that allow an implicit mux monitor

2018-08-22 Thread Marc-André Lureau
This is mostly for readability of the code. Let's make it clear which callers can create an implicit monitor when the chardev is muxed. This will also enforce a safer behaviour, as we don't really support creating monitor anywhere/anytime at the moment. There are documented cases, such as: -seria

Re: [Qemu-devel] [PATCH] pc: acpi: revert back to 1 SRAT entry for hotpluggable area

2018-08-22 Thread Eduardo Habkost
On Wed, Aug 22, 2018 at 03:05:36PM +0200, Igor Mammedov wrote: > On Wed, 22 Aug 2018 12:06:26 +0200 > Laszlo Ersek wrote: > > > On 08/22/18 11:46, Igor Mammedov wrote: > > > Commit > > > 10efd7e108 "pc: acpi: fix memory hotplug regression by reducing stub > > > SRAT entry size" > > > attemped

Re: [Qemu-devel] virtio_stw_phys_cached crash

2018-08-22 Thread Paolo Bonzini
On 22/08/2018 16:57, Fam Zheng wrote: > On master (13b7b188501) and v3.0.0, booting the OpenBSD install63.iso with a > virtio-net (slirp backend) device gives this assertion failure: > > (gdb) bt > #0 0x7f6f25703feb in raise () at /lib64/libc.so.6 > #1 0x7f6f256ee5c1 in abort () at /lib6

Re: [Qemu-devel] [PULL 1/4] balloon: Allow multiple inhibit users

2018-08-22 Thread Alex Williamson
On Wed, 22 Aug 2018 17:56:12 +0200 Christian Borntraeger wrote: > This breaks qemu-io test for me. > > #0 0x03ff98f3e2d4 in raise () at /lib64/libc.so.6 > #1 0x03ff98f239a8 in abort () at /lib64/libc.so.6 > #2 0x03ff98f3632e in __assert_fail_base () at /lib64/libc.so.6 > #3 0x000

Re: [Qemu-devel] [PATCH v1 1/8] s390x/tcg: factor out and fix DATA exception injection

2018-08-22 Thread David Hildenbrand
On 22.08.2018 18:52, David Hildenbrand wrote: > On 22.08.2018 18:31, Richard Henderson wrote: >> On 08/22/2018 12:57 AM, David Hildenbrand wrote: >>> The DXC is to be stored in the low core, and only in the FPC in case AFP >>> is enabled in CR0. >>> >>> Signed-off-by: David Hildenbrand >>> --- >>>

Re: [Qemu-devel] [PATCH v4 4/4] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 07:02:50PM +0200, Marc-André Lureau wrote: > When using "-seccomp on", the seccomp policy is only applied to the > main thread, the vcpu worker thread and other worker threads created > after seccomp policy is applied; the seccomp policy is not applied to > e.g. the RCU thre

Re: [Qemu-devel] [PATCH v4 3/4] configure: require libseccomp 2.2.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 07:02:49PM +0200, Marc-André Lureau wrote: > The following patch is going to require TSYNC, which is only available > since libseccomp 2.2.0. > > libseccomp 2.2.0 was released February 12, 2015. > > According to repology, libseccomp version in different distros: > > RHE

[Qemu-devel] [PATCH v4 2/4] seccomp: prefer SCMP_ACT_KILL_PROCESS if available

2018-08-22 Thread Marc-André Lureau
The upcoming libseccomp release should have SCMP_ACT_KILL_PROCESS action (https://github.com/seccomp/libseccomp/issues/96). SCMP_ACT_KILL_PROCESS is preferable to immediately terminate the offending process, rather than having the SIGSYS handler running. Use SECCOMP_GET_ACTION_AVAIL to check avai

[Qemu-devel] [PATCH v4 1/4] seccomp: use SIGSYS signal instead of killing the thread

2018-08-22 Thread Marc-André Lureau
The seccomp action SCMP_ACT_KILL results in immediate termination of the thread that made the bad system call. However, qemu being multi-threaded, it keeps running. There is no easy way for parent process / management layer (libvirt) to know about that situation. Instead, the default SIGSYS handle

[Qemu-devel] [PATCH v4 0/4] seccomp fixes

2018-08-22 Thread Marc-André Lureau
Hi, This series fixes 2 issues with -sandbox: - The seccomp action SCMP_ACT_KILL results in immediate termination of the thread that made the bad system call. However, qemu being multi-threaded, it keeps running. There is no easy way for parent process / management layer (libvirt) to know a

[Qemu-devel] [PATCH v4 3/4] configure: require libseccomp 2.2.0

2018-08-22 Thread Marc-André Lureau
The following patch is going to require TSYNC, which is only available since libseccomp 2.2.0. libseccomp 2.2.0 was released February 12, 2015. According to repology, libseccomp version in different distros: RHEL-7: 2.3.1 Debian (Stretch): 2.3.1 OpenSUSE Leap 15: 2.3.2 Ubuntu (Xenial):

[Qemu-devel] [PATCH v4 4/4] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Marc-André Lureau
When using "-seccomp on", the seccomp policy is only applied to the main thread, the vcpu worker thread and other worker threads created after seccomp policy is applied; the seccomp policy is not applied to e.g. the RCU thread because it is created before the seccomp policy is applied and SECCOMP_F

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 05:43:36PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 06:19:16PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Wed, Aug 22, 2018 at 6:07 PM, Eric Blake wrote: > > > On 08/22/2018 10:58 AM, Marc-André Lureau wrote: > > > > > >>> At this point you might a

Re: [Qemu-devel] [PATCH v1 1/8] s390x/tcg: factor out and fix DATA exception injection

2018-08-22 Thread David Hildenbrand
On 22.08.2018 18:31, Richard Henderson wrote: > On 08/22/2018 12:57 AM, David Hildenbrand wrote: >> The DXC is to be stored in the low core, and only in the FPC in case AFP >> is enabled in CR0. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/cpu.h | 1 + >> target/s390x/ex

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 06:37:56PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, Aug 22, 2018 at 6:08 PM Daniel P. Berrangé > wrote: > > > > On Wed, Aug 22, 2018 at 05:58:46PM +0200, Marc-André Lureau wrote: > > > On Wed, Aug 22, 2018 at 5:46 PM, Daniel P. Berrangé > > > wrote: > > > > On W

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 06:39:52PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, Aug 22, 2018 at 6:37 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Wed, Aug 22, 2018 at 6:08 PM Daniel P. Berrangé > > wrote: > > > We would have to make libvirt probe for tsync support too, because it > >

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 06:19:16PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, Aug 22, 2018 at 6:07 PM, Eric Blake wrote: > > On 08/22/2018 10:58 AM, Marc-André Lureau wrote: > > > >>> At this point you might as well not bother using seccomp at all. The > >>> thread that is confined merely n

Re: [Qemu-devel] [PATCH v1 2/8] s390x/tcg: store in the TB flags if AFP is enabled

2018-08-22 Thread Richard Henderson
On 08/22/2018 12:57 AM, David Hildenbrand wrote: > We exit the TB when changing the control registers, so just like PSW > bits, this should always be consistent for a TB. > > Using the PSW bit semantic makes things a lot easier compared to > manually defining the sapre, shifted bits. > > Signed-o

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Marc-André Lureau
Hi On Wed, Aug 22, 2018 at 6:37 PM Marc-André Lureau wrote: > > Hi > > On Wed, Aug 22, 2018 at 6:08 PM Daniel P. Berrangé > wrote: > > We would have to make libvirt probe for tsync support too, because it > > now unconditionally uses -sandbox for new enough QEMU. > > sigh :( that's where the -s

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Marc-André Lureau
Hi On Wed, Aug 22, 2018 at 6:08 PM Daniel P. Berrangé wrote: > > On Wed, Aug 22, 2018 at 05:58:46PM +0200, Marc-André Lureau wrote: > > On Wed, Aug 22, 2018 at 5:46 PM, Daniel P. Berrangé > > wrote: > > > On Wed, Aug 22, 2018 at 04:29:56PM +0200, Marc-André Lureau wrote: > > > > > > At this poi

Re: [Qemu-devel] [PATCH v3 03/10] check: Only test isa-testdev when it is compiled in

2018-08-22 Thread Juan Quintela
Thomas Huth wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> Once there, untangle endianness-test and boot-serial-test. >> >> Signed-off-by: Juan Quintela >> >> -- >> >> boot-serial-test don't depend on isa-testdev. Thanks Thomas. >> >> Signed-off-by: Juan Quintela > > Please remove th

Re: [Qemu-devel] [PATCH v1 1/8] s390x/tcg: factor out and fix DATA exception injection

2018-08-22 Thread Richard Henderson
On 08/22/2018 12:57 AM, David Hildenbrand wrote: > The DXC is to be stored in the low core, and only in the FPC in case AFP > is enabled in CR0. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 1 + > target/s390x/excp_helper.c | 28 > targe

Re: [Qemu-devel] Question: Updating wikis on QEMU website - what is the procedure?

2018-08-22 Thread Aleksandar Markovic
> From: Laszlo Ersek > Sent: Wednesday, August 22, 2018 6:19 PM > To: Aleksandar Markovic > Cc: qemu-devel@nongnu.org; Peter Maydell; Rich Fuhler; Alex Bennée; Eduardo > Habkost; Petar Jovanovic > Subject: Re: [Qemu-devel] Question: Updating wikis on QEMU website - what is > the procedure? > >

Re: [Qemu-devel] Question: Updating wikis on QEMU website - what is the procedure?

2018-08-22 Thread Laszlo Ersek
On 08/22/18 18:19, Laszlo Ersek wrote: > On 08/22/18 17:14, Aleksandar Markovic wrote: >> Hello, all. >> >> I need to update soon following two pages on QEMU wiki website >> (https://wiki.qemu.org) >> >> https://wiki.qemu.org/Documentation/Platforms/MIPS >> >> and >> >> https://wiki.qemu.org/Testi

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Marc-André Lureau
Hi On Wed, Aug 22, 2018 at 6:07 PM, Eric Blake wrote: > On 08/22/2018 10:58 AM, Marc-André Lureau wrote: > >>> At this point you might as well not bother using seccomp at all. The >>> thread that is confined merely needs to scribble something into the >>> stack of the unconfined thread and now it

Re: [Qemu-devel] Question: Updating wikis on QEMU website - what is the procedure?

2018-08-22 Thread Laszlo Ersek
On 08/22/18 17:14, Aleksandar Markovic wrote: > Hello, all. > > I need to update soon following two pages on QEMU wiki website > (https://wiki.qemu.org) > > https://wiki.qemu.org/Documentation/Platforms/MIPS > > and > > https://wiki.qemu.org/Testing. > > It looks these wikis are not editable

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Eric Blake
On 08/22/2018 10:58 AM, Marc-André Lureau wrote: At this point you might as well not bother using seccomp at all. The thread that is confined merely needs to scribble something into the stack of the unconfined thread and now it can do whatever it wants. Actually, that message is incorrect, it

Re: [Qemu-devel] [PATCH v4 11/16] linux-user: Split out preadv, pwritev, readv, writev

2018-08-22 Thread Laurent Vivier
Le 18/08/2018 à 21:01, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > linux-user/syscall-file.inc.c | 98 +++ > linux-user/syscall.c | 75 ++- > linux-user/strace.list| 12 - > 3 files changed, 10

Re: [Qemu-devel] [PULL 0/3] seccomp branch queue

2018-08-22 Thread Daniel P . Berrangé
27;remotes/kraxel/tags/vga-20180821-pull-request' into staging (2018-08-21 > 15:57:56 +0100) > > are available in the Git repository at: > > https://github.com/otubo/qemu.git tags/pull-seccomp-20180822 > > for you to fetch changes up to 2131f3e6e98195b4ce43a87c78cd9d8c

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 05:58:46PM +0200, Marc-André Lureau wrote: > On Wed, Aug 22, 2018 at 5:46 PM, Daniel P. Berrangé > wrote: > > On Wed, Aug 22, 2018 at 04:29:56PM +0200, Marc-André Lureau wrote: > > > > At this point you might as well not bother using seccomp at all. The > > thread that is

Re: [Qemu-devel] [PULL 0/3] seccomp branch queue

2018-08-22 Thread Eric Blake
https://github.com/otubo/qemu.git tags/pull-seccomp-20180822 for you to fetch changes up to 2131f3e6e98195b4ce43a87c78cd9d8cb9f4da2c: seccomp: set the seccomp filter to all threads (2018-08-22 17:35:34 +0200) pull-seccom

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 12:49:48PM -0300, Eduardo Habkost wrote: > > The thing that has really tipped my mind this way is that even > > if we provide new device models, mgmt apps will be loathe to > > actually use them because it will prevent live migration of > > those guests to hosts with older

[Qemu-devel] [PULL 2/3] seccomp: prefer SCMP_ACT_KILL_PROCESS if available

2018-08-22 Thread Eduardo Otubo
From: Marc-André Lureau The upcoming libseccomp release should have SCMP_ACT_KILL_PROCESS action (https://github.com/seccomp/libseccomp/issues/96). SCMP_ACT_KILL_PROCESS is preferable to immediately terminate the offending process, rather than having the SIGSYS handler running. Use SECCOMP_GET_

Re: [Qemu-devel] [PULL 1/4] balloon: Allow multiple inhibit users

2018-08-22 Thread Christian Borntraeger
This breaks qemu-io test for me. #0 0x03ff98f3e2d4 in raise () at /lib64/libc.so.6 #1 0x03ff98f239a8 in abort () at /lib64/libc.so.6 #2 0x03ff98f3632e in __assert_fail_base () at /lib64/libc.so.6 #3 0x03ff98f363ac in () at /lib64/libc.so.6 #4 0x0108301a in qemu_balloo

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Marc-André Lureau
On Wed, Aug 22, 2018 at 5:46 PM, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 04:29:56PM +0200, Marc-André Lureau wrote: >> When using "-seccomp on", the seccomp policy is only applied to the >> main thread, the vcpu worker thread and other worker threads created >> after seccomp policy is

[Qemu-devel] [PULL 0/3] seccomp branch queue

2018-08-22 Thread Eduardo Otubo
ll-seccomp-20180822 for you to fetch changes up to 2131f3e6e98195b4ce43a87c78cd9d8cb9f4da2c: seccomp: set the seccomp filter to all threads (2018-08-22 17:35:34 +0200) pull-seccom

Re: [Qemu-devel] Question: Updating wikis on QEMU website - what is the procedure?

2018-08-22 Thread Eduardo Habkost
On Wed, Aug 22, 2018 at 03:14:12PM +, Aleksandar Markovic wrote: > Hello, all. > > I need to update soon following two pages on QEMU wiki website > (https://wiki.qemu.org) > > https://wiki.qemu.org/Documentation/Platforms/MIPS > > and > > https://wiki.qemu.org/Testing. > > It looks these

Re: [Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 04:29:56PM +0200, Marc-André Lureau wrote: > When using "-seccomp on", the seccomp policy is only applied to the > main thread, the vcpu worker thread and other worker threads created > after seccomp policy is applied; the seccomp policy is not applied to > e.g. the RCU thre

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Eduardo Habkost
On Wed, Aug 22, 2018 at 03:57:20PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 11:18:28AM -0300, Eduardo Habkost wrote: > > On Wed, Aug 22, 2018 at 02:44:40PM +0100, Daniel P. Berrangé wrote: [...] > > > An explicit virtio-transitional device is still two separate > > > devices prete

[Qemu-devel] [PULL 1/3] seccomp: use SIGSYS signal instead of killing the thread

2018-08-22 Thread Eduardo Otubo
From: Marc-André Lureau The seccomp action SCMP_ACT_KILL results in immediate termination of the thread that made the bad system call. However, qemu being multi-threaded, it keeps running. There is no easy way for parent process / management layer (libvirt) to know about that situation. Instead,

[Qemu-devel] [PULL 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Eduardo Otubo
From: Marc-André Lureau When using "-seccomp on", the seccomp policy is only applied to the main thread, the vcpu worker thread and other worker threads created after seccomp policy is applied; the seccomp policy is not applied to e.g. the RCU thread because it is created before the seccomp polic

Re: [Qemu-devel] [PATCH v4 2/3] target/s390x: exception on non-aligned LPSW(E)

2018-08-22 Thread Richard Henderson
On 08/22/2018 07:40 AM, Pavel Zbitskiy wrote: > @@ -2828,9 +2828,13 @@ static DisasJumpType op_lpp(DisasContext *s, DisasOps > *o) > > static DisasJumpType op_lpsw(DisasContext *s, DisasOps *o) > { > +TCGv_i32 t0; > TCGv_i64 t1, t2; > > check_privileged(s); > +t0 = tcg_cons

[Qemu-devel] [Bug 1775702] Re: High host CPU load and slower guest after upgrade guest OS Windows 10 to ver 1803

2018-08-22 Thread Heiko Sieger
I ran into similar issues with Windows 10 (1803), with regard to 2D graphics performance. See my bug report here: https://bugzilla.kernel.org/show_bug.cgi?id=200877 Could you test with Spectre protection (temporarily) turned off inside the Windows VM? See my post here: https://heiko-sieger.info/

Re: [Qemu-devel] [PATCH v3 0/3] seccomp fixes

2018-08-22 Thread Eduardo Otubo
On 22/08/2018 - 16:29:53, Marc-André Lureau wrote: > Hi, > > This series fixes 2 issues with -sandbox: > > - The seccomp action SCMP_ACT_KILL results in immediate termination of > the thread that made the bad system call. However, qemu being > multi-threaded, it keeps running. There is no eas

Re: [Qemu-devel] [PATCH v2 1/3] qapi: add x-query-block-graph

2018-08-22 Thread Vladimir Sementsov-Ogievskiy
20.08.2018 20:35, Vladimir Sementsov-Ogievskiy wrote: 20.08.2018 20:13, Max Reitz wrote: On 2018-08-20 19:04, Vladimir Sementsov-Ogievskiy wrote: 20.08.2018 19:35, Max Reitz wrote: On 2018-08-20 17:13, Vladimir Sementsov-Ogievskiy wrote: 20.08.2018 16:44, Max Reitz wrote: On 2018-08-20 12:20

Re: [Qemu-devel] [PATCH v4 1/3] target/s390x: use regular spaces in translate.c

2018-08-22 Thread David Hildenbrand
On 22.08.2018 16:40, Pavel Zbitskiy wrote: > In a few places translate.c contains non-breaking spaces (0xc2 0xa0) > instead of regular ones (0x20): > > 7c 7c c2 a0 63 63 > 7c 7c 2063 63 > | |c c > > This confuses some text editors. > > Signed-off-by: Pavel Zbitskiy > --- >

Re: [Qemu-devel] [PATCH v4 0/3] Some improvements in z/Arch instructions support

2018-08-22 Thread David Hildenbrand
On 22.08.2018 16:40, Pavel Zbitskiy wrote: > Changes since v3: > * Patches 1-6 were accepted, thanks! > * Use in1_la2 in op_cvb(). > * Free a temp in op_cvb(). > * Make ra const in helper_cvb(). > * Use wrap_address() in helper_cvb(). > * Add a minor formatting patch. > * Add LPSW(E) alignment chec

Re: [Qemu-devel] [PATCH v4 2/3] target/s390x: exception on non-aligned LPSW(E)

2018-08-22 Thread David Hildenbrand
On 22.08.2018 16:40, Pavel Zbitskiy wrote: > Both LPSW and LPSWE should raise a specification exception when their > operand is not doubleword aligned. > > This could've been done without a helper, but this would introduce a > new basic block, which would require making o->in2 local. This > could'

[Qemu-devel] Question: Updating wikis on QEMU website - what is the procedure?

2018-08-22 Thread Aleksandar Markovic
Hello, all. I need to update soon following two pages on QEMU wiki website (https://wiki.qemu.org) https://wiki.qemu.org/Documentation/Platforms/MIPS and https://wiki.qemu.org/Testing. It looks these wikis are not editable by public (like it is the case for Wikipedia). How can I do the updat

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 10:37:12AM -0400, Laine Stump wrote: > On 08/22/2018 09:44 AM, Daniel P. Berrangé wrote: > > Even if someone is willing to implement it in libvirt, we have to > > consider the cost of supporting it in both libvirt and applications > > using libvirt and the complexity it adds

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 11:18:28AM -0300, Eduardo Habkost wrote: > On Wed, Aug 22, 2018 at 02:44:40PM +0100, Daniel P. Berrangé wrote: > > On Wed, Aug 22, 2018 at 09:54:55AM -0300, Eduardo Habkost wrote: > > > On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: > > > > On Wed, Aug 2

[Qemu-devel] virtio_stw_phys_cached crash

2018-08-22 Thread Fam Zheng
On master (13b7b188501) and v3.0.0, booting the OpenBSD install63.iso with a virtio-net (slirp backend) device gives this assertion failure: (gdb) bt #0 0x7f6f25703feb in raise () at /lib64/libc.so.6 #1 0x7f6f256ee5c1 in abort () at /lib64/libc.so.6 #2 0x7f6f256ee491 in _nl_load_dom

[Qemu-devel] [PULL 1/1] fsdev: fix compilation with VIRTIO but not VIRTIO_9P

2018-08-22 Thread Greg Kurz
From: Paolo Bonzini hw/9pfs/Makefile.objs uses CONFIG_VIRTIO_9P to guard the definition for FileOperations structs, while fsdev/Makefile.objs uses CONFIG_VIRTIO to guard the use. Mismatch causes linking to fail when CONFIG_VIRTIO is set but CONFIG_VIRTIO_9P is not. Fix it and use if/else to cla

[Qemu-devel] [PULL 0/1] 9p patches 2018-08-22

2018-08-22 Thread Greg Kurz
The following changes since commit 13b7b188501d419a7d63c016e00065bcc693b7d4: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20180821-pull-request' into staging (2018-08-21 15:57:56 +0100) are available in the Git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for

[Qemu-devel] [PATCH v4 3/3] target/s390x: implement CVB, CVBY and CVBG

2018-08-22 Thread Pavel Zbitskiy
Convert to Binary - counterparts of the already implemented Convert to Decimal (CVD*) instructions. Example from the Principles of Operation: 25594C becomes 63FA. Signed-off-by: Pavel Zbitskiy --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 4 +++ target/s390x/int_

Re: [Qemu-devel] [PATCH v3 06/10] check: Only test ivshm when it is compiled in

2018-08-22 Thread Thomas Huth
On 2018-08-22 16:36, Juan Quintela wrote: [...] > I got even more confused. check-qtest-pci-y is only tested on x86*, go > figure. Yes, that's ugly, indeed. We should maybe rework that so that all board which include pci.mak can use it... Thomas

[Qemu-devel] [PATCH v4 1/3] target/s390x: use regular spaces in translate.c

2018-08-22 Thread Pavel Zbitskiy
In a few places translate.c contains non-breaking spaces (0xc2 0xa0) instead of regular ones (0x20): 7c 7c c2 a0 63 63 7c 7c 2063 63 | |c c This confuses some text editors. Signed-off-by: Pavel Zbitskiy --- target/s390x/translate.c | 4 ++-- 1 file changed, 2 insertions(+),

[Qemu-devel] [PATCH v4 2/3] target/s390x: exception on non-aligned LPSW(E)

2018-08-22 Thread Pavel Zbitskiy
Both LPSW and LPSWE should raise a specification exception when their operand is not doubleword aligned. This could've been done without a helper, but this would introduce a new basic block, which would require making o->in2 local. This could've also been done in load_psw helper, but this is too l

[Qemu-devel] [PATCH v4 0/3] Some improvements in z/Arch instructions support

2018-08-22 Thread Pavel Zbitskiy
Changes since v3: * Patches 1-6 were accepted, thanks! * Use in1_la2 in op_cvb(). * Free a temp in op_cvb(). * Make ra const in helper_cvb(). * Use wrap_address() in helper_cvb(). * Add a minor formatting patch. * Add LPSW(E) alignment check. Pavel Zbitskiy (3): target/s390x: use regular spaces

Re: [Qemu-devel] [PATCH v3 08/10] check: Move VMXNET3 test to common

2018-08-22 Thread Juan Quintela
Thomas Huth wrote: > On 2018-08-22 12:41, Juan Quintela wrote: >> Thomas Huth wrote: >>> On 2018-08-22 11:54, Juan Quintela wrote: We protect it with CONFIG_VMXNET3_PCI now, so no need to also put it on i386. Signed-off-by: Juan Quintela --- tests/Makefile.include

Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in

2018-08-22 Thread Juan Quintela
Thomas Huth wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> This is only for x86* architecture. >> >> Signed-off-by: Juan Quintela >> --- >> tests/Makefile.include | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/Makefile.include b/tests/Makefile.include

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Laine Stump
On 08/22/2018 09:44 AM, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 09:54:55AM -0300, Eduardo Habkost wrote: >> On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: >>> On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: On Wed, Aug 22, 2018 at 12:36:27PM +0

Re: [Qemu-devel] [PATCH v3 06/10] check: Only test ivshm when it is compiled in

2018-08-22 Thread Juan Quintela
Thomas Huth wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/Makefile.include | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/tests/Makefile.include b/tests/Makefile.include >> index 9a918f7655..116e93cdb6 10064

[Qemu-devel] [PATCH v3 3/3] seccomp: set the seccomp filter to all threads

2018-08-22 Thread Marc-André Lureau
When using "-seccomp on", the seccomp policy is only applied to the main thread, the vcpu worker thread and other worker threads created after seccomp policy is applied; the seccomp policy is not applied to e.g. the RCU thread because it is created before the seccomp policy is applied and SECCOMP_F

Re: [Qemu-devel] [PATCH v3 03/10] check: Only test isa-testdev when it is compiled in

2018-08-22 Thread Juan Quintela
Thomas Huth wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> Once there, untangle endianness-test and boot-serial-test. >> >> Signed-off-by: Juan Quintela >> >> -- >> >> boot-serial-test don't depend on isa-testdev. Thanks Thomas. >> >> Signed-off-by: Juan Quintela > > Please remove th

Re: [Qemu-devel] [PATCH v3 04/10] check: Only test usb-xhci-nec when it is compiled in

2018-08-22 Thread Juan Quintela
Thomas Huth wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/Makefile.include | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/tests/Makefile.include b/tests/Makefile.include >> index 15296be246..9a918f7655 10

[Qemu-devel] [PATCH v3 1/3] seccomp: use SIGSYS signal instead of killing the thread

2018-08-22 Thread Marc-André Lureau
The seccomp action SCMP_ACT_KILL results in immediate termination of the thread that made the bad system call. However, qemu being multi-threaded, it keeps running. There is no easy way for parent process / management layer (libvirt) to know about that situation. Instead, the default SIGSYS handle

[Qemu-devel] [PATCH v3 2/3] seccomp: prefer SCMP_ACT_KILL_PROCESS if available

2018-08-22 Thread Marc-André Lureau
The upcoming libseccomp release should have SCMP_ACT_KILL_PROCESS action (https://github.com/seccomp/libseccomp/issues/96). SCMP_ACT_KILL_PROCESS is preferable to immediately terminate the offending process, rather than having the SIGSYS handler running. Use SECCOMP_GET_ACTION_AVAIL to check avai

[Qemu-devel] [PATCH v3 0/3] seccomp fixes

2018-08-22 Thread Marc-André Lureau
Hi, This series fixes 2 issues with -sandbox: - The seccomp action SCMP_ACT_KILL results in immediate termination of the thread that made the bad system call. However, qemu being multi-threaded, it keeps running. There is no easy way for parent process / management layer (libvirt) to know a

Re: [Qemu-devel] [PATCH v3 02/10] check: Use land/lor when possible

2018-08-22 Thread Juan Quintela
Thomas Huth wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> So everythig is (a bit) more consistent >> >> Signed-off-by: Juan Quintela >> --- >> tests/Makefile.include | 12 >> 1 file changed, 4 insertions(+), 8 deletions(-) > [...] >> @@ -299,9 +297,7 @@ check-qtest-i386-y +

Re: [Qemu-devel] [PATCH v3 01/10] configure: We don't want to clean configuration files

2018-08-22 Thread Juan Quintela
Thomas Huth wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> If you don't want to compile everything, you configure >> config-devices.mak. And then make clean remove it, and make will >> create a default one without your configuration. Fix it by not >> removing it on clean target. Remove i

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Eduardo Habkost
On Wed, Aug 22, 2018 at 02:44:40PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 09:54:55AM -0300, Eduardo Habkost wrote: > > On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: > > > > On Wed, Aug 2

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 09:54:55AM -0300, Eduardo Habkost wrote: > On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: > > On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: > > > On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: > > > > On Tue, 2018-08

Re: [Qemu-devel] [PATCH] job: Fix nested aio_poll() hanging in job_txn_apply

2018-08-22 Thread Eric Blake
On 08/22/2018 12:48 AM, Fam Zheng wrote: However, I was unable to quickly audit whether all callers really did have the lock (it balloons into whether all callers of job_finalize() have the lock), so I'm reluctant to give R-b. @@ -857,10 +849,10 @@ static void job_completed_txn_success(Job *job

[Qemu-devel] [PATCH v2 3/3] ui: remove support for SDL1.2 in favour of SDL2

2018-08-22 Thread Daniel P . Berrangé
SDL1.2 was deprecated in the 2.12.0 release with: commit e52c6ba34149b4f39c3fd60e59ee32b809db2bfa Author: Daniel P. Berrange Date: Mon Jan 15 14:25:33 2018 + ui: deprecate use of SDL 1.2 in favour of 2.0 series The SDL 2.0 release was made in Aug, 2013: https://www.li

[Qemu-devel] [PATCH v2 2/3] ui: increase min required GTK3 version to 3.14.0

2018-08-22 Thread Daniel P . Berrangé
Per supported platforms doc[1], the various min GTK3 on relevant distros is: RHEL-7.0: 3.8.8 RHEL-7.2: 3.14.13 RHEL-7.4: 3.22.10 RHEL-7.5: 3.22.26 Debian (Stretch): 3.22.11 Debian (Jessie): 3.14.5 OpenBSD (Ports): 3.22.30 FreeBSD (Ports): 3.22.29 OpenSUSE Leap 15: 3.22.30 SLE12

[Qemu-devel] [PATCH v2 1/3] ui: remove support for GTK2 in favour of GTK3

2018-08-22 Thread Daniel P . Berrangé
GTK2 was deprecated in the 2.12.0 release with: commit b7715af2b31f47060cc5b4be930d16c13be93fa9 Author: Daniel P. Berrange Date: Tue Dec 12 11:34:40 2017 + ui: deprecate use of GTK 2.x in favour of 3.x series The GTK 3.0 release was made in Feb, 2011: https://blog.gtk

[Qemu-devel] [PATCH v2 0/3] ui: remove deprecated UI frontends

2018-08-22 Thread Daniel P . Berrangé
We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to be removed entirely in the 3.1.0 release. The min GTK3 version can also be bumped up based the distros we aim to support. Note that before this can merge, the openbsd VM test image needs to be updated to have SDL2, as openbsd

  1   2   3   >