Re: [Qemu-devel] [C v2 10/10] hw/m68k: define Macintosh Quadra 800

2018-07-07 Thread Thomas Huth
On 28.06.2018 01:23, Laurent Vivier wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- > MAINTAINERS | 19 ++ > default-configs/m68k-softmmu.mak | 14 ++ > hw/intc/Makefile.objs

Re: [Qemu-devel] [C v2 09/10] dp8393x: manage big endian bus

2018-07-07 Thread Thomas Huth
On 28.06.2018 01:23, Laurent Vivier wrote: > This is needed by Quadra 800, this card can run on little-endian > or big-endian bus. > > Signed-off-by: Laurent Vivier > Tested-by: Hervé Poussineau > --- > hw/net/dp8393x.c | 88 > > 1 file

Re: [Qemu-devel] [PATCH v6 02/27] json: remove useless return value from lexer/parser

2018-07-07 Thread Thomas Huth
On 06.07.2018 12:57, Marc-André Lureau wrote: > The lexer always returns 0 when char feeding. Furthermore, none of the > caller care about the return value. > > Signed-off-by: Marc-André Lureau > Message-Id: <20180326150916.9602-10-marcandre.lur...@redhat.com> > Reviewed-by: Markus Armbruster >

Re: [Qemu-devel] [PATCH v6 03/27] tests: change /0.15/* tests to /qmp/*

2018-07-07 Thread Thomas Huth
On 06.07.2018 12:57, Marc-André Lureau wrote: > Presumably 0.15 was the version it was first introduced, but > qmp keeps evolving. There is no point in having that version > as test prefix, 'qmp' makes more sense here. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake > Message-Id:

[Qemu-devel] [PULL 0/1] NBD patches for 3.0

2018-07-07 Thread Eric Blake
The following changes since commit 43a473993fd9378bf850dcafa68eb6dee8c300f8: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-07-06 18:18:08 +0100) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-07-07 for you to

[Qemu-devel] [PULL 1/1] nbd/server: fix nbd_co_send_block_status

2018-07-07 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Call nbd_co_send_extents() with correct length parameter (extent.length may be smaller than original length). Also, switch length parameter type to uint32_t, to correspond with request->len and similar nbd_co_send_bitmap(). Signed-off-by: Vladimir Sementsov-Og

Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

2018-07-07 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180704132239.6506-1-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() === TES

Re: [Qemu-devel] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations

2018-07-07 Thread Guenter Roeck
On Fri, Jul 06, 2018 at 02:41:18PM +0200, Paolo Bonzini wrote: > On 06/07/2018 03:18, David Gibson wrote: > >> Ok, but why would it even fail? Maybe it's not this case, but even if > >> it's not fatal for the OS, generating different device trees silently > >> seems like a recipe for Heisenbugs. >

[Qemu-devel] [RFC] target/mips: Initial support for MIPS R5900

2018-07-07 Thread Fredrik Noring
Hi, This patch implements initial QEMU support for the MIPS R5900. Primarily code generated by GCC. The only special instruction needed for this, as far as I can tell, is the three-operand multiply. The MIPS R5900 is normally taken to be MIPS3, but it has MOVN, MOVZ and PREF defined in MIPS4 whic

Re: [Qemu-devel] [PATCH] etsec: fix IRQ (un)masking

2018-07-07 Thread Michael Davidsaver
On 11/28/2017 05:35 PM, David Gibson wrote: > On Mon, Nov 27, 2017 at 08:42:13PM -0600, Michael Davidsaver wrote: >> Interrupt conditions occurring while masked are not being >> signaled when later unmasked. >> The fix is to raise/lower IRQs when IMASK is changed. >> >> To avoid problems like this

Re: [Qemu-devel] [PATCH 03/14] timer: ds1338 persist 12-hour mode selection

2018-07-07 Thread Michael Davidsaver
On 07/05/2018 09:35 PM, Michael Davidsaver wrote: > Also, I though I had test coverage of this bug. That's actually how I > noticed it to begin with. But it seems my later change to allow for a > slow test runner also stopped testing readback of the 12/24 hour mode bit. > It just silently uses wh

[Qemu-devel] [PATCH v2 07/14] tests: ds-rtc test wday offset

2018-07-07 Thread Michael Davidsaver
Signed-off-by: Michael Davidsaver --- tests/ds-rtc-common.h | 10 +++--- tests/ds-rtc-current-test.c | 9 - tests/ds-rtc-set-test.c | 6 -- 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/tests/ds-rtc-common.h b/tests/ds-rtc-common.h index 5bc7ab32a6..7

[Qemu-devel] [PATCH v2 06/14] tests: ds-rtc test 12 hour mode

2018-07-07 Thread Michael Davidsaver
Signed-off-by: Michael Davidsaver --- tests/ds-rtc-common.h | 9 --- tests/ds-rtc-current-test.c | 2 +- tests/ds-rtc-set-test.c | 58 +++-- 3 files changed, 63 insertions(+), 6 deletions(-) diff --git a/tests/ds-rtc-common.h b/tests/ds-rtc

Re: [Qemu-devel] [virtio-dev] [PATCH v3 3/3] Add "Group Identifier" support to Red Hat PCI Express bridge.

2018-07-07 Thread Marcel Apfelbaum
Hi Venu, On 06/30/2018 01:19 AM, Venu Busireddy wrote: Add a new bridge device "pcie-downstream" with a Vendor ID of PCI_VENDOR_ID_REDHAT and a Device ID of PCI_DEVICE_ID_REDHAT_DOWNPORT_FAILOVER. Can't we use the current pcie-pci-bridge device (see hw/pci-bridge/pcie_pci_bridge.c) by adding

[Qemu-devel] [PATCH V4] qemu-img: align result of is_allocated_sectors

2018-07-07 Thread Peter Lieven
We currently don't enforce that the sparse segments we detect during convert are aligned. This leads to unnecessary and costly read-modify-write cycles either internally in Qemu or in the background on the storage device as nearly all modern filesystems or hardware have a 4k alignment internally.

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-07-07 Thread Apport retracing service
** Tags added: cosmic -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1755912 Title: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl Status in QEMU: New Status in qemu package i

Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc

2018-07-07 Thread Laurent Vivier
Le 07/07/2018 à 01:02, Stafford Horne a écrit : > On Fri, Jul 06, 2018 at 05:22:15PM -0500, Eric Blake wrote: >> On 07/04/2018 03:54 PM, Richard Henderson wrote: >>> On 07/03/2018 04:51 PM, Stafford Horne wrote: Richard, how do you usually remove these before your pr?  I suppose you have

Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc

2018-07-07 Thread Alex Bennée
Stafford Horne writes: > Hello, > > On Wed, Jul 4, 2018, 7:34 AM Philippe Mathieu-Daudé wrote: > >> Hi Stafford, >> >> On 07/02/2018 12:10 PM, Stafford Horne wrote: >> > From: Richard Henderson > > Sorry, I brought these in from Richards tree and saw them but thought it > was fine to keep th