Re: [Qemu-devel] [PATCH v2] e1000e: Prevent MSI/MSI-X storms

2018-06-29 Thread Jan Kiszka
On 2018-04-05 19:41, Jan Kiszka wrote: > From: Jan Kiszka > > Only signal MSI/MSI-X events on rising edges. So far we re-triggered the > interrupt sources even if the guest did no consumed the pending one, > easily causing interrupt storms. > > Issue was observable with Linux 4.16 e1000e driver

[Qemu-devel] [PULL 42/47] monitor: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-43-f4...@amsat.org> Signed-off-by: Paolo Bo

[Qemu-devel] [PULL 41/47] cutils: Do not include "qemu/units.h" directly

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé All files using "qemu/units.h" definitions already include it directly, we can now remove it from "qemu/cutils.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marcel Apfelbaum Message-Id: <20180625124238.25339-41-f4...@amsat.org> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 46/47] bsd-user: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-47-f4...@amsat.org> Signed-off-by: Paolo Bo

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-29 Thread David Gibson
On Fri, Jun 29, 2018 at 08:06:10PM +0200, Sebastian Bauer wrote: > Hi, > > Am 2018-06-19 06:36, schrieb David Gibson: > > Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. > > It looks like you've made it against a tree including some of BALATON > > Zoltan's proposed but not yet

[Qemu-devel] [PULL 40/47] hw/rdma: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia Messag

[Qemu-devel] [PULL 38/47] hw/vfio: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-38-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 37/47] hw/sd: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-37-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 39/47] hw/virtio: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-39-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 45/47] linux-user: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-46-f4...@amsat.org> Signed-off-by: Paolo Bo

[Qemu-devel] [PULL 43/47] vl: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-44-f4...@amsat.org> Signed-off-by: Paolo Bo

[Qemu-devel] [PULL 36/47] hw/usb: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-36-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 32/47] hw/mips: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Franc

[Qemu-devel] [PULL 31/47] hw/mips/r4k: Constify params_size

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-30-f4...@amsat.org> Signed-off-by: Paolo Bonzini --- hw/mips/mips_r4k.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c index e

[Qemu-devel] [PULL 33/47] hw/ppc: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson Message-Id: <20180625124238.25339-33-f4

[Qemu-devel] [PULL 35/47] hw/net: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Weil Message-Id: <20180625124238.25339-35-

[Qemu-devel] [PULL 24/47] hw/alpha: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-23-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 28/47] hw/cris: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-27-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 34/47] hw/i386: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
It eases code review, unit is explicit. Patch generated using: $ git grep -E '[<>][<>]=? ?[1-5]0' hw/ include/hw/ and modified manually. Signed-off-by: Paolo Bonzini --- hw/i386/acpi-build.c | 4 ++-- hw/i386/pc.c | 23 --- hw/i386/pc_piix.c| 3 ++- hw/i386

[Qemu-devel] [PULL 26/47] hw/microblaze: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-25-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 44/47] tests/crypto: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-45-f4...@amsat.org> Signed-off-by: Paolo Bo

[Qemu-devel] [PULL 16/47] hw/display: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann Reviewed-by: Alistair Francis Mess

[Qemu-devel] [PULL 30/47] hw/sh4: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-29-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 15/47] hw/block: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-14-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 47/47] serial: Open non-block

2018-06-29 Thread Paolo Bonzini
From: "Dr. David Alan Gilbert" On a real serial device, the open can block if the handshake lines are in a particular state. If a QEMU is passing the serial device to the guest, the QEMU startup is blocked opening the device (with a symptom seen as a timeout from libvirt). Open the serial port

[Qemu-devel] [PULL 25/47] hw/tricore: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Bastian Koppelmann Message-Id: <20180625124238.25339

[Qemu-devel] [PULL 27/47] hw/nios2: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-26-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 23/47] hw/xtensa: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ $ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Max Filippov Mes

[Qemu-devel] [PULL 21/47] hw/s390x: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Acked-by: Cornelia Huck Message-Id:

[Qemu-devel] [PULL 11/47] hw/scsi: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-10-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 29/47] hw/lm32: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle Message-Id: <20180625124238.25339-28-f

[Qemu-devel] [PULL 22/47] hw/hppa: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Acked-by: Cornelia Huck Message-Id:

[Qemu-devel] [PULL 10/47] hw/ipack: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alberto Garcia Message-Id: <20180625124238.25339-

[Qemu-devel] [PULL 18/47] hw/riscv: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael Clark Message-Id: <20180625124238.25339-1

[Qemu-devel] [PULL 20/47] hw/sparc: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-19-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 19/47] hw/m68k: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20180625124238.25339-18-

[Qemu-devel] [PULL 17/47] hw/misc: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-16-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 00/47] More misc patches for 3.0 soft freeze

2018-06-29 Thread Paolo Bonzini
The following changes since commit 109b25045b3651f9c5d02c3766c0b3ff63e6d193: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-06-29 12:30:29 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fet

[Qemu-devel] [PULL 12/47] hw/smbios: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-11-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 07/47] hw: Use IEC binary prefix definitions from "qemu/units.h"

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Code change produced with: $ git ls-files | egrep '\.[ch]$' | \ xargs sed -i -e 's/\(\W[KMGTPE]\)_BYTE/\1iB/g' Suggested-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson (ppc parts) Message-Id: <20180625124238.25339-6-f4...@amsat

[Qemu-devel] [PULL 14/47] hw/tpm: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Message-Id: <20180625124238.253

[Qemu-devel] [PULL 01/47] i386/kvm: add support for Hyper-V TLB flush

2018-06-29 Thread Paolo Bonzini
From: Vitaly Kuznetsov Add support for Hyper-V TLB flush which recently got added to KVM. Just like regular Hyper-V we announce HV_EX_PROCESSOR_MASKS_RECOMMENDED regardless of how many vCPUs we have. Windows is 'smart' and uses less expensive non-EX Hypercall whenever possible (when it wants to

[Qemu-devel] [PULL 04/47] vdi: Use definitions from "qemu/units.h"

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Weil Message-Id: <20180625124238.25339-3-f4...@amsat.org> Signed-off-by: Paolo Bonzini --- block/vdi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/vdi.c b/block/vdi.c in

[Qemu-devel] [PULL 13/47] hw/xen: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alan Robinson Message-Id: <20180625124238.25339-1

[Qemu-devel] [PULL 09/47] hw/ivshmem: Use the IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Message-Id: <20180625124238.253

[Qemu-devel] [PULL 05/47] x86/cpu: Use definitions from "qemu/units.h"

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Eduardo Habkost Message-Id: <20180625124238.25339-4-f4...@amsat.org> Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/i386/cpu.c b/targe

[Qemu-devel] [PULL 02/47] configure: add sanity check to catch builds from "git archive"

2018-06-29 Thread Paolo Bonzini
From: Daniel P. Berrangé The "git archive" feature creates tarballs which are missing all submodule content. GitHub unhelpfully provides users with "Download" links that claim to give them valid source release tarballs. These GitHub archives will not be buildable as they are created by the "git a

[Qemu-devel] [PULL 08/47] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h"

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé These files don't use anything exposed by "qemu/cutils.h", simplify preprocessing including directly "qemu/units.h". Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson (ppc parts) Message-Id: <20180625124238.25339-7-f4...@amsat.org> Signed-off-by: Paolo B

[Qemu-devel] [PULL 03/47] include: Add IEC binary prefixes in "qemu/units.h"

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Loosely based on 076b35b5a56. Suggested-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180625124238.25339-2-f4...@amsat.org> Signed-off-by: Paolo Bonzini --- include/qemu/units.h | 20 1 file changed, 20 insertions(+) c

[Qemu-devel] [PULL 06/47] checkpatch: Recognize IEC binary prefix definitions

2018-06-29 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Do not match the IEC binary prefix as camelcase typedefs. This fixes: ERROR: "foo * bar" should be "foo *bar" #310: FILE: hw/ppc/ppc440_uc.c:564: +size = 8 * MiB * sh; total: 1 errors, 0 warnings, 433 lines checked Signed-off-by: Philippe Ma

[Qemu-devel] [PATCH v2] target-i386: Add NPT support

2018-06-29 Thread Jan Kiszka
From: Jan Kiszka This implements NPT suport for SVM by hooking into x86_cpu_handle_mmu_fault where it reads the stage-1 page table. Whether we need to perform this 2nd stage translation, and how, is decided during vmrun and stored in hflags2, along with nested_cr3 and nested_pg_mode. As get_hphy

Re: [Qemu-devel] [PATCH v2 4/4] target-i386: Add NPT support

2018-06-29 Thread Jan Kiszka
On 2018-06-30 08:05, Paolo Bonzini wrote: > On 30/06/2018 07:25, Jan Kiszka wrote: >> On 2018-06-27 14:14, Paolo Bonzini wrote: >>> On 03/04/2018 17:36, Jan Kiszka wrote: +static hwaddr get_hphys(CPUState *cs, hwaddr gphys, MMUAccessType access_type, +

Re: [Qemu-devel] [PATCH v2 4/4] target-i386: Add NPT support

2018-06-29 Thread Paolo Bonzini
On 30/06/2018 07:25, Jan Kiszka wrote: > On 2018-06-27 14:14, Paolo Bonzini wrote: >> On 03/04/2018 17:36, Jan Kiszka wrote: >>> >>> +static hwaddr get_hphys(CPUState *cs, hwaddr gphys, MMUAccessType >>> access_type, >>> +int *prot) >>> +{ >>> +CPUX86State *env = &X86

Re: [Qemu-devel] [PATCH v2 4/4] target-i386: Add NPT support

2018-06-29 Thread Jan Kiszka
On 2018-06-27 14:14, Paolo Bonzini wrote: > On 03/04/2018 17:36, Jan Kiszka wrote: >> >> +static hwaddr get_hphys(CPUState *cs, hwaddr gphys, MMUAccessType >> access_type, >> +int *prot) >> +{ >> +CPUX86State *env = &X86_CPU(cs)->env; >> +uint64_t rsvd_mask = PG_H

[Qemu-devel] [PATCH v2] fix fdiv instruction

2018-06-29 Thread John Arbuckle
When the fdiv instruction divides a finite number by zero, the result actually depends on the FPSCR[ZE] bit. If this bit is set, the return value is the value originally in the destination register. If it is not set the result should be either positive or negative infinity. The sign of this result

Re: [Qemu-devel] [PATCH V9 11/20] qapi/migration.json: Rename COLO unknown mode to none mode.

2018-06-29 Thread Zhang Chen
On Fri, Jun 29, 2018 at 5:14 PM, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: > > On 06/27/2018 03:41 PM, Zhang Chen wrote: > > > From: Zhang Chen > > > > > > Suggested by Markus Armbruster rename COLO unknown mode to none mode. > > > > > > Signed-off-by: Zhang Chen >

[Qemu-devel] about live memory snapshot

2018-06-29 Thread Gonglei (Arei)
Hi Peter, As we discussed in LC3 China, the current scheme of "migration to file" can't fit on production environment, which will cause the snapshot file bigger and bigger when the guest is under enough memory pressure. We can't assume what size the snapshot file is. Pls have a look if we have

Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-06-29 Thread Joe Perches
On Fri, 2018-06-29 at 15:41 -0500, Eric Blake wrote: > On 06/25/2018 07:41 AM, Philippe Mathieu-Daudé wrote: > > Do not match the IEC binary prefix as camelcase typedefs. > > > > This fixes: > > > > ERROR: "foo * bar" should be "foo *bar" > > #310: FILE: hw/ppc/ppc440_uc.c:564: > >

[Qemu-devel] [PATCH 0/2] Fix qemu-system-aarch64 crash

2018-06-29 Thread Richard Henderson
The sequence of events was (1) Kernel executed a disabled sve insn, (2) Undefined Instruction trap went to EL3, (3) Lookup of the exception handler saw el3 and returned asidx 1, (4) Which hadn't been set up. So there's definitely a bug with SVE exception routing. That said... With just th

[Qemu-devel] [PATCH 1/2] target/arm: Always return ARMASIdx_NS when num_ases == 1

2018-06-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index e310ffc29d..c26cc43ea8 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -2915,7 +2915,7 @@ enum { /* Return the address space

[Qemu-devel] [PATCH 2/2] cpu: Assert asidx_from_attrs return value in range

2018-06-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/qom/cpu.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index cce2fd6acc..bd796579ee 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -620,11 +620,13 @@ static inline hwaddr cpu

[Qemu-devel] [PATCH v6 4/5] s390x/vfio: ap: Introduce VFIO AP device

2018-06-29 Thread Tony Krowiak
Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated matrix device is created by the VFIO AP device driver by writing a UUID to a sysfs attribute f

[Qemu-devel] [PATCH v6 3/5] s390x/ap: base Adjunct Processor (AP) object model

2018-06-29 Thread Tony Krowiak
From: Tony Krowiak Introduces the base object model for virtualizing AP devices. Signed-off-by: Tony Krowiak --- MAINTAINERS | 12 +++ hw/s390x/Makefile.objs |2 + hw/s390x/ap-bridge.c | 76 ++ hw/s390x/ap-devic

[Qemu-devel] [PATCH v6 5/5] s390: doc: detailed specifications for AP virtualization

2018-06-29 Thread Tony Krowiak
This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak Signed-off-by: Tony Krowiak --- MAINTAINERS

[Qemu-devel] [PATCH v6 1/5] linux-headers: linux header updates for AP support

2018-06-29 Thread Tony Krowiak
Updates the linux header files in preparation for introduction of the VFIO AP device: * Added a feature ID to indicate AP facilities are installed * Added a device attribute to the KVM_S390_VM_CRYPTO group to indicate whether AP instructions are to be interpreted * Added VFIO device informatio

[Qemu-devel] [PATCH v6 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-06-29 Thread Tony Krowiak
From: Tony Krowiak This patch series is the QEMU counterpart to the KVM/kernel support for guest dedicated crypto adapters. The KVM/kernel model is built on the VFIO mediated device framework and provides the infrastructure for granting exclusive guest access to crypto devices installed on the

[Qemu-devel] [PATCH v6 2/5] s390x/cpumodel: Set up CPU model for AP device support

2018-06-29 Thread Tony Krowiak
A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP facilities are installed. This feature will be enabled by the kernel only if the AP facilitie

[Qemu-devel] [PATCH v3 3/3] Add "Group Identifier" support to Red Hat PCI Express bridge.

2018-06-29 Thread Venu Busireddy
Add a new bridge device "pcie-downstream" with a Vendor ID of PCI_VENDOR_ID_REDHAT and a Device ID of PCI_DEVICE_ID_REDHAT_DOWNPORT_FAILOVER. Also, add the "Vendor-Specific" capability to the bridge to contain the "Group Identifier" that will be used to pair a virtio device with the passthrough dev

[Qemu-devel] [PATCH v3 2/3] Add "Group Identifier" support to Red Hat PCI bridge.

2018-06-29 Thread Venu Busireddy
Add the "Vendor-Specific" capability to the Red Hat PCI bridge device "pci-bridge", to contain the "Group Identifier" that will be used to pair a virtio device with the passthrough device attached to that bridge. Also, change the Device ID of the bridge to PCI_DEVICE_ID_REDHAT_BRIDGE_FAILOVER to av

[Qemu-devel] [PATCH v3 virtio 1/1] Add "Group Identifier" to virtio PCI capabilities.

2018-06-29 Thread Venu Busireddy
Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the virtio PCI capabilities to allow for the grouping of devices. Signed-off-by: Venu Busireddy --- content.tex | 30 ++ 1 file changed, 30 insertions(+) diff --git a/content.tex b/content.tex index be1

[Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-06-29 Thread Venu Busireddy
The patch set "Enable virtio_net to act as a standby for a passthru device" [1] deals with live migration of guests that use passthrough devices. However, that scheme uses the MAC address for pairing the virtio device and the passthrough device. The thread "netvsc: refactor notifier/event handling

[Qemu-devel] [PATCH v3 1/3] Add "Group Identifier" support to virtio devices.

2018-06-29 Thread Venu Busireddy
Use the virtio PCI capability "VIRTIO_PCI_CAP_GROUP_ID_CFG" to store the "Group Identifier" specified via the command line option "failover-group-id" for the virtio device. The capability will be present in the virtio device's configuration space iff the "failover-group-id" option is specified. Gr

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 0/4] Use of unique identifier for pairing virtio and passthrough devices...

2018-06-29 Thread Michael S. Tsirkin
On Fri, Jun 29, 2018 at 01:55:07PM -0500, Venu Busireddy wrote: > On 2018-06-27 22:27:33 -0500, Venu Busireddy wrote: > > On 2018-06-28 04:54:16 +0300, Michael S. Tsirkin wrote: > > > On Wed, Jun 27, 2018 at 05:34:17PM -0500, Venu Busireddy wrote: > > > > On 2018-06-27 23:12:12 +0300, Michael S. Ts

[Qemu-devel] [PATCH] accel/tcg: Avoid caching overwritten tlb entries

2018-06-29 Thread Richard Henderson
When installing a TLB entry, remove any cached version of the same page in the VTLB. If the existing TLB entry matches, do not copy into the VTLB, but overwrite it. Signed-off-by: Richard Henderson --- This may fix some problems with Q800 that Laurent reported. On IRC, Peter suggested that reg

Re: [Qemu-devel] [PATCH] migration: Appease coverity, skip empty block trees

2018-06-29 Thread John Snow
On 06/29/2018 01:07 PM, Stefan Hajnoczi wrote: > On Fri, Jun 22, 2018 at 04:11:22PM -0400, John Snow wrote: >> If a tree consists exclusively of implicit filter nodes, we might crash >> QEMU. This configuration should not exist in practice, but if it did, >> skipping it would be fine. >> >> For

[Qemu-devel] [Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze

2018-06-29 Thread Andreas Hasenack
** Description changed: [Impact] - * An explanation of the effects of the bug on users and +  * An explanation of the effects of the bug on users and - * justification for backporting the fix to the stable release. +  * justification for backporting the fix to the stable release. - *

Re: [Qemu-devel] RISC-V platform

2018-06-29 Thread Alistair Francis
On Fri, Jun 29, 2018 at 2:05 PM, G 3 wrote: > Hi, I noticed your RISC-V patches on the mailing list and had a question > that I think you may be able to answer. Has anyone defined a RISC-V platform > yet? What I mean is defining what devices would be found on a RISC-V > motherboard. I do hope to s

[Qemu-devel] RISC-V platform

2018-06-29 Thread G 3
Hi, I noticed your RISC-V patches on the mailing list and had a question that I think you may be able to answer. Has anyone defined a RISC-V platform yet? What I mean is defining what devices would be found on a RISC-V motherboard. I do hope to see RISC-V based desktop systems one day. But

[Qemu-devel] [PATCH v2 17/21] docker: drop QEMU build-dep from bootstrap

2018-06-29 Thread Alex Bennée
This is best done with any child images that actually need it. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-bootstrap.docker | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-bootstrap.docker b/tests/docker/dockerfiles/debian-bootstrap.docker

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Image fleecing test case 222

2018-06-29 Thread John Snow
On 06/29/2018 01:58 PM, Eric Blake wrote: > On 06/29/2018 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: >> From: Fam Zheng >> >> This tests the workflow of creating a lightweight point-in-time snapshot >> with blockdev-backup command, and exporting it with built-in NBD server. >> >> It's tested

Re: [Qemu-devel] [PATCH 1/2] qapi: Add comments to aid debugging generated introspection

2018-06-29 Thread Eric Blake
On 06/29/2018 02:55 PM, Eric Blake wrote: The generated qapi-introspect.c changes only with the addition of comments, such as: | @@ -14927,6 +15410,7 @@ | {} | })), | QLIT_QDICT(((QLitDictEntry[]) { | +/* QCryptoBlockInfoLUKSSlot */ | { "members", QLIT_QLIST(

[Qemu-devel] [PATCH v2 15/21] docker: Do not run tests in 'intermediate' images

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé We can still build the DOCKER_INTERMEDIATE_IMAGES images, but they won't appear in 'make test*@$IMAGE'. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) dif

[Qemu-devel] [PATCH v2 13/21] docker: ubuntu: Use SDL2

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Do not test the deprecated API versions (see cabd35840749d). Debian MXE MinGW cross images are already using SDL2. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/ubuntu.docker | 4 ++-- 1 file changed, 2 insertions(+)

[Qemu-devel] [PATCH v2 19/21] docker: add special rule for deboostrapped images

2018-06-29 Thread Alex Bennée
We might as well have a custom rule for this. For one things the dependencies are different. We drop the test and EXECUTABLE lines from the general rule as they are no longer needed there. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 26 +- 1 file change

[Qemu-devel] [PATCH v2 16/21] docker: add env parser to docker.py build step

2018-06-29 Thread Alex Bennée
We need to pass environment variables down to the debbootstrap.pre script to be able to specify build parameters. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 8 1 file changed, 8 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index b279836154..38

[Qemu-devel] [PATCH v2 18/21] docker: add special handling for FROM:debian-%-user targets

2018-06-29 Thread Alex Bennée
These will have been build with debootstrap so we need to check against the debian-bootstrap dockerfile. This does mean sticking to debian-FOO-user as the naming conventions for boot-strapped images. The actual cross image is built on top. Signed-off-by: Alex Bennée --- tests/docker/docker.py |

[Qemu-devel] [PATCH v2 21/21] .shippable.yml: add linux-user cross-build for ppc-softmmu

2018-06-29 Thread Alex Bennée
Use our new ability to use linux-user powered docker images to build ppc-softmmu. Signed-off-by: Alex Bennée --- .shippable.yml | 8 1 file changed, 8 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index f74a3de3ff..12f9d3b221 100644 --- a/.shippable.yml +++ b/.shippable.ym

[Qemu-devel] [PATCH v2 09/21] linux-user: introduce preexit_cleanup

2018-06-29 Thread Alex Bennée
To avoid repeating ourselves move our preexit clean-up code into a helper function. I figured the continuing effort to split of the syscalls made it worthwhile creating a new file for it now. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Reviewed

[Qemu-devel] [PATCH v2 20/21] docker: add linux-user powered cross builder for QEMU

2018-06-29 Thread Alex Bennée
We can't use cross compilers in the current Debian stable and Debian sid is sketchy as hell. So for powerpc fall back to dog-fooding our own linux-user to do the build. As we can only build the base image with a suitably configured source tree we fall back to checking for it's existence when we ca

[Qemu-devel] [PATCH v2 10/21] linux-user: add gcov support to preexit_cleanup

2018-06-29 Thread Alex Bennée
As we don't always take the normal exit path when running a guest we can skip the normal exit destructors where gcov normally dumps it's info. The GCC manual suggests long running programs use __gcov_dump() to flush out the coverage state periodically so we use that here. Signed-off-by: Alex Benné

[Qemu-devel] [PATCH v2 12/21] docker: ubuntu: Update the package list before installing new ones

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since docker caches the different layers, updating the package list does not invalidate the previous "apt-get update" layer, and it is likely "apt-get install" hits an outdated repository. See https://docs.docker.com/develop/develop-images/dockerfile_best-practices/

[Qemu-devel] [PATCH v2 14/21] docker: Clean the MXE base image

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Using the duplicated same package is confusing. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian8-mxe.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/d

[Qemu-devel] [PATCH v2 06/21] travis: add gcovr summary for GCOV build

2018-06-29 Thread Alex Bennée
This gives a more useful summary, sorted by descending % coverage, after the tests have run. The final numbers will give an idea if our coverage is getting better or worse. To keep the width sane we need to post process the file that the old gcovr tool generates. This is done with a mix of sed, aw

[Qemu-devel] [PATCH v2 08/21] build-system: add coverage-report target

2018-06-29 Thread Alex Bennée
This will build a coverage report under the current directory in reports/coverage. At the users option a report can be generated by directly invoking something like: make foo/bar/coverage-report.html Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Da

[Qemu-devel] [PATCH v2 11/21] docker: filter out linux-user builds for mingw

2018-06-29 Thread Alex Bennée
The recent change from TARGET_DIRS to TARGET_LIST (208ecb3e1) had the effect of defaulting all docker builds to the current configured set of targets. This is actually reasonable behaviour but does run into problems if you have linux-user builds configured and you want to test the windows cross bui

[Qemu-devel] [PATCH v2 05/21] docker: add gcovr to travis image

2018-06-29 Thread Alex Bennée
Useful for debugging if nothing else as the gcovr on the Travis images are a little old. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- tests/docker/dockerfiles/travis.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH v2 03/21] build-system: remove per-test GCOV reporting

2018-06-29 Thread Alex Bennée
I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex Bennée

[Qemu-devel] [PATCH v2 07/21] build-system: add clean-coverage target

2018-06-29 Thread Alex Bennée
This can be used to remove any stale coverage data before any particular test run. This is useful for analysing individual tests. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- v2 - s/to any/to delete any/ --- Makefile | 11 +++ docs/devel/testing.rst |

[Qemu-devel] [PATCH v2 02/21] travis: test out-of-tree builds

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Force one config to build 'out-of-tree' (object files and executables are created in a tree outside the project source code). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- .travis.yml | 8 +++- 1 file cha

[Qemu-devel] [PATCH v2 04/21] .gitignore: add .gcov files

2018-06-29 Thread Alex Bennée
These are temporary files generated on gcov runs and shouldn't be included in the source tree. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.g

  1   2   3   4   5   6   >