On Thu, Jun 07, 2018 at 01:29:22PM +0800, Wei Wang wrote:
> On 06/07/2018 11:17 AM, Peter Xu wrote:
> > On Wed, Jun 06, 2018 at 06:11:50PM +0800, Wei Wang wrote:
> >
> > I got similar comments from Michael, and it will be
> > while (1) {
> > lock;
> > func();
> > unlock();
> > }
> >
> > All the u
Thomas Huth writes:
> On 05.06.2018 00:40, Eric Blake wrote:
>> On 06/04/2018 05:34 AM, Thomas Huth wrote:
>>> On 04.06.2018 09:18, Markus Armbruster wrote:
Roman Kagan writes:
> Add helper functions to query the block drivers actually supported by
> QEMU using "-drive format=?
On Thu, Jun 07, 2018 at 01:24:29PM +0800, Wei Wang wrote:
> On 06/06/2018 07:02 PM, Peter Xu wrote:
> > On Wed, Jun 06, 2018 at 06:04:23PM +0800, Wei Wang wrote:
> > > On 06/06/2018 01:42 PM, Peter Xu wrote:
> > > > IMHO migration states do not suite here. IMHO bitmap syncing is too
> > > > freque
From: Max Reitz
There are numerous QDict functions that have been introduced for and are
used only by the block layer. Move their declarations into an own
header file to reflect that.
While qdict_extract_subqdict() is in fact used outside of the block
layer (in util/qemu-config.c), it is still
Pure code motion, except for two brace placements and a comment
tweaked to appease checkpatch.
Signed-off-by: Markus Armbruster
---
MAINTAINERS | 2 +
qobject/Makefile.objs | 1 +
qobject/block-qdict.c | 640 +
qobject/qdict.c
Legacy -drive supports "password-secret" parameter that isn't
available with -blockdev / blockdev-add. That's because we backed out
our first try to provide it there due to interface design doubts, in
commit 577d8c9a811, v2.9.0.
This is the second try. It brings back the parameter, except it's
n
The following pattern occurs in the .bdrv_co_create_opts() methods of
parallels, qcow, qcow2, qed, vhdx and vpc:
qobj = qdict_crumple_for_keyval_qiv(qdict, errp);
qobject_unref(qdict);
qdict = qobject_to(QDict, qobj);
if (qdict == NULL) {
ret = -EINVAL;
goto done;
-blockdev and blockdev-add silently ignore empty objects and arrays in
their argument. That's because qmp_blockdev_add() converts the
argument to a flat QDict, and qdict_flatten() eats empty QDict and
QList members. For instance, we ignore an empty BlockdevOptions
member @cache. No real harm, as
Parameter auth-client-required lets you configure authentication
methods. We tried to provide that in v2.9.0, but backed out due to
interface design doubts (commit 46fcc16).
This commit is similar to what we backed out, but simpler: we use a
list of enumeration values instead of a list of obj
Configuration flows through the block subsystem in a rather peculiar
way. Configuration made with -drive enters it as QemuOpts.
Configuration made with -blockdev / blockdev-add enters it as QAPI
type BlockdevOptions. The block subsystem uses QDict, QemuOpts and
QAPI types internally. The precise
Signed-off-by: Markus Armbruster
---
block/nbd.c | 7 ++-
block/nfs.c | 7 ++-
block/parallels.c | 7 ++-
block/qcow.c | 7 ++-
block/qcow2.c | 7 ++-
block/qed.c | 7 ++-
block/rbd.c | 7 ++-
block/sh
When you mix scalar and non-scalar keys, whether you get an "already
set as scalar" or an "already set as dict" error depends on qdict
iteration order. Neither message makes much sense. Replace by
""Cannot mix scalar and non-scalar keys". This is similar to the
message we get for mixing list and
Parameter "filename" is deprecated since commit 91589d9e5ca, v2.10.0.
Time to get rid of it.
Signed-off-by: Markus Armbruster
---
block/rbd.c | 16
1 file changed, 16 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index a16431e267..40c6e4185f 100644
--- a/block/rbd.c
+++ b
Remaining uses of qobject_input_visitor_new_keyval() in the block
subsystem:
* block_crypto_create_opts_init()
Currently doesn't visit any non-string scalars, thus safe. It's
called from
- block_crypto_open_luks()
Creates the QDict with qemu_opts_to_qdict_filtered(), which
creates o
Signed-off-by: Markus Armbruster
---
tests/check-block-qdict.c | 57 ---
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/tests/check-block-qdict.c b/tests/check-block-qdict.c
index 5b9f4d506e..29f58a2d3d 100644
--- a/tests/check-block-qdict.c
++
Signed-off-by: Markus Armbruster
---
tests/check-block-qdict.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/tests/check-block-qdict.c b/tests/check-block-qdict.c
index 29f58a2d3d..2da16f01a6 100644
--- a/tests/check-block-qdict.c
+++ b/tests/check-block-qdict
qdict_flatten_qdict() skips copying scalars from @qdict to @target
when the two are the same. Fair enough, but it uses a non-obvious
test for "same". Replace it by the obvious one. While there, improve
comments.
Signed-off-by: Markus Armbruster
---
qobject/block-qdict.c | 14 +-
1
The previous commit fixed -blockdev breakage due to misuse of the
qobject input visitor's keyval flavor in bdrv_file_open(). The commit
message explain why using the plain flavor would be just as wrong; it
would break -drive. Turns out we break it in three places:
nbd_open(), sd_open() and ssh_fi
There's no need to restart the loop. We don't elsewhere, e.g. in
qdict_extract_subqdict(), qdict_join() and qemu_opts_absorb_qdict().
Simplify accordingly.
Signed-off-by: Markus Armbruster
---
qobject/block-qdict.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff
Signed-off-by: Markus Armbruster
---
qobject/block-qdict.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/qobject/block-qdict.c b/qobject/block-qdict.c
index 35e9052816..f24bea30e1 100644
--- a/qobject/block-qdict.c
+++ b/qobject/block-qdict.c
@@
Parameter "filename" is deprecated since commit 5c3ad1a6a8f, v2.10.0.
Time to get rid of it.
Signed-off-by: Markus Armbruster
---
block/iscsi.c | 23 ++-
1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index c2fbd8a8aa..7e3ea72bd2
This series is RFC because:
* It clashes with parts of Max's "[PATCH 00/13] block: Try to create
well typed json:{} filenames". I missed that one until too late,
sorry.
- I stole "[PATCH 06/13] block: Add block-specific QDict header",
and tacked on fixups I'd like to have.
- My qobj
Signed-off-by: Markus Armbruster
---
include/block/qdict.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/block/qdict.h b/include/block/qdict.h
index 825e096a72..71c037afba 100644
--- a/include/block/qdict.h
+++ b/include/block/qdict.h
@@ -1,7 +1,7 @@
/*
* Spec
> -Original Message-
> From: luc.mic...@greensocs.com [mailto:luc.mic...@greensocs.com]
> Sent: Wednesday, June 6, 2018 3:01 PM
> To: qemu-devel@nongnu.org
> Cc: Luc MICHEL ; qemu-...@nongnu.org; Peter
> Maydell ; Sai Pavan Boddu ;
> Edgar Iglesias ; mark.bur...@greensocs.com; Jan Kiszka
On 06.06.2018 19:32, Daniel P. Berrangé wrote:
> Per supported platforms doc, the various min glib on relevant distros is:
>
> RHEL-7: 2.50.3
> Debian (Stretch): 2.50.3
> Debian (Jessie): 2.42.1
> OpenBSD (Ports): 2.54.3
> FreeBSD (Ports): 2.50.3
> OpenSUSE Leap 15: 2.54.3
> Ubuntu (
hi everyone:
my order:
virt-install --virt-type kvm -n centos -r 1024 --disk
centos.img,format=qcow2,size=10 --cdrom /home/CentOS-7-aarch64-Everything.iso
the failed log:
qemu-kvm: -device
pcie-root-port,port=0x8,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x1:MSI-X
is not supported b
On 06/07/2018 11:17 AM, Peter Xu wrote:
On Wed, Jun 06, 2018 at 06:11:50PM +0800, Wei Wang wrote:
I got similar comments from Michael, and it will be
while (1) {
lock;
func();
unlock();
}
All the unlock inside the body will be gone.
Ok I think I have more question on this part...
Actually AFAI
On 06/06/2018 07:02 PM, Peter Xu wrote:
On Wed, Jun 06, 2018 at 06:04:23PM +0800, Wei Wang wrote:
On 06/06/2018 01:42 PM, Peter Xu wrote:
IMHO migration states do not suite here. IMHO bitmap syncing is too
frequently an operation, especially at the end of a precopy migration.
If you really wan
On Thu, Jun 7, 2018 at 6:56 AM, Thomas Huth wrote:
> On 06.06.2018 20:56, Markus Armbruster wrote:
>> BALATON Zoltan writes:
>>
>>> Hello,
>>>
>>> Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output
>>> is printed in stair steps when using -trace and -serial stdio
>>> together. E
On 06.06.2018 20:56, Markus Armbruster wrote:
> BALATON Zoltan writes:
>
>> Hello,
>>
>> Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output
>> is printed in stair steps when using -trace and -serial stdio
>> together. E.g.
>> $ qemu-system-i386 -trace 'pci*' -serial stdio
>>
>>
On Wed, Jun 06, 2018 at 07:31:53PM +0100, Peter Maydell wrote:
> On 6 June 2018 at 18:32, Daniel P. Berrangé wrote:
> > Code must only ever include glib.h indirectly via the glib-compat.h
> > header file, because we will need some macros set before glib.h is
> > pulled in. Adding extra includes of
On Wed, Jun 06, 2018 at 02:24:46PM -0400, John Snow wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Expose the ability to turn bitmaps "on" or "off". This is experimental
> and principally for the sake of the Libvirt Checkpoints API, and it may
> or may not be committed for 3.0.
>
> Signed-off-b
On Wed, Jun 06, 2018 at 02:24:48PM -0400, John Snow wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> block/dirty-bitmap.c | 18 ++
> blockdev.c | 30
On Wed, Jun 06, 2018 at 02:24:47PM -0400, John Snow wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> [Added x- prefix. --js]
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> blockdev.c| 81
> +
On Wed, Jun 06, 2018 at 06:11:50PM +0800, Wei Wang wrote:
> On 06/06/2018 02:43 PM, Peter Xu wrote:
> > On Tue, Apr 24, 2018 at 02:13:47PM +0800, Wei Wang wrote:
> >
> > [...]
> >
> > +if (elem->out_num) {
> > +size = iov_to_buf(elem->out_sg, elem->out_num, 0, &id,
> > sizeof
On Wed, Jun 06, 2018 at 09:37:00PM +0200, Max Reitz wrote:
> This is a useful function for the whole block layer, so make it public.
> At the same time, users outside of block.c probably do not need to make
> use of the reopen functionality, so rename the current function to
> bdrv_is_writable_afte
On Wed, Jun 06, 2018 at 09:37:01PM +0200, Max Reitz wrote:
> When signaling a corruption on a read-only image, qcow2 already makes
> fatal events non-fatal (i.e., they will not result in the image being
> closed, and the image header's corrupt flag will not be set). This is
> necessary because we
On 06/06/2018 11:16 PM, David Gibson wrote:
> On Wed, Jun 06, 2018 at 12:21:21PM -0300, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé
>
> I'm not really sure what series this was part of, but I've applied it
> to ppc-for-3.0 anyway.
I did an effort to split the series, t
On Wed, Jun 06, 2018 at 12:21:21PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
I'm not really sure what series this was part of, but I've applied it
to ppc-for-3.0 anyway.
Acked-by: David Gibson
> ---
> hw/ppc/pnv_core.c | 4 ++--
> 1 file changed, 2 insertion
On Wed, Jun 06, 2018 at 11:59:18AM -0300, Philippe Mathieu-Daudé wrote:
> Nothing very exciting here.
> I sometimes miss to notice some trace events, running with -d unimp,trace...
> then using 'grep ^...'. This is only due to a missing '\n' :)
Applied to ppc-for-3.0, thanks.
>
> Philippe Mathie
Hi,
This is Wonsang Ryu.
I'm developing the open embedded OS using QEMU with virglrenderer.
Our OS is very light, so it doesn't support multi resolution.
Our OS supports only 1920x1080.
So, we want to resize to 1280x720 the QEMU window for developers.
If QEMU window size is 1920x1080, it is clear.
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 20180606181352.61144-1-...@google.com
Subject: [Qemu-devel] [PATCH] Improve file-backed RAM
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180606181352.61144-1-...@google.com
Subject: [Qemu-devel] [PATCH] Improve file-backed RA
On Wed, Jun 6, 2018 at 4:20 PM, Elliott, Robert (Persistent Memory)
wrote:
>
>> > Okay, we can move to the symbolic names. Do you want them to be that
>> long, or
>> > would:
>> >
>> > nvdimm-cap-cpu
>> > nvdimm-cap-mem-ctrl
>> > nvdimm-cap-mirroring
>>
>> Wait, why is mirroring part of this?
>
>
> > Okay, we can move to the symbolic names. Do you want them to be that
> long, or
> > would:
> >
> > nvdimm-cap-cpu
> > nvdimm-cap-mem-ctrl
> > nvdimm-cap-mirroring
>
> Wait, why is mirroring part of this?
This data structure is intended to report any kind of platform capability, not
just p
On 06/06/2018 05:23 PM, Cleber Rosa wrote:
> On 06/06/2018 04:11 PM, Eduardo Habkost wrote:
>> On Wed, Jun 06, 2018 at 04:36:16PM -0300, Philippe Mathieu-Daudé wrote:
>>> On 06/06/2018 04:24 PM, Eduardo Habkost wrote:
On Tue, Jun 05, 2018 at 11:45:03AM -0300, Philippe Mathieu-Daudé wrote:
On 06/06/2018 05:05 PM, Eduardo Habkost wrote:
> On Wed, Jun 06, 2018 at 04:27:31PM -0300, Philippe Mathieu-Daudé wrote:
>> The readline() call returns partial data.
>
> How can this be reproduced? Despite not being forbidden by the
> QMP specification, QEMU normally doesn't break QMP replies in
One is from my manual completion series,
the other is from the recent refactor.
John Snow (2):
jobs: fix stale wording
jobs: fix verb references in docs
qapi/job.json | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
--
2.14.3
During the design for manual completion, we decided not to use the
"manual" property as a shorthand for both auto-dismiss and auto-finalize.
Fix the wording.
Signed-off-by: John Snow
---
qapi/job.json | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/qapi/job.json
These point to the job versions now, not the blockjob versions which
don't really exist anymore.
Except set-speed, which does. It sticks out like a sore thumb. This
patch doesn't fix that, but it doesn't make it any worse, either.
Signed-off-by: John Snow
---
qapi/job.json | 12 ++--
1
On Wed, Jun 06, 2018 at 10:36:45AM -0400, Babu Moger wrote:
> Enable TOPOEXT feature on EPYC CPU. This is required to support
> hyperthreading on VM guests. Also extend xlevel to 0x801E.
>
> Disable TOPOEXT feature for legacy machines.
>
> Signed-off-by: Babu Moger
Now, I just noticed we ha
I see you point. Just close this issue.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1775366
Title:
[Feature request] qemu-ga - Allow unexpected parameter
Status in QEMU:
New
Bug description:
On Wed, Jun 06, 2018 at 10:36:44AM -0400, Babu Moger wrote:
> topoext feature cannot be supported in certain cases
> with large number of cores or threads. Add the check.
>
> Signed-off-by: Babu Moger
> ---
> target/i386/cpu.c | 27 +++
> 1 file changed, 27 insertions(+)
On 6 June 2018 at 21:23, Paul Burton wrote:
> Hi Peter,
>
> On Mon, Jun 04, 2018 at 11:29:47AM +0100, Peter Maydell wrote:
>> Hi; I was looking at the code for this PCI controller as
>> part of identifying RAM memory regions that don't migrate
>> their contents, and this looks kind of odd. Can you
On Wed, Jun 06, 2018 at 10:36:43AM -0400, Babu Moger wrote:
[...]
> +/*
> + * CPUID_Fn801E_EBX
> + * 31:16 Reserved
> + * 15:8 Threads per core (The number of threads per core is
> + * Threads per core + 1)
> + * 7:0 Core id (see bit decoding below)
> + *
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180606205629.66987-1-...@google.com
Subject: [Qemu-devel] [PATCH] Improve file-backed RA
Hi,
> our actual qcow2v3 improvements, so no one ended up switching to that. So,
> to some extent, various high-level consumers still have the notion that
> 'raw' files are better/safer/faster than 'qcow2' files because of an
> anecdote from years ago, even if we have since fixed the speed parit
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180606181352.61144-1-...@google.com
Subject: [Qemu-devel] [PATCH] Improve file-backed RAM
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BA
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180606205629.66987-1-...@google.com
Subject: [Qemu-devel] [PATCH] Improve file-backed RAM
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BA
1. Add support for all platforms
2. Add option to map in shared mode, allowing the guest to write
through to the backing file
Taken together, this allows one to write RAM snapshots as the guest is
running. Saving RAM snapshots is then equivalent to exiting the qemu
process or unmapping the file. T
1. Add support for all platforms
2. Add option to map in shared mode, allowing the guest to write
through to the backing file
Taken together, this allows one to write RAM snapshots as the guest is
running. Saving RAM snapshots is then equivalent to exiting the qemu
process or unmapping the file. T
On 06/06/2018 09:57 AM, Eric Blake wrote:
On 06/06/2018 09:43 AM, Michael S. Tsirkin wrote:
On Wed, Jun 06, 2018 at 01:02:53PM +0200, Max Reitz wrote:
Yeah, but why make qcow2 that format? That's what I completely fail to
understand.
Because why not? It's cheap to add it there and is much ea
On 06/06/2018 04:11 PM, Eduardo Habkost wrote:
> On Wed, Jun 06, 2018 at 04:36:16PM -0300, Philippe Mathieu-Daudé wrote:
>> On 06/06/2018 04:24 PM, Eduardo Habkost wrote:
>>> On Tue, Jun 05, 2018 at 11:45:03AM -0300, Philippe Mathieu-Daudé wrote:
>>> [... something about config files ...]
>
Hi Peter,
On Mon, Jun 04, 2018 at 11:29:47AM +0100, Peter Maydell wrote:
> On 22 February 2017 at 00:21, Yongbok Kim wrote:
> > From: Paul Burton
> >
> > Add support for emulating the Xilinx AXI Root Port Bridge for PCI
> > Express as described by Xilinx' PG055 document. This is a PCIe
> > contr
On 06/06/2018 03:36 PM, Max Reitz wrote:
> The non-public logs in
> https://bugzilla.redhat.com/show_bug.cgi?id=1583346 (sorry...) reveal
> this problem:
>
> $ (Create a qcow2 file "foo.qcow2" with a corrupted first L1 entry)
> $ echo 'qemu-io none0 "read 0 512"' \
> | x86_64-softmmu/qemu-s
On Wed, Jun 06, 2018 at 04:36:16PM -0300, Philippe Mathieu-Daudé wrote:
> On 06/06/2018 04:24 PM, Eduardo Habkost wrote:
> > On Tue, Jun 05, 2018 at 11:45:03AM -0300, Philippe Mathieu-Daudé wrote:
> > [... something about config files ...]
> >>> And after that, the following would run all "console"
On 2018-06-06 14:35, Thomas Huth wrote:
> It has been marked as deprecated since QEMU v2.0 already, so it
> is time now to finally remove it.
>
> Signed-off-by: Thomas Huth
> ---
> qemu-doc.texi | 7 ---
> qemu-img-cmds.hx | 4 ++--
> qemu-img.c | 7 +--
> qemu
On Wed, Jun 06, 2018 at 04:27:31PM -0300, Philippe Mathieu-Daudé wrote:
> The readline() call returns partial data.
How can this be reproduced? Despite not being forbidden by the
QMP specification, QEMU normally doesn't break QMP replies in
multiple lines, and readline() is not supposed to return
Pass the TPM interface model, such as 'tpm-crb', through to the functions
that create the command line for QEMU.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
tests/tpm-crb-swtpm-test.c | 4 ++--
tests/tpm-tests.c | 13 -
tests/tpm-tests.h | 6 +
On 06/06/2018 03:09 PM, John Snow wrote:
> Real hardware doesn't have an unlimited stack, so the unlimited
> recursion in the ATAPI code smells a bit. In fact, the call to
> ide_transfer_start easily becomes a tail call with a small change
> to the code (patch 5); however, we also need to turn
Add a test case for testing swtpm migration with the TPM TIS
interface.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
tests/Makefile.include | 3 +++
tests/tpm-tis-swtpm-test.c | 66 ++
tests/tpm-util.c | 48 ++
This series of patches refactors existing TPM test code and adds another
TPM TIS test case testing TPM migration.
Stefan
The following changes since commit c1c2a435905ae76b159c573b0c0d6f095b45ebc6:
Merge remote-tracking branch
'remotes/stsquad/tags/pull-docker-updates-050618-1' into stagi
Move code we can reuse from tpm-crb-swtpm-test.c into tpm-util.c
and prefix functions with 'tpm_util_'.
Remove some unnecessary #include's.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
tests/tpm-crb-swtpm-test.c | 100 +++--
tests/tpm-
Move common TPM test functions from tpm-crb-swtpm-test.c to tpm-tests.c
so that for example test cases with the TPM TIS interface can use the
same code. Prefix all funcions with 'tpm_test_'.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
tests/Makefile.include | 2 +-
tes
This sounds an awful lot like your hosting provider expects you to be
using a specialized version of qemu-ga which you are not using.
It is my opinion that it's dangerous for a client to accept partial
commands and try to execute them anyway, as those ignored parameters
drastically change the sema
On 06/06/2018 04:09 PM, John Snow wrote:
> From: Paolo Bonzini
>
> The code can simply be moved to the sole caller that has notify == true.
>
> Signed-off-by: Paolo Bonzini
> Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/ide/core.c | 11 ---
> 1 file chang
On 06/06/2018 04:09 PM, John Snow wrote:
> It's not always 512, and it does wind up mattering for PIO tranfers,
> because this means DRQ blocks are four times as big for ATAPI.
> Replace an instance of 2048 with the correct define, too.
>
> This patch by itself winds changing no behavior. fis->cou
On 06/06/2018 11:21 AM, Philippe Mathieu-Daudé wrote:
> Nothing very exciting here.
> I sometimes miss to notice some trace events, running with -d unimp,trace...
> then using 'grep ^...'. This is only due to a missing '\n' :)
>
so error_setg must be used WITHOUT \n and logging must happen wit
On 06/06/2018 04:09 PM, John Snow wrote:
> From: Paolo Bonzini
>
> There is code checking s->end_transfer_func and it was not taught about
> ide_transfer_cancel. We can just use ide_transfer_stop because
> s->end_transfer_func is only ever called in the DRQ phase.
>
> ide_transfer_cancel can th
On 6/6/2018 11:52 AM, Ján Tomko wrote:
On Wed, Jun 06, 2018 at 11:17:36AM -0700, Samudrala, Sridhar wrote:
On 6/4/2018 7:06 PM, Jason Wang wrote:
On 2018年06月05日 09:41, Samudrala, Sridhar wrote:
Ping on this patch now that the kernel patches are accepted into
davem's net-next tree.
https:/
Reviewed-by: John Snow
Tested-by: Jeff Cody
Reviewed-by: Jeff Cody
Signed-off-by: Max Reitz
---
tests/qemu-iotests/060 | 30 ++
tests/qemu-iotests/060.out | 14 ++
2 files changed, 44 insertions(+)
diff --git a/tests/qemu-iotests/060 b/tests/qemu-io
On 2018-06-06 21:06, Max Reitz wrote:
> 219 has two issues that may lead to sporadic failure, both of which are
> the result of issuing query-jobs too early after a job has been
> modified. This can then lead to different results based on whether the
> modification has taken effect already or not.
On 2018-06-06 21:36, Max Reitz wrote:
> The non-public logs in
> https://bugzilla.redhat.com/show_bug.cgi?id=1583346 (sorry...) reveal
> this problem:
>
> $ (Create a qcow2 file "foo.qcow2" with a corrupted first L1 entry)
> $ echo 'qemu-io none0 "read 0 512"' \
> | x86_64-softmmu/qemu-system-
The non-public logs in
https://bugzilla.redhat.com/show_bug.cgi?id=1583346 (sorry...) reveal
this problem:
$ (Create a qcow2 file "foo.qcow2" with a corrupted first L1 entry)
$ echo 'qemu-io none0 "read 0 512"' \
| x86_64-softmmu/qemu-system-x86_64 -drive if=none,file=foo.qcow2 \
When signaling a corruption on a read-only image, qcow2 already makes
fatal events non-fatal (i.e., they will not result in the image being
closed, and the image header's corrupt flag will not be set). This is
necessary because we cannot set the corrupt flag on read-only images,
and it is possible
This is a useful function for the whole block layer, so make it public.
At the same time, users outside of block.c probably do not need to make
use of the reopen functionality, so rename the current function to
bdrv_is_writable_after_reopen() create a new bdrv_is_writable() function
that just passe
On 06/06/2018 04:24 PM, Eduardo Habkost wrote:
> On Tue, Jun 05, 2018 at 11:45:03AM -0300, Philippe Mathieu-Daudé wrote:
> [... something about config files ...]
>>> And after that, the following would run all "console" tests:
>>>
>>> avocado run -t console
>>>
>>> How does this sound?
>>
>> For
On 2018-06-04 20:58, John Snow wrote:
>
>
> On 06/04/2018 10:14 AM, Max Reitz wrote:
>> The non-public logs in
>> https://bugzilla.redhat.com/show_bug.cgi?id=1583346 (sorry...) reveal
>> this problem:
>>
>> $ (Create a qcow2 file "foo.qcow2" with a corrupted first L1 entry)
>> $ echo 'qemu-io non
On 06/06/2018 02:06 PM, Max Reitz wrote:
219 has two issues that may lead to sporadic failure, both of which are
the result of issuing query-jobs too early after a job has been
modified. This can then lead to different results based on whether the
modification has taken effect already or not.
F
The readline() call returns partial data.
Keep appending until the JSON buffer is complete.
This fixes:
$ scripts/qmp/qmp-shell -v -p /tmp/qmp.sock
Traceback (most recent call last):
File "scripts/qmp/qmp-shell", line 456, in
main()
File "scripts/qmp/qmp-shell", line
On Tue, Jun 05, 2018 at 11:49:07AM -0300, Philippe Mathieu-Daudé wrote:
> Hi Eduardo,
>
> On 05/30/2018 03:41 PM, Cleber Rosa wrote:
> > TL;DR
> > =
> >
> > Another version, with a minimalist approach, of the acceptance tests
> > infrastructure for QEMU, based on the Avocado Testing Framework
On Tue, Jun 05, 2018 at 11:45:03AM -0300, Philippe Mathieu-Daudé wrote:
[... something about config files ...]
> > And after that, the following would run all "console" tests:
> >
> > avocado run -t console
> >
> > How does this sound?
>
> For my use cases this doesn't worry me, I'll let Eduar
Signed-off-by: Philippe Mathieu-Daudé
---
$ qemu-system ... -d trace:i2c_recv,trace:i2c_send
4486@1528311614.709959:i2c_recv recv(addr:0x50) data:0x00
4486@1528311614.709994:i2c_send send(addr:0x50) data:0x05
4486@1528311614.710060:i2c_recv recv(addr:0x50) data:0x02
4486@1528311614.710161:i2c_rec
From: Paolo Bonzini
For the case where the end_transfer_func is also the caller of
ide_transfer_start, the mutual recursion can lead to unlimited
stack usage. Introduce a new version that can be used to change
tail recursion into a loop, and use it in trace_ide_atapi_cmd_reply_end.
Signed-off-b
MEH I forgot to v2 this.
On 06/06/2018 03:09 PM, John Snow wrote:
> Real hardware doesn't have an unlimited stack, so the unlimited
> recursion in the ATAPI code smells a bit. In fact, the call to
> ide_transfer_start easily becomes a tail call with a small change
> to the code (patch 5); however
From: Paolo Bonzini
The ATAPI_INT_REASON_IO interrupt is raised when I/O starts, but in the
AHCI case ide_set_irq was actually called at the end of a mutual recursion.
Move it early, with the side effect that ide_transfer_start becomes a tail
call in ide_atapi_cmd_reply_end.
Signed-off-by: Paolo
From: Paolo Bonzini
Now that end_transfer_func is a tail call in ahci_start_transfer,
formalize the fact that the callback (of which ahci_start_transfer is
the sole implementation) takes care of the transfer too: rename it to
pio_transfer and, if it is present, call the end_transfer_func as soon
The PIO Setup FIS is written in the PIO:Entry state, which comes before
the ATA and ATAPI data transfer states. As a result, the PIO Setup FIS
interrupt is now raised before DMA ends for ATAPI commands, and tests have
to be adjusted.
This is also hinted by the description of the command header in
Real hardware doesn't have an unlimited stack, so the unlimited
recursion in the ATAPI code smells a bit. In fact, the call to
ide_transfer_start easily becomes a tail call with a small change
to the code (patch 5); however, we also need to turn the call back to
ide_atapi_cmd_reply_end into anothe
From: Paolo Bonzini
There is code checking s->end_transfer_func and it was not taught about
ide_transfer_cancel. We can just use ide_transfer_stop because
s->end_transfer_func is only ever called in the DRQ phase.
ide_transfer_cancel can then be removed, since it would just be
calling ide_trans
1 - 100 of 341 matches
Mail list logo