Hi Keno,
On 05/26/2018 02:23 AM, k...@juliacomputing.com wrote:
> From: Keno Fischer
>
> - Guard two Linux only headers.
> - Define `ENOATTR` only if not only defined
>(it's defined in system headers on Darwin).
>
> Signed-off-by: Keno Fischer
> ---
> fsdev/file-op-9p.h | 2 ++
> hw/9
Hi Alex,
On 05/25/2018 11:19 AM, Alex Bennée wrote:
> This make is now invoked from each individual target make with the
> appropriate CC and EXTRA_CFLAGS set for each guest. It then includes
> additional Makefile.targets from:
>
> - tests/tcg/multiarch (always)
> - tests/tcg/$(TARGET_BASE_AR
(Cc'ing Samuel who replied in a previous thread)
Hi Alex,
On 05/25/2018 11:19 AM, Alex Bennée wrote:
> We can't use our normal Debian based compilers as Alpha isn't an
> officially supported architecture. However it is available as a port
> and fortunately cross compilers for all these targets ar
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: cover.1527310210.git.k...@alumni.harvard.edu
Subject: [Qemu-devel] [PATCH 00/13] 9p: Add support for Darwin
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git l
From: Keno Fischer
Signed-off-by: Keno Fischer
---
Makefile.objs | 1 +
configure | 23 +++
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/Makefile.objs b/Makefile.objs
index c6c3554..a2245c9 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -104,6 +104
From: Keno Fischer
Signed-off-by: Keno Fischer
---
hw/9pfs/9p-local.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index c55ea25..3e358b7 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-local.c
@@ -669,6 +669,13 @@ static int local_mknod(
From: Keno Fischer
This function is new in Mac OS 10.13. Provide a fallback implementation
when building against older SDKs.
Signed-off-by: Keno Fischer
---
hw/9pfs/9p-local.c | 2 +-
hw/9pfs/9p-util.c | 38 ++
hw/9pfs/9p-util.h | 7 +++
hw/9pfs/9p.c
From: Keno Fischer
Signed-off-by: Keno Fischer
---
hw/9pfs/9p-util.c | 49 +
1 file changed, 45 insertions(+), 4 deletions(-)
diff --git a/hw/9pfs/9p-util.c b/hw/9pfs/9p-util.c
index 8cf5554..98004ac 100644
--- a/hw/9pfs/9p-util.c
+++ b/hw/9pfs/9
From: Keno Fischer
Signed-off-by: Keno Fischer
---
hw/9pfs/9p.c | 37 +++--
1 file changed, 23 insertions(+), 14 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 49654ae..f5f00aa 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -115,20 +115,27 @@ stati
From: Keno Fischer
Signed-off-by: Keno Fischer
---
hw/9pfs/9p.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index f5f00aa..4ae4da6 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -3351,6 +3351,13 @@ out_nofid:
v9fs_string_free(&name);
}
+#if de
From: Keno Fischer
Signed-off-by: Keno Fischer
---
fsdev/file-op-9p.h | 4
hw/9pfs/9p-proxy.c | 17 ++---
hw/9pfs/9p-synth.c | 2 ++
hw/9pfs/9p.c | 16 ++--
4 files changed, 34 insertions(+), 5 deletions(-)
diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p
From: Keno Fischer
This code relied on P9_DOTL_AT_REMOVEDIR and AT_REMOVEDIR having the same
numerical value, but on Darwin, they do not.
Signed-off-by: Keno Fischer
---
hw/9pfs/9p-local.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/hw/9pfs/9p-local.c b/hw/
From: Keno Fischer
Signed-off-by: Keno Fischer
---
hw/9pfs/9p-local.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index f6c7526..7592f8d 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-loc
From: Keno Fischer
Signed-off-by: Keno Fischer
---
hw/9pfs/9p-synth.c | 4
hw/9pfs/9p.c | 18 --
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c
index eb68b42..3c0a6d8 100644
--- a/hw/9pfs/9p-synth.c
+++ b/hw/9p
From: Keno Fischer
These functions will need custom implementations on Darwin. Since the
implementation is very similar among all of them, and 9p-util already
has the _nofollow version of fgetxattrat, let's move them all there.
Additionally, introduce a _follow version of fgetxattr and use it.
O
From: Keno Fischer
- Darwin doesn't have strchrnul
- Comparisons of mode_t with -1 require an explicit cast, since mode_t
is unsigned on Darwin.
Signed-off-by: Keno Fischer
---
hw/9pfs/9p-local.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/9pfs/9p-local.c
From: Keno Fischer
- Guard two Linux only headers.
- Define `ENOATTR` only if not only defined
(it's defined in system headers on Darwin).
Signed-off-by: Keno Fischer
---
fsdev/file-op-9p.h | 2 ++
hw/9pfs/9p-local.c | 2 ++
include/qemu/xattr.h | 4 +++-
3 files changed, 7 insertions
From: Keno Fischer
Hi Greg,
this series adds support for building the 9p code on Mac OS X.
It seems to work decently well (tested by booting up a linux
guest and building a copy of qemu on a 9p mount in the guest),
but there are probably corner cases I got wrong (particular
in the xattr support)
Hi Alex,
On 01/17/2018 08:01 AM, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé writes:
>
>> the 'debian' base image is deprecated since 3e11974988d8
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>
> Reviewed-by: Alex Bennée
Can you also queue this patch?
>
>> ---
>> tests/docker/Makefile.i
Hi Alex,
On 01/17/2018 06:37 AM, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé writes:
>
>> we can now directly see different version sort consecutively.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>
> I of course meant:
>
> Reviewed-by: Alex Bennée
Can you queue this patch please?
>
>
Hi Alex, ping for review ;)
On 05/01/2018 09:21 PM, Philippe Mathieu-Daudé wrote:
> TriCore binutils is built from Bastian Koppelmann repository.
>
> Note: There is no TriCore compiler in this image (only assembler/linker).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> See http://lists.nong
Hi Cleber,
On 05/25/2018 03:42 PM, Cleber Rosa wrote:
> The set_console() method is intended to ease higher level use cases
> that require a console device.
>
> The amount of intelligence is limited on purpose, requiring either the
> device type explicitly, or the existence of a machine (pattern)
Hi John,
On 05/25/2018 08:54 PM, John Snow wrote:
> A trace is added to let us watch unimplemented registers specifically,
> as these are more likely to cause us trouble. Otherwise, the port read
> traces now tell us what register is getting hit, which is nicer.
>
> Signed-off-by: John Snow
> --
On 05/25/2018 01:48 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Reviewed-by: Zhang Chen
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe M
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> No reason for vhost-scsi to pull in migration headers directly.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
> ---
> hw/scsi/vhost-scsi-common.c | 1 -
> 1 file changed, 1 delet
Extend the docs related to TPM with specs related to VM save and
restore and a troubleshooting guide for TPM migration.
Signed-off-by: Stefan Berger
Reviewed-by: Dr. David Alan Gilbert
---
docs/specs/tpm.txt | 106 +
1 file changed, 106 insert
Extend the TPM emulator backend device with state migration support.
The external TPM emulator 'swtpm' provides a protocol over
its control channel to retrieve its state blobs. We implement
functions for getting and setting the different state blobs.
In case the setting of the state blobs fails, w
Add a test program for testing the CRB with the external swtpm.
The 1st test case extends a PCR and reads back the value and compares
it against an expected return packet.
The 2nd test case repeats the 1st test case and then migrates the
external swtpm's state along with the VM state to a destina
This series of patches adds TPM emulator state migration support and a
test case for testing (local) migration.
Stefan
The following changes since commit 4f50c1673a89b07f376ce5c42d22d79a79cd466d:
Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request'
into staging (2018-
Extend the TPM TIS interface with state migration support.
We need to synchronize with the backend thread to make sure that a command
being processed by the external TPM emulator has completed and its
response been received.
Signed-off-by: Stefan Berger
Reviewed-by: Dr. David Alan Gilbert
Revie
On 05/25/2018 05:03 AM, Peter Maydell wrote:
On 24 May 2018 at 17:48, Stefan Berger wrote:
This series of patches adds TPM emulator state migration support and a
test case for testing (local) migration.
Stefan
The following changes since commit 4f50c1673a89b07f376ce5c42d22d79a79cd466d:
On 2018/5/25 19:36, no-re...@patchew.org wrote:
> /tmp/qemu-test/src/hw/intc/arm_gicv3_common.c: In function
> 'gicv3_gicd_no_migration_shift_bug_post_load':
> /tmp/qemu-test/src/hw/intc/arm_gicv3_common.c:165:9: error:
> 'gicd_no_migration_shift_bug' undeclared (first use in this function); di
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180525235509.11282-1-js...@redhat.com
Subject: [Qemu-devel] [PATCH 00/16] AHCI: tracing improvements
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --
Signed-off-by: John Snow
---
hw/ide/ahci.c | 7 ++-
hw/ide/trace-events | 4 +++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index cd834c563e..b74a871a83 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -490,13 +490,18 @@ static void ah
Churn.
Signed-off-by: John Snow
---
hw/ide/ahci.c | 142 +-
1 file changed, 71 insertions(+), 71 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 57c80a2fe9..2298e72833 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -279,85
Signed-off-by: John Snow
---
hw/ide/ahci.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 674e06853e..4bcb613bf9 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -382,22 +382,27 @@ static uint64_t ahci_mem_read_32(void *
Signed-off-by: John Snow
---
hw/ide/ahci.c | 47 +++
1 file changed, 23 insertions(+), 24 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index ea68950952..9225c4559f 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -465,37 +465,36 @@ static v
Signed-off-by: John Snow
---
hw/ide/ahci.c | 7 +--
hw/ide/trace-events | 3 +++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 4bcb613bf9..ea68950952 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -46,7 +46,6 @@ static bool ahci_ma
Instead of tracking offsets, lets count the registers.
Signed-off-by: John Snow
---
hw/ide/ahci.c | 25 +
hw/ide/ahci_internal.h | 29 +
2 files changed, 54 insertions(+)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index e22d7be05f..48
Signed-off-by: John Snow
---
hw/ide/ahci.c | 4 +++-
hw/ide/trace-events | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 1d93cd6806..61ac8e46c8 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -284,8 +284,8 @@ static void ahci_por
Actually, this function looks pretty broken, but for now, let's finish
up what this series of commits came here to do.
Signed-off-by: John Snow
---
hw/ide/ahci.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 9225c4559f..cd
Signed-off-by: John Snow
---
hw/ide/ahci_internal.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
index f9dcf8b6e6..2953243929 100644
--- a/hw/ide/ahci_internal.h
+++ b/hw/ide/ahci_internal.h
@@ -55,12 +55,6 @@
#define RX_FIS_UNK
Signed-off-by: John Snow
---
hw/ide/ahci.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index e9ca820d5e..1d93cd6806 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -282,30 +282,32 @@ static int ahci_cond_st
Yes, comment, it ought to be 0x2C.
Signed-off-by: John Snow
---
hw/ide/ahci_internal.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
index af366db6f3..f9dcf8b6e6 100644
--- a/hw/ide/ahci_internal.h
+++ b/hw/ide/ahci_internal
There's a bug I'm hunting down in AHCI at the moment,
so I made the AHCI tracing a little nicer again.
The bug is still at large, but no reason to hold up
tracing improvements.
In general, this set just adds register names so that
the read/write traces make more sense on their own without
having
Signed-off-by: John Snow
---
hw/ide/ahci.c | 15 +++
hw/ide/ahci_internal.h | 15 +++
2 files changed, 30 insertions(+)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 61ac8e46c8..674e06853e 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -46,6 +46,21 @@ stati
A trace is added to let us watch unimplemented registers specifically,
as these are more likely to cause us trouble. Otherwise, the port read
traces now tell us what register is getting hit, which is nicer.
Signed-off-by: John Snow
---
hw/ide/ahci.c | 5 +++--
hw/ide/trace-events | 3 ++-
Signed-off-by: John Snow
---
hw/ide/ahci.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 2298e72833..e9ca820d5e 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -330,11 +330,7 @@ static void ahci_port_write(AHCIState *s, int port, int
offset, uint32_
They're now unused.
Signed-off-by: John Snow
---
hw/ide/ahci_internal.h | 18 --
1 file changed, 18 deletions(-)
diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
index eb7e1eefc0..db00c9aa39 100644
--- a/hw/ide/ahci_internal.h
+++ b/hw/ide/ahci_internal.h
@@ -102,24
Signed-off-by: John Snow
---
hw/ide/ahci.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 48130c6439..5187bf34ad 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -93,41 +93,42 @@ static const char *
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Signed-off-by: Michael S. Tsirkin
> Acked-by: David Gibson
Reviewed-by: Philippe Ma
On Tue, May 22, 2018 at 5:15 PM, Michael Clark wrote:
> A missing shift made updates to the low order bits
> of timecmp erroneously copy the old low order bits
> into the high order bits of the 64-bit timecmp
> register. Add the missing shift and rename timecmp
> local variables to timecmp_hi and
On Tue, May 22, 2018 at 5:15 PM, Michael Clark wrote:
> The address calculation for the pending bitfield had
> a copy paste bug. This bug went unnoticed because the Linux
> PLIC driver does not read the pending bitfield, rather it
> reads pending interrupt numbers from the claim register
> and wri
On Fri, May 25, 2018 at 01:32:40PM -0500, Eric Blake wrote:
> On 05/25/2018 11:47 AM, Michael S. Tsirkin wrote:
> > Right now, a local header can be included with either
> >
> > #include "foo.h"
> > or
> > #include "dir/foo.h"
> >
> > since the later doesn't tell you where the header is
> >
On Fri, May 25, 2018 at 06:29:29PM -0300, Philippe Mathieu-Daudé wrote:
> On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> > When pulling in headers that are in the same directory as C file (as
> > opposed to one in include/), we should use its relative path, without a
> > directory.
> >
> > Si
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Ph
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Ph
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Ph
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> include files shouldn't have the "include/" part,
> that is implied.
>
> Also, drop an unused include.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
> ---
> hw/intc/ioapic.c | 3
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/net/e1000e.c | 2 +-
> 1 file changed,
On 05/25/2018 01:48 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Ph
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> We don't use net/clients.h, drop that include.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
> ---
> hw/net/rocker/rocker_fp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --
On 05/25/2018 01:48 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Ph
On 05/25/2018 01:48 PM, Michael S. Tsirkin wrote:
> include files shouldn't have the "include/" part,
> that is implied.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
> ---
> hw/sd/milkymist-memcard.c | 2 +-
> 1 file changed, 1 i
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Signed-off-by: Michael S. Tsirkin
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Stef
The Linux sandalfoot zImage has an initialisation process which resets the
VGA controller by setting all the BAR addresses to zero to access the VGA
ioports at their legacy addresses.
Unfortunately setting the framebuffer BAR to address 0 makes the framebuffer
memory overlap the internal VGA memor
On Fri, May 25, 2018 at 08:27:03PM +0200, Juan Quintela wrote:
> "Michael S. Tsirkin" wrote:
> > When pulling in headers that are in the same directory as C file (as
> > opposed to one in include/), we should use its relative path, without a
> > directory. Directory based path works more or less b
On Fri, May 25, 2018 at 01:24:08PM -0500, Eric Blake wrote:
> On 05/25/2018 11:48 AM, Michael S. Tsirkin wrote:
> > When pulling in headers that are in the same directory as C file (as
>
> s/as C/as the C/ (here and in many other messages)
Will fix, thanks.
> > opposed to one in include/), we sh
On Fri, May 25, 2018 at 08:30:59AM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
> > On Wed, May 23, 2018 at 05:53:34PM +0200, Markus Armbruster wrote:
[...]
> >> >> Worse, a machine type property that is static for all machine types now
> >> >> could conceivably become dynamic when we
On Fri, May 25, 2018 at 08:05:30AM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Thu, May 24, 2018 at 08:16:20PM +0200, Markus Armbruster wrote:
> >> Markus Armbruster writes:
> >>
> >> > Igor Mammedov writes:
> >> >
> >> >> Ban it for now, if someone would need it to work
On 05/25/2018 08:08 PM, Eric Blake wrote:
On 05/25/2018 12:46 PM, Halil Pasic wrote:
+static inline void warn_once(bool *warned, const char *fmt, ...)
+{
+ va_list ap;
+
+ if (!warned || *warned) {
+ return;
+ }
+ *warned = true;
+ va_start(ap, fmt);
+ warn_vreport(fm
The set_console() method is intended to ease higher level use cases
that require a console device.
The amount of intelligence is limited on purpose, requiring either the
device type explicitly, or the existence of a machine (pattern)
definition.
Because of the console device type selection criter
This patch adds a few simple behavior tests for VNC.
Signed-off-by: Cleber Rosa
---
tests/acceptance/test_vnc.py | 60
1 file changed, 60 insertions(+)
create mode 100644 tests/acceptance/test_vnc.py
diff --git a/tests/acceptance/test_vnc.py b/tests/accepta
This test boots a Linux kernel, and checks that the given command
line was effective in two ways:
* It makes the kernel use the set "console device" as a console
* The kernel records the command line as expected in the console
Given that way too many error conditions may occur, and detecting th
Tests will often need to add extra arguments to QEMU command
line arguments.
Signed-off-by: Cleber Rosa
---
scripts/qemu.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 08a3e9af5a..7cd8193df8 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
This patch adds the very minimum infrastructure necessary for writing
and running functional/acceptance tests, including:
* Documentation
* The avocado_qemu.Test base test class
* One example tests (test_version.py)
Additional functionality is expected to be added along the tests that
require
TL;DR
=
Another version, with a minimalist approach, to the acceptance tests
infrastructure for QEMU, based on the Avocado Testing Framework.
Background
==
The previous version, still considered an RFC, was sent to the list by
Eduardo[1] was based on the work held in Amador's branch[
On 05/25/2018 11:47 AM, Michael S. Tsirkin wrote:
Right now, a local header can be included with either
#include "foo.h"
or
#include "dir/foo.h"
since the later doesn't tell you where the header is
(in source or include directory), the former is preferable.
I intend to look for ways to pr
On 05/25/2018 11:47 AM, Michael S. Tsirkin wrote:
we just need a struct name, let's add a forward
declaration instead of an include.
Signed-off-by: Michael S. Tsirkin
---
include/migration/vmstate.h | 2 +-
migration/savevm.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
On 05/25/2018 11:47 AM, Michael S. Tsirkin wrote:
When pulling in headers that are in the same directory as C file (as
s/as C/as the C/
opposed to one in include/), we should use its relative path, without a
directory.
Signed-off-by: Michael S. Tsirkin
---
block/crypto.c | 2 +-
"Michael S. Tsirkin" wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
I don't agree with the comment that they work by accident,
On 05/25/2018 11:48 AM, Michael S. Tsirkin wrote:
When pulling in headers that are in the same directory as C file (as
s/as C/as the C/ (here and in many other messages)
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less
On 05/25/2018 11:33 AM, Kevin Wolf wrote:
This changes the x-blockdev-create QMP command so that it doesn't block
the monitor and the main loop any more, but starts a background job that
performs the image creation.
The basic job as implemented here is all that is necessary to make image
creatio
On 05/25/2018 12:46 PM, Halil Pasic wrote:
+static inline void warn_once(bool *warned, const char *fmt, ...)
+{
+ va_list ap;
+
+ if (!warned || *warned) {
+ return;
+ }
+ *warned = true;
+ va_start(ap, fmt);
+ warn_vreport(fmt, ap);
+ va_end(ap);
+}
+
+static inline
On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote:
> Changes since v3:
> * Updated the text in docs/nvdimm.txt to make it clear that the value
>being passed in on the command line in an integer made up of various
>bit fields. (Rob Elliott)
>
> * Updated the "Highest Valid Cap
On 05/25/2018 11:40 AM, Cornelia Huck wrote:
On Thu, 24 May 2018 19:58:27 +0200
Halil Pasic wrote:
There is at least one guest (OS) such that although it does not rely on
the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka
P bit) not being set, it fails to tell this to t
On 05/25/2018 04:00 AM, Kevin Wolf wrote:
> Am 24.05.2018 um 19:42 hat John Snow geschrieben:
>>
>>
>> On 05/24/2018 04:24 AM, Kevin Wolf wrote:
>>> Am 24.05.2018 um 01:18 hat John Snow geschrieben:
> diff --git a/include/qemu/job.h b/include/qemu/job.h
> index 3e817beee9..2648c74281 1006
On 15 May 2018 at 16:40, Kevin Wolf wrote:
> From: Alberto Garcia
>
> The L2 and refcount caches have default sizes that can be overridden
> using the l2-cache-size and refcount-cache-size (an additional
> parameter named cache-size sets the combined size of both caches).
Hi; Coverity raises a n
On 05/25/2018 02:08 AM, Fam Zheng wrote:
> On Thu, 05/24 20:58, Cleber Rosa wrote:
>> TL;DR
>> =
>>
>> Another version, with a minimalist approach, to the acceptance tests
>> infrastructure for QEMU, based on the Avocado Testing Framework.
>>
>> Background
>> ==
>>
>> The previous ver
On 05/25/2018 01:47 AM, Fam Zheng wrote:
> On Thu, 05/24 20:58, Cleber Rosa wrote:
>> The set_console() method is intended to ease higher level use cases
>> that require a console device.
>>
>> The amount of inteligence is limited on purpose, requiring either the
>> device type explicitly, or the
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180525163327.23097-1-kw...@redhat.com
Subject: [Qemu-devel] [PATCH 00/14] block: Make blockdev-create a job and
stable API
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory.
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
---
ui/gtk.c | 2 +-
ui/input-keymap.c | 2 +-
ui/input-legacy.c
Sort alphabetically. Will help us see if anything is missing (e.g. tile
is not there now).
Signed-off-by: Michael S. Tsirkin
---
arch_init.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 9597218..f4f3f61 100644
--- a/arch_ini
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory.
Signed-off-by: Michael S. Tsirkin
---
trace/qmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/trace/qmp.c b/trace/qmp.c
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin
---
migration/block-dirty-bitmap.c | 2 +-
migration/page
No reason for vhost-scsi to pull in migration headers directly.
Signed-off-by: Michael S. Tsirkin
---
hw/scsi/vhost-scsi-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/vhost-scsi-common.c b/hw/scsi/vhost-scsi-common.c
index 77e9897..e2a5828 100644
--- a/hw/scsi/vhost-scsi-co
include files shouldn't have the "include/" part,
that is implied.
Signed-off-by: Michael S. Tsirkin
---
hw/sd/milkymist-memcard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c
index 5570c1e..fe1 100644
--- a/hw/sd/m
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory.
Reviewed-by: Zhang Chen
Signed-off-by: Michael S. Tsirkin
---
net/colo-compare.c| 2 +-
net/colo.c| 2 +-
net/filter-rewriter.c
include files shouldn't have the "include/" part,
that is implied.
Also, drop an unused include.
Signed-off-by: Michael S. Tsirkin
---
hw/intc/ioapic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index 36139a4..c45f073 100644
--- a/h
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory.
Signed-off-by: Michael S. Tsirkin
Acked-by: David Gibson
---
hw/ppc/ppc440_uc.c | 2 +-
hw/ppc/sam460ex.c | 4 ++--
2 files changed, 3 inserti
1 - 100 of 309 matches
Mail list logo
