I enjoyed the great benefit of your suggestions, and I will improve next time.
:)
This time, I ask maintainers to touch up the commit message base on version 5
and merge it, thanks very much.
On 2018/5/17 14:22, Peter Xu wrote:
> On Thu, May 17, 2018 at 10:26:17AM +0800, Jie Wang wrote:
>> epoll
On Thu, May 17, 2018 at 10:26:17AM +0800, Jie Wang wrote:
> epoll_available will only be set if epollfd != -1, os we
> can swap the two variables in aio_epoll_disable, and
> aio_context_destroy can call aio_epoll_disable directly.
>
> Signed-off-by: Jie Wang
> ---
> util/aio-posix.c | 10 ---
On Thu, 05/17 10:26, Jie Wang wrote:
> epoll_available will only be set if epollfd != -1, os we
s/os/so/
> can swap the two variables in aio_epoll_disable, and
> aio_context_destroy can call aio_epoll_disable directly.
If you put this as 1/2 in v7, you do not want to mention the
yet-to-be-introd
Thanks for the quick iterations. A note on the patch submission:
When sending patch series with git, please use git-send-email's "--thread
--no-chain-reply-to" options, and also create a cover letter using "git
format-patch --cover-letter". Or you can use git-publish. For more complete
information
After a "make check" we end up with the following:
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Untracked files:
(use "git add ..." to include in what will be committed)
tests/test-block-backend
nothing added to commit but untracked files present (use
Signed-off-by: Ross Zwisler
Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"")
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Igor Mammedov
Cc: Haozhong Zhang
Cc: Michael S. Tsirkin
Cc: Stefan Hajnoczi
---
hw/mem/nvdimm.c | 2 +-
include/hw/mem/nvdimm.h | 2 +-
2
The first 2 patches in this series clean up some things I noticed while
coding.
Patch 3 adds support for the new Platform Capabilities Structure, which
was added to the NFIT in ACPI 6.2 Errata A. We add a machine command
line option "nvdimm-cap":
-machine pc,accel=kvm,nvdimm,nvdimm-cap=2
wh
Add testing for the newly added NFIT Platform Capabilities Structure.
Signed-off-by: Ross Zwisler
Suggested-by: Igor Mammedov
---
tests/acpi-test-data/pc/NFIT.dimmpxm | Bin 224 -> 240 bytes
tests/acpi-test-data/q35/NFIT.dimmpxm | Bin 224 -> 240 bytes
tests/bios-tables-test.c |
Add a machine command line option to allow the user to control the Platform
Capabilities Structure in the virtualized NFIT. This Platform Capabilities
Structure was added in ACPI 6.2 Errata A.
Signed-off-by: Ross Zwisler
---
docs/nvdimm.txt | 18 ++
hw/acpi/nvdimm.c
epoll_available will only be set if epollfd != -1, os we
can swap the two variables in aio_epoll_disable, and
aio_context_destroy can call aio_epoll_disable directly.
Signed-off-by: Jie Wang
---
util/aio-posix.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/util/
When we call addIOThread, the epollfd created in aio_context_setup,
but not close it in the process of delIOThread, so the epollfd will leak.
Signed-off-by: Jie Wang
---
include/block/aio.h | 8
util/aio-posix.c| 9 +
util/aio-win32.c| 4
util/async.c| 1 +
On Wed, May 16, 2018 at 09:39:41PM -0600, Alex Williamson wrote:
> On Thu, 17 May 2018 10:45:44 +0800
> Peter Xu wrote:
>
> > On Wed, May 16, 2018 at 09:57:40PM +0800, Jason Wang wrote:
> > >
> > >
> > > On 2018年05月16日 14:30, Peter Xu wrote:
> > > > On Fri, May 04, 2018 at 11:08:01AM +0800, P
On Thu, 17 May 2018 10:45:44 +0800
Peter Xu wrote:
> On Wed, May 16, 2018 at 09:57:40PM +0800, Jason Wang wrote:
> >
> >
> > On 2018年05月16日 14:30, Peter Xu wrote:
> > > On Fri, May 04, 2018 at 11:08:01AM +0800, Peter Xu wrote:
> > > > v2:
> > > > - fix patchew code style warnings
> > > > -
OK! I will split into two patches
On 2018/5/17 11:04, Peter Xu wrote:
> On Thu, May 17, 2018 at 08:42:43AM +0800, Jie Wang wrote:
>> When we call addIOThread, the epollfd created in aio_context_setup,
>> but not close it in the process of delIOThread, so the epollfd will leak.
>
> (maybe also men
On Thu, May 17, 2018 at 08:42:43AM +0800, Jie Wang wrote:
> When we call addIOThread, the epollfd created in aio_context_setup,
> but not close it in the process of delIOThread, so the epollfd will leak.
(maybe also mention about the aio_epoll_disable change, or split into
two patches?)
>
> Sig
On Thu, 05/17 08:42, Jie Wang wrote:
> When we call addIOThread, the epollfd created in aio_context_setup,
> but not close it in the process of delIOThread, so the epollfd will leak.
>
> Signed-off-by: Jie Wang
> ---
> include/block/aio.h | 8
> util/aio-posix.c| 13 ++---
>
When we call addIOThread, the epollfd created in aio_context_setup,
but not close it in the process of delIOThread, so the epollfd will leak.
Signed-off-by: Jie Wang
---
include/block/aio.h | 8
util/aio-posix.c| 13 ++---
util/aio-win32.c| 4
util/async.c
On Wed, May 16, 2018 at 09:02:42AM -0500, Eric Blake wrote:
> On 05/15/2018 10:07 PM, Peter Xu wrote:
>
> > > > +static bool __print_once; \
> > >
> > > Double-underscore names are reserved for the compiler's use, not ours.
> > > Better would be naming this:
> > >
> > > sta
On Wed, May 16, 2018 at 09:57:40PM +0800, Jason Wang wrote:
>
>
> On 2018年05月16日 14:30, Peter Xu wrote:
> > On Fri, May 04, 2018 at 11:08:01AM +0800, Peter Xu wrote:
> > > v2:
> > > - fix patchew code style warnings
> > > - interval tree: postpone malloc when inserting; simplify node remove
> > >
On Wed, 05/16 19:43, Peter Xu wrote:
> On Wed, May 16, 2018 at 07:14:53PM +0800, WangJie (Pluto) wrote:
> > Hi, Peter Xu:
> > If call aio_epoll_disable() here, aio_epoll_disable() will return
> > before close ctx->epollfd,
> > Because the ctx->epoll_enabled is false in the moment.
> >
On Wed, 05/16 18:52, Vladimir Sementsov-Ogievskiy wrote:
> 16.05.2018 18:32, Kevin Wolf wrote:
> > Am 16.05.2018 um 17:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > 16.05.2018 15:47, Kevin Wolf wrote:
> > > > Am 14.05.2018 um 12:09 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > > > 14
I agree, wait for a reply from Fam
On 2018/5/16 19:43, Peter Xu wrote:
> On Wed, May 16, 2018 at 07:14:53PM +0800, WangJie (Pluto) wrote:
>> Hi, Peter Xu:
>> If call aio_epoll_disable() here, aio_epoll_disable() will return
>> before close ctx->epollfd,
>> Because the ctx->epoll_enabled
Thank you for your reply.
I understand your suggestion.
But, our embedded OS is very light, so it does not still support to change
screen resolution.
It has fixed resolution(1920x1080).
So, I want a MultiSampling(anti-aliasing) in QEMU & virglrenderer.
I know the embedded OS supports changing res
On Wed, May 16, 2018 at 11:51 AM, Edgar E. Iglesias
wrote:
> From: "Edgar E. Iglesias"
>
> Consolidate MMU enabled checks to cpu_mmu_index().
> No functional changes.
>
> Suggested-by: Richard Henderson
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alistair Francis
Alistair
> ---
> targe
On Wed, May 16, 2018 at 11:51 AM, Edgar E. Iglesias
wrote:
> From: "Edgar E. Iglesias"
>
> Fixup the indentation of cpu_mmu_index in preparation for
> future edits.
> No functional changes.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alistair Francis
Alistair
> ---
> target/microblaze
On Wed, May 16, 2018 at 11:51 AM, Edgar E. Iglesias
wrote:
> From: "Edgar E. Iglesias"
>
> Add support for extended access to TLBLO's upper 32 bits.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alistair Francis
Alistair
> ---
> target/microblaze/helper.h| 4 ++--
> target/microbla
On Wed, May 16, 2018 at 11:51 AM, Edgar E. Iglesias
wrote:
> From: "Edgar E. Iglesias"
>
> Cleanup debug log messages:
> * Avoid long 80+ character lines.
> * Remove D() macro and use qemu_log_mask.
> * Remove logs that are not very useful
>
> Suggested-by: Alistair Francis
> Reviewed-by: Richar
On 05/16/2018 05:55 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
> ---
> linux-user/alpha/sockbits.h | 2 +-
> linux-user/generic/sockbits.h | 2 +-
> linux-user/mips/sockbits.h| 3 ---
> 3 files changed, 2 insertions(+), 5 deletions(-)
>
On 05/16/2018 05:55 PM, Laurent Vivier wrote:
> No code change.
>
> Signed-off-by: Laurent Vivier
> ---
> linux-user/generic/sockbits.h | 9 +
> linux-user/ppc/sockbits.h | 19 +++
> 2 files changed, 20 insertions(+), 8 deletions(-)
>
> diff --git a/linux-user/gener
Rearrange the arithmetic so that we are agnostic about the total size
of the vector and the size of the element. This will allow us to index
up to the 32nd byte and with 16-byte elements.
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.h | 14 +++---
1 file changed, 7 inse
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 4
target/arm/sve_helper.c| 43 ++
target/arm/translate-sve.c | 21 +++
target/arm/sve.decode | 4
4 files changed, 72 insertions(
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 5 +
target/arm/sve_helper.c| 40 ++
target/arm/translate-sve.c | 36 ++
target/arm/sve.decode | 12
4 files
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 10
target/arm/sve_helper.c| 108 +
target/arm/translate-sve.c | 88 ++
target/arm/sve.decode | 19 ++-
4 files change
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 5 +++
target/arm/sve_helper.c| 40 +++
target/arm/translate-sve.c | 79 ++
target/arm/sve.decode | 14 +++
4 files changed, 138 insertio
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/translate-sve.c | 49 ++
target/arm/sve.decode | 17 +
2 files changed, 66 insertions(+)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 2a0
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 23 +++
target/arm/sve_helper.c| 114 +++
target/arm/translate-sve.c | 133 +
target/arm/sve.decode | 27
4 files c
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/translate-sve.c | 34 ++
target/arm/sve.decode | 13 +
2 files changed, 47 insertions(+)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index f14bb21
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 25
target/arm/sve_helper.c| 264 +
target/arm/translate-sve.c | 130 ++
target/arm/sve.decode | 26
4 files changed, 445 insertio
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 4 ++
target/arm/sve_helper.c| 90 ++
target/arm/translate-sve.c | 24 ++
target/arm/sve.decode | 7 +++
4 files changed, 125 insertions(+)
diff --
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 2 +
target/arm/sve_helper.c| 81 ++
target/arm/translate-sve.c | 34
target/arm/sve.decode | 7
4 files changed, 124 insertions(+)
d
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 60 ++
target/arm/sve_helper.c| 127 +
target/arm/translate-sve.c | 113 +
target/arm/sve.decode | 23 ++
Signed-off-by: Richard Henderson
---
target/arm/cpu.h | 4 +
target/arm/helper-sve.h| 3 +
target/arm/sve_helper.c| 84 +++
target/arm/translate-sve.c | 209 +
target/arm/sve.decode | 31 ++
5 files changed, 331 inse
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 11 ++
target/arm/sve_helper.c| 136 ++
target/arm/translate-sve.c | 288 +
target/arm/sve.decode | 31 +++-
4 files changed, 465 insertions
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/translate-sve.c | 27 +++
target/arm/sve.decode | 12
2 files changed, 39 insertions(+)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index e3a8e9506e..f95
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 27 +++
target/arm/sve_helper.c| 25 +
target/arm/translate-sve.c | 4
target/arm/sve.decode | 8
4 files changed, 64 insertions(+
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/cpu.h | 4 +-
target/arm/helper-sve.h| 10 +
target/arm/sve_helper.c| 39
target/arm/translate-sve.c | 361 +
target/arm/sve.decode | 16 ++
5 files cha
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 12 ++
target/arm/sve_helper.c| 30 ++
target/arm/translate-sve.c | 85 ++
target/arm/sve.decode | 26
4 files changed, 153 inser
Excepting MOVPRFX, which isn't a reduction. Presumably it is
placed within the group because of its encoding.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 44 ++
target/arm/sve_helper.c| 91
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 21 +
target/arm/sve_helper.c| 35 +++
target/arm/translate-sve.c | 24
target/arm/sve.decode | 6 ++
4 files ch
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 21 ++
target/arm/helper.h| 1 +
target/arm/sve_helper.c| 78 ++
target/arm/translate-sve.c | 65 +++
target/arm/Makef
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 18
target/arm/sve_helper.c| 57 ++
target/arm/translate-sve.c | 34 +++
target/arm/sve.decode | 17
4 files cha
Signed-off-by: Richard Henderson
---
target/arm/helper-sve.h| 145 +++
target/arm/sve_helper.c| 194 +
target/arm/translate-sve.c | 68 +
target/arm/sve.decode | 42
4 files changed, 449 insertions(+)
These were the instructions that were stubbed out when
introducing the decode skeleton.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
v3: Remove typedefs now present in translate-a64.h.
---
target/arm/translate-sve.c | 55 --
1 file changed
Move some stuff that will be common to both translate-a64.c
and translate-sve.c.
Reviewed-by: Alex Bennée
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
v3: Move GVecGen2Fn, GVecGen2iFn, GVecGen3Fn too.
---
target/arm/translate-a64.h | 118
Signed-off-by: Richard Henderson
---
target/arm/translate-sve.c | 127 +
target/arm/sve.decode | 20 ++
2 files changed, 147 insertions(+)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 67d6db313e..5ec18a6aac 100644
--- a/
This is the first third, more or less, of my current patch set.
I'm sending only this portion now, rather than another monster
set all at once.
The major change is to move the call to sve_access_check inside
any final decode reject that might be required. There are other
minor cleanups to patch i
Including only 4, as-yet unimplemented, instruction patterns
so that the whole thing compiles.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.c | 7 -
target/arm/translate-sve.c | 63 ++
.gitignore
On 05/04/2018 03:37 AM, Igor Mammedov wrote:
Add permission checks for commands at 'preconfig' stage.
Signed-off-by: Igor Mammedov
---
+++ b/tests/qmp-test.c
@@ -392,6 +392,49 @@ static void add_query_tests(QmpSchema *schema)
}
}
+static bool qmp_rsp_is_err(QDict *rsp)
+{
+QD
Update enums with entries from linux 4.17
Translate entries that generate logs with iproute2 4.9.0 and
host kernel 4.15:
# ip address show
Unknown host QEMU_IFLA type: 43
Unknown host QEMU_IFLA type: 43
Unknown host QEMU_IFLA type: 43
Unknown QEMU_IFLA_BR type 41
Unknown QEMU_IFLA_BR
On Fri, May 04, 2018 at 10:37:49AM +0200, Igor Mammedov wrote:
> * start QEMU with 2 unmapped cpus,
> * while in preconfig state
> * add 2 numa nodes
> * assign cpus to them
> * exit preconfig and in running state check that cpus
>are mapped correctly.
>
> Signed-off-by: Igor Mammed
On 05/16/2018 06:35 PM, Daniel Henrique Barboza wrote:
On 05/16/2018 04:47 AM, Paolo Bonzini wrote:
On 15/05/2018 23:25, Daniel Henrique Barboza wrote:
This is the current status of this investigation. I decided to start a
discussion here, see if someone can point me something that I
overl
On 05/16/2018 05:37 PM, Eric Blake wrote:
>> +##
>> +# @BitmapMapping:
>> +#
>> +# List of described regions correlated to a named bitmap.
>> +#
>> +# @name: The name of the bitmap whose range is described here
>> +#
>> +# @entries: A list of zero or more @BitmapEntry elements representing
>> +#
On 05/16/2018 05:34 PM, Eric Blake wrote:
> On 05/11/2018 08:25 PM, John Snow wrote:
>> The function already exists, just expose it.
>>
>> Signed-off-by: John Snow
>> ---
>> include/qapi/qmp/qjson.h | 1 +
>> qobject/qjson.c | 21 +++--
>> 2 files changed, 12 insert
For me it is hangs with SATA, but IDE is fine.
Windows 7 Version (for the VM)
- SP1
Boot HDD for VM
- Actual HDD (/dev/sda)
- QCOW2 Image
QEMU
- qemu-2.12.0-1
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.n
On 05/16/2018 06:47 AM, Dr. David Alan Gilbert wrote:
* Daniel Henrique Barboza (danie...@linux.ibm.com) wrote:
Hi,
I've been working in the last two months in a miscompare issue that happens
when using a raid device and a SATA as scsi-hd (emulated SCSI) with
cache=none and io=threads during
On 05/11/2018 08:25 PM, John Snow wrote:
Add two new structures for detailing the marked regions of bitmaps as
saved in e.g. qcow2 files.
Signed-off-by: John Snow
---
qapi/block-core.json | 32
1 file changed, 32 insertions(+)
diff --git a/qapi/block-core.js
On 05/16/2018 04:47 AM, Paolo Bonzini wrote:
On 15/05/2018 23:25, Daniel Henrique Barboza wrote:
This is the current status of this investigation. I decided to start a
discussion here, see if someone can point me something that I overlooked
or got it wrong, before I started changing the POSIX
On 05/11/2018 08:25 PM, John Snow wrote:
The function already exists, just expose it.
Signed-off-by: John Snow
---
include/qapi/qmp/qjson.h | 1 +
qobject/qjson.c | 21 +++--
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/include/qapi/qmp/qjson.h
On 05/16/2018 03:56 PM, Kevin Wolf wrote:
+
+void job_unref(Job *job)
+{
+if (--job->refcnt == 0) {
Should this be free()-like and allow an incoming job == NULL as a no-op?
This behaves like block_job_unref() always behavec, and I don't see a
single caller having a NULL check before call
On 05/09/2018 11:26 AM, Kevin Wolf wrote:
BlockJob has fields .offset and .len, which are actually misnomers today
because they are no longer tied to block device sizes, but just progress
counters. As such they make a lot of sense in generic Jobs.
This patch moves the fields to Job and renames t
On 05/14/2018 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
> 12.05.2018 04:25, John Snow wrote:
>> Add functions for querying the basic information inside of bitmaps.
>> Restructure the bitmaps flags masks to facilitate providing a list of
>> flags belonging to the bitmap(s) being queried.
>>
>>
On 05/14/2018 10:30 AM, Vladimir Sementsov-Ogievskiy wrote:
> 12.05.2018 04:25, John Snow wrote:
>> Add some of the necessary scaffolding for reporting bitmap information.
>>
>> Signed-off-by: John Snow
>> ---
>> qapi/block-core.json | 60
>> +++-
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180516205543.29305-1-laur...@vivier.eu
Subject: [Qemu-devel] [PATCH v2 0/8] linux-user: move socket.h definitions to
CPU directories
=== TEST SCRIPT BEGIN ===
#!/bin/bash
Signed-off-by: Laurent Vivier
---
linux-user/alpha/sockbits.h | 2 +-
linux-user/generic/sockbits.h | 2 +-
linux-user/mips/sockbits.h| 3 ---
3 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/linux-user/alpha/sockbits.h b/linux-user/alpha/sockbits.h
index f5397dd875..d54dc98c0
and include the file from architectures without specific definitions
Signed-off-by: Laurent Vivier
---
linux-user/aarch64/sockbits.h| 1 +
linux-user/arm/sockbits.h| 1 +
linux-user/cris/sockbits.h | 1 +
linux-user/generic/sockbits.h| 67
to be like in the kernel and rename it TARGET_ARCH_HAS_SOCKET_TYPES
Signed-off-by: Laurent Vivier
---
linux-user/alpha/sockbits.h | 36 +++---
linux-user/hppa/sockbits.h | 33 +++-
linux-user/mips/sockbits.h | 9 ---
linux-user/socket.h | 62
No code change.
Signed-off-by: Laurent Vivier
---
linux-user/generic/sockbits.h | 9 +
linux-user/ppc/sockbits.h | 19 +++
2 files changed, 20 insertions(+), 8 deletions(-)
diff --git a/linux-user/generic/sockbits.h b/linux-user/generic/sockbits.h
index 093faf0a48..
No code change.
Signed-off-by: Laurent Vivier
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
linux-user/socket.h | 44 +---
linux-user/sparc/sockbits.h | 94 +++
linux-user/sparc64/sockbits.h | 1 +
3 file
No code change.
Signed-off-by: Laurent Vivier
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
linux-user/alpha/sockbits.h | 113
linux-user/socket.h | 106 +
2 files changed, 114 ins
Splitting out socket.h definitions helps to read the code
and to fix the bugs...
No code change, except for the last one that ports
definitions from linux for sparc as the values are not the
correct ones.
v2:
- move generic socket.h to generic/sockbits.h
and include this file from arch with
Am 16.05.2018 um 20:17 hat Eric Blake geschrieben:
> On 05/09/2018 11:26 AM, Kevin Wolf wrote:
> > This moves reference counting from BlockJob to Job.
> >
> > In order to keep calling the BlockJob cleanup code when the job is
> > deleted via job_unref(), introduce a new JobDriver.free callback. Ev
Values defined for sparc are not correct.
Copy the content of "arch/sparc/include/uapi/asm/socket.h"
to fix them.
Signed-off-by: Laurent Vivier
---
linux-user/sparc/sockbits.h | 131 +++-
1 file changed, 92 insertions(+), 39 deletions(-)
diff --git a/linu
No code change.
Signed-off-by: Laurent Vivier
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
linux-user/mips/sockbits.h | 110 +++
linux-user/mips64/sockbits.h | 1 +
linux-user/socket.h | 106 +---
Am 16.05.2018 um 21:13 hat Eric Blake geschrieben:
> On 05/09/2018 11:26 AM, Kevin Wolf wrote:
> > This renames the BlockJobCreateFlags constants, moves a few JOB_INTERNAL
> > checks to job_create() and the auto_{finalize,dismiss} fields from
> > BlockJob to Job.
>
> Do we still want to allow auto
On Wed, May 16, 2018 at 07:25:53PM +, Moger, Babu wrote:
>
> > -Original Message-
> > From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> > Sent: Wednesday, May 16, 2018 7:52 AM
> > To: Moger, Babu
> > Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
> > r...@twi
On 05/16/2018 03:46 PM, Kevin Wolf wrote:
+{ 'event': 'JOB_STATUS_CHANGE',
+ 'data': { 'id': 'str',
+'status': 'JobStatus' } }
Is it worth also trying to list the old state that the transition came from?
But that's new compared to what block jobs are currently doing, so if we
can'
Am 16.05.2018 um 21:26 hat Eric Blake geschrieben:
> On 05/09/2018 11:26 AM, Kevin Wolf wrote:
> > This adds a QMP event that is emitted whenever a job transitions from
> > one status to another. For the event, a new qapi/job.json schema file is
> > created which will contain all job-related defini
Murilo Opsfelder Araujo writes:
> On Wed, May 16, 2018 at 04:18:56PM +0100, Alex Bennée wrote:
>>
>> Murilo Opsfelder Araujo writes:
>>
>> > On 04/24/2018 12:23 PM, Alex Bennée wrote:
>> >> This allows us to specify cross compilers for our guests. This is
>> >> useful for building test images/p
On 05/16/2018 01:23 PM, Peter Maydell wrote:
> On 16 May 2018 at 16:16, Philippe Mathieu-Daudé wrote:
>> Hi Eric,
>>
>> On 05/16/2018 03:03 PM, Eric Auger wrote:
>>> Coverity points out that this can overflow if n > 31,
>>> because it's only doing 32-bit arithmetic. Let's use 1ULL instead
>>> of 1
I'm queueing this version (including v8 of patches 5-7) on
numa-next.
Markus, Daniel: you were the people I remember expressing some
concerns about the new preconfig mechanism. Do you have any
objections to this version?
On Fri, May 04, 2018 at 10:37:38AM +0200, Igor Mammedov wrote:
>
>
> v6
From: "Edgar E. Iglesias"
Consolidate MMU enabled checks to cpu_mmu_index().
No functional changes.
Suggested-by: Richard Henderson
Signed-off-by: Edgar E. Iglesias
---
target/microblaze/cpu.h| 4 +++-
target/microblaze/helper.c | 6 +++---
2 files changed, 6 insertions(+), 4 deletions(-)
From: "Edgar E. Iglesias"
Fixup the indentation of cpu_mmu_index in preparation for
future edits.
No functional changes.
Signed-off-by: Edgar E. Iglesias
---
target/microblaze/cpu.h | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/target/microblaze/cpu.h b/t
From: "Edgar E. Iglesias"
Plug a temp leak.
Reported-by: Richard Henderson
Signed-off-by: Edgar E. Iglesias
---
target/microblaze/translate.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 0
On 05/09/2018 11:26 AM, Kevin Wolf wrote:
This adds a QMP event that is emitted whenever a job transitions from
one status to another. For the event, a new qapi/job.json schema file is
created which will contain all job-related definitions that aren't tied
to the block layer.
Signed-off-by: Kevi
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Wednesday, May 16, 2018 7:52 AM
> To: Moger, Babu
> Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; qemu-devel@nongnu.org;
> k...@vger.kernel.or
From: "Edgar E. Iglesias"
Add a R_TBLX_MISS MASK and SHIFT macros.
Reviewed-by: Alistair Francis
Reviewed-by: Richard Henderson
Signed-off-by: Edgar E. Iglesias
---
target/microblaze/mmu.c | 5 +++--
target/microblaze/mmu.h | 4
2 files changed, 7 insertions(+), 2 deletions(-)
diff --g
From: "Edgar E. Iglesias"
Convert env_btarget to i64.
No functional change.
Signed-off-by: Edgar E. Iglesias
---
target/microblaze/cpu.h | 2 +-
target/microblaze/op_helper.c | 2 +-
target/microblaze/translate.c | 36 +++-
3 files changed, 25 insertions
From: "Edgar E. Iglesias"
Setup MicroBlaze builds for 64bit addressing.
No functional change since the translator does not yet
emit 64bit addresses.
Reviewed-by: Richard Henderson
Signed-off-by: Edgar E. Iglesias
---
configure | 1 +
target/microblaze/cpu.h | 6 +++---
2 files c
On 05/09/2018 11:26 AM, Kevin Wolf wrote:
block_job_event_pending() doesn't only send a QMP event, but it also
transitions to the PENDING state. Split the function so that we get one
part only sending the event (like other block_job_event_* functions) and
another part than does the state transiti
From: "Edgar E. Iglesias"
Cleanup eval_cond_jmp to use tcg_gen_movcond_i64().
No functional change.
Suggested-by: Richard Henderson
Signed-off-by: Edgar E. Iglesias
---
target/microblaze/translate.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/target/m
1 - 100 of 320 matches
Mail list logo
