Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-04-19 Thread Viktor VM Mihajlovski
On 19.04.2018 18:55, Thomas Huth wrote: > On 19.04.2018 14:40, Viktor VM Mihajlovski wrote: >> On 19.04.2018 10:17, Thomas Huth wrote: >>> On 19.04.2018 09:41, Viktor VM Mihajlovski wrote: On 18.04.2018 14:31, Thomas Huth wrote: > Since it is quite cumbersome to manually create a combined

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 02/10] spapr: Remove support for PowerPC 970 with pseries machine type

2018-04-19 Thread luigi burdo
(because testing if we broke it means finding a real 970 host). Hi, i have a real 970 host if you need an hand to test just ask Luigi

[Qemu-devel] [PATCH v5 2/2] Add QTest testcase for the Intel Hexadecimal Object File Loader.

2018-04-19 Thread Su Hang
'test.hex' file is a bare metal ARM software stored in Hexadecimal Object Format. When it's loaded by QEMU, it will print "Hello world!\n" on console. `pre_store` array in 'hexloader-test.c' file, stores the binary format of 'test.hex' file, which is used to verify correctness. Signed-off-by: Su

[Qemu-devel] [PATCH v5 1/2] Implement .hex file loader

2018-04-19 Thread Su Hang
This patch adds Intel Hexadecimal Object File format support to the loader. The file format specification is available here: http://www.piclist.com/techref/fileext/hex/intel.htm The file format is mainly intended for embedded systems and microcontrollers, such as Arduino, ARM, STM32, etc. Sugge

[Qemu-devel] [PATCH v5 0/2] Implement Hex file loader and add test case

2018-04-19 Thread Su Hang
These series of patchs implement Intel Hexadecimal File loader and add QTest testcase to verify the correctness of Loader. v1: Basic version. v2: Replace `do{}while(cond);` block with `for(;;)` block. v3: Add two new files information in MAINTAINERS. v4: Correct the 'test.hex' path in hexloader-te

Re: [Qemu-devel] [PATCH v2 42/43] tests/tcg: disable fp-test for 32 bit (HACK!)

2018-04-19 Thread Alex Bennée
Richard Henderson writes: > On 04/19/2018 03:59 AM, Alex Bennée wrote: >> +ifneq (,$(findstring 64,$(TARGET_NAME))) > > You're only considering aarch64, x86_64, ppc64 and the like. > This fails for alpha, s390x and the like. Yes, it's a temporary hack that needs a better solution. -- Alex Benn

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-19 Thread Alex Bennée
Richard Henderson writes: > On 04/19/2018 03:58 AM, Alex Bennée wrote: >> I did start playing with crosstool-ng and Linaro's own ABE scripts but >> realised this could end up a massive time sync. What would be really >> helpful is if the respective maintainers could encode their EXACT >> STEPS f

Re: [Qemu-devel] [PATCH for-2.13 02/10] spapr: Remove support for PowerPC 970 with pseries machine type

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 07:21:05PM +0200, Greg Kurz wrote: > On Tue, 17 Apr 2018 17:17:14 +1000 > David Gibson wrote: > > > Current POWER cpus allow for a VRMA, a special mapping which describes a > > guest's view of memory when in real mode (MMU off, from the guest's point > > of view). Older c

Re: [Qemu-devel] [PATCH for-2.13 01/10] spapr: Avoid redundant calls to spapr_cpu_reset()

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 03:48:23PM +0200, Greg Kurz wrote: > On Tue, 17 Apr 2018 17:17:13 +1000 > David Gibson wrote: > > > af81cf323c1 "spapr: CPU hotplug support" added a direct call to > > spapr_cpu_reset() in spapr_cpu_init(), as well as registering it as a > > reset callback. That was in or

Re: [Qemu-devel] [PATCH v4 0/9] enable numa configuration before machine_init() from QMP

2018-04-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Apr 19, 2018 at 10:00:04AM +0200, Igor Mammedov wrote: >> On Wed, 18 Apr 2018 09:08:30 +0200 >> Markus Armbruster wrote: >> >> > Eduardo Habkost writes: >> > >> > > On Tue, Apr 17, 2018 at 05:41:10PM +0200, Igor Mammedov wrote: >> > >> On Tue, 17 Apr 2018 1

Re: [Qemu-devel] [PATCH v1 for-2.13 2/4] pc-bios/s390-ccw/net: Stop virtio-net device before jumping into the OS

2018-04-19 Thread Thomas Huth
On 19.04.2018 17:49, Christian Borntraeger wrote: > On 04/18/2018 02:31 PM, Thomas Huth wrote: >> The virtio-net receive buffers are filled asynchronously, so we should >> make sure to properly shut down the virtio-net device before we jump into >> the loaded kernel. Otherwise an incoming packet co

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

2018-04-19 Thread Alexey Kardashevskiy
On 19/4/18 8:33 pm, Paolo Bonzini wrote: > On 19/04/2018 04:41, Alexey Kardashevskiy wrote: >> it just seems to >> be a real case and majority of object_get_canonical_path_component() users >> do not test the returned pointer. >> >> === >> diff --git a/qom/object.c b/qom/object.c >>

Re: [Qemu-devel] [RFC 1/2] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

2018-04-19 Thread Kevin Wolf
Am 20.04.2018 um 05:21 hat Stefan Hajnoczi geschrieben: > On Thu, Apr 19, 2018 at 10:18:33AM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use > > > this to drop page cache on the destin

Re: [Qemu-devel] [RFC 2/2] block/file-posix: verify page cache is not used

2018-04-19 Thread Kevin Wolf
Am 20.04.2018 um 05:02 hat Stefan Hajnoczi geschrieben: > On Thu, Apr 19, 2018 at 10:05:47AM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > This commit is for debugging only. Do not merge it. > > > > > > mincore(2) checks whether pages are resident.

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 09/10] target/ppc: Don't bother with MSR_EP in cpu_ppc_set_papr()

2018-04-19 Thread David Gibson
On Fri, Apr 20, 2018 at 08:08:59AM +0200, Thomas Huth wrote: > On 17.04.2018 09:17, David Gibson wrote: > > cpu_ppc_set_papr() removes the EP and HV bits from the MSR mask. While > > removing the HV bit makes sense (a cpu in PAPR mode should never be > > emulated in hypervisor mode), the EP bit is

Re: [Qemu-devel] [RFC 1/2] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

2018-04-19 Thread Kevin Wolf
Am 20.04.2018 um 05:15 hat Stefan Hajnoczi geschrieben: > On Thu, Apr 19, 2018 at 04:13:44PM +0800, Fam Zheng wrote: > > On Thu, 04/19 15:52, Stefan Hajnoczi wrote: > > > On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use > > > this to drop page cache on the destination host durin

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 09/10] target/ppc: Don't bother with MSR_EP in cpu_ppc_set_papr()

2018-04-19 Thread Thomas Huth
On 17.04.2018 09:17, David Gibson wrote: > cpu_ppc_set_papr() removes the EP and HV bits from the MSR mask. While > removing the HV bit makes sense (a cpu in PAPR mode should never be > emulated in hypervisor mode), the EP bit is just bizarre. Although it's > true that a papr mode guest shouldn't

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 02/10] spapr: Remove support for PowerPC 970 with pseries machine type

2018-04-19 Thread Thomas Huth
On 19.04.2018 19:21, Greg Kurz wrote: > On Tue, 17 Apr 2018 17:17:14 +1000 > David Gibson wrote: > >> Current POWER cpus allow for a VRMA, a special mapping which describes a >> guest's view of memory when in real mode (MMU off, from the guest's point >> of view). Older cpus didn't have that whi

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 12:24:04PM +0100, Dr. David Alan Gilbert wrote: > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > > > On Wed, Apr 18, 2018 at 10:57:26A

Re: [Qemu-devel] [PATCH v4 0/9] enable numa configuration before machine_init() from QMP

2018-04-19 Thread David Gibson
On Tue, Apr 17, 2018 at 04:13:34PM +0200, Markus Armbruster wrote: > Igor Mammedov writes: > > [...] > > Series allows to configure NUMA mapping at runtime using QMP > > interface. For that to happen it introduces a new '-preconfig' CLI option > > which allows to pause QEMU before machine_init()

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-19 Thread Peter Xu
On Fri, Apr 20, 2018 at 12:57:13PM +0800, Jason Wang wrote: > > > On 2018年04月18日 12:51, Peter Xu wrote: > > During IOVA page table walk, there is a special case when: > > > > - notify_unmap is set, meanwhile > > - entry is invalid > > > > In the past, we skip the entry always. This is not corr

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-19 Thread Jason Wang
On 2018年04月18日 12:51, Peter Xu wrote: During IOVA page table walk, there is a special case when: - notify_unmap is set, meanwhile - entry is invalid In the past, we skip the entry always. This is not correct. We should send UNMAP notification to registered notifiers in this case. Otherwise

[Qemu-devel] [PATCH v3 3/3] configure: enable debug-mutex if debug enabled

2018-04-19 Thread Peter Xu
Signed-off-by: Peter Xu --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index a80af735b2..87453edd88 100755 --- a/configure +++ b/configure @@ -1005,6 +1005,7 @@ for opt do --enable-debug) # Enable debugging options that aren't excessively noisy

[Qemu-devel] [PATCH v3 2/3] QemuMutex: support --enable-debug-mutex

2018-04-19 Thread Peter Xu
We have had some tracing tools for mutex but it's not easy to use them for e.g. dead locks. Let's provide "--enable-debug-mutex" parameter when configure to allow QemuMutex to store the last owner that took specific lock. It will be easy to use this tool to debug deadlocks since we can directly k

[Qemu-devel] [PATCH v3 1/3] qemu-thread: introduce qemu-thread-common.[ch]

2018-04-19 Thread Peter Xu
Put all the shared qemu-thread implementations into these files. The header should be internal to qemu-thread but not for qemu-thread users. Introduce some hooks correspondingly for the shared part. Note that in qemu_mutex_unlock_impl() we moved the call before unlock operation which should make

[Qemu-devel] [PATCH v3 0/3] qemu-thread: support --enable-debug-mutex

2018-04-19 Thread Peter Xu
v3: - note down owner for every locking operations [Emilio] - let Windows use it too [Emilio] - added two more patches: patch 1 & 3. Patch 1 generalize some common hooks for qemu-thread implementation for both POSIX and Windows. Patch 2 introduces the new debugging facility. Patch 3 turns on mut

Re: [Qemu-devel] [RFC PATCH 0/7] avocado: Add acceptance tests parsing the Linux boot console

2018-04-19 Thread Philippe Mathieu-Daudé
Cross-posting qemu-devel + avocado-devel. > While previously working on a Super I/O refactor, I encountered some problems > at runtime, after building the codebase successfully and running qtests. > I had to manually start to boot different guests and check the bootlog. > > I wanted to give a try

Re: [Qemu-devel] [sw-dev] The problem of write misa on QEMU and BBL

2018-04-19 Thread Andrew Waterman
On Thu, Apr 19, 2018 at 5:05 PM, Michael Clark wrote: > > > On Thu, Apr 19, 2018 at 9:28 PM, Zong Li wrote: > >> 2018-04-19 12:43 GMT+08:00 Michael Clark : >> > Hi Zong, >> > >> >> On 19/04/2018, at 2:40 PM, Zong Li wrote: >> >> >> >> Hi all, >> >> >> >> For BBL part, in fp_init at machine/mini

Re: [Qemu-devel] [sw-dev] The problem of write misa on QEMU and BBL

2018-04-19 Thread Andrew Waterman
On Thu, Apr 19, 2018 at 5:11 PM, Michael Clark wrote: > > > On Fri, Apr 20, 2018 at 12:05 PM, Michael Clark wrote: > >> >> >> On Thu, Apr 19, 2018 at 9:28 PM, Zong Li wrote: >> >>> 2018-04-19 12:43 GMT+08:00 Michael Clark : >>> > Hi Zong, >>> > >>> >> On 19/04/2018, at 2:40 PM, Zong Li wrote:

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-19 Thread Max Filippov
On Thu, Apr 19, 2018 at 6:58 AM, Alex Bennée wrote: > We still have quite a bit of test code that is not built. These are: [...] > * tests/tcg/xtensa > Needs a cross-compiler FWIW static bare-metal cross-compiler w/o libc for xtensa core used in test/tcg/xtensa is available here: https://git

Re: [Qemu-devel] [PATCH] docker: Rename the amd64 image as amd64-cross

2018-04-19 Thread Philippe Mathieu-Daudé
On 04/19/2018 11:57 PM, Fam Zheng wrote: > On Thu, 04/19 23:40, Philippe Mathieu-Daudé wrote: >> Like the other images, this one is also used to cross-compile. >> Name it accordingly, matching directory pattern. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> tests/docker/Makefile.include

Re: [Qemu-devel] [RFC 1/2] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

2018-04-19 Thread Fam Zheng
On Fri, 04/20 11:15, Stefan Hajnoczi wrote: > On Thu, Apr 19, 2018 at 04:13:44PM +0800, Fam Zheng wrote: > > On Thu, 04/19 15:52, Stefan Hajnoczi wrote: > > > On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use > > > this to drop page cache on the destination host during shared sto

Re: [Qemu-devel] [RFC 1/2] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

2018-04-19 Thread Stefan Hajnoczi
On Thu, Apr 19, 2018 at 10:18:33AM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use > > this to drop page cache on the destination host during shared storage > > migration. This way the de

Re: [Qemu-devel] [RFC 1/2] block/file-posix: implement bdrv_co_invalidate_cache() on Linux

2018-04-19 Thread Stefan Hajnoczi
On Thu, Apr 19, 2018 at 04:13:44PM +0800, Fam Zheng wrote: > On Thu, 04/19 15:52, Stefan Hajnoczi wrote: > > On Linux posix_fadvise(POSIX_FADV_DONTNEED) invalidates pages*. Use > > this to drop page cache on the destination host during shared storage > > migration. This way the destination host w

Re: [Qemu-devel] [PATCH v2 31/43] tests/tcg: enable building for MIPS

2018-04-19 Thread Fam Zheng
On Thu, 04/19 23:57, Philippe Mathieu-Daudé wrote: > On 04/19/2018 02:58 PM, Peter Maydell wrote: > > On 19 April 2018 at 18:49, Alex Bennée wrote: > >> Philippe Mathieu-Daudé writes: > >>> On 04/19/2018 10:58 AM, Alex Bennée wrote: > This doesn't add any additional tests but enables buildin

Re: [Qemu-devel] [RFC for-2.13 0/7] spapr: Clean up pagesize handling

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 05:30:04PM +0200, Andrea Bolognani wrote: > On Thu, 2018-04-19 at 16:29 +1000, David Gibson wrote: > > Currently the "pseries" machine type will (usually) advertise > > different pagesizes to the guest when running under KVM and TCG, which > > is not how things are supposed

Re: [Qemu-devel] [qemu-s390x] [PATCH for-2.13] Clear mem_path if we fall back to anonymous RAM allocation

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 06:08:51PM +0200, Greg Kurz wrote: > On Thu, 19 Apr 2018 16:11:37 +0200 > David Hildenbrand wrote: > > > On 19.04.2018 15:34, Christian Borntraeger wrote: > > > > > > > > > On 04/19/2018 02:58 PM, Cornelia Huck wrote: > > >> On Thu, 19 Apr 2018 14:33:18 +0200 > > >> Ig

Re: [Qemu-devel] [PATCH for-2.13] Clear mem_path if we fall back to anonymous RAM allocation

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 06:30:37PM +0200, Greg Kurz wrote: > On Thu, 19 Apr 2018 17:21:23 +1000 > David Gibson wrote: > > > If the -mem-path option is set, we attempt to map the guest's RAM from a > > file in the given path; it's usually used to back guest RAM with hugepages. > > If we're unable

Re: [Qemu-devel] [RFC 0/2] block/file-posix: allow -drive cache.direct=off live migration

2018-04-19 Thread Stefan Hajnoczi
On Thu, Apr 19, 2018 at 11:09:53AM -0500, Eric Blake wrote: > On 04/19/2018 02:52 AM, Stefan Hajnoczi wrote: > > file-posix.c only supports shared storage live migration with -drive > > cache.direct=off due to cache consistency issues. There are two main shared > > storage configurations: files on

Re: [Qemu-devel] [RFC 2/2] block/file-posix: verify page cache is not used

2018-04-19 Thread Stefan Hajnoczi
On Thu, Apr 19, 2018 at 10:05:47AM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > This commit is for debugging only. Do not merge it. > > > > mincore(2) checks whether pages are resident. Use it to verify that > > page cache has been dropped. > > > > Y

Re: [Qemu-devel] [virtio-dev] RE: [PATCH v3 6/6] vhost-user: support registering external host notifiers

2018-04-19 Thread Liang, Cunming
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Friday, April 20, 2018 12:56 AM > To: Liang, Cunming > Cc: Paolo Bonzini ; Bie, Tiwei ; > jasow...@redhat.com; alex.william...@redhat.com; stefa...@redhat.com; > qemu-devel@nongnu.org; virtio-...@lists.oasis

Re: [Qemu-devel] [PATCH] docker: Rename the amd64 image as amd64-cross

2018-04-19 Thread Fam Zheng
On Thu, 04/19 23:40, Philippe Mathieu-Daudé wrote: > Like the other images, this one is also used to cross-compile. > Name it accordingly, matching directory pattern. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/Makefile.include | 2 +- > .../{

Re: [Qemu-devel] [PATCH v2 31/43] tests/tcg: enable building for MIPS

2018-04-19 Thread Philippe Mathieu-Daudé
On 04/19/2018 02:58 PM, Peter Maydell wrote: > On 19 April 2018 at 18:49, Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: >>> On 04/19/2018 10:58 AM, Alex Bennée wrote: This doesn't add any additional tests but enables building the multiarch tests for MIPS using docker cross compil

Re: [Qemu-devel] [PATCH v2 09/43] docker: extend "cc" command to accept compiler

2018-04-19 Thread Philippe Mathieu-Daudé
On 04/19/2018 10:58 AM, Alex Bennée wrote: > When calling our cross-compilation images we want to call something > other than the default cc. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé > > --- > v2 > - use arg.cc default to simplify logic > --- > tests/docker/docker

[Qemu-devel] [PATCH] docker: Rename the amd64 image as amd64-cross

2018-04-19 Thread Philippe Mathieu-Daudé
Like the other images, this one is also used to cross-compile. Name it accordingly, matching directory pattern. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 2 +- .../{debian-amd64.docker => debian-amd64-cross.docker} | 0 2

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-19 Thread Philippe Mathieu-Daudé
> It seems I can't even build fp-test for x86_64. > > CROSS-BUILD x86_64 guest-tests with cc > In file included from /home/rth/work/qemu/qemu/tests/fp/fp-test.c:14:0: > /home/rth/work/qemu/qemu/include/qemu/osdep.h:30:10: fatal error: > config-host.h: No such file or directory > #include "confi

Re: [Qemu-devel] [PATCH v2] QemuMutex: support --enable-debug-mutex

2018-04-19 Thread Peter Xu
On Thu, Apr 19, 2018 at 03:43:01PM -0400, Emilio G. Cota wrote: > On Thu, Apr 19, 2018 at 11:13:35 +0800, Peter Xu wrote: > > On Thu, Apr 19, 2018 at 09:56:31AM +0800, Fam Zheng wrote: > (snip) > > > > @@ -12,6 +12,10 @@ typedef QemuMutex QemuRecMutex; > > > > > > > > struct QemuMutex { > > > >

Re: [Qemu-devel] vnc: heap-use-after-free in vnc_client_io() after vnc_disconnect_finish()

2018-04-19 Thread Philippe Mathieu-Daudé
On 04/19/2018 09:39 PM, Philippe Mathieu-Daudé wrote: > On 04/19/2018 01:40 PM, Daniel P. Berrangé wrote: >> On Thu, Apr 19, 2018 at 06:37:12PM +0200, Marc-André Lureau wrote: >>> On Tue, Apr 17, 2018 at 7:52 PM, Philippe Mathieu-Daudé >>> wrote: running commit ce8d4082054519f2eaac39958edde5

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-19 Thread Fam Zheng
On Thu, 04/19 14:58, Alex Bennée wrote: > Hi, > > This is the second revision of my attempt to revive the tests/tcg > directory. You can find the first iteration here: > > https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg01361.html Thanks for taking over! I cannot review all the patche

Re: [Qemu-devel] [PATCH v2 01/43] docker: add "probe" command for configure

2018-04-19 Thread Fam Zheng
On Thu, 04/19 14:58, Alex Bennée wrote: > From: Peter Maydell > > This is a helper function for the configure script. It replies yes, > sudo or no to inform the user if non-interactive docker support is > available. We trap the Exception to fail gracefully. > > Signed-off-by: Alex Bennée > ---

Re: [Qemu-devel] [PATCH v2 09/43] docker: extend "cc" command to accept compiler

2018-04-19 Thread Fam Zheng
On Thu, 04/19 14:58, Alex Bennée wrote: > When calling our cross-compilation images we want to call something > other than the default cc. > > Signed-off-by: Alex Bennée > Reviewed-by: Fam Zheng

Re: [Qemu-devel] [sw-dev] The problem of write misa on QEMU and BBL

2018-04-19 Thread Zong Li
2018-04-20 8:05 GMT+08:00 Michael Clark : > > > On Thu, Apr 19, 2018 at 9:28 PM, Zong Li wrote: >> >> 2018-04-19 12:43 GMT+08:00 Michael Clark : >> > Hi Zong, >> > >> >> On 19/04/2018, at 2:40 PM, Zong Li wrote: >> >> >> >> Hi all, >> >> >> >> For BBL part, in fp_init at machine/minit.c, >> >> it

Re: [Qemu-devel] [sw-dev] The problem of write misa on QEMU and BBL

2018-04-19 Thread Zong Li
2018-04-20 8:11 GMT+08:00 Andrew Waterman : > > > On Thu, Apr 19, 2018 at 5:05 PM, Michael Clark wrote: >> >> >> >> On Thu, Apr 19, 2018 at 9:28 PM, Zong Li wrote: >>> >>> 2018-04-19 12:43 GMT+08:00 Michael Clark : >>> > Hi Zong, >>> > >>> >> On 19/04/2018, at 2:40 PM, Zong Li wrote: >>> >> >>>

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-19 Thread David Gibson
On Thu, 19 Apr 2018 10:09:30 +0200 Laszlo Ersek wrote: > On 04/19/18 02:09, David Gibson wrote: > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > > Thank you -- I will replace SLOF with "openfirmware". > > This also implies I shouldn't add "ope

Re: [Qemu-devel] [PATCH v1 2/2] riscv: htif: increase the priority of the htif subregion

2018-04-19 Thread Michael Clark
On Wed, Apr 18, 2018 at 10:16 PM, KONRAD Frederic < frederic.kon...@adacore.com> wrote: > The htif device is supposed to be mapped over an other subregion. So > increase > its priority to one to avoid any conflict. > > Here is the output of info mtree: > > Before: > (qemu) info mtree > address-sp

Re: [Qemu-devel] vnc: heap-use-after-free in vnc_client_io() after vnc_disconnect_finish()

2018-04-19 Thread Philippe Mathieu-Daudé
On 04/19/2018 01:40 PM, Daniel P. Berrangé wrote: > On Thu, Apr 19, 2018 at 06:37:12PM +0200, Marc-André Lureau wrote: >> On Tue, Apr 17, 2018 at 7:52 PM, Philippe Mathieu-Daudé >> wrote: >>> running commit ce8d4082054519f2eaac39958edde502860a7fc6: >>> >>> qemu-system-mips -M malta -m 512 \ >>>

Re: [Qemu-devel] [sw-dev] The problem of write misa on QEMU and BBL

2018-04-19 Thread Michael Clark
On Fri, Apr 20, 2018 at 12:12 PM, Andrew Waterman wrote: > > > On Thu, Apr 19, 2018 at 5:11 PM, Michael Clark wrote: > >> >> >> On Fri, Apr 20, 2018 at 12:05 PM, Michael Clark wrote: >> >>> >>> >>> On Thu, Apr 19, 2018 at 9:28 PM, Zong Li wrote: >>> 2018-04-19 12:43 GMT+08:00 Michael Clar

Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > I did start playing with crosstool-ng and Linaro's own ABE scripts but > realised this could end up a massive time sync. What would be really > helpful is if the respective maintainers could encode their EXACT > STEPS for building their cross compilers i

Re: [Qemu-devel] [sw-dev] The problem of write misa on QEMU and BBL

2018-04-19 Thread Michael Clark
On Fri, Apr 20, 2018 at 12:05 PM, Michael Clark wrote: > > > On Thu, Apr 19, 2018 at 9:28 PM, Zong Li wrote: > >> 2018-04-19 12:43 GMT+08:00 Michael Clark : >> > Hi Zong, >> > >> >> On 19/04/2018, at 2:40 PM, Zong Li wrote: >> >> >> >> Hi all, >> >> >> >> For BBL part, in fp_init at machine/min

Re: [Qemu-devel] [sw-dev] The problem of write misa on QEMU and BBL

2018-04-19 Thread Michael Clark
On Thu, Apr 19, 2018 at 9:28 PM, Zong Li wrote: > 2018-04-19 12:43 GMT+08:00 Michael Clark : > > Hi Zong, > > > >> On 19/04/2018, at 2:40 PM, Zong Li wrote: > >> > >> Hi all, > >> > >> For BBL part, in fp_init at machine/minit.c, > >> it will clear the D and F bits of misa register, and assertio

[Qemu-devel] [PATCH] hw/char/cmsdk-apb-uart.c: Accept more input after character read

2018-04-19 Thread Patrick Oppenlander
The character frontend needs to be notified that the uart receive buffer is empty and ready to handle another character. Previously, the uart only worked correctly when receiving one character at a time. Signed-off-by: Patrick Oppenlander --- hw/char/cmsdk-apb-uart.c | 1 + 1 file changed, 1 in

Re: [Qemu-devel] [PATCH] riscv: requires libfdt

2018-04-19 Thread Michael Clark
On Fri, Apr 20, 2018 at 4:56 AM, Philippe Mathieu-Daudé wrote: > > On 04/19/2018 12:51 PM, KONRAD Frederic wrote: > >> When compiling on a machine without libfdt installed the configure > script > >> should try to get libfdt from the git or should die because otherwise > >> CONFIG_LIBFDT is not s

Re: [Qemu-devel] [PATCH v1 5/5] target-microblaze: mmu: Make the TLBX MISS bit read-only

2018-04-19 Thread Alistair Francis
On Thu, Apr 19, 2018 at 4:21 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Make the TLBX MISS bit read-only. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > target/microblaze/mmu.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH v1 4/5] target-microblaze: mmu: Make TLBSX write-only

2018-04-19 Thread Alistair Francis
On Thu, Apr 19, 2018 at 4:21 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Make TLBSX write-only and guest-error log reads from it. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > target/microblaze/mmu.c | 5 - > 1 file changed, 4 inser

Re: [Qemu-devel] [PATCH v3 6/6] vhost-user: support registering external host notifiers

2018-04-19 Thread Liang, Cunming
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Friday, April 20, 2018 1:01 AM > To: Liang, Cunming > Cc: Paolo Bonzini ; Bie, Tiwei ; > jasow...@redhat.com; alex.william...@redhat.com; stefa...@redhat.com; > qemu-devel@nongnu.org; virtio-...@lists.oasis-

Re: [Qemu-devel] [PATCH v2 5/7] blockdev: refactor block-dirty-bitmap-clear transaction

2018-04-19 Thread John Snow
On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: > bdrv_clear_dirty_bitmap do not fail, so we can call it in transaction > commit, avoiding any rollback. > > After this, bdrv_undo_clear_dirty_bitmap() becomes unused, so, drop it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > ---

Re: [Qemu-devel] [PATCH v2 6/7] block/dirty-bitmap: bdrv_clear_dirty_bitmap: drop unused parameter

2018-04-19 Thread John Snow
On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: > Drop parameter "HBitmap **out" which is unused now, all callers set > it to NULL. > > Signed-off-by: Vladimir Sementsov-Ogievskiy And now this patch is in question too.

Re: [Qemu-devel] [PATCH v2] QemuMutex: support --enable-debug-mutex

2018-04-19 Thread Emilio G. Cota
On Thu, Apr 19, 2018 at 15:43:01 -0400, Emilio G. Cota wrote: > BTW you might also want to add the file/line pair to > qemu-thread-win32.c, or hide the configure option to Windows > users. A few other call sites are missing as well, e.g. when returning from pthread_cond_wait or with _trylock. If

Re: [Qemu-devel] [PATCH v2 5/7] blockdev: refactor block-dirty-bitmap-clear transaction

2018-04-19 Thread John Snow
On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: > bdrv_clear_dirty_bitmap do not fail, so we can call it in transaction > commit, avoiding any rollback. > > After this, bdrv_undo_clear_dirty_bitmap() becomes unused, so, drop it. > I'm trying to remember why we ever bothered doing i

Re: [Qemu-devel] [PATCH RFC 14/14] qapi: Add #if conditions to commands, events, types, visitors

2018-04-19 Thread Eric Blake
On 02/23/2018 12:13 PM, Markus Armbruster wrote: [reviving this RFC] > > For what it's worth, I disliked the decorator magic enough to write this > series. > >>Furthermore, I don't fancy much having to redo and tune >> the generation *again* to fix the inden, extra-spaces etc th

[Qemu-devel] [PATCH v2 1/2] qapi: Rename QMP and QGA schema files

2018-04-19 Thread Eric Blake
Having two files in the tree both named qapi-schema.json just adds confusion. Rename these files to {qmp,qga}-schema to make it obvious which schema is in effect, and relocate qga into the common qapi/ subdirectory. Update all build rules that refer to the file names, and adjust other documentati

[Qemu-devel] [PATCH v2 0/2] QAPI file renames

2018-04-19 Thread Eric Blake
v1 was here: https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02877.html Since then: rebase to master, drop patch that has already been incorporated Eric Blake (2): qapi: Rename QMP and QGA schema files qapi: Rename .json to .qapi docs/devel/blkdebug.txt|

Re: [Qemu-devel] [PATCH 2/2] Revert "Revert "mux: fix ctrl-a b again"" again

2018-04-19 Thread Marc-André Lureau
Hi On Fri, Apr 20, 2018 at 12:09 AM, Philippe Mathieu-Daudé wrote: > This reverts commit 6f660996f1623034344cc37a1d430099067b755b to > reintroduce commit 1b2503fcf7b5932c5a3779ca2ceb92bd403c4ee7. > > Signed-off-by: Philippe Mathieu-Daudé I think we agreed this would go after 2.12. I was going

[Qemu-devel] [PATCH 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be

2018-04-19 Thread Philippe Mathieu-Daudé
4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent use of Chardev->be. Also, this CharBackend member is private and is not supposed to be accessible. Fix it by removing the inconsistent check. Reported-by: Marc-André Lureau Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa

[Qemu-devel] [PATCH 2/2] Revert "Revert "mux: fix ctrl-a b again"" again

2018-04-19 Thread Philippe Mathieu-Daudé
This reverts commit 6f660996f1623034344cc37a1d430099067b755b to reintroduce commit 1b2503fcf7b5932c5a3779ca2ceb92bd403c4ee7. Signed-off-by: Philippe Mathieu-Daudé --- chardev/char-mux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/chardev/char-mux.c b/chardev/char-mux.c index 1b925c8dec..

[Qemu-devel] [PATCH 0/2] hw/superio: Fix inconsistent use of Chardev->be

2018-04-19 Thread Philippe Mathieu-Daudé
My commit cd9526ab7c0 break something in the chardev frontend (serial). Also 4c3119a6e3e does the same with the parallel device. Fix the broken code and restore Marc-André patch which fixes the ctrl-a+b. Tested with my usual setup. Philippe Mathieu-Daudé (2): hw/isa/superio: Fix inconsistent us

Re: [Qemu-devel] [PATCH v2 42/43] tests/tcg: disable fp-test for 32 bit (HACK!)

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:59 AM, Alex Bennée wrote: > +ifneq (,$(findstring 64,$(TARGET_NAME))) You're only considering aarch64, x86_64, ppc64 and the like. This fails for alpha, s390x and the like. r~

Re: [Qemu-devel] [PATCH v2 38/43] osdep: disable glib-compat.h include with QEMU_NO_GLIB

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > To ease the cross-compilation of tests that do not use glib. > > Signed-off-by: Emilio G. Cota > --- > include/qemu/osdep.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 4/7] dirty-bitmap: separate unused meta-bitmap related functions

2018-04-19 Thread John Snow
On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: > Separate them in the header and clarify needed locking in comments. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/dirty-bitmap.h | 14 +- > block/dirty-bitmap.c | 5 + > 2 files changed

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-19 Thread Eduardo Habkost
On Thu, Apr 19, 2018 at 11:32:16PM +0200, Paolo Bonzini wrote: > On 19/04/2018 21:56, Eduardo Habkost wrote: > > On Thu, Apr 19, 2018 at 05:48:57PM +0200, Paolo Bonzini wrote: > >> On 17/04/2018 22:59, Eduardo Habkost wrote: > +if (disable_exits) { > +disable_exits &=

Re: [Qemu-devel] [PATCH v2 39/43] softfloat: do not include glib headers

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > To ease the cross-compilation of softfloat.o. > > Signed-off-by: Emilio G. Cota > --- > fpu/softfloat.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 03/43] configure: add support for --cross-cc-FOO

2018-04-19 Thread Eric Blake
On 04/19/2018 08:58 AM, Alex Bennée wrote: > This allows us to specify cross compilers for our guests. This is > useful for building test images/programs. Currently we re-run the > compile test for each target. I couldn't think of a way to cache the > value for a given arch without getting messier

Re: [Qemu-devel] [PATCH v3 3/4] qdev: Simplify the SysBusDeviceClass::init path

2018-04-19 Thread Philippe Mathieu-Daudé
On 04/19/2018 06:27 PM, Philippe Mathieu-Daudé wrote: > The SysBusDevice is the last DeviceClass::init user. > > Instead of using > SysBusDeviceClass::realize >-> DeviceClass::realize >-> DeviceClass::init >-> sysbus_device_init > -> SysBusDeviceClass::init

Re: [Qemu-devel] [PATCH v3 0/4] qdev: remove DeviceClass::init/exit()

2018-04-19 Thread Philippe Mathieu-Daudé
On 04/19/2018 06:27 PM, Philippe Mathieu-Daudé wrote: > Since v2: > - rebased for 2.13 (Markus) > - dropped 2 patches already merged (Gerd) > - start sentences with a capital letter and end with a full stop (Peter) I forgot to put the backport-diff, in case someone already reviewed v2: [---

Re: [Qemu-devel] [PATCH v2 26/43] tests/tcg/arm: fix up test-arm-iwmmxt test

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > +test-arm-iwmmxt: CFLAGS+=-marm -march=iwmmxt -mabi=aapcs > +test-arm-iwmmxt: test-arm-iwmmxt.S This appears to be insufficient. If I begin with armv7l-linux-gnueabihf-gcc, then I get CROSS-BUILD arm guest-tests with armv7l-linux-gnueabihf-gcc cc1: e

Re: [Qemu-devel] [PATCH v2 03/43] configure: add support for --cross-cc-FOO

2018-04-19 Thread Eric Blake
On 04/19/2018 03:47 PM, Richard Henderson wrote: > On 04/19/2018 10:41 AM, Richard Henderson wrote: >> On 04/19/2018 03:58 AM, Alex Bennée wrote: >>> + --cross-cc-*) cc_arch=${opt#--cross-cc-} >>> +eval "cross_cc_${cc_arch}=\$optarg" >> >> This doesn't work as intended. >> >> Given

Re: [Qemu-devel] [PATCH v2 25/43] tests/tcg: move ARM specific tests into subdir

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > These only need to be built for ARM guests. > > Signed-off-by: Alex Bennée > Reviewed-by: Thomas Huth > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > --- > v2 > - do VPATH manipulation in tests/tcg/arm/Makefile.target >

Re: [Qemu-devel] [PATCH v2 24/43] tests/tcg/i386/test-i386: fix printf format

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > tests/tcg/i386/test-i386.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v3 4/4] qdev: Remove DeviceClass::exit

2018-04-19 Thread Philippe Mathieu-Daudé
Since no devices use it, we can safely remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/qdev-core.h | 2 -- hw/core/qdev.c | 14 -- 2 files changed, 16 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 6f60748043..88b52be8fb 1006

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-19 Thread Paolo Bonzini
On 19/04/2018 21:56, Eduardo Habkost wrote: > On Thu, Apr 19, 2018 at 05:48:57PM +0200, Paolo Bonzini wrote: >> On 17/04/2018 22:59, Eduardo Habkost wrote: +if (disable_exits) { +disable_exits &= (KVM_X86_DISABLE_EXITS_MWAIT | + KVM_X8

[Qemu-devel] [PATCH v3 3/4] qdev: Simplify the SysBusDeviceClass::init path

2018-04-19 Thread Philippe Mathieu-Daudé
The SysBusDevice is the last DeviceClass::init user. Instead of using SysBusDeviceClass::realize -> DeviceClass::realize -> DeviceClass::init -> sysbus_device_init -> SysBusDeviceClass::init Simplify the path by directly calling SysBusDeviceClass::init in SysB

[Qemu-devel] [PATCH v3 1/4] hw/i2c/smbus: Use DeviceClass::realize instead of SMBusDeviceClass::init

2018-04-19 Thread Philippe Mathieu-Daudé
SMBusDeviceClass::init is no more used, remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i2c/smbus.h | 1 - hw/i2c/smbus.c | 9 - hw/i2c/smbus_eeprom.c | 5 ++--- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/include/hw/i2c/smbus.h b/include/hw/i

Re: [Qemu-devel] [PATCH v2 23/43] tests/tcg/i386/test-i386: use modern vector_size attributes

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > The compiler complains about the old __mode__ style attributes. > > Signed-off-by: Alex Bennée > --- > tests/tcg/i386/test-i386.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v3 2/4] hw/i2c: Use DeviceClass::realize instead of I2CSlaveClass::init

2018-04-19 Thread Philippe Mathieu-Daudé
I2CSlaveClass::init is no more used, remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h| 3 --- hw/audio/wm8750.c | 8 +++- hw/display/ssd0303.c| 9 - hw/gpio/max7310.c | 9 - hw/i2c/core.c | 13 - hw/input/

[Qemu-devel] [PATCH v3 0/4] qdev: remove DeviceClass::init/exit()

2018-04-19 Thread Philippe Mathieu-Daudé
Since v2: - rebased for 2.13 (Markus) - dropped 2 patches already merged (Gerd) - start sentences with a capital letter and end with a full stop (Peter) since v1: - fix format string on 32-bit host (patchew) - do not add smbus_eeprom_reset() (Eduardo) - directly use DeviceClass::realiz

Re: [Qemu-devel] [PATCH v2 19/43] tests/tcg/i386: fix test-i386

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > The test-i386 test case is a little special as it includes assembler > files. Add the additional compile magic to assemble these bits and > link them to the final binary. > > Signed-off-by: Alex Bennée > Reviewed-by: Thomas Huth > Reviewed-by: Philipp

Re: [Qemu-devel] [PATCH v2 18/43] tests/tcg/i386: Build fix for hello-i386

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > From: Fam Zheng > > We have -Werror=missing-prototype, add a dummy prototype to avoid that > warning. > > Signed-off-by: Fam Zheng > Reviewed-by: Thomas Huth > --- > tests/tcg/i386/hello-i386.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by:

Re: [Qemu-devel] [PATCH v2 14/43] tests/tcg/multiarch: enable additional linux-test tests

2018-04-19 Thread Richard Henderson
On 04/19/2018 03:58 AM, Alex Bennée wrote: > Un-comment the remaining tests. I removed the itimer value tests > because I'm fairly sure a re-arming timer will always have a different > value in it when you grab it. > > Signed-off-by: Alex Bennée > --- > tests/tcg/multiarch/linux-test.c | 20

Re: [Qemu-devel] [PATCH v2 3/7] dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header

2018-04-19 Thread John Snow
On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/dirty-bitmap.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h > index 1ff8949b1b..c7e910016d 1006

Re: [Qemu-devel] [PATCH v2 2/7] dirty-bitmaps: fix comment about dirty_bitmap_mutex

2018-04-19 Thread John Snow
On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: > Clarify first two cases and fix Modify -> Any access in third case. > Also, drop 'only' from third case, as it a bit confuses, when thinking > about case where we modify BdrvDirtyBitmap and access HBitmap. > > Signed-off-by: Vladimir

  1   2   3   4   5   >