[Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

2018-04-15 Thread Thomas Huth
It's been marked as deprecated since QEMU v2.9.0, so that should have been enough time for everybody to either just drop unnecessary "vlan=0" parameters, to switch to the modern -device + -netdev syntax for connecting guest NICs with host network backends, or to switch to the "hubport" netdev in ca

[Qemu-devel] [PATCH v3 for-2.13 2/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the source files

2018-04-15 Thread Thomas Huth
'vlan' is very confusing since it does not mean something like IEEE 802.1Q, but rather emulated hubs, so let's switch to that terminology instead. Buglink: https://bugs.launchpad.net/qemu/+bug/658904 Signed-off-by: Thomas Huth --- net/hub.c | 7 +++ net/slirp.c | 8 net/tap.c |

[Qemu-devel] [PATCH v3 for-2.13 3/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the doc files

2018-04-15 Thread Thomas Huth
'vlan' is very confusing since it does not mean something like IEEE 802.1Q, but rather emulated hubs, so let's switch to that terminology instead. While we're at it, move the subsection about hub a little bit downward in the documentation (it's not as important anymore as it was before the inventio

[Qemu-devel] [PATCH v3 for-2.13 0/3] net: Get rid of 'vlan'

2018-04-15 Thread Thomas Huth
The 'vlan' term caused a lot of confusion and misconfigurations in the past. The parameter has been marked as deprecated since QEMU v2.9.0, so it's now time to finally remove the parameter and use the better word "hub" in the remaining spots that actually mean the QEMU emulated hub feature. v3: -

Re: [Qemu-devel] [PATCH v3 27/41] hw/lm32: Use the BYTE-based definitions

2018-04-15 Thread Michael Walle
Am 2018-04-16 01:42, schrieb Philippe Mathieu-Daudé: It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle

Re: [Qemu-devel] [Consult] nfs-vsocks support

2018-04-15 Thread Liu, Jing2
On 4/4/2018 5:45 PM, Stefan Hajnoczi wrote: On Wed, Mar 28, 2018 at 07:25:21PM +0800, Liu, Jing2 wrote: On 3/26/2018 6:12 PM, Liu, Jing2 wrote: Hi Stefan, Thank you very much for the response! It truly gave me much help. On 3/24/2018 12:02 AM, Stefan Hajnoczi wrote: [...] Could you give m

Re: [Qemu-devel] [PATCH 3/4] pc-bios/s390-ccw: fix non-sequential boot entries (eckd)

2018-04-15 Thread Thomas Huth
On 14.04.2018 00:08, Collin Walling wrote: > zIPL boot menu entries can be non-sequential. Let's account > for this issue for the s390 zIPL boot menu. Since this boot > menu is actually an imitation and is not completely capable > of everything the real zIPL menu can do, let's also print a > differ

Re: [Qemu-devel] [PATCH v3 33/41] hw/net: Use the BYTE-based definitions

2018-04-15 Thread Stefan Weil
Am 16.04.2018 um 01:42 schrieb Philippe Mathieu-Daudé: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/n

Re: [Qemu-devel] [PATCH for-2.12? 1/4] configure: Really use local libfdt if the system one is too old

2018-04-15 Thread Thomas Huth
On 16.04.2018 01:05, Philippe Mathieu-Daudé wrote: > QEMU requires libfdt version >= 1.4.2. > If the host has an older libfdt installed, the configure script will use > a (git cloned) local version. > > Example with Debian 8: > $ dpkg-query --showformat='${Version}\n' --show libfdt-dev > 1

Re: [Qemu-devel] [PATCH 2/4] configure: Display if libfdt is from system or git

2018-04-15 Thread Thomas Huth
On 16.04.2018 01:05, Philippe Mathieu-Daudé wrote: > The configure script outputs "yes" regardless which libfdt is used: > > ./configure > [...] > fdt support yes > > Sometimes you can have both system and local git version available, > change the configure script to display which lib

Re: [Qemu-devel] [PATCH v3 17/41] hw/m68k: Use the BYTE-based definitions

2018-04-15 Thread Thomas Huth
On 16.04.2018 01:42, Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/m68k/mcf5208.

Re: [Qemu-devel] [PATCH v3 01/41] hw: Clean "hw/devices.h" includes

2018-04-15 Thread Thomas Huth
On 16.04.2018 01:42, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/devices.h | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/include/hw/devices.h b/include/hw/devices.h > index 861ddea8af..0e27feb0c2 100644 > --- a/includ

[Qemu-devel] [Bug 1461918] Re: guest hangs after use ethtool to set scatter-gather on

2018-04-15 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1461918 Title: guest hangs

Re: [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier

2018-04-15 Thread David Gibson
On Thu, Apr 12, 2018 at 06:40:19PM +0200, Igor Mammedov wrote: > platform-bus were using machine_done notifier to get and map > (assign irq/mmio resources) dynamically added sysbus devices > after all '-device' options had been processed. > That however creates non obvious dependencies on ordering

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-04-15 Thread David Gibson
On Thu, Apr 12, 2018 at 10:36:10AM +0200, Cédric Le Goater wrote: > On 04/12/2018 07:16 AM, David Gibson wrote: > > On Mon, Feb 12, 2018 at 09:55:17AM +1100, Benjamin Herrenschmidt wrote: > >> On Sun, 2018-02-11 at 19:08 +1100, David Gibson wrote: > >>> On Thu, Jan 18, 2018 at 08:27:52AM +1100, Ben

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-04-15 Thread David Gibson
On Thu, Apr 12, 2018 at 10:18:11AM +0200, Cédric Le Goater wrote: > On 04/12/2018 07:07 AM, David Gibson wrote: > > On Wed, Dec 20, 2017 at 08:38:41AM +0100, Cédric Le Goater wrote: > >> On 12/20/2017 06:09 AM, David Gibson wrote: > >>> On Sat, Dec 09, 2017 at 09:43:21AM +0100, Cédric Le Goater wro

Re: [Qemu-devel] [PATCH v3 38/41] hw/rdma: Use the BYTE-based definitions

2018-04-15 Thread Marcel Apfelbaum
On 16/04/2018 2:43, Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rdma/vmw/pvrdm

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m

2018-04-15 Thread Philippe Mathieu-Daudé
Hi Michael, On 04/14/2018 11:27 AM, Michael Tokarev wrote: > Signed-off-by: Michael Tokarev > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 727ef118f3..8644c2e918 100644 > --- a/Makefile > +++ b/Makefile > @@ -856,7 +856,7 @@

Re: [Qemu-devel] [PATCH for 2.13 v3 12/20] linux-user: move tilegx signal.c parts to tilegx directory

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/11/2018 03:45 PM, Laurent Vivier wrote: > No code change, only move code from signal.c to > tilegx/signal.c, except adding includes and > exporting setup_rt_frame(). > > Signed-off-by: Laurent Vivier > Reviewed-by: Alex Bennée > Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathie

Re: [Qemu-devel] [PATCH for 2.13 v2 11/19] linux-user: move cris cpu loop to cris directory

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/11/2018 03:56 PM, Laurent Vivier wrote: > No code change, only move code from main.c to > cris/cpu_loop.c. > > Signed-off-by: Laurent Vivier > Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > > Notes: > v2: expand tabs > > linux-user/cris/cpu_loop.c | 89

Re: [Qemu-devel] [PATCH for 2.13 v2 12/19] linux-user: move microblaze cpu loop to microblaze directory

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/11/2018 03:56 PM, Laurent Vivier wrote: > No code change, only move code from main.c to > microblaze/cpu_loop.c. > > Signed-off-by: Laurent Vivier > Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > > Notes: > v2: expand tabs > > linux-user/main.c

Re: [Qemu-devel] [PATCH for 2.13 v2 15/19] linux-user: move s390x cpu loop to s390x directory

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/11/2018 03:56 PM, Laurent Vivier wrote: > No code change, only move code from main.c to > s390x/cpu_loop.c. > > Signed-off-by: Laurent Vivier > Reviewed-by: Richard Henderson > Acked-by: Cornelia Huck Reviewed-by: Philippe Mathieu-Daudé > --- > linux-user/main.c | 146 > ---

Re: [Qemu-devel] [PATCH for 2.13 v2 17/19] linux-user: move riscv cpu loop to riscv directory

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/11/2018 03:56 PM, Laurent Vivier wrote: > No code change, only move code from main.c to > riscv/cpu_loop.c. > > Signed-off-by: Laurent Vivier > Reviewed-by: Richard Henderson > Reviewed-by: Michael Clark Reviewed-by: Philippe Mathieu-Daudé > --- > linux-user/main.c | 101 >

Re: [Qemu-devel] [PATCH for 2.13 v2 10/19] linux-user: move sh4 cpu loop to sh4 directory

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/11/2018 03:56 PM, Laurent Vivier wrote: > No code change, only move code from main.c to > sh4/cpu_loop.c. > > Signed-off-by: Laurent Vivier > Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > > Notes: > v2: expand tabs > > linux-user/main.c | 90

Re: [Qemu-devel] [PATCH for 2.13 v2 05/19] linux-user: move sparc/sparc64 cpu loop to sparc directory

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/11/2018 03:56 PM, Laurent Vivier wrote: > No code change, only move code from main.c to > sparc/cpu_loop.c. > > Include sparc/cpu_loop.c in sparc64/cpu_loop.c > to avoid to duplicate code. > > Signed-off-by: Laurent Vivier > Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Da

Re: [Qemu-devel] [PATCH v1 02/24] configure: add support for --cross-cc-FOO

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:38 PM, Alex Bennée wrote: > This allows us to specify cross compilers for our guests. This is > useful for building test images/programs. Currently we re-run the > compile test for each target. I couldn't think of a way to cache the > value for a given arch without getting messier

Re: [Qemu-devel] [PATCH v1 24/24] tests/Makefile.include: add (clean-)check-tcg targets

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > This will ensure all linux-user targets build their guest test > programs. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/Makefile.include | 19 ++- > 1 file chang

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > Now all the build infrastructure is in place we can build tests for > each guest that we support. That support mainly depends on having > cross compilers installed or docker setup. To keep all the logic for > that together we put the rules in tests/tcg/M

Re: [Qemu-devel] [PATCH v1 05/24] docker: Add "cc" subcommand

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > From: Fam Zheng > > Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/docker/docker.py | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/tests/docker/dock

Re: [Qemu-devel] [PATCH v1 21/24] tests/tcg: enable building for ppc64

2018-04-15 Thread Philippe Mathieu-Daudé
Hi Alex, On 04/10/2018 04:39 PM, Alex Bennée wrote: > Currently this just enables building the multiarch tests. > > Signed-off-by: Alex Bennée "make tcg-tests-ppc64-linux-user" works indeed. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Do we care about ppc[32]? > -

Re: [Qemu-devel] [PATCH v1 20/24] tests/tcg: enable building for s390x

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > This doesn't add any additional tests but enables building the > multiarch tests for s390x. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/tcg/s390x/Makefile.include | 2 ++ > 1 f

Re: [Qemu-devel] [PATCH v1 19/24] tests/tcg: move MIPS specific tests into subdir

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/15/2018 10:02 PM, Philippe Mathieu-Daudé wrote: > On 04/10/2018 04:39 PM, Alex Bennée wrote: >> These only need to be built for MIPS guests. >> >> Signed-off-by: Alex Bennée >> --- >> tests/tcg/README | 11 --- >> tests/tcg/mips/README | 7 +++ >> t

Re: [Qemu-devel] [PATCH v1 18/24] tests/tcg/arm: fix hello-arm

2018-04-15 Thread Philippe Mathieu-Daudé
Hi Alex, On 04/10/2018 04:39 PM, Alex Bennée wrote: > As hello-arm is a bare bones syscall test it needs specific compiler > flags so it doesn't try and link against glibc. > > Signed-off-by: Alex Bennée > --- > tests/tcg/arm/Makefile.target | 6 ++ > 1 file changed, 6 insertions(+) > crea

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

2018-04-15 Thread Philippe Mathieu-Daudé
Hi Alex, On 04/10/2018 04:39 PM, Alex Bennée wrote: > Now all the build infrastructure is in place we can build tests for > each guest that we support. That support mainly depends on having > cross compilers installed or docker setup. To keep all the logic for > that together we put the rules in t

Re: [Qemu-devel] [PATCH v1 19/24] tests/tcg: move MIPS specific tests into subdir

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > These only need to be built for MIPS guests. > > Signed-off-by: Alex Bennée > --- > tests/tcg/README | 11 --- > tests/tcg/mips/README | 7 +++ > tests/tcg/{ => mips}/hello-mips.c | 0 > 3 files changed, 7 in

Re: [Qemu-devel] [PATCH v1 14/24] tests/tcg/i386: fix test-i386

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > The test-i386 test case is a little special as it includes assembler > files. Add the additional compile magic to assemble these bits and > link them to the final binary. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: P

Re: [Qemu-devel] [PATCH v1 11/24] tests/tcg: move i386 specific tests into subdir

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > These only need to be built for i386 guests. This includes a stub > tests/tcg/i386/Makfile.target which absorbs some of what was in Mak[e]file > tests/tcg/Makefile. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phili

Re: [Qemu-devel] [PATCH v1 15/24] tests/tcg/i368: fix hello-i386

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > This is a direct syscall test so needs additional CFLAGS and LDFLAGS. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/tcg/i386/Makefile.target | 6 ++ > 1 file changed, 6 inser

Re: [Qemu-devel] [PATCH v1 07/24] docker: allow "cc" command to run in user context

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/docker/docker.py | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/docker/docker.py b/tests/docker/docker.py > index 9

Re: [Qemu-devel] [PATCH v1 09/24] tests/tcg: move architecture independent tests into subdir

2018-04-15 Thread Philippe Mathieu-Daudé
Hi Alex, On 04/10/2018 04:39 PM, Alex Bennée wrote: > We will want to build these for all supported guest architectures so > lets move them all into one place. We also drop test_path at this > point because it needs qemu utils and glib bits which is hard to > support for cross compiling. Can we k

[Qemu-devel] [PATCH v3 40/41] hw/loader: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/loader.h | 5 +++-- hw/core/loader-fit.c | 2 +- 2 files changed, 4 insertion

[Qemu-devel] [PATCH v3 41/41] cutils: Do not include "qemu/units.h" directly

2018-04-15 Thread Philippe Mathieu-Daudé
All files using "qemu/units.h" definitions already include it directly, we can now remove it from "qemu/cutils.h". Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/cutils.h | 1 - hw/core/machine.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/qemu/cutil

Re: [Qemu-devel] [PATCH v1 03/24] configure: move i386_cc to cross_cc_i386

2018-04-15 Thread Philippe Mathieu-Daudé
Hi Alex, On 04/10/2018 04:38 PM, Alex Bennée wrote: > We should still be able to use the system cross compiler with the > appropriate flags on x86_64 hosts. > > Signed-off-by: Alex Bennée > --- > configure | 23 +++ > 1 file changed, 15 insertions(+), 8 deletions(-) > > dif

[Qemu-devel] [PATCH v3 38/41] hw/rdma: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/rdma/vmw/pvrdma.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v3 34/41] hw/usb: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/ccid-card-passthru.c | 5 +++-- hw/usb/combined-packet.c | 3 ++- hw/usb/de

[Qemu-devel] [PATCH v3 36/41] hw/vfio: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/vfio/pci-quirks.c | 9 + hw/vfio/pci.c| 3 ++- 2 files changed, 7 inse

Re: [Qemu-devel] [PATCH v1 17/24] tests/tcg: move ARM specific tests into subdir

2018-04-15 Thread Philippe Mathieu-Daudé
On 04/10/2018 04:39 PM, Alex Bennée wrote: > These only need to be built for ARM guests. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/tcg/README | 9 - > tests/tcg/arm/README

[Qemu-devel] [PATCH v3 30/41] hw/arm: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- include/hw/arm/fsl-imx7.h | 5 +++-- include/hw/arm/

[Qemu-devel] [PATCH v3 27/41] hw/lm32: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/lm32_boards.c | 13 +++-- hw/lm32/milkymist.c | 10 +- 2 files

Re: [Qemu-devel] [PATCH v1 12/24] tests/tcg/i386: Build fix for hello-i386

2018-04-15 Thread Philippe Mathieu-Daudé
Hi Fam, Alex, On 04/10/2018 04:39 PM, Alex Bennée wrote: > From: Fam Zheng > > We have -Werror=missing-prototype, add a dummy prototype to avoid that > warning. > > Signed-off-by: Fam Zheng > --- > tests/tcg/i386/hello-i386.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/tcg

[Qemu-devel] [PATCH v3 28/41] hw/sh4: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/sh4/r2d.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sh4

[Qemu-devel] [PATCH v3 29/41] hw/mips: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/intc/mips_gic.h | 3 ++- include/hw/mips/bios.h | 3 ++- hw/mips/boston.

[Qemu-devel] [PATCH v3 25/41] hw/nios2: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/nios2/boot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[Qemu-devel] [PATCH v3 24/41] hw/microblaze: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/microblaze/petalogix_ml605_mmu.c | 7 --- hw/microblaze/petalogix_s3adsp1800_

[Qemu-devel] [PATCH v3 26/41] hw/cris: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/cris/axis_dev88.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v3 20/41] hw/hppa: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/hppa/dino.c| 3 ++- hw/hppa/machine.c | 10 +- 2 files changed, 7 inserti

[Qemu-devel] [PATCH v3 23/41] hw/tricore: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Bastian Koppelmann --- hw/tricore/tricore_testboard.c | 13 +++-- 1 file c

[Qemu-devel] [PATCH v3 22/41] hw/alpha: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/alpha/typhoon.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-

[Qemu-devel] [PATCH v3 17/41] hw/m68k: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/m68k/mcf5208.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/h

[Qemu-devel] [PATCH v3 39/41] hw/nvdimm: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/mem/nvdimm.h | 3 ++- hw/mem/nvdimm.c | 2 +- 2 files changed, 3 inser

[Qemu-devel] [PATCH v3 21/41] hw/xtensa: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Max Filippov --- hw/xtensa/xtfpga.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[Qemu-devel] [PATCH v3 13/41] hw/block: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/nvme.c| 3 ++- hw/block/tc58128.c | 3 ++- 2 files changed, 4 insertions(+),

[Qemu-devel] [PATCH v3 37/41] hw/virtio: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/virtio/virtio-net.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

[Qemu-devel] [PATCH v3 12/41] hw/tpm: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- include/hw/acpi/tpm.h | 3 ++- 1 file changed, 2 insertio

[Qemu-devel] [PATCH v3 19/41] hw/s390x: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Acked-by: Cornelia Huck --- hw/s390x/s390-skeys.c| 3 ++- hw/s

[Qemu-devel] [PATCH v3 11/41] hw/xen: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alan Robinson --- hw/block/xen_disk.c| 5 +++-- hw/i386/xen/xen-mapcac

[Qemu-devel] [PATCH v3 35/41] hw/sd: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c| 4 ++-- hw/sd/sdhci.c | 4 ++-- 2 files changed, 4 insertions(+), 4 delet

[Qemu-devel] [PATCH v3 09/41] hw/scsi: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-disk.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH v3 16/41] hw/riscv: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/riscv/virt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/

[Qemu-devel] [PATCH v3 10/41] hw/smbios: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH v3 06/41] cutils: Extract byte-based definitions into a new header: "qemu/units.h"

2018-04-15 Thread Philippe Mathieu-Daudé
(added in 076b35b5a56) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/qemu/cutils.h | 8 +--- include/qemu/units.h | 11 +++ 2 files changed, 12 insertions(+), 7 deletions(-) create mode 100644 include/qemu/units.

[Qemu-devel] [PATCH v3 33/41] hw/net: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/allwinner_emac.h | 5 +++-- hw/net/e1000e.c | 7 --- h

[Qemu-devel] [PATCH v3 15/41] hw/misc: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/auxbus.c | 3 ++- hw/misc/edu.c| 3 ++- 2 files changed, 4 insertions(+), 2 d

[Qemu-devel] [PATCH v3 07/41] hw/ivshmem: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- hw/misc/ivshmem.c | 3 ++- 1 file changed, 2 insertions(+

[Qemu-devel] [PATCH v3 03/41] hw/block/nvme: Include the "qemu/cutils.h" in the source file

2018-04-15 Thread Philippe Mathieu-Daudé
where it is used. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/block/nvme.h | 1 - hw/block/nvme.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.h b/hw/block/nvme.h index 8f3981121d..cabcf20c32 100644 --- a/hw/block/nvme.h +++ b/hw/bl

[Qemu-devel] [PATCH v3 18/41] hw/sparc: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/leon3.c | 9 + hw/sparc/sun4m.c | 9 - hw/sparc64/niagar

[Qemu-devel] [PATCH v3 08/41] hw/ipack: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alberto Garcia --- hw/ipack/tpci200.c | 5 +++-- 1 file changed, 3 insertions(+

[Qemu-devel] [PATCH v3 04/41] hw/misc/mips_itu: Sort includes

2018-04-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/mips_itu.h | 2 ++ hw/misc/mips_itu.c | 5 + 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/include/hw/misc/mips_itu.h b/include/hw/misc/mips_itu.h index b3a4532036..030eb4ac62 100644 --- a/include/hw/misc/mips_

[Qemu-devel] [PATCH v3 01/41] hw: Clean "hw/devices.h" includes

2018-04-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/devices.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/include/hw/devices.h b/include/hw/devices.h index 861ddea8af..0e27feb0c2 100644 --- a/include/hw/devices.h +++ b/include/hw/devices.h @@ -1,13 +1,10 @@ #ifnde

[Qemu-devel] [PATCH v3 02/41] hw: Do not include "sysemu/block-backend.h" if it is not necessary

2018-04-15 Thread Philippe Mathieu-Daudé
Remove those unneeded includes to speed up the compilation process a little bit. (Missed in 7eceff5b5a1fa) Signed-off-by: Philippe Mathieu-Daudé --- hw/cris/axis_dev88.c | 1 - hw/sh4/r2d.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c i

[Qemu-devel] [PATCH v3 05/41] hw/mips/r4k: Constify params_size

2018-04-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_r4k.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c index aeadc4a340..c26a44da06 100644 --- a/hw/mips/mips_r4k.c +++ b/hw/mips/mips_r4k.c @@ -80,8 +80,9 @@ typedef struct Res

[Qemu-devel] [PATCH v3 00/41] hw: Use the BYTE-based definitions when useful

2018-04-15 Thread Philippe Mathieu-Daudé
Hi, This series: - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.h" - clean hw/ includes; - replace different constants used for byte size with their corresponding BYTE-based definitions. Since v2: - use "qemu/units.h" instead of "qemu/cunits.h" (Daniel P. Berrangé) - av

[Qemu-devel] [PATCH 4/4] build: Silence dtc directory creation

2018-04-15 Thread Philippe Mathieu-Daudé
From: Jan Kiszka Align with other mkdir calls. Signed-off-by: Jan Kiszka Reviewed-by: Philippe Mathieu-Daudé Message-Id: <0dd4c8f5-d60e-e564-652f-cd0101f6e...@web.de> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 727ef118f3..fc6f210

[Qemu-devel] [PATCH 3/4] shippable: Remove Debian 8 libfdt kludge

2018-04-15 Thread Philippe Mathieu-Daudé
This kludge was added in a825ca06137, but a cleaner and more generic fix is now available (see ##COMMIT_CONFIGURE_LIBFDT_LDFLAGS_SHA##). Signed-off-by: Philippe Mathieu-Daudé --- If a maintainer take the whole series, I hope he'll be kind enough to update ##COMMIT_CONFIGURE_LIBFDT_LDFLAGS_SHA## w

[Qemu-devel] [PATCH 2/4] configure: Display if libfdt is from system or git

2018-04-15 Thread Philippe Mathieu-Daudé
The configure script outputs "yes" regardless which libfdt is used: ./configure [...] fdt support yes Sometimes you can have both system and local git version available, change the configure script to display which library got selected: debian8$ dpkg-query --showformat='${Version}\

[Qemu-devel] [PATCH for-2.12? 1/4] configure: Really use local libfdt if the system one is too old

2018-04-15 Thread Philippe Mathieu-Daudé
QEMU requires libfdt version >= 1.4.2. If the host has an older libfdt installed, the configure script will use a (git cloned) local version. Example with Debian 8: $ dpkg-query --showformat='${Version}\n' --show libfdt-dev 1.4.0+dfsg-1 $ ./configure [...] fdt support yes

[Qemu-devel] [PATCH 0/4] build: fix failure when host provides too old libfdt

2018-04-15 Thread Philippe Mathieu-Daudé
Hi, I already hit this problem on Shippable and tried to resolve it for 2.10; and shamefully hit it again yesterday on a Debian 8 host with distrib libfdt installed. I wondered how to fix this without root access and realized my previous Shippable kludge wasn't the best fix :) Here we go adding th

Re: [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-04-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1523819244-29954-1-git-send-email-akrow...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size

2018-04-15 Thread Philippe Mathieu-Daudé
>From the datasheet (3368J–SEEPR) description: The AT25128A/256A provides 131,072/262,144 bits of serial electrically-erasable programmable read only memory (EEPROM) organized as 16,384/32,768 words of 8 bits each. However QEMU models the flash size in bytes. Correct the at25128a/at252

[Qemu-devel] [PATCH v4 5/5] s390: doc: detailed specifications for AP virtualization

2018-04-15 Thread Tony Krowiak
This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak --- docs/vfio-ap.txt | 649 ++

[Qemu-devel] [PATCH v4 2/5] s390x/ap: base Adjunct Processor (AP) object

2018-04-15 Thread Tony Krowiak
This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 39 +++ include/hw/s390x/ap-device.h | 38 ++ ui/keycodemapdb

[Qemu-devel] [PATCH v4 4/5] s390x/vfio: ap: Introduce VFIO AP device

2018-04-15 Thread Tony Krowiak
Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated matrix device is created by the VFIO AP device driver by writing a UUID to a sysfs attribute f

[Qemu-devel] [PATCH v4 1/5] linux-headers: linux header updates for AP support

2018-04-15 Thread Tony Krowiak
Updates the linux header files in preparation for introduction of the VFIO AP device: * Added a feature ID to indicate AP facilities are installed * Added a device attribute to the KVM_S390_VM_CRYPTO group to indicate whether AP instructions are to be interpreted * Added VFIO device informatio

[Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-04-15 Thread Tony Krowiak
This patch series is the QEMU counterpart to the KVM/kernel support for guest dedicated crypto adapters. The KVM/kernel model is built on the VFIO mediated device framework and provides the infrastructure for granting exclusive guest access to crypto devices installed on the linux host. This pa

[Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

2018-04-15 Thread Tony Krowiak
A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP facilities are installed. This feature will be enabled by the kernel only if the AP facilitie

[Qemu-devel] [PULL 0/1] m68k fixes for 2.12-rc4

2018-04-15 Thread Laurent Vivier
The following changes since commit 38e83a71d02e026d4a6d0ab1ef9855c4924c2c68: Update version for v2.12.0-rc3 release (2018-04-11 19:03:24 +0100) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k-for-2.12-pull-request for you to fetch changes up to 000761

[Qemu-devel] [PULL 1/1] m68k: fix exception stack frame for 68000

2018-04-15 Thread Laurent Vivier
From: Pavel Dovgalyuk 68000 CPUs do not save format in the exception stack frame. This patch adds feature checking to prevent format saving for 68000. m68k_ret() already includes this modification, this patch fixes the exception processing function too. Signed-off-by: Pavel Dovgalyuk Reviewed-b