Re: [Qemu-devel] [PATCH v2] monitor: let cur_mon be per-thread

2018-04-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180412060358.9118-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v2] monitor: let cur_mon be per-thread === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git l

Re: [Qemu-devel] [PATCH 5/5] migration: disable RDMA WRITR after postcopy started.

2018-04-11 Thread 858585 jemmy
On Wed, Apr 11, 2018 at 11:56 PM, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: >> RDMA write operations are performed with no notification to the destination >> qemu, then the destination qemu can not wakeup. So disable RDMA WRITE after >> postcopy started. >> >> Si

[Qemu-devel] [Bug 1760262] Re: cmsdk-apb-uart doesn't appear to clear interrupt flags

2018-04-11 Thread Thomas Huth
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=6670b494fdb23f74ecd9b ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1760262 Title: c

[Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-11 Thread Peter Xu
In the future the monitor iothread may be accessing the cur_mon as well (via monitor_qmp_dispatch_one()). Before we introduce a real Out-Of-Band command, let's convert the cur_mon variable to be a per-thread variable to make sure there won't be a race between threads. Note that thread variables a

[Qemu-devel] [PATCH v2] monitor: let cur_mon be per-thread

2018-04-11 Thread Peter Xu
In the future the monitor iothread may be accessing the cur_mon as well (via monitor_qmp_dispatch_one()). Before we introduce a real Out-Of-Band command, let's convert the cur_mon variable to be a per-thread variable to make sure there won't be a race between threads. Note that thread variables a

[Qemu-devel] [PATCH v2] qemu-thread: always keep the posix wrapper layer

2018-04-11 Thread Peter Xu
We will conditionally have a wrapper layer depending on whether the host has the PTHREAD_SETNAME capability. It complicates stuff. Let's keep the wrapper there; we opt out the pthread_setname_np() call only. Signed-off-by: Peter Xu --- v2: - set thread name only conditionally [Eric] --- util/q

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: let cur_mon be per-thread

2018-04-11 Thread Peter Xu
On Wed, Apr 11, 2018 at 08:06:04AM -0500, Eric Blake wrote: > On 04/11/2018 04:48 AM, Peter Xu wrote: > > > Okay. :) Thanks for confirming. Then let me repost this patch without > > touching the qemu-threads. > > > > Btw, do you want me to repost the first patch separately too, or keep > > the c

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-04-11 Thread David Gibson
On Wed, Jan 17, 2018 at 10:18:43AM +0100, Cédric Le Goater wrote: > >>> Also, have we decided how the process of switching between XICS and > >>> XIVE will work vs. CAS ? > >> > >> That's how it is described in the architecture. The current choice is > >> to create both XICS and XIVE objects and c

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-04-11 Thread David Gibson
On Mon, Feb 12, 2018 at 09:55:17AM +1100, Benjamin Herrenschmidt wrote: > On Sun, 2018-02-11 at 19:08 +1100, David Gibson wrote: > > On Thu, Jan 18, 2018 at 08:27:52AM +1100, Benjamin Herrenschmidt wrote: > > > On Wed, 2018-01-17 at 15:39 +0100, Cédric Le Goater wrote: > > > > Migration is a proble

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-04-11 Thread David Gibson
On Wed, Dec 20, 2017 at 08:38:41AM +0100, Cédric Le Goater wrote: > On 12/20/2017 06:09 AM, David Gibson wrote: > > On Sat, Dec 09, 2017 at 09:43:21AM +0100, Cédric Le Goater wrote: > >> With the POWER9 processor comes a new interrupt controller called > >> XIVE. It is composed of three sub-engines

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-04-11 Thread David Gibson
On Thu, Dec 21, 2017 at 11:12:06AM +1100, Benjamin Herrenschmidt wrote: > On Wed, 2017-12-20 at 16:09 +1100, David Gibson wrote: > > > > As you've suggested in yourself, I think we might need to more > > explicitly model the different components of the XIVE system. As part > > of that, I think yo

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-04-11 Thread David Gibson
On Wed, Jan 17, 2018 at 03:39:46PM +0100, Cédric Le Goater wrote: > On 01/17/2018 12:10 PM, Benjamin Herrenschmidt wrote: > > On Wed, 2018-01-17 at 10:18 +0100, Cédric Le Goater wrote: > > Also, have we decided how the process of switching between XICS and > > XIVE will work vs. CAS ? > >>

Re: [Qemu-devel] [Qemu-arm] Crash when running hello-world unikernel for ARM

2018-04-11 Thread Ajay Garg
Is "integratorcp" the same board that rumprun is being built for (https://github.com/rumpkernel/rumprun/tree/master/platform/hw/arch/arm/integrator)? On Thu, Apr 12, 2018 at 9:56 AM, Ajay Garg wrote: > Actually just realised that qemu does support integratorcp as one of > the supported-boards. >

Re: [Qemu-devel] [Qemu-arm] Crash when running hello-world unikernel for ARM

2018-04-11 Thread Ajay Garg
Actually just realised that qemu does support integratorcp as one of the supported-boards. Unfortunately, when I use qemu-system-arm -machine integratorcp -nographic -kernel helloer.bin the shell just hangs :( Following are the details when run through gdb : ##

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Michael S. Tsirkin
On Thu, Apr 12, 2018 at 11:43:41AM +0800, Jason Wang wrote: > > > On 2018年04月12日 11:35, Michael S. Tsirkin wrote: > > > There are more advantages to using request with PASID: > > > > > > You can use hardware support for nesting, having guest supply 1st level > > > translation and host second lev

Re: [Qemu-devel] [PATCH 0/5] Enable postcopy RDMA live migration

2018-04-11 Thread 858585 jemmy
On Wed, Apr 11, 2018 at 8:29 PM, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: >> Current Qemu RDMA communication does not support send and receive >> data at the same time, so when RDMA live migration with postcopy >> enabled, the source qemu return path thread get

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Jason Wang
On 2018年04月12日 11:37, Michael S. Tsirkin wrote: Yeah, we are still using the existing IOTLB update messages to send the IOTLB messages to backend. The only difference is that, QEMU won't wait for the queries before sending the IOTLB update messages. Yes, my question is not very clear. I mean w

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Jason Wang
On 2018年04月12日 11:35, Michael S. Tsirkin wrote: There are more advantages to using request with PASID: You can use hardware support for nesting, having guest supply 1st level translation and host second level translation. I actually had an idea to do something like this for AMD and ARM which

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Michael S. Tsirkin
On Thu, Apr 12, 2018 at 11:37:35AM +0800, Jason Wang wrote: > > > On 2018年04月12日 09:57, Michael S. Tsirkin wrote: > > On Thu, Apr 12, 2018 at 09:39:43AM +0800, Tiwei Bie wrote: > > > On Thu, Apr 12, 2018 at 04:29:29AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 12, 2018 at 09:10:59AM +08

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Jason Wang
On 2018年04月12日 09:57, Michael S. Tsirkin wrote: On Thu, Apr 12, 2018 at 09:39:43AM +0800, Tiwei Bie wrote: On Thu, Apr 12, 2018 at 04:29:29AM +0300, Michael S. Tsirkin wrote: On Thu, Apr 12, 2018 at 09:10:59AM +0800, Tiwei Bie wrote: On Wed, Apr 11, 2018 at 04:22:21PM +0300, Michael S. Tsirk

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Michael S. Tsirkin
On Thu, Apr 12, 2018 at 11:23:31AM +0800, Jason Wang wrote: > > > On 2018年04月12日 01:00, Michael S. Tsirkin wrote: > > On Wed, Apr 11, 2018 at 09:41:05PM +0800, Jason Wang wrote: > > > On 2018年04月11日 16:38, Tiwei Bie wrote: > > > > On Wed, Apr 11, 2018 at 04:01:19PM +0800, Jason Wang wrote: > > >

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Michael S. Tsirkin
On Thu, Apr 12, 2018 at 06:20:55AM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 12, 2018 at 10:35:05AM +0800, Tiwei Bie wrote: > > On Thu, Apr 12, 2018 at 04:57:13AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 12, 2018 at 09:39:43AM +0800, Tiwei Bie wrote: > > > > On Thu, Apr 12, 2018 at 0

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Jason Wang
On 2018年04月12日 01:00, Michael S. Tsirkin wrote: On Wed, Apr 11, 2018 at 09:41:05PM +0800, Jason Wang wrote: On 2018年04月11日 16:38, Tiwei Bie wrote: On Wed, Apr 11, 2018 at 04:01:19PM +0800, Jason Wang wrote: On 2018年04月11日 15:20, Tiwei Bie wrote: This patch introduces VHOST_USER_PROTOCOL_F_N

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Michael S. Tsirkin
On Thu, Apr 12, 2018 at 10:35:05AM +0800, Tiwei Bie wrote: > On Thu, Apr 12, 2018 at 04:57:13AM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 12, 2018 at 09:39:43AM +0800, Tiwei Bie wrote: > > > On Thu, Apr 12, 2018 at 04:29:29AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 12, 2018 at 0

Re: [Qemu-devel] [PATCH for-2.13] spapr: drop useless dynamic sysbus device sanity check

2018-04-11 Thread David Gibson
On Wed, Apr 11, 2018 at 05:01:20PM +0200, Greg Kurz wrote: > Since commit 7da79a167aa11, the machine class init function registers > dynamic sysbus device types it supports. Passing an unsupported device > type on the command line causes QEMU to exit with an error message > just after machine init.

Re: [Qemu-devel] [PATCH] spapr: drop useless sanity check in spapr_irq_alloc*()

2018-04-11 Thread David Gibson
On Wed, Apr 11, 2018 at 07:46:06PM +0200, Greg Kurz wrote: > Both spapr_irq_alloc() and spapr_irq_alloc_block() have an errp > parameter, but they don't use it if XICS hasn't been initialized > yet. > > This is doubly wrong: > > - all callers do pass a non-null Error **, ie, they expect an error

Re: [Qemu-devel] [PATCH for 2.13 v3 0/2] target/ppc: Support adding memory to initially memory-less NUMA nodes

2018-04-11 Thread David Gibson
On Wed, Apr 11, 2018 at 02:41:58PM -0400, Serhii Popovych wrote: > Now PowerPC Linux kernel supports hot-add to NUMA nodes not populated > initially with memory we can enable such support in qemu. This requires > two changes: > > o Add device tree property "ibm,max-associativity-domains" to let

Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-04-11 Thread David Gibson
On Tue, Mar 06, 2018 at 06:33:52PM +0800, Liu, Yi L wrote: > On Mon, Mar 05, 2018 at 02:31:44PM +1100, David Gibson wrote: > > On Thu, Mar 01, 2018 at 06:31:55PM +0800, Liu, Yi L wrote: > > > This patch intoduces PCISVAOps for virt-SVA. > > > > > > So far, to setup virt-SVA for assigned SVA capable

Re: [Qemu-devel] Bad icount read when running qemu-system-ppc64 and mfspr atbu guest instruction

2018-04-11 Thread Darrell Leinwand
Ah I see, that makes sense and the atb instructions are marked as unused in the mainline which when I compared I recall now that we modifed them because the guest software we are running is trying to use those special registers. I added the wrappers into those function, is that correct? Thanks

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Tiwei Bie
On Thu, Apr 12, 2018 at 04:57:13AM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 12, 2018 at 09:39:43AM +0800, Tiwei Bie wrote: > > On Thu, Apr 12, 2018 at 04:29:29AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 12, 2018 at 09:10:59AM +0800, Tiwei Bie wrote: > > > > On Wed, Apr 11, 2018 at 0

Re: [Qemu-devel] [PATCH V4] migration: add capability to bypass the shared memory

2018-04-11 Thread Lai Jiangshan
On Tue, Apr 10, 2018 at 1:30 AM, Dr. David Alan Gilbert wrote: > Hi, > > * Lai Jiangshan (jiangshan...@gmail.com) wrote: >> 1) What's this >> >> When the migration capability 'bypass-shared-memory' >> is set, the shared memory will be bypassed when migration. >> >> It is the key feature to enable

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Michael S. Tsirkin
On Thu, Apr 12, 2018 at 09:39:43AM +0800, Tiwei Bie wrote: > On Thu, Apr 12, 2018 at 04:29:29AM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 12, 2018 at 09:10:59AM +0800, Tiwei Bie wrote: > > > On Wed, Apr 11, 2018 at 04:22:21PM +0300, Michael S. Tsirkin wrote: > > > > On Wed, Apr 11, 2018 at 0

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Tiwei Bie
On Wed, Apr 11, 2018 at 08:37:17PM +0300, Michael S. Tsirkin wrote: > On Wed, Apr 11, 2018 at 04:38:53PM +0800, Tiwei Bie wrote: > > On Wed, Apr 11, 2018 at 04:01:19PM +0800, Jason Wang wrote: > > > On 2018年04月11日 15:20, Tiwei Bie wrote: > > > > This patch introduces VHOST_USER_PROTOCOL_F_NEED_ALL_

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Tiwei Bie
On Thu, Apr 12, 2018 at 04:29:29AM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 12, 2018 at 09:10:59AM +0800, Tiwei Bie wrote: > > On Wed, Apr 11, 2018 at 04:22:21PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Apr 11, 2018 at 03:20:27PM +0800, Tiwei Bie wrote: > > > > This patch introduces VHO

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Michael S. Tsirkin
On Thu, Apr 12, 2018 at 09:10:59AM +0800, Tiwei Bie wrote: > On Wed, Apr 11, 2018 at 04:22:21PM +0300, Michael S. Tsirkin wrote: > > On Wed, Apr 11, 2018 at 03:20:27PM +0800, Tiwei Bie wrote: > > > This patch introduces VHOST_USER_PROTOCOL_F_NEED_ALL_IOTLB > > > feature for vhost-user. By default,

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

2018-04-11 Thread Tiwei Bie
On Wed, Apr 11, 2018 at 04:22:21PM +0300, Michael S. Tsirkin wrote: > On Wed, Apr 11, 2018 at 03:20:27PM +0800, Tiwei Bie wrote: > > This patch introduces VHOST_USER_PROTOCOL_F_NEED_ALL_IOTLB > > feature for vhost-user. By default, vhost-user backend needs > > to query the IOTLBs from QEMU after me

Re: [Qemu-devel] [PATCHv3 for-2.13 0/2] Helpers to obtain host page sizes for guest RAM

2018-04-11 Thread David Gibson
On Wed, Apr 11, 2018 at 03:54:20PM +0200, Paolo Bonzini wrote: > On 11/04/2018 09:04, David Gibson wrote: > > This series makes some small changes to make it easier to obtain the > > host page size backing given portions of guest RAM. We use this in a > > couple of places currently, and I have one

Re: [Qemu-devel] [PATCH 00/10] Avoid integer overflow in next_page_start

2018-04-11 Thread Richard Henderson
On 04/12/2018 01:29 AM, Emilio G. Cota wrote: > To ease an eventual merge I'll be updating the patches' R-b tags as > they come in this branch: > https://github.com/cota/qemu/tree/next_page_overflow-r-b > > BTW to avoid conflicts we should merge this before the translator loop > conversion serie

Re: [Qemu-devel] Bad icount read when running qemu-system-ppc64 and mfspr atbu guest instruction

2018-04-11 Thread Richard Henderson
On 04/12/2018 04:18 AM, Darrell Leinwand wrote: > Hi, > > When I enable icount using an e5500 core I get an exit with “Bad icount > read” when the guest software executes a load atbu command. Yep, it looks like there are some bugs in the ppc front end wrt icount. In target/ppc/translate_init.c,

Re: [Qemu-devel] [PATCH v8 19/23] SiFive RISC-V UART Device

2018-04-11 Thread Eric Blake
On 04/10/2018 03:04 AM, Antony Pavlov wrote: +++ b/include/hw/riscv/sifive_uart.h + +typedef struct SiFiveUARTState { +/*< private >*/ +SysBusDevice parent_obj; >>> >>> >>> You use SysBusDevive in this header file but there is no 'include >>> "hw/sysbus.h"' in th

Re: [Qemu-devel] Bad icount read when running qemu-system-ppc64 and mfspr atbu guest instruction

2018-04-11 Thread Emilio G. Cota
On Wed, Apr 11, 2018 at 18:18:18 +, Darrell Leinwand wrote: > Hi, > > When I enable icount using an e5500 core I get an exit with “Bad icount read” > when the guest software executes a load atbu command. > > It looks like in qemu/accel/tcg/cpu_exec.c:166 sets can_do_io false when > using ic

Re: [Qemu-devel] [PATCH v4 11/13] block/mirror: Add active mirroring

2018-04-11 Thread Eric Blake
On 04/11/2018 01:54 PM, Max Reitz wrote: > This patch implements active synchronous mirroring. In active mode, the > passive mechanism will still be in place and is used to copy all > initially dirty clusters off the source disk; but every write request > will write data both to the source and the

Re: [Qemu-devel] [PATCH 01/10] target/riscv: avoid integer overflow in next_page PC check

2018-04-11 Thread Michael Clark
On Wed, Apr 11, 2018 at 4:19 AM, Emilio G. Cota wrote: > If the PC is in the last page of the address space, next_page_start > overflows to 0. Fix it. > > Reported-by: Richard Henderson > Suggested-by: Richard Henderson > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Ba

Re: [Qemu-devel] [PATCH v3 01/15] tests: add fp-test, a floating point test suite

2018-04-11 Thread Emilio G. Cota
On Wed, Apr 11, 2018 at 02:20:49 +0100, Alex Bennée wrote: > Emilio G. Cota writes: > So with the attached patch and my proposed cross build we can now get: > > 02:15:54 [alex@zen:~/l/q/qemu.git] softfloat-fixes-for-2.12-v1 ± find . > -iname "fp-test" | xargs file > ./ppc64-linux-user/tests/fp-t

Re: [Qemu-devel] [PATCH v8 19/23] SiFive RISC-V UART Device

2018-04-11 Thread Michael Clark
On Tue, Apr 10, 2018 at 8:04 PM, Antony Pavlov wrote: > On Tue, 10 Apr 2018 08:17:32 +0200 > Thomas Huth wrote: > > > On 10.04.2018 05:21, Antony Pavlov wrote: > > > On Sat, 3 Mar 2018 02:51:47 +1300 > > > Michael Clark wrote: > > > > > >> QEMU model of the UART on the SiFive E300 and U500 ser

[Qemu-devel] [ANNOUNCE] QEMU 2.12.0-rc3 is now available

2018-04-11 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.12 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.12.0-rc3.tar.xz http://do

Re: [Qemu-devel] [PATCH for 2.13 v2 00/19] linux-user: move arch specific parts from main.c to arch directories

2018-04-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180411185651.21351-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH for 2.13 v2 00/19] linux-user: move arch specific parts from main.c to arch directories === TEST SCRIPT

Re: [Qemu-devel] [RFC PATCH] migration: discard RAMBlocks of type ram_device

2018-04-11 Thread Dr. David Alan Gilbert
* Cédric Le Goater (c...@kaod.org) wrote: > Here is some context for this strange change request. > > On the POWER9 processor, the XIVE interrupt controller can control > interrupt sources using MMIO to trigger events, to EOI or to turn off > the sources. Priority management and interrupt acknowle

[Qemu-devel] [PATCH for 2.13 v2 14/19] linux-user: move alpha cpu loop to alpha directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to alpha/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/alpha/cpu_loop.c | 199 ++ linux-user/main.c | 204 -

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

2018-04-11 Thread Dr. David Alan Gilbert
* Alexey Kardashevskiy (a...@ozlabs.ru) wrote: > This adds owners/parents (which are the same, just occasionally > owner==NULL) printing for memory regions; a new '-o' flag > enabled new output. > > Signed-off-by: Alexey Kardashevskiy From the HMP side this looks fine to me, and if it's making i

[Qemu-devel] [PATCH for 2.13 v2 17/19] linux-user: move riscv cpu loop to riscv directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to riscv/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Michael Clark --- linux-user/main.c | 101 +--- linux-user/riscv/cpu_loop.c | 92

Re: [Qemu-devel] [PATCH for 2.13 v3 00/20] move arch specific parts to arch directories

2018-04-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180411184556.17200-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH for 2.13 v3 00/20] move arch specific parts to arch directories === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH for 2.13] linux-user: introduce target_sigsp() and target_save_altstack()

2018-04-11 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- Based-on: <20180411185651.21351-1-laur...@vivier.eu> "[PATCH for 2.13 v2 00/19] linux-user: move arch specific parts from main.c to arch directories" linux-user/aarch64/signal.c| 13 ++--- linux-user/alpha/signal.c | 17 ++--- linux

[Qemu-devel] [PATCH for 2.13 v2 16/19] linux-user: move tilegx cpu loop to tilegx directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to tilegx/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/main.c| 267 --- linux-user/tilegx/cpu_loop.c | 260 + 2 files

[Qemu-devel] [PATCH for 2.13 v2 08/19] linux-user: move nios2 cpu loop to nios2 directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to nios2/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/main.c | 133 linux-user/nios2/cpu_loop.c | 126 + 2 files c

[Qemu-devel] [PATCH for 2.13 v2 07/19] linux-user: move mips/mips64 cpu loop to mips directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to mips/cpu_loop.c. Include mips/cpu_loop.c in mips64/cpu_loop.c to avoid to duplicate code. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- Notes: v2: expand tabs linux-user/main.c

[Qemu-devel] [PATCH for 2.13 v2 04/19] linux-user: move arm cpu loop to arm directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to arm/cpu_loop.c and duplicate some macro defined for both arm and aarch64. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/arm/cpu_loop.c | 430 + linux-user/main.c | 433

[Qemu-devel] [PATCH for 2.13 v2 11/19] linux-user: move cris cpu loop to cris directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to cris/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- Notes: v2: expand tabs linux-user/cris/cpu_loop.c | 89 + linux-user/main.c | 90 ---

[Qemu-devel] [PATCH for 2.13 v2 05/19] linux-user: move sparc/sparc64 cpu loop to sparc directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to sparc/cpu_loop.c. Include sparc/cpu_loop.c in sparc64/cpu_loop.c to avoid to duplicate code. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/main.c | 288 +- linux-user

[Qemu-devel] [PATCH for 2.13 v2 19/19] linux-user: move xtensa cpu loop to xtensa directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to xtensa/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- Notes: v2: report changes introduced by 4a6bf7adb9 target/xtensa: linux-user: rewind pc for restarted syscall linux-user/main.c| 250 --

[Qemu-devel] [PATCH for 2.13 v2 06/19] linux-user: move ppc/ppc64 cpu loop to ppc directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to ppc/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/main.c | 560 +- linux-user/ppc/cpu_loop.c | 553 + 2 files c

[Qemu-devel] [PATCH for 2.13 v2 13/19] linux-user: move m68k cpu loop to m68k directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to m68k/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/m68k/cpu_loop.c | 144 +++ linux-user/main.c | 150 + 2 files c

[Qemu-devel] [PATCH for 2.13 v2 18/19] linux-user: move hppa cpu loop to hppa directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to hppa/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/hppa/cpu_loop.c | 185 ++ linux-user/main.c | 194 +---

[Qemu-devel] [PATCH for 2.13 v2 03/19] linux-user: move aarch64 cpu loop to aarch64 directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to aarch64/cpu_loop.c and duplicate some macro defined for both arm and aarch64. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/aarch64/cpu_loop.c | 156 ++ linux-user/main.c

Re: [Qemu-devel] [RFC PATCH] migration: discard RAMBlocks of type ram_device

2018-04-11 Thread Kirti Wankhede
On 4/11/2018 11:25 PM, Alex Williamson wrote: > [cc +folks working on vfio-mdev migration] > > On Wed, 11 Apr 2018 19:20:14 +0200 > Cédric Le Goater wrote: > >> Here is some context for this strange change request. >> >> On the POWER9 processor, the XIVE interrupt controller can control >> int

[Qemu-devel] [PATCH v4 09/13] block/dirty-bitmap: Add bdrv_dirty_iter_next_area

2018-04-11 Thread Max Reitz
This new function allows to look for a consecutively dirty area in a dirty bitmap. Signed-off-by: Max Reitz Reviewed-by: Fam Zheng Reviewed-by: John Snow --- include/block/dirty-bitmap.h | 2 ++ block/dirty-bitmap.c | 55 2 files changed, 5

[Qemu-devel] [PATCH for 2.13 v2 10/19] linux-user: move sh4 cpu loop to sh4 directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to sh4/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- Notes: v2: expand tabs linux-user/main.c | 90 --- linux-user/sh4/cpu_loop.c | 85

[Qemu-devel] [PATCH for 2.13 v2 02/19] linux-user: move i386/x86_64 cpu loop to i386 directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to i386/cpu_loop.c. Include i386/cpu_loop.c in x86_64/cpu_loop.c to avoid to duplicate code. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/i386/cpu_loop.c | 343 ++ linux-user/mai

[Qemu-devel] [PATCH v4 05/13] block/mirror: Use source as a BdrvChild

2018-04-11 Thread Max Reitz
With this, the mirror_top_bs is no longer just a technically required node in the BDS graph but actually represents the block job operation. Also, drop MirrorBlockJob.source, as we can reach it through mirror_top_bs->backing. Signed-off-by: Max Reitz Reviewed-by: Fam Zheng --- block/mirror.c |

[Qemu-devel] [PATCH for 2.13 v2 09/19] linux-user: move openrisc cpu loop to openrisc directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to openrisc/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/main.c | 96 -- linux-user/openrisc/cpu_loop.c | 89 +++ 2 file

[Qemu-devel] [PATCH v4 13/13] iotests: Add test for active mirroring

2018-04-11 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Fam Zheng --- tests/qemu-iotests/151 | 120 + tests/qemu-iotests/151.out | 5 ++ tests/qemu-iotests/group | 1 + 3 files changed, 126 insertions(+) create mode 100755 tests/qemu-iotests/151 create mode

[Qemu-devel] [PATCH for 2.13 v2 15/19] linux-user: move s390x cpu loop to s390x directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to s390x/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Acked-by: Cornelia Huck --- linux-user/main.c | 146 linux-user/s390x/cpu_loop.c | 139 +++

[Qemu-devel] [PATCH for 2.13 v3 04/20] linux-user: move sh4 signal.c parts to sh4 directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to sh4/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- Notes: v3: expand tabs linux-user/sh4/signal.c| 332 +++

[Qemu-devel] [PATCH v4 12/13] block/mirror: Add copy mode QAPI interface

2018-04-11 Thread Max Reitz
This patch allows the user to specify whether to use active or only background mode for mirror block jobs. Currently, this setting will remain constant for the duration of the entire block job. Signed-off-by: Max Reitz --- qapi/block-core.json | 11 +-- include/block/block_int.h |

[Qemu-devel] [PATCH v4 11/13] block/mirror: Add active mirroring

2018-04-11 Thread Max Reitz
This patch implements active synchronous mirroring. In active mode, the passive mechanism will still be in place and is used to copy all initially dirty clusters off the source disk; but every write request will write data both to the source and the target disk, so the source cannot be dirtied fas

[Qemu-devel] [PATCH for 2.13 v2 12/19] linux-user: move microblaze cpu loop to microblaze directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from main.c to microblaze/cpu_loop.c. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- Notes: v2: expand tabs linux-user/main.c| 155 --- linux-user/microblaze/cpu_loop.c | 150 +

[Qemu-devel] [PATCH v4 10/13] block/mirror: Add MirrorBDSOpaque

2018-04-11 Thread Max Reitz
This will allow us to access the block job data when the mirror block driver becomes more complex. Signed-off-by: Max Reitz Reviewed-by: Fam Zheng --- block/mirror.c | 12 1 file changed, 12 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 40c7c55f07..abaf2a83c7 10

[Qemu-devel] [PATCH v4 08/13] test-hbitmap: Add non-advancing iter_next tests

2018-04-11 Thread Max Reitz
Add a function that wraps hbitmap_iter_next() and always calls it in non-advancing mode first, and in advancing mode next. The result should always be the same. By using this function everywhere we called hbitmap_iter_next() before, we should get good test coverage for non-advancing hbitmap_iter_

[Qemu-devel] [PATCH for 2.13 v3 03/20] linux-user: move arm signal.c parts to arm directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to arm/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- Notes: v3: expand tabs linux-user/arm/signal.c| 754 +++

[Qemu-devel] [PATCH for 2.13 v2 01/19] linux-user: create a dummy per arch cpu_loop.c

2018-04-11 Thread Laurent Vivier
Create a cpu_loop-common.h for future use by these new files and use it in the existing main.c Introduce target_cpu_copy_regs(): declare the function in cpu_loop-common.h and an empty function for each target, to move all the cpu_loop prologues to this function. Signed-off-by: Laurent Vivier Rev

[Qemu-devel] [PATCH v4 04/13] block/mirror: Wait for in-flight op conflicts

2018-04-11 Thread Max Reitz
This patch makes the mirror code differentiate between simply waiting for any operation to complete (mirror_wait_for_free_in_flight_slot()) and specifically waiting for all operations touching a certain range of the virtual disk to complete (mirror_wait_on_conflicts()). Signed-off-by: Max Reitz R

[Qemu-devel] [PATCH v4 07/13] hbitmap: Add @advance param to hbitmap_iter_next()

2018-04-11 Thread Max Reitz
This new parameter allows the caller to just query the next dirty position without moving the iterator. Signed-off-by: Max Reitz Reviewed-by: Fam Zheng Reviewed-by: John Snow --- include/qemu/hbitmap.h | 5 - block/backup.c | 2 +- block/dirty-bitmap.c | 2 +- tests/test-hbitm

[Qemu-devel] [PATCH for 2.13 v3 01/20] linux-user: create a dummy per arch signal.c

2018-04-11 Thread Laurent Vivier
Create a signal-common.h for future use by these new files and use it in the existing signal.c Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/Makefile.objs | 2 +- linux-user/aarch64/signal.c| 18 +++ linux-user/alpha

[Qemu-devel] [PATCH for 2.13 v2 00/19] linux-user: move arch specific parts from main.c to arch directories

2018-04-11 Thread Laurent Vivier
This series moves from main.c the architecture specific parts to the architecture directory. This is the continuation of my series "linux-user: move arch specific parts to arch directories" that includes since the v2 only the signal.c parts. For each architecture, there are two parts: - cpu_

[Qemu-devel] [PATCH v4 for-2.13 00/13] block/mirror: Add active-sync mirroring

2018-04-11 Thread Max Reitz
This series implements an active and synchronous mirroring mode. Currently, the mirror block job is passive an asynchronous: Depending on your start conditions, some part of the source disk starts as "dirty". Then, the block job will (as a background operation) continuously copy dirty parts to the

[Qemu-devel] [PATCH for 2.13 v3 09/20] linux-user: move s390x signal.c parts to s390x directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to s390x/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Acked-by: Cornelia Huck Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/s390x/signal.c| 309 +++

[Qemu-devel] [PATCH v4 06/13] block: Generalize should_update_child() rule

2018-04-11 Thread Max Reitz
Currently, bdrv_replace_node() refuses to create loops from one BDS to itself if the BDS to be replaced is the backing node of the BDS to replace it: Say there is a node A and a node B. Replacing B by A means making all references to B point to A. If B is a child of A (i.e. A has a reference to B

[Qemu-devel] [PATCH v4 01/13] block/mirror: Pull out mirror_perform()

2018-04-11 Thread Max Reitz
When converting mirror's I/O to coroutines, we are going to need a point where these coroutines are created. mirror_perform() is going to be that point. Signed-off-by: Max Reitz Reviewed-by: Fam Zheng Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Jeff Cody --- block/mirror.c | 51 ++

[Qemu-devel] [PATCH for 2.13 v3 11/20] linux-user: move alpha signal.c parts to alpha directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to alpha/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- Notes: v3: report changes

[Qemu-devel] [PATCH v4 03/13] block/mirror: Use CoQueue to wait on in-flight ops

2018-04-11 Thread Max Reitz
Attach a CoQueue to each in-flight operation so if we need to wait for any we can use it to wait instead of just blindly yielding and hoping for some operation to wake us. A later patch will use this infrastructure to allow requests accessing the same area of the virtual disk to specifically wait

[Qemu-devel] [PATCH for 2.13 v3 19/20] linux-user: move ppc/ppc64 signal.c parts to ppc directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to ppc/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/ppc/signal.c| 671

[Qemu-devel] [PATCH for 2.13 v3 14/20] linux-user: move hppa signal.c parts to hppa directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to hppa/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/hppa/signal.c| 192 +++

[Qemu-devel] [PATCH v4 02/13] block/mirror: Convert to coroutines

2018-04-11 Thread Max Reitz
In order to talk to the source BDS (and maybe in the future to the target BDS as well) directly, we need to convert our existing AIO requests into coroutine I/O requests. Signed-off-by: Max Reitz Reviewed-by: Fam Zheng --- block/mirror.c | 152 ++-

[Qemu-devel] [PATCH for 2.13 v3 08/20] linux-user: move openrisc signal.c parts to openrisc directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to openrisc/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/openrisc/signal.c| 213 li

[Qemu-devel] [PATCH for 2.13 v3 18/20] linux-user: move mips/mips64 signal.c parts to mips directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to mips/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). mips64/signal.c includes mips/signal.c Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henders

[Qemu-devel] [PATCH for 2.13 v3 10/20] linux-user: move m68k signal.c parts to m68k directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to m68k/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/m68k/signal.c| 410 ++

[Qemu-devel] [PATCH for 2.13 v3 15/20] linux-user: move xtensa signal.c parts to xtensa directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to xtensa/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- Notes: v3: report changes introduced by 20ef667060 target/xtensa: fix fl

[Qemu-devel] [PATCH for 2.13 v3 20/20] linux-user: define TARGET_ARCH_HAS_SETUP_FRAME

2018-04-11 Thread Laurent Vivier
Instead of calling setup_frame() conditionally to a list of known targets, define TARGET_ARCH_HAS_SETUP_FRAME if the target provides the function and call it only if the macro is defined. Move declarations of setup_frame() and setup_rt_frame() to linux-user/signal-common.h Signed-off-by: Laurent

[Qemu-devel] [PATCH for 2.13 v3 06/20] linux-user: move cris signal.c parts to cris directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to cris/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/cris/signal.c| 171 ++

[Qemu-devel] [PATCH for 2.13 v3 05/20] linux-user: move microblaze signal.c parts to microblaze directory

2018-04-11 Thread Laurent Vivier
No code change, only move code from signal.c to microblaze/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/microblaze/signal.c| 230 ++

  1   2   3   >