[Qemu-devel] [PATCH for-2.12 3/8] monitor: new parameter "x-oob"

2018-03-25 Thread Peter Xu
Add new parameter to optionally enable Out-Of-Band for a QMP server. An example command line: ./qemu-system-x86_64 -chardev stdio,id=char0 \ -mon chardev=char0,mode=control,x-oob=on By default, Out-Of-Band is off. It is not allowed if either MUX or non-QMP is detected,

[Qemu-devel] [PATCH for-2.12 8/8] tests: qmp-test: add test for new "x-oob"

2018-03-25 Thread Peter Xu
Test the new OOB capability. It's mostly the reverted OOB test, but differs in that: - It uses the new qtest_init_with_qmp_format() to create the monitor with the new monitor parameter "-mon x-oob" - Squashed the capability tests on greeting message - Don't use qtest_global any more, instead use

[Qemu-devel] [PATCH for-2.12 6/8] tests: add oob-test for qapi-schema

2018-03-25 Thread Peter Xu
It simply tests the new OOB capability, and make sure the QAPISchema can parse it correctly. Signed-off-by: Peter Xu --- tests/Makefile.include | 1 + tests/qapi-schema/oob-test.err | 1 + tests/qapi-schema/oob-test.exit | 1 + tests/qapi-schema/oob-test.json

[Qemu-devel] [PATCH for-2.12 7/8] tests: introduce qtest_init_with_qmp_format()

2018-03-25 Thread Peter Xu
It is abstracted from qtest_init_without_qmp_handshake(). It works just like qtest_init_without_qmp_handshake() but further it would allow the caller to specify the QMP parameter. Signed-off-by: Peter Xu --- tests/libqtest.c | 14 +++--- tests/libqtest.h | 14 ++ 2 files chan

[Qemu-devel] [PATCH for-2.12 0/8] Monitor: some oob related patches (fixes, new param, tests)

2018-03-25 Thread Peter Xu
I suppose these are all good even for 2.12, so marked in subject. Tested with "make check" for all targets on x86_64, and iotest -raw. Patch 1 fixes one OOB error message regression reported by Marc-Andre. Patch 2 fixes one potential OOB problem when more than one clients are there, reported by M

[Qemu-devel] [PATCH for-2.12 5/8] tests: let qapi-schema tests detect oob

2018-03-25 Thread Peter Xu
The allow_oob parameter was passed in but not used in tests. Now reflect that in the tests, so we need to touch up other command testers with that new change. Reviewed-by: Eric Blake Signed-off-by: Peter Xu --- tests/qapi-schema/doc-good.out | 4 ++-- tests/qapi-schema/ident-with-esc

[Qemu-devel] [PATCH for-2.12 2/8] qmp: cleanup qmp queues properly

2018-03-25 Thread Peter Xu
Marc-André Lureau reported that we can have this happen: 1. client1 connects, send command C1 2. client1 disconnects before getting response for C1 3. client2 connects, who might receive response of C1 However client2 should not receive remaining responses for client1. Basically, we should clean

[Qemu-devel] [PATCH for-2.12 4/8] qapi: restrict allow-oob value to be "true"

2018-03-25 Thread Peter Xu
It was missed in the first version of OOB series. We should check this to make sure we throw the right error when fault value is passed in. Signed-off-by: Peter Xu --- scripts/qapi/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/common.py b/scripts/qap

[Qemu-devel] [PATCH for-2.12 1/8] qmp: fix qmp_capabilities error regression

2018-03-25 Thread Peter Xu
When someone sents a command before QMP handshake, error was like this: {"execute": "query-cpus"} {"error": {"class": "CommandNotFound", "desc": "Expecting capabilities negotiation with 'qmp_capabilities'"}} While after cf869d5317 it becomes: {"execute": "query-cpus"} {"error": {

[Qemu-devel] [PATCH] iotests: fix wait_until_completed()

2018-03-25 Thread Peter Xu
If there are more than one events, wait_until_completed() might return the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop will continue to run even if completed is set to True. It never happened before, but it can be triggered when OOB is enabled due to the RESUME startup mes

Re: [Qemu-devel] [PATCH 00/14] Generalize Dallas/Maxim I2C RTC devices v2

2018-03-25 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180324192455.12254-1-mdavidsa...@gmail.com Subject: [Qemu-devel] [PATCH 00/14] Generaliz

[Qemu-devel] [Bug 1758819] [NEW] HVF Illegal instruction: 4, High Sierra, v2.12-rc0

2018-03-25 Thread Erik Kristian Sverre Uri
Public bug reported: I've built v2.12.0-rc0 on MacOS using homebrew. I'm running 10.13.3 on a 5,1 Mac Pro with a X5690 processor. When I run 'qemu-system-x86_64 -M accel=hvf', I get a crash "Illegal instruction: 4". ** Affects: qemu Importance: Undecided Status: New ** Tags: hvf

Re: [Qemu-devel] [PATCH] target/ppc: Fix reserved bit mask of dstst instruction

2018-03-25 Thread BALATON Zoltan
On Mon, 26 Mar 2018, David Gibson wrote: On Mon, Mar 26, 2018 at 01:54:28AM +0200, BALATON Zoltan wrote: According to the Vector/SIMD extension documentation bit 6 that is currently masked is valid (listed as transient bit) but bits 7 and 8 should be reserved instead. Fix the mask to match this.

Re: [Qemu-devel] [PATCH] monitor: fix expected qmp_capabilities error description regression

2018-03-25 Thread Peter Xu
On Sat, Mar 24, 2018 at 06:41:04AM -0500, Eric Blake wrote: > On 03/23/2018 08:41 PM, Peter Xu wrote: > > > > There have been quite a few patch ideas across multiple threads related to > > > OOB fallout. Hopefully I can keep straight which patches are intended for > > > 2.12 (anything that fixes

Re: [Qemu-devel] [PATCH] target/ppc: Fix reserved bit mask of dstst instruction

2018-03-25 Thread David Gibson
On Mon, Mar 26, 2018 at 01:54:28AM +0200, BALATON Zoltan wrote: > According to the Vector/SIMD extension documentation bit 6 that is > currently masked is valid (listed as transient bit) but bits 7 and 8 > should be reserved instead. Fix the mask to match this. What document can I find information

[Qemu-devel] [PATCH RFC v3] scripts/checkpatch.pl: Bug fix

2018-03-25 Thread Su Hang
Commit 2b9aef6fcd96ba7ed8c1ee723e391901852d344c introduced a regression: checkpatch.pl started complaining about the following valid pattern: do { /* something */ } while (condition); Fix the script to once again permit this pattern. Signed-off-by: Su Hang --- v1: fix bug. v2: correct inapp

[Qemu-devel] [PATCH] target/ppc: Fix reserved bit mask of dstst instruction

2018-03-25 Thread BALATON Zoltan
According to the Vector/SIMD extension documentation bit 6 that is currently masked is valid (listed as transient bit) but bits 7 and 8 should be reserved instead. Fix the mask to match this. Signed-off-by: BALATON Zoltan --- target/ppc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-03-25 Thread Mark Cave-Ayland
On 22/03/18 09:00, Philippe Mathieu-Daudé wrote: Hi Mark, On 03/21/2018 12:29 AM, David Gibson wrote: On Tue, Mar 06, 2018 at 08:31:01PM +, Mark Cave-Ayland wrote: Commit 4e46dcdbd3 "PPC: Newworld: Add uninorth token register" added a TODO which was to convert the uninorth registers hack

[Qemu-devel] [PATCH sgabios] Makefile: Add HOSTCC

2018-03-25 Thread Cole Robinson
From: Paolo Bonzini Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 970b0ff..c8cb92b 100644 --- a/Makefile +++ b/Makefile @@ -30,6 +30,7 @@ ASFLAGS += -DBUILD_USER="$(BUILD_USER)" LDSCRIPT := rom16.ld LDFLAGS := -T $(LDSCRIPT) -nostdlib

Re: [Qemu-devel] [PULL 00/10] target-arm queue

2018-03-25 Thread Peter Maydell
On 23 March 2018 at 18:49, Peter Maydell wrote: > Ten arm-related bug fixes for 2.12... > > thanks > -- PMM > > The following changes since commit 4c2c1015905fa1d616750dfe024b4c0b35875950: > > Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20180323' into > staging (2018-03-23 10:2

Re: [Qemu-devel] [PATCH v6 00/26] RISC-V: Fixes and cleanups for QEMU 2.12

2018-03-25 Thread Peter Maydell
On 24 March 2018 at 18:13, Michael Clark wrote: > This is a series of bug fixes and code cleanups that we would > like to get in before the QEMU 2.12 release. We are respinning > v6 of this series to include two new bug fixes. These changes > are present in the downstream riscv.org riscv-all branc

[Qemu-devel] Regarding qemu console?

2018-03-25 Thread Arun raj
Hi, I'm new to qemu.i'm using qemu 2.11 version in my laptop.In qemu system i have two serial port.If i type the any information on the minicom serial port, this message are redirected into QEMU console. How you are redirecting all message onto qemu console. Are you using any virtual console drive

Re: [Qemu-devel] [PATCH v6 06/26] RISC-V: Mark ROM read-only after copying in code

2018-03-25 Thread Peter Maydell
On 25 March 2018 at 00:23, Michael Clark wrote: > > > On Sat, Mar 24, 2018 at 2:23 PM, Peter Maydell > wrote: >> >> On 24 March 2018 at 18:13, Michael Clark wrote: >> > The sifive_u machine already marks its ROM readonly. This fixes >> > the remaining boards. >> > >> > Cc: Sagar Karandikar >> >