Re: [Qemu-devel] [PATCH v3 09/18] sdcard: handles more commands in SPI mode

2018-01-31 Thread Philippe Mathieu-Daudé
On 01/31/2018 09:11 PM, Alistair Francis wrote: > On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé > wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/sd/sd.c | 57 ++--- >> 1 file changed, 54 insertions(+), 3 deletions(-) >>

Re: [Qemu-devel] [PATCH v2 04/19] Include qapi/error.h exactly where needed

2018-01-31 Thread Markus Armbruster
Cc: Gerd for an idea; please skip to bottom of the message. Eric Blake writes: > On 01/31/2018 08:48 AM, Markus Armbruster wrote: >> This cleanup makes the number of objects depending on qapi/error.h >> drop from 1910 (out of 4743) to 1612 in my "build everything" tree. >> >> While there, separ

Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes

2018-01-31 Thread Markus Armbruster
Fam Zheng writes: > On Wed, Jan 31, 2018 at 11:48 PM, Thomas Huth wrote: >> On 31.01.2018 15:48, Markus Armbruster wrote: >>> Clean up includes so that osdep.h is included first and headers >>> which it implies are not included manually. >>> >>> This commit was created with scripts/clean-include

Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes

2018-01-31 Thread Markus Armbruster
Eric Blake writes: > On 01/31/2018 08:48 AM, Markus Armbruster wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes, with the change >> to target/s390x/gen-features.c man

Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others

2018-01-31 Thread Markus Armbruster
Eric Blake writes: > On 01/31/2018 08:48 AM, Markus Armbruster wrote: >> System headers should be included with <...>, our own headers with >> "...". Offenders tracked down with an ugly, brittle and probably >> buggy Perl script. Previous iteration was commit a9c94277f0. >> >> Put the cleaned

Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others

2018-01-31 Thread Markus Armbruster
Thomas Huth writes: > On 31.01.2018 15:48, Markus Armbruster wrote: >> System headers should be included with <...>, our own headers with >> "...". Offenders tracked down with an ugly, brittle and probably >> buggy Perl script. Previous iteration was commit a9c94277f0. >> >> Put the cleaned up

Re: [Qemu-devel] [PATCH] vcpu: join vcpu thread after it exiting

2018-01-31 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1517463523-21394-1-git-send-email-li...@zju.edu.cn Subject: [Qemu-devel] [PATCH] vcpu: j

Re: [Qemu-devel] Can not hotplug device to pci-to-pci bridge using machine type older than 1.7

2018-01-31 Thread Fei Li
On 01/29/2018 09:33 PM, Igor Mammedov wrote: On Thu, 25 Jan 2018 16:01:39 +0800 Fei Li wrote: Hi, After I hotplug a pci device to a pci2pci bridge (I use "pci.1") with machine type 1.7 or older, I can not see the pci device via `lspci` in the guest, but can see it via `info qtree` in the hmp

Re: [Qemu-devel] [PATCH] vcpu: join vcpu thread after it exiting

2018-01-31 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1517463523-21394-1-git-send-email-li...@zju.edu.cn Subject: [Qemu-devel] [PATCH] vcpu: jo

[Qemu-devel] [PATCH] virtio-blk: enable multiple vectors when using multiple I/O queues

2018-01-31 Thread Changpeng Liu
Currently virtio-pci driver hardcoded 2 vectors for virtio-blk device, for multiple I/O queues scenario, all the I/O queues will share one interrupt vector, while here, enable multiple vectors according to the number of I/O queues. Signed-off-by: Changpeng Liu --- hw/virtio/virtio-pci.c | 12 +++

[Qemu-devel] [PATCH v3 2/2] i386: Add support to get/set/migrate Intel Processor Trace feature

2018-01-31 Thread Luwei Kang
From: Chao Peng Add Intel Processor Trace related definition. It also add corresponding part to kvm_get/set_msr and vmstate. Signed-off-by: Chao Peng Signed-off-by: Luwei Kang --- target/i386/cpu.h | 22 ++ target/i386/kvm.c | 51 +++

[Qemu-devel] [PATCH v3 1/2] i386: Add Intel Processor Trace feature support

2018-01-31 Thread Luwei Kang
From: Chao Peng Expose Intel Processor Trace feature to guest. To make Intel PT live migration safe and get same CPUID information with same CPU model on diffrent host. CPUID[14] is constant in this patch. Intel PT use EPT is first supported in IceLake, the CPUID[14] get on this machine as defau

[Qemu-devel] [PATCH] vcpu: join vcpu thread after it exiting

2018-01-31 Thread linzhecheng
As we create vcpu thread with QEMU_THREAD_JOINABLE mode, we should join it after it exiting to cleanup resources. Signed-off-by: linzhecheng diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index f290f48..6ff71e4 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -282,9 +282,9 @

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

2018-01-31 Thread Marcel Apfelbaum
On 01/02/2018 4:22, Michael S. Tsirkin wrote: > On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost wrote: >> On Wed, Jan 31, 2018 at 11:10:07PM +0200, Michael S. Tsirkin wrote: >>> On Wed, Jan 31, 2018 at 06:40:59PM -0200, Eduardo Habkost wrote: On Wed, Jan 17, 2018 at 11:54:18AM +0200,

[Qemu-devel] [PULL 1/2] block/ssh: fix possible segmentation fault when .desc is not null-terminated

2018-01-31 Thread Jeff Cody
From: Murilo Opsfelder Araujo This patch prevents a possible segmentation fault when .desc members are checked against NULL. The ssh_runtime_opts was added by commit 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("block/ssh: Use QemuOpts for runtime options"). This fix was inspired by http://lists.n

[Qemu-devel] [PULL 2/2] iotests: Make 200 run on tmpfs

2018-01-31 Thread Jeff Cody
From: Max Reitz 200 currently fails on tmpfs because it sets cache=none. However, without that (and aio=native), the test still works now and it fails before Jeff's series (on fc7dbc119e0852a70dc9fa68bb41a318e49e4cd6). So we can probably remove the aio=native safely, and replace cache=none by c

[Qemu-devel] [PULL 0/2] Block patches

2018-01-31 Thread Jeff Cody
The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into staging (2018-01-31 15:50:29 +) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-01-31 Thread Dan Williams
[ adding Michal and lsf-pci ] On Wed, Jan 31, 2018 at 7:02 PM, Dan Williams wrote: > On Wed, Jan 31, 2018 at 6:29 PM, Haozhong Zhang > wrote: >> + vfio maintainer Alex Williamson in case my understanding of vfio is >> incorrect. >> >> On 01/31/18 16:32 -0800, Dan Williams wrote: >>> On Wed, Jan

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-01-31 Thread Dan Williams
On Wed, Jan 31, 2018 at 6:29 PM, Haozhong Zhang wrote: > + vfio maintainer Alex Williamson in case my understanding of vfio is > incorrect. > > On 01/31/18 16:32 -0800, Dan Williams wrote: >> On Wed, Jan 31, 2018 at 4:24 PM, Haozhong Zhang >> wrote: >> > On 01/31/18 16:08 -0800, Dan Williams wro

Re: [Qemu-devel] Windows balloon driver PFN issue

2018-01-31 Thread Peter Xu
On Thu, Feb 01, 2018 at 04:24:40AM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 01, 2018 at 10:18:53AM +0800, Peter Xu wrote: > > On Wed, Jan 31, 2018 at 04:03:12PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Jan 31, 2018 at 05:28:35PM +0800, Peter Xu wrote: > > > > Hi, Michael and the list, >

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-01-31 Thread Haozhong Zhang
+ vfio maintainer Alex Williamson in case my understanding of vfio is incorrect. On 01/31/18 16:32 -0800, Dan Williams wrote: > On Wed, Jan 31, 2018 at 4:24 PM, Haozhong Zhang > wrote: > > On 01/31/18 16:08 -0800, Dan Williams wrote: > >> On Wed, Jan 31, 2018 at 4:02 PM, Haozhong Zhang > >> wrot

Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes

2018-01-31 Thread Fam Zheng
On Wed, Jan 31, 2018 at 11:48 PM, Thomas Huth wrote: > On 31.01.2018 15:48, Markus Armbruster wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes, with the change >> to ta

Re: [Qemu-devel] [PATCH v5 2/5] migration: Set the migration tcp port

2018-01-31 Thread Peter Xu
On Wed, Jan 31, 2018 at 01:35:33PM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jan 29, 2018 at 01:17:51PM +0100, Juan Quintela wrote: > >> We can set the port parameter as zero. This patch lets us know what > >> port the system was choosen for us. Now we can migrate to this place.

Re: [Qemu-devel] [PATCH v2] Small IPMI fixes

2018-01-31 Thread Michael S. Tsirkin
On Wed, Jan 31, 2018 at 06:52:25PM +0100, Greg Kurz wrote: > On Tue, 23 Jan 2018 10:55:15 -0600 > Corey Minyard wrote: > > > Michael?  Anyone?  Can we get these in? > > > > Since you're adding yourself as a maintainer for IPMI, why not just sending > a pull request ? Alternatively if you want

Re: [Qemu-devel] Windows balloon driver PFN issue

2018-01-31 Thread Michael S. Tsirkin
On Thu, Feb 01, 2018 at 10:18:53AM +0800, Peter Xu wrote: > On Wed, Jan 31, 2018 at 04:03:12PM +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 31, 2018 at 05:28:35PM +0800, Peter Xu wrote: > > > Hi, Michael and the list, > > > > > > I observed this on windows 8 enterprise guests, when doing memor

Re: [Qemu-devel] [RFC PATCH qemu v6] vfio-pci: Allow mmap of MSIX BAR

2018-01-31 Thread Alexey Kardashevskiy
On 01/02/18 05:57, Alex Williamson wrote: > On Wed, 31 Jan 2018 18:24:45 +1100 > Alexey Kardashevskiy wrote: > >> This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability >> which tells that a region with MSIX data can be mapped entirely, i.e. >> the VFIO PCI driver won't prevent MSI

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

2018-01-31 Thread Michael S. Tsirkin
On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost wrote: > On Wed, Jan 31, 2018 at 11:10:07PM +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 31, 2018 at 06:40:59PM -0200, Eduardo Habkost wrote: > > > On Wed, Jan 17, 2018 at 11:54:18AM +0200, Marcel Apfelbaum wrote: > > > > Currently only

[Qemu-devel] [PATCH v3] docs: Add docs/devel/testing.rst

2018-01-31 Thread Fam Zheng
To make our efforts on QEMU testing easier to consume by contributors, let's add a document. For example, Patchew reports build errors on patches that should be relatively easy to reproduce with a few steps, and it is much nicer if there is such a documentation that it can refer to. This focuses o

Re: [Qemu-devel] [PATCH] block/mirror: change the semantic of 'force' of block-job-cancel

2018-01-31 Thread Liang Li
On Tue, Jan 30, 2018 at 03:18:31PM -0500, John Snow wrote: > > > On 01/30/2018 03:38 AM, Liang Li wrote: >> When doing drive mirror to a low speed shared storage, if there was heavy >> BLK IO write workload in VM after the 'ready' event, drive mirror block job >> can't be canceled immediately, it

Re: [Qemu-devel] Windows balloon driver PFN issue

2018-01-31 Thread Peter Xu
On Wed, Jan 31, 2018 at 04:03:12PM +0200, Michael S. Tsirkin wrote: > On Wed, Jan 31, 2018 at 05:28:35PM +0800, Peter Xu wrote: > > Hi, Michael and the list, > > > > I observed this on windows 8 enterprise guests, when doing memory > > ballooning: > > > > 23892@1517298572.328354:virtio_balloon_t

Re: [Qemu-devel] [PATCH v2] docs: Add docs/devel/testing.rst

2018-01-31 Thread Fam Zheng
On Wed, Jan 31, 2018 at 10:24 PM, Eric Blake wrote: > On 01/30/2018 09:28 PM, Fam Zheng wrote: >> To make our efforts on QEMU testing easier to consume by contributors, >> let's add a document. For example, Patchew reports build errors on >> patches that should be relatively easy to reproduce with

Re: [Qemu-devel] [PATCH] block/mirror: change the semantic of 'force' of block-job-cancel

2018-01-31 Thread Liang Li
On Tue, Jan 30, 2018 at 08:20:03AM -0600, Eric Blake wrote: > On 01/30/2018 02:38 AM, Liang Li wrote: >> When doing drive mirror to a low speed shared storage, if there was heavy >> BLK IO write workload in VM after the 'ready' event, drive mirror block job >> can't be canceled immediately, it woul

Re: [Qemu-devel] vhost-user question

2018-01-31 Thread jack.chen
thanks,but I really can not understand how the fd works,can someone explain it or give me some reference material?? 2018-02-01 1:31 GMT+08:00 Dr. David Alan Gilbert : > * jack.chen (zhun...@gmail.com) wrote: >> hello,I am confused when I read vhost-user source code in qemu.I know >> vhost-user a

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

2018-01-31 Thread David Gibson
On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote: > This matches what other files do for qemu includes > > Signed-off-by: BALATON Zoltan Applied, thanks. > --- > hw/ide/sii3112.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/ide/sii3112.c b/hw/i

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-31 Thread Fam Zheng
On Thu, Feb 1, 2018 at 2:58 AM, Max Reitz wrote: > On 2018-01-30 07:25, Fam Zheng wrote: >> This reverts commit 76bf133c4 which updated the reference output, and >> fixed the reference image, because the code path we want to exercise is >> actually the invalid image size. >> >> The descriptor bloc

Re: [Qemu-devel] [PATCH v3 18/18] sdcard: add an enum for the SD PHY Spec version

2018-01-31 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé wrote: > So far this device intends to model the Spec v1.10 > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/sd/sd.c b

Re: [Qemu-devel] [PATCH v3 13/18] sdcard: simplify SEND_IF_COND (CMD8)

2018-01-31 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé wrote: > replace switch(single case) -> if() > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 26 +++--- > 1 file changed, 11 insertions(+), 15 deletions(-) > > di

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-01-31 Thread Dan Williams
On Wed, Jan 31, 2018 at 4:24 PM, Haozhong Zhang wrote: > On 01/31/18 16:08 -0800, Dan Williams wrote: >> On Wed, Jan 31, 2018 at 4:02 PM, Haozhong Zhang >> wrote: >> > On 01/31/18 14:25 -0800, Dan Williams wrote: >> >> On Tue, Jan 30, 2018 at 10:02 PM, Haozhong Zhang >> >> wrote: >> >> > Linux 4

Re: [Qemu-devel] [PATCH v3 11/18] sdcard: check the card is in correct state for APP CMD (CMD55)

2018-01-31 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index bbf9496e8a..434d1fbc47 100644 > --

Re: [Qemu-devel] [PATCH v3 12/18] sdcard: warn if host uses an incorrect address for APP CMD (CMD55)

2018-01-31 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 434d1fbc47..b5c947df62 100644 > --- a

Re: [Qemu-devel] [PATCH v2] docs: Add docs/devel/testing.rst

2018-01-31 Thread Fam Zheng
On Wed, Jan 31, 2018 at 9:49 PM, Andrew Jones wrote: > On Wed, Jan 31, 2018 at 11:28:00AM +0800, Fam Zheng wrote: >> +On top of libqtest, a higher level library, ``libqos``, was created to >> +encapsulate common tasks of device drivers, such as memory management and >> +communicating with system b

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-01-31 Thread Haozhong Zhang
On 01/31/18 16:08 -0800, Dan Williams wrote: > On Wed, Jan 31, 2018 at 4:02 PM, Haozhong Zhang > wrote: > > On 01/31/18 14:25 -0800, Dan Williams wrote: > >> On Tue, Jan 30, 2018 at 10:02 PM, Haozhong Zhang > >> wrote: > >> > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to >

Re: [Qemu-devel] [PATCH v3 10/18] sdcard: handle CMD54 (SDIO)

2018-01-31 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé wrote: > Linux uses it to poll the bus before polling for a card. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v3 09/18] sdcard: handles more commands in SPI mode

2018-01-31 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 57 ++--- > 1 file changed, 54 insertions(+), 3 deletions(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 2eca999bc3

Re: [Qemu-devel] [RFC v3 00/14] blockjobs: add explicit job management

2018-01-31 Thread John Snow
On 01/26/2018 09:05 PM, John Snow wrote: > For jobs that complete when a monitor isn't looking, there's no way to > tell what the job's final return code was. We need to allow jobs to > remain in the list until queried for reliable management. > > Furthermore, it's not viable to have graph chang

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-01-31 Thread Dan Williams
On Wed, Jan 31, 2018 at 4:02 PM, Haozhong Zhang wrote: > On 01/31/18 14:25 -0800, Dan Williams wrote: >> On Tue, Jan 30, 2018 at 10:02 PM, Haozhong Zhang >> wrote: >> > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to >> > guarantee the write persistence to mmap'ed files suppo

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-01-31 Thread Haozhong Zhang
On 01/31/18 14:25 -0800, Dan Williams wrote: > On Tue, Jan 30, 2018 at 10:02 PM, Haozhong Zhang > wrote: > > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > > files on ext4/xfs file system mounted wit

Re: [Qemu-devel] [RfC PATCH v2 4/5] vfio/display: core & wireup

2018-01-31 Thread Alex Williamson
On Wed, 31 Jan 2018 23:42:49 + "Zhang, Tina" wrote: > > @@ -2977,6 +2984,8 @@ static void vfio_instance_init(Object *obj) static > > Property vfio_pci_dev_properties[] = { > > DEFINE_PROP_PCI_HOST_DEVADDR("host", VFIOPCIDevice, host), > > DEFINE_PROP_STRING("sysfsdev", VFIOPCIDevice

Re: [Qemu-devel] [RfC PATCH v2 4/5] vfio/display: core & wireup

2018-01-31 Thread Zhang, Tina
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Wednesday, January 31, 2018 8:12 PM > To: qemu-devel@nongnu.org > Cc: Alex Williamson ; Zhang, Tina > ; intel-gvt-...@lists.freedesktop.org; Kirti Wankhede > ; Gerd Hoffmann > Subject: [RfC PATCH v2 4/5] vfio/d

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

2018-01-31 Thread Eduardo Habkost
On Wed, Jan 31, 2018 at 11:10:07PM +0200, Michael S. Tsirkin wrote: > On Wed, Jan 31, 2018 at 06:40:59PM -0200, Eduardo Habkost wrote: > > On Wed, Jan 17, 2018 at 11:54:18AM +0200, Marcel Apfelbaum wrote: > > > Currently only file backed memory backend can > > > be created with a "share" flag in or

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-01-31 Thread Programmingkid
> On Jan 31, 2018, at 4:03 AM, Gerd Hoffmann wrote: > >>> What about the other hotkeys? >>> >>> There is fullscreen. Ctrl-Alt-F for SDL and GTK. Cmd-F for cocoa, but >>> it works only if the grab is not active. >> >> If has to be that way because the meta (command) key is sent to the >> gues

Re: [Qemu-devel] MTTCG External Halt

2018-01-31 Thread Alistair Francis
On Wed, Jan 31, 2018 at 12:32 PM, Alex Bennée wrote: > > Alistair Francis writes: > >> On Tue, Jan 30, 2018 at 8:26 PM, Paolo Bonzini wrote: >>> On 30/01/2018 18:56, Alistair Francis wrote: I don't have a good solution though, as setting CPU_INTERRUPT_RESET doesn't help (that isn'

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-01-31 Thread Dan Williams
On Tue, Jan 30, 2018 at 10:02 PM, Haozhong Zhang wrote: > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > files on ext4/xfs file system mounted with '-o dax'). Wait, MAP_SYNC does not guarantee persist

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-31 Thread Programmingkid
> On Jan 31, 2018, at 4:43 PM, Programmingkid wrote: > >> >> On Jan 31, 2018, at 4:22 AM, Gerd Hoffmann wrote: >> >> On Tue, Jan 30, 2018 at 10:30:46AM -0500, Programmingkid wrote: >>> On Jan 30, 2018, at 4:41 AM, Gerd Hoffmann wrote: > @@ -148,15 +142,16 @@ static int irq_of

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-31 Thread Programmingkid
> On Jan 31, 2018, at 4:22 AM, Gerd Hoffmann wrote: > > On Tue, Jan 30, 2018 at 10:30:46AM -0500, Programmingkid wrote: >> >>> On Jan 30, 2018, at 4:41 AM, Gerd Hoffmann wrote: >>> @@ -148,15 +142,16 @@ static int irq_of_magic (int magic) #if 0 static void log_dsp (SB16State *d

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

2018-01-31 Thread Michael S. Tsirkin
On Wed, Jan 31, 2018 at 06:40:59PM -0200, Eduardo Habkost wrote: > On Wed, Jan 17, 2018 at 11:54:18AM +0200, Marcel Apfelbaum wrote: > > Currently only file backed memory backend can > > be created with a "share" flag in order to allow > > sharing guest RAM with other processes in the host. > > >

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

2018-01-31 Thread Eduardo Habkost
On Wed, Jan 17, 2018 at 11:54:18AM +0200, Marcel Apfelbaum wrote: > Currently only file backed memory backend can > be created with a "share" flag in order to allow > sharing guest RAM with other processes in the host. > > Add the "share" flag also to RAM Memory Backend > in order to allow remappi

Re: [Qemu-devel] MTTCG External Halt

2018-01-31 Thread Alex Bennée
Alistair Francis writes: > On Tue, Jan 30, 2018 at 8:26 PM, Paolo Bonzini wrote: >> On 30/01/2018 18:56, Alistair Francis wrote: >>> >>> I don't have a good solution though, as setting CPU_INTERRUPT_RESET >>> doesn't help (that isn't handled while we are halted) and >>> async_run_on_cpu()/run_o

Re: [Qemu-devel] [PATCH v3 20/39] qcow2: Update qcow2_get_cluster_offset() to support L2 slices

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > qcow2_get_cluster_offset() checks how many contiguous bytes are > available at a given offset. The returned number of bytes is limited > by the amount that can be addressed without having to load more than > one L2 table. > > Since we'll be loading L2 s

Re: [Qemu-devel] [RfC PATCH v2 0/5] vfio: add display support

2018-01-31 Thread Alex Williamson
On Wed, 31 Jan 2018 13:12:12 +0100 Gerd Hoffmann wrote: > This series adds support for a vgpu display to the qemu vfio code. > For now only regions are supported, dmabufs will follow later. > > The vfio API update is done, queued in drm-next, should land in the > upstream kernel during the 4.16

[Qemu-devel] [PATCH] tests/migration: Add source to PC boot block

2018-01-31 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The boot block used in the migration test is currently only shipped as a hex (with the source in the git commit message), change this to actually include the source. A makefile rule is added, but the expectation is that the generated hex is shipped as well as the .

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Ard Biesheuvel
On 31 January 2018 at 19:12, Christoffer Dall wrote: > On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel > wrote: >> On 31 January 2018 at 17:39, Christoffer Dall >> wrote: >>> On Wed, Jan 31, 2018 at 5:59 PM, Ard Biesheuvel >>> wrote: On 31 January 2018 at 16:53, Christoffer Dall wrot

Re: [Qemu-devel] [PATCH v3 19/39] qcow2: Update get_cluster_table() to support L2 slices

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This patch updates get_cluster_table() to return L2 slices instead of > full L2 tables. > > The code itself needs almost no changes, it only needs to call > offset_to_l2_slice_index() instead of offset_to_l2_index(). This patch > also renames all the re

Re: [Qemu-devel] [PATCH v3 18/39] qcow2: Refactor get_cluster_table()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > After the previous patch we're now always using l2_load() in > get_cluster_table() regardless of whether a new L2 table has to be > allocated or not. > > This patch refactors that part of the code to use one single l2_load() > call. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This patch updates l2_allocate() to support the qcow2 cache returning > L2 slices instead of full L2 tables. > > The old code simply gets an L2 table from the cache and initializes it > with zeroes or with the contents of an existing table. With a cache

Re: [Qemu-devel] [PATCH v3 16/39] qcow2: Prepare l2_allocate() for adding L2 slice support

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > Adding support for L2 slices to l2_allocate() needs (among other > things) an extra loop that iterates over all slices of a new L2 table. > > Putting all changes in one patch would make it hard to read because > all semantic changes would be mixed with

Re: [Qemu-devel] [PATCH v3 15/39] qcow2: Update l2_load() to support L2 slices

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > Each entry in the qcow2 L2 cache stores a full L2 table (which uses a > complete cluster in the qcow2 image). A cluster is usually too large > to be used efficiently as the size for a cache entry, so we want to > decouple both values by allowing smaller

Re: [Qemu-devel] [PATCH v3 14/39] qcow2: Add offset_to_l2_slice_index()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > Similar to offset_to_l2_index(), this function takes a guest offset > and returns the index in the L2 slice that contains its L2 entry. > > An L2 slice has currently the same size as an L2 table (one cluster), > so both functions return the same value f

Re: [Qemu-devel] [PATCH v3 13/39] qcow2: Add l2_slice_size field to BDRVQcow2State

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > The BDRVQcow2State structure contains an l2_size field, which stores > the number of 64-bit entries in an L2 table. > > For efficiency reasons we want to be able to load slices instead of > full L2 tables, so we need to know how many entries an L2 slice

Re: [Qemu-devel] [PATCH v3 12/39] qcow2: Add offset_to_l1_index()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > Similar to offset_to_l2_index(), this function returns the index in > the L1 table for a given guest offset. This is only used in a couple > of places and it's not a particularly complex calculation, but it > makes the code a bit more readable. > > Alth

Re: [Qemu-devel] [PATCH v3 11/39] qcow2: Remove BDS parameter from qcow2_cache_is_table_offset()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function was only using the BlockDriverState parameter to pass it > to qcow2_cache_get_table_addr(). This is no longer necessary so this > parameter can be removed. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2-

Re: [Qemu-devel] [PATCH v3 10/39] qcow2: Remove BDS parameter from qcow2_cache_discard()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function was only using the BlockDriverState parameter to pass it > to qcow2_cache_get_table_idx() and qcow2_cache_table_release(). This > is no longer necessary so this parameter can be removed. > > Signed-off-by: Alberto Garcia > Reviewed-by: Er

Re: [Qemu-devel] MTTCG External Halt

2018-01-31 Thread Alistair Francis
On Wed, Jan 31, 2018 at 10:59 AM, Peter Maydell wrote: > On 31 January 2018 at 18:51, Alistair Francis wrote: >> On Wed, Jan 31, 2018 at 10:48 AM, Peter Maydell >> wrote: >>> On 31 January 2018 at 18:17, Alistair Francis wrote: On Wed, Jan 31, 2018 at 9:13 AM, Paolo Bonzini wrote: > c

Re: [Qemu-devel] [PATCH v3 09/39] qcow2: Remove BDS parameter from qcow2_cache_clean_unused()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function was only using the BlockDriverState parameter to pass it > to qcow2_cache_table_release(). This is no longer necessary so this > parameter can be removed. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2-c

Re: [Qemu-devel] [PATCH v3 08/39] qcow2: Remove BDS parameter from qcow2_cache_destroy()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function was never using the BlockDriverState parameter so it can > be safely removed. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2-cache.c | 2 +- > block/qcow2.c | 16 > block/qcow2.h

Re: [Qemu-devel] [PATCH v3 07/39] qcow2: Remove BDS parameter from qcow2_cache_put()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function was only using the BlockDriverState parameter to pass it > to qcow2_cache_get_table_idx(). This is no longer necessary so this > parameter can be removed. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2-c

Re: [Qemu-devel] [PATCH v3 06/39] qcow2: Remove BDS parameter from qcow2_cache_entry_mark_dirty()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function was only using the BlockDriverState parameter to pass it > to qcow2_cache_get_table_idx(). This is no longer necessary so this > parameter can be removed. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2-c

Re: [Qemu-devel] [PATCH v3 05/39] qcow2: Remove BDS parameter from qcow2_cache_table_release()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function was only using the BlockDriverState parameter to get the > cache table size (since it was equal to the cluster size). This is no > longer necessary so this parameter can be removed. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Bl

Re: [Qemu-devel] [PATCH v3 04/39] qcow2: Remove BDS parameter from qcow2_cache_get_table_idx()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function was only using the BlockDriverState parameter to get the > cache table size (since it was equal to the cluster size). This is no > longer necessary so this parameter can be removed. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Bl

Re: [Qemu-devel] [PATCH v3 03/39] qcow2: Remove BDS parameter from qcow2_cache_get_table_addr()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function was only using the BlockDriverState parameter to get the > cache table size (since it was equal to the cluster size). This is no > longer necessary so this parameter can be removed. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Bl

Re: [Qemu-devel] [PATCH v3 02/39] qcow2: Add table size field to Qcow2Cache

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > The table size in the qcow2 cache is currently equal to the cluster > size. This doesn't allow us to use the cache memory efficiently, > particularly with large cluster sizes, so we need to be able to have > smaller cache tables that are independent from

Re: [Qemu-devel] [PATCH v3 39/39] iotests: Add l2-cache-entry-size to iotest 137

2018-01-31 Thread Eric Blake
On 01/26/2018 09:00 AM, Alberto Garcia wrote: > This test tries reopening a qcow2 image with valid and invalid > options. This patch adds l2-cache-entry-size to the set. > > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/137 | 5 + > tests/qemu-iotests/137.out | 2 ++ > 2 files

Re: [Qemu-devel] [PATCH v3 38/39] iotests: Test downgrading an image using a small L2 slice size

2018-01-31 Thread Eric Blake
On 01/26/2018 09:00 AM, Alberto Garcia wrote: > expand_zero_clusters_in_l1() is used when downgrading qcow2 images > from v3 to v2 (compat=0.10). This is one of the functions that needed > more changes to support L2 slices, so this patch extends iotest 061 to > test downgrading a qcow2 image using

Re: [Qemu-devel] [PATCH v3 37/39] iotests: Test valid values of l2-cache-entry-size

2018-01-31 Thread Eric Blake
On 01/26/2018 09:00 AM, Alberto Garcia wrote: > The l2-cache-entry-size setting can only contain values that are > powers of two between 512 and the cluster size. > > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/103 | 17 + > tests/qemu-iotests/103.out | 3 +++ >

Re: [Qemu-devel] [PATCH v3 36/39] qcow2: Allow configuring the L2 slice size

2018-01-31 Thread Eric Blake
On 01/26/2018 09:00 AM, Alberto Garcia wrote: > Now that the code is ready to handle L2 slices we can finally add an > option to allow configuring their size. > > An L2 slice is the portion of an L2 table that is read by the qcow2 > cache. Until now the cache was always reading full L2 tables, and

Re: [Qemu-devel] [PATCH v3 01/39] qcow2: Fix documentation of get_cluster_table()

2018-01-31 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > This function has not been returning the offset of the L2 table since > commit 3948d1d4876065160583e79533bf604481063833 > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2-cluster.c | 3 +-- > 1 file changed, 1 insertion(+

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-31 Thread Christoffer Dall
On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel wrote: > On 31 January 2018 at 17:39, Christoffer Dall > wrote: >> On Wed, Jan 31, 2018 at 5:59 PM, Ard Biesheuvel >> wrote: >>> On 31 January 2018 at 16:53, Christoffer Dall >>> wrote: On Wed, Jan 31, 2018 at 4:18 PM, Ard Biesheuvel wr

Re: [Qemu-devel] [PATCH v2] block: maintain persistent disabled bitmaps

2018-01-31 Thread Max Reitz
On 2018-01-29 19:43, Max Reitz wrote: > On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote: >> To maintain load/store disabled bitmap there is new approach: >> >> - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored >> - store enabled bitmaps as "auto" to qcow2 >> - store d

Re: [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization

2018-01-31 Thread Max Reitz
On 2018-01-31 20:01, John Snow wrote: > > > On 01/31/2018 01:54 PM, Max Reitz wrote: >> On 2018-01-18 11:58, Liang Li wrote: >>> The .count of HBitmap is forgot to set in function >>> hbitmap_deserialize_finish, let's set it to the right value. >>> >>> Cc: Vladimir Sementsov-Ogievskiy >>> Cc: Fa

Re: [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization

2018-01-31 Thread John Snow
On 01/31/2018 01:54 PM, Max Reitz wrote: > On 2018-01-18 11:58, Liang Li wrote: >> The .count of HBitmap is forgot to set in function >> hbitmap_deserialize_finish, let's set it to the right value. >> >> Cc: Vladimir Sementsov-Ogievskiy >> Cc: Fam Zheng >> Cc: Max Reitz >> Cc: John Snow >> Si

Re: [Qemu-devel] MTTCG External Halt

2018-01-31 Thread Peter Maydell
On 31 January 2018 at 18:51, Alistair Francis wrote: > On Wed, Jan 31, 2018 at 10:48 AM, Peter Maydell > wrote: >> On 31 January 2018 at 18:17, Alistair Francis wrote: >>> On Wed, Jan 31, 2018 at 9:13 AM, Paolo Bonzini wrote: cpu->halted = false likewise should not be needed here, but you

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-31 Thread Max Reitz
On 2018-01-30 07:25, Fam Zheng wrote: > This reverts commit 76bf133c4 which updated the reference output, and > fixed the reference image, because the code path we want to exercise is > actually the invalid image size. > > The descriptor block in the image, which includes the CID to verify, has be

Re: [Qemu-devel] [RFC PATCH qemu v6] vfio-pci: Allow mmap of MSIX BAR

2018-01-31 Thread Alex Williamson
On Wed, 31 Jan 2018 18:24:45 +1100 Alexey Kardashevskiy wrote: > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > which tells that a region with MSIX data can be mapped entirely, i.e. > the VFIO PCI driver won't prevent MSIX vectors area from being mapped. > > With this ch

Re: [Qemu-devel] MTTCG External Halt

2018-01-31 Thread Alistair Francis
On Wed, Jan 31, 2018 at 10:51 AM, Alistair Francis wrote: > On Wed, Jan 31, 2018 at 10:48 AM, Peter Maydell > wrote: >> On 31 January 2018 at 18:17, Alistair Francis wrote: >>> On Wed, Jan 31, 2018 at 9:13 AM, Paolo Bonzini wrote: cpu->halted = false likewise should not be needed here, but

Re: [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization

2018-01-31 Thread Max Reitz
On 2018-01-18 11:58, Liang Li wrote: > The .count of HBitmap is forgot to set in function > hbitmap_deserialize_finish, let's set it to the right value. > > Cc: Vladimir Sementsov-Ogievskiy > Cc: Fam Zheng > Cc: Max Reitz > Cc: John Snow > Signed-off-by: weiping zhang > Signed-off-by: Liang L

Re: [Qemu-devel] MTTCG External Halt

2018-01-31 Thread Alistair Francis
On Wed, Jan 31, 2018 at 10:48 AM, Peter Maydell wrote: > On 31 January 2018 at 18:17, Alistair Francis wrote: >> On Wed, Jan 31, 2018 at 9:13 AM, Paolo Bonzini wrote: >>> cpu->halted = false likewise should not be needed here, but you cannot >>> just clear CPU_INTERRUPT_HALT either. You need to

Re: [Qemu-devel] MTTCG External Halt

2018-01-31 Thread Peter Maydell
On 31 January 2018 at 18:17, Alistair Francis wrote: > On Wed, Jan 31, 2018 at 9:13 AM, Paolo Bonzini wrote: >> cpu->halted = false likewise should not be needed here, but you cannot >> just clear CPU_INTERRUPT_HALT either. You need to set a *different* >> interrupt request bit (the dummy CPU_IN

Re: [Qemu-devel] [PATCH v7 8/9] qcow2: skip writing zero buffers to empty COW areas

2018-01-31 Thread Eric Blake
On 01/31/2018 12:35 PM, Max Reitz wrote: >>> Not sure how useful 2 is, though. (I don't know. I always hear about >>> people wanting to optimize for such a case where a backing file is >>> shorter than the overlay, but I can't imagine a real use case for that.) >> >> I can; here's what's happene

Re: [Qemu-devel] [Bug 1739304] Re: Passing a directory to (eg.) -cdrom results in misleading error message

2018-01-31 Thread John Snow
On 01/31/2018 01:36 PM, Michal Suchánek wrote: > On Wed, 20 Dec 2017 21:57:00 -0500 > John Snow wrote: > >> On 12/20/2017 05:31 AM, Dr. David Alan Gilbert wrote: >>> Yep, can repeat it here, it seems pretty random which error it >>> gives: >>> >>> [dgilbert@dgilbert-t530 try]$ ./x86_64-softmmu/

Re: [Qemu-devel] [PATCH v4] file-posix: specify expected filetypes

2018-01-31 Thread John Snow
ping On 01/19/2018 06:03 PM, Eric Blake wrote: > On 01/19/2018 04:47 PM, John Snow wrote: >> Adjust each caller of raw_open_common to specify if they are expecting >> host and character devices or not. Tighten expectations of file types upon >> open in the common code and refuse types that are not

  1   2   3   >