Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

On 2017/12/21 0:44, Halil Pasic wrote: > Meta: Updated Connie's email. > > On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: >> From: Gonglei >> >> The virtio crypto device is a virtual crypto device (ie. hardware >> crypto accelerator card). Currently, the virtio crypto device provides >> the fol

[Qemu-devel] [PATCH RESEND v4] vhost: set used memslots for vhost-user and vhost-kernel respectively

Used_memslots is equal to dev->mem->nregions now, it is true for vhost kernel, but not for vhost user, which uses the memory regions that have file descriptor. In fact, not all of the memory regions have file descriptor. It is usefully in some scenarios, e.g. used_memslots is 8, and only 5 memory s

Re: [Qemu-devel] [PATCH v4] vhost: set used memslots for vhost-user and vhost-kernel respectively

> -Original Message- > From: Zhoujian (jay) > Sent: Saturday, December 30, 2017 3:06 AM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; imamm...@redhat.com; Huangweidong (C) > ; wangxin (U) ; > Gonglei (Arei) ; Zhoujian (jay) > ; Liuzhe (Cloud Open Labs, NFV) > > Subject: [PATCH v4] v

[Qemu-devel] [PULL v2 0/8] tcg queued patches

ommit 281f327487c9c9b1599f93c589a408bbf4a651b8: Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2017-12-22 00:11:36 +) are available in the Git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20171229 for you to fetc

Re: [Qemu-devel] [PULL 0/8] tcg queued patches

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171229193113.11753-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PULL 0/8] tcg queued patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log -

[Qemu-devel] [PULL 3/8] tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*

These are now trivial sets and tests against NULL. Unwrap. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 4 --- tcg/tcg.h| 9 --- target/alpha/translate.c | 22 target/arm/translate-a64.c

[Qemu-devel] [PULL 6/8] tcg: Add tcg_signed_cond

Complimenting the existing tcg_unsigned_cond. Signed-off-by: Richard Henderson --- tcg/tcg.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tcg/tcg.h b/tcg/tcg.h index f25efa9795..8c45f7edbc 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -488,6 +488,12 @@ static inline TCGCond tcg_unsigned

[Qemu-devel] [PULL 4/8] tcg: Dynamically allocate TCGOps

With no fixed array allocation, we can't overflow a buffer. This will be important as optimizations related to host vectors may expand the number of ops used. Use QTAILQ to link the ops together. Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 9 ++-- include/qemu/queue.h

[Qemu-devel] [PULL 1/8] target/*helper: don't check retaddr before calling cpu_restore_state

From: Alex Bennée cpu_restore_state officially supports being passed an address it can't resolve the state for. As a result the checks in the helpers are superfluous and can be removed. This makes the code consistent with other users of cpu_restore_state. Of course this does nothing to address w

[Qemu-devel] [PULL 7/8] tcg: Allow 6 arguments to TCG helpers

We already handle this in the backends, and the lifetime datum for the TCGOp is already large enough. Signed-off-by: Richard Henderson --- include/exec/helper-gen.h | 11 +++ include/exec/helper-head.h | 2 ++ include/exec/helper-proto.h | 5 + include/exec/helper-tcg.h | 7 +

[Qemu-devel] [PULL 0/8] tcg queued patches

to staging (2017-12-22 00:11:36 +) are available in the Git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20171229 for you to fetch changes up to d034b92af6687e1ba436ee9541c91f78af20b47f: tcg: add cs_base and flags to -d exec output (2017-12-28 20:3

[Qemu-devel] [PULL 8/8] tcg: add cs_base and flags to -d exec output

From: Paolo Bonzini Signed-off-by: Paolo Bonzini Message-Id: <20171217055023.29225-1-pbonz...@redhat.com> [rth: Also change the Chain logging in helper_lookup_tb_ptr.] Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c| 6 -- accel/tcg/tcg-runtime.c | 5 +++-- 2 files changed, 7

[Qemu-devel] [PULL 5/8] tcg: Generalize TCGOp parameters

We had two fields specific to INDEX_op_call. Rename these and add some macros so that the fields may be reused for other opcodes. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg.h | 10 ++ tcg/optimize.c | 4 ++-- tcg/tcg.c | 22 +++--

[Qemu-devel] [PULL 2/8] target/moxie: Fix tlb_fill

We should not exit unless moxie_cpu_handle_mmu_fault has failed. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/moxie/helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/moxie/helper.c b/target/moxie/helper.c index 2ecee89f11..6890ffd71c

[Qemu-devel] [PATCH v4] vhost: set used memslots for vhost-user and vhost-kernel respectively

Used_memslots is equal to dev->mem->nregions now, it is true for vhost kernel, but not for vhost user, which uses the memory regions that have file descriptor. In fact, not all of the memory regions have file descriptor. It is usefully in some scenarios, e.g. used_memslots is 8, and only 5 memory s

Re: [Qemu-devel] [PATCH v3] vhost: add used memslot number for vhost-user and vhost-kernel separately

> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Friday, December 29, 2017 11:08 PM > To: Zhoujian (jay) > Cc: qemu-devel@nongnu.org; Huangweidong (C) ; > m...@redhat.com; wangxin (U) ; Liuzhe (Cloud > Open Labs, NFV) ; Gonglei (Arei) > > Subject: Re: [Qem

[Qemu-devel] [PATCH v3] linux-user: Use *at functions instead of caching interp_prefix contents

From: Richard Henderson If the interp_prefix is a complete chroot, it may have a *lot* of files. Setting up the cache for this is quite expensive. Instead, use the *at versions of various syscalls to attempt the operation in the prefix. Cc: Eric Blake Cc: Peter Maydell Signed-off-by: Richard

[Qemu-devel] [PATCH v3 39/42] sdhci: add a check_capab_baseclock() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 0443a23e45..2aa3fa0d3b 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -7,9 +7,

[Qemu-devel] [PATCH v3 35/42] hw/arm/xilinx_zynqmp: implement SDHCI Spec v3

Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xlnx-zynqmp.c | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 325642058b..dacf89c566 100644 --- a/hw/arm/xlnx-zynqmp.c +++ b/hw/arm/xlnx-

[Qemu-devel] [PATCH v3 34/42] hw/arm/fsl-imx6: implement SDHCI Spec v3

Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/fsl-imx6.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c index 59ef33efa9..d4de428dbc 100644 --- a/hw/arm/fsl-imx6.c +++ b/hw/arm/fsl-imx6.c @@ -348,6 +348,18 @@ static void fsl_imx6_realize

[Qemu-devel] [PATCH v3 33/42] hw/arm/bcm2835_peripherals: implement SDHCI Spec v3

Signed-off-by: Philippe Mathieu-Daudé --- Note, the bcm2835 seems to have 1KB minimum blocksize, however the current model is implemented with 512B. Can someone with access to the datasheets verify? Thanks! --- hw/arm/bcm2835_peripherals.c | 35 --- 1 file chang

[Qemu-devel] [PATCH v3 29/42] sdhci: add qtest to check the SD Spec version

with check_specs_version() Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 82 ++ tests/Makefile.include | 2 ++ 2 files changed, 84 insertions(+) create mode 100644 tests/sdhci-test.c diff --git

[Qemu-devel] [PATCH v3 27/42] hw/arm/exynos4210: implement SDHCI Spec v2

Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c index e8e1d81e62..0e6acac784 100644 --- a/hw/arm/exynos4210.c +++ b/hw/arm/exynos4210.c @@ -75,7 +75,6 @@ #de

[Qemu-devel] [PATCH v3 24/42] sdhci: add a 'dma' shortcut property

disabling it disables all DMAs at once. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sdhci.h | 1 + hw/sd/sdhci.c | 5 + 2 files changed, 6 insertions(+) diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h index 4a9c3e9175..bac37f9e11 100644 --- a/include/hw/sd/sdh

[Qemu-devel] [PATCH v3 19/42] sdhci: add basic Spec v1 capabilities

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 22 ++- include/hw/sd/sdhci.h | 6 ++ hw/sd/sdhci.c | 58 -- 3 files changed, 69 insertions(+), 17 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/

[Qemu-devel] [PATCH v3 17/42] sdhci: add a "dma-memory" property

Add a dma property allowing machine creation to provide the address-space sdhci dma operates on. [based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2016.1] Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- include/hw/sd/sdhci.h | 2 ++ hw/sd/sdhci.c

[Qemu-devel] [PATCH v3 41/42] sdhci: add a check_capab_v3() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 91b1b29d75..6ebe9f4d25 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -13,6

[Qemu-devel] [PATCH v3 14/42] sdhci: fix CAPAB/MAXCURR registers, both are 64bit and read-only

running qtests: $ make check-qtest-arm GTESTER check-qtest-arm SDHC rd_4b @0x44 not implemented SDHC wr_4b @0x40 <- 0x89abcdef not implemented SDHC wr_4b @0x44 <- 0x01234567 not implemented Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sdhci.h | 4 ++-- hw/sd/sdhci.c

[Qemu-devel] [PATCH v3 32/42] sdhci: rename the hostctl1 register

As per the Spec v3.00 Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sdhci.h | 2 +- hw/sd/sdhci.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h index 46e1e42fa1..c2da48c17c 100644 --- a/include

[Qemu-devel] [PATCH v3 15/42] sdhci: Implement write method of ACMD12ERRSTS register

From: Andrey Smirnov Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index ae84af46da..a47ed61248 100644 -

[Qemu-devel] [PATCH v3 30/42] sdhci: check Spec v2 capabilities qtest

with check_capab_capareg() Signed-off-by: Philippe Mathieu-Daudé --- tests/sdhci-test.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 492b332588..200d7bcee2 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -9,6 +9,

[Qemu-devel] [PATCH v3 42/42] sdhci: add Spec v4.2 register definitions

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 8 1 file changed, 8 insertions(+) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index 1da91a27b4..8193aa1821 100644 --- a/hw/sd/sdhci-internal.h +++ b/hw/sd/sdhci-internal.h @@ -191,6 +191,10 @@ FIELD(SDH

[Qemu-devel] [PATCH v3 13/42] sdhci: rename the SDHC_CAPAB register

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 2 +- hw/sd/sdhci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index df240ea046..b7475a1b7b 100644 --- a/hw/sd/sdhci-internal.h +++ b/hw/sd/sdhci

[Qemu-devel] [PATCH v3 28/42] hw/arm/xilinx_zynq: implement SDHCI Spec v2

Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xilinx_zynq.c | 64 1 file changed, 40 insertions(+), 24 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 1836a4ed45..9a106db7b7 100644 --- a/hw/arm/xilinx_zynq.c +++

[Qemu-devel] [PATCH v3 08/42] sdhci: use qemu_log_mask(UNIMP) instead of fprintf()

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 06a1ec6f91..afb3a794ec 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -946,7 +946,8 @@ static ui

[Qemu-devel] [PATCH v3 40/42] sdhci: add a check_capab_sdma() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 2aa3fa0d3b..91b1b29d75 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -12,6 +12,7

[Qemu-devel] [PATCH v3 37/42] sdhci: remove the deprecated 'capareg' property

All SDHCI consumers have been upgraded to set correct properties. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 38f26788df..8087e85589 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sd

[Qemu-devel] [PATCH v3 26/42] sdhci: Fix 64-bit ADMA2

From: Sai Pavan Boddu The 64-bit ADMA address is not converted to the cpu endianes correctly. This patch fixes the issue and uses a valid mask for the attribute data. Signed-off-by: Sai Pavan Boddu [AF: Re-write commit message] Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daud

[Qemu-devel] [PATCH v3 22/42] sdhci: add DMA and 64-bit capabilities (Spec v2)

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 14 +++--- include/hw/sd/sdhci.h | 4 hw/sd/sdhci.c | 40 ++-- 3 files changed, 29 insertions(+), 29 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-inter

[Qemu-devel] [PATCH v3 38/42] sdhci: add check_capab_readonly() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index f7487808af..0443a23e45 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -

[Qemu-devel] [PATCH v3 07/42] sdhci: refactor common sysbus/pci unrealize() into sdhci_unrealizefn()

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index ad5853d527..06a1ec6f91 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -31,6 +31,7 @@ #include "qemu/bitops.h" #

[Qemu-devel] [PATCH v3 16/42] sdhci: use deposit64() on admasysaddr

This makes the code slightly safer, and easier to review. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index a47ed61248..7f2c3dc9d5 100644 --- a/hw/sd

[Qemu-devel] [PATCH v3 06/42] sdhci: refactor common sysbus/pci realize() into sdhci_realizefn()

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 38d82b4c61..ad5853d527 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1194,6 +

[Qemu-devel] [PATCH v3 20/42] sdhci: add max-block-length capability (Spec v1)

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 1 - include/hw/sd/sdhci.h | 1 + hw/sd/sdhci.c | 38 +- 3 files changed, 14 insertions(+), 26 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index 6944fc

[Qemu-devel] [PATCH v3 36/42] sdhci: check Spec v3 capabilities qtest

Signed-off-by: Philippe Mathieu-Daudé --- tests/sdhci-test.c | 12 tests/Makefile.include | 1 + 2 files changed, 13 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 200d7bcee2..f7487808af 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -29,9

[Qemu-devel] [PATCH v3 23/42] sdhci: default to Spec v2

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index b8749b6f42..dac5c48196 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1293,7 +1293,7 @@ const VMStateDescription sdhci_vmstate = { /

[Qemu-devel] [PATCH v3 12/42] sdhci: use FIELD_DP32() macro for the WRITE_PROTECT flag

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 6 -- hw/sd/sdhci.c | 8 ++-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index e941bc2386..df240ea046 100644 --- a/hw/sd/sdhci-internal.h +++ b/h

[Qemu-devel] [PATCH v3 05/42] sdhci: refactor common sysbus/pci class_init() into sdhci_class_init()

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index a11469fbca..38d82b4c61 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1275,6 +1275,16 @@ static Property sdhc

[Qemu-devel] [PATCH v3 11/42] sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h"

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 1 + hw/sd/sdhci.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index 248fd027f9..e941bc2386 100644 --- a/hw/sd/sdh

[Qemu-devel] [PATCH v3 10/42] sdhci: add a GPIO for the 'access control' LED

It blinks to caution the user not to remove the card while the SD card is being accessed. So far it only emit a trace event. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sdhci.h | 2 ++ hw/sd/sdhci.c | 14 ++ hw/sd/trace-events| 1 + 3 files changed, 17 inser

[Qemu-devel] [PATCH v3 04/42] sdhci: refactor same sysbus/pci properties into a common one

add sysbus/pci/sdbus separator comments to keep it clearer Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 365bc80009..a11469fbca 100644 --- a/hw/sd/sdhci.c +++

[Qemu-devel] [PATCH v3 18/42] sdhci: add a spec_version property

default to Spec v2.00 Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 4 ++-- include/hw/sd/sdhci.h | 3 +++ hw/sd/sdhci.c | 19 +-- 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h inde

[Qemu-devel] [PATCH v3 09/42] sdhci: convert the DPRINT() calls into trace events

zero-initialize ADMADescr 'dscr' in sdhci_do_adma() to avoid: hw/sd/sdhci.c: In function ‘sdhci_do_adma’: hw/sd/sdhci.c:714:29: error: ‘dscr.addr’ may be used uninitialized in this function [-Werror=maybe-uninitialized] trace_sdhci_adma("link", s->admasysaddr);

[Qemu-devel] [PATCH v3 03/42] sdhci: remove dead code

Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sdhci.h | 2 -- hw/sd/sdhci.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h index 749cc279ed..a6fe064f51 100644 --- a/include/hw/sd/sdhci.h +++ b/include/hw/sd/sdhci.h @@ -44,8 +4

[Qemu-devel] [PATCH v3 01/42] sdhci: clean up includes

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 4 include/hw/sd/sdhci.h | 7 ++- hw/sd/sdhci.c | 1 + 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index 161177cf

[Qemu-devel] [PATCH v3 02/42] sdhci: sort registers comments

Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sdhci.h | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h index 1335373d3c..749cc279ed 100644 --- a/include/hw/sd/sdhci.h +++ b/include/hw/sd/sdhci.h @@ -

[Qemu-devel] [PATCH v3 00/42] SDHCI: housekeeping, add a qtest and fix few issues

Since v2: - more detailed 'capabilities', all boards converted to use these properties - since all qtests pass, removed the previous 'capareg' property - added Stefan/Alistair R-b - corrected 'access' LED behavior (Alistair's review) - more uses of the registerfields API - remove some dead code - c

Re: [Qemu-devel] [PATCH v2 04/20] sdhci: refactor same sysbus/pci properties into a common one

Hi Alistair, On 12/18/2017 10:13 PM, Alistair Francis wrote: > On Thu, Dec 14, 2017 at 7:15 PM, Philippe Mathieu-Daudé > wrote: >> add sysbus/pci/sdbus separator comments to keep it clearer >> >> Signed-off-by: Philippe Mathieu-Daudé > > I'm still unsure about this. Won't this leave us with pr

Re: [Qemu-devel] [PATCH 35/38] qom: Add MMU_DEBUG_LOAD

Hi, Since you're specifically CC'ing me, some nits: Am 29.12.2017 um 07:31 schrieb Richard Henderson: > This lets us tell bottom levels of virtual memory translation > routines that the access is from within QEMU itself and bypass > certain tests. This sentence could use a tweak for clarity: tel

[Qemu-devel] [PATCH 4/5] tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables usage

Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index af22555..81c558e 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -257,6 +257,8 @@ static void fetch_rs

[Qemu-devel] [PATCH 3/5] tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its usage

Main purpose of test_dst_table() is loading a table from QEMU with checking that checksum in header matches actual one, rename it reflect main action it performs. Likewise test_acpi_tables() name is to broad, while the function only loads tables referenced by RSDT, rename it to reflect it. Signed

[Qemu-devel] [PATCH 1/5] tests: acpi: move tested tables array allocation outside of test_acpi_dsdt_table()

at best it's confusing that array for list of tables to be tested against reference tables is allocated within test_acpi_dsdt_table() and at worst it would just overwrite list of tables if they were added before test_acpi_dsdt_table(). Move array initialization to test_acpi_one() before we start pr

[Qemu-devel] [PATCH 0/5] tests: acpi: fix FADT not being tested and cleanups

Even though we have tests/acpi-test-data/[q35|pc]/FACP reference table in source tree, it hasn't been actually tested. As result it went stale and we did not notice any changes that were happening to it. Fix it buy making sure it's not ignored and before fixing it, do some cleanups in testcase tha

[Qemu-devel] [PATCH 5/5] tests: acpi: fix FADT not being compared to reference table

It turns out that FADT isn't actually tested for changes against reference table, since it happens to be the 1st table in RSDT which is currently ignored. Fix it by making sure that all tables from RSDT are added to test list. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 4 ++-- 1

[Qemu-devel] [PATCH 2/5] tests: acpi: init table descriptor in test_dst_table()

remove code duplication and make sure that table descriptor passed in for initialization is in expected state. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c inde

Re: [Qemu-devel] [PATCH v3] vhost: add used memslot number for vhost-user and vhost-kernel separately

On Fri, 29 Dec 2017 12:54:44 + "Zhoujian (jay)" wrote: > > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: Friday, December 29, 2017 7:22 PM > > To: Zhoujian (jay) > > Cc: qemu-devel@nongnu.org; Huangweidong (C) ; > > m...@redhat.com; wangxin (

[Qemu-devel] [PATCH v3 07/16] piix4: add a i8259 interrupt controller as specified in datasheet

Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. Remove i8259 instanciated in malta board, to not have it twice. We can also remove the now unused piix4_init() function. Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 40 +---

[Qemu-devel] [PATCH v3 12/16] piix4: add a mc146818rtc controller as specified in datasheet

Remove mc146818rtc instanciated in malta board, to not have it twice. Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 12 hw/mips/mips_malta.c | 5 - 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index f672af21cd..093

[Qemu-devel] [PATCH v3 01/16] fdc: move object structures to header file

We are now able to embed floppy controllers in another object. Signed-off-by: Hervé Poussineau --- hw/block/fdc.c | 102 include/hw/block/fdc.h | 103 + 2 files changed, 103 insertions(+), 10

[Qemu-devel] [PATCH v3 04/16] mc146818rtc: always register rtc to rtc list

We are not required anymore to use rtc_init() function. Signed-off-by: Hervé Poussineau --- hw/timer/mc146818rtc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c index 3e8c0b7d33..0b0da691cc 100644 --- a/hw/timer/

[Qemu-devel] [PATCH v3 15/16] piix4: rename PIIX4 object to piix4-isa

Other piix4 parts are already named piix4-ide and piix4-usb-uhci. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 1 - hw/mips/mips_malta.c | 2 +- include/hw/isa/isa.h | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/isa/

[Qemu-devel] [PATCH v3 10/16] piix4: add a i8042 keyboard/mouse controller as specified in datasheet

Remove i8042 instanciated in malta board, to not have it twice. Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 3 +++ hw/mips/mips_malta.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index 1fd9f4f330..c5639f7640 100644 --- a/

[Qemu-devel] [PATCH v3 05/16] piix4: rename some variables in realize function

PIIX4 structure is now 's' PCI device is now 'pci' DeviceState is now 'dev' Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index 6b8bc3faf0..4f476dc7e6 100644 --- a/hw/isa/piix4.

[Qemu-devel] [PATCH v3 11/16] piix4: add a floppy controller, 1 parallel port and 2 serial ports

Remove their instanciation from malta board, to not have them twice. Automatically create serial/parallel ports in PIIX4 if not provided. Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 67 hw/mips/mips_malta.c | 41

[Qemu-devel] [PATCH v3 08/16] piix4: add a i8257 dma controller as specified in datasheet

Remove i8257 instanciated in malta board, to not have it twice. Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 3 +++ hw/mips/mips_malta.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index eb2f730fff..66fdfe25e2 100644 --- a/hw

[Qemu-devel] [PATCH v3 13/16] piix4: add a speaker as specified in datasheet

Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index 09388ff286..64526e1bb8 100644 --- a/hw/isa/piix4.c +++ b/hw/isa/piix4.c @@ -30,6 +30,7 @@ #include "hw/isa/isa.h" #include "hw/char/

[Qemu-devel] [PATCH v3 03/16] mc146818rtc: move structure to header file

We are now able to embed a timer in another object. Signed-off-by: Hervé Poussineau --- hw/timer/mc146818rtc.c | 30 -- include/hw/timer/mc146818rtc.h | 29 + 2 files changed, 29 insertions(+), 30 deletions(-) diff --git a/hw/timer

[Qemu-devel] [PATCH v3 02/16] serial/parallel: move object structures to header file

We are now able to embed serial/parallel ports in another object. Signed-off-by: Hervé Poussineau --- hw/char/parallel.c | 31 +- hw/char/serial-isa.c | 13 + hw/ppc/pnv.c | 2 +- include/hw/char/isa.h| 50 +++

[Qemu-devel] [PATCH v3 06/16] piix4: add Reset Control Register

The RCR I/O port (0xcf9) is used to generate a hard reset or a soft reset. Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index 4f476dc7e6..7c83e7c23d 100644 --- a/hw/isa/

[Qemu-devel] [PATCH v3 09/16] piix4: add a i8254 pit controller as specified in datasheet

Remove i8254 instanciated in malta board, to not have it twice. Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 4 hw/mips/mips_malta.c | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index 66fdfe25e2..1fd9f4f330 100644 ---

[Qemu-devel] [PATCH v3 14/16] piix4: convert reset function to QOM

Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index 64526e1bb8..c6691a6914 100644 --- a/hw/isa/piix4.c +++ b/hw/isa/piix4.c @@ -56,10 +56,10 @@ typedef struct PIIX4State { #define PII

[Qemu-devel] [PATCH v3 16/16] piix4: we can now instanciate a PIIX4 with -device

Note that the PIC master can't be connected to CPU using the command line, but it's not necessary to have a working ISA bus (for I/O, memory and DMA). Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index

[Qemu-devel] [PATCH v3 00/16] piix4: cleanup and improvements

Hi, This patchset is a cleanup of the PIIX4 PCI-ISA bridge. Lots of devices are moved from MIPS Malta board (which has a PIIX4) to PIIX4, where devices belong. This lets us reuse PIIX4 in other machines, while not loosing any functionality. Last patch allows adding a new PIIX4 device directly fro

Re: [Qemu-devel] [PATCH v3] vhost: add used memslot number for vhost-user and vhost-kernel separately

> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Friday, December 29, 2017 7:22 PM > To: Zhoujian (jay) > Cc: qemu-devel@nongnu.org; Huangweidong (C) ; > m...@redhat.com; wangxin (U) ; Liuzhe (Cloud > Open Labs, NFV) ; Gonglei (Arei) > > Subject: Re: [Qemu

Re: [Qemu-devel] [PATCH v3] vhost: add used memslot number for vhost-user and vhost-kernel separately

On Fri, 29 Dec 2017 10:37:40 + "Zhoujian (jay)" wrote: > Hi Igor, > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: Friday, December 29, 2017 5:31 PM > > To: Zhoujian (jay) > > Cc: qemu-devel@nongnu.org; Huangweidong (C) ; > > m...@redhat.com; w

Re: [Qemu-devel] [PATCH v3] vhost: add used memslot number for vhost-user and vhost-kernel separately

Hi Igor, > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Friday, December 29, 2017 5:31 PM > To: Zhoujian (jay) > Cc: qemu-devel@nongnu.org; Huangweidong (C) ; > m...@redhat.com; wangxin (U) ; Liuzhe (Cloud > Open Labs, NFV) ; Gonglei (Arei) > > Subject: R

Re: [Qemu-devel] [PATCH 29/38] hw/hppa: Implement DINO system board

On Thu, 28 Dec 2017 22:31:36 -0800 Richard Henderson wrote: > Now that we have the prerequisites in target/hppa/, > implement the hardware for a PA7100LC. > > This also enables build for hppa-softmmu. > > Signed-off-by: Helge Deller > [rth: Since it is all new code, squashed all branch develop

[Qemu-devel] [PATCH 2/2] pvpanic: add PVPANIC_ABORT_PROP

PVPANIC_ABORT_PROP is a boolean to instruct pvpanic to request an abort() of the process when the Guest signals a panic. Signed-off-by: Sergio Lopez --- hw/misc/pvpanic.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index 4f

[Qemu-devel] [PATCH 1/2] vl: extend qemu_system_guest_panicked with abort_on_panic

The abort_on_panic argument for qemu_system_guest_panicked allows callers to request an immediate abort() of the process. Signed-off-by: Sergio Lopez --- accel/kvm/kvm-all.c | 2 +- hw/misc/pvpanic.c | 2 +- hw/ppc/spapr_rtas.c | 2 +- include/sysemu/sysemu.h | 3 ++- target/s3

[Qemu-devel] [PATCH 0/2] pvpanic: implement abort_on_panic option

Extend pvpanic and qemu_system_guest_panicked so it's possible to configure the first to induce an abort() when the Guest panics. This is specially useful (and mainly intended to be enabled only) when debugging soft/hard lockups on the Guest OS. Sergio Lopez (2): vl: extend qemu_system_guest_pa

Re: [Qemu-devel] [PATCH v3] vhost: add used memslot number for vhost-user and vhost-kernel separately

On Fri, 29 Dec 2017 10:35:11 +0800 Jay Zhou wrote: > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that have file descriptor. In fact, not all of the memory regions > have file descriptor. > It is usefully

Re: [Qemu-devel] [PATCH v2 0/5] target/m68k: implement 680x0 FPU (part 3)

On 20.12.2017 19:25, Laurent Vivier wrote: > Le 23/11/2017 à 17:35, Laurent Vivier a écrit : >> Implement fmod, frem, fscale, fgetman and fgetexp. >> >> Instead of using functions of libm (v1 of this series) >> and converting between host long double and floatx80 type >> the new version (v2) adds n