Re: [Qemu-devel] [PATCH 0/4] cryptodev: add vhost support

2017-12-21 Thread Gonglei (Arei)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, December 21, 2017 10:25 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; Huangweidong (C); > stefa...@redhat.com; Zhoujian (jay); pa...@linux.vnet.ibm.com; longpeng; > xin.z.

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-21 Thread Markus Armbruster
Eric Blake writes: > On 12/19/2017 08:20 AM, Max Reitz wrote: > >> So there are three things: >> >> (1) We probably should not allow snapshot names that could be IDs. >> Easiest way to solve this: Names have to start with a non-digit. > > Yes, that would be a nice change. It is not strictly back

Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe

2017-12-21 Thread Hikaru Nishida
ping http://patchwork.ozlabs.org/patch/849786/ 2017-12-18 14:00 GMT+09:00 Hikaru Nishida : > Pin-based interrupt of NVMe controller did not work properly > because using an obsolated function pci_irq_pulse(). > To fix this, change to use pci_irq_assert() / pci_irq_deassert() > instead of pci_irq_p

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-12-21 Thread Liu, Yi L
On Wed, Dec 20, 2017 at 10:01:10PM +1100, David Gibson wrote: > On Wed, Dec 20, 2017 at 02:32:42PM +0800, Liu, Yi L wrote: > > On Mon, Dec 18, 2017 at 10:22:18PM +1100, David Gibson wrote: > > > On Mon, Dec 18, 2017 at 05:17:35PM +0800, Liu, Yi L wrote: > > > > On Mon, Dec 18, 2017 at 05:14:42PM +1

Re: [Qemu-devel] [PATCH] target/ppc: more use of the PPC_*() macros

2017-12-21 Thread Cédric Le Goater
On 12/22/2017 01:39 AM, David Gibson wrote: > On Thu, Dec 21, 2017 at 05:54:56PM +0100, Cédric Le Goater wrote: >> Also introduce utilities to manipulate bitmasks (originaly from OPAL) >> which be will be used in the model of the XIVE interrupt controller. >> >> Signed-off-by: Cédric Le Goater >

[Qemu-devel] [PATCH] Virt: ACPI: fix qemu assert due to re-assigned table data address

2017-12-21 Thread Shannon Zhao
acpi_data_push uses g_array_set_size to resize the memory size. If there is no enough contiguous memory, the address will be changed. If we use the old value, it will assert. qemu-kvm: hw/acpi/bios-linker-loader.c:214: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' fail

[Qemu-devel] [RFC 3/3] vhost-user: add VFIO based accelerators support

2017-12-21 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- docs/interop/vhost-user.txt| 57 ++ hw/vfio/common.c | 2 +- hw/virtio/vhost-user.c | 381 - hw/virtio/vhost.c | 3 +- hw/virtio/virtio-pci.c | 8 - hw/virtio/virtio-pci.

[Qemu-devel] [RFC 0/3] Extend vhost-user to support VFIO based accelerators

2017-12-21 Thread Tiwei Bie
This RFC patch set does some small extensions to vhost-user protocol to support VFIO based accelerators, and makes it possible to get the similar performance of VFIO passthru while keeping the virtio device emulation in QEMU. When we have virtio ring compatible devices, it's possible to setup the

[Qemu-devel] [RFC 1/3] vhost-user: support receiving file descriptors in slave_read

2017-12-21 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- hw/virtio/vhost-user.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 093675ed98..e7108138fd 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-u

[Qemu-devel] [RFC 2/3] vhost-user: introduce shared vhost-user state

2017-12-21 Thread Tiwei Bie
When multi-queue is enabled for virtio-net, each virtio queue pair will have a vhost_dev, and the only thing they share currently is the chardev. This patch introduces a vhost-user state structure which will be shared by all virtio queue pairs of the same virtio device. Signed-off-by: Tiwei Bie -

Re: [Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

2017-12-21 Thread Marcel Apfelbaum
On 22/12/2017 0:30, Yuval Shaia wrote: On Thu, Dec 21, 2017 at 10:46:35PM +0200, Michael S. Tsirkin wrote: On Thu, Dec 21, 2017 at 05:59:38PM +0200, Marcel Apfelbaum wrote: On 21/12/2017 16:22, Michael S. Tsirkin wrote: On Thu, Dec 21, 2017 at 09:27:51AM +0200, Yuval Shaia wrote: What happe

Re: [Qemu-devel] Hi, where can i get a latest full version of QAPI ?

2017-12-21 Thread 那个秀才
Thanks a lot !These are useful to me :) --发件人:Markus Armbruster 发送时间:2017年12月21日(星期四) 21:15收件人:Luiz Capitulino 抄 送:bob ; qemu-devel 主 题:Re: [Qemu-devel] Hi, where can i get a latest full version of QAPI ? Luiz Capitulino  writes:

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

2017-12-21 Thread John Snow
In the termbin: So the "good" one is on the left, and the "bad" one is on the right. The bad one is ... completely blank for the first 200+ MB? That's not great. so: .bin.apfs: broken raw file, made on apfs, no arguments(?) .bin.apfs2: broken raw file, made on apfs, `-S 0` ? .img.org: qcow2 file

[Qemu-devel] [PULL 17/18] qemu-doc: The "-net nic" option can be used with "netdev=...", too

2017-12-21 Thread Jason Wang
From: Thomas Huth Looks like we missed to document that it is also possible to specify a netdev with "-net nic" - which is very useful if you want to configure your on-board NIC to use a backend that has been specified with "-netdev". Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- q

[Qemu-devel] [PULL 15/18] net: remove unused compute_mcast_idx() function

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland Now that all of the callers have been converted to compute the multicast index inline using new net CRC functions, this function can now be dropped. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang --- net/net.c | 5 - 1 file changed, 5 deletions(-) diff -

[Qemu-devel] [PULL 14/18] rtl8139: use inline net_crc32() and bitshift instead of compute_mcast_idx()

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang --- hw/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Qemu-devel] [PULL 12/18] ftgmac100: use inline net_crc32() and bitshift instead of compute_mcast_idx()

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang --- hw/net/ftgmac100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[Qemu-devel] [PULL 08/18] sungem: fix multicast filter CRC calculation

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland >From the Linux sungem driver, we know that the multicast filter CRC is implemented using ether_crc_le() which isn't the same as calling zlib's crc32() function (the zlib implementation requires a complemented initial value and also returns the complemented result). Fix th

[Qemu-devel] [PULL 11/18] lan9118: use inline net_crc32() and bitshift instead of compute_mcast_idx()

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang --- hw/net/lan9118.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -

[Qemu-devel] [PULL 10/18] opencores_eth: use inline net_crc32() and bitshift instead of compute_mcast_idx()

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang --- hw/net/opencores_eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 03/18] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland Separate out the standard ethernet CRC32 calculation into a new net_crc32() function, renaming the constant POLYNOMIAL to POLYNOMIAL_BE to make it clear that this is a big-endian CRC32 calculation. As part of the constant rename, remove the duplicate definition of POLYNOMI

[Qemu-devel] [PULL 18/18] qemu-doc: Update the deprecation information of -tftp, -bootp, -redir and -smb

2017-12-21 Thread Jason Wang
From: Thomas Huth The information how to update the deprecated parameters was too scarce, so that some people did not update to the new syntax yet. Provide some more information to make sure that it is clear how to update from the old syntax to the new one. Signed-off-by: Thomas Huth Signed-off

[Qemu-devel] [PULL 07/18] sunhme: switch sunhme over to use net_crc32_le()

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland Instead of sunhme_crc32_le() using its own implementation, we can simply call net_crc32_le() directly and apply the bit shift inline. Signed-off-by: Mark Cave-Ayland Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Jason Wang --- hw/net/sunhm

[Qemu-devel] [PULL 02/18] e1000: Separate TSO and non-TSO contexts, fixing UDP TX corruption

2017-12-21 Thread Jason Wang
From: Ed Swierk via Qemu-devel The device is supposed to maintain two distinct contexts for transmit offloads: one has parameters for both segmentation and checksum offload, the other only for checksum offload. The guest driver can send two context descriptors, one for each context (the TSE flag

[Qemu-devel] [PULL 13/18] ne2000: use inline net_crc32() and bitshift instead of compute_mcast_idx()

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang --- hw/net/ne2000.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

[Qemu-devel] [PULL 16/18] net: Remove the legacy "-net channel" parameter

2017-12-21 Thread Jason Wang
From: Thomas Huth It has never been documented, so hardly anybody knows about this parameter, and it is marked as deprecated since QEMU v2.6. Time to let it go now. Reviewed-by: Samuel Thibault Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- include/net/slirp.h | 2 -- net/net.c

[Qemu-devel] [PULL 05/18] pcnet: switch pcnet over to use net_crc32_le()

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland Instead of lnc_mchash() using its own implementation, we can simply call net_crc32_le() directly and apply the bit shift inline. Signed-off-by: Mark Cave-Ayland Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Jason Wang --- hw/net/pcnet.c |

[Qemu-devel] [PULL 01/18] e1000, e1000e: Move per-packet TX offload flags out of context state

2017-12-21 Thread Jason Wang
From: Ed Swierk via Qemu-devel sum_needed and cptse flags are received from the guest within each transmit data descriptor. They are not part of the offload context; instead, they determine how to apply a previously received context to the packet being transmitted: - If cptse is set, perform bot

[Qemu-devel] [PULL 04/18] net: introduce net_crc32_le() function

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland This provides a standard ethernet CRC32 little-endian implementation. Signed-off-by: Mark Cave-Ayland Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Jason Wang --- include/net/net.h | 2 ++ net/net.c | 22 ++ 2

[Qemu-devel] [PULL 00/18] Net patches

2017-12-21 Thread Jason Wang
The following changes since commit 43ab9a5376c95c61ae898a222c4d04bdf60e239b: hw/i386/vmport: fix missing definitions with non-log trace backends (2017-12-21 22:52:28 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch c

[Qemu-devel] [PULL 09/18] eepro100: use inline net_crc32() and bitshift instead of compute_mcast_idx()

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland This makes it much easier to compare the multicast CRC calculation endian and bitshift against the Linux driver implementation. Signed-off-by: Mark Cave-Ayland Signed-off-by: Jason Wang --- hw/net/eepro100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[Qemu-devel] [PULL 06/18] eepro100: switch eepro100 e100_compute_mcast_idx() over to use net_crc32()

2017-12-21 Thread Jason Wang
From: Mark Cave-Ayland Instead of e100_compute_mcast_idx() using its own implementation, we can simply call net_crc32() directly and apply the bit shift inline. Signed-off-by: Mark Cave-Ayland Reviewed-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Jason Wang --- hw/net/

Re: [Qemu-devel] [PATCHv3 00/13] net: introduce common net_crc32() and net_crc32_le() functions

2017-12-21 Thread Jason Wang
On 2017年12月20日 16:58, Mark Cave-Ayland wrote: Series looks good to me. A small question is that, is this better to keep compute_mcast_idx()? Thanks Hi Jason, I did think about this, however at the very minimum you'd need big-endian and little-endian variants of compute_mcast_idx(), and th

Re: [Qemu-devel] [PATCH 0/3] net: Remove "-net channel" and update "-net nic" docs

2017-12-21 Thread Jason Wang
On 2017年12月19日 23:28, Thomas Huth wrote: Remove the deprecated (and even undocumented) "-net channel" parameter, and update our docs with regards to the possibility to use "netdev=..." together with the "-net nic" option for embedded NICs. Thomas Huth (3): net: Remove the legacy "-net chann

Re: [Qemu-devel] [PATCH] target/ppc: more use of the PPC_*() macros

2017-12-21 Thread David Gibson
On Thu, Dec 21, 2017 at 05:54:56PM +0100, Cédric Le Goater wrote: > Also introduce utilities to manipulate bitmasks (originaly from OPAL) > which be will be used in the model of the XIVE interrupt controller. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-2.12, thanks. Unfortunately get

Re: [Qemu-devel] [PATCH v9 04/13] dirty-bitmap: add locked state

2017-12-21 Thread John Snow
On 12/20/2017 10:49 AM, Vladimir Sementsov-Ogievskiy wrote: > Add special state, when qmp operations on the bitmap are disabled. > It is needed during bitmap migration. "Frozen" state is not > appropriate here, because it looks like bitmap is unchanged. > As of right now this breaks test 124, d

Re: [Qemu-devel] [PATCH] scsi-generic: Add share-rw option

2017-12-21 Thread Fam Zheng
On Wed, 12/20 11:06, Paolo Bonzini wrote: > On 20/12/2017 10:51, Fam Zheng wrote: > > On Tue, 12/05 23:15, Fam Zheng wrote: > >> Add the property to the device model, then parse it by calling > >> blkconf_apply_backend_options(). > >> > >> In addition to blk_set_perm(), the called function also han

[Qemu-devel] [PATCH] pc: fail memory hot-plug/unplug with -no-acpi and Q35 machine type

2017-12-21 Thread Haozhong Zhang
When -no-acpi option is used with Q35 machine type, no guest ACPI is built, but the ACPI device is still created, so only checking the presence of ACPI device before memory plug/unplug is not enough in such cases. Check whether ACPI is disabled globally in addition and fail memory plug/unplug if it

Re: [Qemu-devel] [PATCH v2] util: add is_equal to UUID API

2017-12-21 Thread Fam Zheng
On Wed, 12/20 16:54, Roman Kagan wrote: > > Thanks, queued. Will send a pull request once next release dev window opens. > > Ping? In master now. Fam

Re: [Qemu-devel] [Qemu-block] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events

2017-12-21 Thread Eric Blake
On 12/21/2017 07:08 PM, Eric Blake wrote:   # +# @errno: int describing the error cause, provided for applications. +# (Note: while most errnos are posix compliant between OSs, it +# is possible some errno values can vary among different OSs.) +# (since 2.12) The proof

Re: [Qemu-devel] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events

2017-12-21 Thread Eric Blake
On 12/21/2017 06:11 PM, Jack Schwartz wrote: BLOCK_IO_ERROR events currently contain a "reason" string which is strerror(errno) of the error. This enhancement provides those events with the numeric errno value as well, since it is easier to parse for error type than a string. NACK. Numeric er

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

2017-12-21 Thread Philippe Mathieu-Daudé
>> > Done and pushed - I dropped the conflicting patch. >> >> Have you also dropped the other one Philippe says depends on it? Now than I could take time to check, dropping this single patch was correct and inoffensive, since conflicting patch from Mao Zhongyi is doing exactly the same change (e01

[Qemu-devel] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events

2017-12-21 Thread Jack Schwartz
BLOCK_IO_ERROR events currently contain a "reason" string which is strerror(errno) of the error. This enhancement provides those events with the numeric errno value as well, since it is easier to parse for error type than a string. Signed-off-by: Jack Schwartz Reviewed-by: Konrad Rzeszutek Wilk

[Qemu-devel] [PATCH v1 0/1] block: Add numeric errno field to BLOCK_IO_ERROR events

2017-12-21 Thread Jack Schwartz
Currently, BLOCK_IO_ERROR events have a string error "reason" field which is derived from errno. The proposed change adds errno itself as a field to these events. Figuring out the error by comparing the (int) errno itself is easier than comparing a string. There is also a comment in the code tha

[Qemu-devel] [Bug 1728635] Re: qemu-io crashes with SIGSEGV when did -c aio_write 9233408 28160 on a image_fuzzer image

2017-12-21 Thread John Snow
I can't reproduce this on commit a93ece47fd9edbd4558db24300056c9a57d3bcd4: # ./qemu-io copy.img -c "aio_write 9233408 28160" can't open device copy.img: Could not open backing file: Could not open 'backing_img.file': No such file or directory and on the latest commit, I get a different error tha

Re: [Qemu-devel] [PATCH v7 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-12-21 Thread Liu, Changpeng
> -Original Message- > From: Marc-André Lureau [mailto:marcandre.lur...@gmail.com] > Sent: Thursday, December 21, 2017 6:48 PM > To: Michael S. Tsirkin > Cc: Liu, Changpeng ; QEMU de...@nongnu.org>; Harris, James R ; Stefan Hajnoczi > ; Paolo Bonzini ; Felipe Franciosi > > Subject: Re:

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

2017-12-21 Thread Michael S. Tsirkin
On Thu, Dec 21, 2017 at 08:05:51PM -0300, Philippe Mathieu-Daudé wrote: > Hi Peter, Michael, > > On Thu, Dec 21, 2017 at 5:37 PM, Michael S. Tsirkin wrote: > > On Thu, Dec 21, 2017 at 08:26:47PM +, Peter Maydell wrote: > >> On 21 December 2017 at 14:27, Michael S. Tsirkin wrote: > >> > The f

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

2017-12-21 Thread Michael S. Tsirkin
On Thu, Dec 21, 2017 at 11:05:01PM +, Peter Maydell wrote: > On 21 December 2017 at 20:37, Michael S. Tsirkin wrote: > > Done and pushed - I dropped the conflicting patch. > > Have you also dropped the other one Philippe says depends on it? > > thanks > -- PMM I did now

Re: [Qemu-devel] [PATCH] file-posix: refuse to open directories

2017-12-21 Thread Eric Blake
On 12/21/2017 04:44 PM, John Snow wrote: I don't think there's a legitimate reason to open directories as if they were files. This prevents QEMU from opening and attempting to probe a directory inode, which can break in exciting ways. One of those ways is lseek on ext4/xfs, which will return 0x7f

Re: [Qemu-devel] [PATCH 11/19] block: Don't notify parents in drain call chain

2017-12-21 Thread Eric Blake
On 12/20/2017 04:34 AM, Kevin Wolf wrote: This is in preparation for subtree drains, i.e. drained sections that affect not only a single node, but recursively all child nodes, too. Calling the parent callbacks for drain is pointless when we just came from that parent node recursively and leads t

Re: [Qemu-devel] [PATCH 08/19] block: Don't block_job_pause_all() in bdrv_drain_all()

2017-12-21 Thread Eric Blake
On 12/20/2017 04:34 AM, Kevin Wolf wrote: Block jobs are already paused using the BdrvChildRole drain callbacks, so we don't need an additionall block_job_pause_all() call. s/additionall/additional/ Signed-off-by: Kevin Wolf --- block/io.c | 4 tests/test-bdrv-drain.c

[Qemu-devel] [Bug 1739378] Re: qemu git master snapshot doesn't work

2017-12-21 Thread Gustavo Moreira
So, it should be only related to SD? Which virtual device/storage backend do you recommend for snapshots? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1739378 Title: qemu git master snapshot doesn

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-21 Thread Eric Blake
On 12/19/2017 08:20 AM, Max Reitz wrote: So there are three things: (1) We probably should not allow snapshot names that could be IDs. Easiest way to solve this: Names have to start with a non-digit. Yes, that would be a nice change. It is not strictly backwards compatible (so we'd still ha

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

2017-12-21 Thread Philippe Mathieu-Daudé
Hi Peter, Michael, On Thu, Dec 21, 2017 at 5:37 PM, Michael S. Tsirkin wrote: > On Thu, Dec 21, 2017 at 08:26:47PM +, Peter Maydell wrote: >> On 21 December 2017 at 14:27, Michael S. Tsirkin wrote: >> > The following changes since commit >> > 2babfe0c9241c239272a03fec785165a50e8288c: >> > >

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

2017-12-21 Thread Peter Maydell
On 21 December 2017 at 20:37, Michael S. Tsirkin wrote: > Done and pushed - I dropped the conflicting patch. Have you also dropped the other one Philippe says depends on it? thanks -- PMM

Re: [Qemu-devel] [PATCH] hw/i386/vmport: fix missing definitions with x86_64-w64-mingw32

2017-12-21 Thread Peter Maydell
On 21 December 2017 at 22:55, Philippe Mathieu-Daudé wrote: >>> Fixes: 7299e1a411 >>>("hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP") >>> Signed-off-by: Laurent Vivier >> >> Looks to me like it'll be a bug for anything not configured >> using the 'log' trace backend, rat

Re: [Qemu-devel] [PULL 15/25] hw/block/nvme: QOM'ify PCI NVME

2017-12-21 Thread Philippe Mathieu-Daudé
Hi Michael, On Thu, Dec 21, 2017 at 5:38 PM, Michael S. Tsirkin wrote: > On Thu, Dec 21, 2017 at 04:29:21PM +0200, Michael S. Tsirkin wrote: >> From: Philippe Mathieu-Daudé >> >> Signed-off-by: Philippe Mathieu-Daudé >> Reviewed-by: Michael S. Tsirkin >> Signed-off-by: Michael S. Tsirkin > >

Re: [Qemu-devel] [PATCH] file-posix: refuse to open directories

2017-12-21 Thread John Snow
On 12/21/2017 05:56 PM, no-re...@patchew.org wrote: > /tmp/qemu-test/src/hw/i386/vmport.c: In function 'vmport_ioport_read': > /tmp/qemu-test/src/hw/i386/vmport.c:81:9: error: implicit declaration of > function 'qemu_log_mask' [-Werror=implicit-function-declaration] > qemu_log_mask(LOG_

Re: [Qemu-devel] qemu 2.9.0 qcow2 file failed to open after hard server reset

2017-12-21 Thread John Snow
On 12/21/2017 05:13 PM, Vasiliy Tolstov wrote: > Hi! Today my server have forced reboot and one of my vm can't start > with message: > qcow2: Marking image as corrupt: L2 table offset 0x3f786d6c207600 > unaligned (L1 index: 0); further corruption events will be suppressed > > i'm use debian jess

Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes

2017-12-21 Thread Corey Minyard
On 12/07/2017 03:30 PM, miny...@acm.org wrote: These are some fixes I've had for a while (mostly). They are small fixes and additions for various things. It would be nice to be able to get at least some of these into the upcoming release, but it's probably too late. I also add myself as the ma

Re: [Qemu-devel] [PATCH] hw/i386/vmport: fix missing definitions with x86_64-w64-mingw32

2017-12-21 Thread Philippe Mathieu-Daudé
>> Fixes: 7299e1a411 >>("hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP") >> Signed-off-by: Laurent Vivier > > Looks to me like it'll be a bug for anything not configured > using the 'log' trace backend, rather than win32 specific. Sorry my bad, it seems I don't test enoug

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2017-12-21 Thread Benjamin Herrenschmidt
On Thu, 2017-12-21 at 10:16 +0100, Cédric Le Goater wrote: > On 12/21/2017 01:12 AM, Benjamin Herrenschmidt wrote: > > On Wed, 2017-12-20 at 16:09 +1100, David Gibson wrote: > > > > > > As you've suggested in yourself, I think we might need to more > > > explicitly model the different components o

Re: [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up

2017-12-21 Thread Michael S. Tsirkin
On Thu, Dec 21, 2017 at 10:21:20PM +0100, Maxime Coquelin wrote: > Sorry, I missed to fixup the feature mask in patch 4, > this is the only change in this v3. > > The two changes in v2 are fixing the features mask > before the function rework, and reword of commit message > of patch "vhost-user-te

Re: [Qemu-devel] [PATCH] hw/i386/vmport: fix missing definitions with x86_64-w64-mingw32

2017-12-21 Thread Peter Maydell
On 21 December 2017 at 21:11, Laurent Vivier wrote: > When compiled with x86_64-w64-mingw32, we have: > >error: implicit declaration of function 'qemu_log_mask' >error: 'LOG_UNIMP' undeclared (first use in this function) > > This patch adds the missing include. > > Fixes: 7299e1a411 >

Re: [Qemu-devel] [PULL v2 00/13] Block layer patches

2017-12-21 Thread Peter Maydell
On 21 December 2017 at 15:26, Kevin Wolf wrote: > The following changes since commit 4da5c51cac8363f86ec92dc99c38f9382d617647: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-12-20' > into staging (2017-12-20 20:38:36 +) > > are available in the git repository at: > >

[Qemu-devel] [PATCH] file-posix: refuse to open directories

2017-12-21 Thread John Snow
I don't think there's a legitimate reason to open directories as if they were files. This prevents QEMU from opening and attempting to probe a directory inode, which can break in exciting ways. One of those ways is lseek on ext4/xfs, which will return 0x7fff as the file size instead of

Re: [Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

2017-12-21 Thread Yuval Shaia
On Thu, Dec 21, 2017 at 10:46:35PM +0200, Michael S. Tsirkin wrote: > On Thu, Dec 21, 2017 at 05:59:38PM +0200, Marcel Apfelbaum wrote: > > On 21/12/2017 16:22, Michael S. Tsirkin wrote: > > > On Thu, Dec 21, 2017 at 09:27:51AM +0200, Yuval Shaia wrote: > > > > > > > > > > > > > What happens if gu

[Qemu-devel] qemu 2.9.0 qcow2 file failed to open after hard server reset

2017-12-21 Thread Vasiliy Tolstov
Hi! Today my server have forced reboot and one of my vm can't start with message: qcow2: Marking image as corrupt: L2 table offset 0x3f786d6c207600 unaligned (L1 index: 0); further corruption events will be suppressed i'm use debian jessie with hand builded qemu 2.9.0, i'm try to qemu-img check bu

[Qemu-devel] [PATCH v3 4/5] vhost-user-test: make features mask an init_virtio_dev() argument

2017-12-21 Thread Maxime Coquelin
The goal is to generalize the use of [un]init_virtio_dev() to all tests, which does not necessarily expose the same features set. Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vhost-user-test.c

[Qemu-devel] [PATCH v3 3/5] vhost-user-test: setup virtqueues in all tests

2017-12-21 Thread Maxime Coquelin
Only the multiqueue test setups the virtqueues. This patch generalizes the setup of virtqueues for all tests. Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 53 +++-- 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/tests/v

[Qemu-devel] [PATCH v3 5/5] vhost-user-test: use init_virtio_dev in multiqueue test

2017-12-21 Thread Maxime Coquelin
Now that init_virtio_dev() has been generalized to all cases, use it in test_multiqueue() to avoid code duplication. Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 65 ++--- 1 file changed, 8 insertions(+), 57 deletions(-) diff --git a/t

[Qemu-devel] [PATCH v3 2/5] vhost-user-test: extract read-guest-mem test from main loop

2017-12-21 Thread Maxime Coquelin
This patch makes read-guest-test consistent with other tests, i.e. create the test server in the test function. Reviewed-by: Marc-André Lureau Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletion

[Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up

2017-12-21 Thread Maxime Coquelin
Sorry, I missed to fixup the feature mask in patch 4, this is the only change in this v3. The two changes in v2 are fixing the features mask before the function rework, and reword of commit message of patch "vhost-user-test: extract read-guest-mem test from main loop" (Thanks Marc-André). This se

[Qemu-devel] [PATCH v3 1/5] vhost-user-test: fix features mask

2017-12-21 Thread Maxime Coquelin
VIRTIO_NET_F_MAC is a bit position, not a bit mask. Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index e2c89ed376..43c6528644 100644 --- a/tests/vhost-user-test.c +

[Qemu-devel] [PATCH] hw/i386/vmport: fix missing definitions with x86_64-w64-mingw32

2017-12-21 Thread Laurent Vivier
When compiled with x86_64-w64-mingw32, we have: error: implicit declaration of function 'qemu_log_mask' error: 'LOG_UNIMP' undeclared (first use in this function) This patch adds the missing include. Fixes: 7299e1a411 ("hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP"

[Qemu-devel] [PATCH v2 5/5] vhost-user-test: use init_virtio_dev in multiqueue test

2017-12-21 Thread Maxime Coquelin
Now that init_virtio_dev() has been generalized to all cases, use it in test_multiqueue() to avoid code duplication. Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 65 ++--- 1 file changed, 8 insertions(+), 57 deletions(-) diff --git a/t

[Qemu-devel] [PATCH v2 3/5] vhost-user-test: setup virtqueues in all tests

2017-12-21 Thread Maxime Coquelin
Only the multiqueue test setups the virtqueues. This patch generalizes the setup of virtqueues for all tests. Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 53 +++-- 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/tests/v

[Qemu-devel] [PATCH v2 4/5] vhost-user-test: make features mask an init_virtio_dev() argument

2017-12-21 Thread Maxime Coquelin
The goal is to generalize the use of [un]init_virtio_dev() to all tests, which does not necessarily expose the same features set. Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vhost-user-test.c

[Qemu-devel] [PATCH v2 0/5] vhost-user-test: Fixes & code clean-up

2017-12-21 Thread Maxime Coquelin
The two changes in this v2 are fixing the features mask before the function rework, and reword of commit message of patch "vhost-user-test: extract read-guest-mem test from main loop" (Thanks Marc-Andr??). This series fixes two issues in vhost-user-test: 1. Setup virtqueues in all tests 2. Fix fe

[Qemu-devel] [PATCH v2 1/5] vhost-user-test: fix features mask

2017-12-21 Thread Maxime Coquelin
VIRTIO_NET_F_MAC is a bit position, not a bit mask. Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index e2c89ed376..43c6528644 100644 --- a/tests/vhost-user-test.c +

[Qemu-devel] [PATCH v2 2/5] vhost-user-test: extract read-guest-mem test from main loop

2017-12-21 Thread Maxime Coquelin
This patch makes read-guest-test consistent with other tests, i.e. create the test server in the test function. Signed-off-by: Maxime Coquelin --- tests/vhost-user-test.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/tests/vhost-u

Re: [Qemu-devel] [PATCH v20 3/7 RESEND] xbitmap: add more operations

2017-12-21 Thread Matthew Wilcox
OK, here's a rewrite of xbitmap. Compared to the version you sent: - xb_find_set() is the rewrite I sent out yesterday. - xb_find_clear() is a new implementation. I use the IDR_FREE tag to find clear bits. This led to me finding a bug in radix_tree_for_each_tagged(). - xb_zero() is also a

Re: [Qemu-devel] [PULL 0/5] M68k for 2.12 patches

2017-12-21 Thread Laurent Vivier
Le 21/12/2017 à 21:27, Laurent Vivier a écrit : > Le 21/12/2017 à 20:57, no-re...@patchew.org a écrit : >> Hi, >> >> This series failed automatic build test. Please find the testing commands and >> their output below. If you have docker installed, you can probably reproduce >> it >> locally. >> >>

Re: [Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

2017-12-21 Thread Michael S. Tsirkin
On Thu, Dec 21, 2017 at 05:59:38PM +0200, Marcel Apfelbaum wrote: > On 21/12/2017 16:22, Michael S. Tsirkin wrote: > > On Thu, Dec 21, 2017 at 09:27:51AM +0200, Yuval Shaia wrote: > > > > > > > > > > > What happens if guest attempts to register all its memory? > > > > > > > > > > > > > > > > The

Re: [Qemu-devel] [PATCH 2/2] qemu: add linkspeed and duplex setting to virtio-net

2017-12-21 Thread Michael S. Tsirkin
On Thu, Dec 21, 2017 at 02:42:48PM -0500, Jason Baron wrote: > > > On 12/20/2017 09:33 AM, Yan Vugenfirer wrote: > > > >> On 20 Dec 2017, at 16:31, Michael S. Tsirkin wrote: > >> > >> On Tue, Dec 19, 2017 at 11:52:39AM -0500, Jason Baron wrote: > >>> > >>> > >>> On 12/19/2017 04:19 AM, Yan Vuge

Re: [Qemu-devel] [PULL 15/25] hw/block/nvme: QOM'ify PCI NVME

2017-12-21 Thread Michael S. Tsirkin
On Thu, Dec 21, 2017 at 04:29:21PM +0200, Michael S. Tsirkin wrote: > From: Philippe Mathieu-Daudé > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin Dropped due to merge conflicts. Pls rebase and ask storage maintainers to apply as

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

2017-12-21 Thread Michael S. Tsirkin
On Thu, Dec 21, 2017 at 08:26:47PM +, Peter Maydell wrote: > On 21 December 2017 at 14:27, Michael S. Tsirkin wrote: > > The following changes since commit 2babfe0c9241c239272a03fec785165a50e8288c: > > > > Update version for v2.11.0-rc4 release (2017-12-05 16:36:46 +) > > > > are availab

Re: [Qemu-devel] [PATCH v2 0/5] Add aarch64_be-linux-user target

2017-12-21 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171219201613.7399-1-michael.wei...@gmx.de Subject: [Qemu-devel] [PATCH v2 0/5] Add aarch64_be-linux-user target === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$

Re: [Qemu-devel] [PULL 0/5] M68k for 2.12 patches

2017-12-21 Thread Laurent Vivier
Le 21/12/2017 à 20:57, no-re...@patchew.org a écrit : > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Type: series > Message-id: 20171221193640.27418-1-laur.

[Qemu-devel] [PULL v3 00/19] Initial support for Hypervisor.framework

2017-12-21 Thread Paolo Bonzini
The following changes since commit 200780a3a3ed067dfb2e0d2210b0ed09e748ba26: Merge remote-tracking branch 'remotes/armbru/tags/pull-cmdline-2017-12-18-v2' into staging (2017-12-20 13:20:48 +) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream-hvf

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups

2017-12-21 Thread Peter Maydell
On 21 December 2017 at 14:27, Michael S. Tsirkin wrote: > The following changes since commit 2babfe0c9241c239272a03fec785165a50e8288c: > > Update version for v2.11.0-rc4 release (2017-12-05 16:36:46 +) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/ms

Re: [Qemu-devel] [PULL v2 00/19] Initial support for Hypervisor.framework

2017-12-21 Thread Peter Maydell
On 21 December 2017 at 08:55, Paolo Bonzini wrote: > The following changes since commit 200780a3a3ed067dfb2e0d2210b0ed09e748ba26: > > Merge remote-tracking branch > 'remotes/armbru/tags/pull-cmdline-2017-12-18-v2' into staging (2017-12-20 > 13:20:48 +) > > are available in the Git reposito

Re: [Qemu-devel] About my strnlen patch

2017-12-21 Thread Eric Blake
On 12/21/2017 01:07 PM, Programmingkid wrote: On Dec 21, 2017, at 1:40 PM, Eric Blake wrote: On 12/21/2017 12:36 PM, Programmingkid wrote: On Dec 21, 2017, at 1:30 PM, Eric Blake wrote: On 12/21/2017 08:31 AM, Programmingkid wrote: Now would be a good time to push the strnlen patch. No

Re: [Qemu-devel] [PATCH 2/2] qemu: add linkspeed and duplex setting to virtio-net

2017-12-21 Thread Jason Baron via Qemu-devel
On 12/20/2017 09:33 AM, Yan Vugenfirer wrote: > >> On 20 Dec 2017, at 16:31, Michael S. Tsirkin wrote: >> >> On Tue, Dec 19, 2017 at 11:52:39AM -0500, Jason Baron wrote: >>> >>> >>> On 12/19/2017 04:19 AM, Yan Vugenfirer wrote: > On 18 Dec 2017, at 18:04, Jason Baron via Qemu-devel >>>

[Qemu-devel] [PULL 4/5] target/m68k: fix set_cc_op()

2017-12-21 Thread Laurent Vivier
The first call of set_cc_op() in a new translation sequence is done with old_op set to CC_OP_DYNAMIC (-1). This will do an out of bound access to the array cc_op_live[]. We fix that by adding an entry in cc_op_live[] for CC_OP_DYNAMIC. Reported-by: Thomas Huth Signed-off-by: Laurent Vivier Rev

[Qemu-devel] [PULL 3/5] target/m68k: add monitor.c

2017-12-21 Thread Laurent Vivier
This allows to use registers content in the monitor. Example: BEFORE: (qemu) print $d0 unknown register AFTER: (qemu) print $d0 0 (qemu) print $sr 0x2000 (qemu) x/10i $pc 0x40010a2a: movew %sr,%d0 0x40010a2c: oril #1792,%d0 0x40010a32: movew %d0,%sr 0x40010a34: movel

[Qemu-devel] [PULL 1/5] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

2017-12-21 Thread Laurent Vivier
It makes the code clearer to separate the bus implementation from the devices one. Replace ADB_DPRINTF() with trace events (and adding new ones in adb-kbd.c). Some minor changes to make checkpatch.pl happy. Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave

[Qemu-devel] [PULL 0/5] M68k for 2.12 patches

2017-12-21 Thread Laurent Vivier
The following changes since commit 23bafd75cd979ad3a21af10273c5a0c5d67d068b: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-12-21 16:34:23 +) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k-for-2.12-pull-reques

[Qemu-devel] [PULL 5/5] tests/boot-serial-test: Add support for the mcf5208evb board

2017-12-21 Thread Laurent Vivier
From: Thomas Huth We can output a character quite easily here with some few lines of assembly that we provide as a mini-kernel for this board. Signed-off-by: Thomas Huth Message-Id: <1512031988-32490-4-git-send-email-th...@redhat.com> [lv: add boot-serial-test in check-qtest-m68k] Signed-off-by

[Qemu-devel] [PULL 2/5] target/m68k: remove unused variable gen_throws_exception

2017-12-21 Thread Laurent Vivier
It has been introduced by e6e5906b6e ("ColdFire target."), but the content is never used. Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20171220130815.20708-1-laur...@vivier.eu> --- target/m68k/translate.c | 10 -- 1 file change

  1   2   3   4   >