[Qemu-devel] [Bug 1717708] Re: QEMU aarch64 can't run Windows ARM64 iso's

I just noticed this bug via qemu-devel. For the record, recent QEMU (2.11-rc1 and later) can run recent arm64 Windows images using -M virt and the virtio storage/input/networking drivers in the guest. I was using older UEFI build that still includes the VGA framebuffer support. (I only just learned

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v17 6/6] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

On Friday, November 17, 2017 8:45 PM, Michael S. Tsirkin wrote: > On Fri, Nov 17, 2017 at 07:35:03PM +0800, Wei Wang wrote: > > On 11/16/2017 09:27 PM, Wei Wang wrote: > > > On 11/16/2017 04:32 AM, Michael S. Tsirkin wrote: > > > > On Fri, Nov 03, 2017 at 04:13:06PM +0800, Wei Wang wrote: > > > > >

Re: [Qemu-devel] [PATCH v8 04/14] block/dirty-bitmap: add bdrv_dirty_bitmap_set_frozen

On 11/17/2017 12:30 PM, Vladimir Sementsov-Ogievskiy wrote: > 17.11.2017 20:20, John Snow wrote: >> >> On 11/17/2017 09:46 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 14.11.2017 02:32, John Snow wrote: On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: > Make it possible to set

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.11] iotests: Fix 176 on 32-bit host

On 11/17/2017 02:10 PM, Eric Blake wrote: > On 11/17/2017 01:04 PM, Eric Blake wrote: >> The contents of a qcow2 bitmap are rounded up to a size that >> matches the number of bits available for the granularity, but >> that granularity differs for 32-bit hosts (our default 64k >> cluster allows fo

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

On 11/17/2017 03:22 AM, Vladimir Sementsov-Ogievskiy wrote: > 17.11.2017 06:10, John Snow wrote: >> >> On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 16.11.2017 00:20, John Snow wrote: On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > Ther

Re: [Qemu-devel] [PATCH 3/4] multiboot: load elf sections and section headers

Hello On Tue, Oct 31, 2017 at 11:38 AM, Anatol Pomozov wrote: > Hi > > On Thu, Oct 19, 2017 at 2:36 AM, Kevin Wolf wrote: >> Am 18.10.2017 um 19:22 hat Anatol Pomozov geschrieben: >>> Hello qemu-devs, >>> >>> This patchset has been posted a while ago. I would like to move >>> forward with it and

Re: [Qemu-devel] [PATCH 02/24] sdl: remove -alt-grab and -ctrl-grab support

On Fri, Nov 17, 2017 at 11:06:12AM -0500, Programmingkid wrote: > > > With absolute pointer devices such as usb-tablet being widely used > > mouse grabs (for relative pointing devices) should be rarely needed > > these days. So the benefit of the options to configure the hotkey > > modifiers for

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.11] spapr: reset DRCs after devices

On 11/17/2017 04:19 PM, Michael Roth wrote: Quoting Daniel Henrique Barboza (2017-11-17 10:21:27) On 11/17/2017 10:56 AM, Greg Kurz wrote: A DRC with a pending unplug request releases its associated device at machine reset time. In the case of LMB, when all DRCs for a DIMM device have been

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

On 11/17/2017 01:25 PM, Kevin Wolf wrote: > Am 17.11.2017 um 19:15 hat John Snow geschrieben: >> >> >> On 11/17/2017 10:01 AM, Max Reitz wrote: >>> On 2017-11-17 13:30, Kevin Wolf wrote: Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > Snapshot-switch actually chang

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

On 17 November 2017 at 20:26, Paolo Bonzini wrote: > On 17/11/2017 21:07, Peter Maydell wrote: >> Hi. This commit breaks booting of Debian on aarch64 virt board. >> (repro instructions for creating the image available at: >> https://translatedcode.wordpress.com/2017/07/24/installing-debian-on-qemu

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

On 17/11/2017 21:07, Peter Maydell wrote: > On 16 November 2017 at 11:59, Paolo Bonzini wrote: >> From: Pavel Dovgalyuk >> >> This patch adds a condition before overwriting exception_index fiels. >> It is needed when exception_index is already set to some meaningful value. >> >> Signed-off-by: Pa

[Qemu-devel] [Bug 1732981] [NEW] usb-net on aarch64 has wrong class IDs, isn't recognized by Windows

Public bug reported: If I run qemu-system-aarch64 with "-device usb-net,...", the resulting USB device will be seen in the guest as class 0x2, subclass 0x2, protocol 0xFF, instead of the expected class 0xe0, subclass 0x1, protocol 0x3. This prevents Windows' in-box class driver from binding to the

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

On 16 November 2017 at 11:59, Paolo Bonzini wrote: > From: Pavel Dovgalyuk > > This patch adds a condition before overwriting exception_index fiels. > It is needed when exception_index is already set to some meaningful value. > > Signed-off-by: Pavel Dovgalyuk > > Message-Id: <20171114081812.276

Re: [Qemu-devel] [PATCH 03/15] sun4u: move ISABus inside of EBusState

On Fri, Nov 17, 2017 at 4:46 PM, Mark Cave-Ayland wrote: > On 17/11/17 14:53, Artyom Tarasenko wrote: > >> On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland >> wrote: >>> Since the EBus is effectively a PCI-ISA bridge then the underlying ISA bus >>> should be contained within the PCI bridge itsel

Re: [Qemu-devel] [PATCH 01/15] apb: move QOM macros and typedefs from apb.c to apb.h

On Fri, Nov 17, 2017 at 4:40 PM, Mark Cave-Ayland wrote: > On 17/11/17 14:24, Artyom Tarasenko wrote: > >> Hi Mark, >> >> On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland >> wrote: >>> This also includes the related IOMMUState typedef and defines. >>> >>> Signed-off-by: Mark Cave-Ayland >>> ---

Re: [Qemu-devel] [PATCH v4 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

On Fri, Nov 17, 2017 at 07:54:44PM +0100, Kashyap Chamarthy wrote: > When you cancel an in-progress 'mirror' job (or "active `block-commit`) When applying, can the maintainer please fix-up the missing closing double-quote in the brackets above? It should be: "active `block-commit`" [...] -- /k

[Qemu-devel] [Bug 1717708] Re: QEMU aarch64 can't run Windows ARM64 iso's

(1) See also . (2) One idea is (a) letting Windows use VirtioGpuDxe's GOP (blt only) until it calls ExitBootServices() -- which I have already confirmed to work with an ARM64 Windows Server variant that I was legally given access to --, and (b) once av

[Qemu-devel] [Bug 1717708] Re: QEMU aarch64 can't run Windows ARM64 iso's

Sigh, in bullet (1) of comment #10, I obviously didn't mean to link this same LP entry. Instead I meant . Sorry. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpa

Re: [Qemu-devel] [PATCH 15/15] sun4u: switch from EBUS_DPRINTF() macro to trace-events

On 11/17/2017 10:42 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > hw/sparc64/sun4u.c | 12 ++-- > hw/sparc64/trace-events |3 +++ > 2 files changed, 5 insertions(+), 10 deletions(-) > > diff --git a/hw/sparc64/sun4

Re: [Qemu-devel] [PATCH for-2.11] iotests: Fix 176 on 32-bit host

On 11/17/2017 01:04 PM, Eric Blake wrote: > The contents of a qcow2 bitmap are rounded up to a size that > matches the number of bits available for the granularity, but > that granularity differs for 32-bit hosts (our default 64k > cluster allows for 2M bitmap coverage per 'long') and 64-bit > host

Re: [Qemu-devel] [PATCH 07/15] apb: return APBState from pci_apb_init() rather then PCIBus

"rather then PCIBus" -> "rather than PCIBus" On 11/17/2017 10:42 AM, Mark Cave-Ayland wrote: > This is a first step towards removing pci_apb_init() completely. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > hw/pci-host/apb.c |8 > hw/spar

Re: [Qemu-devel] [PULL 0/4] NBD patches for 2.11-rc2

On 17 November 2017 at 15:05, Eric Blake wrote: > The following changes since commit fec035a53fa15c4c8c4e62bfef56a35df4161e38: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20171117-pull-request' > into staging (2017-11-17 10:18:41 +) > > are availa

[Qemu-devel] [PATCH for-2.11] iotests: Fix 176 on 32-bit host

The contents of a qcow2 bitmap are rounded up to a size that matches the number of bits available for the granularity, but that granularity differs for 32-bit hosts (our default 64k cluster allows for 2M bitmap coverage per 'long') and 64-bit hosts (4M bitmap per 'long'). If the image is a multipl

Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot

On 11/17/2017 12:46 PM, Eric Blake wrote: >> >> The test fails with -m32 and probably also on Big Endian architectures, >> because the bitmap hash differs. > > Oh my. Thanks for the rapid testing. > >> We could "fix" this by replacing the 2100 by a 2102, so for both bit >> widths rounding is th

[Qemu-devel] [PATCH v4 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

When you cancel an in-progress 'mirror' job (or "active `block-commit`) with QMP `block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED. However, when `block-job-cancel` is issued *after* `drive-mirror` has indicated (via the event BLOCK_JOB_READY) that the source and destination have reached

Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot

On 11/17/2017 12:17 PM, Max Reitz wrote: > On 2017-11-17 17:47, Eric Blake wrote: >> If an image contains persistent snapshots, we cannot use the >> fast path of bdrv_make_empty() to clear the image during >> qemu-img commit, because that will lose the clusters related >> to the bitmaps. >> >> Also

Re: [Qemu-devel] [PATCH for-2.11] pc-bios/s390-ccw: Fix problem with invalid virtio-scsi LUN when rebooting

On 11/17/2017 07:10 PM, Thomas Huth wrote: > When rebooting a guest that has a virtio-scsi disk, the s390-ccw > bios sometimes bails out with an error message like this: > > ! SCSI cannot report LUNs: STATUS=02 RSPN=70 KEY=05 CODE=25 QLFR=00, sure ! > > Enabling the scsi_req* tracing in QEMU sh

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

Am 17.11.2017 um 19:15 hat John Snow geschrieben: > > > On 11/17/2017 10:01 AM, Max Reitz wrote: > > On 2017-11-17 13:30, Kevin Wolf wrote: > >> Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>> Snapshot-switch actually changes active state of disk so it should > >>> refl

Re: [Qemu-devel] [PATCH for-2.11] spapr: reset DRCs after devices

Quoting Greg Kurz (2017-11-17 06:56:48) > A DRC with a pending unplug request releases its associated device at > machine reset time. > > In the case of LMB, when all DRCs for a DIMM device have been reset, > the DIMM gets unplugged, causing guest memory to disappear. This may > be very confusing

[Qemu-devel] [Bug 1732959] [NEW] [regression] Clock jump on source VM after migration

Public bug reported: We (ab)use migration + block mirroring to perform transparent zero downtime VM backups. Basically: 1) do a block mirror of the source VM's disk 2) migrate the source VM to a destination VM using the disk copy 3) cancel the block mirroring 4) resume the source VM 5) shut down

[Qemu-devel] [PULL 24/25] block: Make bdrv_next() keep strong references

From: Max Reitz On one hand, it is a good idea for bdrv_next() to return a strong reference because ideally nearly every pointer should be refcounted. This fixes intermittent failure of iotest 194. On the other, it is absolutely necessary for bdrv_next() itself to keep a strong reference to both

Re: [Qemu-devel] [PATCH v8 02/14] block/dirty-bitmap: add locked version of bdrv_release_dirty_bitmap

On 11/17/2017 03:07 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.11.2017 01:52, John Snow wrote: >> >> On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: >>> It is needed to realize bdrv_dirty_bitmap_release_successor in >>> the following patch. >>> >> OK, but... >> >>> Signed-off-by: Vl

[Qemu-devel] [PULL 18/25] qcow2: check_errors are fatal

From: Max Reitz When trying to repair a dirty image, qcow2_check() may apparently succeed (no really fatal error occurred that would prevent the check from continuing), but if check_errors in the result object is non-zero, we cannot trust the image to be usable. Reported-by: R. Nageswara Sastry

[Qemu-devel] [PULL 23/25] qcow2: Fix overly broad madvise()

From: Max Reitz @mem_size and @offset are both size_t, thus subtracting them from one another will just return a big size_t if mem_size < offset -- even more obvious here because the result is stored in another size_t. Checking that result to be positive is therefore not sufficient to exclude th

[Qemu-devel] [PULL 25/25] iotests: Make 087 pass without AIO enabled

From: Max Reitz If AIO has not been enabled in the qemu build that is to be tested, we should skip the "aio=native without O_DIRECT" test instead of failing. Signed-off-by: Max Reitz Message-id: 20171115180732.31753-1-mre...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tes

[Qemu-devel] [PULL 22/25] qcow2: Refuse to get unaligned offsets from cache

From: Max Reitz Instead of using an assertion, it is better to emit a corruption event here. Checking all offsets for correct alignment can be tedious and it is easily possible to forget to do so. qcow2_cache_do_get() is a function every L2 and refblock access has to go through, so this is a go

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.11] spapr: reset DRCs after devices

Quoting Daniel Henrique Barboza (2017-11-17 10:21:27) > > > On 11/17/2017 10:56 AM, Greg Kurz wrote: > > A DRC with a pending unplug request releases its associated device at > > machine reset time. > > > > In the case of LMB, when all DRCs for a DIMM device have been reset, > > the DIMM gets unp

Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot

On 2017-11-17 17:47, Eric Blake wrote: > If an image contains persistent snapshots, we cannot use the > fast path of bdrv_make_empty() to clear the image during > qemu-img commit, because that will lose the clusters related > to the bitmaps. > > Also leave a comment in qcow2_read_extensions to rem

[Qemu-devel] [PULL 15/25] tests: Add check-qobject for equality tests

From: Max Reitz Add a new test file (check-qobject.c) for unit tests that concern QObjects as a whole. Its only purpose for now is to test the qobject_is_equal() function. Signed-off-by: Max Reitz Message-id: 20171114180128.17076-7-mre...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max

[Qemu-devel] [PULL 19/25] qcow2: Unaligned zero cluster in handle_alloc()

From: Max Reitz We should check whether the cluster offset we are about to use is actually valid; that is, whether it is aligned to cluster boundaries. Reported-by: R. Nageswara Sastry Buglink: https://bugs.launchpad.net/qemu/+bug/1728643 Buglink: https://bugs.launchpad.net/qemu/+bug/1728657 Si

[Qemu-devel] [PULL 20/25] block: Guard against NULL bs->drv

From: Max Reitz We currently do not guard everywhere against a NULL bs->drv where we should be doing so. Most of the places fixed here just do not care about that case at all. Some care implicitly, e.g. through a prior function call to bdrv_getlength() which would always fail for an ejected BDS

[Qemu-devel] [PULL 12/25] qapi: Add qobject_is_equal()

From: Max Reitz This generic function (along with its implementations for different types) determines whether two QObjects are equal. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Reviewed-by: Markus Armbruster Message-id: 20171114180128.17076-4-mre...@redhat.c

[Qemu-devel] [PULL 21/25] qcow2: Add bounds check to get_refblock_offset()

From: Max Reitz Reported-by: R. Nageswara Sastry Buglink: https://bugs.launchpad.net/qemu/+bug/1728661 Signed-off-by: Max Reitz Message-id: 20171110203111.7666-5-mre...@redhat.com Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Signed-off-by: Max Reitz --- block/qcow2.h |

[Qemu-devel] [PULL 16/25] iotests: Add test for failing qemu-img commit

From: Max Reitz Signed-off-by: Max Reitz Message-id: 20170616135847.17726-1-mre...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tests/qemu-iotests/020 | 27 +++ tests/qemu-iotests/020.out | 17 + 2 files changed, 44 insertions(+)

[Qemu-devel] [PULL 08/25] iotests: test clearing unknown autoclear_features by qcow2

From: Vladimir Sementsov-Ogievskiy Test clearing unknown autoclear_features by qcow2 on incoming migration. [ kwolf: Fixed wait for destination VM startup ] Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/196 | 66 +

[Qemu-devel] [PULL 09/25] qcow2: fix image corruption on commit with persistent bitmap

From: Eric Blake If an image contains persistent bitmaps, we cannot use the fast path of bdrv_make_empty() to clear the image during qemu-img commit, because that will lose the clusters related to the bitmaps. Also leave a comment in qcow2_read_extensions to remind future feature additions to th

[Qemu-devel] [PULL 17/25] qcow2: reject unaligned offsets in write compressed

From: Anton Nefedov Misaligned compressed write is not supported. Signed-off-by: Anton Nefedov Message-id: 1510654613-47868-2-git-send-email-anton.nefe...@virtuozzo.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- block/qcow2.c | 4 1 file changed, 4 insertions(+) diff --git a/

[Qemu-devel] [PULL 11/25] qapi/qlist: Add qlist_append_null() macro

From: Max Reitz Besides the macro itself, this patch also adds a corresponding Coccinelle rule. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Message-id: 20171114180128.17076-3-mre...@redhat.com Signed-off-by: Max Reitz --- include/qapi/qmp/qlist.h | 3

[Qemu-devel] [PULL 05/25] block: Deprecate bdrv_set_read_only() and users

bdrv_set_read_only() is used by some block drivers to override the read-only option given by the user. This is not how read-only images generally work in QEMU: Instead of second guessing what the user really meant (which currently includes making an image read-only even if the user didn't only use

[Qemu-devel] [PULL 07/25] block: Fix permissions in image activation

Inactive images generally request less permissions for their image files than they would if they were active (in particular, write permissions). Activating the image involves extending the permissions, therefore. drv->bdrv_invalidate_cache() can already require write access to the image file, so w

[Qemu-devel] [PULL 14/25] iotests: Add test for non-string option reopening

From: Max Reitz Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Message-id: 20171114180128.17076-6-mre...@redhat.com Signed-off-by: Max Reitz --- tests/qemu-iotests/133 | 9 + tests/qemu-iotests/133.out | 5 + 2 files changed, 14 insertions(+) diff -

[Qemu-devel] [PULL 06/25] qcow2: fix image corruption after committing qcow2 image into base

From: "Daniel P. Berrange" After committing the qcow2 image contents into the base image, qemu-img will call bdrv_make_empty to drop the payload in the layered image. When this is done for qcow2 images, it blows away the LUKS encryption header, making the resulting image unusable. There are two

[Qemu-devel] [PULL 00/25] Block layer patches for 2.11.0-rc2

The following changes since commit fec035a53fa15c4c8c4e62bfef56a35df4161e38: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20171117-pull-request' into staging (2017-11-17 10:18:41 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-ups

[Qemu-devel] [PULL 01/25] replication: Fix replication open fail

From: Wang Guang replication_child_perm request write permissions for all child which will lead bdrv_check_perm fail. replication_child_perm() should request write permissions only if it is writable itself. Signed-off-by: Wang Guang Signed-off-by: Wang Yong Reviewed-by: Xie Changlong Signed-o

[Qemu-devel] [PULL 13/25] block: qobject_is_equal() in bdrv_reopen_prepare()

From: Max Reitz Currently, bdrv_reopen_prepare() assumes that all BDS options are strings. However, this is not the case if the BDS has been created through the json: pseudo-protocol or blockdev-add. Note that the user-invokable reopen command is an HMP command, so you can only specify strings t

[Qemu-devel] [PULL 03/25] block: Fix error path in bdrv_backing_update_filename()

error_setg_errno() takes a positive errno code. Spotted by Coverity (CID 1381628). Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PULL 02/25] qemu-iotests: Use -nographic in 182

This avoids that random UI frontend error messages end up in the output. In particular, we were seeing this line in CI error logs: +Unable to init server: Could not connect: Connection refused Signed-off-by: Kevin Wolf Reviewed-by: Kashyap Chamarthy Reviewed-by: Jeff Cody --- tests/qemu-iotes

[Qemu-devel] [PULL 04/25] qcow2: don't permit changing encryption parameters

From: "Daniel P. Berrange" Currently if trying to change encryption parameters on a qcow2 image, qemu-img will abort. We already explicitly check for attempt to change encrypt.format but missed other parameters like encrypt.key-secret. Rather than list each parameter, just blacklist changing of a

[Qemu-devel] [PULL 10/25] qapi/qnull: Add own header

From: Max Reitz Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Reviewed-by: Markus Armbruster Message-id: 20171114180128.17076-2-mre...@redhat.com Signed-off-by: Max Reitz --- include/qapi/qmp/qdict.h| 1 + include/qapi/qmp/qnull.h| 30

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

On 11/17/2017 10:01 AM, Max Reitz wrote: > On 2017-11-17 13:30, Kevin Wolf wrote: >> Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> Snapshot-switch actually changes active state of disk so it should >>> reflect on dirty bitmaps. Otherwise next incremental backup using >>

[Qemu-devel] [PATCH for-2.11] pc-bios/s390-ccw: Fix problem with invalid virtio-scsi LUN when rebooting

When rebooting a guest that has a virtio-scsi disk, the s390-ccw bios sometimes bails out with an error message like this: ! SCSI cannot report LUNs: STATUS=02 RSPN=70 KEY=05 CODE=25 QLFR=00, sure ! Enabling the scsi_req* tracing in QEMU shows that the ccw bios is trying to execute the REPORT LUN

Re: [Qemu-devel] [PATCH 09/10] qemu-iotests: remove unused "here" variable

On 11/16/2017 11:38 AM, Cleber Rosa wrote: > Another legacy variable that did not convince me it has any > purpose whatsoever. > > Signed-off-by: Cleber Rosa > --- > +++ b/tests/qemu-iotests/001 > @@ -23,7 +23,6 @@ > seq=`basename $0` > echo "QA output created by $seq" > > -here=`pwd` Good

Re: [Qemu-devel] [PATCH 02/15] sun4u: ebus QOMify tidy-up

On 11/17/2017 10:42 AM, Mark Cave-Ayland wrote: > The main change here is to introduce the proper TYPE_EBUS/EBUS QOM macros > and remove the use of DO_UPCAST. > > Alongside this there are some a couple of minor cosmetic changes and a rename > of pci_ebus_realize() to ebus_realize() since the ebus

Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

On 11/17/2017 07:18 AM, Cleber Rosa wrote: > > > On 11/17/2017 02:19 AM, Paolo Bonzini wrote: >> On 16/11/2017 18:38, Cleber Rosa wrote: >>> This variables has no real use. To avoid pretending it does, while >>> still keeping the information, let's turn it into a comment. >>> >>> The format chos

Re: [Qemu-devel] [PATCH v8 04/14] block/dirty-bitmap: add bdrv_dirty_bitmap_set_frozen

17.11.2017 20:20, John Snow wrote: On 11/17/2017 09:46 AM, Vladimir Sementsov-Ogievskiy wrote: 14.11.2017 02:32, John Snow wrote: On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: Make it possible to set bitmap 'frozen' without a successor. This is needed to protect the bitmap durin

Re: [Qemu-devel] [PATCH v3 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

On Fri, Nov 17, 2017 at 11:07:41AM -0600, Eric Blake wrote: > On 11/17/2017 10:25 AM, Kashyap Chamarthy wrote: [...] > Sorry for not wordsmithing on earlier versions: That's fine. Always appreciate your wordsmithing :-) > > +'mirror' job *after* it has indicated (by emitting the event > >

Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot

Am 17.11.2017 um 18:07 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.11.2017 19:47, Eric Blake wrote: > > If an image contains persistent snapshots, we cannot use the > > bitmaps > > > fast path of bdrv_make_empty() to clear the image during > > qemu-img commit, because that will lose the cl

Re: [Qemu-devel] [PATCH v8 04/14] block/dirty-bitmap: add bdrv_dirty_bitmap_set_frozen

On 11/17/2017 09:46 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.11.2017 02:32, John Snow wrote: >> >> On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Make it possible to set bitmap 'frozen' without a successor. >>> This is needed to protect the bitmap during outgoing bitmap postc

Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot

Am 17.11.2017 um 17:47 hat Eric Blake geschrieben: > If an image contains persistent snapshots, we cannot use the > fast path of bdrv_make_empty() to clear the image during > qemu-img commit, because that will lose the clusters related > to the bitmaps. > > Also leave a comment in qcow2_read_exten

Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot

On 11/17/2017 11:07 AM, Vladimir Sementsov-Ogievskiy wrote: > 17.11.2017 19:47, Eric Blake wrote: >> If an image contains persistent snapshots, we cannot use the > > bitmaps Oh, right. Maintainer can fix that, if I don't need to respin. > >> fast path of bdrv_make_empty() to clear the image dur

Re: [Qemu-devel] [PATCH v3 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

On 11/17/2017 10:25 AM, Kashyap Chamarthy wrote: > When you cancel an in-progress live block operation with QMP > `block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED. However, > when `block-job-cancel` is issued after `drive-mirror` has indicated (by > emitting the event BLOCK_JOB_READY) t

Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot

17.11.2017 19:47, Eric Blake wrote: If an image contains persistent snapshots, we cannot use the bitmaps fast path of bdrv_make_empty() to clear the image during qemu-img commit, because that will lose the clusters related to the bitmaps. Also leave a comment in qcow2_read_extensions to remi

Re: [Qemu-devel] [PATCH] block: Close a BlockDriverState completely even when bs->drv is NULL

Am 17.11.2017 um 17:19 hat Alberto Garcia geschrieben: > On Fri 17 Nov 2017 05:14:08 PM CET, Max Reitz wrote: > > On 2017-11-06 15:53, Alberto Garcia wrote: > >> bdrv_close() skips much of its logic when bs->drv is NULL. This is > >> fine when we're closing a BlockDriverState that has just been cre

Re: [Qemu-devel] [PATCH v22 00/30] qcow2: persistent dirty bitmaps

On 11/17/2017 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: >> Nothing in this series touched qemu-img.  At the very minimum, it would >> be nice if 'qemu-img info' were to display a summary of all bitmaps in >> the qcow2 file; the QMP type ImageInfoSpecificQCow2 should be updated to >> mention th

[Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot

If an image contains persistent snapshots, we cannot use the fast path of bdrv_make_empty() to clear the image during qemu-img commit, because that will lose the clusters related to the bitmaps. Also leave a comment in qcow2_read_extensions to remind future feature additions to think about fast-pa

Re: [Qemu-devel] [PATCH 0/4] ramfb: simple boot framebuffer, no legacy vga

CC Ard & Drew Hi, On 11/17/17 13:04, Gerd Hoffmann wrote: > Hi, > > Ok folks, here is a experimental patch series for a legacy free boot > framebuffer. If you want play with it I recommend getting the bits from > > https://www.kraxel.org/cgit/qemu/log/?h=sirius/ramfb > > because they

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.11] spapr: reset DRCs after devices

On Fri, 17 Nov 2017 14:21:27 -0200 Daniel Henrique Barboza wrote: > On 11/17/2017 10:56 AM, Greg Kurz wrote: > > A DRC with a pending unplug request releases its associated device at > > machine reset time. > > > > In the case of LMB, when all DRCs for a DIMM device have been reset, > > the DIMM

[Qemu-devel] [PATCH v3] QAPI & interop: Clarify events emitted by 'block-job-cancel'

When you cancel an in-progress live block operation with QMP `block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED. However, when `block-job-cancel` is issued after `drive-mirror` has indicated (by emitting the event BLOCK_JOB_READY) that the source and destination remain synchronized:

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.11] spapr: reset DRCs after devices

On 11/17/2017 10:56 AM, Greg Kurz wrote: A DRC with a pending unplug request releases its associated device at machine reset time. In the case of LMB, when all DRCs for a DIMM device have been reset, the DIMM gets unplugged, causing guest memory to disappear. This may be very confusing for any

Re: [Qemu-devel] [PATCH v22 00/30] qcow2: persistent dirty bitmaps

17.11.2017 19:04, Eric Blake wrote: Revisiting an old series: On 06/28/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! There is a new update of qcow2-bitmap series - v22. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v22 git: https://src.openvz.org

Re: [Qemu-devel] [PATCH] block: Close a BlockDriverState completely even when bs->drv is NULL

On Fri 17 Nov 2017 05:14:08 PM CET, Max Reitz wrote: > On 2017-11-06 15:53, Alberto Garcia wrote: >> bdrv_close() skips much of its logic when bs->drv is NULL. This is >> fine when we're closing a BlockDriverState that has just been created >> (because e.g the initialization process failed), but it

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

On Thu 16 Nov 2017 10:56:58 PM CET, John Snow wrote: I have the impression that one major source of headaches is the fact that the reopen queue contains nodes that don't need to be reopened at all. Ideally this should be detected early on in bdrv_reopen_queue(), so there's no ch

Re: [Qemu-devel] [PATCH] block: Close a BlockDriverState completely even when bs->drv is NULL

On 2017-11-06 15:53, Alberto Garcia wrote: > bdrv_close() skips much of its logic when bs->drv is NULL. This is > fine when we're closing a BlockDriverState that has just been created > (because e.g the initialization process failed), but it's not enough > in other cases. > > For example, when a v

Re: [Qemu-devel] [PATCH] iotests: Make 087 pass without AIO enabled

On 2017-11-15 19:07, Max Reitz wrote: > If AIO has not been enabled in the qemu build that is to be tested, we > should skip the "aio=native without O_DIRECT" test instead of failing. > > Signed-off-by: Max Reitz > --- > Cleber wanted to fix this in July with his "build configuration query > tool

Re: [Qemu-devel] [PATCH v2 for-2.11] block: Make bdrv_next() keep strong references

On 2017-11-10 18:25, Max Reitz wrote: > On one hand, it is a good idea for bdrv_next() to return a strong > reference because ideally nearly every pointer should be refcounted. > This fixes intermittent failure of iotest 194. > > On the other, it is absolutely necessary for bdrv_next() itself to k

Re: [Qemu-devel] [PATCH 02/24] sdl: remove -alt-grab and -ctrl-grab support

> With absolute pointer devices such as usb-tablet being widely used > mouse grabs (for relative pointing devices) should be rarely needed > these days. So the benefit of the options to configure the hotkey > modifiers for grab (and other actions) seems questionable. Which > is expecially true f

Re: [Qemu-devel] [PATCH v22 00/30] qcow2: persistent dirty bitmaps

Revisiting an old series: On 06/28/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > There is a new update of qcow2-bitmap series - v22. > > web: > https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v22 > git: https://src.openvz.org/scm/~vsementsov/qemu.git

Re: [Qemu-devel] [PATCH for-2.11 2/2] iotests: test clearing unknown autoclear_features by qcow2

On 2017-11-17 16:47, Kevin Wolf wrote: > From: Vladimir Sementsov-Ogievskiy > > Test clearing unknown autoclear_features by qcow2 on incoming > migration. > > [ kwolf: Fixed wait for destination VM startup ] > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

On Fri, Nov 17, 2017 at 04:03:28PM +0100, Gerd Hoffmann wrote: Hi, OK, so the odd thing then is the check for !remote_display earlier on in the function (missing from the quote above) which seems to end up initializing VNC (albeit with localhost) when CONFIG_VNC is defined, but no other local

Re: [Qemu-devel] [PATCH for-2.11 1/2] block: Fix permissions in image activation

On 2017-11-17 16:47, Kevin Wolf wrote: > Inactive images generally request less permissions for their image files > than they would if they were active (in particular, write permissions). > Activating the image involves extending the permissions, therefore. > > drv->bdrv_invalidate_cache() can alr

[Qemu-devel] [PATCH for-2.11 2/2] iotests: test clearing unknown autoclear_features by qcow2

From: Vladimir Sementsov-Ogievskiy Test clearing unknown autoclear_features by qcow2 on incoming migration. [ kwolf: Fixed wait for destination VM startup ] Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf --- tests/qemu-iotests/196 | 66 +

[Qemu-devel] [PATCH for-2.11 1/2] block: Fix permissions in image activation

Inactive images generally request less permissions for their image files than they would if they were active (in particular, write permissions). Activating the image involves extending the permissions, therefore. drv->bdrv_invalidate_cache() can already require write access to the image file, so w

[Qemu-devel] [PATCH for-2.11 0/2] block: Fix permissions in image activation

Kevin Wolf (1): block: Fix permissions in image activation Vladimir Sementsov-Ogievskiy (1): iotests: test clearing unknown autoclear_features by qcow2 block.c| 32 +++--- tests/qemu-iotests/196 | 66 ++ test

Re: [Qemu-devel] [PATCH 03/15] sun4u: move ISABus inside of EBusState

On 17/11/17 14:53, Artyom Tarasenko wrote: > On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland > wrote: >> Since the EBus is effectively a PCI-ISA bridge then the underlying ISA bus >> should be contained within the PCI bridge itself. > > While it's like that on the Sabre chipset, the Spitfire c

Re: [Qemu-devel] [PATCH 01/15] apb: move QOM macros and typedefs from apb.c to apb.h

On 17/11/17 14:24, Artyom Tarasenko wrote: > Hi Mark, > > On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland > wrote: >> This also includes the related IOMMUState typedef and defines. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/pci-host/apb.c | 85 >> --

Re: [Qemu-devel] [PATCH v2 1/1] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

* Daniel Henrique Barboza (danie...@linux.vnet.ibm.com) wrote: > When migrating a VM with 'migrate_set_capability postcopy-ram on' > a postcopy_state is set during the process, ending up with the > state POSTCOPY_INCOMING_END when the migration is over. This > postcopy_state is taken into account i

[Qemu-devel] [PULL 2/4] nbd/client: Use error_prepend() correctly

When using error prepend(), it is necessary to end with a space in the format string; otherwise, messages come out incorrectly, such as when connecting to a socket that hangs up immediately: can't open device nbd://localhost:10809/: Failed to read dataUnexpected end-of-file before all bytes were

[Qemu-devel] [PULL 1/4] nbd: Don't crash when server reports NBD_CMD_READ failure

If a server fails a read, for example with EIO, but the connection is still live, then we would crash trying to print a non-existent error message in nbd_client_co_preadv(). For consistency, also change the error printout in nbd_read_reply_entry(), although that instance does not crash. Bug intro

Re: [Qemu-devel] [PATCH 01/24] sdl: remove -no-frame support

On Fri, Nov 17, 2017 at 02:59:54PM +, Daniel P. Berrange wrote: > On Fri, Nov 17, 2017 at 03:49:06PM +0100, Gerd Hoffmann wrote: > > On Fri, Nov 17, 2017 at 02:21:30PM +, Daniel P. Berrange wrote: > > > On Fri, Nov 17, 2017 at 11:30:23AM +0100, Gerd Hoffmann wrote: > > > > SDL2 doesn't supp

[Qemu-devel] [PULL 4/4] nbd/server: Fix error reporting for bad requests

The NBD spec says an attempt to NBD_CMD_TRIM on a read-only export should fail with EPERM, as a trim has the potential to change disk contents, but we were relying on the block layer to catch that for us, which might not always give the right error (and even if it does, it does not let us pass back

  1   2   3   >