Re: [Qemu-devel] [RFC PATCH qemu] git-submodule.sh: Do not try writing to source directory if not necessary

On Wed, Oct 25, 2017 at 12:45:10PM +1100, Alexey Kardashevskiy wrote: > On 25/10/17 03:27, Daniel P. Berrange wrote: > > On Tue, Oct 24, 2017 at 07:58:53PM +1100, Alexey Kardashevskiy wrote: > >> The new git-submodule.sh script writes .git-submodule-status to > >> the source directory every time no

Re: [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

On Mon, Oct 23, 2017 at 10:45:41AM +0200, Igor Mammedov wrote: > On Fri, 20 Oct 2017 17:53:09 -0200 > Eduardo Habkost wrote: > > > On Fri, Oct 20, 2017 at 12:21:30PM +1100, David Gibson wrote: > > > On Thu, Oct 19, 2017 at 02:23:04PM +0200, Paolo Bonzini wrote: > > > > On 19/10/2017 13:49, Davi

Re: [Qemu-devel] [PATCH 4/6] Fixed IRQ problem for CAN device can_pcm3680_pci.

Can't this be merged in the previous patch? Fred On 10/25/2017 01:29 AM, p...@cmp.felk.cvut.cz wrote: From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/can_pcm3680_pci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/can/can_pcm3680_pci.c b/hw/can/can_pcm3680_pci.

[Qemu-devel] [PATCH] replication: Fix replication open fail

replication_child_perm request write permissions for all child which will lead bdrv_check_perm fail. replication_child_perm() should request write permissions only if it is writable itself. Signed-off-by: Wang Guang Signed-off-by: Wang Yong --- block/replication.c | 11 +++ 1 file chang

Re: [Qemu-devel] iotest 194 fails on vhdx

On 25/10/17 15:29, Alexey Kardashevskiy wrote: > Hi! > > The latest QEMU fails on: > tests/qemu-iotests/check -vhdx 194 Bit more details: 1. the assert started appearing from https://git.qemu.org/?p=qemu.git;a=commit;h=09e0c771e47 - this one just added the assert; 2. if removed, then another a

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

Collin, can you take care of the comments and send out a new version? On 10/20/2017 03:48 PM, Farhan Ali wrote: > > > On 10/20/2017 07:02 AM, Christian Borntraeger wrote: >> --- a/pc-bios/s390-ccw/sclp.c >> +++ b/pc-bios/s390-ccw/sclp.c >> @@ -83,7 +83,7 @@ long write(int fd, const void *str, s

[Qemu-devel] [PATCH v3 5/5] migration: [RFC] Use proper types in json

We use int for everything (int64_t), and then we check that value is between 0 and 255. Change it to the valid types. For qmp, the only real change is that now max_bandwidth allows to use the k/M/G suffixes. Signed-off-by: Juan Quintela --- hmp.c | 22 +++--- mi

[Qemu-devel] [PATCH v3 4/5] migration: Make xbzrle_cache_size a migration parameter

Right now it is a variable in MigrationState instead of a MigrationParameter. The change allows to set it as the rest of the Migration parameters, from the command line, with query_migration_paramters, set_migrate_parameters, etc. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH v3 3/5] migration: No need to return the size of the cache

After the previous commits, we make sure that the value passed is right, or we just drop an error. So now we return if there is one error or we have setup correctly the value passed. Signed-off-by: Juan Quintela -- Improve error messasge Return 0 always for success --- migration/migration.c |

[Qemu-devel] [PATCH v3 1/5] migration: Make sure that we pass the right cache size

Instead of passing silently round down the number of pages, make it an error that the cache size is not a power of 2. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/page_cache.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migr

[Qemu-devel] [PATCH v3 2/5] migration: Don't play games with the requested cache size

Now that we check that the value passed is a power of 2, we don't need to play games when comparing what is the size that is going to take the cache. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletio

[Qemu-devel] [PATCH v3 0/5] Make xbzrle_cache_size a migration parameter

Hi On v3: - rebase on top of last migration pull requset - improve comments (dave suggestion) - always return 0 in case of error - checked with ovirt/openstack/libvirt people that making value a power of two is not a problem. - should I drop the last patch, or sent it? Please revieww. [v2]

[Qemu-devel] [PATCH 1/5] tpm: add missing include

From: Philippe Mathieu-Daudé else file including "sysemu/tpm.h" fails to compile: In file included from qemu/stubs/tpm.c:2:0: qemu/include/sysemu/tpm.h:36:19: error: implicit declaration of function ‘object_resolve_path_type’ [-Werror=implicit-function-declaration] Object *obj = obje

[Qemu-devel] [PATCH 2/5] tpm: add stubs

From: Philippe Mathieu-Daudé Commit c37cacabf22 moved tpm_cleanup() in the main loop exit, however this function is not available when compiling with --disable-tpm. Provides necessary stubs to keep code clean of #ifdef'fery. Reported-by: BALATON Zoltan Message-Id: <20171023102903.256af745...@z

[Qemu-devel] [PATCH 3/5] tpm: remove unnecessary #ifdef CONFIG_TPM

From: Philippe Mathieu-Daudé Makefile.objs now checks for $(CONFIG_TPM). Suggested-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger Reviewed-by: Juan Quintela Signed-off-by: Stefan Berger --- tpm.c | 4 1 file changed, 4 deletions(-) diff --git a/tpm

[Qemu-devel] [PATCH 5/5] tpm: print buffers received from TPM when debugging

Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau --- hw/tpm/tpm_tis.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 8c5cac5..7402528 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -422,6 +422,8 @@ static void tpm_tis_receive_b

[Qemu-devel] [PATCH 4/5] vl: remove unnecessary #ifdef CONFIG_TPM

From: Philippe Mathieu-Daudé a stub is now provided. Signed-off-by: Philippe Mathieu-Daudé Tested-by: Richard W.M. Jones Reviewed-by: Juan Quintela Signed-off-by: Stefan Berger --- vl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vl.c b/vl.c index 0723835..ec29909 100644 --- a/vl.c

[Qemu-devel] [PATCH 0/5] Merge tpm 2017/10/24

*The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20171023-pull-request' into staging (2017-10-24 16:05:57 +0100) are available in the git repository at: git://github.com/stefanberger/qemu-tpm.git tags/pull-tp

[Qemu-devel] iotest 194 fails on vhdx

Hi! The latest QEMU fails on: tests/qemu-iotests/check -vhdx 194 /home/aik/pbuild/qemu-aikhostos2-ppc64-softmmu-debug-build/ppc64-softmmu/qemu-system-ppc64 \ -chardev socket,id=mon,path=/home/aik/qemudest-monitor.sock \ -mon chardev=mon,mode=control \ -display none \ -vga none \ -machine ac

[Qemu-devel] [PATCH v2] linux-user: fix is_proc_myself to check the paths via realpath

Previously, it was possible to get a handle to the "real" /proc/self/mem by creating a symlink to it and opening the symlink, or opening e.g. "./mem" after chdir'ing to "/proc/self". $ ln -s /proc/self self $ cat self/maps 6000-602bc000 r-xp fc:01 270375

Re: [Qemu-devel] [PATCH] linux-user: fix is_proc_myself to check the paths via realpath

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171024230758.31779-1-rig...@google.com Subject: [Qemu-devel] [PATCH] linux-user: fix is_proc_myself to check the paths via realpath === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity

Fixed incorrect frame size mask, validated maximum frame size in spi_write and removed dead code. Signed-off-by: Subbaraya Sundeep --- v4: changed %d to %u while logging frame size error. v3: Added comment that [31:6] bits are reserved in R_SPI_DFSIZE register and logged i

[Qemu-devel] [PATCH] linux-user: fix is_proc_myself to check the paths via realpath

From: Zach Riggle Previously, it was possible to get a handle to the "real" /proc/self/mem by creating a symlink to it and opening the symlink, or opening e.g. "./mem" after chdir'ing to "/proc/self". $ ln -s /proc/self self $ cat self/maps 6000-602bc000 r-xp fc:01 27037

Re: [Qemu-devel] [RFC PATCH qemu] git-submodule.sh: Do not try writing to source directory if not necessary

On 25/10/17 03:27, Daniel P. Berrange wrote: > On Tue, Oct 24, 2017 at 07:58:53PM +1100, Alexey Kardashevskiy wrote: >> The new git-submodule.sh script writes .git-submodule-status to >> the source directory every time no matter what. This makes it conditional. >> >> Signed-off-by: Alexey Kardashev

Re: [Qemu-devel] [PATCH v4 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Tuesday, October 24, 2017 8:53 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; m...@redhat.com; > marcandre.lur...@redhat.com; fel...@nutanix.com; Harris, James R > > Subject: Re:

Re: [Qemu-devel] [RFC PATCH qemu] git-submodule.sh: Do not try writing to source directory if not necessary

On 25/10/17 03:33, Peter Maydell wrote: > On 24 October 2017 at 17:27, Daniel P. Berrange wrote: >> On Tue, Oct 24, 2017 at 07:58:53PM +1100, Alexey Kardashevskiy wrote: >>> I compile out of tree on a remote guest system where I mount the >>> source directory as "readonly" and build directory as "

[Qemu-devel] [PATCH 6/6] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.

From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_mioe3680_pci.c | 335 ++ 2 files changed, 336 insertions(+) create mode 100644 hw/can/can_mioe3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can/Makefile

[Qemu-devel] [PATCH 5/6] Minor clean-up of can_pcm3680_pci.

From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/can_pcm3680_pci.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/can/can_pcm3680_pci.c b/hw/can/can_pcm3680_pci.c index bc6b164ea7..692aab6ab8 100644 --- a/hw/can/can_pcm3680_pci.c +++ b/hw/can/can_pcm3680_pci.

[Qemu-devel] [PATCH 3/6] CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.

From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_pcm3680_pci.c | 325 +++ 2 files changed, 326 insertions(+) create mode 100644 hw/can/can_pcm3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can/Makefile.o

[Qemu-devel] [PATCH 4/6] Fixed IRQ problem for CAN device can_pcm3680_pci.

From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/can_pcm3680_pci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/can/can_pcm3680_pci.c b/hw/can/can_pcm3680_pci.c index 77523f2ddb..bc6b164ea7 100644 --- a/hw/can/can_pcm3680_pci.c +++ b/hw/can/can_pcm3680_pci.c @@ -61,6

[Qemu-devel] [PATCH 2/6] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

From: Pavel Pisa Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs| 1 + hw/can/can_kvaser_pci.c | 376 2 files changed, 377 insertions(+) create mode 100644 hw/can/can_kvaser_pci.c diff --git a/hw/can/Makefile.objs b/hw/can/Makefile.obj

Re: [Qemu-devel] [PATCH v2 3/4] tpm: remove unnecessary #ifdef CONFIG_TPM

Philippe Mathieu-Daudé wrote: > Makefile.objs now checks for $(CONFIG_TPM). > > Suggested-by: Stefan Berger > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 4/4] vl: remove unnecessary #ifdef CONFIG_TPM

Philippe Mathieu-Daudé wrote: > a stub is now provided. > > Signed-off-by: Philippe Mathieu-Daudé > Tested-by: Richard W.M. Jones Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 2/4] tpm: add stubs

Philippe Mathieu-Daudé wrote: > Commit c37cacabf22 moved tpm_cleanup() in the main loop exit, however this > function is not available when compiling with --disable-tpm. > > Provides necessary stubs to keep code clean of #ifdef'fery. > > Reported-by: BALATON Zoltan > Message-Id: <20171023102903.2

[Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU

From: Pavel Pisa The work is based on Jin Yang GSoC 2013 work funded by Google and mentored in frame of RTEMS project GSoC slot donated to QEMU. Rewritten for QEMU-2.0+ versions and architecture cleanup by Pavel Pisa (Czech Technical University in Prague). The core SJA1000 support is independen

[Qemu-devel] [PATCH 0/6] CAN bus support for QEMU (SJA1000 PCI so far)

From: Pavel Pisa Basic emulation of CAN bus controller and interconnection for QEMU. The work has been started by Jin Yang in the frame of GSoC 2013 slot contributed by RTEMS project which has been looking for environment to allow develope and test CAN drivers for multiple CPU rachitectures. I

Re: [Qemu-devel] [PATCH v7 03/11] target/arm: Move BE32 disassembler fixup

On 10/21/2017 09:46 PM, Richard Henderson wrote: > The Capstone disassembler has its own big-endian fixup. > Doing this twice does not work, of course. Move our current > fixup from target/arm/cpu.c to disas/arm.c. > > This makes read_memory_inner_func unused and can be removed. > > Signed-off-b

Re: [Qemu-devel] [sw-dev] [RFC] RISC-V Decoder generator

On 10/22/2017 03:22 PM, Bastian Koppelmann wrote: > Hi Richard, > > On 10/21/2017 08:44 AM, Richard W.M. Jones wrote: >> On Fri, Oct 20, 2017 at 03:46:54PM +0200, Bastian Koppelmann wrote: >>> I asked you for feedback some while ago regarding a modular RISC-V QEMU >>> target (see discussion [1]).

[Qemu-devel] [PATCH v3 09/13] xilinx_spips: Add support for zero pumping

Add support for zero pumping according to the transfer size register. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 47 --- include/hw/ssi/xilinx_spips.h | 2 ++ 2 files changed, 42 insertions(+), 7 deletions(-) diff --git a/hw/ss

[Qemu-devel] [PATCH v3 12/13] xilinx_spips: Add support for the ZynqMP Generic QSPI

Add support for the Zynq Ultrascale MPSoc Generic QSPI. Signed-off-by: Francisco Iglesias --- default-configs/arm-softmmu.mak | 1 + hw/ssi/xilinx_spips.c | 451 include/hw/ssi/xilinx_spips.h | 30 ++- 3 files changed, 437 insertions(+), 45

[Qemu-devel] [PATCH v3 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done

Don't set TX FIFO UNDERFLOW interrupt after done transmiting the commands. Also update interrupts after reading out the interrupt status. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/

[Qemu-devel] [PATCH v3 06/13] xilinx_spips: Update striping to be big-endian bit order

Update striping functionality to be big-endian bit order and output even bits into flash memory connected to the lower QSPI bus and odd bits into the flash memory connected to the upper QSPI bus. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 19 ++- 1 file changed

[Qemu-devel] [PATCH v3 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

Add support for the ZynqMP QSPI (consisting of the Generic QSPI and Legacy QSPI) and connect Numonyx n25q512a11 flashes to it. Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-zcu102.c | 23 +++ hw/arm/xlnx-zynqmp.c | 24 include/hw/a

[Qemu-devel] [PATCH v3 04/13] m25p80: Add support for n25q512a11 and n25q512a13

Add support for Micron (Numonyx) n25q512a11 and n25q512a13 flashes. Signed-off-by: Francisco Iglesias --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 3d2975c..7f3fcc4 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@

[Qemu-devel] [PATCH v3 10/13] xilinx_spips: Add support for 4 byte addresses in the LQSPI

Add support for 4 byte addresses in the LQSPI and correct LQSPI_CFG_SEP_BUS. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index df5d908..5e5e8cc 100644 --- a/hw/s

Re: [Qemu-devel] [PATCH v7 19/52] tcg: Remove TCGV_EQUAL*

On 10/24/2017 05:11 AM, Philippe Mathieu-Daudé wrote: >> /* If no temporary was used, be careful not to alias t1 and t0. */ >> -t0 = TCGV_EQUAL(t1, cpu_cc_src) ? cpu_tmp0 : reg; >> +t0 = t1 == cpu_cc_src ? cpu_tmp0 : reg; > As I noticed in a previous patch, this expression is

[Qemu-devel] [PATCH v3 02/13] m25p80: Add support for SST READ ID 0x90/0xAB commands

Add support for SST READ ID 0x90/0xAB commands for reading out the flash manufacuter ID and device ID. Signed-off-by: Francisco Iglesias --- hw/block/m25p80.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 2971519..c85e8fa 10

[Qemu-devel] [PATCH v3 08/13] xilinx_spips: Make tx/rx_data_bytes more generic and reusable

Make tx/rx_data_bytes more generic so they can be reused (when adding support for the Zynqmp Generic QSPI). Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 64 +-- 1 file changed, 37 insertions(+), 27 deletions(-) diff --git a/hw/ssi

[Qemu-devel] [PATCH v3 05/13] xilinx_spips: Move FlashCMD, XilinxQSPIPS and XilinxSPIPSClass

Move the FlashCMD enum, XilinxQSPIPS and XilinxSPIPSClass structures to the header for consistency. Also move out a define and remove two dubbel included headers (while touching the code). Finally, add 4 byte address commands to the FlashCMD enum. Signed-off-by: Francisco Iglesias --- hw/ssi/xil

[Qemu-devel] [PATCH v3 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

Add support for continuous read out of the RDSR and READ_FSR status registers until the chip select is deasserted. This feature is supported by amongst others 1 or more flashtypes manufactured by Numonyx (Micron), Windbond, SST, Gigadevice, Eon and Macronix. Signed-off-by: Francisco Iglesias ---

[Qemu-devel] [PATCH v3 03/13] m25p80: Add support for BRRD/BRWR and BULK_ERASE (0x60)

Add support for the bank address register access commands (BRRD/BRWR) and the BULK_ERASE (0x60) command. Signed-off-by: Francisco Iglesias --- hw/block/m25p80.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index c85e8fa..3d2975c

[Qemu-devel] [PATCH v3 00/13] Add support for the ZynqMP Generic QSPI

Hi, This patch series is an attempt to add support for the ZynqMP QSPI (consisting of the Generic QSPI and the legacy QSPI) to the xlnx-zcu102 board and connect Numonyx n25q512a11 flashes to the QSPI. Also some functionality is added to m25p80. The series starts by adding support in m25p80 for c

Re: [Qemu-devel] [PATCH v7 11/11] disas: Add capstone as submodule

On 10/24/2017 06:45 PM, Philippe Mathieu-Daudé wrote: > Hi Richard, > > On 10/21/2017 09:46 PM, Richard Henderson wrote: >> Do not require the submodule, but use it if present. Allow the >> command-line to override system or git submodule either way. >> >> Signed-off-by: Richard Henderson >> ---

Re: [Qemu-devel] Command line option "-option-rom" doesn't take the ROM file

Thank you, Stefan! That worked. Sorry for the double email, I'm learning quickly :) On Tue, Oct 24, 2017 at 4:50 AM, Stefan Hajnoczi wrote: > On Mon, Oct 23, 2017 at 02:22:05PM -0700, Deema B wrote: > > I'm trying to use the -option-rom option to supply my own virtio OpROM. > > > > I am not abl

Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas : facility

Anthony PERARD writes ("Re: [PATCH v5.1 7/8] os-posix: Provide new -runas : facility"): > On Fri, Oct 20, 2017 at 02:38:21PM +0100, Ian Jackson wrote: > > +static bool os_parse_runas_uid_gid(const char *optarg) ... > > +errno = 0; > > +lv = strtoul(optarg, &ep, 0); /* can't qemu_strtoul, w

Re: [Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm

On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote: > This fixes building with --disable-tpm as reported by Zoltan: > http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html > > Cc'ing Peter in case this enters as a build fix instead of via trivial. > > v2: > - added

[Qemu-devel] [PATCH v3] fix WFI/WFE length in syndrome register

WFI/E are often, but not always, 4 bytes long. When they are, we need to set ARM_EL_IL_SHIFT in the syndrome register. Pass the instruction length to HELPER(wfi), use it to decrement pc appropriately and to pass an is_16bit flag to syn_wfx, which sets ARM_EL_IL_SHIFT if needed. Set dc->insn in bo

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/virt: support 4 serial ports

Hey folks, In case you're curious, this is the kind of hideous workaround required until this is fixed: https://git.zx2c4.com/WireGuard/commit/?id=2456a56729f7247bf88476317fed0ac822a31e92 Please let me know if you intend to fix this or if you will accept working patches from me for it, or if you

Re: [Qemu-devel] [PATCH v2] fix WFI/WFE length in syndrome register

On Tue, 24 Oct 2017, Stefano Stabellini wrote: > On Tue, 24 Oct 2017, Peter Maydell wrote: > > On 24 October 2017 at 16:53, Peter Maydell wrote: > > > On 21 October 2017 at 19:09, Stefano Stabellini > > > wrote: > > >> diff --git a/target/arm/translate.c b/target/arm/translate.c > > >> index 4da

[Qemu-devel] [RFC v5 1/2] virtio: introduce `query-virtio' QMP command

The command is intended for gathering virtio information such as status, feature bits, negotiation status. It is convenient and useful for debug purpose. The commands returns generic virtio information for virtio such as common feature names and status bits names and information for all attached t

[Qemu-devel] [RFC v5 2/2] virtio: add `info virtio' HMP command

The command prints data from `query-virtio' QMP in human-readable format. Cc: Denis V. Lunev Signed-off-by: Jan Dakinevich --- hmp-commands-info.hx | 14 ++ hmp.c| 122 +++ hmp.h| 1 + 3 files changed, 137 in

[Qemu-devel] [RFC v5 0/2] virtio: introduce `info virtio' hmp command

Previously, it was suggested to use QAPI unions/enums to declare feature bits. Some of weak parts of my code (such `get_feature_name' callback) went away. But a lot of of dummy code with feature declaration is still here, it just migrated to json file. So, I would be glad to get a responce if m

Re: [Qemu-devel] [PATCH v2] fix WFI/WFE length in syndrome register

On Tue, 24 Oct 2017, Peter Maydell wrote: > On 24 October 2017 at 16:53, Peter Maydell wrote: > > On 21 October 2017 at 19:09, Stefano Stabellini > > wrote: > >> diff --git a/target/arm/translate.c b/target/arm/translate.c > >> index 4da1a4c..a89518f 100644 > >> --- a/target/arm/translate.c > >>

Re: [Qemu-devel] [PATCH 3/7] sdl2: Do not hide the cursor on auxilliary windows

On Mon, 23 Oct 2017 23:38:16 -0300 Philippe Mathieu-Daudé wrote: > Hi Jindrich, > > This looks like 2 different patches, can you split? Hi, here is the split version. > > On 10/23/2017 06:07 PM, Jindrich Makovicka wrote: > > --- > > ui/sdl2.c | 41 ++--- >

Re: [Qemu-devel] [PATCH v2 3/4] tpm: remove unnecessary #ifdef CONFIG_TPM

On 10/24/2017 08:20 AM, Philippe Mathieu-Daudé wrote: Makefile.objs now checks for $(CONFIG_TPM). Suggested-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger --- tpm.c | 4 1 file changed, 4 deletions(-) diff --git a/tpm.c b/tpm.c index 45520f555d

Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas : facility

On Fri, Oct 20, 2017 at 02:38:21PM +0100, Ian Jackson wrote: > +static bool os_parse_runas_uid_gid(const char *optarg) > +{ > +unsigned long lv; > +char *ep; > +uid_t got_uid; > +gid_t got_gid; > +int rc; > + > +errno = 0; > +lv = strtoul(optarg, &ep, 0); /* can't qemu_s

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 00/20] ARM SMMUv3 Emulation Support

Hi Will, On Tue, Oct 24, 2017 at 11:20:29AM +0100, Will Deacon wrote: > On Tue, Oct 24, 2017 at 11:08:02AM +0530, Linu Cherian wrote: > > On Fri Sep 01, 2017 at 07:21:03PM +0200, Eric Auger wrote: > > > This series implements the emulation code for ARM SMMUv3. > > > > > > Changes since v6: > > >

Re: [Qemu-devel] [PATCH v7 06/11] disas: Support the Capstone disassembler library

On 10/21/2017 09:46 PM, Richard Henderson wrote: > If configured, prefer this over our rather dated copy of the > GPLv2-only binutils. This will be especially apparent with > the proposed vector extensions to TCG, as disas/i386.c does > not handle AVX. > > Reviewed-by: Philippe Mathieu-Daudé > S

Re: [Qemu-devel] [PATCH v7 11/11] disas: Add capstone as submodule

Hi Richard, On 10/21/2017 09:46 PM, Richard Henderson wrote: > Do not require the submodule, but use it if present. Allow the > command-line to override system or git submodule either way. > > Signed-off-by: Richard Henderson > --- > Makefile| 13 + > .gitmodules | 3 +++ > ca

Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it

On Tue, Oct 24, 2017 at 12:16:47AM -0400, Programmingkid wrote: > > > On Oct 22, 2017, at 1:33 AM, David Gibson > > wrote: > > > > On Fri, Oct 20, 2017 at 04:44:58PM -0700, Richard Henderson wrote: > >> On 10/20/2017 10:55 AM, John Arbuckle wrote: > >>> +static inline size_t strnlen(const char

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

> From: bzt bzt [mailto:bztem...@gmail.com] > Sent: Tuesday, 24 October 2017 02:54 > On Mon, Oct 23, 2017 at 6:34 PM, Andrew Baumann wrote: > Are there any changes from bcm2836 other than the CPU model? > > > Duplicating the whole file just to have a different CPU seems like a bad > i

Re: [Qemu-devel] [RFC PATCH qemu] git-submodule.sh: Do not try writing to source directory if not necessary

On 24 October 2017 at 17:27, Daniel P. Berrange wrote: > On Tue, Oct 24, 2017 at 07:58:53PM +1100, Alexey Kardashevskiy wrote: >> I compile out of tree on a remote guest system where I mount the >> source directory as "readonly" and build directory as "rw" and >> scripts/git-submodule.sh tries wri

Re: [Qemu-devel] [PATCH v2] fix WFI/WFE length in syndrome register

On 24 October 2017 at 16:53, Peter Maydell wrote: > On 21 October 2017 at 19:09, Stefano Stabellini > wrote: >> diff --git a/target/arm/translate.c b/target/arm/translate.c >> index 4da1a4c..a89518f 100644 >> --- a/target/arm/translate.c >> +++ b/target/arm/translate.c >> @@ -12325,12 +12325,15

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

On Tue, Oct 24, 2017 at 1:05 PM, BALATON Zoltan wrote: [...] > Summa summarum, which one is preferred? Think of the future or keep it at a >> bare minimum? >> > > I don't feel I have a deciding word in this but to share my opinion I > think it's better to keep it in one file avoiding too much cod

Re: [Qemu-devel] [RFC PATCH qemu] git-submodule.sh: Do not try writing to source directory if not necessary

On Tue, Oct 24, 2017 at 07:58:53PM +1100, Alexey Kardashevskiy wrote: > The new git-submodule.sh script writes .git-submodule-status to > the source directory every time no matter what. This makes it conditional. > > Signed-off-by: Alexey Kardashevskiy > --- > > I compile out of tree on a remote

Re: [Qemu-devel] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__

On Thu, Oct 19, 2017 at 09:15:41AM -0700, Alistair Francis wrote: > Replace all occurs of __FUNCTION__ except for the check in checkpatch > with the non GCC specific __func__. > > One line in hcd-musb.c was manually tweaked to pass checkpatch. > > Signed-off-by: Alistair Francis > Cc: Gerd Hoffm

Re: [Qemu-devel] [PATCH v3 40/46] hw/watchdog: Replace fprintf(stderr, "*\n" with error_report()

On 10/19/2017 01:18 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N; {s|

Re: [Qemu-devel] [PATCH v3 34/46] hw/sd: Replace fprintf(stderr, "*\n" with error_report()

On 10/19/2017 01:17 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N; {s|

Re: [Qemu-devel] [PATCH v3 16/46] hw/ide: Replace fprintf(stderr, "*\n" with error_report()

Hi Alistair, On 10/19/2017 01:16 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;

Re: [Qemu-devel] [PULL 0/1] Usb 20171023 patches

On 23 October 2017 at 09:45, Gerd Hoffmann wrote: > The following changes since commit e822e81e350825dd94f41ee2538ff1432b812eb9: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-10-20 15:04:00 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v2] fix WFI/WFE length in syndrome register

On 21 October 2017 at 19:09, Stefano Stabellini wrote: > WFI/E are often, but not always, 4 bytes long. When they are, we need to > set ARM_EL_IL_SHIFT in the syndrome register. > > Pass the instruction length to HELPER(wfi), use it to decrement pc > appropriately and to pass an is_16bit flag to s

[Qemu-devel] [Bug 1726910] [NEW] UI request: add a function key toolbar (f1-f12)

Public bug reported: I run old DOS programs under FreeDOS using QEMU. It's common when running/testing DOS applications to use the function keys. Some of these (such as F10) are intercepted by the window system. For example, some DOS program installers use F10 to install the software, but F10 is

Re: [Qemu-devel] [PULL 0/3] Fixes 20171023 patches

On 23 October 2017 at 09:02, Gerd Hoffmann wrote: > The following changes since commit e822e81e350825dd94f41ee2538ff1432b812eb9: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-10-20 15:04:00 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v3 41/46] hw/xen*: Replace fprintf(stderr, "*\n" with error_report()

On Thu, Oct 19, 2017 at 09:18:14AM -0700, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;

Re: [Qemu-devel] [libfdt][PATCH v3] implement strnlen for systems that need it

> On Oct 24, 2017, at 8:09 AM, Stefan Hajnoczi wrote: > > On Mon, Oct 23, 2017 at 11:13:13PM -0400, Programmingkid wrote: >> >>> On Oct 23, 2017, at 12:09 PM, Stefan Hajnoczi wrote: >>> >>> On Sun, Oct 22, 2017 at 10:50:16PM -0400, John Arbuckle wrote: Prior the Mac OS 10.7, the function

Re: [Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm

>> v2: >> - added Richard W.M. Jones Tested-by tag >> - remove #ifdef CONFIG_TPM in tpm.c (Stefan Berger) > > Can confirm v2 works as well. Thanks for testing!

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

On Tue, Oct 24, 2017 at 12:52:28AM +, Liu, Changpeng wrote: > > > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > > Sent: Tuesday, October 24, 2017 1:26 AM > > To: Liu, Changpeng > > Cc: Michael S. Tsirkin ; qemu-devel@nongnu.org; > > pbonz...@redhat.com;

Re: [Qemu-devel] [PATCH v1] os-posix: Add -unshare option

On Mon, Oct 23, 2017 at 03:30:05PM +0100, Ross Lagerwall wrote: > On 10/19/2017 05:24 PM, Daniel P. Berrange wrote: > > On Thu, Oct 19, 2017 at 05:04:19PM +0100, Ross Lagerwall wrote: > > > Add an option to allow calling unshare() just before starting guest > > > execution. The option allows unshar

Re: [Qemu-devel] [PATCH v4 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

On Tue, Oct 24, 2017 at 12:44:30AM +, Liu, Changpeng wrote: > > > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > > Sent: Tuesday, October 24, 2017 1:12 AM > > To: Liu, Changpeng > > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; m...@redhat.com; > > mar

Re: [Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm

On Tue, Oct 24, 2017 at 09:20:41AM -0300, Philippe Mathieu-Daudé wrote: > This fixes building with --disable-tpm as reported by Zoltan: > http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html > > Cc'ing Peter in case this enters as a build fix instead of via trivial. > > v2: > -

Re: [Qemu-devel] [Qemu-block] Question regarding qemuimg check

Thanks for the detailed reply, Stefan. Can we always run qemu-img check with -r leaks option, even if there are no leaks? On Tue, Oct 24, 2017 at 3:06 PM, Stefan Hajnoczi wrote: > On Mon, Oct 23, 2017 at 03:38:40PM +0300, Ala Hino wrote: > > I have a question regarding qemuimg check. We use qem

Re: [Qemu-devel] [Qemu-block] [PATCH] ide: avoid referencing NULL dev in rotational rate setting

On Tue, Oct 24, 2017 at 08:43:24AM +0100, Daniel P. Berrange wrote: > CC John Feel free to ping me if John doesn't respond by next Wednesday and I'll merge this trivial fix. Stefan

[Qemu-devel] [PATCH v2 1/4] tpm: add missing include

else file including "sysemu/tpm.h" fails to compile: In file included from qemu/stubs/tpm.c:2:0: qemu/include/sysemu/tpm.h:36:19: error: implicit declaration of function ‘object_resolve_path_type’ [-Werror=implicit-function-declaration] Object *obj = object_resolve_path_type("", TYPE_T

[Qemu-devel] [PATCH v2 4/4] vl: remove unnecessary #ifdef CONFIG_TPM

a stub is now provided. Signed-off-by: Philippe Mathieu-Daudé Tested-by: Richard W.M. Jones --- vl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vl.c b/vl.c index 0723835bbf..ec299099ff 100644 --- a/vl.c +++ b/vl.c @@ -4624,11 +4624,9 @@ int main(int argc, char **argv, char **envp)

Re: [Qemu-devel] [Qemu-block] Question regarding qemuimg check

On Mon, Oct 23, 2017 at 03:38:40PM +0300, Ala Hino wrote: > I have a question regarding qemuimg check. We use qemuimg check in order to > get the offset of image. we need the offset to reduce the size of the image > to optimal. > > In BZ 1502488 , we are encoun

[Qemu-devel] [PATCH v2 2/4] tpm: add stubs

Commit c37cacabf22 moved tpm_cleanup() in the main loop exit, however this function is not available when compiling with --disable-tpm. Provides necessary stubs to keep code clean of #ifdef'fery. Reported-by: BALATON Zoltan Message-Id: <20171023102903.256af745...@zero.eik.bme.hu> Signed-off-by:

[Qemu-devel] [PATCH v2 3/4] tpm: remove unnecessary #ifdef CONFIG_TPM

Makefile.objs now checks for $(CONFIG_TPM). Suggested-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- tpm.c | 4 1 file changed, 4 deletions(-) diff --git a/tpm.c b/tpm.c index 45520f555d..ab5d29e91e 100644 --- a/tpm.c +++ b/tpm.c @@ -30,8 +30,6 @@ void tpm_register_model(enum

[Qemu-devel] [PATCH v2 0/4] tpm: add stubs to fix compiling with --disable-tpm

This fixes building with --disable-tpm as reported by Zoltan: http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05369.html Cc'ing Peter in case this enters as a build fix instead of via trivial. v2: - added Richard W.M. Jones Tested-by tag - remove #ifdef CONFIG_TPM in tpm.c (Stefan Be

Re: [Qemu-devel] [PATCH v2] tpm: Fix compilation with --disable-tpm

"Valluri, Amarnath" wrote: > On Tue, 2017-10-24 at 08:35 +0200, Juan Quintela wrote: >> Commit >>    c37cacabf2285b0731b44c1f667781fdd4f2b658 >> >> broke compilation without tpm.  Just add an #ifdef >> >> CC: Amarnath Valluri >> Signed-off-by: Juan Quintela >> --- >>  tpm.c | 6 +- >>  vl.c

Re: [Qemu-devel] [PATCH] migration, xen: Fix block image lock issue on live migration

On Wed, Oct 04, 2017 at 03:03:49PM +0200, Kevin Wolf wrote: > Am 02.10.2017 um 21:18 hat Dr. David Alan Gilbert geschrieben: > > Adding in kwolf; it looks sane to me; Kevin? > > If I'm reading this right, this is just after the device state save. > > Is this actual migration? Because the code loo

  1   2   >